forest_liana 9.14.0 → 9.14.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 133660170841c0069ffdc0da3e2a4918e4147f417eae55c87b79bb300d9924b0
-  data.tar.gz: eba503c46d489b6f6a4e81f26764f284574db290aed180755c6ca33841fc8b19
+  metadata.gz: a594bcf7830da0f415fbfadfa90d985e46814d07cda6892f317f1834db731ce3
+  data.tar.gz: a565c34a7ef4c7b6e637818963a76b11d772cd716b3eed1db7ffe6b4e8711d2f
 SHA512:
-  metadata.gz: a1b5122e4700ae49500fbfc7b7c1060561e3a73cdfe3c980f946453c54eac0fa0c0982914b2ffcb3a18710d9e5c4fddb0cc7b6a12f18feca424d64067987691d
-  data.tar.gz: 4b4183d21184e1986ca78158f7d6e99aae06ea6767292448ddb1bc29b00f3fe2862000d9c642eb8b8c84e4ce19166778a5fa5e3439cdac1c33e925d2f0ce988f
+  metadata.gz: c12bd80a362e62935a333d6c9b3df3e8bee0618cb29ef3f0a3677d50b4a33b79a66a09e42b38b3ca2a72cb15c2fdef5542d08a4b190f03ce270ed35ce0d951e4
+  data.tar.gz: f0a9ea3a170fff1bab99b583d7c5cc491740ffec9b8f48f6de8eee29bc497c77a7d28db34f49b53e08ee49957a3601c4b37be074a4f2a9a7ee1e427fca5df5a8

data/app/serializers/forest_liana/serializer_factory.rb

@@ -139,10 +139,10 @@ module ForestLiana
 
             next if !should_include_attr?(attribute_name, attr_data)
 
-            unless relation.polymorphic?
+            unless relation.nil? || (relation.respond_to?(:polymorphic?) && relation.polymorphic?)
               relation_class_name = ForestLiana.name_for(relation.klass).demodulize
 
-              if object.send(relation.foreign_key.to_sym) &&
+              if object.respond_to?(relation.foreign_key.to_sym) &&
                 @options[:fields][relation_class_name]&.size == 1 &&
                 @options[:fields][relation_class_name]&.include?(relation.klass.primary_key.to_sym)
 

data/app/services/forest_liana/base_getter.rb

@@ -47,6 +47,8 @@ module ForestLiana
     end
 
     def separate_database?(resource, association)
+      return false if SchemaUtils.polymorphic?(association)
+
       target_model_connection = association.klass.connection
       target_model_database = target_model_connection.current_database if target_model_connection.respond_to? :current_database
       resource_connection = resource.connection

data/app/services/forest_liana/resources_getter.rb

@@ -56,10 +56,22 @@ module ForestLiana
 
     def records
       records = @records.offset(offset).limit(limit).to_a
-
       polymorphic_association, preload_loads = analyze_associations(@resource)
-      if polymorphic_association && Rails::VERSION::MAJOR >= 7
-        # TODO
+
+      if polymorphic_association.any? && Rails::VERSION::MAJOR >= 7
+        preloader = ActiveRecord::Associations::Preloader.new(records: records, associations: polymorphic_association)
+        preloader.loaders
+        preloader.branches.each do |branch|
+          branch.loaders.each do |loader|
+            records_by_owner = loader.records_by_owner
+            records_by_owner.each do |record, association|
+              record_index =  records.find_index { |r| r.id == record.id }
+              records[record_index].define_singleton_method(branch.association) do
+                association.first
+              end
+            end
+          end
+        end
       end
 
       preload_cross_database_associations(records, preload_loads)
@@ -73,7 +85,6 @@ module ForestLiana
         next unless separate_database?(@resource, association)
 
         columns = columns_for_cross_database_association(association_name)
-
         if association.macro == :belongs_to
           foreign_key = association.foreign_key
           primary_key = association.klass.primary_key
@@ -113,27 +124,22 @@ module ForestLiana
     end
 
     def columns_for_cross_database_association(association_name)
-      return [:id] unless @params[:fields].present?
-
-      fields = @params[:fields][association_name.to_s]
-      return [:id] unless fields
-
-      base_fields = fields.split(',').map(&:strip).map(&:to_sym) | [:id]
-
       association = @resource.reflect_on_association(association_name)
-      extra_key = association.foreign_key
 
-      # Add the foreign key used for the association to ensure it's available in the preloaded records
-      # This is necessary for has_one associations, without it calling record.public_send(foreign_key) would raise a "missing attribute" error
-      base_fields << extra_key if association.macro == :has_one
+      # Always include all columns of the associated model to avoid missing attribute errors
+      columns = association.klass.column_names.map(&:to_sym)
 
-      base_fields.uniq
+      # Ensure the foreign key is present for manual binding (especially for has_one)
+      columns << association.foreign_key.to_sym if association.macro == :has_one
+
+      columns.uniq
     end
 
     def compute_includes
       associations_has_one = ForestLiana::QueryHelper.get_one_associations(@resource)
+
       @optional_includes = []
-      if @field_names_requested
+      if @field_names_requested && @params['searchExtended'].to_i != 1
         includes = associations_has_one.map do |association|
           association_name = association.name.to_s
 
@@ -163,7 +169,10 @@ module ForestLiana
 
         @includes = (includes & @field_names_requested).concat(includes_for_smart_search)
       else
-        @includes = associations_has_one.map(&:name)
+        @includes = associations_has_one
+                      # Avoid eager loading has_one associations pointing to a different database as ORM can't join cross databases
+                      .reject { |association| separate_database?(@resource, association) }
+                      .map(&:name)
       end
     end
 

data/app/services/forest_liana/schema_adapter.rb

@@ -278,7 +278,13 @@ module ForestLiana
               field[:field] = association.name
               field[:inverse_of] = inverse_of(association)
               field[:relationship] = get_relationship_type(association)
-          # NOTICE: Create the fields of hasOne, HasMany, … relationships.
+
+              ForestLiana::SchemaUtils.disable_filter_and_sort_if_cross_db!(
+                field,
+                association.name.to_s,
+                ForestLiana.name_for(@model)
+              )
+              # NOTICE: Create the fields of hasOne, HasMany, … relationships.
           else
             collection.fields << get_schema_for_association(association)
           end
@@ -346,7 +352,7 @@ module ForestLiana
     end
 
     def get_schema_for_association(association)
-      {
+      opts ={
         field: association.name.to_s,
         type: get_type_for_association(association),
         relationship: get_relationship_type(association),
@@ -363,6 +369,14 @@ module ForestLiana
         widget: nil,
         validations: []
       }
+
+      ForestLiana::SchemaUtils.disable_filter_and_sort_if_cross_db!(
+        opts,
+        association.name.to_s,
+        ForestLiana.name_for(@model)
+      )
+
+      opts
     end
 
     def get_relationship_type(association)

data/app/services/forest_liana/schema_utils.rb

@@ -126,5 +126,27 @@ module ForestLiana
     def self.is_active_type? model
       Object.const_defined?('ActiveType::Object') && model < ActiveType::Object
     end
+
+    def self.disable_filter_and_sort_if_cross_db!(opts, name, collection_name)
+      return unless opts[:reference]
+
+      assoc_name = opts[:reference].split('.').first&.underscore&.to_sym || name
+      model = find_model_from_collection_name(collection_name)
+      return unless model
+
+      association = model.reflect_on_association(assoc_name)
+      return unless association
+      return if polymorphic?(association)
+
+      model_db = model.connection_db_config.database
+      assoc_db = association.klass.connection_db_config.database
+
+      if model_db != assoc_db
+        opts[:is_filterable] = false
+        opts[:is_sortable] = false
+      end
+    rescue => e
+      FOREST_LOGGER.warn("Could not evaluate cross-db association for #{name}: #{e.message}")
+    end
   end
 end

data/lib/forest_liana/version.rb

@@ -1,3 +1,3 @@
 module ForestLiana
-  VERSION = "9.14.0"
+  VERSION = "9.14.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: forest_liana
 version: !ruby/object:Gem::Version
-  version: 9.14.0
+  version: 9.14.2
 platform: ruby
 authors:
 - Sandro Munda
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-05-26 00:00:00.000000000 Z
+date: 2025-06-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails