forest_liana 8.0.9 → 8.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7da02ba115c9316d358a95b7e7001b92dd50b61e3799aa59d44fe552f62bdd0b
-  data.tar.gz: 43d99d7f3067815e9dd3af8bf26f153e2ff33b5910e892ca3ada77fc00246284
+  metadata.gz: 46e0bf016cde7afdf3a6cc2fc021d2984d649af245e62c3e56262c68b16a00cf
+  data.tar.gz: 22769b1933fd3f95169e33a7f13cec97b463f2e28784691772e817213d29fdc1
 SHA512:
-  metadata.gz: 46ecb0aa4cd2257f62cff46564061b181e41dfac8407f10dec94883a351c5a5ade2372c0dfd6fb92a90e01c3b22e38f4b3a4ad7b67c2364255bdc937c82e326d
-  data.tar.gz: 17c836f951cc37a5a9ab6fe5bd39e78b444451938ab65eedf654274e1c3965cf66b151796d5317481b9267d658badbf19e3ae417d906109914547834dbe10aaf
+  metadata.gz: 41e4b81c03def8ae2cfd17455133ba66e552805a85604b8daf057d468b6d0b96f407ac50f55c01ae2c8de2bc047894084f2357792de2d7cf343ad7f12d51f166
+  data.tar.gz: 7748c16eae78df865130cfdcaec6db0a7605d8e3253167c8d6fd4b6da511930ace227cb4581c1da5021de0b91149bb9c2dc96182757a0e365f9a654f3abfb784

data/config/routes/actions.rb

@@ -0,0 +1,12 @@
+ForestLiana.apimap.each do |collection|
+  if !collection.actions.empty?
+    collection.actions.each do |action|
+      if action.hooks && action.hooks[:load].present?
+        post action.endpoint.sub('forest', '') + '/hooks/load' => 'actions#load', action_name: ActiveSupport::Inflector.parameterize(action.name)
+      end
+      if action.hooks && action.hooks[:change].present?
+        post action.endpoint.sub('forest', '') + '/hooks/change' => 'actions#change', action_name: ActiveSupport::Inflector.parameterize(action.name)
+      end
+    end
+  end
+end

data/config/routes.rb

@@ -59,7 +59,6 @@ ForestLiana::Engine.routes.draw do
   delete ':collection/:id', to: router
   delete ':collection', to: router
 
-  # Smart Actions forms value
-  post 'actions/:action_name/hooks/load' => 'actions#load'
-  post 'actions/:action_name/hooks/change' => 'actions#change'
+  draw(:actions)
+
 end

data/lib/forest_liana/version.rb

@@ -1,3 +1,3 @@
 module ForestLiana
-  VERSION = "8.0.9"
+  VERSION = "8.0.10"
 end

data/spec/dummy/lib/forest_liana/collections/island.rb

@@ -3,5 +3,106 @@ class Forest::Island
 
   collection :Island
 
-  action 'my_action'
+  foo = {
+    field: 'foo',
+    type: 'String',
+    default_value: nil,
+    enums: nil,
+    is_required: false,
+    is_read_only: false,
+    reference: nil,
+    description: nil,
+    widget: nil,
+    hook: 'on_foo_changed'
+  }
+  enum = {
+    field: 'enum',
+    type: 'Enum',
+    enums: %w[a b c],
+  }
+  multiple_enum = {
+    field: 'multipleEnum',
+    type: ['Enum'],
+    enums: %w[a b c],
+  }
+
+  action 'my_action',
+    fields: [foo],
+    hooks: {
+      :load => -> (context) {
+        context[:fields]
+      },
+      :change => {
+        'on_foo_changed' => -> (context) {
+          foo = context[:fields].find{|field| field[:field] == 'foo'}
+          foo[:value] = 'baz'
+          context[:fields]
+        }
+      }
+    }
+
+  action 'fail_action',
+    fields: [foo],
+    hooks: {
+      :load => -> (context) {
+        1
+      },
+      :change => {
+        'on_foo_changed' => -> (context) {
+          1
+        }
+      }
+    }
+
+  action 'cheat_action',
+    fields: [foo],
+    hooks: {
+      :load => -> (context) {
+        {}
+      },
+      :change => {
+        'on_foo_changed' => -> (context) {
+          context[:fields]['baz'] = foo.clone.update({field: 'baz'})
+          context[:fields]
+        }
+      }
+    }
+
+  action 'enums_action',
+    endpoint: 'forest/custom/islands/enums_action',
+    fields: [foo, enum],
+    hooks: {
+      :change => {
+        'on_foo_changed' => -> (context) {
+          fields = context[:fields]
+          enum_field = fields.find{|field| field[:field] == 'enum'}
+          enum_field[:enums] = %w[c d e]
+          fields
+        }
+      }
+    }
+
+  action 'multiple_enums_action',
+    fields: [foo, multiple_enum],
+    hooks: {
+      :change => {
+        'on_foo_changed' => -> (context) {
+          fields = context[:fields]
+          enum_field = fields.find{|field| field[:field] == 'multipleEnum'}
+          enum_field[:enums] = %w[c d z]
+          fields
+        }
+      }
+    }
+
+  action 'use_user_context',
+    fields: [foo],
+    hooks: {
+      :load => -> (context) {
+        foo = context[:fields].find{|field| field[:field] == 'foo'}
+        foo[:value] = context[:user]['first_name']
+        context[:fields]
+      }
+    }
+
 end

data/spec/requests/actions_controller_spec.rb

@@ -39,124 +39,7 @@ describe 'Requesting Actions routes', :type => :request  do
   }
 
   describe 'hooks' do
-    foo = {
-        field: 'foo',
-        type: 'String',
-        default_value: nil,
-        enums: nil,
-        is_required: false,
-        is_read_only: false,
-        reference: nil,
-        description: nil,
-        widget: nil,
-        hook: 'on_foo_changed'
-    }
-    enum = {
-        field: 'enum',
-        type: 'Enum',
-        enums: %w[a b c],
-    }
-    multiple_enum = {
-        field: 'multipleEnum',
-        type: ['Enum'],
-        enums: %w[a b c],
-    }
-
-    action_definition = {
-        name: 'my_action',
-        fields: [foo],
-        hooks: {
-            :load => -> (context) {
-              context[:fields]
-            },
-            :change => {
-              'on_foo_changed' => -> (context) {
-                foo = context[:fields].find{|field| field[:field] == 'foo'}
-                foo[:value] = 'baz'
-                context[:fields]
-              }
-            }
-        }
-    }
-    fail_action_definition = {
-        name: 'fail_action',
-        fields: [foo],
-        hooks: {
-            :load => -> (context) {
-              1
-            },
-            :change => {
-                'on_foo_changed' => -> (context) {
-                  1
-                }
-            }
-        }
-    }
-    cheat_action_definition = {
-        name: 'cheat_action',
-        fields: [foo],
-        hooks: {
-            :load => -> (context) {
-              {}
-            },
-            :change => {
-                'on_foo_changed' => -> (context) {
-                  context[:fields]['baz'] = foo.clone.update({field: 'baz'})
-                  context[:fields]
-                }
-            }
-        }
-    }
-    enums_action_definition = {
-      name: 'enums_action',
-      fields: [foo, enum],
-      hooks: {
-        :change => {
-          'on_foo_changed' => -> (context) {
-            fields = context[:fields]
-            enum_field = fields.find{|field| field[:field] == 'enum'}
-            enum_field[:enums] = %w[c d e]
-            fields
-          }
-        }
-      }
-    }
-
-    multiple_enums_action_definition = {
-        name: 'multiple_enums_action',
-        fields: [foo, multiple_enum],
-        hooks: {
-            :change => {
-                'on_foo_changed' => -> (context) {
-                  fields = context[:fields]
-                  enum_field = fields.find{|field| field[:field] == 'multipleEnum'}
-                  enum_field[:enums] = %w[c d z]
-                  fields
-                }
-            }
-        }
-    }
-
-    use_user_context_action_definition = {
-      name: 'use_user_context',
-      fields: [foo],
-      hooks: {
-        :load => -> (context) {
-          foo = context[:fields].find{|field| field[:field] == 'foo'}
-          foo[:value] = context[:user]['first_name']
-          context[:fields]
-        }
-      }
-    }
-
-    action = ForestLiana::Model::Action.new(action_definition)
-    fail_action = ForestLiana::Model::Action.new(fail_action_definition)
-    cheat_action = ForestLiana::Model::Action.new(cheat_action_definition)
-    enums_action = ForestLiana::Model::Action.new(enums_action_definition)
-    multiple_enums_action = ForestLiana::Model::Action.new(multiple_enums_action_definition)
-    use_user_context_action = ForestLiana::Model::Action.new(use_user_context_action_definition)
     island = ForestLiana.apimap.find {|collection| collection.name.to_s == ForestLiana.name_for(Island)}
-    island.actions = [action, fail_action, cheat_action, enums_action, multiple_enums_action, use_user_context_action]
 
     describe 'call /load' do
       params = {
@@ -167,6 +50,8 @@ describe 'Requesting Actions routes', :type => :request  do
 
       it 'should respond 200' do
         post '/forest/actions/my_action/hooks/load', params: JSON.dump(params), headers: headers
+        action = island.actions.select { |action| action.name == 'my_action' }.first
+        foo = action.fields.select { |field| field[:field] == 'foo' }.first
         expect(response.status).to eq(200)
         expect(JSON.parse(response.body)).to eq({'fields' => [foo.merge({:value => nil}).transform_keys { |key| key.to_s.camelize(:lower) }.stringify_keys]})
       end
@@ -190,26 +75,30 @@ describe 'Requesting Actions routes', :type => :request  do
 
       it 'should return the first_name of the user who call the action' do
         post '/forest/actions/use_user_context/hooks/load', params: JSON.dump(params), headers: headers
+        action = island.actions.select { |action| action.name == 'use_user_context' }.first
+        foo = action.fields.select { |field| field[:field] == 'foo' }.first
         expect(response.status).to eq(200)
         expect(JSON.parse(response.body)).to eq({'fields' => [foo.merge({:value => 'Michael'}).transform_keys { |key| key.to_s.camelize(:lower) }.stringify_keys]})
       end
     end
 
     describe 'call /change' do
-      updated_foo = foo.clone.merge({:previousValue => nil, :value => 'bar'})
-      params = {
-        data: {
-          attributes: {
-            ids: [1],
-            fields: [updated_foo],
-            collection_name: 'Island',
-            changed_field: 'foo',
-            is_read_only: true
+      it 'should respond 200' do
+        action = island.actions.select { |action| action.name == 'my_action' }.first
+        foo = action.fields.select { |field| field[:field] == 'foo' }.first
+        updated_foo = foo.clone.merge({:previousValue => nil, :value => 'bar'})
+        params = {
+          data: {
+            attributes: {
+              ids: [1],
+              fields: [updated_foo],
+              collection_name: 'Island',
+              changed_field: 'foo',
+              is_read_only: true
+            }
           }
         }
-      }
 
-      it 'should respond 200' do
         post '/forest/actions/my_action/hooks/change', params: JSON.dump(params), headers: headers
         expect(response.status).to eq(200)
         expected = updated_foo.clone.merge({:value => 'baz'})
@@ -226,12 +115,31 @@ describe 'Requesting Actions routes', :type => :request  do
       end
 
       it 'should respond 500 with bad hook result type' do
+        action = island.actions.select { |action| action.name == 'fail_action' }.first
+        foo = action.fields.select { |field| field[:field] == 'foo' }.first
+        updated_foo = foo.clone.merge({:previousValue => nil, :value => 'bar'})
+        params = {
+          data: {
+            attributes: {
+              ids: [1],
+              fields: [updated_foo],
+              collection_name: 'Island',
+              changed_field: 'foo',
+              is_read_only: true
+            }
+          }
+        }
+
         post '/forest/actions/fail_action/hooks/change', params: JSON.dump(params), headers: headers
         expect(response.status).to eq(500)
         expect(JSON.parse(response.body)).to eq({'error' => 'Error in smart action load hook: hook must return an array of fields'})
       end
 
       it 'should reset value when enums has changed' do
+        action = island.actions.select { |action| action.name == 'enums_action' }.first
+        foo = action.fields.select { |field| field[:field] == 'foo' }.first
+        enum = action.fields.select { |field| field[:field] == 'enum' }.first
+        updated_foo = foo.clone.merge({:previousValue => nil, :value => 'bar'})
         updated_enum = enum.clone.merge({:previousValue => nil, :value => 'a'}) # set value to a
         p = {
           data: {
@@ -243,7 +151,8 @@ describe 'Requesting Actions routes', :type => :request  do
             }
           }
         }
-        post '/forest/actions/enums_action/hooks/change', params: JSON.dump(p), headers: headers
+
+        post '/forest/custom/islands/enums_action/hooks/change', params: JSON.dump(p), headers: headers
         expect(response.status).to eq(200)
 
         expected_enum = updated_enum.clone.merge({ :enums => %w[c d e], :value => nil, :widgetEdit => nil})
@@ -258,6 +167,9 @@ describe 'Requesting Actions routes', :type => :request  do
       end
 
       it 'should not reset value when every enum values are in the enums definition' do
+        action = island.actions.select { |action| action.name == 'multiple_enums_action' }.first
+        foo = action.fields.select { |field| field[:field] == 'foo' }.first
+        multiple_enum = action.fields.select { |field| field[:field] == 'multipleEnum' }.first
         updated_multiple_enum = multiple_enum.clone.merge({:previousValue => nil, :value => %w[c]})
         p = {
           data: {
@@ -284,6 +196,9 @@ describe 'Requesting Actions routes', :type => :request  do
       end
 
       it 'should reset value when one of the enum values is not in the enums definition' do
+        action = island.actions.select { |action| action.name == 'multiple_enums_action' }.first
+        foo = action.fields.select { |field| field[:field] == 'foo' }.first
+        multiple_enum = action.fields.select { |field| field[:field] == 'multipleEnum' }.first
         wrongly_updated_multiple_enum = multiple_enum.clone.merge({:previousValue => nil, :value => %w[a b]})
         p = {
           data: {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: forest_liana
 version: !ruby/object:Gem::Version
-  version: 8.0.9
+  version: 8.0.10
 platform: ruby
 authors:
 - Sandro Munda
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-06-13 00:00:00.000000000 Z
+date: 2023-06-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -326,6 +326,7 @@ files:
 - config/initializers/logger.rb
 - config/initializers/time_formats.rb
 - config/routes.rb
+- config/routes/actions.rb
 - lib/forest_liana.rb
 - lib/forest_liana/base64_string_io.rb
 - lib/forest_liana/bootstrapper.rb