forest_liana 8.0.14 → 8.0.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e58456aa931649225eed7877b806e8f46e38aff513b4bd1d47ed4ca6d1a7c4e2
-  data.tar.gz: e29ceefbdda9bc4d9dd1eee4daf32a10093bc1f3e8a3e6c809b5e5aa4283c35e
+  metadata.gz: d66f322c9f51d6beebaa2eb338b8f568f7d12bc781d71c4b47a8c2c3e6503c73
+  data.tar.gz: 37db17c392bac96b35c43595c03ef702e840ae40e420538151d36edc2a347c68
 SHA512:
-  metadata.gz: 1865aee0aee41357c69048badaa0b7372a93b503d45fc7ee2c0c752960230403b332239aa9633b501ed73d5237b57d651deee4b59f52a678c9f41925c6f91670
-  data.tar.gz: 24067eabbacc781a120caa9606335f6d9c18ca6564ddd7e71424ae6cca8d6afa32b02f0cf35805e3bc987ffb14fe26284bce5d53aef11829018898e903bb0db9
+  metadata.gz: 9466f6b82dc0ffbfae007bfc0024e5b831172dacdffcf00e51c58a8ca2333dbbefb165227a3d36b704954b1cdb75ecdfb9a5f2605840572220e612226e6cb39d
+  data.tar.gz: 5c313811aead7c0617d1e5d5d9c424f66e56b0482a46dc8354a1714b59f61490a728cc1cacb9224553110b0577b68712ba62366e8b214d6c7bddb2daffde4c7d

data/app/controllers/forest_liana/application_controller.rb

@@ -4,6 +4,7 @@ require 'csv'
 module ForestLiana
   class ApplicationController < ForestLiana::BaseController
     rescue_from ForestLiana::Ability::Exceptions::AccessDenied, with: :render_error
+    rescue_from ForestLiana::Errors::HTTP403Error, with: :render_error
     rescue_from ForestLiana::Errors::HTTP422Error, with: :render_error
 
     def self.papertrail?

data/app/controllers/forest_liana/authentication_controller.rb

@@ -39,6 +39,8 @@ module ForestLiana
     end
 
     def authentication_callback
+      return authentication_exception if params.key?(:error)
+
       begin
         token = @authentication_service.verify_code_and_generate_token(params)
 
@@ -55,6 +57,21 @@ module ForestLiana
       end
     end
 
+    def authentication_exception
+      begin
+        raise ForestLiana::Errors::AuthenticationOpenIdClientException.new(params[:error], params[:error_description], params[:state])
+      rescue => error
+        FOREST_REPORTER.report error
+        FOREST_LOGGER.error "AuthenticationOpenIdClientException: #{error.error_description}"
+
+        render json: {
+          error: error.error,
+          error_description: error.error_description,
+          state: error.state
+        }, status: :unauthorized
+      end
+    end
+
     def logout
       begin
         if cookies.has_key?(:forest_session_token)

data/app/services/forest_liana/ability/fetch.rb

@@ -2,20 +2,12 @@ module ForestLiana
   module Ability
     module Fetch
       def get_permissions(route)
-        begin
-          response = ForestLiana::ForestApiRequester.get(route)
+        response = ForestLiana::ForestApiRequester.get(route)
 
-          if response.is_a?(Net::HTTPOK)
-            JSON.parse(response.body)
-          else
-            raise "Forest API returned an #{ForestLiana::Errors::HTTPErrorHelper.format(response)}"
-          end
-        rescue => exception
-          FOREST_REPORTER.report exception
-          FOREST_LOGGER.error 'Cannot retrieve the permissions from the Forest server.'
-          FOREST_LOGGER.error 'Which was caused by:'
-          ForestLiana::Errors::ExceptionHelper.recursively_print(exception, margin: ' ', is_error: true)
-          nil
+        if response.is_a?(Net::HTTPOK)
+          JSON.parse(response.body)
+        else
+          raise ForestLiana::Errors::HTTP403Error.new("Permission could not be retrieved")
         end
       end
     end

data/app/services/forest_liana/ability/permission.rb

@@ -6,7 +6,7 @@ module ForestLiana
     module Permission
       include Fetch
 
-      TTL = (ENV['FOREST_PERMISSIONS_EXPIRATION_IN_SECONDS'] || 1).to_i.second
+      TTL = (ENV['FOREST_PERMISSIONS_EXPIRATION_IN_SECONDS'] || 900).to_i.second
 
       def is_crud_authorized?(action, user, collection)
         return true unless has_permission_system?

data/app/services/forest_liana/authentication.rb

@@ -38,8 +38,6 @@ module ForestLiana
         raise ForestLiana::MESSAGES[:SERVER_TRANSACTION][:INVALID_STATE_MISSING]
       end
 
-      rendering_id = nil
-
       begin
         parsed_state = JSON.parse(state.gsub("'",'"').gsub('=>',':'))
         rendering_id = parsed_state["renderingId"].to_s

data/config/initializers/errors.rb

@@ -30,6 +30,17 @@ module ForestLiana
       end
     end
 
+    class AuthenticationOpenIdClientException < StandardError
+      attr_reader :error, :error_description, :state
+
+      def initialize(error, error_description, state)
+        super(error_description)
+        @error = error
+        @error_description = error_description
+        @state = state
+      end
+    end
+
     class ExpectedError < StandardError
       attr_reader :error_code, :status, :message, :name
 

data/lib/forest_liana/version.rb

@@ -1,3 +1,3 @@
 module ForestLiana
-  VERSION = "8.0.14"
+  VERSION = "8.0.16"
 end

data/spec/requests/authentications_spec.rb

@@ -44,44 +44,66 @@ describe "Authentications", type: :request do
   end
 
   describe "GET /authentication/callback" do
-    before() do
-      response = '{"data":{"id":666,"attributes":{"first_name":"Alice","last_name":"Doe","email":"alice@forestadmin.com","teams":[1,2,3],"role":"Test","tags":[{"key":"city","value":"Paris"}]}}}'
-      allow(ForestLiana::ForestApiRequester).to receive(:get).with(
-        "/liana/v2/renderings/42/authorization", { :headers => { "forest-token" => "THE-ACCESS-TOKEN" }, :query => {} }
-      ).and_return(
-        instance_double(HTTParty::Response, :body => response, :code => 200)
-      )
-
-      get ForestLiana::Engine.routes.url_helpers.authentication_callback_path + "?code=THE-CODE&state=#{CGI::escape('{"renderingId":42}')}"
-    end
+    context 'when the response is a 200' do
+      before() do
+        response = '{"data":{"id":666,"attributes":{"first_name":"Alice","last_name":"Doe","email":"alice@forestadmin.com","teams":[1,2,3],"role":"Test","tags":[{"key":"city","value":"Paris"}]}}}'
+        allow(ForestLiana::ForestApiRequester).to receive(:get).with(
+          "/liana/v2/renderings/42/authorization", { :headers => { "forest-token" => "THE-ACCESS-TOKEN" }, :query => {} }
+        ).and_return(
+          instance_double(HTTParty::Response, :body => response, :code => 200)
+        )
 
-    it "should respond with a 200 code" do
-      expect(response).to have_http_status(200)
-    end
+        get ForestLiana::Engine.routes.url_helpers.authentication_callback_path + "?code=THE-CODE&state=#{CGI::escape('{"renderingId":42}')}"
+      end
 
-    it "should return a valid authentication token" do
-      body = JSON.parse(response.body, :symbolize_names => true);
+      it "should respond with a 200 code" do
+        expect(response).to have_http_status(200)
+      end
 
-      token = body[:token]
-      decoded = JWT.decode(token, ForestLiana.auth_secret, true, { algorithm: 'HS256' })[0]
+      it "should return a valid authentication token" do
+        body = JSON.parse(response.body, :symbolize_names => true);
 
-      expected_token_data = {
-        "id" => 666,
-        "email" => 'alice@forestadmin.com',
-        "rendering_id" => "42",
-        "first_name" => 'Alice',
-        "last_name" => 'Doe',
-        "team" => 1,
-        "role" => "Test",
-      }
+        token = body[:token]
+        decoded = JWT.decode(token, ForestLiana.auth_secret, true, { algorithm: 'HS256' })[0]
 
-      expect(decoded).to include(expected_token_data)
-      tags = decoded['tags']
-      expect(tags.length).to eq(1)
-      expect(tags[0]['key']).to eq("city")
-      expect(tags[0]['value']).to eq("Paris")
-      expect(body).to eq({ token: token, tokenData: decoded.deep_symbolize_keys! })
-      expect(response).to have_http_status(200)
+        expected_token_data = {
+          "id" => 666,
+          "email" => 'alice@forestadmin.com',
+          "rendering_id" => "42",
+          "first_name" => 'Alice',
+          "last_name" => 'Doe',
+          "team" => 1,
+          "role" => "Test",
+        }
+
+        expect(decoded).to include(expected_token_data)
+        tags = decoded['tags']
+        expect(tags.length).to eq(1)
+        expect(tags[0]['key']).to eq("city")
+        expect(tags[0]['value']).to eq("Paris")
+        expect(body).to eq({ token: token, tokenData: decoded.deep_symbolize_keys! })
+        expect(response).to have_http_status(200)
+      end
+    end
+
+    context 'when the response is not a 200' do
+      before() do
+        get ForestLiana::Engine.routes.url_helpers.authentication_callback_path,
+          params: {
+            error: 'TrialBlockedError',
+            error_description: 'Your free trial has ended. We hope you enjoyed your experience with Forest Admin.',
+            state: '{"renderingId":100}'
+          },
+          headers: {
+            'Accept' => 'application/json',
+            'Content-Type' => 'application/json',
+          }
+      end
+
+      it "should respond with a 401 code" do
+        expect(response).to have_http_status(401)
+        expect(response.body).to eq('{"error":"TrialBlockedError","error_description":"Your free trial has ended. We hope you enjoyed your experience with Forest Admin.","state":"{\"renderingId\":100}"}')
+      end
     end
   end
 

data/spec/services/forest_liana/ability/permission_spec.rb

@@ -327,6 +327,17 @@ module ForestLiana
           expect {dummy_class.is_smart_action_authorized?(user, String, parameters, '/forest/actions/my_action', 'POST')}.to raise_error(ForestLiana::Errors::ExpectedError, 'The collection String doesn\'t exist')
         end
       end
+
+      describe 'when the server doesn\'t return an success response' do
+        before do
+          Rails.cache.clear
+        end
+
+        it 'should return an exception' do
+          allow(ForestLiana::ForestApiRequester).to receive(:get).and_return(instance_double(HTTParty::Response, code: 500, body: nil))
+          expect { dummy_class.is_crud_authorized?('browse', user, Island.first) }.to raise_error(ForestLiana::Errors::HTTP403Error, 'Permission could not be retrieved')
+        end
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: forest_liana
 version: !ruby/object:Gem::Version
-  version: 8.0.14
+  version: 8.0.16
 platform: ruby
 authors:
 - Sandro Munda
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-10-16 00:00:00.000000000 Z
+date: 2023-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails