forest_admin_datasource_active_record 1.40.0 → 1.40.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 900ccccbc0c8a7ae95c5eee13a67dca16bbad7add14ac849381a95246878393d
-  data.tar.gz: 7fb49021e33e83ed9cb8e01a39a813b4e261fae73e8d6d32e936092f843e7aad
+  metadata.gz: b924a7fc6ab865fa83285d4dc554e0d2124b26c2b998d6c06c3dcfcd357d313d
+  data.tar.gz: dfd941d070ddb69f934b43db627d83ed0dac8af12fcf3dbf5f6594bdfaae617d
 SHA512:
-  metadata.gz: dcda7837f4a0d0b6658c10ae3245d9e31ab3933d7302b414e7560716f1cf6ccfb261f4ccc1e93dac131384cfb927cca9b5cb412c6ebace19cff563b24398d67b
-  data.tar.gz: 43d723551915aace679d91971d5264f70e91f2adbd4a5bde9bc153884a69364292d5fbb7d33e2584794ca5f7009358ee783cdf930b2521035e5ef12e31b70f63
+  metadata.gz: 13177d23d5702e9a93d282e09c213c8b99fb2d5ba47828712e3fc67b84a198e67bf65848af806ce58f084c8465bda80ad282c29da73b0413a3e50aac6b38bf0c
+  data.tar.gz: 297df24c7a0e70780552f7f0b4712860171930f57cce1c0a7a602732e73ace9ce187e41dde2e8e9048c5796c7674b8a23dd077895bcb05b64cdb96de6e4bc456

data/lib/forest_admin_datasource_active_record/collection.rb

@@ -114,6 +114,15 @@ module ForestAdminDatasourceActiveRecord
       association.source_reflection&.belongs_to?
     end
 
+    # Same criterion as unrepresentable_many_to_many?: a composite primary key can arrive as a
+    # real Array or already flattened by Rails into a mangled String -- checking column
+    # membership catches both forms, plus a custom primary_key pointing at a non-column, all of
+    # which would otherwise hit nil.column_type in build_one_to_one_schema (#379).
+    def unrepresentable_one_to_one?(association)
+      !association.klass.column_names.include?(association.klass.primary_key) ||
+        !@model.column_names.include?(@model.primary_key)
+    end
+
     def build_many_to_many_field(association, through_reflection, is_polymorphic, source_polymorphic)
       ForestAdminDatasourceToolkit::Schema::Relations::ManyToManySchema.new(
         foreign_collection: format_model_name(association.klass.name),
@@ -157,15 +166,19 @@ module ForestAdminDatasourceActiveRecord
 
               if many_to_many_shape
                 add_many_to_many_field(association, through_reflection, is_polymorphic, source_polymorphic)
+              elsif unrepresentable_one_to_one?(association)
+                warn_unrepresentable_one_to_one(association, through_reflection)
               else
                 add_field(
                   association.name.to_s,
                   ForestAdminDatasourceToolkit::Schema::Relations::OneToOneSchema.new(
                     foreign_collection: format_model_name(association.klass.name),
                     origin_key: association.klass.primary_key,
-                    origin_key_target: @model.primary_key
+                    origin_key_target: @model.primary_key,
+                    is_read_only: true
                   )
                 )
+                warn_readonly_identity_join(association, through_reflection)
               end
             elsif association.inverse_of&.polymorphic?
               add_field(
@@ -362,6 +375,33 @@ module ForestAdminDatasourceActiveRecord
       )
     end
 
+    def warn_unrepresentable_one_to_one(association, through_reflection)
+      logger = ActiveSupport::Logger.new($stdout)
+      logger.warn(
+        "[ForestAdmin] ⚠️  Skipping association '#{association.name}' in model '#{@model.name}': " \
+        "this has_one :through (via '#{format_model_name(through_reflection.klass.name)}') can't be " \
+        'represented as a Forest Admin one-to-one -- one of its endpoints has a composite primary key.'
+      )
+    end
+
+    # OneToOneSchema has no through_collection, so this publishes each side's own primary key
+    # as a placeholder join -- the columns exist on both sides, so GeneratorField's field
+    # lookups don't raise, but the join isn't meaningful data (it matches two unrelated
+    # sequences), which is exactly why it's marked read-only rather than left writable through
+    # what's really the foreign collection's own primary key (#379).
+    def warn_readonly_identity_join(association, through_reflection)
+      logger = ActiveSupport::Logger.new($stdout)
+      foreign_key = association.klass.primary_key
+      origin_key = @model.primary_key
+      logger.warn(
+        "[ForestAdmin] ⚠️  Association '#{association.name}' in model '#{@model.name}' is published " \
+        "as a read-only one-to-one joining '#{format_model_name(association.klass.name)}'.'#{foreign_key}' " \
+        "to this model's own '#{origin_key}': it's a has_one chained through " \
+        "'#{format_model_name(through_reflection.klass.name)}', which OneToOneSchema can't express as a " \
+        'real two-hop join -- see #379 for background.'
+      )
+    end
+
     def warn_missing_polymorphic_columns(association)
       missing_columns = []
       missing_columns << association.foreign_key unless schema[:fields][association.foreign_key]

data/lib/forest_admin_datasource_active_record/version.rb

@@ -1,3 +1,3 @@
 module ForestAdminDatasourceActiveRecord
-  VERSION = "1.40.0"
+  VERSION = "1.40.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: forest_admin_datasource_active_record
 version: !ruby/object:Gem::Version
-  version: 1.40.0
+  version: 1.40.1
 platform: ruby
 authors:
 - Matthieu
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-08-27 00:00:00.000000000 Z
+date: 2026-08-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord