forest_admin_agent 1.47.0 → 1.48.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 24a29d40927535f076eb8353abd44e1825a64324e102944c250ac882c01a3dcb
-  data.tar.gz: 2b43060825da0b2fca90393f0b65fa93bc3933e7f410553b8b33d230c1a96ca1
+  metadata.gz: 32e0f7c27c7dea94a2edc46e7fd3fb938e2ec986d4684fd28d9544eb0b3acc93
+  data.tar.gz: ee4246b8d69882a1ab72c72a5ae9208382da9d71e740eba74a109c76492cff5c
 SHA512:
-  metadata.gz: e77e3892dcf0a456a89a1d5199e1f582f33187f64d9c197df556a6fe3c4560adfc10a09e38670cb049e9630820efcf205e5d01165d4335ef0877165624efb848
-  data.tar.gz: a3ab87f07b033727407a2b4979c8f62c1d8e50c3761cc95224d09efd205119f4a0811a61b1b56dc6bccc9a28816c63104a5f8d4e6a5b8617bd16305a3a5f8a38
+  metadata.gz: bb1d2f2761640a61484a7943a490d4149b3616eafcab69cbff6a713d4ff842965ccc8f1f44be3fbcea715b5e36230f79480fcfa5cc384302bddce74cd5bc4f46
+  data.tar.gz: 23673caf7138deb825471449efca08581aaf4d923b69e18d71238795d773c3a8b59bfcae47ec93ceac278b9e907c3a35f34c26aec6dc9c7733e857ca61b5f63c

data/AUDIT_TRAIL.md

@@ -340,6 +340,11 @@ the store. A missing `collection` or `recordId` returns **HTTP 400** (`Validatio
 
 ## Smart actions
 
+Writes a smart action makes through Forest (`context.collection` or `context.datasource.get_collection(...)`
+`create` / `update` / `delete`) are audited like any other write, under the same `correlationKey` as the
+action: the audit hooks sit on an internal layer below smart actions. Writes that bypass Forest (raw SQL, a
+direct ActiveRecord call, an external API) only show up through the action row below.
+
 Running a smart action writes one row per selected record, in the same table:
 
 | column           | value                                                                      |

data/lib/forest_admin_agent/audit_trail/capture.rb

@@ -43,19 +43,18 @@ module ForestAdminAgent
         add_delete_hooks(collection_customizer, target)
       end
 
-      # The "after" hooks are prepended: `execute_after` stops at the first exception, so a customization
-      # raising in its own after hook would otherwise drop the record of a write that already happened.
-      # The "before" hooks stay appended, so they read the data, filter and patch every other customization
-      # has had its say on.
+      # Hooks sit on the internal layer, below smart actions, so writes made from an action's `execute` are
+      # audited too. The "after" hooks are prepended: `execute_after` stops at the first exception, so another
+      # internal hook raising would otherwise drop the record of a write that already happened.
       def add_create_hooks(collection_customizer, target)
-        collection_customizer.add_hook('Before', 'Create') do |context|
+        collection_customizer.add_internal_hook('Before', 'Create') do |context|
           # No record id yet — that is what the column being nullable is for.
           rows = [{ record_id: nil, new_values: pick(context.data, target[:columns]) }]
 
           @snapshots.push(context.data, ids: pending_rows(context.caller, 'create', target[:name], rows))
         end
 
-        collection_customizer.add_hook('After', 'Create', prepend: true) do |context|
+        collection_customizer.add_internal_hook('After', 'Create', prepend: true) do |context|
           pending = @snapshots.pop_for(context.data)
           next unless pending
 
@@ -66,7 +65,7 @@ module ForestAdminAgent
       end
 
       def add_update_hooks(collection_customizer, target)
-        collection_customizer.add_hook('Before', 'Update') do |context|
+        collection_customizer.add_internal_hook('Before', 'Update') do |context|
           records = @snapshots.take(context, target[:projection])
           @snapshots.push(
             context.filter,
@@ -83,7 +82,7 @@ module ForestAdminAgent
           )
         end
 
-        collection_customizer.add_hook('After', 'Update', prepend: true) do |context|
+        collection_customizer.add_internal_hook('After', 'Update', prepend: true) do |context|
           pending = @snapshots.pop_for(context.filter)
           next unless pending
 
@@ -92,7 +91,7 @@ module ForestAdminAgent
       end
 
       def add_delete_hooks(collection_customizer, target)
-        collection_customizer.add_hook('Before', 'Delete') do |context|
+        collection_customizer.add_internal_hook('Before', 'Delete') do |context|
           records = @snapshots.take(context, target[:projection])
           @snapshots.push(
             context.filter,
@@ -107,7 +106,7 @@ module ForestAdminAgent
           )
         end
 
-        collection_customizer.add_hook('After', 'Delete', prepend: true) do |context|
+        collection_customizer.add_internal_hook('After', 'Delete', prepend: true) do |context|
           pending = @snapshots.pop_for(context.filter)
           next unless pending
 

data/lib/forest_admin_agent/utils/schema/schema_emitter.rb

@@ -6,7 +6,7 @@ module ForestAdminAgent
     module Schema
       class SchemaEmitter
         LIANA_NAME = "agent-ruby"
-        LIANA_VERSION = "1.47.0"
+        LIANA_VERSION = "1.48.0"
 
         def self.generate(datasource)
           datasource.collections

data/lib/forest_admin_agent/version.rb

@@ -1,3 +1,3 @@
 module ForestAdminAgent
-  VERSION = "1.47.0"
+  VERSION = "1.48.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: forest_admin_agent
 version: !ruby/object:Gem::Version
-  version: 1.47.0
+  version: 1.48.0
 platform: ruby
 authors:
 - Matthieu