forest_admin_agent 1.39.4 → 1.40.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 70619859806c445a79898fd7c0ccc1d8584d1d32441b2b41d9a955577effaf70
-  data.tar.gz: 9aec675836fe8747de7d4a52ce392e0df50593c6b30dffa86d0c28349a142bcb
+  metadata.gz: 41424b4c16e2ad72007fc04077d6ba6eaaac2cb39e664a7bf45ca081ea3cd48f
+  data.tar.gz: 3436faf494fa9b564bddcdd218bc3e86d40e7d017ed3abeb232ff3cd2086b96f
 SHA512:
-  metadata.gz: b4d575fee79985367b338dcda0e3d646ce32e119ada6db4370acb4a402e11824330732160e4636d96c3cdf91704e6fc8e216082ac4ee091300325a61d6465853
-  data.tar.gz: b48ea6b3ac88d37052c9bfb04d26e3179ef4182c96dce7df018847fab099971e83d3a9630d6c77430a738b273bac27571f2d03fe88f719b6a92e04b303697599
+  metadata.gz: b04f5cd5d017f5dc76cadf4277a7a6b7a940298d95db23a3e31a8f15b70b3964506f56861a82b18300c2c785e3d2ecef3e70c75c5f62d71d2c7ae4fe79e011f5
+  data.tar.gz: 77f78657ad7eac790127770d7ad4af2d98cdf4477882c882fab27779799e65c6f72ee7edb6adacf3673e2768153415935fd9c7060e03914e0cf8fec647a23b73

data/lib/forest_admin_agent/routes/resources/related/associate_related.rb

@@ -28,6 +28,7 @@ module ForestAdminAgent
             target_primary_key_values = Utils::Id.unpack_id(context.child_collection, args[:params]['data'][0]['id'],
                                                             with_key: true)
             relation = Schema.get_to_many_relation(context.collection, args[:params]['relation_name'])
+            Collection.assert_writable_relation!(args[:params]['relation_name'], relation)
 
             case relation.type
             when 'OneToMany'

data/lib/forest_admin_agent/routes/resources/related/dissociate_related.rb

@@ -34,6 +34,7 @@ module ForestAdminAgent
 
             filter = get_base_foreign_filter(args, context)
             relation = Schema.get_to_many_relation(context.collection, args[:params]['relation_name'])
+            Collection.assert_writable_relation!(args[:params]['relation_name'], relation)
 
             relation_name = args[:params]['relation_name']
             options = {

data/lib/forest_admin_agent/routes/resources/related/update_related.rb

@@ -28,6 +28,11 @@ module ForestAdminAgent
             # Must run before unpack_id: unauthorized callers get a 403, not a validation error
             context.permissions.can?(:edit, mutated_collection(relation, context))
 
+            # Every relation type this route writes through can be read-only (#379's
+            # OneToOne identity join is the reason this exists, but the flag itself sits on
+            # the shared RelationSchema, so enforce it once here rather than per-branch).
+            Collection.assert_writable_relation!(args[:params]['relation_name'], relation)
+
             parent_primary_key_values = Utils::Id.unpack_id(context.collection, args[:params]['id'])
 
             linked_primary_key_values = if (id = args.dig(:params, 'data', 'id'))

data/lib/forest_admin_agent/routes/resources/store.rb

@@ -67,6 +67,8 @@ module ForestAdminAgent
           id = value.dig('data', 'id')
           return if id.nil?
 
+          ForestAdminDatasourceToolkit::Utils::Collection.assert_writable_relation!(field, schema)
+
           {
             schema: schema,
             foreign_collection: context.datasource.get_collection(schema.foreign_collection),

data/lib/forest_admin_agent/services/permissions.rb

@@ -201,7 +201,8 @@ module ForestAdminAgent
         smart_action_approval = SmartActionChecker.new(
           request[:params],
           collection,
-          collection_actions[action['name'].to_sym],
+          # The schema scope lets the checker skip select-all resolution for global actions.
+          collection_actions[action['name'].to_sym].merge(scope: collection.schema[:actions][action['name']]&.scope),
           caller,
           user_data[:roleId],
           filter

data/lib/forest_admin_agent/services/smart_action_checker.rb

@@ -20,12 +20,24 @@ module ForestAdminAgent
       end
     end
 
+    class ApprovalSelectionTooLargeError < UnprocessableError
+      def initialize(max)
+        super(
+          "This action requires approval and cannot be triggered on more than #{max} records at once. " \
+          'Please refine your selection.'
+        )
+      end
+    end
+
     class SmartActionChecker
       include ForestAdminAgent::Utils
       include ForestAdminDatasourceToolkit::Utils
       include ForestAdminDatasourceToolkit::Components::Query
       include ForestAdminDatasourceToolkit::Components::Query::ConditionTree
 
+      # The Forest server's cap on approval record ids; max_records_for_approval may only lower it.
+      MAX_RECORDS_FOR_APPROVAL = 500
+
       attr_reader :parameters, :collection, :smart_action, :caller, :role_id, :filter, :attributes
 
       def initialize(parameters, collection, smart_action, caller, role_id, filter)
@@ -66,9 +78,19 @@ module ForestAdminAgent
           end
         elsif smart_action[:approvalRequired].include?(role_id) && smart_action[:triggerEnabled].include?(role_id)
           if condition_by_role_id(smart_action[:approvalRequiredConditions]).nil? || match_conditions(:approvalRequiredConditions)
+            # Global actions target no specific records — never resolve.
+            if attributes[:all_records] && smart_action[:scope] != ForestAdminDatasourceCustomizer::Decorators::Action::Types::ActionScope::GLOBAL
+              record_ids = resolve_select_all_record_ids
+            end
+
             raise CustomActionRequiresApprovalError.new(
               'This action requires to be approved.',
-              details: { user_approval_enabled: smart_action[:userApprovalEnabled] }
+              details: {
+                user_approval_enabled: smart_action[:userApprovalEnabled],
+                # camelCase: sent verbatim in the error data, the key the frontend reads.
+                roleIdsAllowedToApprove: smart_action[:userApprovalEnabled],
+                **(record_ids ? { recordIds: record_ids } : {})
+              }
             )
           elsif condition_by_role_id(smart_action[:triggerConditions]).nil? || match_conditions(:triggerConditions)
             return true
@@ -78,6 +100,27 @@ module ForestAdminAgent
         raise CustomActionTriggerForbiddenError, 'You don\'t have the permission to trigger this action.'
       end
 
+      # Fetching cap+1 distinguishes "over the cap" from "exactly the cap".
+      def resolve_select_all_record_ids
+        configured = ForestAdminAgent::Facades::Container.config_from_cache[:max_records_for_approval]
+        # Anything but a positive Integer gets the default (a negative LIMIT means unlimited on
+        # some datasources, and a String would raise on comparison).
+        max = if configured.is_a?(Integer) && configured.positive?
+                [configured, MAX_RECORDS_FOR_APPROVAL].min
+              else
+                MAX_RECORDS_FOR_APPROVAL
+              end
+        records = collection.list(
+          caller,
+          filter.override(page: Page.new(offset: 0, limit: max + 1)),
+          Projection.new.with_pks(collection)
+        )
+
+        raise ApprovalSelectionTooLargeError, max if records.size > max
+
+        Utils::Id.pack_ids(collection, records)
+      end
+
       def match_conditions(condition_name)
         pks = Schema.primary_keys(collection)
 

data/lib/forest_admin_agent/utils/schema/generator_field.rb

@@ -127,7 +127,7 @@ module ForestAdminAgent
                 isFilterable: foreign_collection_filterable?(foreign_collection),
                 isPrimaryKey: false,
                 isRequired: false,
-                isReadOnly: key_field.is_read_only,
+                isReadOnly: relation.is_read_only || key_field.is_read_only,
                 isSortable: target_field.is_sortable,
                 validations: [],
                 reference: "#{foreign_collection.name}.#{relation.origin_key_target}"

data/lib/forest_admin_agent/utils/schema/schema_emitter.rb

@@ -6,7 +6,7 @@ module ForestAdminAgent
     module Schema
       class SchemaEmitter
         LIANA_NAME = "agent-ruby"
-        LIANA_VERSION = "1.39.4"
+        LIANA_VERSION = "1.40.1"
 
         def self.generate(datasource)
           datasource.collections

data/lib/forest_admin_agent/version.rb

@@ -1,3 +1,3 @@
 module ForestAdminAgent
-  VERSION = "1.39.4"
+  VERSION = "1.40.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: forest_admin_agent
 version: !ruby/object:Gem::Version
-  version: 1.39.4
+  version: 1.40.1
 platform: ruby
 authors:
 - Matthieu
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-08-26 00:00:00.000000000 Z
+date: 2026-08-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport