foreman_wreckingball 4.0.0 → 5.0.0

data/test/actions/foreman_wreckingball/host/refresh_vmware_facet_test.rb

@@ -13,17 +13,16 @@ module Actions
 
         setup do
           ::Fog.mock!
-          ::ForemanWreckingball.fog_vsphere_namespace::Mock.any_instance.stubs(:get_vm_ref).returns(vm)
-          ::ForemanWreckingball.fog_vsphere_namespace::Server.any_instance.stubs(:ready?).returns(false)
+          Fog::Vsphere::Compute::Mock.any_instance.stubs(:get_vm_ref).returns(vm)
+          Fog::Vsphere::Compute::Server.any_instance.stubs(:ready?).returns(false)
           ::ForemanWreckingball::SpectreV2Status.any_instance.stubs(:recent_hw_version?).returns(true)
           # this is not stubbed correctly in fog-vsphere
-          ::ForemanWreckingball.fog_vsphere_namespace::Server.any_instance.stubs(:cpuHotAddEnabled).returns(false)
-          Setting::Wreckingball.load_defaults
+          Fog::Vsphere::Compute::Server.any_instance.stubs(:cpuHotAddEnabled).returns(false)
         end
         teardown { ::Fog.unmock! }
 
         let(:compute_resource) do
-          cr = FactoryBot.create(:compute_resource, :vmware, :with_taxonomy, :uuid => 'Solutions')
+          cr = FactoryBot.create(:compute_resource, :vmware, :with_taxonomy, uuid: 'Solutions')
           ComputeResource.find(cr.id)
         end
 
@@ -35,7 +34,7 @@ module Actions
             compute_resource: compute_resource,
             uuid: uuid
           ).tap do |host|
-            host.vmware_facet.update_attribute(:guest_id, 'asianux4_64Guest')
+            host.vmware_facet.update_attribute(:guest_id, 'asianux4_64Guest') # rubocop:disable Rails/SkipsModelValidations
           end
         end
 
@@ -45,7 +44,7 @@ module Actions
             action.stubs(:action_subject).returns(host)
             action.input.update(
               host: {
-                id: host.id
+                id: host.id,
               }
             )
           end

data/test/actions/foreman_wreckingball/host/remediate_hardware_version_test.rb

@@ -10,16 +10,15 @@ module Actions
         setup do
           ::Fog.mock!
           # this is not stubbed correctly in fog-vsphere
-          ::ForemanWreckingball.fog_vsphere_namespace::Server.any_instance.stubs(:cpuHotAddEnabled).returns(false)
-          ::ForemanWreckingball.fog_vsphere_namespace::Server.any_instance.stubs(:hardware_version).returns('vmx-13')
+          Fog::Vsphere::Compute::Server.any_instance.stubs(:cpuHotAddEnabled).returns(false)
+          Fog::Vsphere::Compute::Server.any_instance.stubs(:hardware_version).returns('vmx-13')
           ::ForemanWreckingball::SpectreV2Status.any_instance.stubs(:recent_hw_version?).returns(true)
           ::PowerManager::Virt.any_instance.stubs(:ready?).returns(true)
-          Setting::Wreckingball.load_defaults
         end
         teardown { ::Fog.unmock! }
 
         let(:compute_resource) do
-          cr = FactoryBot.create(:compute_resource, :vmware, :with_taxonomy, :uuid => 'Solutions')
+          cr = FactoryBot.create(:compute_resource, :vmware, :with_taxonomy, uuid: 'Solutions')
           ComputeResource.find(cr.id)
         end
         let(:uuid) { '5032c8a5-9c5e-ba7a-3804-832a03e16381' }
@@ -41,7 +40,7 @@ module Actions
             action.stubs(:action_subject).returns(host)
             action.input.update(
               host: {
-                id: host.id
+                id: host.id,
               }
             )
           end
@@ -53,8 +52,8 @@ module Actions
 
         test "it remediates the host's hardware version" do
           assert_equal :success, runned_action.state
-          assert_equal true, runned_action.output.fetch('state')
-          assert_equal true, runned_action.output.fetch('initially_powered_on')
+          assert runned_action.output.fetch('state')
+          assert runned_action.output.fetch('initially_powered_on')
           assert_equal 'vmx-13', host.reload.vmware_facet.hardware_version
         end
       end

data/test/actions/foreman_wreckingball/host/remediate_spectre_v2_test.rb

@@ -10,16 +10,15 @@ module Actions
         setup do
           ::Fog.mock!
           # this is not stubbed correctly in fog-vsphere
-          ::ForemanWreckingball.fog_vsphere_namespace::Server.any_instance.stubs(:cpuHotAddEnabled).returns(false)
-          ::ForemanWreckingball.fog_vsphere_namespace::Server.any_instance.stubs(:hardware_version).returns('vmx-13')
+          Fog::Vsphere::Compute::Server.any_instance.stubs(:cpuHotAddEnabled).returns(false)
+          Fog::Vsphere::Compute::Server.any_instance.stubs(:hardware_version).returns('vmx-13')
           ::ForemanWreckingball::SpectreV2Status.any_instance.stubs(:recent_hw_version?).returns(true)
           ::PowerManager::Virt.any_instance.stubs(:ready?).returns(true)
-          Setting::Wreckingball.load_defaults
         end
         teardown { ::Fog.unmock! }
 
         let(:compute_resource) do
-          cr = FactoryBot.create(:compute_resource, :vmware, :with_taxonomy, :uuid => 'Solutions')
+          cr = FactoryBot.create(:compute_resource, :vmware, :with_taxonomy, uuid: 'Solutions')
           ComputeResource.find(cr.id)
         end
         let(:uuid) { '5032c8a5-9c5e-ba7a-3804-832a03e16381' }
@@ -41,7 +40,7 @@ module Actions
             action.stubs(:action_subject).returns(host)
             action.input.update(
               host: {
-                id: host.id
+                id: host.id,
               }
             )
           end
@@ -53,8 +52,8 @@ module Actions
 
         test "it remediates the host's spectre v2 status" do
           assert_equal :success, runned_action.state
-          assert_equal true, runned_action.output.fetch('state')
-          assert_equal true, runned_action.output.fetch('initially_powered_on')
+          assert runned_action.output.fetch('state')
+          assert runned_action.output.fetch('initially_powered_on')
         end
       end
     end

data/test/actions/foreman_wreckingball/host/remediate_vmware_operatingsystem_test.rb

@@ -10,15 +10,14 @@ module Actions
         setup do
           ::Fog.mock!
           # this is not stubbed correctly in fog-vsphere
-          ::ForemanWreckingball.fog_vsphere_namespace::Server.any_instance.stubs(:cpuHotAddEnabled).returns(false)
+          Fog::Vsphere::Compute::Server.any_instance.stubs(:cpuHotAddEnabled).returns(false)
           ::ForemanWreckingball::SpectreV2Status.any_instance.stubs(:recent_hw_version?).returns(true)
           ::PowerManager::Virt.any_instance.stubs(:ready?).returns(true)
-          Setting::Wreckingball.load_defaults
         end
         teardown { ::Fog.unmock! }
 
         let(:compute_resource) do
-          cr = FactoryBot.create(:compute_resource, :vmware, :with_taxonomy, :uuid => 'Solutions')
+          cr = FactoryBot.create(:compute_resource, :vmware, :with_taxonomy, uuid: 'Solutions')
           ComputeResource.find(cr.id)
         end
         let(:uuid) { '5032c8a5-9c5e-ba7a-3804-832a03e16381' }
@@ -27,7 +26,7 @@ module Actions
         let(:operatingsystem) do
           FactoryBot.create(
             :operatingsystem,
-            architectures: [architectures(:x86_64)],
+            architectures: [architectures(:x86_64)], # rubocop:disable Naming/VariableNumber
             major: 6,
             minor: 1,
             type: 'Redhat',
@@ -40,12 +39,12 @@ module Actions
             :host,
             :managed,
             :with_vmware_facet,
-            architecture: architectures(:x86_64),
+            architecture: architectures(:x86_64), # rubocop:disable Naming/VariableNumber
             operatingsystem: operatingsystem,
             compute_resource: compute_resource,
             uuid: uuid
           ).tap do |host|
-            host.vmware_facet.update_attribute(:guest_id, 'asianux4_64Guest')
+            host.vmware_facet.update_attribute(:guest_id, 'asianux4_64Guest') # rubocop:disable Rails/SkipsModelValidations
           end
         end
 
@@ -55,7 +54,7 @@ module Actions
             action.stubs(:action_subject).returns(host)
             action.input.update(
               host: {
-                id: host.id
+                id: host.id,
               }
             )
           end
@@ -69,8 +68,8 @@ module Actions
           assert_equal :success, runned_action.state
           assert_equal 'asianux4_64Guest', runned_action.output.fetch('old_operatingsystem_id')
           assert_equal 'rhel6_64Guest', runned_action.output.fetch('new_operatingsytem_id')
-          assert_equal true, runned_action.output.fetch('state')
-          assert_equal true, runned_action.output.fetch('initially_powered_on')
+          assert runned_action.output.fetch('state')
+          assert runned_action.output.fetch('initially_powered_on')
           assert_equal 'rhel6_64Guest', host.reload.vmware_facet.guest_id
         end
       end

data/test/actions/foreman_wreckingball/vmware/sync_compute_resource_test.rb

@@ -27,7 +27,7 @@ module Actions
             action.stubs(:action_subject).returns(compute_resource)
             action.input.update(
               compute_resource: {
-                id: compute_resource.id
+                id: compute_resource.id,
               }
             )
           end
@@ -41,7 +41,7 @@ module Actions
           test 'syncs a compute resource' do
             assert ::ForemanWreckingball::VmwareCluster.count.zero?
             assert_equal :success, runned_action.state
-            refute ::ForemanWreckingball::VmwareCluster.count.zero?
+            assert_not ::ForemanWreckingball::VmwareCluster.count.zero?
           end
         end
       end

data/test/controllers/compute_resources_controller_test.rb

@@ -11,9 +11,9 @@ class ComputeResourcesControllerTest < ActionController::TestCase
       skip if Gem::Version.new(Foreman::Version.new.to_s) < Gem::Version.new('1.19.0')
       FactoryBot.create_list(:vmware_hypervisor_facet, 5, vmware_cluster: vmware_cluster)
 
-      get :show, params: { :id => compute_resource.to_param }, session: set_session_user
+      get :show, params: { id: compute_resource.to_param }, session: set_session_user
       assert_response :success
-      assert @response.body.match(/Hypervisors/)
+      assert_includes @response.body, 'Hypervisors'
     end
   end
 end

data/test/controllers/foreman_wreckingball/hosts_controller_test.rb

@@ -6,10 +6,6 @@ module ForemanWreckingball
   class HostsControllerTest < ActionController::TestCase
     let(:fake_task) { OpenStruct.new(id: 123) }
 
-    setup do
-      Setting::Wreckingball.load_defaults
-    end
-
     describe '#status_dashboard' do
       context 'when there are no hosts with wreckingball statuses' do
         test 'shows an empty status page' do
@@ -47,8 +43,8 @@ module ForemanWreckingball
           let(:search) { "owner = current_user or (owner_type = Usergroup and owner_id = #{user.usergroups.first.id}) or hostgroup_id = #{hostgroup.id} or name ~ #{host_name_prefix}" }
           let(:filter) do
             FactoryBot.create(:filter,
-                              search: search,
-                              permissions: Permission.where(name: 'view_hosts'))
+              search: search,
+              permissions: Permission.where(name: 'view_hosts'))
           end
           let(:role) { FactoryBot.create(:role) }
           let(:user) { FactoryBot.create(:user, :with_mail, :with_usergroup, admin: false, roles: [role]) }
@@ -131,7 +127,7 @@ module ForemanWreckingball
 
       test 'should filter host with vm' do
         get :status_managed_hosts_dashboard, session: set_session_user
-        refute_includes assigns[:missing_hosts], @managed_host
+        assert_not_includes assigns[:missing_hosts], @managed_host
       end
     end
 
@@ -140,8 +136,9 @@ module ForemanWreckingball
         FactoryBot.create_list(:vmware_hardware_version_status, 3, :with_ok_status)
         FactoryBot.create_list(:vmware_hardware_version_status, 4, :with_out_of_date_status)
 
-        get :status_hosts, params: { status: ::ForemanWreckingball::HardwareVersionStatus.host_association },
-                           session: set_session_user, xhr: true
+        get :status_hosts,
+          params: { status: ::ForemanWreckingball::HardwareVersionStatus.host_association },
+          session: set_session_user, xhr: true
 
         assert_response :ok
         json = JSON.parse(response.body)
@@ -154,8 +151,9 @@ module ForemanWreckingball
         ok_status = FactoryBot.create(:vmware_hardware_version_status, :with_ok_status)
         out_of_date_status = FactoryBot.create(:vmware_hardware_version_status, :with_out_of_date_status)
 
-        get :status_hosts, params: { status: ::ForemanWreckingball::HardwareVersionStatus.host_association },
-                           session: set_session_user, xhr: true
+        get :status_hosts,
+          params: { status: ::ForemanWreckingball::HardwareVersionStatus.host_association },
+          session: set_session_user, xhr: true
 
         assert_response :ok
 
@@ -164,15 +162,16 @@ module ForemanWreckingball
         hosts_names = data.map { |host| host['name'] }
         assert_equal 1, data.size
         assert_includes hosts_names, out_of_date_status.host.name
-        refute_includes hosts_names, ok_status.host.name
+        assert_not_includes hosts_names, ok_status.host.name
       end
 
       test 'returns hosts for spectre v2 status' do
         FactoryBot.create_list(:vmware_spectre_v2_status, 1, :with_enabled)
         FactoryBot.create_list(:vmware_spectre_v2_status, 2, :with_missing)
 
-        get :status_hosts, params: { status: ::ForemanWreckingball::SpectreV2Status.host_association },
-                           session: set_session_user, xhr: true
+        get :status_hosts,
+          params: { status: ::ForemanWreckingball::SpectreV2Status.host_association },
+          session: set_session_user, xhr: true
 
         data = JSON.parse(response.body)['data']
         assert_equal 2, data.size
@@ -187,14 +186,16 @@ module ForemanWreckingball
         end
 
         test 'should show all hosts' do
-          get :status_hosts, params: { status: ::ForemanWreckingball::SpectreV2Status.host_association },
-                             session: set_session_user, xhr: true
+          get :status_hosts,
+            params: { status: ::ForemanWreckingball::SpectreV2Status.host_association },
+            session: set_session_user, xhr: true
           assert_equal 4, JSON.parse(response.body)['data'].count
         end
 
         test 'should show only owned hosts' do
-          get :status_hosts, params: { status: ::ForemanWreckingball::SpectreV2Status.host_association, owned_only: true },
-                             session: set_session_user, xhr: true
+          get :status_hosts,
+            params: { status: ::ForemanWreckingball::SpectreV2Status.host_association, owned_only: true },
+            session: set_session_user, xhr: true
           assert_equal 2, JSON.parse(response.body)['data'].count
         end
       end

data/test/factories/foreman_wreckingball_factories.rb

@@ -3,8 +3,8 @@
 FactoryBot.define do
   factory :vmware_facet, class: 'ForemanWreckingball::VmwareFacet' do
     vmware_cluster
-    tools_state { 2 } #:toolsOk
-    power_state { 1 } #:poweredOn
+    tools_state { 2 } # :toolsOk
+    power_state { 1 } # :poweredOn
     cpus { 2 }
     corespersocket { 1 }
     memory_mb { 8192 }
@@ -32,7 +32,7 @@ FactoryBot.define do
         'cpuid.NX',
         'cpuid.RDTSCP',
         'cpuid.LM',
-        'cpuid.Intel'
+        'cpuid.Intel',
       ]
     end
     host
@@ -127,14 +127,14 @@ FactoryBot.define do
         'vpmc.numFixedCtrs',
         'vpmc.numGenCtrs',
         'vpmc.version',
-        'vt.realmode'
+        'vt.realmode',
       ]
     end
   end
 
   factory :vmware_cluster, class: 'ForemanWreckingball::VmwareCluster' do
     sequence(:name) { |n| "Cluster #{n}" }
-    association :compute_resource, factory: [:compute_resource, :vmware]
+    association :compute_resource, factory: %i[compute_resource vmware]
 
     trait(:with_hosts) do
       after(:create) do |vmware_cluster|
@@ -156,25 +156,25 @@ FactoryBot.define do
   end
 
   factory :vmware_tools_status, class: 'ForemanWreckingball::ToolsStatus' do
-    association :host, factory: [:host, :with_vmware_facet]
+    association :host, factory: %i[host with_vmware_facet]
     reported_at { Time.now.utc }
     after(:build) { |status| status.status = status.to_status }
   end
 
   factory :vmware_operatingsystem_status, class: 'ForemanWreckingball::OperatingsystemStatus' do
-    association :host, factory: [:host, :with_vmware_facet]
+    association :host, factory: %i[host with_vmware_facet]
     reported_at { Time.now.utc }
     after(:build) { |status| status.status = status.to_status }
   end
 
   factory :vmware_cpu_hot_add_status, class: 'ForemanWreckingball::CpuHotAddStatus' do
-    association :host, factory: [:host, :with_vmware_facet]
+    association :host, factory: %i[host with_vmware_facet]
     reported_at { Time.now.utc }
     after(:build) { |status| status.status = status.to_status }
   end
 
   factory :vmware_spectre_v2_status, class: 'ForemanWreckingball::SpectreV2Status' do
-    association :host, factory: [:host, :with_vmware_facet]
+    association :host, factory: %i[host with_vmware_facet]
     reported_at { Time.now.utc }
     after(:build) { |status| status.status = status.to_status }
 
@@ -188,7 +188,7 @@ FactoryBot.define do
   end
 
   factory :vmware_hardware_version_status, class: 'ForemanWreckingball::HardwareVersionStatus' do
-    association :host, factory: [:host, :with_vmware_facet]
+    association :host, factory: %i[host with_vmware_facet]
     reported_at { Time.now.utc }
     after(:build) { |status| status.status = status.to_status }
 

data/test/integration/hosts_status_dashboard_test.rb

@@ -3,10 +3,6 @@
 require 'integration_test_plugin_helper'
 
 class HostsStatusDashboardTest < ActionDispatch::IntegrationTest
-  setup do
-    Setting::Wreckingball.load_defaults
-  end
-
   test 'shows different vmware host statuses' do
     FactoryBot.create_list(:host, 10)
     FactoryBot.create_list(:vmware_tools_status, 1)

data/test/integration/hosts_status_managed_hosts_test.rb

@@ -4,7 +4,6 @@ require 'integration_test_plugin_helper'
 
 class HostsStatusManagedHostsTest < ActionDispatch::IntegrationTest
   setup do
-    Setting::Wreckingball.load_defaults
     Fog.mock!
   end
 
@@ -33,7 +32,7 @@ class HostsStatusManagedHostsTest < ActionDispatch::IntegrationTest
 
     list = page.find('#missing_vms')
     assert_includes list.text, missing_host.name
-    refute_includes list.text, managed_host.name
+    assert_not_includes list.text, managed_host.name
   end
 
   test 'shows hosts associated to wrong compute resource' do
@@ -62,7 +61,7 @@ class HostsStatusManagedHostsTest < ActionDispatch::IntegrationTest
     visit status_managed_hosts_dashboard_hosts_path
 
     list = page.find('#wrong_hosts')
-    refute_includes list.text, correct_host.name
+    assert_not_includes list.text, correct_host.name
     assert_includes list.text, incorrect_host.name
   end
 
@@ -98,8 +97,8 @@ class HostsStatusManagedHostsTest < ActionDispatch::IntegrationTest
     visit status_managed_hosts_dashboard_hosts_path
 
     list = page.find('#more_than_one_hosts')
-    refute_includes list.text, managed1_host.name
+    assert_not_includes list.text, managed1_host.name
     assert_includes list.text, managed2_host.name
-    refute_includes list.text, managed3_host.name
+    assert_not_includes list.text, managed3_host.name
   end
 end

data/test/models/compute_resources/vmware_test.rb

@@ -5,7 +5,7 @@ require 'test_plugin_helper'
 class VmwareTest < ActiveSupport::TestCase
   setup { Fog.mock! }
   teardown { Fog.unmock! }
-  let(:compute_resource) { FactoryBot.build(:vmware_cr, :uuid => 'Solutions') }
+  let(:compute_resource) { FactoryBot.build(:vmware_cr, uuid: 'Solutions') }
 
   test '#hypervisors returns hosts by cluster' do
     hosts = compute_resource.hypervisors(cluster_id: 'Solutionscluster').map(&:name)

data/test/models/foreman_wreckingball/cpu_hot_add_status_test.rb

@@ -51,11 +51,11 @@ module ForemanWreckingball
         end
 
         test 'status is not relevant' do
-          refute status.relevant?
+          assert_not status.relevant?
         end
 
         test 'no performance degration is indicated' do
-          refute status.performance_degration?
+          assert_not status.performance_degration?
         end
       end
 

data/test/models/foreman_wreckingball/hardware_version_status_test.rb

@@ -6,7 +6,6 @@ module ForemanWreckingball
   class HardwareVersionStatusTest < ActiveSupport::TestCase
     setup do
       User.current = users(:admin)
-      Setting::Wreckingball.load_defaults
     end
 
     should belong_to(:host)
@@ -27,14 +26,14 @@ module ForemanWreckingball
 
     test '#relevant is only for hosts with a vmware facet' do
       h = FactoryBot.build(:host, :managed)
-      refute ForemanWreckingball::ToolsStatus.new(host: h).relevant?
+      assert_not ForemanWreckingball::ToolsStatus.new(host: h).relevant?
       assert status.relevant?
     end
 
     test '#relevant is for hosts with a hardware version' do
       assert status.relevant?
       host.vmware_facet.hardware_version = nil
-      refute status.relevant?
+      assert_not status.relevant?
     end
 
     describe 'status calculation' do
@@ -81,7 +80,7 @@ module ForemanWreckingball
 
       test 'is false when hw version is ancient' do
         status.host.vmware_facet.hardware_version = 'vmx-3'
-        refute status.recent_hw_version?
+        assert_not status.recent_hw_version?
       end
     end
   end

data/test/models/foreman_wreckingball/operatingsystem_status_test.rb

@@ -13,7 +13,7 @@ module ForemanWreckingball
     let(:operatingsystem) do
       FactoryBot.create(
         :operatingsystem,
-        architectures: [architectures(:x86_64)],
+        architectures: [architectures(:x86_64)], # rubocop:disable Naming/VariableNumber
         major: 6,
         minor: 1,
         type: 'Redhat',
@@ -25,7 +25,7 @@ module ForemanWreckingball
         :host,
         :managed,
         :with_vmware_facet,
-        architecture: architectures(:x86_64),
+        architecture: architectures(:x86_64), # rubocop:disable Naming/VariableNumber
         operatingsystem: operatingsystem
       )
     end
@@ -38,7 +38,7 @@ module ForemanWreckingball
 
     test '#relevant is only for hosts with a vmware facet' do
       h = FactoryBot.build(:host, :managed)
-      refute ForemanWreckingball::ToolsStatus.new(host: h).relevant?
+      assert_not ForemanWreckingball::ToolsStatus.new(host: h).relevant?
       assert status.relevant?
     end
 
@@ -81,12 +81,12 @@ module ForemanWreckingball
     describe '#os_matches_identifier?' do
       test 'when architecture does not match' do
         host.architecture = architectures(:sparc)
-        refute status.os_matches_identifier?
+        assert_not status.os_matches_identifier?
       end
 
       test 'when operatingsystem does not match' do
         host.operatingsystem = operatingsystems(:ubuntu1210)
-        refute status.os_matches_identifier?
+        assert_not status.os_matches_identifier?
       end
 
       test 'when architecture, osfamily, name and major match' do

data/test/models/foreman_wreckingball/spectre_v2_status_test.rb

@@ -26,14 +26,14 @@ module ForemanWreckingball
 
     test '#relevant is only for hosts with a vmware facet' do
       h = FactoryBot.build(:host, :managed)
-      refute ForemanWreckingball::ToolsStatus.new(host: h).relevant?
+      assert_not ForemanWreckingball::ToolsStatus.new(host: h).relevant?
       assert status.relevant?
     end
 
     test '#relevant is for hosts with cpu features' do
       assert status.relevant?
       host.vmware_facet.cpu_features = []
-      refute status.relevant?
+      assert_not status.relevant?
     end
 
     describe 'status calculation' do
@@ -84,14 +84,14 @@ module ForemanWreckingball
 
       test 'is false when hw version is ancient' do
         host.vmware_facet.hardware_version = 'vmx-3'
-        refute status.recent_hw_version?
+        assert_not status.recent_hw_version?
       end
     end
 
     describe '#required_cpu_features_present?' do
       test 'is false when neither cpuid.IBRS, cpuid.IBPB nor cpuid.STIBP is present' do
         host.vmware_facet.cpu_features = ['cpuid.SSE42']
-        refute status.required_cpu_features_present?
+        assert_not status.required_cpu_features_present?
       end
 
       test 'is true when cpuid.IBRS is present' do

data/test/models/foreman_wreckingball/tools_status_test.rb

@@ -23,12 +23,12 @@ module ForemanWreckingball
       assert status.relevant?
 
       host.build = true
-      refute status.relevant?
+      assert_not status.relevant?
     end
 
     test '#relevant is only for hosts with a vmware facet' do
       h = FactoryBot.build(:host, :managed)
-      refute ForemanWreckingball::ToolsStatus.new(host: h).relevant?
+      assert_not ForemanWreckingball::ToolsStatus.new(host: h).relevant?
     end
 
     describe 'status calculation' do

data/test/models/foreman_wreckingball/vmware_facet_test.rb

@@ -19,12 +19,12 @@ module ForemanWreckingball
       let(:vmware_facet) { host.vmware_facet }
 
       test 'is true when vm is powered on' do
-        assert_equal true, vmware_facet.vm_ready?
+        assert vmware_facet.vm_ready?
       end
 
       test 'is false when vm is not powered on' do
         vmware_facet.power_state = 'suspended'
-        assert_equal false, vmware_facet.vm_ready?
+        assert_not vmware_facet.vm_ready?
       end
     end
 
@@ -36,7 +36,7 @@ module ForemanWreckingball
             featureRequirement: [
               'cpuid.SSE3',
               'cpuid.AES',
-              'cpuid.Intel'
+              'cpuid.Intel',
             ].map do |cpu_feature|
               OpenStruct.new(key: cpu_feature)
             end
@@ -45,7 +45,7 @@ module ForemanWreckingball
       end
 
       let(:compute_resource) do
-        cr = FactoryBot.create(:compute_resource, :vmware, :with_taxonomy, :uuid => 'Solutions')
+        cr = FactoryBot.create(:compute_resource, :vmware, :with_taxonomy, uuid: 'Solutions')
         ComputeResource.find(cr.id)
       end
 
@@ -62,12 +62,12 @@ module ForemanWreckingball
 
       setup do
         ::Fog.mock!
-        ::ForemanWreckingball.fog_vsphere_namespace::Mock.any_instance.stubs(:get_vm_ref).returns(vm)
+        Fog::Vsphere::Compute::Mock.any_instance.stubs(:get_vm_ref).returns(vm)
         # this is not stubbed correctly in fog-vsphere
-        ::ForemanWreckingball.fog_vsphere_namespace::Server.any_instance.stubs(:cpuHotAddEnabled).returns(false)
-        ::ForemanWreckingball.fog_vsphere_namespace::Server.any_instance.stubs(:hardware_version).returns('vmx-9')
-        ::ForemanWreckingball.fog_vsphere_namespace::Server.any_instance.stubs(:corespersocket).returns(1)
-        ::ForemanWreckingball.fog_vsphere_namespace::Server.any_instance.stubs(:power_state).returns('poweredOn')
+        Fog::Vsphere::Compute::Server.any_instance.stubs(:cpuHotAddEnabled).returns(false)
+        Fog::Vsphere::Compute::Server.any_instance.stubs(:hardware_version).returns('vmx-9')
+        Fog::Vsphere::Compute::Server.any_instance.stubs(:corespersocket).returns(1)
+        Fog::Vsphere::Compute::Server.any_instance.stubs(:power_state).returns('poweredOn')
       end
       teardown { ::Fog.unmock! }
 
@@ -79,7 +79,7 @@ module ForemanWreckingball
         assert_equal 'rhel6_64Guest', vmware_facet.guest_id
         assert_equal 'toolsOk', vmware_facet.tools_state
         assert_equal 'poweredOn', vmware_facet.power_state
-        assert_equal false, vmware_facet.cpu_hot_add
+        assert_not vmware_facet.cpu_hot_add
         assert_equal ['cpuid.SSE3', 'cpuid.AES', 'cpuid.Intel'], vmware_facet.cpu_features
         assert_equal 'vmx-9', vmware_facet.hardware_version
       end