foreman_wreckingball 3.4.1 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5386e48704b4c0837fd34063239ead1bda9c7e2dd72cc60d82c15ac60334fea2
-  data.tar.gz: 4ed751665783de1efb8e25534cc32324f287c4611aa579d031873078b53ff7d1
+  metadata.gz: 0fc1a2760d1b2467a0fcae578b7307eae8d2b0fcce5ce7de9ecacc2c81601043
+  data.tar.gz: 1680594f03c2237ba9c068f6caa0600f365bb590a14a1ee5b9cd3dab7e541a5f
 SHA512:
-  metadata.gz: 2d6df272535f83e43c0889bce9655beb8b01f522269a85ebfbb7e5a6f1d332c407632e295234e12e7dc826897e8cc7eda587a322a57d265b3239ebbda54b4d4f
-  data.tar.gz: 3aea63d70aa6895ba153fdf32c370127ca8ee8a2b22ceb9099b4c8ded6fca3b8315561e4cd78854ec1977b6df73d7dee7e54e5943237de496dfaf1eebec179bd
+  metadata.gz: 5f796c690147b26378f6518bddcd2d57535229b117e8292fe1b7ab02558a3ed9423c756ad32d9813dc65624886ebce83d227d2b9e435ed6dea5d03621b2fef7f
+  data.tar.gz: e6fa1d5e46961f3f44ae105c1767b027c8255e3068aaf828c0a60a0992b4b6f1c1104e72f64a761cc8bc3ebb02fd2b36a4dddf59fa51d0ea2c70730abc9a1634

data/README.md

@@ -11,7 +11,9 @@ This is a plugin for Foreman that adds several VMware related status checks to y
 | >= 1.15         | ~> 0.1         |
 | >= 1.16         | ~> 1.0         |
 | >= 1.17         | ~> 2.0         |
-| >= 1.18         | ~> 3.0         |
+| >= 1.21         | ~> 3.0         |
+| >= 2.3          | ~> 4.0         |
+| >= 3.9          | ~> 5.0         |
 
 ## Installation
 

data/Rakefile

@@ -20,7 +20,7 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
-APP_RAKEFILE = File.expand_path('../test/dummy/Rakefile', __FILE__)
+APP_RAKEFILE = File.expand_path('test/dummy/Rakefile', __dir__)
 
 Bundler::GemHelper.install_tasks
 
@@ -38,7 +38,7 @@ task default: :test
 begin
   require 'rubocop/rake_task'
   RuboCop::RakeTask.new
-rescue => _
+rescue LoadError
   puts 'Rubocop not loaded.'
 end
 

data/app/assets/stylesheets/foreman_wreckingball/status_hosts_table.css.scss

@@ -11,3 +11,10 @@ div.status-hosts-container.ajax-error div.dataTables_wrapper,
 div.status-hosts-container.ajax-error p {
   display: none;
 }
+
+table.status-hosts.hide-puppet-environment {
+  th:nth-child(5),
+  td:nth-child(5) {
+    display: none;
+  }
+}

data/app/controllers/foreman_wreckingball/hosts_controller.rb

@@ -7,13 +7,16 @@ module ForemanWreckingball
     include ::AuthorizeHelper
 
     AJAX_REQUESTS = [:status_hosts].freeze
-    before_action :ajax_request, :only => AJAX_REQUESTS
-    before_action :find_statuses, :only => [:schedule_remediate, :submit_remediate]
+    before_action :ajax_request, only: AJAX_REQUESTS
+    before_action :find_statuses, only: %i[schedule_remediate submit_remediate]
 
+    # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
     def status_dashboard
       @newest_data = Host.authorized(:view_hosts).joins(:vmware_facet).maximum('vmware_facets.updated_at')
       host_ids = Host.authorized(:view_hosts)
-                     .try { |query| params[:owned_only] ? query.owned_by_current_user_or_group_with_current_user : query }
+                     .try do |query|
+                       params[:owned_only] ? query.owned_by_current_user_or_group_with_current_user : query
+                     end
                      .pluck(:id)
 
       @data = HostStatus.wreckingball_statuses.map do |status|
@@ -31,18 +34,20 @@ module ForemanWreckingball
           counter: {
             ok: counter[HostStatus::Global::OK] || 0,
             warning: counter[HostStatus::Global::WARN] || 0,
-            critical: counter[HostStatus::Global::ERROR] || 0
-          }
+            critical: counter[HostStatus::Global::ERROR] || 0,
+          },
         }
       end
     end
+    # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
 
+    # rubocop:todo Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
     def status_managed_hosts_dashboard
       vmware_compute_resources = Foreman::Model::Vmware.unscoped.all
 
       @errors = {}
 
-      # NOTE The call to ComputeResource#vms may slow things down
+      # NOTE: The call to ComputeResource#vms may slow things down
       vms_by_compute_resource_id = vmware_compute_resources.each_with_object({}) do |cr, memo|
         memo[cr.id] = cr.vms.all
       rescue StandardError => e
@@ -68,7 +73,6 @@ module ForemanWreckingball
                    .where(compute_resource: vmware_compute_resources)
                    .try { |query| params[:owned_only] ? query.owned_by_current_user_or_group_with_current_user : query }
                    .each do |host|
-
         compute_resources = @vm_compute_resource_mapping[host.uuid]
 
         if compute_resources.empty?
@@ -86,15 +90,20 @@ module ForemanWreckingball
       @compute_resource_authorizer = Authorizer.new(User.current, collection: vmware_compute_resources)
       @host_authorizer = Authorizer.new(User.current)
     end
+    # rubocop:enable Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
 
     # ajax method
+    # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
     def status_hosts
       @status = HostStatus.find_wreckingball_status_by_host_association(params.fetch(:status))
 
       all_hosts = Host.authorized(:view_hosts, Host)
                       .joins(@status.host_association)
-                      .try { |query| params[:owned_only] ? query.owned_by_current_user_or_group_with_current_user : query }
-                      .includes(@status.host_association, :vmware_facet, :environment)
+                      .try do |query|
+                        params[:owned_only] ? query.owned_by_current_user_or_group_with_current_user : query
+                      end
+                      .includes([*(:environment if Host::Managed.reflect_on_environment?), @status.host_association,
+                                 :vmware_facet])
                       .where.not('host_status.status': @status.global_ok_list)
                       .preload(:owner)
                       .order(:name)
@@ -105,12 +114,14 @@ module ForemanWreckingball
       respond_to do |format|
         format.json do
           Rabl::Renderer.json(@hosts, 'foreman_wreckingball/hosts/status_hosts',
-                              view_path: "#{ForemanWreckingball::Engine.root}/app/views",
-                              scope: self)
+            view_path: "#{ForemanWreckingball::Engine.root}/app/views",
+            scope: self)
         end
       end
     end
+    # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
 
+    # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
     def refresh_status_dashboard
       if ForemanTasks::Task.active.where(label: ::Actions::ForemanWreckingball::Vmware::ScheduleVmwareSync.to_s).empty?
         flash[:success] = _('Refresh Compute Resource data task was successfully scheduled.')
@@ -119,15 +130,18 @@ module ForemanWreckingball
         end
         redirect_to(foreman_tasks_task_path(task.id))
       else
-        flash[:warning] = _('Refresh Compute Resource data task is already running. Please wait for the running task to finish.')
+        flash[:warning] =
+          _('Refresh Compute Resource data task is already running. Please wait for the running task to finish.')
         redirect_to status_dashboard_hosts_path
       end
     end
+    # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
 
     def schedule_remediate
       @triggering = ForemanTasks::Triggering.new(mode: :immediate)
     end
 
+    # rubocop:todo Metrics/MethodLength
     def submit_remediate
       return not_found unless @statuses.any?
 
@@ -145,6 +159,7 @@ module ForemanWreckingball
 
       redirect_to foreman_tasks_task_path(task.id)
     end
+    # rubocop:enable Metrics/MethodLength
 
     private
 
@@ -158,6 +173,7 @@ module ForemanWreckingball
       @statuses_params ||= params.permit(:host_association, :owned_only, status_ids: [])
     end
 
+    # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
     def find_statuses
       @statuses = begin
         host_association = statuses_params[:host_association]
@@ -166,7 +182,7 @@ module ForemanWreckingball
           Host.authorized(:remediate_vmware_status_hosts, Host)
               .joins(status_class.host_association)
               .includes(status_class.host_association)
-              .try { |query| statuses_params[:owned_only] ? query.owned_by_current_user_or_group_with_current_user : query }
+              .try { |query| statuses_params[:owned_only] ? query.owned_by_current_user_or_group_with_current_user : query } # rubocop:disable Layout/LineLength
               .where.not('host_status.status': status_class.global_ok_list)
               .map { |host| host.send(status_class.host_association) }
         else
@@ -176,6 +192,7 @@ module ForemanWreckingball
         end
       end
     end
+    # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
 
     def action_permission
       case params[:action]

data/app/helpers/{concerns/foreman_wreckingball/hosts_helper_extensions.rb → foreman_wreckingball/hosts_helper.rb}

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module ForemanWreckingball
-  module HostsHelperExtensions
+  module HostsHelper
     extend ActiveSupport::Concern
 
     def classes_for_vmware_status_row(counter)

data/app/helpers/foreman_wreckingball/hypervisors_helper.rb

@@ -8,7 +8,8 @@ module ForemanWreckingball
       elsif vmware_hypervisor_facet.provides_spectre_features?
         icon_text('ok', '', kind: 'pficon', title: _('CPU-Features are present on this host.'))
       else
-        icon_text('error-circle-o', '', kind: 'pficon', title: _('Required CPU features are missing. This host is most likely vulnerable.'))
+        icon_text('error-circle-o', '', kind: 'pficon',
+                                        title: _('Required CPU features are missing. This host is most likely vulnerable.')) # rubocop:disable Layout/LineLength
       end
     end
   end

data/app/helpers/foreman_wreckingball/statuses_helper.rb

@@ -2,20 +2,22 @@
 
 module ForemanWreckingball
   module StatusesHelper
+    # rubocop:todo Metrics/MethodLength
     def status_actions(host_association, owned_only, supports_remediate)
       actions = []
       actions << display_link_if_authorized(_('Refresh'),
-                                            hash_for_refresh_status_dashboard_hosts_path,
-                                            title: _('Refresh Data'),
-                                            method: :put)
+        hash_for_refresh_status_dashboard_hosts_path,
+        title: _('Refresh Data'),
+        method: :put)
       if supports_remediate
         actions << display_link_if_authorized(_('Remediate All'),
-                                              hash_for_schedule_remediate_hosts_path,
-                                              'data-host-association': host_association,
-                                              'data-owned-only': owned_only,
-                                              onClick: 'show_modal(this); return false;')
+          hash_for_schedule_remediate_hosts_path,
+          'data-host-association': host_association,
+          'data-owned-only': owned_only,
+          onClick: 'show_modal(this); return false;')
       end
       actions.reject(&:blank?)
     end
+    # rubocop:enable Metrics/MethodLength
   end
 end

data/app/jobs/update_hosts_vmware_facets.rb

@@ -2,8 +2,9 @@
 
 class UpdateHostsVmwareFacets < ApplicationJob
   after_perform do
-    self.class.set(:wait => 12.hours).perform_later
+    self.class.set(wait: 12.hours).perform_later
   end
 
-  def perform; end
+  def perform
+  end
 end

data/app/lib/actions/foreman_wreckingball/bulk_remediate.rb

@@ -6,7 +6,10 @@ module Actions
       def plan(statuses)
         sequence do
           statuses.group_by(&:class).each do |statuses_klass, statuses_list|
-            plan_action(::Actions::BulkAction, statuses_klass.remediate_action, statuses_list.map(&:host)) if statuses_klass.respond_to?(:remediate_action)
+            if statuses_klass.respond_to?(:remediate_action)
+              plan_action(::Actions::BulkAction, statuses_klass.remediate_action,
+                statuses_list.map(&:host))
+            end
           end
         end
       end

data/app/lib/actions/foreman_wreckingball/host/remediate_hardware_version.rb

@@ -16,6 +16,7 @@ module Actions
           plan_self
         end
 
+        # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
         def run
           host = ::Host.find(input[:host][:id])
 
@@ -29,7 +30,7 @@ module Actions
           if initially_powered_on
             vm.stop
             vm.wait_for { power_state == 'poweredOff' }
-            fail _('Could not shut down VM.') if vm.ready?
+            raise _('Could not shut down VM.') if vm.ready?
           end
 
           vm.vm_upgrade_hardware
@@ -40,6 +41,7 @@ module Actions
         ensure
           vm.start if vm && initially_powered_on
         end
+        # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
 
         def humanized_name
           _('Upgrade VM Hardware Version')

data/app/lib/actions/foreman_wreckingball/host/remediate_spectre_v2.rb

@@ -16,6 +16,7 @@ module Actions
           plan_self
         end
 
+        # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
         def run
           host = ::Host.find(input[:host][:id])
 
@@ -27,7 +28,7 @@ module Actions
           if initially_powered_on
             vm.stop
             vm.wait_for { power_state == 'poweredOff' }
-            fail _('Could not shut down VM.') if vm.ready?
+            raise _('Could not shut down VM.') if vm.ready?
           end
 
           vm.start if vm && initially_powered_on
@@ -35,6 +36,7 @@ module Actions
           state = host.refresh_vmware_facet!
           output[:state] = state
         end
+        # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
 
         def humanized_name
           _('Power-Cycle VM')

data/app/lib/actions/foreman_wreckingball/host/remediate_vmware_operatingsystem.rb

@@ -16,11 +16,12 @@ module Actions
           plan_self
         end
 
+        # rubocop:todo Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
         def run
           host = ::Host.find(input[:host][:id])
 
-          fail _('Foreman does not know the Architecture of this host.') unless host.architecture
-          fail _('Foreman does not know the Operatingsystem of this host.') unless host.operatingsystem
+          raise _('Foreman does not know the Architecture of this host.') unless host.architecture
+          raise _('Foreman does not know the Operatingsystem of this host.') unless host.operatingsystem
 
           initially_powered_on = host.power.ready?
           output[:initially_powered_on] = initially_powered_on
@@ -29,11 +30,11 @@ module Actions
           current_os = VsphereOsIdentifiers.lookup(current_os_id)
 
           selectors = {
-            :architecture => host.architecture.name,
-            :osfamily => host.operatingsystem.family,
-            :name => host.operatingsystem.name,
-            :major => host.operatingsystem.major.to_i,
-            :release => host.facts['os::release::full']
+            architecture: host.architecture.name,
+            osfamily: host.operatingsystem.family,
+            name: host.operatingsystem.name,
+            major: host.operatingsystem.major.to_i,
+            release: host.facts['os::release::full'],
           }
 
           desired_os = VsphereOsIdentifiers.find_by(selectors)
@@ -43,9 +44,11 @@ module Actions
           desired_os ||= VsphereOsIdentifiers.find_by(selectors.except(:major, :name))
           desired_os ||= VsphereOsIdentifiers.find_by(selectors.except(:major, :name, :release))
 
-          fail _('Could not auto detect desired operatingsystem.') unless desired_os
+          raise _('Could not auto detect desired operatingsystem.') unless desired_os
 
-          fail _('VMs current and desired OS (%s) already match. No update necessary.') % current_os.description if current_os == desired_os
+          if current_os == desired_os
+            raise _('VMs current and desired OS (%s) already match. No update necessary.') % current_os.description
+          end
 
           output[:old_operatingsystem] = current_os.description
           output[:old_operatingsystem_id] = current_os.id
@@ -57,7 +60,7 @@ module Actions
           if initially_powered_on
             vm.stop
             vm.wait_for { power_state == 'poweredOff' }
-            fail _('Could not shut down VM.') if vm.ready?
+            raise _('Could not shut down VM.') if vm.ready?
           end
 
           vm.vm_reconfig_hardware('guestId' => desired_os.id)
@@ -67,6 +70,7 @@ module Actions
         ensure
           vm.start if vm && initially_powered_on
         end
+        # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
 
         def humanized_name
           _('Correct VM Operatingsystem')

data/app/lib/actions/foreman_wreckingball/vmware/schedule_vmware_sync.rb

@@ -5,7 +5,7 @@ module Actions
     module Vmware
       class ScheduleVmwareSync < Actions::EntryAction
         def plan
-          compute_resources = ComputeResource.where(:type => 'Foreman::Model::Vmware')
+          compute_resources = ComputeResource.where(type: 'Foreman::Model::Vmware')
           sequence do
             compute_resources.each do |compute_resource|
               plan_action(::Actions::ForemanWreckingball::Vmware::SyncComputeResource, compute_resource)

data/app/lib/actions/foreman_wreckingball/vmware/sync_compute_resource.rb

@@ -14,11 +14,11 @@ module Actions
         def run
           compute_resource = ComputeResource.find(input[:compute_resource][:id])
           ::ForemanWreckingball::VmwareClusterImporter.new(
-            :compute_resource => compute_resource
+            compute_resource: compute_resource
           ).import!
 
           ::ForemanWreckingball::VmwareHypervisorImporter.new(
-            :compute_resource => compute_resource.reload
+            compute_resource: compute_resource.reload
           ).import!
 
           compute_resource.hosts.each(&:refresh_vmware_facet!)

data/app/lib/fog_extensions/foreman_wreckingball/vsphere/host.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module FogExtensions
   module ForemanWreckingball
     module Vsphere

data/app/lib/fog_extensions/foreman_wreckingball/vsphere/mock.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module FogExtensions
   module ForemanWreckingball
     module Vsphere
       module Mock
         extend ActiveSupport::Concern
 
-        def vm_upgrade_hardware(version: nil, instance_uuid:)
+        def vm_upgrade_hardware(*)
           { 'task_state' => 'success' }
         end
       end

data/app/lib/fog_extensions/foreman_wreckingball/vsphere/real.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module FogExtensions
   module ForemanWreckingball
     module Vsphere
@@ -12,7 +14,10 @@ module FogExtensions
           end
 
           def list_hosts(filters = {})
-            super.map { |h| h[:feature_capabilities] = h[:feature_capabilities].map(&:key); h }
+            super.map do |h|
+              h[:feature_capabilities] = h[:feature_capabilities].map(&:key)
+              h
+            end
           end
         end
 
@@ -20,7 +25,7 @@ module FogExtensions
           prepend Overrides
         end
 
-        def vm_upgrade_hardware(version: nil, instance_uuid:)
+        def vm_upgrade_hardware(instance_uuid:, version: nil)
           vm_mob_ref = get_vm_ref(instance_uuid)
           task = vm_mob_ref.UpgradeVM_Task(version: version)
           task.wait_for_completion

data/app/lib/fog_extensions/foreman_wreckingball/vsphere/server.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module FogExtensions
   module ForemanWreckingball
     module Vsphere

data/app/lib/vsphere_os_identifiers/data.yaml

@@ -388,6 +388,20 @@ rhel7_64Guest:
   :name: RedHat
   :major: 7
   :since: 5.5
+rhel8_64Guest:
+  :description: Red Hat Enterprise Linux 8 (64-bit)
+  :architecture: x86_64
+  :osfamily: Redhat
+  :name: RedHat
+  :major: 8
+  :since: 6.5
+rhel9_64Guest:
+  :description: Red Hat Enterprise Linux 9 (64-bit)
+  :architecture: x86_64
+  :osfamily: Redhat
+  :name: RedHat
+  :major: 9
+  :since: 7.0
 sjdsGuest:
   :description: Sun Java Desktop System
 sles10Guest:
@@ -426,6 +440,13 @@ sles12_64Guest:
   :name: SLES
   :major: 12
   :since: 5.5
+sles15_64Guest:
+  :description: SUSE Linux Enterprise 15 (64-bit)
+  :architecture: x86_64
+  :osfamily: Suse
+  :name: SLES
+  :major: 15
+  :since: 6.0
 sles64Guest:
   :description: SUSE Linux Enterprise 8/9 (64-bit)
   :architecture: x86_64

data/app/models/concerns/foreman_wreckingball/compute_resource_extensions.rb

@@ -6,13 +6,19 @@ module ForemanWreckingball
     include ForemanTasks::Concerns::ActionSubject
 
     included do
-      has_many :vmware_clusters, :class_name => 'ForemanWreckingball::VmwareCluster',
-                                 :inverse_of => :compute_resource, :dependent => :destroy
+      has_many :vmware_clusters,
+        class_name: 'ForemanWreckingball::VmwareCluster',
+        inverse_of: :compute_resource, dependent: :destroy
 
-      has_many :vmware_hypervisor_facets, :class_name => '::ForemanWreckingball::VmwareHypervisorFacet', :through => :vmware_clusters,
-                                          :inverse_of => :compute_resource
+      has_many :vmware_hypervisor_facets,
+        class_name: '::ForemanWreckingball::VmwareHypervisorFacet',
+        through: :vmware_clusters,
+        inverse_of: :compute_resource
 
-      has_many :hypervisor_hosts, :class_name => 'Host::Managed', :through => :vmware_hypervisor_facets, :source => :host, :inverse_of => :compute_resource
+      has_many :hypervisor_hosts,
+        class_name: 'Host::Managed',
+        through: :vmware_hypervisor_facets,
+        source: :host, inverse_of: :compute_resource
     end
 
     def action_input_key

data/app/models/concerns/foreman_wreckingball/host_extensions.rb

@@ -7,15 +7,24 @@ module ForemanWreckingball
 
     included do
       ForemanWreckingball::Engine::WRECKINGBALL_STATUSES.map(&:constantize).each do |status|
-        has_one(status.host_association, class_name: status.to_s,
-                                         foreign_key: 'host_id',
-                                         inverse_of: :host,
-                                         dependent: :destroy)
+        has_one(
+          status.host_association,
+          class_name: status.to_s,
+          foreign_key: 'host_id',
+          inverse_of: :host,
+          dependent: :destroy
+        )
       end
 
+      # rubocop:disable Layout/LineLength
       scope :owned_by_current_user, -> { where(owner_type: 'User', owner_id: User.current.id) }
       scope :owned_by_group_with_current_user, -> { where(owner_type: 'Usergroup', owner_id: User.current.usergroup_ids_with_parents) }
       scope :owned_by_current_user_or_group_with_current_user, -> { owned_by_current_user.or(owned_by_group_with_current_user) }
+      # rubocop:enable Layout/LineLength
+
+      def self.reflect_on_environment?
+        reflect_on_association(:environment).present?
+      end
     end
 
     def action_input_key

data/app/models/concerns/foreman_wreckingball/vmware_facet_host_extensions.rb

@@ -4,21 +4,52 @@ module ForemanWreckingball
   module VmwareFacetHostExtensions
     extend ActiveSupport::Concern
 
+    # rubocop:disable Metrics/BlockLength
     included do
-      has_one :vmware_facet, :class_name => '::ForemanWreckingball::VmwareFacet', :foreign_key => :host_id, :inverse_of => :host, :dependent => :destroy
+      has_one :vmware_facet,
+        class_name: '::ForemanWreckingball::VmwareFacet',
+        foreign_key: :host_id,
+        inverse_of: :host, dependent: :destroy
 
       before_provision :queue_vmware_facet_refresh
 
-      scoped_search on: :hardware_version, relation: :vmware_facet, rename: :vsphere_hardware_version, complete_value: true, only_explicit: true
-      scoped_search on: :guest_id, relation: :vmware_facet, rename: :vsphere_guest_id, complete_value: true, only_explicit: true
-      scoped_search on: :cpus, relation: :vmware_facet, rename: :vsphere_cpus, complete_value: true, only_explicit: true
-      scoped_search on: :corespersocket, relation: :vmware_facet, rename: :vsphere_corespersocket, complete_value: true, only_explicit: true
-      scoped_search on: :memory_mb, relation: :vmware_facet, rename: :vsphere_memory_mb, complete_value: true, only_explicit: true
-      scoped_search on: :power_state, relation: :vmware_facet, rename: :vsphere_power_state, only_explicit: true,
-                    complete_value: ForemanWreckingball::VmwareFacet::VALID_POWER_STATES.map { |status| [status, ForemanWreckingball::VmwareFacet.power_states[status]] }.to_h
-      scoped_search on: :tools_state, relation: :vmware_facet, rename: :vsphere_tools_state, only_explicit: true,
-                    complete_value: ForemanWreckingball::VmwareFacet::VALID_GUEST_STATUSES.map { |status| [status, ForemanWreckingball::VmwareFacet.tools_states[status]] }.to_h
+      scoped_search on: :hardware_version,
+        relation: :vmware_facet,
+        rename: :vsphere_hardware_version,
+        complete_value: true,
+        only_explicit: true
+      scoped_search on: :guest_id,
+        relation: :vmware_facet,
+        rename: :vsphere_guest_id,
+        complete_value: true,
+        only_explicit: true
+      scoped_search on: :cpus,
+        relation: :vmware_facet,
+        rename: :vsphere_cpus,
+        complete_value: true,
+        only_explicit: true
+      scoped_search on: :corespersocket,
+        relation: :vmware_facet,
+        rename: :vsphere_corespersocket,
+        complete_value: true,
+        only_explicit: true
+      scoped_search on: :memory_mb,
+        relation: :vmware_facet,
+        rename: :vsphere_memory_mb,
+        complete_value: true,
+        only_explicit: true
+      scoped_search on: :power_state,
+        relation: :vmware_facet,
+        rename: :vsphere_power_state,
+        only_explicit: true,
+        complete_value: ForemanWreckingball::VmwareFacet::VALID_POWER_STATES.map { |status| [status, ForemanWreckingball::VmwareFacet.power_states[status]] }.to_h # rubocop:todo Rails/IndexWith, Layout/LineLength
+      scoped_search on: :tools_state,
+        relation: :vmware_facet,
+        rename: :vsphere_tools_state,
+        only_explicit: true,
+        complete_value: ForemanWreckingball::VmwareFacet::VALID_GUEST_STATUSES.map { |status| [status, ForemanWreckingball::VmwareFacet.tools_states[status]] }.to_h # rubocop:todo Rails/IndexWith, Layout/LineLength
     end
+    # rubocop:enable Metrics/BlockLength
 
     def refresh_vmware_facet!
       facet = vmware_facet || build_vmware_facet
@@ -31,7 +62,7 @@ module ForemanWreckingball
         User.as_anonymous_admin do
           ForemanTasks.delay(
             ::Actions::ForemanWreckingball::Host::RefreshVmwareFacet,
-            { :start_at => Time.now.utc + 5.minutes },
+            { start_at: Time.now.utc + 5.minutes },
             self
           )
         end

data/app/models/concerns/foreman_wreckingball/vmware_hypervisor_facet_host_extensions.rb

@@ -5,8 +5,12 @@ module ForemanWreckingball
     extend ActiveSupport::Concern
 
     included do
-      has_one :vmware_hypervisor_facet, :class_name => '::ForemanWreckingball::VmwareHypervisorFacet', :foreign_key => :host_id, :inverse_of => :host, :dependent => :destroy
-      has_one :vmware_cluster, :through => :vmware_hypervisor_facet
+      has_one :vmware_hypervisor_facet,
+        class_name: '::ForemanWreckingball::VmwareHypervisorFacet',
+        foreign_key: :host_id,
+        inverse_of: :host,
+        dependent: :destroy
+      has_one :vmware_cluster, through: :vmware_hypervisor_facet
     end
   end
 end