foreman_wreckingball 3.2.0 → 4.0.0

data/test/controllers/foreman_wreckingball/hosts_controller_test.rb

@@ -114,9 +114,9 @@ module ForemanWreckingball
         @missing_host = FactoryBot.create(:host, :managed, :with_vmware_facet, compute_resource: cr, owner: admin, uuid: 2)
 
         mock_vm = mock('vm')
-        mock_vm.stubs(:uuid).returns(@managed_host.uuid)
+        mock_vm.stubs(:id).returns(@managed_host.uuid)
         mock_vm.stubs(:name).returns(@managed_host.name)
-        Foreman::Model::Vmware.any_instance.stubs(:vms).returns(Array(mock_vm))
+        Foreman::Model::Vmware.any_instance.stubs(:vms).returns(OpenStruct.new(all: Array(mock_vm)))
       end
 
       test 'shows a status page' do
@@ -222,56 +222,108 @@ module ForemanWreckingball
     end
 
     describe '#schedule_remediate' do
-      let(:host) do
-        FactoryBot.create(:host, :with_wreckingball_statuses)
-      end
+      let(:host) { FactoryBot.create(:host, :with_wreckingball_statuses) }
+      let(:status_ids) { [host.vmware_tools_status_object.id] }
 
       test 'shows a remediation schedule page' do
-        get :schedule_remediate, params: { status_id: host.vmware_operatingsystem_status_object.id, id: host.id }, session: set_session_user
+        get :schedule_remediate, params: { status_ids: status_ids }, session: set_session_user
         assert_response :success
       end
 
-      test 'returns not found when host id is invalid' do
-        get :schedule_remediate, params: { status_id: nil, id: 'invalid' }, session: set_session_user
-        assert_response :not_found
+      context 'with status_id' do
+        let(:hosts) { FactoryBot.create_list(:host, 2, :with_wreckingball_statuses) }
+        let(:status_ids) { [hosts.first.vmware_operatingsystem_status_object.id] }
+
+        test 'remediate selected statuses' do
+          get :schedule_remediate, params: { status_ids: status_ids }, session: set_session_user
+          assert_same_elements HostStatus::Status.find(status_ids), assigns['statuses']
+        end
       end
 
-      test 'returns not found when status id is invalid' do
-        FactoryBot.create(:host, :with_wreckingball_statuses)
-        get :schedule_remediate, params: { status_id: 'invalid', id: host.id }, session: set_session_user
-        assert_response :not_found
+      context 'with host_association' do
+        let(:hosts) { FactoryBot.create_list(:host, 2, :with_wreckingball_statuses, owner: users(:admin)) }
+        let(:statuses) { hosts.map { |h| h.send(host_association) } }
+        let(:status_class) { ForemanWreckingball::OperatingsystemStatus }
+        let(:host_association) { status_class.host_association }
+
+        setup do
+          hosts.each { |h| h.send(host_association).update(status: status_class::MISMATCH) }
+        end
+
+        test 'remediate all statuses' do
+          get :schedule_remediate, params: { host_association: host_association }, session: set_session_user
+          assert_same_elements statuses, assigns['statuses']
+        end
+
+        context 'with owned_only' do
+          setup do
+            hosts_list = FactoryBot.create_list(:host, 2, :with_wreckingball_statuses, owner: users(:one))
+            hosts_list.each { |h| h.send(host_association).update(status: status_class::MISMATCH) }
+          end
+
+          test 'remediate only those statuses where the user is the owner of the host' do
+            get :schedule_remediate, params: { host_association: host_association, owned_only: true }, session: set_session_user
+            assert_same_elements statuses, assigns['statuses']
+          end
+        end
       end
     end
 
     describe '#submit_remediate' do
-      let(:host) do
-        FactoryBot.create(:host, :with_wreckingball_statuses)
+      let(:host) { FactoryBot.create(:host, :with_wreckingball_statuses) }
+      let(:status_ids) { [host.vmware_tools_status_object.id] }
+
+      setup do
+        ForemanTasks.stubs(:async_task).returns(fake_task)
       end
 
       test 'redirects to scheduled task' do
-        ForemanTasks.expects(:async_task).returns(fake_task)
-        post :submit_remediate, params: { status_id: host.vmware_operatingsystem_status_object.id, id: host.id }, session: set_session_user
+        post :submit_remediate, params: { status_ids: status_ids }, session: set_session_user
         assert_response :redirect
-        assert_includes flash[:success], 'successfully scheduled'
-        assert_redirected_to foreman_tasks_task_path(123)
+        assert_redirected_to foreman_tasks_task_path(fake_task.id)
       end
 
-      test 'raises error when status can not be remediated' do
-        FactoryBot.create(:host, :with_wreckingball_statuses)
-        assert_raises Foreman::Exception do
-          post :submit_remediate, params: { status_id: host.vmware_tools_status_object.id, id: host.id }, session: set_session_user
-        end
+      test 'returns not found when status_ids param is invalid' do
+        post :submit_remediate, params: { status_ids: 'invalid' }, session: set_session_user
+        assert_response :not_found
       end
 
-      test 'returns not found when host id is invalid' do
-        post :submit_remediate, params: { status_id: nil, id: 'invalid' }, session: set_session_user
-        assert_response :not_found
+      context 'with status_id' do
+        let(:hosts) { FactoryBot.create_list(:host, 2, :with_wreckingball_statuses) }
+        let(:status_ids) { [hosts.first.vmware_operatingsystem_status_object.id] }
+
+        test 'remediate selected statuses' do
+          post :submit_remediate, params: { status_ids: status_ids }, session: set_session_user
+          assert_same_elements HostStatus::Status.find(status_ids), assigns['statuses']
+        end
       end
 
-      test 'returns not found when status id is invalid' do
-        FactoryBot.create(:host, :with_wreckingball_statuses)
-        post :submit_remediate, params: { status_id: 'invalid', id: host.id }, session: set_session_user
-        assert_response :not_found
+      context 'with host_association' do
+        let(:hosts) { FactoryBot.create_list(:host, 2, :with_wreckingball_statuses, owner: users(:admin)) }
+        let(:statuses) { hosts.map { |h| h.send(host_association) } }
+        let(:status_class) { ForemanWreckingball::OperatingsystemStatus }
+        let(:host_association) { status_class.host_association }
+
+        setup do
+          hosts.each { |h| h.send(host_association).update(status: status_class::MISMATCH) }
+        end
+
+        test 'remediate all statuses' do
+          post :submit_remediate, params: { host_association: host_association }, session: set_session_user
+          assert_same_elements statuses, assigns['statuses']
+        end
+
+        context 'with owned_only' do
+          setup do
+            hosts_list = FactoryBot.create_list(:host, 2, :with_wreckingball_statuses, owner: users(:one))
+            hosts_list.each { |h| h.send(host_association).update(status: status_class::MISMATCH) }
+          end
+
+          test 'remediate only those statuses where the user is the owner of the host' do
+            post :submit_remediate, params: { host_association: host_association, owned_only: true }, session: set_session_user
+            assert_same_elements statuses, assigns['statuses']
+          end
+        end
       end
     end
   end

data/test/factories/compute_resource.rb

@@ -4,7 +4,7 @@ FactoryBot.modify do
   factory :compute_resource do
     trait :with_vmware_clusters do
       transient do
-        vmware_clusters_count 1
+        vmware_clusters_count { 1 }
       end
 
       after(:create) do |compute_resource, evaluator|

data/test/factories/foreman_wreckingball_factories.rb

@@ -3,129 +3,133 @@
 FactoryBot.define do
   factory :vmware_facet, class: 'ForemanWreckingball::VmwareFacet' do
     vmware_cluster
-    tools_state 2 #:toolsOk
-    power_state 1 #:poweredOn
-    cpus 2
-    corespersocket 1
-    memory_mb 8192
-    guest_id 'rhel6_64Guest'
-    cpu_hot_add false
-    hardware_version 'vmx-10'
-    cpu_features [
-      'cpuid.SSE3',
-      'cpuid.PCLMULQDQ',
-      'cpuid.SSSE3',
-      'cpuid.CMPXCHG16B',
-      'cpuid.PCID',
-      'cpuid.SSE41',
-      'cpuid.SSE42',
-      'cpuid.POPCNT',
-      'cpuid.AES',
-      'cpuid.XSAVE',
-      'cpuid.AVX',
-      'cpuid.DS',
-      'cpuid.SS',
-      'cpuid.XCR0_MASTER_SSE',
-      'cpuid.XCR0_MASTER_YMM_H',
-      'cpuid.LAHF64',
-      'cpuid.NX',
-      'cpuid.RDTSCP',
-      'cpuid.LM',
-      'cpuid.Intel'
-    ]
+    tools_state { 2 } #:toolsOk
+    power_state { 1 } #:poweredOn
+    cpus { 2 }
+    corespersocket { 1 }
+    memory_mb { 8192 }
+    guest_id { 'rhel6_64Guest' }
+    cpu_hot_add { false }
+    hardware_version { 'vmx-10' }
+    cpu_features do
+      [
+        'cpuid.SSE3',
+        'cpuid.PCLMULQDQ',
+        'cpuid.SSSE3',
+        'cpuid.CMPXCHG16B',
+        'cpuid.PCID',
+        'cpuid.SSE41',
+        'cpuid.SSE42',
+        'cpuid.POPCNT',
+        'cpuid.AES',
+        'cpuid.XSAVE',
+        'cpuid.AVX',
+        'cpuid.DS',
+        'cpuid.SS',
+        'cpuid.XCR0_MASTER_SSE',
+        'cpuid.XCR0_MASTER_YMM_H',
+        'cpuid.LAHF64',
+        'cpuid.NX',
+        'cpuid.RDTSCP',
+        'cpuid.LM',
+        'cpuid.Intel'
+      ]
+    end
     host
   end
 
   factory :vmware_hypervisor_facet, class: 'ForemanWreckingball::VmwareHypervisorFacet' do
     host
     vmware_cluster
-    cpu_cores 18
-    cpu_sockets 1
-    cpu_threads 36
-    memory 412_046_372_864
+    cpu_cores { 18 }
+    cpu_sockets { 1 }
+    cpu_threads { 36 }
+    memory { 412_046_372_864 }
     uuid { SecureRandom.uuid }
-    feature_capabilities [
-      'cpuid.3DNOW',
-      'cpuid.3DNOWPLUS',
-      'cpuid.3DNPREFETCH',
-      'cpuid.ABM',
-      'cpuid.ADX',
-      'cpuid.AES',
-      'cpuid.AMD',
-      'cpuid.AVX',
-      'cpuid.AVX2',
-      'cpuid.BMI1',
-      'cpuid.BMI2',
-      'cpuid.CMPXCHG16B',
-      'cpuid.CR8AVAIL',
-      'cpuid.Cyrix',
-      'cpuid.DS',
-      'cpuid.ENFSTRG',
-      'cpuid.EXTAPICSPC',
-      'cpuid.F16C',
-      'cpuid.FFXSR',
-      'cpuid.FMA',
-      'cpuid.FMA4',
-      'cpuid.FSGSBASE',
-      'cpuid.HLE',
-      'cpuid.IBPB',
-      'cpuid.IBRS',
-      'cpuid.INVPCID',
-      'cpuid.Intel',
-      'cpuid.LAHF64',
-      'cpuid.LM',
-      'cpuid.MISALIGNED_SSE',
-      'cpuid.MMXEXT',
-      'cpuid.MOVBE',
-      'cpuid.MWAIT',
-      'cpuid.NX',
-      'cpuid.PCID',
-      'cpuid.PCLMULQDQ',
-      'cpuid.PDPE1GB',
-      'cpuid.POPCNT',
-      'cpuid.PSN',
-      'cpuid.RDRAND',
-      'cpuid.RDSEED',
-      'cpuid.RDTSCP',
-      'cpuid.RTM',
-      'cpuid.SMAP',
-      'cpuid.SMEP',
-      'cpuid.SS',
-      'cpuid.SSE3',
-      'cpuid.SSE41',
-      'cpuid.SSE42',
-      'cpuid.SSE4A',
-      'cpuid.SSSE3',
-      'cpuid.STIBP',
-      'cpuid.SVM',
-      'cpuid.SVM_DECODE_ASSISTS',
-      'cpuid.SVM_FLUSH_BY_ASID',
-      'cpuid.SVM_NPT',
-      'cpuid.SVM_NRIP',
-      'cpuid.SVM_VMCB_CLEAN',
-      'cpuid.TBM',
-      'cpuid.VIA',
-      'cpuid.VMX',
-      'cpuid.XCR0_MASTER_SSE',
-      'cpuid.XCR0_MASTER_YMM_H',
-      'cpuid.XOP',
-      'cpuid.XSAVE',
-      'cpuid.XSAVEOPT',
-      'hv.capable',
-      'misc.cpuidFaulting',
-      'vpmc.fixctr.0',
-      'vpmc.fixedWidth',
-      'vpmc.genWidth',
-      'vpmc.genctr.0',
-      'vpmc.genctr.1',
-      'vpmc.genctr.2',
-      'vpmc.genctr.3',
-      'vpmc.microarchitecture.ivybridge',
-      'vpmc.numFixedCtrs',
-      'vpmc.numGenCtrs',
-      'vpmc.version',
-      'vt.realmode'
-    ]
+    feature_capabilities do
+      [
+        'cpuid.3DNOW',
+        'cpuid.3DNOWPLUS',
+        'cpuid.3DNPREFETCH',
+        'cpuid.ABM',
+        'cpuid.ADX',
+        'cpuid.AES',
+        'cpuid.AMD',
+        'cpuid.AVX',
+        'cpuid.AVX2',
+        'cpuid.BMI1',
+        'cpuid.BMI2',
+        'cpuid.CMPXCHG16B',
+        'cpuid.CR8AVAIL',
+        'cpuid.Cyrix',
+        'cpuid.DS',
+        'cpuid.ENFSTRG',
+        'cpuid.EXTAPICSPC',
+        'cpuid.F16C',
+        'cpuid.FFXSR',
+        'cpuid.FMA',
+        'cpuid.FMA4',
+        'cpuid.FSGSBASE',
+        'cpuid.HLE',
+        'cpuid.IBPB',
+        'cpuid.IBRS',
+        'cpuid.INVPCID',
+        'cpuid.Intel',
+        'cpuid.LAHF64',
+        'cpuid.LM',
+        'cpuid.MISALIGNED_SSE',
+        'cpuid.MMXEXT',
+        'cpuid.MOVBE',
+        'cpuid.MWAIT',
+        'cpuid.NX',
+        'cpuid.PCID',
+        'cpuid.PCLMULQDQ',
+        'cpuid.PDPE1GB',
+        'cpuid.POPCNT',
+        'cpuid.PSN',
+        'cpuid.RDRAND',
+        'cpuid.RDSEED',
+        'cpuid.RDTSCP',
+        'cpuid.RTM',
+        'cpuid.SMAP',
+        'cpuid.SMEP',
+        'cpuid.SS',
+        'cpuid.SSE3',
+        'cpuid.SSE41',
+        'cpuid.SSE42',
+        'cpuid.SSE4A',
+        'cpuid.SSSE3',
+        'cpuid.STIBP',
+        'cpuid.SVM',
+        'cpuid.SVM_DECODE_ASSISTS',
+        'cpuid.SVM_FLUSH_BY_ASID',
+        'cpuid.SVM_NPT',
+        'cpuid.SVM_NRIP',
+        'cpuid.SVM_VMCB_CLEAN',
+        'cpuid.TBM',
+        'cpuid.VIA',
+        'cpuid.VMX',
+        'cpuid.XCR0_MASTER_SSE',
+        'cpuid.XCR0_MASTER_YMM_H',
+        'cpuid.XOP',
+        'cpuid.XSAVE',
+        'cpuid.XSAVEOPT',
+        'hv.capable',
+        'misc.cpuidFaulting',
+        'vpmc.fixctr.0',
+        'vpmc.fixedWidth',
+        'vpmc.genWidth',
+        'vpmc.genctr.0',
+        'vpmc.genctr.1',
+        'vpmc.genctr.2',
+        'vpmc.genctr.3',
+        'vpmc.microarchitecture.ivybridge',
+        'vpmc.numFixedCtrs',
+        'vpmc.numGenCtrs',
+        'vpmc.version',
+        'vt.realmode'
+      ]
+    end
   end
 
   factory :vmware_cluster, class: 'ForemanWreckingball::VmwareCluster' do

data/test/factories/task.rb

@@ -3,15 +3,15 @@
 FactoryBot.modify do
   factory :some_task do
     trait :running do
-      state 'running'
+      state { 'running' }
     end
 
     trait :stopped do
-      state 'stopped'
+      state { 'stopped' }
     end
 
     trait :vmware_sync do
-      label ::Actions::ForemanWreckingball::Vmware::ScheduleVmwareSync.to_s
+      label { ::Actions::ForemanWreckingball::Vmware::ScheduleVmwareSync.to_s }
     end
   end
 end

data/test/helpers/foreman_wreckingball/status_helper.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+module ForemanWreckingball
+  module StatusHelper
+    def assert_statuses(expected)
+      actual = request.env['action_controller.instance'].instance_variable_get('@statuses')
+      assert_same_elements expected, actual
+    end
+  end
+end

data/test/integration/hosts_status_dashboard_test.rb

@@ -23,28 +23,28 @@ class HostsStatusDashboardTest < ActionDispatch::IntegrationTest
     lists = find_all('div.list-view-pf-main-info')
 
     # VMWare Tools
-    assert_text lists[0].text, '1 OK'
-    assert_text lists[0].text, '0 Warning'
-    assert_text lists[0].text, '0 Critical'
+    assert_includes lists[0].text, '1 OK'
+    assert_includes lists[0].text, '0 Warning'
+    assert_includes lists[0].text, '0 Critical'
 
     # VMWare Operating System
-    assert_text lists[1].text, '2 OK'
-    assert_text lists[1].text, '0 Warning'
-    assert_text lists[1].text, '0 Critical'
+    assert_includes lists[1].text, '2 OK'
+    assert_includes lists[1].text, '0 Warning'
+    assert_includes lists[1].text, '0 Critical'
 
     # VMWare CPU Hot Plug
-    assert_text lists[2].text, '3 OK'
-    assert_text lists[2].text, '0 Warning'
-    assert_text lists[2].text, '0 Critical'
+    assert_includes lists[2].text, '3 OK'
+    assert_includes lists[2].text, '0 Warning'
+    assert_includes lists[2].text, '0 Critical'
 
     # VMWare Spectre V2
-    assert_text lists[3].text, '4 OK'
-    assert_text lists[3].text, '0 Warning'
-    assert_text lists[3].text, '5 Critical'
+    assert_includes lists[3].text, '4 OK'
+    assert_includes lists[3].text, '0 Warning'
+    assert_includes lists[3].text, '5 Critical'
 
     # VMWare Hardware Version
-    assert_text lists[4].text, '6 OK'
-    assert_text lists[4].text, '7 Warning'
-    assert_text lists[4].text, '0 Critical'
+    assert_includes lists[4].text, '6 OK'
+    assert_includes lists[4].text, '7 Warning'
+    assert_includes lists[4].text, '0 Critical'
   end
 end

data/test/integration/hosts_status_managed_hosts_test.rb

@@ -25,9 +25,9 @@ class HostsStatusManagedHostsTest < ActionDispatch::IntegrationTest
     missing_host = FactoryBot.create(:host, :managed, compute_resource: cr, owner: admin, uuid: 2)
 
     mock_vm = mock('vm')
-    mock_vm.stubs(:uuid).returns(managed_host.uuid)
+    mock_vm.stubs(:id).returns(managed_host.uuid)
     mock_vm.stubs(:name).returns(managed_host.name)
-    Foreman::Model::Vmware.any_instance.stubs(:vms).returns(Array(mock_vm))
+    Foreman::Model::Vmware.any_instance.stubs(:vms).returns(OpenStruct.new(all: Array(mock_vm)))
 
     visit status_managed_hosts_dashboard_hosts_path
 
@@ -36,25 +36,37 @@ class HostsStatusManagedHostsTest < ActionDispatch::IntegrationTest
     refute_includes list.text, managed_host.name
   end
 
-  test 'shows duplicate vms with same uuid for a host' do
-    managed_host = FactoryBot.create(:host, :managed, compute_resource: cr, owner: admin, uuid: 1)
+  test 'shows hosts associated to wrong compute resource' do
+    other_cr = FactoryBot.create(
+      :vmware_cr,
+      uuid: 'bla',
+      organizations: [organization],
+      locations: [tax_location]
+    )
+
+    correct_host = FactoryBot.create(:host, :managed, compute_resource: cr, owner: admin, uuid: 1)
+    incorrect_host = FactoryBot.create(:host, :managed, compute_resource: cr, owner: admin, uuid: 2)
 
     mock1_vm = mock('vm1')
-    mock1_vm.stubs(:uuid).returns(managed_host.uuid)
+    mock1_vm.stubs(:id).returns(correct_host.uuid)
     mock1_vm.stubs(:name).returns('foo01.example.com')
     mock2_vm = mock('vm2')
-    mock2_vm.stubs(:uuid).returns(managed_host.uuid)
+    mock2_vm.stubs(:id).returns(incorrect_host.uuid)
     mock2_vm.stubs(:name).returns('foo02.example.com')
-    Foreman::Model::Vmware.any_instance.stubs(:vms).returns([mock1_vm, mock2_vm])
+
+    cr.stubs(:vms).returns(OpenStruct.new(all: [mock1_vm]))
+    other_cr.stubs(:vms).returns(OpenStruct.new(all: [mock2_vm]))
+
+    Foreman::Model::Vmware.stubs(:unscoped).returns(OpenStruct.new(all: [cr, other_cr]))
 
     visit status_managed_hosts_dashboard_hosts_path
 
-    list = page.find('#duplicate_vms')
-    assert_includes list.text, 'foo01.example.com'
-    assert_includes list.text, 'foo02.example.com'
+    list = page.find('#wrong_hosts')
+    refute_includes list.text, correct_host.name
+    assert_includes list.text, incorrect_host.name
   end
 
-  test 'shows hosts with vm associated with a different compute resource' do
+  test 'shows hosts that can be found one more than one compute resource' do
     other_cr = FactoryBot.create(
       :vmware_cr,
       uuid: 'bla',
@@ -69,23 +81,23 @@ class HostsStatusManagedHostsTest < ActionDispatch::IntegrationTest
     managed3_host = FactoryBot.create(:host, :managed, compute_resource: other_cr, owner: admin, uuid: 3)
 
     mock1_vm = mock('vm1')
-    mock1_vm.stubs(:uuid).returns(managed1_host.uuid)
+    mock1_vm.stubs(:id).returns(managed1_host.uuid)
     mock1_vm.stubs(:name).returns(managed1_host.name)
     mock2_vm = mock('vm2')
-    mock2_vm.stubs(:uuid).returns(managed2_host.uuid)
+    mock2_vm.stubs(:id).returns(managed2_host.uuid)
     mock2_vm.stubs(:name).returns(managed2_host.name)
     mock3_vm = mock('vm3')
-    mock3_vm.stubs(:uuid).returns(managed3_host.uuid)
+    mock3_vm.stubs(:id).returns(managed3_host.uuid)
     mock3_vm.stubs(:name).returns(managed3_host.name)
 
-    cr.stubs(:vms).returns([mock1_vm, mock2_vm])
-    other_cr.stubs(:vms).returns([mock3_vm])
+    cr.stubs(:vms).returns(OpenStruct.new(all: [mock1_vm, mock2_vm]))
+    other_cr.stubs(:vms).returns(OpenStruct.new(all: [mock2_vm, mock3_vm]))
 
-    ComputeResource.stubs(:where).returns([cr, other_cr])
+    Foreman::Model::Vmware.stubs(:unscoped).returns(OpenStruct.new(all: [cr, other_cr]))
 
     visit status_managed_hosts_dashboard_hosts_path
 
-    list = page.find('#different_vms')
+    list = page.find('#more_than_one_hosts')
     refute_includes list.text, managed1_host.name
     assert_includes list.text, managed2_host.name
     refute_includes list.text, managed3_host.name

data/test/integration_test_plugin_helper.rb

@@ -6,6 +6,7 @@ require 'webmock/minitest'
 require 'webmock'
 
 # Add plugin to FactoryBot's paths
+FactoryBot.definition_file_paths << File.join(ForemanTasks::Engine.root, 'test', 'factories')
 FactoryBot.definition_file_paths << File.join(File.dirname(__FILE__), 'factories')
 FactoryBot.reload
 

data/test/models/foreman_wreckingball/vmware_facet_test.rb

@@ -62,12 +62,12 @@ module ForemanWreckingball
 
       setup do
         ::Fog.mock!
-        ::Fog::Compute::Vsphere::Mock.any_instance.stubs(:get_vm_ref).returns(vm)
+        ::ForemanWreckingball.fog_vsphere_namespace::Mock.any_instance.stubs(:get_vm_ref).returns(vm)
         # this is not stubbed correctly in fog-vsphere
-        ::Fog::Compute::Vsphere::Server.any_instance.stubs(:cpuHotAddEnabled).returns(false)
-        ::Fog::Compute::Vsphere::Server.any_instance.stubs(:hardware_version).returns('vmx-9')
-        ::Fog::Compute::Vsphere::Server.any_instance.stubs(:corespersocket).returns(1)
-        ::Fog::Compute::Vsphere::Server.any_instance.stubs(:power_state).returns('poweredOn')
+        ::ForemanWreckingball.fog_vsphere_namespace::Server.any_instance.stubs(:cpuHotAddEnabled).returns(false)
+        ::ForemanWreckingball.fog_vsphere_namespace::Server.any_instance.stubs(:hardware_version).returns('vmx-9')
+        ::ForemanWreckingball.fog_vsphere_namespace::Server.any_instance.stubs(:corespersocket).returns(1)
+        ::ForemanWreckingball.fog_vsphere_namespace::Server.any_instance.stubs(:power_state).returns('poweredOn')
       end
       teardown { ::Fog.unmock! }
 

data/test/models/host_test.rb

@@ -24,9 +24,9 @@ class Host::ManagedTest < ActiveSupport::TestCase
         FactoryBot.create(:host, :managed, owner: usergroup_with_user),
         FactoryBot.create(:host, :managed, owner: FactoryBot.create(:usergroup, usergroups: [usergroup_with_user]))
       ]
-      actual = Host::Managed.owned_by_current_user_or_group_with_current_user
+      actual = Host::Managed.owned_by_current_user_or_group_with_current_user.all
 
-      assert_equal expected, actual
+      assert_same_elements expected, actual
     end
   end
 

data/test/test_plugin_helper.rb

@@ -5,6 +5,8 @@ require 'test_helper'
 require 'database_cleaner'
 require 'dynflow/testing'
 
+Dir["#{__dir__}/helpers/foreman_wreckingball/**.rb"].each { |f| require f }
+
 # Add plugin to FactoryBot's paths
 FactoryBot.definition_file_paths << File.join(ForemanTasks::Engine.root, 'test', 'factories')
 FactoryBot.definition_file_paths << File.join(File.dirname(__FILE__), 'factories')