foreman_wreckingball 3.2.0 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: de6be68d909a39447b86fc7b8ce9f372cc12c929364910205beac6d8dc244829
-  data.tar.gz: 2908a912c935764b978d0f094306ecbad458c70c9bed5138051f52d73f83697f
+  metadata.gz: 5038fc9d12985cb5fb7ee83a5dc72567d63a04fc11ff5d8d17c09d4cc59ea6b9
+  data.tar.gz: 1579d2bb8bb7c35188b76861b84611a190103fdef76f3135f2b3776d86a34003
 SHA512:
-  metadata.gz: d4de761155c5e670000022056211ad3f4064a303914b869c8624f40679b723e6d90d7aa2ba3f156c9f2b535a02a9474cf8c817b7e967f537e7ca8e843a764a84
-  data.tar.gz: 84e82bf20310a20cde12e50dcacd5fb84ab638e1eabf280aefbf3f1cb3d9a1253cbb57136dbb29ea618e95425380cd296a011f8dc40738b7339837833fd5bfa5
+  metadata.gz: ca6aefe61f1d908461e3f527b8384046923cbe3ecc20864165394532b4735587d1bab362836d2ae044c1c3b1a4d4e48e433bbeec34c7beaba18d20c62cc9f4bf
+  data.tar.gz: cfe558ecd67daf5a1b76943396df76626461023f80bae31662aad1cdbc6e4786206ee0307879b5e4d4725b9ecf75fa8a963bbf1f0f98dd7995e3bbe29330a653

data/app/assets/javascripts/foreman_wreckingball/modal.js

@@ -9,29 +9,38 @@ function submit_modal_form() {
   $('#confirmation-modal').modal('hide');
 }
 
-function show_modal(element, url) {
-  if (!url) {
-    url = $(element).attr('href');    
-  }
-  var title = $(element).attr('data-title');
-  if (title) {
-    $('#confirmation-modal .modal-title').text(title);
-  }
+function show_modal(element) {
+  if ($(element).attr('disabled')) { return; }
+
+  const url = $(element).attr('href');
+  const title = $(element).data('title');
+  const hostAssociation = $(element).data('host-association');
+
+  if (title) { $('#confirmation-modal .modal-title').text(title); }
+
   $('#confirmation-modal .modal-body')
     .empty()
     .append('<div class="modal-spinner spinner spinner-lg"></div>');
   $('#confirmation-modal').modal();
-  $('#confirmation-modal .modal-body').load(url + ' #content',
-    function(response, status, xhr) {
-      $('#confirmation-modal .form-actions').remove();
 
-      var submit_button = $('#confirmation-modal button[data-action="submit"]');
-      if ($(element).attr('data-submit-class')) {
-        submit_button.attr('class', 'btn ' + $(element).attr('data-submit-class'));
-      } else {
-        submit_button.attr('class', 'btn btn-primary');
-      }
+  let params;
+  if (!!hostAssociation) {
+    params = Object.assign({}, { host_association: hostAssociation },
+      !!$(element).data('owned-only') ? { owned_only: true } : null);
+  } else if($(element).data('status-id')) {
+    params = { status_ids: [$(element).data('status-id')] };
+  } else {
+    const statusIds = $(element).closest('.status-row')
+      .find(':checkbox[name="status-id"]:checked')
+      .map((_, e) => { return e.value; })
+      .toArray();
+    params = { status_ids: statusIds };
+  }
 
+  $('#confirmation-modal .modal-body').load(`${url}?${$.param(params)} #content`,
+    (response, status, xhr) => {
+      $('#confirmation-modal .form-actions').remove();
+      $('#confirmation-modal button[data-action="submit"]').attr('class', 'btn btn-primary');
       $('#confirmation-modal a[rel="popover"]').popover();
 
       trigger_form_selector_binds('schedule_remediate_form', url);

data/app/assets/javascripts/foreman_wreckingball/status_hosts_table.js

@@ -10,7 +10,8 @@ $(document).ready(() => {
         processing: true,
         serverSide: true,
         columnDefs: [
-          { className: 'ellipsis', targets: [0, 1, 2, 3] }
+          { className: 'ellipsis', targets: [1, 2, 3, 4] },
+          { width: '10px', targets: 0 }
         ],
         ajax: {
           url: $(element).data('hosts-url'),
@@ -26,13 +27,23 @@ $(document).ready(() => {
           dataSrc: (json) => {
             return json.data.map((e) => {
               let row = [
+                `<input name='status-id' type='checkbox' value='${e.status.id}' data-remediate='${!!e.remediate}' >`,
                 `<a href="${e.path}">${e.name}</a>`,
                 `<span class="${e.status.icon_class}"></span><span class="${e.status.status_class}">${e.status.label}</span>`,
                 (e.owner || {}).name || '',
                 (e.environment || {}).name || ''
               ];
               if(e.remediate) {
-                row.push(`<span class="btn btn-sm btn-default"><a data-title="${e.remediate.title}" data-submit-class="btn-danger" onclick="show_modal(this); return false;" data-id="aid_wreckingball_hosts_${e.name}_schedule_remediate" href="${e.remediate.path}">${e.remediate.label}</a></span>`);
+                row.push(`
+                  <span class="btn btn-sm btn-default">
+                    <a data-title="${e.remediate.title}"
+                       data-id="aid_wreckingball_hosts_${e.name}_schedule_remediate"
+                       data-status-id="${e.status.id}"
+                       onclick="show_modal(this); return false;"
+                       href="${e.remediate.path}">
+                         ${e.remediate.label}
+                    </a>
+                  </span>`);
               } else {
                 row.push(null);
               }
@@ -44,6 +55,27 @@ $(document).ready(() => {
       $(element).on('error.dt', (_, settings) => {
         $(settings.nTable).closest('.status-hosts-container').addClass('ajax-error');
       });
+      $(element).on('page.dt', () => {
+        $selectAll.prop('checked', false).change();
+        $remediateSelected.attr('disabled', true);
+      });
+
+      const $selectAll = $(this).find(':checkbox[name="select-all"]');
+      const $remediateSelected = $(this).find('a.remediate-selected');
+
+      $selectAll.prop('checked', false);
+
+      $selectAll.change(() => {
+        const $selectHost = $(this).find(':checkbox[name="status-id"]');
+        $selectHost.prop('checked', $selectAll.is(':checked'));
+        $remediateSelected.attr('disabled', !$selectAll.is(':checked'));
+      });
+
+      $(this).on('change', ':checkbox[name=status-id]', () => {
+        const isAnyHostChecked = $(this).find(':checkbox[name="status-id"]').is(':checked');
+        $selectAll.prop('checked', isAnyHostChecked);
+        $remediateSelected.attr('disabled', !isAnyHostChecked);
+      });
     });
   });
 });

data/app/assets/javascripts/foreman_wreckingball/status_managed_hosts_dashboard.js

@@ -0,0 +1,8 @@
+$(document).ready(() => {
+  $('table#missing_vms').add('table#duplicate_vms').add('table#different_vms')
+    .DataTable({
+      bLengthChange: true,
+      lengthMenu: [20, 50, 100],
+      order: [[ 0, 'desc' ]]
+    });
+});

data/app/assets/stylesheets/foreman_wreckingball/status_managed_hosts_dashboard.css.scss

@@ -0,0 +1,8 @@
+.status-managed-hosts-dashboard-cards {
+  .card-pf.card-pf-accented.card-pf-aggregate-status {
+    min-height: 100px;
+    .card-pf-title {
+      min-height: 30px;
+    }
+  }
+}

data/app/controllers/foreman_wreckingball/hosts_controller.rb

@@ -12,8 +12,7 @@ module ForemanWreckingball
 
     AJAX_REQUESTS = [:status_hosts].freeze
     before_action :ajax_request, :only => AJAX_REQUESTS
-    before_action :find_resource, :only => [:submit_remediate, :schedule_remediate]
-    before_action :find_status, :only => [:submit_remediate, :schedule_remediate]
+    before_action :find_statuses, :only => [:schedule_remediate, :submit_remediate]
 
     def status_dashboard
       @newest_data = Host.authorized(:view_hosts).joins(:vmware_facet).maximum('vmware_facets.updated_at')
@@ -43,27 +42,24 @@ module ForemanWreckingball
     end
 
     def status_managed_hosts_dashboard
-      @hosts = Host::Managed.authorized(:view_hosts, Host)
-                            .try { |query| params[:owned_only] ? query.owned_by_current_user_or_group_with_current_user : query }
-
-      compute_resources = ComputeResource.where(:type => 'Foreman::Model::Vmware')
-
-      # get all vms by compute resource id
-      vms_by_compute_resource_id = {}
       # NOTE The call to ComputeResource#vms may slow things down
-      compute_resources.each { |cr| vms_by_compute_resource_id[cr.id] = cr.vms(eager_loading: true) }
-
-      vms_by_uuid = vms_by_compute_resource_id.values.flatten.group_by(&:uuid)
+      vms_by_compute_resource_id = Foreman::Model::Vmware.all.each_with_object({}) do |cr, memo|
+        memo[cr.id] = cr.vms(eager_loading: true)
+      end
 
       # Find all hosts with duplicate VMs
-      @duplicate_vms = vms_by_uuid.select { |_uuid, vms| vms.size > 1 }
+      @duplicate_vms = vms_by_compute_resource_id.values
+                                                 .flatten
+                                                 .group_by(&:uuid)
+                                                 .select { |_uuid, vms| vms.size > 1 }
 
       @missing_hosts = []
       @different_hosts = []
 
-      @hosts.each do |host|
-        next unless host.compute_resource_id
-
+      Host::Managed.authorized(:view_hosts, Host)
+                   .where.not(compute_resource_id: nil)
+                   .try { |query| params[:owned_only] ? query.owned_by_current_user_or_group_with_current_user : query }
+                   .each do |host|
         # find the compute resource id of the host in the vm map
         cr_id, _vms = vms_by_compute_resource_id.find { |_cr_id, vms| vms.find { |vm| vm.uuid == host.uuid } }
 
@@ -79,7 +75,7 @@ module ForemanWreckingball
 
     # ajax method
     def status_hosts
-      @status = HostStatus.find_wreckingball_status_by_host_association(params.fetch(:status).to_sym)
+      @status = HostStatus.find_wreckingball_status_by_host_association(params.fetch(:status))
 
       all_hosts = Host.authorized(:view_hosts, Host)
                       .joins(@status.host_association)
@@ -119,20 +115,21 @@ module ForemanWreckingball
     end
 
     def submit_remediate
-      raise Foreman::Exception, _('VMware Status can not be remediated.') unless @status.class.respond_to?(:supports_remediate?) && @status.class.supports_remediate?
-      task = User.as_anonymous_admin do
-        triggering = ::ForemanTasks::Triggering.new_from_params(triggering_params)
-        if triggering.future?
-          triggering.parse_start_at!
-          triggering.parse_start_before!
-        else
-          triggering.start_at ||= Time.zone.now
-        end
+      return not_found unless @statuses.any?
+
+      triggering = ::ForemanTasks::Triggering.new_from_params(triggering_params)
+      if triggering.future?
+        triggering.parse_start_at!
+        triggering.parse_start_before!
+      else
+        triggering.start_at ||= Time.zone.now
+      end
 
-        triggering.trigger(@status.class.remediate_action, @host)
+      task = User.as_anonymous_admin do
+        triggering.trigger(::Actions::ForemanWreckingball::BulkRemediate, @statuses)
       end
-      flash[:success] = _('Remediate VM task for %s was successfully scheduled.') % @host
-      redirect_to(foreman_tasks_task_path(task.id))
+
+      redirect_to foreman_tasks_task_path(task.id)
     end
 
     private
@@ -143,8 +140,27 @@ module ForemanWreckingball
       end
     end
 
-    def find_status
-      @status = HostStatus::Status.find_by!(:id => params[:status_id], :host_id => @host.id)
+    def statuses_params
+      @statuses_params ||= params.permit(:host_association, :owned_only, status_ids: [])
+    end
+
+    def find_statuses
+      @statuses = begin
+        host_association = statuses_params[:host_association]
+        status_class = HostStatus.find_wreckingball_status_by_host_association(host_association)
+        if status_class
+          Host.authorized(:remediate_vmware_status_hosts, Host)
+              .joins(status_class.host_association)
+              .includes(status_class.host_association)
+              .try { |query| statuses_params[:owned_only] ? query.owned_by_current_user_or_group_with_current_user : query }
+              .where.not('host_status.status': status_class.global_ok_list)
+              .map { |host| host.send(status_class.host_association) }
+        else
+          HostStatus::Status.includes(:host).where(id: statuses_params[:status_ids]).select do |status|
+            User.current.can?(:remediate_vmware_status_hosts, status.host)
+          end
+        end
+      end
     end
 
     def action_permission

data/app/helpers/foreman_wreckingball/statuses_helper.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module ForemanWreckingball
+  module StatusesHelper
+    def status_actions(host_association, owned_only, supports_remediate)
+      actions = []
+      actions << display_link_if_authorized(_('Refresh'),
+                                            hash_for_refresh_status_dashboard_hosts_path,
+                                            title: _('Refresh Data'),
+                                            method: :put)
+      if supports_remediate
+        actions << display_link_if_authorized(_('Remediate All'),
+                                              hash_for_schedule_remediate_hosts_path,
+                                              'data-host-association': host_association,
+                                              'data-owned-only': owned_only,
+                                              onClick: 'show_modal(this); return false;')
+      end
+      actions.reject(&:blank?)
+    end
+  end
+end

data/app/lib/actions/foreman_wreckingball/bulk_remediate.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+module Actions
+  module ForemanWreckingball
+    class BulkRemediate < Actions::Base
+      def plan(statuses)
+        sequence do
+          statuses.group_by(&:class).each do |statuses_klass, statuses_list|
+            plan_action(::Actions::BulkAction, statuses_klass.remediate_action, statuses_list.map(&:host)) if statuses_klass.respond_to?(:remediate_action)
+          end
+        end
+      end
+
+      def run
+        # dummy run phase to save input
+      end
+
+      def resource_locks
+        :link
+      end
+
+      def humanized_name
+        _('Bulk remediate')
+      end
+    end
+  end
+end

data/app/models/concerns/foreman_wreckingball/host_status_extensions.rb

@@ -7,7 +7,7 @@ module ForemanWreckingball
     end
 
     def find_wreckingball_status_by_host_association(host_association)
-      wreckingball_statuses.find { |s| s.host_association == host_association }
+      wreckingball_statuses.find { |s| s.host_association.to_s == host_association.to_s }
     end
   end
 end

data/app/views/foreman_wreckingball/hosts/_hosts.json.rabl

@@ -2,7 +2,7 @@
 
 collection @hosts
 
-attributes :name
+attributes :id, :name
 
 child owner: :owner do
   attribute :name
@@ -17,6 +17,7 @@ node(:path) { |host| host_path(host) }
 node(:status) do |host|
   status = host.public_send(locals[:host_association])
   {
+    id: status.id,
     label: status.to_label,
     icon_class: host_global_status_icon_class(status.to_global),
     status_class: host_global_status_class(status.to_global)
@@ -24,18 +25,11 @@ node(:status) do |host|
 end
 
 node(:remediate, if: lambda do |host|
-  locals[:supports_remediate] && begin
-    options = hash_for_schedule_remediate_host_path(id: host,
-                                                    status_id: host.public_send(locals[:host_association]).id)
-                                                                   .merge(auth_object: host,
-                                                                          permission: :remediate_vmware_status_hosts)
-    authorized_for(options)
-  end
-end) do |host|
-  status_id = host.public_send(locals[:host_association]).id
+  locals[:supports_remediate] && User.current.can?(:remediate_vmware_status_hosts, host)
+end) do
   {
     label: _('Remediate'),
     title: _('Remediate Host OS'),
-    path: schedule_remediate_host_path(host, status_id: status_id)
+    path: schedule_remediate_hosts_path
   }
 end

data/app/views/foreman_wreckingball/hosts/_status_dashboard_content.erb

@@ -24,6 +24,8 @@
     counter: status[:counter],
     status: status[:host_association],
     supports_remediate: status[:supports_remediate],
+    host_association: status[:host_association],
+    owned_only: params[:owned_only],
     id: idx
   }
 %>

data/app/views/foreman_wreckingball/hosts/_status_managed_hosts_dashboard_cards.html.erb

@@ -0,0 +1,16 @@
+<div class='status-managed-hosts-dashboard-cards container-fluid container-cards-pf'>
+  <div class='row row-cards-pf'>
+    <%= render partial: 'status_managed_hosts_dashboard_cards_card', locals: {
+      title: _('List of Hosts not found in vSphere'),
+      count: missing_hosts_count
+    } %>
+    <%= render partial: 'status_managed_hosts_dashboard_cards_card', locals: {
+      title: _('List of VMs with same uuid'),
+      count: duplicate_vms_count
+    } %>
+    <%= render partial: 'status_managed_hosts_dashboard_cards_card', locals: {
+      title: _('List of VMs associated with different compute resources'),
+      count: different_hosts_count
+    } %>
+  </div>
+</div>

data/app/views/foreman_wreckingball/hosts/_status_managed_hosts_dashboard_cards_card.html.erb

@@ -0,0 +1,11 @@
+<div class='col-xs-12 col-sm-4'>
+  <div class='card-pf card-pf-accented card-pf-aggregate-status'>
+    <%= content_tag :h2, title, class: 'card-pf-title' %>
+    <div class='card-pf-body'>
+      <p class='card-pf-aggregate-status-notifications'>
+        <%= content_tag :span, nil, class: "pficon pficon-#{count > 0 ? 'error-circle-o' : 'ok'}" %>
+        <%= count if count > 0 %>
+      </p>
+    </div>
+  </div>
+</div>

data/app/views/foreman_wreckingball/hosts/_status_row.html.erb

@@ -3,18 +3,14 @@
     <div class="list-view-pf-expand">
       <span class="fa fa-angle-right"></span>
     </div>
-    <div class="list-view-pf-actions">
-      <% if User.current.allowed_to?(hash_for_refresh_status_dashboard_hosts_path) %>
-        <div class="dropdown pull-right dropdown-kebab-pf">
-          <button class="btn btn-link dropdown-toggle" type="button" id="dropdownKebabRight<%= id %>" data-toggle="dropdown" aria-haspopup="true" aria-expanded="true">
-            <span class="fa fa-ellipsis-v"></span>
-          </button>
-          <ul class="dropdown-menu dropdown-menu-right" aria-labelledby="dropdownKebabRight<%= id %>">
-            <li><%= display_link_if_authorized(_('Refresh'), hash_for_refresh_status_dashboard_hosts_path, :title => _('Refresh data'), :method => :put) %></li>
-          </ul>
-        </div>
-      <% end %>
-    </div>
+    <%=
+      render :partial => 'status_row_actions', locals: {
+        id: id,
+        supports_remediate: supports_remediate,
+        host_association: host_association,
+        owned_only: owned_only
+      }
+    %>
     <div class="list-view-pf-main-info">
       <div class="list-view-pf-left">
         <span class="pficon list-view-pf-icon-md <%= classes_for_vmware_status_row(counter) %>"></span>

data/app/views/foreman_wreckingball/hosts/_status_row_actions.html.erb

@@ -0,0 +1,22 @@
+<% actions = status_actions(host_association, owned_only, supports_remediate) %>
+
+<% if actions.any? %>
+  <div class='list-view-pf-actions'>
+    <div class='dropdown pull-right dropdown-kebab-pf'>
+      <%= content_tag :button, class: 'btn btn-link dropdown-toggle',
+                               type: 'button',
+                               id: "dropdownKebabRight#{id}",
+                               'data-toggle': 'dropdown',
+                               'aria-haspopup': true,
+                               'aria-expanded': true do %>
+        <span class='fa fa-ellipsis-v' />
+      <% end %>
+
+      <%= content_tag :ul, class: 'dropdown-menu dropdown-menu-right', 'aria-labelledby': "dropdownKebabRight#{id}" do %>
+        <% actions.each do |action| %>
+          <%= content_tag :li, action %>
+        <% end %>
+      <% end %>
+    </div>
+  </div>
+<% end %>

data/app/views/foreman_wreckingball/hosts/_status_row_hosts_table.html.erb

@@ -1,8 +1,13 @@
+<%= render :partial => 'status_row_hosts_table_actions', locals: { supports_remediate: supports_remediate } %>
+
 <%= content_tag :table, id: status,
                         class: 'table table-striped table-fixed status-hosts',
                         'data-hosts-url': ajax_status_dashboard_hosts_path(status, owned_only: params[:owned_only]) do %>
   <%= content_tag :thead do %>
     <%= content_tag :tr do %>
+      <%= content_tag :th do %>
+        <%= check_box_tag 'select-all' %>
+      <% end %>
       <%= content_tag :th, _('Hostname') %>
       <%= content_tag :th, _('Status') %>
       <%= content_tag :th, _('Owner') %>
@@ -13,5 +18,7 @@
   <%= content_tag(:tbody) {} %>
 <% end %>
 
+<%= render :partial => 'status_row_hosts_table_actions', locals: { supports_remediate: supports_remediate } %>
+
 <%= alert header: _("Oops, we're sorry but something went wrong"), text: '',
           class: 'alert-danger', close: false %>

data/app/views/foreman_wreckingball/hosts/_status_row_hosts_table_actions.html.erb

@@ -0,0 +1,9 @@
+<%= content_tag :div, class: 'text-right' do %>
+  <% if supports_remediate %>
+    <%= content_tag :a, _('Remediate selected'),
+                        href: schedule_remediate_hosts_path,
+                        class: 'btn btn-default remediate-selected',
+                        onclick: 'show_modal(this); return false;',
+                        disabled: true %>
+  <% end %>
+<% end %>

data/app/views/foreman_wreckingball/hosts/schedule_remediate.html.erb

@@ -1,35 +1,53 @@
-<% title _('Remediate %s') % @host %>
+<% title _('Remediate') %>
 <% javascript 'foreman_tasks/trigger_form' %>
 <% stylesheet 'foreman_tasks/trigger_form' %>
 
+<% if @statuses.any? %>
+  <% if @statuses.group_by(&:class).map { |i| i.first}.select { |i| i.try(:dangerous_remediate?) }.any? %>
+    <%= alert(:text => _('This will cause a service interruption.'), :class => 'alert-warning', :close => false) %>
+  <% end %>
 
-<% if @status.class.respond_to?(:dangerous_remediate?) && @status.class.dangerous_remediate? -%>
-<%= alert(:text => _('This will cause a service interruption.'), :class => 'alert-warning', :close => false) %>
-<% end -%>
+  <%= n_('One host selected for remediation.', '%s hosts selected for remediation.', @statuses.count) % @statuses.count %>
 
-<%= form_for @triggering, :url => submit_remediate_host_path(:id => @host.id, :status_id => @status), :html => { :class => 'form-horizontal', :id => 'schedule_remediate_form' } do |f| %>
-  <%= javascript_tag do %>
-    $(function() { trigger_form_selector_binds('<%= f.options[:html][:id] %>','<%= f.object_name %>') });
-  <% end %>
-  <div class="form-group">
-    <label class="col-md-2 control-label"><%= _('Schedule') %></label>
-    <div class="col-md-8">
-      <%= fields_for :triggering, @triggering do |trigger_fields| %>
-        <%= radio_button_f trigger_fields, :mode, :class => 'trigger_mode_selector', :value => 'immediate', :text => _("Execute now") %>
-        <%= radio_button_f trigger_fields, :mode, :class => 'trigger_mode_selector', :value => 'future',    :text => _("Schedule future execution") %>
+  <ul class='hosts-list' style='max-height: 100px; overflow-y: scroll;'>
+    <% @statuses.each do |status| %>
+      <li>
+        <%= status.host.name %>
+        <%= content_tag(:span, nil, class: 'glyphicon glyphicon-warning-sign text-warning', title: _('This will cause a service interruption.')) if status.class.try(:dangerous_remediate?) %>
+      </li>
+    <% end %>
+  </ul>
+
+  <%= form_for @triggering, html: { class: 'form-horizontal', id: 'schedule_remediate_form' },
+                            url: submit_remediate_hosts_path(host_association: @statuses_params[:host_association],
+                                                             owned_only: @statuses_params[:owned_only],
+                                                             status_ids: @statuses_params[:status_ids]) do |f| %>
+    <%= javascript_tag do %>
+      $(function() { trigger_form_selector_binds('<%= f.options[:html][:id] %>','<%= f.object_name %>') });
+    <% end %>
+    <div class="form-group">
+      <label class="col-md-2 control-label"><%= _('Schedule') %></label>
+      <div class="col-md-8">
+        <%= fields_for :triggering, @triggering do |trigger_fields| %>
+          <%= radio_button_f trigger_fields, :mode, :class => 'trigger_mode_selector', :value => 'immediate', :text => _('Execute now') %>
+          <%= radio_button_f trigger_fields, :mode, :class => 'trigger_mode_selector', :value => 'future',    :text => _('Schedule future execution') %>
+      </div>
     </div>
-  </div>
 
-  <div class="trigger_fields">
-    <%= content_tag(:fieldset, nil, :id => 'trigger_mode_future', :class => "trigger_mode_form #{'hidden' unless @triggering.future?}") do
-      safe_join([
-        text_f(f, :start_at_raw, :label => _('Start at'), :placeholder => 'YYYY-mm-dd HH:MM'),
-        text_f(f, :start_before_raw, :label => _('Start before'), :placeholder => 'YYYY-mm-dd HH:MM',
-                                     :label_help => _('Indicates that the action should be cancelled if it cannot be started before this time.'))
-      ])
-    end %>
-  </div>
-  <% end %>
+    <div class="trigger_fields">
+      <%= content_tag(:fieldset, nil, id: 'trigger_mode_future', class: "trigger_mode_form #{'hidden' unless @triggering.future?}") do
+        safe_join([
+          text_f(f, :start_at_raw, label: _('Start at'), placeholder: 'YYYY-mm-dd HH:MM'),
+          text_f(f, :start_before_raw, label: _('Start before'), placeholder: 'YYYY-mm-dd HH:MM',
+                                       label_help: _('Indicates that the action should be cancelled if it cannot be started before this time.'))
+        ])
+      end %>
+    </div>
+    <% end %>
 
-  <%= submit_or_cancel f, false, :cancel_path => { :controller => :'foreman_wreckingball/hosts', :action => :status_dashboard } %>
+    <%= submit_or_cancel f, false, :cancel_path => { controller: :'foreman_wreckingball/hosts', action: :status_dashboard } %>
+  <% end %>
+<% else %>
+  <%= content_tag :h3, _('No hosts selected') %>
+  <%= content_tag :p, _('Please select some hosts and try again') %>
 <% end %>

data/app/views/foreman_wreckingball/hosts/status_dashboard.html.erb

@@ -13,11 +13,11 @@
     render 'status_dashboard_empty'
   end
 %>
-<%= render :partial => 'common/modal', :locals => {
-  :id => 'confirmation-modal',
-  :title => _('Please Confirm'),
-  :buttons => [
-    button_tag(_('Cancel'), :class => 'btn btn-default', :data => { :dismiss => 'modal' }, :type => 'button'),
-    button_tag(_('Submit'), :class => 'btn btn-primary', :data => { :action => 'submit' }, :onclick => 'submit_modal_form()')
+<%= render partial: 'common/modal', locals: {
+  id: 'confirmation-modal',
+  title: _('Please Confirm'),
+  buttons: [
+    button_tag(_('Cancel'), class: 'btn btn-default', data: { dismiss: 'modal' }, type: 'button'),
+    button_tag(_('Submit'), class: 'btn btn-primary', data: { action: 'submit' }, onclick: 'submit_modal_form()')
   ]
 } %>

data/app/views/foreman_wreckingball/hosts/status_managed_hosts_dashboard.html.erb

@@ -1,7 +1,6 @@
 <% title _('VMware Managed Hosts Overview') %>
-<% javascript 'foreman_wreckingball/modal' %>
-<% javascript 'foreman_wreckingball/status_hosts_table' %>
-<% stylesheet 'foreman_wreckingball/status_hosts_table' %>
+<% javascript 'foreman_wreckingball/status_managed_hosts_dashboard' %>
+<% stylesheet 'foreman_wreckingball/status_managed_hosts_dashboard' %>
 
 <%= title_actions(
   button_group(
@@ -13,37 +12,89 @@
   )
 ) %>
 
-<% if @missing_hosts.any? %>
-  <div id="missing_vms">
-    <h2>List of hosts not found in vSphere</h2>
-    <div class="list-group list-view-pf list-view-pf-equalized-column" style="max-height: initial;">
-    <% @missing_hosts.each do |host| %>
-      <div><%= host.name %></div>
+<%= render partial: 'status_managed_hosts_dashboard_cards', locals: {
+  missing_hosts_count: @missing_hosts.count,
+  duplicate_vms_count: @duplicate_vms.map(&:second).flatten.count,
+  different_hosts_count: @different_hosts.count
+} %>
+
+<ul class='nav nav-tabs' data-tabs='tabs'>
+  <li class='active'>
+    <%= content_tag :a, _('List of Hosts not found in vSphere'), href: '#missing_vms_tab', 'data-toggle': 'tab' %>
+  </li>
+  <li>
+    <%= content_tag :a, _('List of VMs with same uuid'), href: '#duplicate_vms_tab', 'data-toggle': 'tab' %>
+  </li>
+  <li>
+    <%= content_tag :a, _('List of VMs associated with different Compute Resources'), href: '#different_vms_tab', 'data-toggle': 'tab' %>
+  </li>
+</ul>
+
+<div class='tab-content'>
+  <div class='tab-pane active' id='missing_vms_tab'>
+    <% if @missing_hosts.empty? %>
+      <%= content_tag :p, _('No hosts to show'), class: 'ca' %>
+    <% else %>
+      <%= content_tag :table, id: 'missing_vms', class: table_css_classes do %>
+        <thead>
+          <tr>
+            <%= content_tag :th, _('Name') %>
+          </tr>
+        </thead>
+        <tbody>
+          <% @missing_hosts.each do |host| %>
+            <tr>
+              <%= content_tag :td, link_to_if_authorized(host.name, hash_for_host_path(id: host)) %>
+            </tr>
+          <% end %>
+        </tbody>
+      <% end %>
     <% end %>
-    </div>
   </div>
-<% end %>
-
-<% if @duplicate_vms.any? %>
-  <div id="duplicate_vms">
-    <h2>List of VMs with same uuid</h2>
-    <div class="list-group list-view-pf list-view-pf-equalized-column" style="max-height: initial;">
-    <% @duplicate_vms.each do |uuid, hosts| %>
-      <% hosts.each do |host| %>
-        <div><%= host.uuid %> - <%= host.name %></div>
+  <div class='tab-pane' id='duplicate_vms_tab'>
+    <% if @duplicate_vms.empty? %>
+      <%= content_tag :p, _('No hosts to show'), class: 'ca' %>
+    <% else %>
+      <%= content_tag :table, id: 'duplicate_vms', class: table_css_classes do %>
+        <thead>
+          <tr>
+            <%= content_tag :th, _('UUID') %>
+            <%= content_tag :th, _('Name') %>
+          </tr>
+        </thead>
+        <tbody>
+          <% @duplicate_vms.each do |_uuid, hosts| %>
+            <% hosts.each do |host| %>
+              <tr>
+                <%= content_tag :td, host.uuid %>
+                <%= content_tag :td, link_to_if_authorized(host.name, hash_for_host_path(id: host)) %>
+              </tr>
+            <% end %>
+          <% end %>
+        </tbody>
       <% end %>
     <% end %>
-    </div>
   </div>
-<% end %>
-
-<% if @different_hosts.any? %>
-  <div id="different_vms">
-    <h2>List of VMs associated with different compute resources</h2>
-    <div class="list-group list-view-pf list-view-pf-equalized-column" style="max-height: initial;">
-    <% @different_hosts.each do |host| %>
-      <div><%= host.uuid %> - <%= host.name %></div>
+  <div class='tab-pane' id='different_vms_tab'>
+    <% if @different_hosts.empty? %>
+      <%= content_tag :p, _('No hosts to show'), class: 'ca' %>
+    <% else %>
+      <%= content_tag :table, id: 'different_vms', class: table_css_classes do %>
+        <thead>
+          <tr>
+            <%= content_tag :th, _('UUID') %>
+            <%= content_tag :th, _('Name') %>
+          </tr>
+        </thead>
+        <tbody>
+          <% @different_hosts.each do |host| %>
+            <tr>
+              <%= content_tag :td, host.uuid %>
+              <%= content_tag :td, link_to_if_authorized(host.name, hash_for_host_path(id: host)) %>
+            </tr>
+          <% end %>
+        </tbody>
+      <% end %>
     <% end %>
-    </div>
   </div>
-<% end %>
+</div>

data/config/routes.rb

@@ -4,15 +4,13 @@ Rails.application.routes.draw do
   scope '/wreckingball' do
     constraints(:id => /[^\/]+/) do
       resources :hosts, controller: 'foreman_wreckingball/hosts', only: [] do
-        member do
-          get :schedule_remediate
-          post :submit_remediate
-        end
         collection do
           get :status_dashboard
           get :status_managed_hosts_dashboard
           get 'status_dashboard/hosts(/:status)', as: :ajax_status_dashboard, action: :status_hosts, defaults: { format: :json }
           put :refresh_status_dashboard
+          get :schedule_remediate
+          post :submit_remediate
         end
       end
     end

data/lib/foreman_wreckingball/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ForemanWreckingball
-  VERSION = '3.2.0'
+  VERSION = '3.3.0'
 end

data/test/actions/foreman_wreckingball/bulk_remediate_test.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'test_plugin_helper'
+
+module Actions
+  module ForemanWreckingball
+    describe Actions::ForemanWreckingball::BulkRemediate do
+      include Dynflow::Testing
+
+      let(:action_class) { ::Actions::ForemanWreckingball::BulkRemediate }
+      let(:bulk_action) { ::Actions::BulkAction }
+      let(:action) { create_action(action_class) }
+
+      setup do
+        Setting::Wreckingball.load_defaults
+        FactoryBot.create_list(:host, 2, :managed, :with_wreckingball_statuses)
+      end
+
+      it 'plans remediate action' do
+        ::ForemanWreckingball::Engine::WRECKINGBALL_STATUSES.map(&:constantize)
+                                                            .select(&:supports_remediate?)
+                                                            .each do |status|
+          statuses = HostStatus::Status.where(type: status.to_s)
+          plan_action(action, statuses)
+
+          assert_action_planed_with(action, bulk_action, status.remediate_action, statuses.map(&:host))
+        end
+      end
+    end
+  end
+end

data/test/controllers/foreman_wreckingball/hosts_controller_test.rb

@@ -4,6 +4,8 @@ require 'test_plugin_helper'
 
 module ForemanWreckingball
   class HostsControllerTest < ActionController::TestCase
+    include ForemanWreckingball::StatusHelper
+
     let(:fake_task) { OpenStruct.new(id: 123) }
 
     setup do
@@ -222,56 +224,108 @@ module ForemanWreckingball
     end
 
     describe '#schedule_remediate' do
-      let(:host) do
-        FactoryBot.create(:host, :with_wreckingball_statuses)
-      end
+      let(:host) { FactoryBot.create(:host, :with_wreckingball_statuses) }
+      let(:status_ids) { [host.vmware_tools_status_object.id] }
 
       test 'shows a remediation schedule page' do
-        get :schedule_remediate, params: { status_id: host.vmware_operatingsystem_status_object.id, id: host.id }, session: set_session_user
+        get :schedule_remediate, params: { status_ids: status_ids }, session: set_session_user
         assert_response :success
       end
 
-      test 'returns not found when host id is invalid' do
-        get :schedule_remediate, params: { status_id: nil, id: 'invalid' }, session: set_session_user
-        assert_response :not_found
+      context 'with status_id' do
+        let(:hosts) { FactoryBot.create_list(:host, 2, :with_wreckingball_statuses) }
+        let(:status_ids) { [hosts.first.vmware_operatingsystem_status_object.id] }
+
+        test 'remediate selected statuses' do
+          get :schedule_remediate, params: { status_ids: status_ids }, session: set_session_user
+          assert_statuses HostStatus::Status.find(status_ids)
+        end
       end
 
-      test 'returns not found when status id is invalid' do
-        FactoryBot.create(:host, :with_wreckingball_statuses)
-        get :schedule_remediate, params: { status_id: 'invalid', id: host.id }, session: set_session_user
-        assert_response :not_found
+      context 'with host_association' do
+        let(:hosts) { FactoryBot.create_list(:host, 2, :with_wreckingball_statuses, owner: users(:admin)) }
+        let(:statuses) { hosts.map { |h| h.send(host_association) } }
+        let(:status_class) { ForemanWreckingball::OperatingsystemStatus }
+        let(:host_association) { status_class.host_association }
+
+        setup do
+          hosts.each { |h| h.send(host_association).update(status: status_class::MISMATCH) }
+        end
+
+        test 'remediate all statuses' do
+          get :schedule_remediate, params: { host_association: host_association }, session: set_session_user
+          assert_statuses statuses
+        end
+
+        context 'with owned_only' do
+          setup do
+            hosts_list = FactoryBot.create_list(:host, 2, :with_wreckingball_statuses, owner: users(:one))
+            hosts_list.each { |h| h.send(host_association).update(status: status_class::MISMATCH) }
+          end
+
+          test 'remediate only those statuses where the user is the owner of the host' do
+            get :schedule_remediate, params: { host_association: host_association, owned_only: true }, session: set_session_user
+            assert_statuses statuses
+          end
+        end
       end
     end
 
     describe '#submit_remediate' do
-      let(:host) do
-        FactoryBot.create(:host, :with_wreckingball_statuses)
+      let(:host) { FactoryBot.create(:host, :with_wreckingball_statuses) }
+      let(:status_ids) { [host.vmware_tools_status_object.id] }
+
+      setup do
+        ForemanTasks.stubs(:async_task).returns(fake_task)
       end
 
       test 'redirects to scheduled task' do
-        ForemanTasks.expects(:async_task).returns(fake_task)
-        post :submit_remediate, params: { status_id: host.vmware_operatingsystem_status_object.id, id: host.id }, session: set_session_user
+        post :submit_remediate, params: { status_ids: status_ids }, session: set_session_user
         assert_response :redirect
-        assert_includes flash[:success], 'successfully scheduled'
-        assert_redirected_to foreman_tasks_task_path(123)
+        assert_redirected_to foreman_tasks_task_path(fake_task.id)
       end
 
-      test 'raises error when status can not be remediated' do
-        FactoryBot.create(:host, :with_wreckingball_statuses)
-        assert_raises Foreman::Exception do
-          post :submit_remediate, params: { status_id: host.vmware_tools_status_object.id, id: host.id }, session: set_session_user
-        end
+      test 'returns not found when status_ids param is invalid' do
+        post :submit_remediate, params: { status_ids: 'invalid' }, session: set_session_user
+        assert_response :not_found
       end
 
-      test 'returns not found when host id is invalid' do
-        post :submit_remediate, params: { status_id: nil, id: 'invalid' }, session: set_session_user
-        assert_response :not_found
+      context 'with status_id' do
+        let(:hosts) { FactoryBot.create_list(:host, 2, :with_wreckingball_statuses) }
+        let(:status_ids) { [hosts.first.vmware_operatingsystem_status_object.id] }
+
+        test 'remediate selected statuses' do
+          post :submit_remediate, params: { status_ids: status_ids }, session: set_session_user
+          assert_statuses HostStatus::Status.find(status_ids)
+        end
       end
 
-      test 'returns not found when status id is invalid' do
-        FactoryBot.create(:host, :with_wreckingball_statuses)
-        post :submit_remediate, params: { status_id: 'invalid', id: host.id }, session: set_session_user
-        assert_response :not_found
+      context 'with host_association' do
+        let(:hosts) { FactoryBot.create_list(:host, 2, :with_wreckingball_statuses, owner: users(:admin)) }
+        let(:statuses) { hosts.map { |h| h.send(host_association) } }
+        let(:status_class) { ForemanWreckingball::OperatingsystemStatus }
+        let(:host_association) { status_class.host_association }
+
+        setup do
+          hosts.each { |h| h.send(host_association).update(status: status_class::MISMATCH) }
+        end
+
+        test 'remediate all statuses' do
+          post :submit_remediate, params: { host_association: host_association }, session: set_session_user
+          assert_statuses statuses
+        end
+
+        context 'with owned_only' do
+          setup do
+            hosts_list = FactoryBot.create_list(:host, 2, :with_wreckingball_statuses, owner: users(:one))
+            hosts_list.each { |h| h.send(host_association).update(status: status_class::MISMATCH) }
+          end
+
+          test 'remediate only those statuses where the user is the owner of the host' do
+            post :submit_remediate, params: { host_association: host_association, owned_only: true }, session: set_session_user
+            assert_statuses statuses
+          end
+        end
       end
     end
   end

data/test/helpers/foreman_wreckingball/status_helper.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+module ForemanWreckingball
+  module StatusHelper
+    def assert_statuses(expected)
+      actual = request.env['action_controller.instance'].instance_variable_get('@statuses')
+      assert_equal expected, actual
+    end
+  end
+end

data/test/integration/hosts_status_managed_hosts_test.rb

@@ -81,7 +81,7 @@ class HostsStatusManagedHostsTest < ActionDispatch::IntegrationTest
     cr.stubs(:vms).returns([mock1_vm, mock2_vm])
     other_cr.stubs(:vms).returns([mock3_vm])
 
-    ComputeResource.stubs(:where).returns([cr, other_cr])
+    Foreman::Model::Vmware.stubs(:all).returns([cr, other_cr])
 
     visit status_managed_hosts_dashboard_hosts_path
 

data/test/test_plugin_helper.rb

@@ -5,6 +5,8 @@ require 'test_helper'
 require 'database_cleaner'
 require 'dynflow/testing'
 
+Dir["#{__dir__}/helpers/foreman_wreckingball/**.rb"].each { |f| require f }
+
 # Add plugin to FactoryBot's paths
 FactoryBot.definition_file_paths << File.join(ForemanTasks::Engine.root, 'test', 'factories')
 FactoryBot.definition_file_paths << File.join(File.dirname(__FILE__), 'factories')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_wreckingball
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.3.0
 platform: ruby
 authors:
 - Timo Goebel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-24 00:00:00.000000000 Z
+date: 2019-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: foreman-tasks
@@ -64,12 +64,16 @@ files:
 - Rakefile
 - app/assets/javascripts/foreman_wreckingball/modal.js
 - app/assets/javascripts/foreman_wreckingball/status_hosts_table.js
+- app/assets/javascripts/foreman_wreckingball/status_managed_hosts_dashboard.js
 - app/assets/javascripts/foreman_wreckingball/status_row.js
 - app/assets/stylesheets/foreman_wreckingball/status_hosts_table.css.scss
+- app/assets/stylesheets/foreman_wreckingball/status_managed_hosts_dashboard.css.scss
 - app/controllers/foreman_wreckingball/hosts_controller.rb
 - app/helpers/concerns/foreman_wreckingball/hosts_helper_extensions.rb
 - app/helpers/foreman_wreckingball/hypervisors_helper.rb
+- app/helpers/foreman_wreckingball/statuses_helper.rb
 - app/jobs/update_hosts_vmware_facets.rb
+- app/lib/actions/foreman_wreckingball/bulk_remediate.rb
 - app/lib/actions/foreman_wreckingball/host/refresh_vmware_facet.rb
 - app/lib/actions/foreman_wreckingball/host/remediate_hardware_version.rb
 - app/lib/actions/foreman_wreckingball/host/remediate_spectre_v2.rb
@@ -106,8 +110,12 @@ files:
 - app/views/foreman_wreckingball/hosts/_hosts.json.rabl
 - app/views/foreman_wreckingball/hosts/_status_dashboard_content.erb
 - app/views/foreman_wreckingball/hosts/_status_dashboard_empty.erb
+- app/views/foreman_wreckingball/hosts/_status_managed_hosts_dashboard_cards.html.erb
+- app/views/foreman_wreckingball/hosts/_status_managed_hosts_dashboard_cards_card.html.erb
 - app/views/foreman_wreckingball/hosts/_status_row.html.erb
+- app/views/foreman_wreckingball/hosts/_status_row_actions.html.erb
 - app/views/foreman_wreckingball/hosts/_status_row_hosts_table.html.erb
+- app/views/foreman_wreckingball/hosts/_status_row_hosts_table_actions.html.erb
 - app/views/foreman_wreckingball/hosts/schedule_remediate.html.erb
 - app/views/foreman_wreckingball/hosts/status_dashboard.html.erb
 - app/views/foreman_wreckingball/hosts/status_hosts.json.rabl
@@ -129,6 +137,7 @@ files:
 - locale/en/foreman_wreckingball.po
 - locale/foreman_wreckingball.pot
 - locale/gemspec.rb
+- test/actions/foreman_wreckingball/bulk_remediate_test.rb
 - test/actions/foreman_wreckingball/host/refresh_vmware_facet_test.rb
 - test/actions/foreman_wreckingball/host/remediate_hardware_version_test.rb
 - test/actions/foreman_wreckingball/host/remediate_spectre_v2_test.rb
@@ -141,6 +150,7 @@ files:
 - test/factories/foreman_wreckingball_factories.rb
 - test/factories/host.rb
 - test/factories/task.rb
+- test/helpers/foreman_wreckingball/status_helper.rb
 - test/integration/hosts_status_dashboard_test.rb
 - test/integration/hosts_status_managed_hosts_test.rb
 - test/integration_test_plugin_helper.rb
@@ -210,9 +220,11 @@ test_files:
 - test/actions/foreman_wreckingball/host/remediate_hardware_version_test.rb
 - test/actions/foreman_wreckingball/host/refresh_vmware_facet_test.rb
 - test/actions/foreman_wreckingball/host/remediate_spectre_v2_test.rb
+- test/actions/foreman_wreckingball/bulk_remediate_test.rb
 - test/actions/foreman_wreckingball/vmware/sync_compute_resource_test.rb
 - test/actions/foreman_wreckingball/vmware/schedule_vmware_sync_test.rb
 - test/test_plugin_helper.rb
 - test/controllers/compute_resources_controller_test.rb
 - test/controllers/foreman_wreckingball/hosts_controller_test.rb
+- test/helpers/foreman_wreckingball/status_helper.rb
 - test/integration_test_plugin_helper.rb