foreman_wreckingball 3.1.0 → 3.2.0

data/test/models/host_test.rb

@@ -6,9 +6,68 @@ class Host::ManagedTest < ActiveSupport::TestCase
   should have_one(:vmware_facet)
   should have_one(:vmware_cluster)
   should have_one(:vmware_hypervisor_facet)
-  should have_one(:vmware_tools_status_object)
-  should have_one(:vmware_operatingsystem_status_object)
-  should have_one(:vmware_cpu_hot_add_status_object)
-  should have_one(:vmware_spectre_v2_status_object)
-  should have_one(:vmware_hardware_version_status_object)
+
+  HostStatus.wreckingball_statuses.each do |status|
+    should have_one(status.host_association)
+  end
+
+  describe '#owned_by_current_user_or_group_with_current_user' do
+    test 'returns only hosts owned by current user' do
+      usergroup_with_user = FactoryBot.create(:usergroup, users: [User.current], usergroups: [FactoryBot.create(:usergroup, users: [])])
+
+      FactoryBot.create :host, :managed, owner: FactoryBot.create(:user)
+      FactoryBot.create :host, :managed, owner: FactoryBot.create(:usergroup, users: [])
+      FactoryBot.create :host, :managed, owner: usergroup_with_user.usergroups.first
+
+      expected = [
+        FactoryBot.create(:host, :managed, owner: User.current),
+        FactoryBot.create(:host, :managed, owner: usergroup_with_user),
+        FactoryBot.create(:host, :managed, owner: FactoryBot.create(:usergroup, usergroups: [usergroup_with_user]))
+      ]
+      actual = Host::Managed.owned_by_current_user_or_group_with_current_user
+
+      assert_equal expected, actual
+    end
+  end
+
+  context 'scoped search' do
+    setup do
+      @host = FactoryBot.create(:host, :with_vmware_facet)
+    end
+
+    test 'search by hardware_version' do
+      hosts = Host.search_for('vsphere_hardware_version = vmx-10')
+      assert_includes hosts, @host
+    end
+
+    test 'search by power_state' do
+      hosts = Host.search_for('vsphere_power_state = poweredOn')
+      assert_includes hosts, @host
+    end
+
+    test 'search by tools_state' do
+      hosts = Host.search_for('vsphere_tools_state = toolsOk')
+      assert_includes hosts, @host
+    end
+
+    test 'search by guest_id' do
+      hosts = Host.search_for('vsphere_guest_id = rhel6_64Guest')
+      assert_includes hosts, @host
+    end
+
+    test 'search by cpus' do
+      hosts = Host.search_for('vsphere_cpus = 2')
+      assert_includes hosts, @host
+    end
+
+    test 'search by corespersocket' do
+      hosts = Host.search_for('vsphere_corespersocket = 1')
+      assert_includes hosts, @host
+    end
+
+    test 'search by memory_mb' do
+      hosts = Host.search_for('vsphere_memory_mb = 8192')
+      assert_includes hosts, @host
+    end
+  end
 end

data/test/models/usergroup_test.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+require 'test_plugin_helper'
+
+class UsergroupTest < ActiveSupport::TestCase
+  describe '#parent_usergroup_ids' do
+    it 'returns the ids of all parents of a usergroup' do
+      child = FactoryBot.create(:usergroup)
+
+      subject = FactoryBot.create(:usergroup, usergroups: [child])
+
+      parent1 = FactoryBot.create(:usergroup, usergroups: [subject])
+      parent2 = FactoryBot.create(:usergroup, usergroups: [parent1])
+      parent3 = FactoryBot.create(:usergroup, usergroups: [parent1])
+
+      assert_equal subject.parent_usergroup_ids, [parent1, parent2, parent3].map(&:id)
+    end
+
+    it 'returns empty array if usergroup has no parents' do
+      subject = FactoryBot.create(:usergroup)
+
+      assert_equal subject.parent_usergroup_ids, []
+    end
+  end
+end

data/test/test_plugin_helper.rb

@@ -2,8 +2,25 @@
 
 # This calls the main test_helper in Foreman-core
 require 'test_helper'
+require 'database_cleaner'
 require 'dynflow/testing'
 
 # Add plugin to FactoryBot's paths
+FactoryBot.definition_file_paths << File.join(ForemanTasks::Engine.root, 'test', 'factories')
 FactoryBot.definition_file_paths << File.join(File.dirname(__FILE__), 'factories')
 FactoryBot.reload
+
+# Foreman's setup doesn't handle cleaning in plugin
+DatabaseCleaner.strategy = :transaction
+
+module Minitest
+  class Spec
+    before :each do
+      DatabaseCleaner.start
+    end
+
+    after :each do
+      DatabaseCleaner.clean
+    end
+  end
+end

data/test/unit/foreman_wreckingball/vmware_cluster_importer_test.rb

@@ -26,10 +26,25 @@ module ForemanWreckingball
         assert_includes clusters, 'Nested/Lastcluster'
       end
 
-      test 'removes old clusters' do
-        old_cluster = FactoryBot.create(:vmware_cluster, compute_resource: compute_resource)
+      test 'removes old clusters without associated records' do
+        old_cluster = FactoryBot.create(:vmware_cluster,
+                                        :with_hosts,
+                                        :with_vmware_facets,
+                                        :with_vmware_hypervisor_facets,
+                                        compute_resource: compute_resource)
+
+        compute_resource_id = old_cluster.compute_resource.id
+        host_ids = old_cluster.hosts.pluck(:id)
+        vmware_facet_ids = old_cluster.vmware_facets.pluck(:id)
+        vmware_hypervisor_facet_ids = old_cluster.vmware_hypervisor_facets.pluck(:id)
+
         importer.import!
         refute ForemanWreckingball::VmwareCluster.find_by(id: old_cluster.id)
+
+        assert Foreman::Model::Vmware.find_by(id: compute_resource_id)
+        assert_equal host_ids.count, Host.where(id: host_ids).count
+        assert_equal vmware_facet_ids.count, ForemanWreckingball::VmwareFacet.where(id: vmware_facet_ids).count
+        assert_equal vmware_hypervisor_facet_ids.count, ForemanWreckingball::VmwareHypervisorFacet.where(id: vmware_hypervisor_facet_ids).count
       end
 
       test 'can be run twice without a change' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_wreckingball
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.2.0
 platform: ruby
 authors:
 - Timo Goebel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-15 00:00:00.000000000 Z
+date: 2019-01-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: foreman-tasks
@@ -64,6 +64,7 @@ files:
 - Rakefile
 - app/assets/javascripts/foreman_wreckingball/modal.js
 - app/assets/javascripts/foreman_wreckingball/status_hosts_table.js
+- app/assets/javascripts/foreman_wreckingball/status_row.js
 - app/assets/stylesheets/foreman_wreckingball/status_hosts_table.css.scss
 - app/controllers/foreman_wreckingball/hosts_controller.rb
 - app/helpers/concerns/foreman_wreckingball/hosts_helper_extensions.rb
@@ -71,6 +72,7 @@ files:
 - app/jobs/update_hosts_vmware_facets.rb
 - app/lib/actions/foreman_wreckingball/host/refresh_vmware_facet.rb
 - app/lib/actions/foreman_wreckingball/host/remediate_hardware_version.rb
+- app/lib/actions/foreman_wreckingball/host/remediate_spectre_v2.rb
 - app/lib/actions/foreman_wreckingball/host/remediate_vmware_operatingsystem.rb
 - app/lib/actions/foreman_wreckingball/vmware/schedule_vmware_sync.rb
 - app/lib/actions/foreman_wreckingball/vmware/sync_compute_resource.rb
@@ -83,6 +85,9 @@ files:
 - app/lib/vsphere_os_identifiers/os.rb
 - app/models/concerns/foreman_wreckingball/compute_resource_extensions.rb
 - app/models/concerns/foreman_wreckingball/host_extensions.rb
+- app/models/concerns/foreman_wreckingball/host_status_extensions.rb
+- app/models/concerns/foreman_wreckingball/user_extensions.rb
+- app/models/concerns/foreman_wreckingball/usergroup_extensions.rb
 - app/models/concerns/foreman_wreckingball/vmware_extensions.rb
 - app/models/concerns/foreman_wreckingball/vmware_facet_host_extensions.rb
 - app/models/concerns/foreman_wreckingball/vmware_hypervisor_facet_host_extensions.rb
@@ -106,6 +111,8 @@ files:
 - app/views/foreman_wreckingball/hosts/schedule_remediate.html.erb
 - app/views/foreman_wreckingball/hosts/status_dashboard.html.erb
 - app/views/foreman_wreckingball/hosts/status_hosts.json.rabl
+- app/views/foreman_wreckingball/hosts/status_managed_hosts_dashboard.html.erb
+- config/environments/production.rb
 - config/routes.rb
 - db/migrate/20171106155000_create_vmware_facets.rb
 - db/migrate/20180504135345_add_cpu_features_to_vmware_facets.rb
@@ -124,6 +131,7 @@ files:
 - locale/gemspec.rb
 - test/actions/foreman_wreckingball/host/refresh_vmware_facet_test.rb
 - test/actions/foreman_wreckingball/host/remediate_hardware_version_test.rb
+- test/actions/foreman_wreckingball/host/remediate_spectre_v2_test.rb
 - test/actions/foreman_wreckingball/host/remediate_vmware_operatingsystem_test.rb
 - test/actions/foreman_wreckingball/vmware/schedule_vmware_sync_test.rb
 - test/actions/foreman_wreckingball/vmware/sync_compute_resource_test.rb
@@ -132,6 +140,10 @@ files:
 - test/factories/compute_resource.rb
 - test/factories/foreman_wreckingball_factories.rb
 - test/factories/host.rb
+- test/factories/task.rb
+- test/integration/hosts_status_dashboard_test.rb
+- test/integration/hosts_status_managed_hosts_test.rb
+- test/integration_test_plugin_helper.rb
 - test/models/compute_resource_test.rb
 - test/models/compute_resources/vmware_test.rb
 - test/models/foreman_wreckingball/cpu_hot_add_status_test.rb
@@ -142,7 +154,9 @@ files:
 - test/models/foreman_wreckingball/vmware_cluster_test.rb
 - test/models/foreman_wreckingball/vmware_facet_test.rb
 - test/models/foreman_wreckingball/vmware_hypervisor_facet_test.rb
+- test/models/host_status_test.rb
 - test/models/host_test.rb
+- test/models/usergroup_test.rb
 - test/test_plugin_helper.rb
 - test/unit/foreman_wreckingball/vmware_cluster_importer_test.rb
 - test/unit/foreman_wreckingball/vmware_hypervisor_importer_test.rb
@@ -173,8 +187,11 @@ summary: Adds status checks of the VMWare VMs to Foreman.
 test_files:
 - test/unit/foreman_wreckingball/vmware_cluster_importer_test.rb
 - test/unit/foreman_wreckingball/vmware_hypervisor_importer_test.rb
+- test/integration/hosts_status_dashboard_test.rb
+- test/integration/hosts_status_managed_hosts_test.rb
 - test/models/compute_resource_test.rb
 - test/models/host_test.rb
+- test/models/usergroup_test.rb
 - test/models/foreman_wreckingball/operatingsystem_status_test.rb
 - test/models/foreman_wreckingball/spectre_v2_status_test.rb
 - test/models/foreman_wreckingball/vmware_hypervisor_facet_test.rb
@@ -183,15 +200,19 @@ test_files:
 - test/models/foreman_wreckingball/vmware_cluster_test.rb
 - test/models/foreman_wreckingball/vmware_facet_test.rb
 - test/models/foreman_wreckingball/tools_status_test.rb
+- test/models/host_status_test.rb
 - test/models/compute_resources/vmware_test.rb
 - test/factories/compute_resource.rb
 - test/factories/host.rb
 - test/factories/foreman_wreckingball_factories.rb
+- test/factories/task.rb
 - test/actions/foreman_wreckingball/host/remediate_vmware_operatingsystem_test.rb
 - test/actions/foreman_wreckingball/host/remediate_hardware_version_test.rb
 - test/actions/foreman_wreckingball/host/refresh_vmware_facet_test.rb
+- test/actions/foreman_wreckingball/host/remediate_spectre_v2_test.rb
 - test/actions/foreman_wreckingball/vmware/sync_compute_resource_test.rb
 - test/actions/foreman_wreckingball/vmware/schedule_vmware_sync_test.rb
 - test/test_plugin_helper.rb
 - test/controllers/compute_resources_controller_test.rb
 - test/controllers/foreman_wreckingball/hosts_controller_test.rb
+- test/integration_test_plugin_helper.rb