foreman_wreckingball 1.0.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ed7b165c08c4f0621f0c1b550730e4754f2cc8208ecc94705648536f5c0583aa
-  data.tar.gz: 31fe06c727fa67c07336d615204ca286f2de9f4905fba85bd97dd460faab4d08
+  metadata.gz: cc7a11036e0646a12bade27dd0103e62ded2dfebf765635f25d4183b1ef526ec
+  data.tar.gz: 6f699717b502e437359a62a220c54ae6ed9caaf2d8cc967dea5ba09646ecdd05
 SHA512:
-  metadata.gz: 6a9951b05899b8657331428cf5f8afe9bd0a806f6aed6fb3354a60782d34ffc6dc2b5a0dc076551a6208ab9273f11a0205f299a569105a4b840b8aecb73982fe
-  data.tar.gz: b5989a99b88494efa790f6ece0b07f53c7d083111b55bd7a8941039c621a73d87f908908f3c0e3f8e51cf64a4415ac7f2c4aa2192f4715a7e4a0b6dfa2d72789
+  metadata.gz: 9fd15f5abf4995dc3818c4f27d6b8e4a7de4a0a23873c705f82b8b194464fa1fb7619220533bf408d1f4c9cf1e64c71b9e523965a245cd7545d650f131707f2b
+  data.tar.gz: c836945e900b536003732099503b532504d1f298a1c59d295a73db0cc4d00d9026c4a36ab1d2f10e222f93b5f6abda2f81965aebbae6b1e2bf0a08a7c83a6cb3

data/README.md

@@ -8,6 +8,7 @@ This is a plugin for Foreman that adds several VMware related status checks to y
 | --------------- | -------------- |
 | >= 1.15         | ~> 0.1         |
 | >= 1.16         | ~> 1.0         |
+| >= 1.17         | ~> 2.0         |
 
 ## Installation
 

data/app/controllers/foreman_wreckingball/hosts_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ForemanWreckingball
   class HostsController < ::HostsController
     before_action :find_resource, :only => [:remediate]

data/app/helpers/concerns/foreman_wreckingball/hosts_helper_extensions.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module ForemanWreckingball
   module HostsHelperExtensions
     extend ActiveSupport::Concern
 
     def classes_for_vmware_status_row(counter)
-      return 'pficon-error-circle-o list-view-pf-icon-danger' if (counter[:critical] || 0) > 0
-      return 'pficon-warning-triangle-o list-view-pf-icon-warning' if (counter[:warning] || 0) > 0
+      return 'pficon-error-circle-o list-view-pf-icon-danger' if (counter[:critical] || 0).positive?
+      return 'pficon-warning-triangle-o list-view-pf-icon-warning' if (counter[:warning] || 0).positive?
       'pficon-ok list-view-pf-icon-success'
     end
 

data/app/jobs/update_hosts_vmware_facets.rb

@@ -1,4 +1,6 @@
-class UpdateHostsVmwareFacets < ActiveJob::Base
+# frozen_string_literal: true
+
+class UpdateHostsVmwareFacets < ApplicationJob
   after_perform do
     self.class.set(:wait => 12.hours).perform_later
   end

data/app/lib/actions/foreman_wreckingball/host/refresh_vmware_facet.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Actions
   module ForemanWreckingball
     module Host

data/app/lib/actions/foreman_wreckingball/host/remediate_vmware_operatingsystem.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Actions
   module ForemanWreckingball
     module Host

data/app/lib/actions/foreman_wreckingball/vmware/schedule_vmware_sync.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Actions
   module ForemanWreckingball
     module Vmware

data/app/lib/actions/foreman_wreckingball/vmware/sync_compute_resource.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Actions
   module ForemanWreckingball
     module Vmware

data/app/lib/vsphere_os_identifiers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module VsphereOsIdentifiers
   def self.data
     @data ||= load_data
@@ -9,7 +11,7 @@ module VsphereOsIdentifiers
   end
 
   def self.load_data
-    YAML.load_file(File.expand_path('../vsphere_os_identifiers/data.yaml', __FILE__))
+    YAML.load_file(File.expand_path('vsphere_os_identifiers/data.yaml', __dir__))
   end
 
   def self.all

data/app/lib/vsphere_os_identifiers/os.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module VsphereOsIdentifiers
   class Os
     attr_reader :id, :description, :architecture, :since, :osfamily, :major, :name, :release

data/app/models/concerns/foreman_wreckingball/compute_resource_extensions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ForemanWreckingball
   module ComputeResourceExtensions
     extend ActiveSupport::Concern

data/app/models/concerns/foreman_wreckingball/host_extensions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ForemanWreckingball
   module HostExtensions
     extend ActiveSupport::Concern

data/app/models/concerns/foreman_wreckingball/vmware_extensions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ForemanWreckingball
   module VmwareExtensions
     def hypervisors(opts = {})

data/app/models/concerns/foreman_wreckingball/vmware_facet_host_extensions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ForemanWreckingball
   module VmwareFacetHostExtensions
     extend ActiveSupport::Concern

data/app/models/concerns/foreman_wreckingball/vmware_hypervisor_facet_host_extensions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ForemanWreckingball
   module VmwareHypervisorFacetHostExtensions
     extend ActiveSupport::Concern

data/app/models/foreman_wreckingball/cpu_hot_add_status.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ForemanWreckingball
   class CpuHotAddStatus < ::HostStatus::Status
     OK = 0
@@ -42,7 +44,7 @@ module ForemanWreckingball
     end
 
     def relevant?(_options = {})
-      host && host.vmware_facet && host.vmware_facet.try(:cpu_hot_add?)
+      host&.vmware_facet && host.vmware_facet.try(:cpu_hot_add?)
     end
 
     def performance_degration?

data/app/models/foreman_wreckingball/operatingsystem_status.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ForemanWreckingball
   class OperatingsystemStatus < ::HostStatus::Status
     OK = 0
@@ -46,7 +48,7 @@ module ForemanWreckingball
     end
 
     def relevant?(_options = {})
-      host && host.vmware_facet
+      host&.vmware_facet
     end
 
     def os_matches_identifier?

data/app/models/foreman_wreckingball/tools_status.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ForemanWreckingball
   class ToolsStatus < ::HostStatus::Status
     POWERDOWN = 10

data/app/models/foreman_wreckingball/vmware_cluster.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module ForemanWreckingball
-  class VmwareCluster < ActiveRecord::Base
+  class VmwareCluster < ApplicationRecord
     has_many :vmware_hypervisor_facets,
              :class_name => '::ForemanWreckingball::VmwareHypervisorFacet',
              :inverse_of => :vmware_cluster,

data/app/models/foreman_wreckingball/vmware_facet.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module ForemanWreckingball
-  class VmwareFacet < ActiveRecord::Base
+  class VmwareFacet < ApplicationRecord
     include Facets::Base
 
     VALID_GUEST_STATUSES = [:toolsNotInstalled, :toolsNotRunning, :toolsOk, :toolsOld].freeze

data/app/models/foreman_wreckingball/vmware_hypervisor_facet.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module ForemanWreckingball
-  class VmwareHypervisorFacet < ActiveRecord::Base
+  class VmwareHypervisorFacet < ApplicationRecord
     include Facets::Base
 
     validates_lengths_from_database

data/app/services/foreman_wreckingball/vmware_cluster_importer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ForemanWreckingball
   class VmwareClusterImporter
     delegate :logger, :to => :Rails

data/app/services/foreman_wreckingball/vmware_hypervisor_importer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ForemanWreckingball
   class VmwareHypervisorImporter
     delegate :logger, :to => :Rails

data/config/routes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.routes.draw do
   scope '/wreckingball' do
     constraints(:id => /[^\/]+/) do

data/db/migrate/20171106155000_create_vmware_facets.rb

@@ -1,4 +1,6 @@
-class CreateVmwareFacets < ActiveRecord::Migration
+# frozen_string_literal: true
+
+class CreateVmwareFacets < ActiveRecord::Migration[4.2]
   def change
     create_table :vmware_clusters do |t|
       t.string :name, limit: 255, index: true

data/lib/foreman_wreckingball.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'foreman_wreckingball/engine'
 
 module ForemanWreckingball

data/lib/foreman_wreckingball/engine.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'dynflow'
 require 'foreman-tasks'
 
@@ -23,7 +25,7 @@ module ForemanWreckingball
 
     initializer 'foreman_wreckingball.register_plugin', :before => :finisher_hook do |_app|
       Foreman::Plugin.register :foreman_wreckingball do
-        requires_foreman '>= 1.16'
+        requires_foreman '>= 1.17'
 
         security_block :foreman_wreckingball do
           permission :refresh_vmware_status_hosts, {
@@ -82,7 +84,7 @@ module ForemanWreckingball
     end
 
     initializer 'foreman_wreckingball.register_gettext', after: :load_config_initializers do |_app|
-      locale_dir = File.join(File.expand_path('../../..', __FILE__), 'locale')
+      locale_dir = File.join(File.expand_path('../..', __dir__), 'locale')
       locale_domain = 'foreman_wreckingball'
       Foreman::Gettext::Support.add_text_domain locale_domain, locale_dir
     end

data/lib/foreman_wreckingball/scheduled_jobs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # First, we check if there's a job already enqueued
 pending_jobs = ::Foreman::Application.dynflow.world.persistence.find_execution_plans(filters: { :state => 'scheduled' })
 scheduled_job = pending_jobs.select do |job|

data/lib/foreman_wreckingball/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ForemanWreckingball
-  VERSION = '1.0.0'.freeze
+  VERSION = '2.0.0'.freeze
 end

data/lib/tasks/foreman_vmware_checks_tasks.rake

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rake/testtask'
 
 # Tasks

data/locale/gemspec.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 # Matches foreman_wreckingball.gemspec
 _('Adds status checks of the VMWare VMs to Foreman.')

data/test/actions/foreman_wreckingball/host/refresh_vmware_facet_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module Actions
@@ -13,14 +15,14 @@ module Actions
         teardown { ::Fog.unmock! }
 
         let(:compute_resource) do
-          cr = FactoryGirl.create(:compute_resource, :vmware, :uuid => 'Solutions')
+          cr = FactoryBot.create(:compute_resource, :vmware, :uuid => 'Solutions')
           ComputeResource.find(cr.id)
         end
         let(:uuid) { '5032c8a5-9c5e-ba7a-3804-832a03e16381' }
         let(:vm) { compute_resource.find_vm_by_uuid(uuid) }
 
         let(:host) do
-          FactoryGirl.create(
+          FactoryBot.create(
             :host,
             :managed,
             :with_vmware_facet,

data/test/actions/foreman_wreckingball/host/remediate_vmware_operatingsystem_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module Actions
@@ -13,14 +15,14 @@ module Actions
         teardown { ::Fog.unmock! }
 
         let(:compute_resource) do
-          cr = FactoryGirl.create(:compute_resource, :vmware, :uuid => 'Solutions')
+          cr = FactoryBot.create(:compute_resource, :vmware, :uuid => 'Solutions')
           ComputeResource.find(cr.id)
         end
         let(:uuid) { '5032c8a5-9c5e-ba7a-3804-832a03e16381' }
         let(:vm) { compute_resource.find_vm_by_uuid(uuid) }
 
         let(:operatingsystem) do
-          FactoryGirl.create(
+          FactoryBot.create(
             :operatingsystem,
             architectures: [architectures(:x86_64)],
             major: 6,
@@ -31,7 +33,7 @@ module Actions
         end
 
         let(:host) do
-          FactoryGirl.create(
+          FactoryBot.create(
             :host,
             :managed,
             :with_vmware_facet,

data/test/actions/foreman_wreckingball/vmware/schedule_vmware_sync_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module Actions

data/test/actions/foreman_wreckingball/vmware/sync_compute_resource_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module Actions
@@ -14,7 +16,7 @@ module Actions
 
         let(:action_class) { ::Actions::ForemanWreckingball::Vmware::SyncComputeResource }
         let(:compute_resource) do
-          FactoryGirl.create(
+          FactoryBot.create(
             :vmware_cr,
             uuid: 'Solutions'
           )

data/test/controllers/foreman_wreckingball/hosts_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module ForemanWreckingball
@@ -11,13 +13,13 @@ module ForemanWreckingball
 
     describe '#status_dashboard' do
       test 'shows an empty status page' do
-        get :status_dashboard, {}, set_session_user
+        get :status_dashboard, session: set_session_user
         assert_response :success
       end
 
       test 'shows a status page' do
-        FactoryGirl.create_list(:host, 5, :with_wreckingball_statuses)
-        get :status_dashboard, {}, set_session_user
+        FactoryBot.create_list(:host, 5, :with_wreckingball_statuses)
+        get :status_dashboard, session: set_session_user
         assert_response :success
       end
     end
@@ -25,7 +27,7 @@ module ForemanWreckingball
     describe '#refresh_status_dashboard' do
       test 'redirects to scheduled task' do
         ForemanTasks.expects(:async_task).returns(fake_task)
-        put :refresh_status_dashboard, {}, set_session_user
+        put :refresh_status_dashboard, session: set_session_user
         assert_response :redirect
         assert_includes flash[:success], 'successfully scheduled'
         assert_redirected_to foreman_tasks_task_path(123)
@@ -34,32 +36,32 @@ module ForemanWreckingball
 
     describe '#remediate' do
       let(:host) do
-        FactoryGirl.create(:host, :with_wreckingball_statuses)
+        FactoryBot.create(:host, :with_wreckingball_statuses)
       end
 
       test 'redirects to scheduled task' do
         ForemanTasks.expects(:async_task).returns(fake_task)
-        put :remediate, { status_id: host.vmware_operatingsystem_status_object.id, id: host.id }, set_session_user
+        put :remediate, params: { status_id: host.vmware_operatingsystem_status_object.id, id: host.id }, session: set_session_user
         assert_response :redirect
         assert_includes flash[:success], 'successfully scheduled'
         assert_redirected_to foreman_tasks_task_path(123)
       end
 
       test 'raises error when status can not be remediated' do
-        FactoryGirl.create(:host, :with_wreckingball_statuses)
+        FactoryBot.create(:host, :with_wreckingball_statuses)
         assert_raises Foreman::Exception do
-          put :remediate, { status_id: host.vmware_tools_status_object.id, id: host.id }, set_session_user
+          put :remediate, params: { status_id: host.vmware_tools_status_object.id, id: host.id }, session: set_session_user
         end
       end
 
       test 'returns not found when host id is invalid' do
-        put :remediate, { status_id: nil, id: 'invalid' }, set_session_user
+        put :remediate, params: { status_id: nil, id: 'invalid' }, session: set_session_user
         assert_response :not_found
       end
 
       test 'returns not found when status id is invalid' do
-        FactoryGirl.create(:host, :with_wreckingball_statuses)
-        put :remediate, { status_id: 'invalid', id: host.id }, set_session_user
+        FactoryBot.create(:host, :with_wreckingball_statuses)
+        put :remediate, params: { status_id: 'invalid', id: host.id }, session: set_session_user
         assert_response :not_found
       end
     end

data/test/factories/compute_resource.rb

@@ -1,4 +1,6 @@
-FactoryGirl.modify do
+# frozen_string_literal: true
+
+FactoryBot.modify do
   factory :compute_resource do
     trait :with_vmware_clusters do
       transient do

data/test/factories/foreman_wreckingball_factories.rb

@@ -1,4 +1,6 @@
-FactoryGirl.define do
+# frozen_string_literal: true
+
+FactoryBot.define do
   factory :vmware_facet, class: 'ForemanWreckingball::VmwareFacet' do
     vmware_cluster
     tools_state 2 #:toolsOk

data/test/factories/host.rb

@@ -1,4 +1,6 @@
-FactoryGirl.modify do
+# frozen_string_literal: true
+
+FactoryBot.modify do
   factory :host do
     trait :with_vmware_facet do
       vmware_facet

data/test/models/compute_resource_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class ComputeResourceTest < ActiveSupport::TestCase

data/test/models/compute_resources/vmware_test.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class VmwareTest < ActiveSupport::TestCase
   setup { Fog.mock! }
   teardown { Fog.unmock! }
-  let(:compute_resource) { FactoryGirl.build(:vmware_cr, :uuid => 'Solutions') }
+  let(:compute_resource) { FactoryBot.build(:vmware_cr, :uuid => 'Solutions') }
 
   test '#hypervisors returns hosts by cluster' do
     hosts = compute_resource.hypervisors(cluster_id: 'Solutionscluster').map(&:name)

data/test/models/foreman_wreckingball/cpu_hot_add_status_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module ForemanWreckingball
@@ -9,7 +11,7 @@ module ForemanWreckingball
     should belong_to(:host)
 
     let(:host) do
-      FactoryGirl.create(:host, :managed, :with_vmware_facet)
+      FactoryBot.create(:host, :managed, :with_vmware_facet)
     end
     let(:status) { ForemanWreckingball::CpuHotAddStatus.new(host: host) }
 
@@ -67,7 +69,7 @@ module ForemanWreckingball
         end
 
         test 'no performance degration is indicated' do
-          FactoryGirl.create(:vmware_hypervisor_facet, cpu_cores: 4, vmware_cluster: host.vmware_facet.vmware_cluster)
+          FactoryBot.create(:vmware_hypervisor_facet, cpu_cores: 4, vmware_cluster: host.vmware_facet.vmware_cluster)
           host.vmware_facet.cpus = 100
           assert status.performance_degration?
         end
@@ -76,8 +78,8 @@ module ForemanWreckingball
 
     describe '#hypervisor_min_cores' do
       test 'returns the minimum core count from all hypervisors in the same cluster' do
-        FactoryGirl.create(:vmware_hypervisor_facet, cpu_cores: 4, vmware_cluster: host.vmware_facet.vmware_cluster)
-        FactoryGirl.create(:vmware_hypervisor_facet, cpu_cores: 8, vmware_cluster: host.vmware_facet.vmware_cluster)
+        FactoryBot.create(:vmware_hypervisor_facet, cpu_cores: 4, vmware_cluster: host.vmware_facet.vmware_cluster)
+        FactoryBot.create(:vmware_hypervisor_facet, cpu_cores: 8, vmware_cluster: host.vmware_facet.vmware_cluster)
         status.host.reload
         assert_equal 4, status.hypervisor_min_cores
       end

data/test/models/foreman_wreckingball/operatingsystem_status_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module ForemanWreckingball
@@ -9,7 +11,7 @@ module ForemanWreckingball
     should belong_to(:host)
 
     let(:operatingsystem) do
-      FactoryGirl.create(
+      FactoryBot.create(
         :operatingsystem,
         architectures: [architectures(:x86_64)],
         major: 6,
@@ -19,7 +21,7 @@ module ForemanWreckingball
       )
     end
     let(:host) do
-      FactoryGirl.create(
+      FactoryBot.create(
         :host,
         :managed,
         :with_vmware_facet,
@@ -35,7 +37,7 @@ module ForemanWreckingball
     end
 
     test '#relevant is only for hosts with a vmware facet' do
-      h = FactoryGirl.build(:host, :managed)
+      h = FactoryBot.build(:host, :managed)
       refute ForemanWreckingball::ToolsStatus.new(host: h).relevant?
       assert status.relevant?
     end

data/test/models/foreman_wreckingball/tools_status_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module ForemanWreckingball
@@ -8,7 +10,7 @@ module ForemanWreckingball
 
     should belong_to(:host)
 
-    let(:host) { FactoryGirl.create(:host, :with_vmware_facet) }
+    let(:host) { FactoryBot.create(:host, :with_vmware_facet) }
     let(:status) { ForemanWreckingball::ToolsStatus.new(host: host) }
 
     test 'has a host association' do
@@ -25,7 +27,7 @@ module ForemanWreckingball
     end
 
     test '#relevant is only for hosts with a vmware facet' do
-      h = FactoryGirl.build(:host, :managed)
+      h = FactoryBot.build(:host, :managed)
       refute ForemanWreckingball::ToolsStatus.new(host: h).relevant?
     end
 

data/test/models/foreman_wreckingball/vmware_cluster_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module ForemanWreckingball

data/test/models/foreman_wreckingball/vmware_facet_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module ForemanWreckingball

data/test/models/foreman_wreckingball/vmware_hypervisor_facet_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module ForemanWreckingball

data/test/models/host_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class Host::ManagedTest < ActiveSupport::TestCase

data/test/test_plugin_helper.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 # This calls the main test_helper in Foreman-core
 require 'test_helper'
 require 'dynflow/testing'
 
 # Add plugin to FactoryBot's paths
-FactoryGirl.definition_file_paths << File.join(File.dirname(__FILE__), 'factories')
-FactoryGirl.reload
+FactoryBot.definition_file_paths << File.join(File.dirname(__FILE__), 'factories')
+FactoryBot.reload

data/test/unit/foreman_wreckingball/vmware_cluster_importer_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module ForemanWreckingball
@@ -8,7 +10,7 @@ module ForemanWreckingball
     end
     teardown { Fog.unmock! }
 
-    let(:compute_resource) { FactoryGirl.create(:vmware_cr, :uuid => 'Solutions') }
+    let(:compute_resource) { FactoryBot.create(:vmware_cr, :uuid => 'Solutions') }
     let(:importer) do
       VmwareClusterImporter.new(
         compute_resource: compute_resource
@@ -25,7 +27,7 @@ module ForemanWreckingball
       end
 
       test 'removes old clusters' do
-        old_cluster = FactoryGirl.create(:vmware_cluster, compute_resource: compute_resource)
+        old_cluster = FactoryBot.create(:vmware_cluster, compute_resource: compute_resource)
         importer.import!
         refute ForemanWreckingball::VmwareCluster.find_by(id: old_cluster.id)
       end

data/test/unit/foreman_wreckingball/vmware_hypervisor_importer_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module ForemanWreckingball
@@ -15,7 +17,7 @@ module ForemanWreckingball
       Location.find_by(name: 'Location 1')
     end
     let(:compute_resource) do
-      FactoryGirl.create(
+      FactoryBot.create(
         :vmware_cr,
         uuid: 'Solutions',
         organizations: [organization],
@@ -23,7 +25,7 @@ module ForemanWreckingball
       )
     end
     let(:cluster) do
-      FactoryGirl.create(
+      FactoryBot.create(
         :vmware_cluster,
         name: 'Solutionscluster',
         compute_resource: compute_resource
@@ -62,8 +64,8 @@ module ForemanWreckingball
       end
 
       test 'updates host by katello name' do
-        host = FactoryGirl.create(:host,  organization: organization)
-        host.update_attributes!(:name => "virt-who-host1.example.com-#{organization.id}")
+        host = FactoryBot.create(:host,  organization: organization)
+        host.update!(:name => "virt-who-host1.example.com-#{organization.id}")
         importer.import!
         assert_equal 'host1.example.com', host.reload.name
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_wreckingball
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Timo Goebel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-03 00:00:00.000000000 Z
+date: 2018-05-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: foreman-tasks
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.9
+        version: 0.11.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.9
+        version: 0.11.2
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.52.1
+        version: 0.54.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.52.1
+        version: 0.54.0
 description: Adds status checks of the VMWare VMs to Foreman.
 email:
 - timo.goebel@dm.de