foreman_virt_who_configure 0.5.20 → 0.5.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 440065d1546034aad5444c97c65f80d75b516aa020a4b39b7cd2de7be606156f
-  data.tar.gz: 2a916a56cd2cb7735770eb46a3d47b05e99077f9cb3a3dc015487bf20ce527a7
+  metadata.gz: bec81d0d25964289226511f89e97ba3f1206a2c507e7b2397f84f8733074f4c9
+  data.tar.gz: 128103a173ff39059da75e62c406346a7814855ad94b0b3584a9ab5e65b69fcf
 SHA512:
-  metadata.gz: cb3daff17402b052f18ebd870055609fb3a43550b2b07bc53be212af51cce76e492efd3c6b4fac95ef81ddbe992641aa8bf139db0dec56ac14911114329a575b
-  data.tar.gz: 39538b399466371a389305e163958c1018e0b24139a077fbeb4d1664724c338b1c39c87f9681b296d7c2652d87421be96851c57a7ba46e185578a1bc5e923955
+  metadata.gz: 779b402b0d303138bbe654ef8ed3fb17ad227cafa82977cec81ba84da5cde29d54e1aa743b51f35b0deeafc2a3073ab6c39c31d3f919cbfa0000ee6f7455af85
+  data.tar.gz: 3fe10668d94b0b5b8b81e95def0f8e353b4a8e98e5d7013be2b63934004083967f714434d6a867260c45c7363c5b59a300ba75838f361dfe5be5a6e26641a8ab

data/Rakefile

@@ -20,7 +20,7 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
-APP_RAKEFILE = File.expand_path('../test/dummy/Rakefile', __FILE__)
+APP_RAKEFILE = File.expand_path('test/dummy/Rakefile', __dir__)
 
 Bundler::GemHelper.install_tasks
 

data/app/models/foreman_virt_who_configure/output_generator.rb

@@ -131,8 +131,10 @@ module ForemanVirtWhoConfigure
         ### manual edits will be deleted.
         [global]
         debug=#{config.debug? ? 1 : 0}
-        interval=#{config.interval * 60}#{proxy_strings}
+        interval=#{config.interval * 60}
         oneshot=False
+
+        [system_environment]#{proxy_strings}
         EOF
           if [ $? -ne 0 ]; then result_code=$(($result_code|#{error_code(:virt_who_sysconfig_file_issue)})); fi
 
@@ -289,7 +291,6 @@ encrypted_password=$cr_password"
       output = ''
       output << "\n#{proxy_type}=#{sanitize_proxy(proxy.full_url)}" if proxy.present?
       output << "\nno_proxy=#{sanitize_proxy(no_proxy)}" if no_proxy.present?
-      output << "\nno_proxy=*" if proxy.blank? && no_proxy.blank?
       output
     end
 

data/app/views/foreman_virt_who_configure/configs/steps/_connection_form.erb

@@ -18,7 +18,7 @@
   <%= textarea_f f, :exclude_host_parents, inline_help_popover(_('Exclude hosts which cluster ID is specified in comma-separated list in this option will <b>NOT</b> be reported. PowerCLI command to find the domain names in VMware <code>Get-Cluster “ClusterName” | Select ID</code>. Wildcards and regular expressions are supported, multiple records must be separated by comma. Put the value into the double-quotes if it contains special characters like comma. All new line characters will be removed in resulting configuration file, white spaces are removed from beginning and end.')).merge(:label => _('Exclude host parents')) %>
 
   <%= checkbox_f f, :debug, { :label => _('Enable debugging output') }.merge(inline_help_popover(_("Different debug value can't be set per hypervisor, therefore it will affect all other deployed configurations on the host on which this configuration will be deployed."))) %>
-  <%= select_f f, :http_proxy_id, HttpProxy.all, :id, :full_url, {:include_blank => true}, { :label => _('HTTP Proxy') }.merge(
+  <%= select_f f, :http_proxy_id, HttpProxy.all, :id, :name, {:include_blank => true}, { :label => _('HTTP Proxy') }.merge(
         inline_help_popover(_('HTTP proxy that should be used for communication between the server on which virt-who is running and the hypervisors and virtualization managers. Leave this blank if no proxy is used.').html_safe)) %>
   <%= text_f f, :no_proxy, inline_help_popover(_('A comma-separated list of hostnames or domains or ip addresses to ignore proxy settings for. Optionally this may be set to <code>*</code> to bypass proxy settings for all hostnames domains or ip addresses.')).merge(:label => _('Ignore proxy')) %>
   <%= text_f f, :kubeconfig_path, inline_help_popover(_('Configuration file containing details about how to connect to the cluster and authentication details')).merge(:label => _('Path to kubeconfig file')) %>

data/lib/foreman_virt_who_configure/version.rb

@@ -1,3 +1,3 @@
 module ForemanVirtWhoConfigure
-  VERSION = '0.5.20'.freeze
+  VERSION = '0.5.21'.freeze
 end

data/test/unit/output_generator_test.rb

@@ -57,8 +57,8 @@ module ForemanVirtWhoConfigure
 
     describe 'proxy attributes' do
       test 'it does not set any proxy attributes by default and set no_proxy to * to bypass sub-man proxy' do
-        assert_nil config.http_proxy
-        assert_nil config.no_proxy
+        config.http_proxy = nil
+        config.no_proxy = '*'
         assert_not_includes output, 'http_proxy'
         assert_includes output, 'no_proxy=*'
       end
@@ -86,7 +86,7 @@ module ForemanVirtWhoConfigure
         config.http_proxy = nil
         config.no_proxy = ''
         assert_not_includes generator.proxy_strings, 'http_proxy'
-        assert_includes generator.proxy_strings, 'no_proxy=*'
+        assert_not_includes generator.proxy_strings, 'no_proxy=*'
       end
 
       test 'proxy_strings removes any new line chars' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_virt_who_configure
 version: !ruby/object:Gem::Version
-  version: 0.5.20
+  version: 0.5.21
 platform: ruby
 authors:
 - Foreman virt-who-configure team
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-01-18 00:00:00.000000000 Z
+date: 2024-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: katello
@@ -25,19 +25,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: theforeman-rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.0.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.0.6
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
@@ -240,7 +240,7 @@ homepage: https://github.com/theforeman/foreman_virt_who_configure
 licenses:
 - GPLv3
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -255,8 +255,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.4.10
+signing_key:
 specification_version: 4
 summary: A plugin to make virt-who configuration easy
 test_files: