foreman_virt_who_configure 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2008ae4faa3e226b92f38e622d36336c9c41ab6d
-  data.tar.gz: 19a345a6b897f6316d4246ac3d27d062e8e11064
+  metadata.gz: 5f2761e2dfcffdd132dda2d6d6b3a02ea455289c
+  data.tar.gz: f03b3dcf1e134f72fb03804815905e122356186e
 SHA512:
-  metadata.gz: fba16d9169161c00450b0d3247552e68a5b103192c1eef0be6a36c77e6d9658b942646e8edc1b6225a737c1fa5a6c54c7780d9857d5d35a8ef5f69f3b3600acd
-  data.tar.gz: dfa23ba31cc18e7a0eeba914cca88fff1e7ab42d8620279848c933037fd7986cfbbf88ade145aa61e8ee2b7531d1b48857c62d52ac329cb20de4d3f11bf8bbdf
+  metadata.gz: 182cf328367ecacfe010927873bd3515ea793be39f7d72aa56f446016a9d847cad66a37a382459ad865afb81526647a1a46f1e7dcac493ca61f7efa5b118c85c
+  data.tar.gz: ff9ee136a6fd6b6d5ce7ad4b19a9b5d07fbed87fa7509076aec82e9248790d00bd7c7847994197bb8575ac629f4a386e2985ac1c70b99d5005d6a473e3d40f53

data/app/models/foreman_virt_who_configure/output_generator.rb

@@ -9,6 +9,8 @@ module ForemanVirtWhoConfigure
 
     MINIMUM_VIRT_WHO_VERSION = '0.19'
 
+    LIBVIRT_FAKE_PASSWORD = 'libvirt_fake_password'
+
     CONFIGURATION_RESULTS = [
       ConfigurationResult.new(0, 'success', N_('Success')),
       ConfigurationResult.new(1, 'virt_who_too_old', N_('Newer version of virt-who is required, minimum version is %s') % MINIMUM_VIRT_WHO_VERSION),
@@ -189,7 +191,7 @@ EOS
     end
 
     def cr_password
-      config.hypervisor_password
+      config.hypervisor_type == 'libvirt' && config.hypervisor_password.blank? ? LIBVIRT_FAKE_PASSWORD : config.hypervisor_password
     end
 
     def satellite_url

data/lib/foreman_virt_who_configure/version.rb

@@ -1,3 +1,3 @@
 module ForemanVirtWhoConfigure
-  VERSION = '0.1.3'.freeze
+  VERSION = '0.1.4'.freeze
 end

data/test/unit/output_generator_test.rb

@@ -6,6 +6,14 @@ module ForemanVirtWhoConfigure
     let(:output) { generator.virt_who_output }
     let(:bash_script_output) { generator.virt_who_output(:bash_script) }
 
+    describe 'cr_password for libvirt' do
+      test 'empty password is replaced by fake value so that virt-who runs in an non-interactive mode' do
+        config.hypervisor_password = nil
+        config.hypervisor_type = 'libvirt'
+        assert_includes output, 'virt-who-password --password "' + OutputGenerator::LIBVIRT_FAKE_PASSWORD + '"'
+      end
+    end
+
     describe 'filtering' do
       test 'it should not filter anything for unlimited configs' do
         assert_equal ForemanVirtWhoConfigure::Config::UNLIMITED, config.listing_mode.to_i

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_virt_who_configure
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Foreman virt-who-configure team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-23 00:00:00.000000000 Z
+date: 2017-07-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: katello