foreman_virt_who_configure 0.0.2 → 0.1.0

data/test/functional/api/v2/configs_controller_test.rb

@@ -0,0 +1,178 @@
+require 'test_plugin_helper'
+
+class ForemanVirtWhoConfigure::Api::V2::ConfigsControllerTest < ActionController::TestCase
+  setup do
+    @new_config = FactoryGirl.create(:virt_who_config,
+                                 :name => 'my vmware',
+                                 :interval => 120,
+                                 :listing_mode => ForemanVirtWhoConfigure::Config::WHITELIST,
+                                 :whitelist => 'a,b',
+                                 :hypervisor_id => 'hostname',
+                                 :hypervisor_type => 'esx',
+                                 :hypervisor_server => "vmware.example.com",
+                                 :hypervisor_username => "root",
+                                 :debug => false,
+                                 :satellite_url => "foreman.example.com",
+                                 :proxy => 'proxy.example.com',
+                                 :no_proxy => nil
+    )
+
+    @out_of_date_config = FactoryGirl.create(:virt_who_config, :out_of_date)
+    @ok_config = FactoryGirl.create(:virt_who_config, :ok)
+  end
+
+  test "should get index" do
+    get :index, {}, set_session_user
+    response = ActiveSupport::JSON.decode(@response.body)
+    assert_not response['results'].empty?
+    assert_response :success
+
+    result_config = response['results'].find { |r| r['id'] == @new_config.id }
+    refute_nil result_config
+    assert_equal 'my vmware', result_config['name']
+    assert_equal 120, result_config['interval']
+    assert_equal ForemanVirtWhoConfigure::Config::WHITELIST, result_config['listing_mode']
+    assert_equal 'a,b', result_config['whitelist']
+    assert_equal 'hostname', result_config['hypervisor_id']
+    assert_equal 'esx', result_config['hypervisor_type']
+    assert_equal 'vmware.example.com', result_config['hypervisor_server']
+    assert_equal 'root', result_config['hypervisor_username']
+    refute result_config.has_key?('hypervisor_password')
+    refute result_config['debug']
+    assert_not_nil result_config['debug']
+    assert_equal 'foreman.example.com', result_config['satellite_url']
+    assert_equal 'proxy.example.com', result_config['proxy']
+    assert_nil result_config['no_proxy']
+    assert_equal 'unknown', result_config['status']
+    assert_nil result_config['last_report_at']
+    assert_nil result_config['out_of_date_at']
+
+    result_config = response['results'].find { |r| r['id'] == @ok_config.id }
+    assert_equal 'ok', result_config['status']
+    assert_equal @ok_config.last_report_at.to_s, Time.zone.parse(result_config['last_report_at']).to_s
+    assert_equal @ok_config.out_of_date_at.to_s, Time.zone.parse(result_config['out_of_date_at']).to_s
+
+    result_config = response['results'].find { |r| r['id'] == @out_of_date_config.id }
+    assert_equal 'error', result_config['status']
+    assert_equal @out_of_date_config.last_report_at.to_s, Time.zone.parse(result_config['last_report_at']).to_s
+    assert_equal @out_of_date_config.out_of_date_at.to_s, Time.zone.parse(result_config['out_of_date_at']).to_s
+  end
+
+  test "should get show for new config" do
+    get :show, { :id => @new_config.to_param }, set_session_user
+    response = ActiveSupport::JSON.decode(@response.body)
+
+    assert_equal 'my vmware', response['name']
+    assert_equal 120, response['interval']
+    assert_equal ForemanVirtWhoConfigure::Config::WHITELIST, response['listing_mode']
+    assert_equal 'a,b', response['whitelist']
+    assert_equal 'hostname', response['hypervisor_id']
+    assert_equal 'esx', response['hypervisor_type']
+    assert_equal 'vmware.example.com', response['hypervisor_server']
+    assert_equal 'root', response['hypervisor_username']
+    refute response.has_key?('hypervisor_password')
+    refute response['debug']
+    assert_not_nil response['debug']
+    assert_equal 'foreman.example.com', response['satellite_url']
+    assert_equal 'proxy.example.com', response['proxy']
+    assert_nil response['no_proxy']
+    assert_equal 'unknown', response['status']
+    assert_nil response['last_report_at']
+    assert_nil response['out_of_date_at']
+
+    assert_response :success
+  end
+
+  test "should get show for ok config" do
+    get :show, { :id => @ok_config.to_param }, set_session_user
+    response = ActiveSupport::JSON.decode(@response.body)
+
+    assert_equal 'ok', response['status']
+    assert_equal @ok_config.last_report_at.to_s, Time.zone.parse(response['last_report_at']).to_s
+    assert_equal @ok_config.out_of_date_at.to_s, Time.zone.parse(response['out_of_date_at']).to_s
+    assert_response :success
+  end
+
+  test "should get show for out of date config" do
+    get :show, { :id => @out_of_date_config.to_param }, set_session_user
+    response = ActiveSupport::JSON.decode(@response.body)
+
+    assert_equal 'error', response['status']
+    assert_equal @out_of_date_config.last_report_at.to_s, Time.zone.parse(response['last_report_at']).to_s
+    assert_equal @out_of_date_config.out_of_date_at.to_s, Time.zone.parse(response['out_of_date_at']).to_s
+    assert_response :success
+  end
+
+  test "should get deploy script for config" do
+    get :deploy_script, { :id => @out_of_date_config.to_param }, set_session_user
+    response = ActiveSupport::JSON.decode(@response.body)
+
+    assert_response :success
+    assert_equal @out_of_date_config.virt_who_config_script, response['virt_who_config_script']
+  end
+
+  test "should get deploy script for plain/text format" do
+    get :deploy_script, { :id => @out_of_date_config.to_param, :format => 'txt' }, set_session_user
+    response = @response.body
+
+    assert_response :success
+    assert_equal @out_of_date_config.virt_who_config_script, response
+  end
+
+  test "should get deploy script for shell script format" do
+    get :deploy_script, { :id => @out_of_date_config.to_param, :format => 'sh' }, set_session_user
+    response = @response.body
+
+    assert_response :success
+    assert_equal @out_of_date_config.virt_who_config_script, response
+  end
+
+  test "should create the config" do
+    org = FactoryGirl.create(:organization)
+    post :create, { :foreman_virt_who_configure_config => { :name => 'my new config',
+                                                            :interval => 240,
+                                                            :listing_mode => ForemanVirtWhoConfigure::Config::BLACKLIST,
+                                                            :blacklist => ' a,b ',
+                                                            :hypervisor_id => 'uuid',
+                                                            :hypervisor_type => 'esx',
+                                                            :hypervisor_server => "vmware.example.com",
+                                                            :hypervisor_username => "root",
+                                                            :hypervisor_password => "password",
+                                                            :debug => true,
+                                                            :satellite_url => "foreman.example.com",
+                                                            :organization_id => org.id }
+    }, set_session_user
+
+    assert_response :success
+
+    response = ActiveSupport::JSON.decode(@response.body)
+    new_config = ForemanVirtWhoConfigure::Config.find(response['id'])
+
+    assert_equal 'my new config', new_config.name
+    assert_equal 240, new_config.interval
+    assert_equal ForemanVirtWhoConfigure::Config::BLACKLIST, new_config.listing_mode
+    assert_equal 'a,b', new_config.blacklist
+    assert_equal 'uuid', new_config.hypervisor_id
+    assert_equal 'vmware.example.com', new_config.hypervisor_server
+    assert_equal 'root', new_config.hypervisor_username
+    assert_equal 'password', new_config.hypervisor_password
+    assert_equal true, new_config.debug
+    assert_equal 'foreman.example.com', new_config.satellite_url
+  end
+
+  test "should update the config" do
+    put :update, { :id => @ok_config.to_param, :foreman_virt_who_configure_config => { :name => 'updated', :interval => 240, :hypervisor_password => 'new_pass' } }, set_session_user
+    assert_response :success
+    @ok_config.reload
+    assert_equal 'updated', @ok_config.name
+    assert_equal 240, @ok_config.interval
+    assert_equal 'new_pass', @ok_config.hypervisor_password
+  end
+
+  test "should destroy the config" do
+    delete :destroy, { :id => @ok_config.to_param }, set_session_user
+    assert_response :success
+
+    assert_empty ForemanVirtWhoConfigure::Config.where(:id => @ok_config.id).all
+  end
+end

data/test/unit/output_generator_test.rb

@@ -4,6 +4,7 @@ module ForemanVirtWhoConfigure
     let(:config) { FactoryGirl.create(:virt_who_config) }
     let(:generator) { OutputGenerator.new(config) }
     let(:output) { generator.virt_who_output }
+    let(:bash_script_output) { generator.virt_who_output(:bash_script) }
 
     describe 'filtering' do
       test 'it should not filter anything for unlimited configs' do
@@ -85,5 +86,33 @@ module ForemanVirtWhoConfigure
         assert_includes generator.proxy_strings, "\nno_proxy=xyz"
       end
     end
+
+    describe 'error codes' do
+      test 'returns code number for known error name specified as symbol' do
+        assert_equal 1, generator.error_code(:virt_who_too_old)
+      end
+
+      test 'returns code number for known error name specified as string' do
+        assert_equal 0, generator.error_code('success')
+      end
+
+      test 'returns nil for unknown error name' do
+        assert_nil generator.error_code('unknown')
+      end
+    end
+
+    describe 'output format' do
+      test 'it returns the inline content of script if no format is specified' do
+        assert_not_includes output, '#!/usr/bin/bash'
+        assert_not_includes output, 'exit $result_code'
+        assert_includes output, 'echo "Installing virt-who.."'
+      end
+
+      test 'it returns the bash script with shebang and exit code for :bash_script format' do
+        assert_includes bash_script_output, "#!/usr/bin/bash\n"
+        assert_includes bash_script_output, 'exit $result_code'
+        assert_includes bash_script_output, 'echo "Installing virt-who.."'
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_virt_who_configure
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.1.0
 platform: ruby
 authors:
 - Foreman virt-who-configure team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-13 00:00:00.000000000 Z
+date: 2017-05-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: katello
@@ -62,8 +62,10 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- app/assets/javascripts/foreman_virt_who_configure/config_copy_and_paste.js
 - app/assets/javascripts/foreman_virt_who_configure/config_edit.js
 - app/assets/stylesheets/foreman_virt_who_configure/config.css.scss
+- app/controllers/foreman_virt_who_configure/api/v2/configs_controller.rb
 - app/controllers/foreman_virt_who_configure/application_controller.rb
 - app/controllers/foreman_virt_who_configure/concerns/config_parameters.rb
 - app/controllers/foreman_virt_who_configure/configs_controller.rb
@@ -76,6 +78,13 @@ files:
 - app/models/foreman_virt_who_configure/service_user.rb
 - app/services/sso/basic_with_hidden.rb
 - app/views/dashboard/_foreman_virt_who_configs_status_widget.html.erb
+- app/views/foreman_virt_who_configure/api/v2/configs/base.json.rabl
+- app/views/foreman_virt_who_configure/api/v2/configs/create.json.rabl
+- app/views/foreman_virt_who_configure/api/v2/configs/deploy_script.json.rabl
+- app/views/foreman_virt_who_configure/api/v2/configs/index.json.rabl
+- app/views/foreman_virt_who_configure/api/v2/configs/main.json.rabl
+- app/views/foreman_virt_who_configure/api/v2/configs/show.json.rabl
+- app/views/foreman_virt_who_configure/api/v2/configs/update.json.rabl
 - app/views/foreman_virt_who_configure/configs/_form.html.erb
 - app/views/foreman_virt_who_configure/configs/edit.html.erb
 - app/views/foreman_virt_who_configure/configs/index.html.erb
@@ -99,10 +108,15 @@ files:
 - lib/foreman_virt_who_configure/version.rb
 - lib/tasks/foreman_virt_who_configure_tasks.rake
 - locale/Makefile
+- locale/action_names.rb
+- locale/en/LC_MESSAGES/foreman_virt_who_configure.mo
+- locale/en/foreman_virt_who_configure.edit.po
 - locale/en/foreman_virt_who_configure.po
+- locale/en/foreman_virt_who_configure.po.time_stamp
 - locale/foreman_virt_who_configure.pot
 - locale/gemspec.rb
 - test/factories/foreman_virt_who_configure_factories.rb
+- test/functional/api/v2/configs_controller_test.rb
 - test/test_plugin_helper.rb
 - test/unit/config_test.rb
 - test/unit/output_generator_test.rb
@@ -131,7 +145,8 @@ signing_key:
 specification_version: 4
 summary: A plugin to make virt-who configuration easy
 test_files:
+- test/factories/foreman_virt_who_configure_factories.rb
+- test/test_plugin_helper.rb
 - test/unit/config_test.rb
 - test/unit/output_generator_test.rb
-- test/test_plugin_helper.rb
-- test/factories/foreman_virt_who_configure_factories.rb
+- test/functional/api/v2/configs_controller_test.rb