foreman_virt_who_configure 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9eb40a56ab4846ea5460f26ea9d55ee1bd2e27ad
-  data.tar.gz: 7e4395fd51902f7c8ae1eaa96357a633b76e943e
+  metadata.gz: fc18a0a6855645558a541c028fdbc976a1e82a28
+  data.tar.gz: c665d9f4302ec737940875c5c668af1eeaf84588
 SHA512:
-  metadata.gz: ccf5ac80e8e889e1845d774f18e5d8d7214916d98ef22cc19eb7051f935a5f5c4e9975c80188187a2b9f6e1b3b2639e8e3c696078e69d4095f375c047d3d33e7
-  data.tar.gz: d9b59a96009c0817998f473c62e244484e3210745499a2eae696b195be94af3fc0769ad8d2c58d9d511927454a58c100109b4975cca13cf973d397ecd1564a00
+  metadata.gz: 94a21f9543e5519eadfda90acdddc83f5d035e14eca3c1952d5228e79eb608a6658c7852166fee9a3b320bdc56fded20291f8e036abe86bc2415f647e0136f32
+  data.tar.gz: 4727236938d4b4e145fb6452698985173f6292d476ea123362b83a3b55674e9eaefa942d7c2896acaf09255846f852ee98d87d68b946584b56551dfaa93f1464

data/app/controllers/foreman_virt_who_configure/configs_controller.rb

@@ -84,7 +84,7 @@ module ForemanVirtWhoConfigure
     private
 
     def apply_organization_filter(scope)
-      Organization.current ? scope.where(:organization_id => Organization.current) : scope
+      scope.for_organization(Organization.current)
     end
 
     def resource_scope(*args)

data/app/helpers/foreman_virt_who_configure/configs_helper.rb

@@ -1,7 +1,7 @@
 module ForemanVirtWhoConfigure
   module ConfigsHelper
     def hypervisor_server_help_data
-      {
+      @hypervisor_server_help_data ||= {
         'esx' => _('VMware vCenter server’s fully qualified host name or IP address.'),
         'rhevm' => _('Red Hat Virtualization Manager’s fully qualified host name or IP address. For example, <code>https://hostname:443/ovirt-engine/</code> for v4, <code>https://hostname_or_IP:443</code> for v3'),
         # 'vdsm' => 'Red Hat Enterprise Linux Hypervisor (vdsm)',
@@ -12,7 +12,7 @@ module ForemanVirtWhoConfigure
     end
 
     def hypervisor_username_help_data
-      {
+      @hypervisor_username_help_data ||= {
         'esx' => _('Account name by which virt-who is to connect to the hypervisor, in the format <code>domain_name\account_name</code>. Note that only a single backslash separates the values for domain_name and account_name. If you are using a domain account, and the global configuration file <code>/etc/sysconfig/virt-who</code>, then <b>two</b> backslashes are required. For further details, see <a href="https://access.redhat.com/solutions/1270223">Red Hat Knowledgebase solution How to use a windows domain account with virt-who</a> for more information.'),
         'rhevm' => _('Account name by which virt-who is to connect to the Red Hat Enterprise Virtualization Manager instance. The username option requires input in the format username@domain.'),
         # 'vdsm' => '',
@@ -21,5 +21,52 @@ module ForemanVirtWhoConfigure
         'libvirt' => _('Account name by which virt-who is to connect to the hypervisor.')
       }
     end
+
+    def config_report_status(config)
+      message = case config.status
+                  when :unknown
+                    _('No Report Yet')
+                  when :ok
+                    l(config.last_report_at, :format => :long)
+                  when :error
+                    l(config.last_report_at, :format => :long)
+                  else
+                    _('Unknown configuration status')
+                end
+
+      config_report_status_icon(config) + content_tag(:span, message, :class => config.status)
+    end
+
+    def config_report_status_icon(config)
+      content_tag(:span, ''.html_safe, :class => report_status_class(config.status), :title => config.status_description) + '&nbsp;'.html_safe
+    end
+
+    def report_status_class(status)
+      icon_class = case status
+                     when :ok
+                       'pficon-ok'
+                     when :error
+                       'pficon-error-circle-o'
+                     when :unknown
+                       'pficon-info'
+                     else
+                       'pficon-help'
+                   end
+
+      "virt-who-config-report-status #{icon_class} #{status_class(status)}"
+    end
+
+    def status_class(status)
+      case status
+        when :ok
+          'status-ok'.html_safe
+        when :unknown
+          'status-info'.html_safe
+        when :error
+          'status-error'.html_safe
+        else
+          'status-warn'.html_safe
+      end
+    end
   end
 end

data/app/lib/actions/foreman_virt_who_configure/config/report.rb

@@ -0,0 +1,37 @@
+module Actions
+  module ForemanVirtWhoConfigure
+    module Config
+      class Report < Actions::EntryAction
+        middleware.use Actions::Middleware::KeepCurrentUser
+
+        def self.subscribe
+          Actions::Katello::Host::HypervisorsUpdate
+        end
+
+        def plan(hypervisors)
+          plan_self(:hypervisors => hypervisors)
+        end
+
+        def run
+          # this is how we could do mapping to hypervisor hosts based on UUID provided by candelpin
+          # input['hypervisors'].each do |hv_attrs|
+          #   # should always exist, Actions::Katello::Host::HypervisorsUpdate should create it
+          #   # but we should be careful anyway
+          #   hypervisor = ::Host.joins(:subscription_facet).where(:'katello_subscription_facets.uuid' => hv_attrs['uuid']).first
+          # end
+
+          config = ::ForemanVirtWhoConfigure::ServiceUser.find_by_user_id(User.current.id).try(:config)
+          if config.present?
+            config.virt_who_touch!
+          end
+
+          # if config was not found, the report is coming from unknown virt-who reporter, we could create a notification
+          # that this plugin can be used for configuration
+
+          # this could be used for mapping to existing compute resource
+          # config.hypervisor_server
+        end
+      end
+    end
+  end
+end

data/app/models/foreman_virt_who_configure/config.rb

@@ -3,7 +3,7 @@ module ForemanVirtWhoConfigure
     PERMITTED_PARAMS = [
       :interval, :organization_id, :compute_resource_id, :whitelist, :blacklist, :listing_mode, :hypervisor_id,
       :hypervisor_type, :hypervisor_server, :hypervisor_username, :hypervisor_password, :debug,
-      :satellite_url, :proxy, :no_proxy
+      :satellite_url, :proxy, :no_proxy, :name
     ]
     include Authorizable
     audited
@@ -47,6 +47,20 @@ module ForemanVirtWhoConfigure
 
     DEFAULT_INTERVAL = 120
 
+    STATUSES = {
+      'ok' => N_('OK'),
+      'error' => N_('Error'),
+      'unknown' => N_('Unknown')
+    }
+
+    STATUS_DESCRIPTIONS = Hash.new(N_('Unknown configuration status, caused by unexpected conditions')).merge(
+      {
+        :unknown => N_('The configuration was not deployed yet or the virt-who was unable to report the status'),
+        :ok => N_('The virt-who report arrived within the interval'),
+        :error => N_('The virt-who report has not arrived within the interval, please check the virt-who reporter status and logs')
+      }
+    )
+
     include Encryptable
     encrypts :hypervisor_password
 
@@ -57,8 +71,22 @@ module ForemanVirtWhoConfigure
     belongs_to :service_user
 
     scoped_search :on => :interval, :complete_value => true
+    scoped_search :on => :name
+    scoped_search :on => :status, :complete_value => true, :only_explicit => true, :operators => ['= '], :ext_method => :search_by_status
+    scoped_search :on => :out_of_date_at, :complete_value => true, :only_explicit => true
+    scoped_search :on => :last_report_at, :complete_value => true, :only_explicit => true
     # TODO add more related objects and attributes
 
+    # Foreman 1.11 specifics, can be removed later, otherwise when string does not start with "encrypts" prefix
+    # we get 500 when we try to create log message that relies on name method
+    def name
+      title
+    end
+
+    def title
+      compute_resource ? compute_resource.name : hypervisor_server
+    end
+
     # compatibility layer for 1.11 - pre strong params patch
     if self.respond_to?(:attr_accessible)
       attr_accessible(*PERMITTED_PARAMS)
@@ -68,7 +96,7 @@ module ForemanVirtWhoConfigure
     after_destroy :destroy_service_user
 
     validates :interval, :hypervisor_type, :hypervisor_server, :hypervisor_username, :hypervisor_password,
-              :satellite_url, :hypervisor_id, :organization_id,
+              :satellite_url, :hypervisor_id, :organization_id, :name,
               :presence => true
     validates :hypervisor_type, :inclusion => HYPERVISOR_TYPES.keys
     validates :hypervisor_id, :inclusion => HYPERVISOR_IDS
@@ -80,6 +108,21 @@ module ForemanVirtWhoConfigure
 
     before_validation :remove_whitespaces
 
+    scope :out_of_date, ->(deadline = DateTime.now.utc) { where(["out_of_date_at < ?", deadline.utc.to_s(:db)]) }
+    scope :for_organization, ->(org) { org.nil? ? where(nil) : where(:organization_id => org) }
+
+    def self.search_by_status(key, operator, value)
+      condition = case value
+                    when 'ok'
+                      sanitize_sql_for_conditions([' out_of_date_at >= ? ', DateTime.now.utc.to_s(:db)])
+                    when 'unknown'
+                      sanitize_sql_for_conditions({:last_report_at => nil})
+                    when 'error'
+                      sanitize_sql_for_conditions([' out_of_date_at < ? ', DateTime.now.utc.to_s(:db)])
+                  end
+      { :conditions => condition }
+    end
+
     def create_service_user
       password = User.random_password
       service_user = self.build_service_user
@@ -117,20 +160,14 @@ module ForemanVirtWhoConfigure
     #     raise 'unsupported compute resource type'
     # end
 
-    # Foreman 1.11 specifics, can be removed later, otherwise when string does not start with "encrypts" prefix
-    # we get 500 when we try to create log message that relies on name method
-    def name
-      title
-    end
-
-    def title
-      compute_resource ? compute_resource.name : hypervisor_server
-    end
-
     def humanized_interval
       _("every %s hours") % (self.interval / 60)
     end
 
+    def out_of_date?(deadline = DateTime.now.utc)
+      self.out_of_date_at.present? && self.out_of_date_at < deadline
+    end
+
     def step_name(step_key)
       WIZARD_STEPS[step_key]
     end
@@ -148,6 +185,27 @@ module ForemanVirtWhoConfigure
       end
     end
 
+    def virt_who_touch!
+      self.last_report_at = DateTime.now.utc
+      self.out_of_date_at = self.last_report_at + self.interval.minutes
+      self.save!
+    end
+
+    def status
+      case
+        when self.last_report_at.nil?
+          :unknown
+        when !self.out_of_date?
+          :ok
+        else
+          :error
+      end
+    end
+
+    def status_description
+      _(STATUS_DESCRIPTIONS[status])
+    end
+
     private
 
     def remove_whitespaces

data/app/models/foreman_virt_who_configure/service_user.rb

@@ -6,7 +6,7 @@ module ForemanVirtWhoConfigure
     encrypts :encrypted_password
 
     belongs_to :user
-    has_many :configs
+    has_one :config
 
     # Foreman 1.11 specifics, can be removed later, otherwise when string does not start with "encrypts" prefix
     # we get 500 when we try to create log message that relies on name method

data/app/views/dashboard/_foreman_virt_who_configs_status_widget.html.erb

@@ -0,0 +1,59 @@
+<% scope = ForemanVirtWhoConfigure::Config.for_organization(Organization.current) %>
+<% scope = scope.authorized(:view_virt_who_config) %>
+<% out_of_date = scope.out_of_date.order('out_of_date_at DESC') %>
+
+<h4 class="header ca"><%= _('Virt-who Configurations Statistics') %></h4>
+<table class="table table-striped ellipsis">
+  <thead>
+  <tr>
+    <th><%= _("Status") %></th>
+    <th><%= _("Count") %></th>
+  </tr>
+  </thead>
+  <tbody>
+  <tr>
+    <td><%= link_to _("Configurations Without Single Report"), foreman_virt_who_configure_configs_path(:search => "status = unknown") %></td>
+    <td><%= scope.where(:last_report_at => nil).count %></td>
+  </tr>
+  <tr>
+    <td><%= link_to _("Configurations Out Of Date"), foreman_virt_who_configure_configs_path(:search => "status = error") %></td>
+    <td><%= out_of_date.count %></td>
+  </tr>
+  <tr>
+    <td><%= link_to _("Configurations Up To Date"), foreman_virt_who_configure_configs_path(:search => "status = ok") %></td>
+    <td><%= scope.where.not(:last_report_at => nil).count - out_of_date.count %></td>
+  </tr>
+  <tr>
+    <td><%= link_to _("Total Configurations"), foreman_virt_who_configure_configs_path %></td>
+    <td><%= scope.count %></td>
+  </tr>
+  </tbody>
+</table>
+
+
+<h5 class="ca"><%= _('Out of Date Virt-who Configurations') %></h5>
+  <% if out_of_date.empty? %>
+  <%= _("No configuration for which the report has not been received during expected interval") %>
+  <% else %>
+    <table class="table table-striped ellipsis">
+      <thead>
+        <tr>
+          <th><%= s_("Config|Name") %></th>
+          <th><%= s_("Config|Last Report") %></th>
+          <th><%= s_("Config|Interval") %></th>
+        </tr>
+      </thead>
+      <tbody>
+        <% out_of_date.limit(3).each do |config| %>
+          <tr>
+            <td><%= config_report_status_icon(config) %><%= link_to config.name, foreman_virt_who_configure_config_path(config) %></td>
+            <td><%= l(config.last_report_at, :format => :long) %></td>
+            <td><%= config.humanized_interval %></td>
+          </tr>
+        <% end %>
+      </tbody>
+    </table>
+  <% end %>
+
+
+

data/app/views/foreman_virt_who_configure/configs/edit.html.erb

@@ -1,3 +1,3 @@
-<% title _("Edit Config") %>
+<% title _("Edit Virt-who Config") %>
 
 <%= render :partial => 'form' %>

data/app/views/foreman_virt_who_configure/configs/index.html.erb

@@ -1,23 +1,25 @@
-<% title _("Configs") %>
+<% title _("Virt-who Configurations") %>
 
 <% title_actions new_config_link, help_button_or_path %>
 
 <table class="<%= table_css_classes 'table-fixed' %>">
   <thead>
     <tr>
-      <th class="col-md-8"><%= sort :name, :as => s_("Config|Title") %></th>
-      <th><%= s_("Config|Interval") %></th>
+      <th class="col-md-8"><%= sort :name, :as => s_("Config|Name") %></th>
+      <th><%= sort :interval, :as => s_("Config|Interval") %></th>
+      <th class="col-md-2"><%= sort :last_report_at, :as => _("Status") %></th>
       <th><%= _('Actions') %></th>
     </tr>
   </thead>
   <tbody>
     <% @configs.each do |config| %>
     <tr>
-      <td class="display-two-pane ellipsis"><%= link_to_if_authorized (config.title), hash_for_foreman_virt_who_configure_config_path(:id => config).merge(:auth_object => config, :authorizer => authorizer) %></td>
+      <td class="display-two-pane ellipsis"><%= link_to_if_authorized config.name, hash_for_foreman_virt_who_configure_config_path(:id => config).merge(:auth_object => config, :authorizer => authorizer) %></td>
       <td><%= config.humanized_interval %></td>
+      <td><%= config_report_status(config) %></td>
       <td class="col-md-1"><%= action_buttons(
                                    display_link_if_authorized(_('Edit'), hash_for_edit_foreman_virt_who_configure_config_path(:id => config).merge(:auth_object => config, :authorizer => authorizer)),
-                                   display_delete_if_authorized((hash_for_foreman_virt_who_configure_config_path(:id => config).merge(:auth_object => config, :authorizer => authorizer)), :data => { :confirm => _("Delete virt-who configuration %s?") % config.title })
+                                   display_delete_if_authorized((hash_for_foreman_virt_who_configure_config_path(:id => config).merge(:auth_object => config, :authorizer => authorizer)), :data => { :confirm => _("Delete virt-who configuration %s?") % config.name })
                                ) %></td>
       </tr>
     <% end %>

data/app/views/foreman_virt_who_configure/configs/new.html.erb

@@ -1,3 +1,3 @@
-<% title _("New Virt Who Config") %>
+<% title _("New Virt-who Config") %>
 
 <%= render :partial => "foreman_virt_who_configure/configs/form" %>

data/app/views/foreman_virt_who_configure/configs/show.html.erb

@@ -6,9 +6,10 @@
       <div class="col-md-12">
         <label><%= _("Run this script on the target host which will run virt-who reporting, preferably Satellite host:") %></label>
         <p>
-          <%= _("1. Copy this configuration script to a safe directory on the host.") %></br>
-          <%= _("2. Make the script executable and run it on the host.") %></br>
-          <%= _("3. Delete the script on the host.") %></br>
+          <%= _("On the target virt-who host:") %></br>
+          <%= _("1. Copy this configuration script to a safe directory.") %></br>
+          <%= _("2. Make the script executable and run it.") %></br>
+          <%= _("3. Delete the script.") %></br>
         </p>
       </div>
     </div>

data/app/views/foreman_virt_who_configure/configs/steps/_general_information_form.erb

@@ -1,4 +1,6 @@
 <div id="config_general_information">
+  <%= text_f f, :name, :help_inline => popover('', _('Name of this configuration, e.g. the name of the hypervisor')) %>
+
   <% if f.object.organization_id.present? %>
     <%= f.hidden_field :organization_id %>
   <% else %>

data/db/migrate/20170404152851_add_last_report_info_to_config.rb

@@ -0,0 +1,6 @@
+class AddLastReportInfoToConfig < ActiveRecord::Migration
+  def change
+    add_column :foreman_virt_who_configure_configs, :last_report_at, :datetime
+    add_column :foreman_virt_who_configure_configs, :out_of_date_at, :datetime
+  end
+end

data/db/migrate/20170407152851_add_name_to_config.rb

@@ -0,0 +1,5 @@
+class AddNameToConfig < ActiveRecord::Migration
+  def change
+    add_column :foreman_virt_who_configure_configs, :name, :string, :null => false, :default => ''
+  end
+end

data/lib/foreman_virt_who_configure/engine.rb

@@ -7,6 +7,7 @@ module ForemanVirtWhoConfigure
     config.autoload_paths += Dir["#{config.root}/app/controllers/concerns"]
     config.autoload_paths += Dir["#{config.root}/app/helpers/concerns"]
     config.autoload_paths += Dir["#{config.root}/app/models/concerns"]
+    config.autoload_paths += Dir["#{config.root}/app/lib"]
     config.autoload_paths += Dir["#{config.root}/test/"]
 
     # Add any db migrations
@@ -23,10 +24,11 @@ module ForemanVirtWhoConfigure
 
         # Add permissions
         security_block :foreman_virt_who_configure do
-          permission :view_virt_who_config, :'foreman_virt_who_configure/configs' => [:index, :show, :auto_complete_search], :resource_type => 'ForemanVirtWhoConfigure::Config'
-          permission :create_virt_who_config, :'foreman_virt_who_configure/configs' => [:new, :create], :resource_type => 'ForemanVirtWhoConfigure::Config'
-          permission :edit_virt_who_config, :'foreman_virt_who_configure/configs' => [:edit, :update], :resource_type => 'ForemanVirtWhoConfigure::Config'
-          permission :destroy_virt_who_config, :'foreman_virt_who_configure/configs' => [:destroy], :resource_type => 'ForemanVirtWhoConfigure::Config'
+          permission_options = { :resource_type => 'ForemanVirtWhoConfigure::Config' }
+          permission :view_virt_who_config, { :'foreman_virt_who_configure/configs' => [:index, :show, :auto_complete_search] }, permission_options
+          permission :create_virt_who_config, { :'foreman_virt_who_configure/configs' => [:new, :create] }, permission_options
+          permission :edit_virt_who_config, { :'foreman_virt_who_configure/configs' => [:edit, :update] }, permission_options
+          permission :destroy_virt_who_config, { :'foreman_virt_who_configure/configs' => [:destroy] }, permission_options
         end
 
         reporter_permissions = [ :create_hosts, :edit_hosts, :view_lifecycle_environments, :my_organizations ]
@@ -48,6 +50,9 @@ module ForemanVirtWhoConfigure
         role 'Virt-who Manager', [ :view_virt_who_config, :create_virt_who_config, :edit_virt_who_config, :destroy_virt_who_config ]
         role 'Virt-who Viewer', [ :view_virt_who_config ]
 
+        # Available since Foreman 1.15
+        add_all_permissions_to_default_roles if respond_to?(:add_all_permissions_to_default_roles)
+
         # add menu entry
         menu :top_menu, :virt_who_configs,
              url_hash: { controller: 'foreman_virt_who_configure/configs', action: :index },
@@ -56,7 +61,7 @@ module ForemanVirtWhoConfigure
              after: :compute_resources
 
         # add dashboard widget
-        # widget 'foreman_virt_who_configure_widget', name: N_('Foreman plugin template widget'), sizex: 4, sizey: 1
+        widget 'foreman_virt_who_configs_status_widget', :name => N_('Virt-who Configs Status'), sizex: 6, sizey: 1
       end
     end
 
@@ -76,6 +81,10 @@ module ForemanVirtWhoConfigure
       SETTINGS[:foreman_virt_who_configure] = { assets: { precompile: assets_to_precompile } }
     end
 
+    initializer 'foreman_virt_who_configure.register_paths' do |_app|
+      ForemanTasks.dynflow.config.eager_load_paths.concat(%W(#{ForemanVirtWhoConfigure::Engine.root}/app/lib/actions))
+    end
+
     # Include concerns in this config.to_prepare block
     config.to_prepare do
       SSO::METHODS.unshift SSO::BasicWithHidden

data/lib/foreman_virt_who_configure/version.rb

@@ -1,3 +1,3 @@
 module ForemanVirtWhoConfigure
-  VERSION = '0.0.1'.freeze
+  VERSION = '0.0.2'.freeze
 end

data/test/factories/foreman_virt_who_configure_factories.rb

@@ -1,5 +1,6 @@
 FactoryGirl.define do
   factory :virt_who_config, :class => ::ForemanVirtWhoConfigure::Config do
+    sequence(:name) { |n| "config #{n}" }
     organization
     interval 120
     hypervisor_id 'hostname'
@@ -10,4 +11,14 @@ FactoryGirl.define do
     satellite_url 'foreman.example.com'
     listing_mode ForemanVirtWhoConfigure::Config::UNLIMITED
   end
+
+  trait :out_of_date do
+    last_report_at (1.minute.ago - 120.minutes).utc
+    out_of_date_at (1.minute.ago).utc
+  end
+
+  trait :ok do
+    last_report_at (1.minute.ago).utc
+    out_of_date_at (1.minute.ago + 120.minutes).utc
+  end
 end

data/test/unit/config_test.rb

@@ -61,5 +61,84 @@ module ForemanVirtWhoConfigure
         assert config.valid?
       end
     end
+
+    describe 'organization scoping' do
+      let(:another_org) { FactoryGirl.create(:organization) }
+      let(:config_1) { FactoryGirl.create(:virt_who_config) }
+      let(:config_2) { FactoryGirl.create(:virt_who_config, :organization => another_org) }
+
+      before do
+        # let is lazy
+        preload = config_1, config_2
+      end
+
+      test '.for_organization does not scope on any organization for nil' do
+        # useful for just passing Organization.current which can be nil
+        assert_includes ForemanVirtWhoConfigure::Config.for_organization(nil), config_1
+        assert_includes ForemanVirtWhoConfigure::Config.for_organization(nil), config_2
+      end
+
+      test '.for_organization scoped to specified organization' do
+        assert_includes ForemanVirtWhoConfigure::Config.for_organization(another_org), config_2
+        refute_includes ForemanVirtWhoConfigure::Config.for_organization(another_org), config_1
+      end
+
+    end
+
+    describe 'statuses and expiration' do
+      let(:out_of_date_config) { FactoryGirl.create(:virt_who_config, :out_of_date) }
+      let(:ok_config) { FactoryGirl.create(:virt_who_config, :ok) }
+      let(:unknown_config) { FactoryGirl.create(:virt_who_config) }
+      before do
+        # let is lazy
+        preload = out_of_date_config, ok_config, unknown_config
+      end
+
+      test 'scoped search definitions work correctly' do
+        assert_equal [ok_config], ForemanVirtWhoConfigure::Config.search_for('status = ok')
+        assert_equal [out_of_date_config], ForemanVirtWhoConfigure::Config.search_for('status = error')
+        assert_equal [unknown_config], ForemanVirtWhoConfigure::Config.search_for('status = unknown')
+      end
+
+      test '.out_of_date scope lists only out_of_date configs' do
+        assert_includes ForemanVirtWhoConfigure::Config.out_of_date, out_of_date_config
+        assert_not_includes ForemanVirtWhoConfigure::Config.out_of_date, ok_config
+        assert_not_includes ForemanVirtWhoConfigure::Config.out_of_date, unknown_config
+      end
+
+      test '#out_of_date?' do
+        assert out_of_date_config.out_of_date?
+        refute ok_config.out_of_date?
+        refute unknown_config.out_of_date?
+      end
+
+      test '#virt_who_touch! sets last_report_at to now' do
+        now = DateTime.now.utc
+        unknown_config.virt_who_touch!
+        assert now <= unknown_config.last_report_at
+      end
+
+      test '#virt_who_touch! makes out_of_date config ok again' do
+        out_of_date_config.virt_who_touch!
+        refute out_of_date_config.out_of_date?
+      end
+
+      test '#virt_who_touch! sets out_of_date_at based on interval and last_report_at' do
+        out_of_date_config.virt_who_touch!
+        assert_equal out_of_date_config.out_of_date_at, out_of_date_config.last_report_at + out_of_date_config.interval.minutes
+      end
+
+      test '#status returns the symbol representing the current status' do
+        assert_equal :ok, ok_config.status
+        assert_equal :error, out_of_date_config.status
+        assert_equal :unknown, unknown_config.status
+      end
+
+      test '#status description returns string describing the status' do
+        assert_kind_of String, ok_config.status_description
+        assert_kind_of String, out_of_date_config.status_description
+        assert_kind_of String, unknown_config.status_description
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_virt_who_configure
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Foreman virt-who-configure team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-13 00:00:00.000000000 Z
+date: 2017-04-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: katello
@@ -69,12 +69,13 @@ files:
 - app/controllers/foreman_virt_who_configure/configs_controller.rb
 - app/helpers/foreman_virt_who_configure/compatibility_helper.rb
 - app/helpers/foreman_virt_who_configure/configs_helper.rb
+- app/lib/actions/foreman_virt_who_configure/config/report.rb
 - app/models/foreman_virt_who_configure/auth_source_hidden_with_authentication.rb
 - app/models/foreman_virt_who_configure/config.rb
 - app/models/foreman_virt_who_configure/output_generator.rb
 - app/models/foreman_virt_who_configure/service_user.rb
 - app/services/sso/basic_with_hidden.rb
-- app/views/dashboard/_foreman_virt_who_configure_widget.html.erb
+- app/views/dashboard/_foreman_virt_who_configs_status_widget.html.erb
 - app/views/foreman_virt_who_configure/configs/_form.html.erb
 - app/views/foreman_virt_who_configure/configs/edit.html.erb
 - app/views/foreman_virt_who_configure/configs/index.html.erb
@@ -91,6 +92,8 @@ files:
 - db/migrate/20170102152851_add_satellite_url_to_config.rb
 - db/migrate/20170215152851_change_default_interval.rb
 - db/migrate/20170309161551_add_proxy_and_no_proxy_to_config.rb
+- db/migrate/20170404152851_add_last_report_info_to_config.rb
+- db/migrate/20170407152851_add_name_to_config.rb
 - lib/foreman_virt_who_configure.rb
 - lib/foreman_virt_who_configure/engine.rb
 - lib/foreman_virt_who_configure/version.rb

data/app/views/dashboard/_foreman_virt_who_configure_widget.html.erb

@@ -1,2 +0,0 @@
-<h4 class="header ca"><%= _('ForemanVirtWhoConfigure') %></h4>
-<%= _('Widget content') %>