foreman_snapshot_management 1.7.1 → 2.0.0

data/locale/en/foreman_snapshot_management.po

@@ -5,7 +5,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_snapshot_management 1.7.0\n"
+"Project-Id-Version: foreman_snapshot_management 1.8.1\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2020-03-02 10:27+0000\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
@@ -20,16 +20,13 @@ msgstr ""
 msgid "Action"
 msgstr ""
 
-msgid "Are you sure to delete this Snapshot?"
+msgid "Action with sub plans"
 msgstr ""
 
-msgid "Are you sure to revert this Snapshot?"
-msgstr ""
-
-msgid "Create"
+msgid "Create Snapshot"
 msgstr ""
 
-msgid "Create Snapshot"
+msgid "Create Snapshot for %s"
 msgstr ""
 
 msgid "Create a snapshot"
@@ -38,10 +35,13 @@ msgstr ""
 msgid "Created %{snapshots} for %{num} %{hosts}"
 msgstr ""
 
-msgid "Delete a snapshot"
+msgid "Delete"
+msgstr ""
+
+msgid "Delete Snapshot \"%s\"?"
 msgstr ""
 
-msgid "Deleting..."
+msgid "Delete a snapshot"
 msgstr ""
 
 msgid "Description"
@@ -62,12 +62,24 @@ msgstr ""
 msgid "Error occurred while rolling back VM: %s"
 msgstr ""
 
+msgid "Error occurred while updating Snapshot: %s"
+msgstr ""
+
+msgid "Failed to load snapshot list"
+msgstr ""
+
 msgid "Failed to update Snapshot: %s"
 msgstr ""
 
 msgid "Foreman-plugin to manage snapshots in a virtual-hardware environments."
 msgstr ""
 
+msgid "Import Puppet classes"
+msgstr ""
+
+msgid "Import facts"
+msgstr ""
+
 msgid "Include RAM"
 msgstr ""
 
@@ -77,6 +89,12 @@ msgstr ""
 msgid "Loading Snapshots information ..."
 msgstr ""
 
+msgid "N/A"
+msgstr ""
+
+msgid "Name"
+msgstr ""
+
 msgid "Name must contain at least 2 characters starting with alphabet. Valid characters are A-Z a-z 0-9 _"
 msgstr ""
 
@@ -95,10 +113,10 @@ msgstr ""
 msgid "Revert Host to a snapshot"
 msgstr ""
 
-msgid "Reverting..."
+msgid "Rollback"
 msgstr ""
 
-msgid "Rollback"
+msgid "Rollback to \"%s\"?"
 msgstr ""
 
 msgid "Snapshot"
@@ -109,12 +127,24 @@ msgstr[1] ""
 msgid "Snapshot name cannot be changed"
 msgstr ""
 
+msgid "Snapshot successfully created!"
+msgstr ""
+
 msgid "Snapshots"
 msgstr ""
 
 msgid "Something went wrong while selecting hosts - %s"
 msgstr ""
 
+msgid "Successfully removed Snapshot \"%s\" from host %s"
+msgstr ""
+
+msgid "Successfully rolled back Snapshot \"%s\" on host %s"
+msgstr ""
+
+msgid "Successfully updated Snapshot \"%s\""
+msgstr ""
+
 msgid "Unable to create Proxmox Snapshot"
 msgstr ""
 
@@ -148,6 +178,9 @@ msgstr ""
 msgid "Whether to include the RAM state in the snapshot"
 msgstr ""
 
+msgid "edit entry"
+msgstr ""
+
 msgid "host"
 msgid_plural "hosts"
 msgstr[0] ""

data/locale/foreman_snapshot_management.pot

@@ -8,8 +8,8 @@ msgid ""
 msgstr ""
 "Project-Id-Version: foreman_snapshot_management 1.0.0\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2020-03-02 15:24+0000\n"
-"PO-Revision-Date: 2020-03-02 15:24+0000\n"
+"POT-Creation-Date: 2021-05-07 09:44+0000\n"
+"PO-Revision-Date: 2021-05-07 09:44+0000\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"
 "Language: \n"
@@ -55,6 +55,7 @@ msgid "Error occurred while creating Snapshot: %s"
 msgstr ""
 
 #: ../app/controllers/foreman_snapshot_management/snapshots_controller.rb:48
+#: ../webpack/components/SnapshotManagement/SnapshotManagementActions.js:81
 msgid "Error occurred while removing Snapshot: %s"
 msgstr ""
 
@@ -63,6 +64,7 @@ msgid "VM successfully rolled back."
 msgstr ""
 
 #: ../app/controllers/foreman_snapshot_management/snapshots_controller.rb:60
+#: ../webpack/components/SnapshotManagement/SnapshotManagementActions.js:199
 msgid "Error occurred while rolling back VM: %s"
 msgstr ""
 
@@ -80,8 +82,8 @@ msgstr ""
 
 #: ../app/controllers/foreman_snapshot_management/snapshots_controller.rb:95
 #: ../app/models/foreman_snapshot_management/snapshot.rb:52
-#: ../app/views/foreman_snapshot_management/snapshots/_index.html.erb:5
 #: ../app/views/foreman_snapshot_management/snapshots/select_multiple_host.html.erb:8
+#: ../webpack/components/SnapshotManagement/components/SnapshotList/SnapshotList.js:156
 msgid "Snapshot"
 msgid_plural "Snapshots"
 msgstr[0] ""
@@ -107,6 +109,7 @@ msgstr ""
 
 #:
 #: ../app/helpers/concerns/foreman_snapshot_management/hosts_helper_extension.rb:6
+#: ../webpack/components/SnapshotManagement/SnapshotManagement.js:46
 msgid "Create Snapshot"
 msgstr ""
 
@@ -152,55 +155,114 @@ msgstr ""
 msgid "Unable to update VMWare Snapshot"
 msgstr ""
 
-#: ../app/views/foreman_snapshot_management/snapshots/_index.html.erb:6
+#:
+#: ../app/views/foreman_snapshot_management/snapshots/select_multiple_host.html.erb:4
+msgid "No capable hosts selected"
+msgstr ""
+
+#:
 #: ../app/views/foreman_snapshot_management/snapshots/select_multiple_host.html.erb:11
+#: ../webpack/components/SnapshotManagement/components/SnapshotForm/SnapshotForm.js:75
+#: ../webpack/components/SnapshotManagement/components/SnapshotList/SnapshotList.js:162
 msgid "Description"
 msgstr ""
 
-#: ../app/views/foreman_snapshot_management/snapshots/_index.html.erb:8
+#:
 #: ../app/views/foreman_snapshot_management/snapshots/select_multiple_host.html.erb:14
+#: ../webpack/components/SnapshotManagement/components/SnapshotForm/SnapshotForm.js:81
 msgid "Include RAM"
 msgstr ""
 
-#: ../app/views/foreman_snapshot_management/snapshots/_index.html.erb:10
-msgid "Action"
+#: ../app/views/hosts/_snapshots_tab.html.erb:13
+msgid "Loading Snapshots information ..."
 msgstr ""
 
-#: ../app/views/foreman_snapshot_management/snapshots/_index.html.erb:28
-msgid "Create"
+#: ../lib/foreman_snapshot_management/engine.rb:64
+msgid "Snapshots"
 msgstr ""
 
-#: ../app/views/foreman_snapshot_management/snapshots/_index.html.erb:55
-msgid "Rollback"
+#: ../webpack/components/SnapshotManagement/SnapshotManagementActions.js:60
+msgid "Successfully removed Snapshot \"%s\" from host %s"
+msgstr ""
+
+#: ../webpack/components/SnapshotManagement/SnapshotManagementActions.js:126
+msgid "Successfully updated Snapshot \"%s\""
 msgstr ""
 
-#: ../app/views/foreman_snapshot_management/snapshots/_index.html.erb:55
-msgid "Are you sure to revert this Snapshot?"
+#: ../webpack/components/SnapshotManagement/SnapshotManagementActions.js:145
+msgid "Error occurred while updating Snapshot: %s"
 msgstr ""
 
-#: ../app/views/foreman_snapshot_management/snapshots/_index.html.erb:55
-msgid "Reverting..."
+#: ../webpack/components/SnapshotManagement/SnapshotManagementActions.js:180
+msgid "Successfully rolled back Snapshot \"%s\" on host %s"
 msgstr ""
 
-#: ../app/views/foreman_snapshot_management/snapshots/_index.html.erb:56
-msgid "Are you sure to delete this Snapshot?"
+#:
+#: ../webpack/components/SnapshotManagement/components/SnapshotForm/SnapshotForm.js:52
+msgid "Snapshot successfully created!"
 msgstr ""
 
-#: ../app/views/foreman_snapshot_management/snapshots/_index.html.erb:56
-msgid "Deleting..."
+#:
+#: ../webpack/components/SnapshotManagement/components/SnapshotForm/SnapshotForm.js:69
+msgid "Name"
 msgstr ""
 
 #:
-#: ../app/views/foreman_snapshot_management/snapshots/select_multiple_host.html.erb:4
-msgid "No capable hosts selected"
+#: ../webpack/components/SnapshotManagement/components/SnapshotFormModal/SnapshotFormModal.js:14
+msgid "Create Snapshot for %s"
 msgstr ""
 
-#: ../app/views/hosts/_snapshots_tab.html.erb:5
-msgid "Loading Snapshots information ..."
+#:
+#: ../webpack/components/SnapshotManagement/components/SnapshotList/SnapshotList.js:122
+msgid "N/A"
 msgstr ""
 
-#: ../lib/foreman_snapshot_management/engine.rb:61
-msgid "Snapshots"
+#:
+#: ../webpack/components/SnapshotManagement/components/SnapshotList/SnapshotList.js:171
+msgid "Action"
+msgstr ""
+
+#:
+#: ../webpack/components/SnapshotManagement/components/SnapshotList/SnapshotList.js:203
+#: ../webpack/components/SnapshotManagement/components/SnapshotList/SnapshotList.js:205
+msgid "Failed to load snapshot list"
+msgstr ""
+
+#:
+#: ../webpack/components/SnapshotManagement/components/SnapshotList/SnapshotListHelper.js:28
+msgid "edit entry"
+msgstr ""
+
+#:
+#: ../webpack/components/SnapshotManagement/components/SnapshotList/SnapshotListHelper.js:42
+msgid "Rollback to \"%s\"?"
+msgstr ""
+
+#:
+#: ../webpack/components/SnapshotManagement/components/SnapshotList/SnapshotListHelper.js:46
+msgid "Rollback"
+msgstr ""
+
+#:
+#: ../webpack/components/SnapshotManagement/components/SnapshotList/SnapshotListHelper.js:60
+msgid "Delete Snapshot \"%s\"?"
+msgstr ""
+
+#:
+#: ../webpack/components/SnapshotManagement/components/SnapshotList/SnapshotListHelper.js:64
+msgid "Delete"
+msgstr ""
+
+#: action_names.rb:2
+msgid "Import Puppet classes"
+msgstr ""
+
+#: action_names.rb:3
+msgid "Import facts"
+msgstr ""
+
+#: action_names.rb:4
+msgid "Action with sub plans"
 msgstr ""
 
 #: gemspec.rb:4

data/package.json

@@ -0,0 +1,46 @@
+{
+  "name": "foreman_snapshot_management",
+  "version": "2.0.0",
+  "description": "Foreman-plugin to manage snapshots in a virtual-hardware environments.",
+  "main": "index.js",
+  "scripts": {
+    "lint": "tfm-lint --plugin -d /webpack",
+    "stylelint": "stylelint webpack/**/*.scss",
+    "test": "tfm-test --config jest.config.js",
+    "test:watch": "tfm-test --plugin --watchAll",
+    "test:current": "tfm-test --plugin --watch",
+    "publish-coverage": "tfm-publish-coverage",
+    "stories": "tfm-stories --plugin",
+    "stories:build": "tfm-build-stories --plugin",
+    "create-react-component": "yo react-domain"
+  },
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/ATIX-AG/foreman_snapshot_management.git"
+  },
+  "bugs": {
+    "url": "http://projects.theforeman.org/projects/foreman_snapshot_management/issues"
+  },
+  "peerDependencies": {
+    "@theforeman/vendor": ">= 4.0.0"
+  },
+  "dependencies": {
+    "react-intl": "^2.8.0"
+  },
+  "devDependencies": {
+    "@babel/core": "^7.7.0",
+    "@sheerun/mutationobserver-shim": "^0.3.3",
+    "@theforeman/builder": "^4.0.0",
+    "@theforeman/eslint-plugin-foreman": "6.0.0",
+    "@theforeman/find-foreman": "^4.8.0",
+    "@theforeman/stories": "^7.0.0",
+    "@theforeman/test": "^8.0.0",
+    "@theforeman/vendor-dev": "^4.0.0",
+    "babel-eslint": "^10.0.3",
+    "eslint": "^6.7.2",
+    "prettier": "^1.19.1",
+    "react-redux-test-utils": "^0.2.0",
+    "stylelint": "^9.3.0",
+    "stylelint-config-standard": "^18.0.0"
+  }
+}

data/test/controllers/api/v2/snapshots_test.rb

@@ -13,137 +13,260 @@ class Api::V2::SnapshotsControllerTest < ActionController::TestCase
   let(:host) { FactoryBot.create(:host, :managed, :compute_resource => compute_resource, :uuid => uuid) }
   let(:snapshot_id) { 'snapshot-0101' }
   let(:proxmox_compute_resource) do
-    FactoryBot.create(:proxmox_cr)
-    ComputeResource.find_by(type: 'ForemanFogProxmox::Proxmox')
+    cr = FactoryBot.create(:proxmox_cr)
+    ComputeResource.find_by(id: cr.id)
   end
   let(:vmid) { '100' }
-  let(:proxmox_host) { FactoryBot.create(:host, :managed, :compute_resource => proxmox_compute_resource, :uuid => vmid) }
+  let(:proxmox_host) { FactoryBot.create(:host, :managed, :compute_resource => proxmox_compute_resource, :uuid => "1_#{vmid}") }
   let(:proxmox_snapshot) { 'snapshot1' }
+  let(:manager_user) do
+    roles = [Role.find_by(name: 'Snapshot Manager')]
+    FactoryBot.create(:user, :organizations => [tax_organization], :locations => [tax_location], :roles => roles)
+  end
+  let(:view_user) do
+    roles = [Role.find_by(name: 'Snapshot Viewer')]
+    FactoryBot.create(:user, :organizations => [tax_organization], :locations => [tax_location], :roles => roles)
+  end
   setup { ::Fog.mock! }
   teardown { ::Fog.unmock! }
 
-  test 'should get index of Vmware Snapshots' do
-    get :index, params: { :host_id => host.to_param }
-    assert_response :success
-    assert_not_nil assigns(:snapshots)
-    body = ActiveSupport::JSON.decode(@response.body)
-    assert_not_empty body
-    assert_not_empty body['results']
-  end
+  context 'view user' do
+    setup do
+      # Make sure that test-hosts are created here (by the admin-user)
+      host
+      proxmox_host
+      @orig_user = User.current
+      User.current = view_user
+    end
+    teardown do
+      User.current = @orig_user
+    end
 
-  test 'should get index of Proxmox Snapshots' do
-    Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
-    get :index, params: { :host_id => proxmox_host.to_param }
-    assert_response :success
-    assert_not_nil assigns(:snapshots)
-    body = ActiveSupport::JSON.decode(@response.body)
-    assert_not_empty body
-    assert_not_empty body['results']
-  end
+    test 'should get index of Vmware Snapshots' do
+      get :index, params: { :host_id => host.to_param }
+      assert_response :success
+      assert_not_nil assigns(:snapshots)
+      body = ActiveSupport::JSON.decode(@response.body)
+      assert_not_empty body
+      assert_not_empty body['results']
+    end
 
-  test 'should search VMware snapshot' do
-    get :index, params: { :host_id => host.to_param, :search => 'name= clean' }
-    assert_response :success
-    assert_not_nil assigns(:snapshots)
-    body = ActiveSupport::JSON.decode(@response.body)
-    assert_not_empty body
-    assert_not_empty body['results']
-    assert body['results'].count == 1
-  end
+    test 'should get index of Proxmox Snapshots' do
+      Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
+      get :index, params: { :host_id => proxmox_host.to_param }
+      assert_response :success
+      assert_not_nil assigns(:snapshots)
+      body = ActiveSupport::JSON.decode(@response.body)
+      assert_not_empty body
+      assert_not_empty body['results']
+    end
 
-  test 'should search Proxmox snapshot' do
-    Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
-    get :index, params: { :host_id => proxmox_host.to_param, :search => 'name= snapshot1' }
-    assert_response :success
-    assert_not_nil assigns(:snapshots)
-    body = ActiveSupport::JSON.decode(@response.body)
-    assert_not_empty body
-    assert_not_empty body['results']
-    assert body['results'].count == 1
-  end
+    test 'should search VMware snapshot' do
+      get :index, params: { :host_id => host.to_param, :search => 'name= clean' }
+      assert_response :success
+      assert_not_nil assigns(:snapshots)
+      body = ActiveSupport::JSON.decode(@response.body)
+      assert_not_empty body
+      assert_not_empty body['results']
+      assert_equal body['results'].count, 1
+    end
 
-  test 'should refute search Vmware snapshot' do
-    get :index, params: { :host_id => host.to_param, :search => 'name != clean' }
-    assert_response :internal_server_error
-  end
+    test 'should search Proxmox snapshot' do
+      Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
+      get :index, params: { :host_id => proxmox_host.to_param, :search => 'name= snapshot1' }
+      assert_response :success
+      assert_not_nil assigns(:snapshots)
+      body = ActiveSupport::JSON.decode(@response.body)
+      assert_not_empty body
+      assert_not_empty body['results']
+      assert_equal body['results'].count, 1
+    end
 
-  test 'should show Vmware snapshot' do
-    get :show, params: { :host_id => host.to_param, :id => snapshot_id }
-    assert_not_nil assigns(:snapshot)
-    assert_response :success
-    body = ActiveSupport::JSON.decode(@response.body)
-    assert_not_empty body
-  end
+    test 'should refute search Vmware snapshot' do
+      get :index, params: { :host_id => host.to_param, :search => 'name != clean' }
+      assert_response :internal_server_error
+    end
 
-  test 'should show Proxmox snapshot' do
-    Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
-    get :show, params: { :host_id => proxmox_host.to_param, :id => proxmox_snapshot }
-    assert_not_nil assigns(:snapshot)
-    assert_response :success
-    body = ActiveSupport::JSON.decode(@response.body)
-    assert_not_empty body
-  end
+    test 'should show Vmware snapshot' do
+      get :show, params: { :host_id => host.to_param, :id => snapshot_id }
+      assert_not_nil assigns(:snapshot)
+      assert_response :success
+      body = ActiveSupport::JSON.decode(@response.body)
+      assert_not_empty body
+    end
 
-  test 'should 404 for unknown Vmware snapshot' do
-    get :show, params: { :host_id => host.to_param, :id => 'does-not-exist' }
-    assert_response :not_found
-  end
+    test 'should show Proxmox snapshot' do
+      Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
+      get :show, params: { :host_id => proxmox_host.to_param, :id => proxmox_snapshot }
+      assert_not_nil assigns(:snapshot)
+      assert_response :success
+      body = ActiveSupport::JSON.decode(@response.body)
+      assert_not_empty body
+    end
 
-  test 'should create Vmware snapshot' do
-    post :create, params: { :host_id => host.to_param, :name => 'test' }
-    assert_response :created
-    assert_not_nil assigns(:snapshot)
-  end
+    test 'should 404 for unknown Vmware snapshot' do
+      get :show, params: { :host_id => host.to_param, :id => 'does-not-exist' }
+      assert_response :not_found
+    end
 
-  test 'should create Proxmox snapshot' do
-    Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
-    post :create, params: { :host_id => proxmox_host.to_param, :name => 'test' }
-    assert_response :created
-    assert_not_nil assigns(:snapshot)
-  end
+    test 'should refute create Vmware snapshot' do
+      post :create, params: { :host_id => host.to_param, :name => 'test' }
+      assert_response :forbidden
+    end
 
-  test 'should update Vmware snapshot' do
-    name = 'test'
-    put :update, params: { :host_id => host.to_param, :id => snapshot_id.to_param, :name => name.to_param }
-    assert_response :success
-  end
+    test 'should refute update Vmware snapshot' do
+      name = 'test'
+      put :update, params: { :host_id => host.to_param, :id => snapshot_id.to_param, :name => name.to_param }
+      assert_response :forbidden
+    end
 
-  test 'should update Proxmox snapshot' do
-    Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
-    description = 'snapshot1 updated'
-    put :update, params: { :host_id => proxmox_host.to_param, :id => proxmox_snapshot.to_param, :description => description.to_param }
-    assert_response :success
-  end
+    test 'should refute destroy Vmware snapshot' do
+      delete :destroy, params: { :host_id => host.to_param, :id => snapshot_id.to_param }
+      assert_response :forbidden
+    end
 
-  test 'should refute update Proxmox snapshot name' do
-    Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
-    name = 'test'
-    put :update, params: { :host_id => proxmox_host.to_param, :id => proxmox_snapshot.to_param, :name => name.to_param }
-    assert_response :unprocessable_entity
+    test 'should refute revert Proxmox snapshot' do
+      Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
+      put :revert, params: { :host_id => proxmox_host.to_param, :id => proxmox_snapshot.to_param }
+      assert_response :forbidden
+    end
   end
 
-  test 'should destroy Vmware snapshot' do
-    delete :destroy, params: { :host_id => host.to_param, :id => snapshot_id.to_param }
-    assert_response :success
-  end
+  context 'manager user' do
+    setup do
+      # Make sure that test-hosts are created here (by the admin-user)
+      host
+      proxmox_host
+      @orig_user = User.current
+      User.current = manager_user
+    end
+    teardown do
+      User.current = @orig_user
+    end
 
-  test 'should destroy Proxmox snapshot' do
-    Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
-    delete :destroy, params: { :host_id => proxmox_host.to_param, :id => proxmox_snapshot.to_param }
-    assert_response :success
-    body = ActiveSupport::JSON.decode(@response.body)
-    assert_not_nil body['name']
-    assert_nil body['id']
-  end
+    test 'should get index of Vmware Snapshots' do
+      get :index, params: { :host_id => host.to_param }
+      assert_response :success
+      assert_not_nil assigns(:snapshots)
+      body = ActiveSupport::JSON.decode(@response.body)
+      assert_not_empty body
+      assert_not_empty body['results']
+    end
 
-  test 'should revert Vmware snapshot' do
-    put :revert, params: { :host_id => host.to_param, :id => snapshot_id.to_param }
-    assert_response :success
-  end
+    test 'should get index of Proxmox Snapshots' do
+      Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
+      get :index, params: { :host_id => proxmox_host.to_param }
+      assert_response :success
+      assert_not_nil assigns(:snapshots)
+      body = ActiveSupport::JSON.decode(@response.body)
+      assert_not_empty body
+      assert_not_empty body['results']
+    end
+
+    test 'should search VMware snapshot' do
+      get :index, params: { :host_id => host.to_param, :search => 'name= clean' }
+      assert_response :success
+      assert_not_nil assigns(:snapshots)
+      body = ActiveSupport::JSON.decode(@response.body)
+      assert_not_empty body
+      assert_not_empty body['results']
+      assert_equal body['results'].count, 1
+    end
+
+    test 'should search Proxmox snapshot' do
+      Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
+      get :index, params: { :host_id => proxmox_host.to_param, :search => 'name= snapshot1' }
+      assert_response :success
+      assert_not_nil assigns(:snapshots)
+      body = ActiveSupport::JSON.decode(@response.body)
+      assert_not_empty body
+      assert_not_empty body['results']
+      assert_equal body['results'].count, 1
+    end
+
+    test 'should refute search Vmware snapshot' do
+      get :index, params: { :host_id => host.to_param, :search => 'name != clean' }
+      assert_response :internal_server_error
+    end
+
+    test 'should show Vmware snapshot' do
+      get :show, params: { :host_id => host.to_param, :id => snapshot_id }
+      assert_not_nil assigns(:snapshot)
+      assert_response :success
+      body = ActiveSupport::JSON.decode(@response.body)
+      assert_not_empty body
+    end
+
+    test 'should show Proxmox snapshot' do
+      Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
+      get :show, params: { :host_id => proxmox_host.to_param, :id => proxmox_snapshot }
+      assert_not_nil assigns(:snapshot)
+      assert_response :success
+      body = ActiveSupport::JSON.decode(@response.body)
+      assert_not_empty body
+    end
+
+    test 'should 404 for unknown Vmware snapshot' do
+      get :show, params: { :host_id => host.to_param, :id => 'does-not-exist' }
+      assert_response :not_found
+    end
+
+    test 'should create Vmware snapshot' do
+      post :create, params: { :host_id => host.to_param, :name => 'test' }
+      assert_response :created
+      assert_not_nil assigns(:snapshot)
+    end
+
+    test 'should create Proxmox snapshot' do
+      Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
+      post :create, params: { :host_id => proxmox_host.to_param, :name => 'test' }
+      assert_response :created
+      assert_not_nil assigns(:snapshot)
+    end
+
+    test 'should update Vmware snapshot' do
+      name = 'test'
+      put :update, params: { :host_id => host.to_param, :id => snapshot_id.to_param, :name => name.to_param }
+      assert_response :success
+    end
+
+    test 'should update Proxmox snapshot' do
+      Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
+      description = 'snapshot1 updated'
+      put :update, params: { :host_id => proxmox_host.to_param, :id => proxmox_snapshot.to_param, :description => description.to_param }
+      assert_response :success
+    end
+
+    test 'should refute update Proxmox snapshot name' do
+      Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
+      name = 'test'
+      put :update, params: { :host_id => proxmox_host.to_param, :id => proxmox_snapshot.to_param, :name => name.to_param }
+      assert_response :unprocessable_entity
+    end
+
+    test 'should destroy Vmware snapshot' do
+      delete :destroy, params: { :host_id => host.to_param, :id => snapshot_id.to_param }
+      assert_response :success
+    end
+
+    test 'should destroy Proxmox snapshot' do
+      Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
+      delete :destroy, params: { :host_id => proxmox_host.to_param, :id => proxmox_snapshot.to_param }
+      assert_response :success
+      body = ActiveSupport::JSON.decode(@response.body)
+      assert_not_nil body['name']
+      assert_nil body['id']
+    end
+
+    test 'should revert Vmware snapshot' do
+      put :revert, params: { :host_id => host.to_param, :id => snapshot_id.to_param }
+      assert_response :success
+    end
 
-  test 'should revert Proxmox snapshot' do
-    Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
-    put :revert, params: { :host_id => proxmox_host.to_param, :id => proxmox_snapshot.to_param }
-    assert_response :success
+    test 'should revert Proxmox snapshot' do
+      Host::Managed.any_instance.stubs(:vm_exists?).returns(false)
+      put :revert, params: { :host_id => proxmox_host.to_param, :id => proxmox_snapshot.to_param }
+      assert_response :success
+    end
   end
 end