foreman_snapshot_management 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: '048b5bbc495a00c7caf44380c5ee03ccd319e592'
-  data.tar.gz: 7d331abbbb267a00c70485e8a74bb1e76d30f684
+  metadata.gz: 30f8e2f14c91a5cf8d79a5c39ae5d65bcf9df35b
+  data.tar.gz: 2b0299b2785eba2d00c7d4e5fc901532d72647d5
 SHA512:
-  metadata.gz: c2f5363bbd5646c3cd7383968fa0529ba483c9e42a0adcf1d483c6668cb5c5e43c8fdf19f46449658ceb07864022ce108644f0697724e4499fe1a493852e0018
-  data.tar.gz: 473771e206b8768650d3085c7494f5b7b4a07c3859894bb7573a2acfff2e4501c44915eb0c545bcadc4938a3efa862d1b1e070aff1ce6525bea147d34971ed74
+  metadata.gz: 4854c380a31a34c47df1cae2040e3c6720b69337b0d0298a1b33dab96034796a5999731d24e417ef8348235e5c2c3b99f890de5a2f7e0a2c35421bf54b541206
+  data.tar.gz: 276fa74482b40f90600e250ca1ddc57308ce4d241ebe835d8d3e7c5af95e28ac207dbb65341fb44bda75cc8824f78ba1f083cbbdd197c4d3faab694beb450a8f

data/app/models/foreman_snapshot_management/snapshot.rb

@@ -10,6 +10,7 @@ module ForemanSnapshotManagement
 
     define_model_callbacks :create, :save, :destroy, :revert
     attr_accessor :id, :raw_snapshot, :name, :description, :host_id, :parent, :create_time
+    define_attribute_methods :name, :description
 
     def self.all_for_host(host)
       snapshots = host.compute_resource.get_snapshots(host.uuid).map do |raw_snapshot|
@@ -19,7 +20,7 @@ module ForemanSnapshotManagement
 
     def self.find_for_host(host, id)
       raw_snapshot = host.compute_resource.get_snapshot(host.uuid, id)
-      new_from_vmware(host, raw_snapshot)
+      new_from_vmware(host, raw_snapshot) if raw_snapshot
     end
 
     def self.new_from_vmware(host, raw_snapshot, opts = {})
@@ -55,16 +56,36 @@ module ForemanSnapshotManagement
     end
 
     def persisted?
-      self.id.present?
+      @id.present?
+    end
+
+    def name=(value)
+      name_will_change! unless value == @name
+      @name = value
+    end
+
+    def description=(value)
+      description_will_change! unless value == @description
+      @description = value
     end
 
     # host accessors
     def host
-      Host.find(self.host_id)
+      @host ||= Host.find(@host_id)
+    end
+
+    def host_id=(host_id)
+      if @host_id != host_id
+        @host_id = host_id
+        @host = nil
+      end
     end
 
     def host=(host)
-      self.host_id = host.id
+      if @host_id != host.id
+        @host_id = host.id
+        @host = host
+      end
     end
 
     def create_time
@@ -81,14 +102,17 @@ module ForemanSnapshotManagement
 
     def update_attributes(new_attributes)
       assign_attributes(new_attributes)
-      save
+      save if changed?
     end
 
     # crud
     def create
       run_callbacks(:create) do
         handle_snapshot_errors do
+          host.audit_comment = "Create snapshot #{name}"
+          host.save!
           host.compute_resource.create_snapshot(host.uuid, name, description)
+          changes_applied
         end
       end
     end
@@ -96,7 +120,10 @@ module ForemanSnapshotManagement
     def save
       run_callbacks(:save) do
         handle_snapshot_errors do
+          host.audit_comment = "Update snapshot #{name}"
+          host.save!
           host.compute_resource.update_snapshot(raw_snapshot, name, description)
+          changes_applied
         end
       end
     end
@@ -104,9 +131,11 @@ module ForemanSnapshotManagement
     def destroy
       run_callbacks(:destroy) do
         result = handle_snapshot_errors do
+          host.audit_comment = "Destroy snapshot #{name}"
+          host.save!
           result = host.compute_resource.remove_snapshot(raw_snapshot, false)
         end
-        self.id = nil
+        @id = nil
         result
       end
     end
@@ -114,6 +143,8 @@ module ForemanSnapshotManagement
     def revert
       run_callbacks(:revert) do
         handle_snapshot_errors do
+          host.audit_comment = "Revert snapshot #{name}"
+          host.save!
           host.compute_resource.revert_snapshot(raw_snapshot)
         end
       end

data/lib/foreman_snapshot_management/version.rb

@@ -1,3 +1,3 @@
 module ForemanSnapshotManagement
-  VERSION = '1.1.0'.freeze
+  VERSION = '1.2.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_snapshot_management
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - ATIX AG
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-19 00:00:00.000000000 Z
+date: 2017-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop