foreman_scc_manager 5.1.0 → 5.3.0

data/webpack/components/SCCAccountIndex/SCCAccountIndex.test.js

@@ -0,0 +1,291 @@
+/* eslint-disable react/prop-types, global-require */
+import React from 'react';
+import '@testing-library/jest-dom';
+import {
+  render,
+  screen,
+  within,
+  fireEvent,
+  waitFor,
+} from '@testing-library/react';
+
+import SccAccountsIndex from './index';
+import { deleteSccAccountAction } from './SCCAccountIndexActions';
+
+jest.mock('foremanReact/common/I18n', () => ({ translate: (s) => s }), {
+  virtual: true,
+});
+jest.mock('foremanReact/common/helpers', () => ({ foremanUrl: (p) => p }), {
+  virtual: true,
+});
+jest.mock('react-redux', () => ({ useDispatch: () => jest.fn() }), {
+  virtual: true,
+});
+
+jest.mock(
+  './SCCAccountIndexActions',
+  () => ({
+    deleteSccAccountAction: jest.fn(),
+  }),
+  { virtual: true }
+);
+
+jest.mock(
+  '@patternfly/react-core',
+  () => {
+    const { forwardRef } = require('react');
+    const PageSection = ({ children }) => <section>{children}</section>;
+
+    const Button = ({
+      children,
+      onClick,
+      component,
+      href,
+      'aria-label': ariaLabel,
+    }) => {
+      if (component === 'a') {
+        return (
+          <a href={href} onClick={onClick} aria-label={ariaLabel}>
+            {children}
+          </a>
+        );
+      }
+      return (
+        <button type="button" onClick={onClick} aria-label={ariaLabel}>
+          {children}
+        </button>
+      );
+    };
+
+    const Dropdown = ({ isOpen, onSelect, onOpenChange, toggle, children }) => (
+      <div>
+        {typeof toggle === 'function' ? toggle({ current: null }) : null}
+        {isOpen ? (
+          <div data-testid="menu">
+            {children}
+            <button
+              type="button"
+              aria-label="Close menu"
+              onClick={() => {
+                if (onSelect) onSelect();
+                if (onOpenChange) onOpenChange(false);
+              }}
+            />
+          </div>
+        ) : null}
+      </div>
+    );
+
+    const DropdownList = ({ children }) => <div role="menu">{children}</div>;
+
+    const DropdownItem = ({ children, onClick, isDisabled }) => (
+      <div
+        role="menuitem"
+        aria-disabled={!!isDisabled}
+        onClick={(e) => {
+          if (!isDisabled && onClick) onClick(e);
+        }}
+      >
+        {children}
+      </div>
+    );
+
+    const MenuToggle = forwardRef(
+      ({ children, onClick, 'aria-label': ariaLabel }, ref) => (
+        <button
+          ref={ref}
+          type="button"
+          aria-label={ariaLabel}
+          onClick={onClick}
+        >
+          {children}
+        </button>
+      )
+    );
+
+    const Modal = ({ title, isOpen, children, actions }) =>
+      isOpen ? (
+        <div role="dialog" aria-label={title}>
+          <h2>{title}</h2>
+          {children}
+          {Array.isArray(actions) &&
+            actions.map((node, i) => <div key={i}>{node}</div>)}
+        </div>
+      ) : null;
+
+    return {
+      __esModule: true,
+      PageSection,
+      Button,
+      Dropdown,
+      DropdownList,
+      DropdownItem,
+      MenuToggle,
+      Modal,
+    };
+  },
+  { virtual: true }
+);
+
+jest.mock(
+  '@patternfly/react-table',
+  () => ({
+    __esModule: true,
+    Table: ({ children, ..._rest }) => <table>{children}</table>,
+    Thead: ({ children }) => <thead>{children}</thead>,
+    Tbody: ({ children }) => <tbody>{children}</tbody>,
+    Tr: ({ children }) => <tr>{children}</tr>,
+    Th: ({ children }) => <th>{children}</th>,
+    Td: ({ children }) => <td>{children}</td>,
+  }),
+  { virtual: true }
+);
+
+// Helpers
+const renderComponent = (initialAccounts = []) =>
+  render(<SccAccountsIndex initialAccounts={initialAccounts} />);
+
+const openActionsMenu = () => {
+  fireEvent.click(screen.getByLabelText('Actions menu'));
+  return screen.getByTestId('menu');
+};
+
+const getRowByAccountName = (name) =>
+  screen.getByRole('row', { name: new RegExp(name, 'i') });
+
+// Tests
+describe('SccAccountsIndex', () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
+  it('renders without crashing and shows the Add button', () => {
+    renderComponent();
+    expect(screen.getByText('Add SCC account')).toBeInTheDocument();
+  });
+
+  it('shows expected table headers', () => {
+    renderComponent();
+    ['Name', 'Products', 'Last synced', 'Actions'].forEach((h) => {
+      expect(screen.getByText(h)).toBeInTheDocument();
+    });
+  });
+
+  it('renders rows from props (names + product counts) with edit links', () => {
+    const data = [
+      { id: 1, name: 'Acc A', scc_products_with_repos_count: 2 },
+      { id: 2, name: 'Acc B', scc_products_with_repos_count: 5 },
+    ];
+    renderComponent(data);
+
+    expect(screen.getByRole('link', { name: 'Acc A' })).toHaveAttribute(
+      'href',
+      '/scc_accounts/1/edit'
+    );
+    expect(screen.getByRole('link', { name: 'Acc B' })).toHaveAttribute(
+      'href',
+      '/scc_accounts/2/edit'
+    );
+
+    const rowA = getRowByAccountName('Acc A');
+    const rowB = getRowByAccountName('Acc B');
+    expect(within(rowA).getByText('2')).toBeInTheDocument();
+    expect(within(rowB).getByText('5')).toBeInTheDocument();
+  });
+
+  it('shows correct "Last synced" content: link when task exists, "never synced" otherwise', () => {
+    const data = [
+      {
+        id: 10,
+        name: 'Successful Sync',
+        scc_products_with_repos_count: 1,
+        sync_status: 'success',
+        sync_task: { id: 'task-123' },
+      },
+      {
+        id: 11,
+        name: 'Failed Sync',
+        scc_products_with_repos_count: 0,
+        sync_status: 'error',
+        sync_task: { id: 'task-456' },
+      },
+      {
+        id: 12,
+        name: 'No Sync',
+        scc_products_with_repos_count: 0,
+        sync_status: null,
+      },
+    ];
+    renderComponent(data);
+
+    const successRow = getRowByAccountName('Successful Sync');
+    expect(
+      within(successRow).getByRole('link', { name: 'success' })
+    ).toHaveAttribute('href', '/foreman_tasks/tasks/task-123');
+
+    const errorRow = getRowByAccountName('Failed Sync');
+    expect(
+      within(errorRow).getByRole('link', { name: 'error' })
+    ).toHaveAttribute('href', '/foreman_tasks/tasks/task-456');
+
+    const noSyncRow = getRowByAccountName('No Sync');
+    expect(within(noSyncRow).getByText('never synced')).toBeInTheDocument();
+  });
+
+  it('delete flow: open modal, confirm calls action, cancel closes modal', async () => {
+    const data = [
+      {
+        id: 5,
+        name: 'ToDelete',
+        scc_products_with_repos_count: 0,
+        sync_status: 'never synced',
+      },
+    ];
+    renderComponent(data);
+
+    const menu = openActionsMenu();
+    fireEvent.click(within(menu).getByRole('menuitem', { name: 'Delete' }));
+
+    const dialog = screen.getByRole('dialog');
+    fireEvent.click(within(dialog).getByRole('button', { name: 'Delete' }));
+
+    expect(deleteSccAccountAction).toHaveBeenCalledWith(
+      expect.any(Function), // dispatch
+      5, // accountId
+      expect.any(Function), // setAccounts
+      expect.any(Function), // setDeleteOpen
+      expect.any(Object) // deletingIdRef
+    );
+
+    fireEvent.click(
+      within(screen.getByRole('dialog')).getByRole('button', { name: 'Cancel' })
+    );
+    await waitFor(() =>
+      expect(screen.queryByRole('dialog')).not.toBeInTheDocument()
+    );
+
+    const menu2 = openActionsMenu();
+    fireEvent.click(within(menu2).getByRole('menuitem', { name: 'Delete' }));
+    fireEvent.click(
+      within(screen.getByRole('dialog')).getByRole('button', { name: 'Cancel' })
+    );
+    await waitFor(() =>
+      expect(screen.queryByRole('dialog')).not.toBeInTheDocument()
+    );
+  });
+
+  it('empty state: renders headers and no data rows', () => {
+    renderComponent([]);
+
+    ['Name', 'Products', 'Last synced', 'Actions'].forEach((h) => {
+      expect(screen.getByText(h)).toBeInTheDocument();
+    });
+
+    expect(screen.getAllByRole('row')).toHaveLength(1);
+
+    expect(screen.queryByLabelText('Actions menu')).not.toBeInTheDocument();
+    expect(
+      screen.queryByRole('button', { name: 'Select Products' })
+    ).not.toBeInTheDocument();
+  });
+});

data/webpack/components/SCCAccountIndex/SCCAccountIndexActions.js

@@ -0,0 +1,205 @@
+import { APIActions } from 'foremanReact/redux/API';
+import { translate as __ } from 'foremanReact/common/I18n';
+
+import { INITIAL_DELAY, MAX_DELAY, BACKOFF } from './SCCAccountIndexConstants';
+
+const isDone = (state, result) =>
+  state === 'stopped' || result === 'success' || result === 'error';
+
+const nextDelay = (prevDelay, changed) => {
+  const base = changed ? INITIAL_DELAY : prevDelay;
+  const next = Math.min(Math.ceil(base * BACKOFF), MAX_DELAY);
+  return next;
+};
+
+const schedule = (taskTimeoutRef, taskId, ms, fn) => {
+  if (taskTimeoutRef.current[taskId])
+    clearTimeout(taskTimeoutRef.current[taskId]);
+  taskTimeoutRef.current[taskId] = setTimeout(fn, ms);
+};
+
+const deriveSyncStatus = (done, result, endedAt, state, fallback) => {
+  if (!done) return state || fallback;
+  return result === 'success' ? endedAt || __('finished') : __('error');
+};
+
+const checkUntilChanged = (
+  dispatch,
+  taskId,
+  accountId,
+  setAccounts,
+  taskTimeoutRef,
+  lastStateRef,
+  delay = INITIAL_DELAY
+) => {
+  if (!taskId) return;
+
+  dispatch(
+    APIActions.get({
+      key: `task_${taskId}`,
+      url: `/foreman_tasks/api/tasks/${taskId}`,
+      handleSuccess: (payload) => {
+        const task = payload?.data ?? payload;
+        const { state, result, ended_at: endedAt } = task || {};
+        const prev = lastStateRef.current[accountId];
+        const done = isDone(state, result);
+
+        setAccounts((prevState) =>
+          prevState.map((acc) => {
+            if (acc.id !== accountId) {
+              return acc;
+            }
+
+            const syncStatus = deriveSyncStatus(
+              done,
+              result,
+              endedAt,
+              state,
+              acc.sync_status
+            );
+            return {
+              ...acc,
+              sync_status: syncStatus,
+              sync_task: {
+                ...(acc.sync_task || {}),
+                id: taskId,
+                ended_at: endedAt,
+              },
+            };
+          })
+        );
+
+        lastStateRef.current[accountId] = state;
+
+        if (done) {
+          if (taskTimeoutRef.current[taskId])
+            clearTimeout(taskTimeoutRef.current[taskId]);
+          delete taskTimeoutRef.current[taskId];
+          delete lastStateRef.current[accountId];
+          return;
+        }
+
+        const changed = state !== prev;
+        const newDelay = nextDelay(delay, changed);
+
+        schedule(taskTimeoutRef, taskId, newDelay, () =>
+          checkUntilChanged(
+            dispatch,
+            taskId,
+            accountId,
+            setAccounts,
+            taskTimeoutRef,
+            lastStateRef,
+            newDelay
+          )
+        );
+      },
+      handleError: () => {
+        const newDelay = nextDelay(delay, false);
+        schedule(taskTimeoutRef, taskId, newDelay, () =>
+          checkUntilChanged(
+            dispatch,
+            taskId,
+            accountId,
+            setAccounts,
+            taskTimeoutRef,
+            lastStateRef,
+            newDelay
+          )
+        );
+      },
+      errorToast: () => null,
+    })
+  );
+};
+
+export const syncSccAccountAction = (
+  dispatch,
+  accountId,
+  setAccounts,
+  taskTimeoutRef,
+  lastStateRef
+) => {
+  if (!accountId) return;
+
+  dispatch(
+    APIActions.put({
+      key: `syncSccAccount_${accountId}`,
+      url: `/api/v2/scc_accounts/${accountId}/sync`,
+      successToast: () => __('Sync task started.'),
+      errorToast: () => __('Failed to start sync task.'),
+      handleSuccess: (resp) => {
+        const taskId = resp?.data?.id;
+        const initialState = resp?.data?.state || 'planned';
+
+        lastStateRef.current[accountId] = initialState;
+
+        setAccounts((prev) =>
+          prev.map((acc) =>
+            acc.id === accountId
+              ? {
+                  ...acc,
+                  sync_status: initialState || __('running'),
+                }
+              : acc
+          )
+        );
+
+        if (taskTimeoutRef.current[taskId]) {
+          clearTimeout(taskTimeoutRef.current[taskId]);
+        }
+        taskTimeoutRef.current[taskId] = setTimeout(() => {
+          checkUntilChanged(
+            dispatch,
+            taskId,
+            accountId,
+            setAccounts,
+            taskTimeoutRef,
+            lastStateRef
+          );
+        }, 15000);
+      },
+      handleError: () => {
+        setAccounts((prev) =>
+          prev.map((acc) =>
+            acc.id === accountId
+              ? {
+                  ...acc,
+                  sync_status: __('error'),
+                  taskId: null,
+                }
+              : acc
+          )
+        );
+      },
+    })
+  );
+};
+
+export const deleteSccAccountAction = (
+  dispatch,
+  id,
+  setAccounts,
+  setDeleteOpen,
+  deletingIdRef
+) => {
+  if (!id) return;
+
+  dispatch(
+    APIActions.delete({
+      key: `deleteSccAccount_${id}`,
+      url: `/api/v2/scc_accounts/${id}`,
+      successToast: () => __('SCC account deleted successfully.'),
+      errorToast: () => __('Failed to delete SCC account.'),
+      handleSuccess: () => {
+        setAccounts((prev) => prev.filter((acc) => acc.id !== id));
+        setDeleteOpen(false);
+        deletingIdRef.current = null;
+      },
+      handleError: () => {
+        setDeleteOpen(false);
+        deletingIdRef.current = null;
+      },
+    })
+  );
+};

data/webpack/components/SCCAccountIndex/SCCAccountIndexConstants.js

@@ -0,0 +1,9 @@
+import { translate as __ } from 'foremanReact/common/I18n';
+
+export const WARN_DELETE = __(
+  'WARNING: If you want to switch SCC accounts and retain the synchronized content, DO NOT delete your old SCC account, even if it is expired. Please change the login and password of your SCC account, instead.\n\nIf you delete your old SCC account, you CANNOT reuse existing repositories, products, content views, and composite content views.\n\n Do you Really want to delete this SCC account %acc_name?'
+);
+
+export const INITIAL_DELAY = 5000;
+export const MAX_DELAY = 30000;
+export const BACKOFF = 1.5;