foreman_rh_cloud 3.0.23 → 3.0.26

data/test/jobs/insights_full_sync_test.rb

@@ -7,6 +7,7 @@ class InsightsFullSyncTest < ActiveSupport::TestCase
   setup do
     InsightsCloud::Async::InsightsFullSync.any_instance.stubs(:plan_rules_sync)
     InsightsCloud::Async::InsightsFullSync.any_instance.stubs(:plan_notifications)
+    FactoryBot.create(:setting, name: 'rh_cloud_token', value: 'MOCK_TOKEN')
 
     uuid1 = 'accdf444-5628-451d-bf3e-cf909ad72756'
     @host1 = FactoryBot.create(:host, :managed, name: 'host1')

data/test/jobs/insights_resolutions_sync_test.rb

@@ -1,4 +1,4 @@
-require 'test_helper'
+require 'test_plugin_helper'
 require 'foreman_tasks/test_helpers'
 
 class InsightsResolutionsSyncTest < ActiveSupport::TestCase
@@ -63,6 +63,7 @@ class InsightsResolutionsSyncTest < ActiveSupport::TestCase
     }
 
     @rule = FactoryBot.create(:insights_rule, rule_id: 'network_tcp_connection_hang|NETWORK_TCP_CONNECTION_HANG_WARN')
+    FactoryBot.create(:setting, name: 'rh_cloud_token', value: 'MOCK_TOKEN')
   end
 
   test 'Resolutions data is replaced with data from cloud' do
@@ -74,4 +75,13 @@ class InsightsResolutionsSyncTest < ActiveSupport::TestCase
     assert_equal 5, InsightsResolution.all.count
     assert_equal 2, @rule.resolutions.count
   end
+
+  test 'Skips pinging the cloud if no rule ids were found' do
+    InsightsCloud::Async::InsightsResolutionsSync.any_instance.expects(:query_insights_resolutions).never
+    InsightsRule.all.delete_all
+
+    ForemanTasks.sync_task(InsightsCloud::Async::InsightsResolutionsSync)
+
+    assert_equal 0, InsightsResolution.all.count
+  end
 end

data/test/jobs/insights_rules_sync_test.rb

@@ -112,6 +112,7 @@ class InsightsRulesSyncTest < ActiveSupport::TestCase
     @hit = FactoryBot.create(:insights_hit, host_id: @host.id)
 
     InsightsCloud::Async::InsightsRulesSync.any_instance.stubs(:plan_resolutions)
+    FactoryBot.create(:setting, name: 'rh_cloud_token', value: 'MOCK_TOKEN')
   end
 
   test 'Hits data is replaced with data from cloud' do

data/test/jobs/inventory_full_sync_test.rb

@@ -242,6 +242,7 @@ class InventoryFullSyncTest < ActiveSupport::TestCase
   end
 
   test 'Host status should be SYNC for inventory hosts' do
+    FactoryBot.create(:setting, name: 'rh_cloud_token', value: 'TEST TOKEN')
     InventorySync::Async::InventoryFullSync.any_instance.expects(:query_inventory).returns(@inventory)
 
     ForemanTasks.sync_task(InventorySync::Async::InventoryFullSync, @host2.organization)
@@ -253,6 +254,7 @@ class InventoryFullSyncTest < ActiveSupport::TestCase
   end
 
   test 'Host status should be DISCONNECT for hosts that are not returned from cloud' do
+    FactoryBot.create(:setting, name: 'rh_cloud_token', value: 'TEST TOKEN')
     InventorySync::Async::InventoryFullSync.any_instance.expects(:query_inventory).returns(@inventory)
     FactoryBot.create(:fact_value, fact_name: fact_names['virt::uuid'], value: '1234', host: @host2)
 
@@ -261,4 +263,12 @@ class InventoryFullSyncTest < ActiveSupport::TestCase
 
     assert_equal InventorySync::InventoryStatus::DISCONNECT, InventorySync::InventoryStatus.where(host_id: @host1.id).first.status
   end
+
+  test 'Task should be aborted if token is not present' do
+    FactoryBot.create(:setting, name: 'rh_cloud_token', value: '')
+
+    InventorySync::Async::InventoryFullSync.any_instance.expects(:plan_self).never
+
+    ForemanTasks.sync_task(InventorySync::Async::InventoryFullSync, @host1.organization)
+  end
 end

data/test/jobs/inventory_hosts_sync_test.rb

@@ -6,6 +6,7 @@ class InventoryHostsSyncTest < ActiveSupport::TestCase
 
   setup do
     User.current = User.find_by(login: 'secret_admin')
+    FactoryBot.create(:setting, name: 'rh_cloud_token', value: 'MOCK_TOKEN')
 
     env = FactoryBot.create(:katello_k_t_environment)
     cv = env.content_views << FactoryBot.create(:katello_content_view, organization: env.organization)
@@ -243,6 +244,7 @@ class InventoryHostsSyncTest < ActiveSupport::TestCase
 
   test 'Inventory should sync UUID for existing Insights Facets' do
     InventorySync::Async::InventoryHostsSync.any_instance.expects(:query_inventory).returns(@inventory)
+    InventorySync::Async::InventoryHostsSync.any_instance.expects(:plan_self_host_sync)
 
     @host2.build_insights.save
 
@@ -255,6 +257,7 @@ class InventoryHostsSyncTest < ActiveSupport::TestCase
 
   test 'Inventory should sync UUID for new Insights Facets' do
     InventorySync::Async::InventoryHostsSync.any_instance.expects(:query_inventory).returns(@inventory)
+    InventorySync::Async::InventoryHostsSync.any_instance.expects(:plan_self_host_sync)
 
     ForemanTasks.sync_task(InventorySync::Async::InventoryHostsSync)
 

data/test/jobs/inventory_self_host_sync_test.rb

@@ -0,0 +1,104 @@
+require 'test_plugin_helper'
+require 'foreman_tasks/test_helpers'
+
+class InventorySelfHostSyncTest < ActiveSupport::TestCase
+  include ForemanTasks::TestHelpers::WithInThreadExecutor
+
+  setup do
+    User.current = User.find_by(login: 'secret_admin')
+    FactoryBot.create(:setting, name: 'rh_cloud_token', value: 'MOCK_TOKEN')
+
+    # this host would pass our plugin queries, so it could be uploaded to the cloud.
+    @host1 = FactoryBot.create(:host)
+    @host1_inventory_id = '3255d080-e6c1-44e2-8d72-b044b9a38d8f'
+
+    ForemanInventoryUpload::Generators::Queries.instance_variable_set(:@fact_names, nil)
+
+    ForemanRhCloud.stubs(:foreman_host).returns(@host1)
+
+    inventory_json = <<-INVENTORY_JSON
+    {
+      "total": 1,
+      "count": 1,
+      "page": 1,
+      "per_page": 1,
+      "results": [
+        {
+          "insights_id": "e0dc5144-d78e-43ed-97be-a7a21d1b6946",
+          "rhel_machine_id": null,
+          "subscription_manager_id": "0f97ee19-6862-4900-aea4-f121c8754776",
+          "satellite_id": "0f97ee19-6862-4900-aea4-f121c8754776",
+          "bios_uuid": "6a0b199a-8225-4ade-ae44-3b18cfc84a01",
+          "ip_addresses": [
+            "192.168.122.136"
+          ],
+          "fqdn": "#{@host1.fqdn}",
+          "mac_addresses": [
+            "52:54:00:02:d1:2a",
+            "00:00:00:00:00:00"
+          ],
+          "external_id": null,
+          "id": "#{@host1_inventory_id}",
+          "account": "1460290",
+          "display_name": "insights-rh8.example.com",
+          "ansible_host": null,
+          "facts": [
+            {
+              "namespace": "satellite",
+              "facts": {
+                "virtual_host_name": "virt-who-nobody.home-1",
+                "satellite_instance_id": "fc4d0cb0-a0b0-421e-b096-b028319b8e47",
+                "is_simple_content_access": false,
+                "distribution_version": "8.3",
+                "satellite_version": "6.8.4",
+                "organization_id": 1,
+                "is_hostname_obfuscated": false,
+                "virtual_host_uuid": "a90e6294-4766-420a-8dc0-3ec5b96d60ec"
+              }
+            },
+            {
+              "namespace": "yupana",
+              "facts": {
+                "report_platform_id": "d37afa50-08ce-4efb-a0e5-759c2a016661",
+                "report_slice_id": "5bf791d7-5e30-4a3c-929a-11dd9fa6eb72",
+                "source": "Satellite",
+                "yupana_host_id": "78c62486-0ac4-406c-a4c0-3a1f81112a2d",
+                "account": "1460290"
+              }
+            }
+          ],
+          "reporter": "puptoo",
+          "stale_timestamp": "2021-03-19T06:05:12.092136+00:00",
+          "stale_warning_timestamp": "2021-03-26T06:05:12.092136+00:00",
+          "culled_timestamp": "2021-04-02T06:05:12.092136+00:00",
+          "created": "2021-02-08T13:22:50.555671+00:00",
+          "updated": "2021-03-18T01:05:12.131847+00:00"
+        }
+      ]
+    }
+    INVENTORY_JSON
+    @inventory = JSON.parse(inventory_json)
+  end
+
+  test 'Inventory should sync UUID for existing Insights Facets' do
+    InventorySync::Async::InventorySelfHostSync.any_instance.expects(:query_inventory).returns(@inventory)
+
+    @host1.build_insights.save
+
+    ForemanTasks.sync_task(InventorySync::Async::InventorySelfHostSync)
+
+    @host1.reload
+
+    assert_equal @host1_inventory_id, @host1.insights.uuid
+  end
+
+  test 'Inventory should sync UUID for new Insights Facets' do
+    InventorySync::Async::InventorySelfHostSync.any_instance.expects(:query_inventory).returns(@inventory)
+
+    ForemanTasks.sync_task(InventorySync::Async::InventorySelfHostSync)
+
+    @host1.reload
+
+    assert_equal @host1_inventory_id, @host1.insights.uuid
+  end
+end

data/test/models/insights_client_report_status_test.rb

@@ -1,77 +1,75 @@
 require 'test_plugin_helper'
 
 class InsightsClientReportStatusTest < ActiveSupport::TestCase
-  describe 'to_status' do
-    let(:host) { FactoryBot.create(:host, :managed) }
-
-    setup do
-      CommonParameter.where(name: 'host_registration_insights').destroy_all
-    end
-
-    test 'host_registration_insights = true & is getting data' do
-      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: true)
-      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
-
-      assert_equal 0, host_status.to_status(data: true)
-    end
-
-    test 'host_registration_insights = true & no data in less than 48 hours' do
-      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: true)
-      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
-      host_status.update(reported_at: 1.day.ago)
-      assert_equal 0, host_status.to_status
-    end
-
-    test 'host_registration_insights = true & no data in more than 48 hours' do
-      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: true)
-      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
-      host_status.update(reported_at: 3.days.ago)
-      assert_equal 1, host_status.to_status
-    end
-
-    test 'host_registration_insights = false & no data' do
-      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: false)
-      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
-      assert_equal 2, host_status.to_status
-    end
-
-    test 'host_registration_insights = false & getting data' do
-      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: false)
-      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
-      assert_equal 3, host_status.to_status(data: true)
-    end
-
-    test 'host_registration_insights = nil & is getting data' do
-      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
-      assert_equal 3, host_status.to_status(data: true)
-    end
-
-    test 'host_registration_insights = nil & no data in less than 48 hours' do
-      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
-      host_status.update(reported_at: 1.day.ago)
-      assert_equal 2, host_status.to_status
-    end
-
-    test 'host_registration_insights = nil & no data in more than 48 hours' do
-      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
-      host_status.update(reported_at: 3.days.ago)
-      assert_equal 2, host_status.to_status
-    end
-
-    test 'override param on host level from `false` to `true`' do
-      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: false)
-      FactoryBot.create(:host_parameter, name: 'host_registration_insights', key_type: 'boolean', value: true, host: host)
-
-      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
-      assert_equal 0, host_status.to_status(data: true)
-    end
-
-    test 'override param on host level from `true` to `false`' do
-      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: true)
-      FactoryBot.create(:host_parameter, name: 'host_registration_insights', key_type: 'boolean', value: false, host: host)
-
-      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
-      assert_equal 2, host_status.to_status
-    end
+  setup do
+    @host = FactoryBot.create(:host, :managed)
+  end
+
+  test 'fresh host does not have insights status' do
+    @host.reload
+
+    refute @host.host_statuses.where(type: 'InsightsClientReportStatus').exists?
+    insights_status = @host.get_status(InsightsClientReportStatus)
+    refute insights_status.relevant?
+  end
+
+  test 'host can refresh all its statuses' do
+    @host.refresh_statuses
+    @host.reload
+
+    refute @host.host_statuses.where(type: 'InsightsClientReportStatus').exists?
+  end
+
+  test 'host with correct report status sets global status to OK' do
+    global_status = @host.get_status(HostStatus.find_status_by_humanized_name('Global'))
+    # Status has to be OK before action
+    assert_equal HostStatus::Global::OK, global_status.status
+
+    # force create record
+    @host.get_status(InsightsClientReportStatus).refresh!
+    # now refresh should work
+    @host.refresh_statuses([InsightsClientReportStatus])
+
+    @host.reload
+    global_status = @host.get_status(HostStatus.find_status_by_humanized_name('Global'))
+    # Status has to be OK after the action too
+    assert_equal HostStatus::Global::OK, global_status.status
+
+    insights_status = @host.get_status(InsightsClientReportStatus)
+    # assert the status would be displayed
+    assert insights_status.relevant?
+  end
+
+  test 'host will return to OK once the status is refreshed' do
+    global_status = @host.get_status(HostStatus.find_status_by_humanized_name('Global'))
+    # Status has to be OK before action
+    assert_equal HostStatus::Global::OK, global_status.status
+
+    insights_status = @host.get_status(InsightsClientReportStatus)
+    insights_status.status = InsightsClientReportStatus::NO_REPORT
+    insights_status.save!
+    @host.refresh_global_status!
+    global_status = @host.global_status
+    assert_equal HostStatus::Global::ERROR, global_status
+
+    @host.refresh_statuses([InsightsClientReportStatus])
+
+    @host.reload
+    # Status has to be OK after the action too
+    assert_equal HostStatus::Global::OK, @host.global_status
+  end
+
+  test 'host with stale status would set global to ERROR' do
+    global_status = @host.get_status(HostStatus.find_status_by_humanized_name('Global'))
+    # Status has to be OK before action
+    assert_equal HostStatus::Global::OK, global_status.status
+
+    insights_status = @host.get_status(InsightsClientReportStatus)
+    insights_status.status = InsightsClientReportStatus::NO_REPORT
+    insights_status.save!
+    @host.refresh_global_status!
+    @host.reload
+
+    assert_equal HostStatus::Global::ERROR, @host.global_status
   end
 end

data/test/unit/services/foreman_rh_cloud/cloud_request_forwarder_test.rb

@@ -42,12 +42,13 @@ class CloudRequestForwarderTest < ActiveSupport::TestCase
   test 'should prepare correct cloud url' do
     paths = {
       "/redhat_access/r/insights/platform/module-update-router/v1/channel?module=insights-core" => "https://cert.cloud.redhat.com/api/module-update-router/v1/channel?module=insights-core",
-      "/redhat_access/r/insights/v1/static/release/insights-core.egg" => "https://cloud.redhat.com/api/v1/static/release/insights-core.egg",
-      "/redhat_access/r/insights/v1/static/uploader.v2.json" => "https://cloud.redhat.com/api/v1/static/uploader.v2.json",
-      "/redhat_access/r/insights/v1/static/uploader.v2.json.asc" => "https://cloud.redhat.com/api/v1/static/uploader.v2.json.asc",
+      "/redhat_access/r/insights/v1/static/release/insights-core.egg" => "https://cert-api.access.redhat.com/r/insights/v1/static/release/insights-core.egg",
+      "/redhat_access/r/insights/v1/static/uploader.v2.json" => "https://cert-api.access.redhat.com/r/insights/v1/static/uploader.v2.json",
+      "/redhat_access/r/insights/v1/static/uploader.v2.json.asc" => "https://cert-api.access.redhat.com/r/insights/v1/static/uploader.v2.json.asc",
       "/redhat_access/r/insights/platform/inventory/v1/hosts" => "https://cert.cloud.redhat.com/api/inventory/v1/hosts",
       "/redhat_access/r/insights/platform/ingress/v1/upload" => "https://cert.cloud.redhat.com/api/ingress/v1/upload",
       "/redhat_access/r/insights/uploads/67200803-132b-474b-a6f9-37be74185df4" => "https://cert-api.access.redhat.com/r/insights/uploads/67200803-132b-474b-a6f9-37be74185df4",
+      "/redhat_access/r/insights/" => "https://cert.cloud.redhat.com/api/apicast-tests/ping",
     }
 
     paths.each do |key, value|

data/test/unit/services/foreman_rh_cloud/insights_status_cleaner_test.rb

@@ -0,0 +1,31 @@
+require 'test_plugin_helper'
+
+class InsightsStatusCleanerTest < ActiveSupport::TestCase
+  setup do
+    @host1 = FactoryBot.create(:host)
+    @host2 = FactoryBot.create(:host)
+
+    InsightsClientReportStatus.find_or_initialize_by(host_id: @host1.id).update(status: InsightsClientReportStatus::NO_REPORT, reported_at: Time.now - InsightsClientReportStatus::REPORT_INTERVAL + 1.day)
+    InsightsClientReportStatus.find_or_initialize_by(host_id: @host2.id).update(status: InsightsClientReportStatus::NO_REPORT, reported_at: Time.now - InsightsClientReportStatus::REPORT_INTERVAL + 1.day)
+
+    @host1.refresh_global_status!
+    @host2.refresh_global_status!
+  end
+
+  test 'Cleans hosts by search condition' do
+    assert_equal HostStatus::Global::ERROR, @host1.global_status
+    assert_equal HostStatus::Global::ERROR, @host2.global_status
+
+    instance = ForemanRhCloud::InsightsStatusCleaner.new
+    actual_count = instance.clean("name = #{@host1.name}")
+
+    @host1.reload
+    @host2.refresh_global_status!
+
+    assert_equal 1, actual_count
+    assert_equal HostStatus::Global::OK, @host1.global_status
+    assert_equal HostStatus::Global::ERROR, @host2.global_status
+    assert InsightsClientReportStatus.where(host_id: @host1.id).empty?
+    refute InsightsClientReportStatus.where(host_id: @host2.id).empty?
+  end
+end

data/test/unit/services/foreman_rh_cloud/template_renderer_helper_test.rb

@@ -8,6 +8,7 @@ class TemplateRendererHelperTest < ActiveSupport::TestCase
     response.stubs(:body).returns('TEST PLAYBOOK')
     ForemanRhCloud::RemediationsRetriever.any_instance.stubs(:query_playbook).returns(response)
     @host1 = FactoryBot.create(:host)
+    FactoryBot.create(:setting, name: 'rh_cloud_token', value: 'MOCK_TOKEN')
   end
 
   test 'Generates a playbook for hit and remediation' do

data/test/unit/slice_generator_test.rb

@@ -53,6 +53,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
       'insights_client::hostname',
       'insights_client::obfuscate_ip_enabled',
       'insights_client::ips',
+      'insights_id',
     ]
   end
 
@@ -657,6 +658,20 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     assert_not_nil actual_host['bios_uuid']
   end
 
+  test 'passes valid insights_id field' do
+    FactoryBot.create(:fact_value, fact_name: fact_names['insights_id'], value: 'D30B0B42-7824-2635-C62D-491394DE43F7', host: @host)
+
+    batch = Host.where(id: @host.id).in_batches.first
+    generator = create_generator(batch)
+
+    json_str = generator.render
+    actual = JSON.parse(json_str.join("\n"))
+
+    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_not_nil(actual_host = actual['hosts'].first)
+    assert_not_nil actual_host['insights_id']
+  end
+
   private
 
   def create_generator(batch, name = '00000000-0000-0000-0000-000000000000')

data/test/unit/tags_generator_test.rb

@@ -62,6 +62,47 @@ class TagsGeneratorTest < ActiveSupport::TestCase
     assert_equal false, actual.key?('content_view')
   end
 
+  test 'generates parameter tags' do
+    FactoryBot.create(:setting, :name => 'include_parameter_tags', :settings_type => "boolean", :category => "Setting::RhCloud", :default => false, :value => true)
+
+    @host.stubs(:host_inherited_params_objects).returns(
+      [
+        OpenStruct.new(name: 'bool_param', value: true),
+        OpenStruct.new(name: 'false_param', value: false),
+        OpenStruct.new(name: 'int_param', value: 1),
+        OpenStruct.new(name: 'empty_param', value: nil),
+        OpenStruct.new(name: 'empty_str_param', value: ''),
+      ]
+    )
+
+    generator = create_generator
+    actual = Hash[generator.generate_parameters]
+
+    assert_equal 3, actual.count
+    assert_equal true, actual['bool_param']
+    assert_equal false, actual['false_param']
+    assert_equal 1, actual['int_param']
+  end
+
+  test 'skips parameter tags if include_parameter_tags setting is off' do
+    FactoryBot.create(:setting, :name => 'include_parameter_tags', :settings_type => "boolean", :category => "Setting::RhCloud", :default => false, :value => false)
+
+    @host.stubs(:host_inherited_params_objects).returns(
+      [
+        OpenStruct.new(name: 'bool_param', value: true),
+        OpenStruct.new(name: 'false_param', value: false),
+        OpenStruct.new(name: 'int_param', value: 1),
+        OpenStruct.new(name: 'empty_param', value: nil),
+        OpenStruct.new(name: 'empty_str_param', value: ''),
+      ]
+    )
+
+    generator = create_generator
+    actual = generator.generate_parameters.group_by { |key, value| key }
+
+    assert_equal 0, actual.count
+  end
+
   private
 
   def create_generator