foreman_rh_cloud 3.0.19 → 4.0.22

data/webpack/InsightsCloudSync/InsightsCloudSync.js

@@ -6,10 +6,12 @@ import PageLayout from 'foremanReact/routes/common/PageLayout/PageLayout';
 import InsightsHeader from './Components/InsightsHeader';
 import { NoTokenEmptyState } from './Components/NoTokenEmptyState';
 import InsightsTable from './Components/InsightsTable';
+import RemediationModal from './Components/RemediationModal';
 import {
   INSIGHTS_SYNC_PAGE_TITLE,
   INSIGHTS_SEARCH_PROPS,
 } from './InsightsCloudSyncConstants';
+import './InsightsCloudSync.scss';
 
 const InsightsCloudSync = ({
   syncInsights,
@@ -32,9 +34,15 @@ const InsightsCloudSync = ({
         onSearch={nextQuery => fetchInsights({ query: nextQuery, page: 1 })}
         header={INSIGHTS_SYNC_PAGE_TITLE}
         toolbarButtons={
-          <Button variant="primary" onClick={syncInsights}>
-            {__('Start recommendations sync')}
-          </Button>
+          <>
+            <RemediationModal />
+            <Button
+              variant="secondary"
+              onClick={() => syncInsights(fetchInsights, query)}
+            >
+              {__('Start recommendations sync')}
+            </Button>
+          </>
         }
         searchQuery={query}
         beforeToolbarComponent={<InsightsHeader />}

data/webpack/InsightsCloudSync/InsightsCloudSync.scss

@@ -0,0 +1,5 @@
+.rh-cloud-insights {
+  .btn-toolbar {
+    display: inherit;
+  }
+}

data/webpack/InsightsCloudSync/InsightsCloudSyncActions.js

@@ -1,25 +1,49 @@
-import React from 'react';
 import { post } from 'foremanReact/redux/API';
 import { translate as __ } from 'foremanReact/common/I18n';
 import { insightsCloudUrl } from './InsightsCloudSyncHelpers';
-import { INSIGHTS_CLOUD_SYNC } from './InsightsCloudSyncConstants';
-import { foremanUrl } from '../ForemanRhCloudHelpers';
+import {
+  INSIGHTS_CLOUD_SYNC,
+  INSIGHTS_CLOUD_SYNC_TASK,
+} from './InsightsCloudSyncConstants';
+import { setupTaskPolling, taskRelatedToast } from '../common/ForemanTasks';
 
-export const syncInsights = () =>
-  post({
-    key: INSIGHTS_CLOUD_SYNC,
-    url: insightsCloudUrl('tasks'),
-    successToast: response => (
-      <span>
-        {__('Recommendation sync has started: ')}
-        <a
-          target="_blank"
-          rel="noopener noreferrer"
-          href={foremanUrl(`/foreman_tasks/tasks/${response.data?.task?.id}`)}
-        >
-          {__('view the task in progress')}
-        </a>
-      </span>
-    ),
-    errorToast: error => `${__('Recommendation sync has failed: ')} ${error}`,
+export const syncInsights = (fetchInsights, query) => dispatch =>
+  dispatch(
+    post({
+      key: INSIGHTS_CLOUD_SYNC,
+      url: insightsCloudUrl('tasks'),
+      handleSuccess: ({
+        data: {
+          task: { id },
+        },
+      }) => {
+        dispatch(syncInsightsStartedToast(id));
+        dispatch(setupInsightsTaskPolling(id, fetchInsights, query, dispatch));
+      },
+      errorToast: error => syncInsightsError(error),
+    })
+  );
+
+const syncInsightsError = error =>
+  `${__('Recommendation sync has failed: ')} ${error}`;
+
+const syncInsightsStartedToast = taskId =>
+  taskRelatedToast(taskId, 'info', __('Recommendation sync has started: '));
+
+const setupInsightsTaskPolling = (taskId, fetchInsights, query, dispatch) =>
+  setupTaskPolling({
+    taskId,
+    key: INSIGHTS_CLOUD_SYNC_TASK,
+    onTaskSuccess: () => {
+      fetchInsights({ query, page: 1 });
+      dispatch(
+        taskRelatedToast(
+          taskId,
+          'success',
+          __('Recommendations synced successfully')
+        )
+      );
+    },
+    taskErrorMessage: data => syncInsightsError(data.humanized.errors),
+    dispatch,
   });

data/webpack/InsightsCloudSync/InsightsCloudSyncConstants.js

@@ -4,6 +4,8 @@ import { foremanUrl } from '../ForemanRhCloudHelpers';
 
 export const INSIGHTS_CLOUD_SYNC = 'INSIGHTS_CLOUD_SYNC';
 
+export const INSIGHTS_CLOUD_SYNC_TASK = 'INSIGHTS_CLOUD_SYNC_TASK';
+
 export const INSIGHTS_SYNC_PAGE_TITLE = __('Red Hat Insights');
 
 export const INSIGHTS_PATH = foremanUrl('/foreman_rh_cloud/insights_cloud');

data/webpack/InsightsCloudSync/__snapshots__/InsightsCloudSync.test.js.snap

@@ -27,12 +27,15 @@ exports[`InsightsCloudSync render 1`] = `
     searchQuery=""
     searchable={true}
     toolbarButtons={
-      <Button
-        onClick={[Function]}
-        variant="primary"
-      >
-        Start recommendations sync
-      </Button>
+      <React.Fragment>
+        <UNDEFINED />
+        <Button
+          onClick={[Function]}
+          variant="secondary"
+        >
+          Start recommendations sync
+        </Button>
+      </React.Fragment>
     }
   >
     <Connect(InsightsTable) />

data/webpack/InsightsCloudSync/__tests__/__snapshots__/InsightsCloudSyncActions.test.js.snap

@@ -1,11 +1,15 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`Insights cloud sync actions should syncInsights 1`] = `
-Object {
-  "errorToast": [Function],
-  "key": "INSIGHTS_CLOUD_SYNC",
-  "successToast": [Function],
-  "type": "post-some-type",
-  "url": "/insights_cloud/tasks",
-}
+Array [
+  Array [
+    Object {
+      "errorToast": [Function],
+      "handleSuccess": [Function],
+      "key": "INSIGHTS_CLOUD_SYNC",
+      "type": "post-some-type",
+      "url": "/insights_cloud/tasks",
+    },
+  ],
+]
 `;

data/webpack/common/ForemanTasks/ForemanTasksActions.js

@@ -0,0 +1,64 @@
+import React from 'react';
+import { get } from 'foremanReact/redux/API';
+import { withInterval } from 'foremanReact/redux/middlewares/IntervalMiddleware';
+import { addToast } from 'foremanReact/redux/actions/toasts';
+import { translate as __ } from 'foremanReact/common/I18n';
+import { foremanTaskDetailsUrl } from './ForemanTasksHelpers';
+import { foremanUrl } from '../../ForemanRhCloudHelpers';
+
+export const setupTaskPolling = ({
+  taskId,
+  key,
+  onTaskSuccess,
+  onTaskError,
+  taskErrorMessage,
+  dispatch,
+}) =>
+  withInterval(
+    get({
+      key,
+      url: foremanTaskDetailsUrl(taskId),
+      handleSuccess: ({ data }, stopTaskInterval) => {
+        if (data.result === 'success') {
+          stopTaskInterval();
+          onTaskSuccess(data, dispatch);
+        }
+        if (data.result === 'error') {
+          stopTaskInterval();
+          if (taskErrorMessage === undefined) {
+            taskErrorMessage = errorData =>
+              `${__('The task failed with the following error:')} ${
+                errorData.humanized.errors
+              }`;
+          }
+          if (onTaskError === undefined) {
+            onTaskError = errorData =>
+              dispatch(defaultTaskErrorHandler(errorData, taskErrorMessage));
+          }
+          onTaskError(data, dispatch);
+        }
+      },
+      errorToast: error => `Could not get task details: ${error}`,
+    })
+  );
+
+export const taskRelatedToast = (taskID, type, message) =>
+  addToast({
+    type,
+    message: (
+      <span>
+        {message}
+        <br />
+        <a
+          target="_blank"
+          rel="noopener noreferrer"
+          href={foremanUrl(`/foreman_tasks/tasks/${taskID}`)}
+        >
+          {__('view the task page for more details')}
+        </a>
+      </span>
+    ),
+  });
+
+const defaultTaskErrorHandler = (data, taskErrorMessage) =>
+  taskRelatedToast(data.id, 'error', taskErrorMessage(data));

data/webpack/common/ForemanTasks/ForemanTasksHelpers.js

@@ -0,0 +1,7 @@
+import { foremanUrl } from '../../ForemanRhCloudHelpers';
+
+export const foremanTasksApiPath = path =>
+  foremanUrl(`/foreman_tasks/api/tasks/${path}`);
+
+export const foremanTaskDetailsUrl = id =>
+  foremanTasksApiPath(`${id}/details?include_permissions`);

data/webpack/common/ForemanTasks/index.js

@@ -0,0 +1 @@
+export { setupTaskPolling, taskRelatedToast } from './ForemanTasksActions';

data/webpack/common/table/helpers.js

@@ -0,0 +1,7 @@
+export const getPerPageOptions = (urlPerPage, appPerPage) => {
+  const initialValues = new Set([5, 10, 15, 25, 50]);
+  initialValues.add(appPerPage);
+  urlPerPage && initialValues.add(urlPerPage);
+  const options = [...initialValues].sort((a, b) => a - b);
+  return options.map(value => ({ title: value.toString(), value }));
+};

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_rh_cloud
 version: !ruby/object:Gem::Version
-  version: 3.0.19
+  version: 4.0.22
 platform: ruby
 authors:
 - Foreman Red Hat Cloud team
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-04-01 00:00:00.000000000 Z
+date: 2021-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: katello
@@ -160,6 +160,7 @@ files:
 - app/helpers/foreman_inventory_upload_helper.rb
 - app/helpers/foreman_inventory_upload_host_helper.rb
 - app/models/concerns/rh_cloud_host.rb
+- app/models/insights_client_report_status.rb
 - app/models/insights_facet.rb
 - app/models/insights_hit.rb
 - app/models/insights_resolution.rb
@@ -171,8 +172,13 @@ files:
 - app/services/foreman_rh_cloud/branch_info.rb
 - app/services/foreman_rh_cloud/cloud_auth.rb
 - app/services/foreman_rh_cloud/cloud_connector.rb
+- app/services/foreman_rh_cloud/cloud_request.rb
 - app/services/foreman_rh_cloud/cloud_request_forwarder.rb
+- app/services/foreman_rh_cloud/remediations_retriever.rb
+- app/services/foreman_rh_cloud/template_renderer_helper.rb
+- app/subscribers/foreman_rh_cloud/insights_subscriber.rb
 - app/views/hosts/_insights_tab.html.erb
+- app/views/job_templates/rh_cloud_remediations.erb
 - app/views/layouts/foreman_rh_cloud/application.html.erb
 - config/Gemfile.lock.gh_test
 - config/database.yml.example
@@ -186,6 +192,9 @@ files:
 - db/migrate/20210214000001_create_rules_and_resolutions.foreman_rh_cloud.rb
 - db/migrate/20210214000002_add_rule_id_to_hits.foreman_rh_cloud.rb
 - db/migrate/20210307000001_add_unique_to_insights_facet.foreman_rh_cloud.rb
+- db/migrate/20210404000001_change_resolutions.foreman_rh_cloud.rb
+- db/seeds.d/179_ui_notifications.rb
+- db/seeds.d/50_job_templates.rb
 - lib/foreman_inventory_upload.rb
 - lib/foreman_inventory_upload/async/async_helpers.rb
 - lib/foreman_inventory_upload/async/generate_all_reports_job.rb
@@ -208,12 +217,15 @@ files:
 - lib/foreman_rh_cloud/version.rb
 - lib/insights_cloud.rb
 - lib/insights_cloud/async/insights_full_sync.rb
+- lib/insights_cloud/async/insights_generate_notifications.rb
+- lib/insights_cloud/async/insights_resolutions_sync.rb
 - lib/insights_cloud/async/insights_rules_sync.rb
 - lib/insights_cloud/async/insights_scheduled_sync.rb
 - lib/insights_cloud/async/rules_result.rb
 - lib/inventory_sync/async/host_result.rb
 - lib/inventory_sync/async/inventory_full_sync.rb
 - lib/inventory_sync/async/inventory_hosts_sync.rb
+- lib/inventory_sync/async/inventory_scheduled_sync.rb
 - lib/inventory_sync/async/query_inventory_job.rb
 - lib/tasks/foreman_rh_cloud_tasks.rake
 - lib/tasks/insights.rake
@@ -232,9 +244,11 @@ files:
 - test/factories/insights_factories.rb
 - test/factories/inventory_upload_factories.rb
 - test/jobs/insights_full_sync_test.rb
+- test/jobs/insights_resolutions_sync_test.rb
 - test/jobs/insights_rules_sync_test.rb
 - test/jobs/inventory_full_sync_test.rb
 - test/jobs/upload_report_job_test.rb
+- test/models/insights_client_report_status_test.rb
 - test/test_plugin_helper.rb
 - test/unit/archived_report_generator_test.rb
 - test/unit/fact_helpers_test.rb
@@ -243,6 +257,8 @@ files:
 - test/unit/rh_cloud_http_proxy_test.rb
 - test/unit/services/foreman_rh_cloud/branch_info_test.rb
 - test/unit/services/foreman_rh_cloud/cloud_request_forwarder_test.rb
+- test/unit/services/foreman_rh_cloud/remediations_retriever_test.rb
+- test/unit/services/foreman_rh_cloud/template_renderer_helper_test.rb
 - test/unit/shell_process_job_test.rb
 - test/unit/slice_generator_test.rb
 - test/unit/tags_generator_test.rb
@@ -538,15 +554,24 @@ files:
 - webpack/InsightsCloudSync/Components/InsightsTable/__tests__/__snapshots__/InsightsTableActions.test.js.snap
 - webpack/InsightsCloudSync/Components/InsightsTable/__tests__/__snapshots__/InsightsTableSelectors.test.js.snap
 - webpack/InsightsCloudSync/Components/InsightsTable/__tests__/fixtures.js
-- webpack/InsightsCloudSync/Components/InsightsTable/components/EmptyState.js
 - webpack/InsightsCloudSync/Components/InsightsTable/index.js
 - webpack/InsightsCloudSync/Components/InsightsTable/table.scss
 - webpack/InsightsCloudSync/Components/NoTokenEmptyState.js
+- webpack/InsightsCloudSync/Components/RemediationModal/RemediateButton.js
+- webpack/InsightsCloudSync/Components/RemediationModal/RemediationActions.js
+- webpack/InsightsCloudSync/Components/RemediationModal/RemediationHelpers.js
+- webpack/InsightsCloudSync/Components/RemediationModal/RemediationModal.js
+- webpack/InsightsCloudSync/Components/RemediationModal/RemediationModal.scss
+- webpack/InsightsCloudSync/Components/RemediationModal/RemediationModalFooter.js
+- webpack/InsightsCloudSync/Components/RemediationModal/RemediationTableConstants.js
+- webpack/InsightsCloudSync/Components/RemediationModal/Resolutions.js
+- webpack/InsightsCloudSync/Components/RemediationModal/index.js
 - webpack/InsightsCloudSync/Components/__tests__/InsightsHeader.test.js
 - webpack/InsightsCloudSync/Components/__tests__/NoTokenEmptyState.test.js
 - webpack/InsightsCloudSync/Components/__tests__/__snapshots__/InsightsHeader.test.js.snap
 - webpack/InsightsCloudSync/Components/__tests__/__snapshots__/NoTokenEmptyState.test.js.snap
 - webpack/InsightsCloudSync/InsightsCloudSync.js
+- webpack/InsightsCloudSync/InsightsCloudSync.scss
 - webpack/InsightsCloudSync/InsightsCloudSync.test.js
 - webpack/InsightsCloudSync/InsightsCloudSyncActions.js
 - webpack/InsightsCloudSync/InsightsCloudSyncConstants.js
@@ -596,6 +621,9 @@ files:
 - webpack/__tests__/__snapshots__/ForemanRhCloudHelpers.test.js.snap
 - webpack/__tests__/__snapshots__/ForemanRhCloudSelectors.test.js.snap
 - webpack/__tests__/__snapshots__/ForemanRhCloudTestHelpers.test.js.snap
+- webpack/common/ForemanTasks/ForemanTasksActions.js
+- webpack/common/ForemanTasks/ForemanTasksHelpers.js
+- webpack/common/ForemanTasks/index.js
 - webpack/common/Switcher/HelpLabel.js
 - webpack/common/Switcher/SwitcherPF4.js
 - webpack/common/Switcher/SwitcherPF4.scss
@@ -604,6 +632,8 @@ files:
 - webpack/common/Switcher/__tests__/__snapshots__/HelpLabel.test.js.snap
 - webpack/common/Switcher/__tests__/__snapshots__/SwitcherPF4.test.js.snap
 - webpack/common/Switcher/index.js
+- webpack/common/table/EmptyState.js
+- webpack/common/table/helpers.js
 - webpack/global_index.js
 - webpack/index.js
 homepage: https://github.com/theforeman/foreman_rh_cloud
@@ -625,7 +655,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.2.3
 signing_key:
 specification_version: 4
 summary: Summary of ForemanRhCloud.
@@ -639,9 +669,11 @@ test_files:
 - test/factories/insights_factories.rb
 - test/factories/inventory_upload_factories.rb
 - test/jobs/insights_full_sync_test.rb
+- test/jobs/insights_resolutions_sync_test.rb
 - test/jobs/insights_rules_sync_test.rb
 - test/jobs/inventory_full_sync_test.rb
 - test/jobs/upload_report_job_test.rb
+- test/models/insights_client_report_status_test.rb
 - test/test_plugin_helper.rb
 - test/unit/archived_report_generator_test.rb
 - test/unit/fact_helpers_test.rb
@@ -650,6 +682,8 @@ test_files:
 - test/unit/rh_cloud_http_proxy_test.rb
 - test/unit/services/foreman_rh_cloud/branch_info_test.rb
 - test/unit/services/foreman_rh_cloud/cloud_request_forwarder_test.rb
+- test/unit/services/foreman_rh_cloud/remediations_retriever_test.rb
+- test/unit/services/foreman_rh_cloud/template_renderer_helper_test.rb
 - test/unit/shell_process_job_test.rb
 - test/unit/slice_generator_test.rb
 - test/unit/tags_generator_test.rb