foreman_rh_cloud 15.0.0 → 15.0.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (39) hide show
  1. checksums.yaml +4 -4
  2. data/app/controllers/api/v2/advisor_engine/advisor_engine_controller.rb +1 -73
  3. data/app/controllers/foreman_inventory_upload/accounts_controller.rb +29 -14
  4. data/app/controllers/insights_cloud/ui_requests_controller.rb +19 -2
  5. data/app/services/foreman_rh_cloud/insights_api_forwarder.rb +93 -79
  6. data/config/package-lock.json.plugin +7160 -21310
  7. data/config/routes.rb +0 -4
  8. data/lib/foreman_inventory_upload/async/generate_host_report.rb +6 -1
  9. data/lib/foreman_inventory_upload/async/host_inventory_report_job.rb +10 -0
  10. data/lib/foreman_inventory_upload/async/queue_for_upload_job.rb +1 -0
  11. data/lib/foreman_inventory_upload/async/upload_report_direct_job.rb +16 -2
  12. data/lib/foreman_inventory_upload/generators/archived_report.rb +4 -4
  13. data/lib/foreman_inventory_upload/generators/slice.rb +55 -12
  14. data/lib/foreman_inventory_upload.rb +69 -0
  15. data/lib/foreman_rh_cloud/plugin.rb +24 -11
  16. data/lib/foreman_rh_cloud/version.rb +1 -1
  17. data/package.json +6 -13
  18. data/test/controllers/insights_cloud/api/advisor_engine_controller_test.rb +4 -15
  19. data/test/controllers/insights_cloud/ui_requests_controller_test.rb +217 -5
  20. data/test/jobs/generate_host_report_test.rb +1 -1
  21. data/test/jobs/host_inventory_report_job_test.rb +72 -0
  22. data/test/jobs/queue_for_upload_job_test.rb +4 -1
  23. data/test/jobs/upload_report_direct_job_test.rb +28 -7
  24. data/test/unit/archived_report_generator_test.rb +21 -0
  25. data/test/unit/foreman_inventory_upload_host_report_path_test.rb +111 -0
  26. data/test/unit/rh_cloud_permissions_test.rb +0 -2
  27. data/test/unit/services/foreman_rh_cloud/insights_api_forwarder_test.rb +189 -356
  28. data/test/unit/slice_generator_test.rb +28 -0
  29. data/webpack/ForemanInventoryUpload/Components/Dashboard/Dashboard.js +1 -0
  30. data/webpack/ForemanInventoryUpload/Components/TaskProgress/TaskProgress.js +8 -2
  31. data/webpack/ForemanInventoryUpload/SubscriptionsPageExtension/InventoryAutoUpload/InventoryAutoUpload.js +3 -1
  32. data/webpack/ForemanInventoryUpload/SubscriptionsPageExtension/InventoryAutoUpload/__tests__/InventoryAutoUpload.test.js +23 -0
  33. data/webpack/HostsIndexExtensions/VulnerabilityAnalysisActions.js +1 -1
  34. data/webpack/test_setup.js +18 -0
  35. metadata +3 -6
  36. data/app/controllers/foreman_inventory_upload/api/tasks_controller.rb +0 -110
  37. data/app/services/foreman_rh_cloud/hits_uploader.rb +0 -50
  38. data/lib/tasks/hybrid_cloud.rake +0 -132
  39. data/test/unit/services/foreman_rh_cloud/hits_uploader_test.rb +0 -131
@@ -37,10 +37,10 @@ class UIRequestForwarderTest < ActiveSupport::TestCase
37
37
  true
38
38
  end
39
39
 
40
- @forwarder.forward_request(req, '/api/vulnerability/v1/cves/abc-123/affected_systems', 'test_controller', @user, @organization, @location)
40
+ @forwarder.forward_request(req, 'api/vulnerability/v1/cves/abc-123/affected_systems', 'test_controller', @user, @organization, @location)
41
41
  end
42
42
 
43
- test 'should not scope GET requests for unknown uris' do
43
+ test 'should reject GET requests for unknown uris' do
44
44
  user_agent = { :foo => :bar }
45
45
  params = {}
46
46
 
@@ -52,14 +52,10 @@ class UIRequestForwarderTest < ActiveSupport::TestCase
52
52
  'action_dispatch.request.query_parameters' => params
53
53
  )
54
54
 
55
- ::ForemanRhCloud::TagsAuth.any_instance.expects(:update_tag).never
56
- @forwarder.expects(:execute_cloud_request).with do |actual_params|
57
- actual = actual_params[:headers][:params]
58
- assert_equal 0, actual.count
59
- true
55
+ # Unmapped paths should raise UnsupportedOperationError (returns 404)
56
+ assert_raises(::ForemanRhCloud::InsightsApiForwarder::UnsupportedOperationError) do
57
+ @forwarder.forward_request(req, 'api/vulnerability/foo/bar', 'test_controller', @user, @organization, @location)
60
58
  end
61
-
62
- @forwarder.forward_request(req, '/api/vulnerability/foo/bar', 'test_controller', @user, @organization, @location)
63
59
  end
64
60
 
65
61
  test 'should merge URI params in GET requests' do
@@ -84,29 +80,48 @@ class UIRequestForwarderTest < ActiveSupport::TestCase
84
80
  true
85
81
  end
86
82
 
87
- @forwarder.forward_request(req, '/api/vulnerability/v1/cves/abc-123/affected_systems', 'test_controller', @user, @organization, @location)
83
+ @forwarder.forward_request(req, 'api/vulnerability/v1/cves/abc-123/affected_systems', 'test_controller', @user, @organization, @location)
88
84
  end
89
85
 
90
- test 'should not scope POST requests' do
91
- post_data = 'Random POST data'
86
+ test 'should not forward organization_id or location_id query params' do
87
+ params = { 'organization_id' => @organization.id.to_s, 'location_id' => @location.id.to_s, :page => 5 }
88
+
92
89
  req = ActionDispatch::Request.new(
93
- 'REQUEST_URI' => '/foo/bar',
94
- 'REQUEST_METHOD' => 'POST',
90
+ 'REQUEST_URI' => '/api/insights/v1/stats/systems',
91
+ 'REQUEST_METHOD' => 'GET',
95
92
  'rack.input' => ::Puma::NullIO.new,
96
- 'RAW_POST_DATA' => post_data
93
+ 'action_dispatch.request.query_parameters' => params
97
94
  )
98
95
 
99
- ::ForemanRhCloud::TagsAuth.any_instance.expects(:update_tag).never
96
+ @user.stubs(:can?).with(:view_advisor).returns(true)
97
+ ::ForemanRhCloud::TagsAuth.any_instance.expects(:update_tag)
100
98
  @forwarder.expects(:execute_cloud_request).with do |actual_params|
101
99
  actual = actual_params[:headers][:params]
102
- assert_equal 0, actual.count
100
+ assert_nil(actual.find { |param| param[0].to_s == 'organization_id' })
101
+ assert_nil(actual.find { |param| param[0].to_s == 'location_id' })
102
+ assert_equal 5, actual.find { |param| param[0] == :page }[1]
103
103
  true
104
104
  end
105
105
 
106
- @forwarder.forward_request(req, '/api/vulnerability/v1/cves', 'test_controller', @user, @organization, @location)
106
+ @forwarder.forward_request(req, 'api/insights/v1/stats/systems', 'test_controller', @user, @organization, @location)
107
+ end
108
+
109
+ test 'should reject unmapped POST requests' do
110
+ post_data = 'Random POST data'
111
+ req = ActionDispatch::Request.new(
112
+ 'REQUEST_URI' => '/foo/bar',
113
+ 'REQUEST_METHOD' => 'POST',
114
+ 'rack.input' => ::Puma::NullIO.new,
115
+ 'RAW_POST_DATA' => post_data
116
+ )
117
+
118
+ # Unmapped POST paths should raise UnsupportedOperationError (returns 404)
119
+ assert_raises(::ForemanRhCloud::InsightsApiForwarder::UnsupportedOperationError) do
120
+ @forwarder.forward_request(req, 'foo/bar', 'test_controller', @user, @organization, @location)
121
+ end
107
122
  end
108
123
 
109
- test 'should not scope PUT requests' do
124
+ test 'should reject unmapped PUT requests' do
110
125
  put_data = 'Random PUT data'
111
126
  req = ActionDispatch::Request.new(
112
127
  'REQUEST_URI' => '/foo/bar',
@@ -115,17 +130,13 @@ class UIRequestForwarderTest < ActiveSupport::TestCase
115
130
  'RAW_POST_DATA' => put_data
116
131
  )
117
132
 
118
- ::ForemanRhCloud::TagsAuth.any_instance.expects(:update_tag).never
119
- @forwarder.expects(:execute_cloud_request).with do |actual_params|
120
- actual = actual_params[:headers][:params]
121
- assert_equal 0, actual.count
122
- true
133
+ # Unmapped PUT paths should raise UnsupportedOperationError (returns 404)
134
+ assert_raises(::ForemanRhCloud::InsightsApiForwarder::UnsupportedOperationError) do
135
+ @forwarder.forward_request(req, 'foo/bar', 'test_controller', @user, @organization, @location)
123
136
  end
124
-
125
- @forwarder.forward_request(req, '/api/vulnerability/v1/cves', 'test_controller', @user, @organization, @location)
126
137
  end
127
138
 
128
- test 'should not scope PATCH requests' do
139
+ test 'should reject unmapped PATCH requests' do
129
140
  post_data = 'Random PATCH data'
130
141
  req = ActionDispatch::Request.new(
131
142
  'REQUEST_URI' => '/foo/bar',
@@ -135,24 +146,20 @@ class UIRequestForwarderTest < ActiveSupport::TestCase
135
146
  "action_dispatch.request.path_parameters" => { :format => "json" }
136
147
  )
137
148
 
138
- ::ForemanRhCloud::TagsAuth.any_instance.expects(:update_tag).never
139
- @forwarder.expects(:execute_cloud_request).with do |actual_params|
140
- actual = actual_params[:headers][:params]
141
- assert_equal 0, actual.count
142
- true
149
+ # Unmapped PATCH paths should raise UnsupportedOperationError (returns 404)
150
+ assert_raises(::ForemanRhCloud::InsightsApiForwarder::UnsupportedOperationError) do
151
+ @forwarder.forward_request(req, 'foo/bar', 'test_controller', @user, @organization, @location)
143
152
  end
144
-
145
- @forwarder.forward_request(req, '/api/vulnerability/v1/cves', 'test_controller', @user, @organization, @location)
146
153
  end
147
154
 
148
155
  test 'scope_request? should return tag_name for scoped requests' do
149
156
  get_req = ActionDispatch::Request.new(
150
- 'REQUEST_URI' => '/api/vulnerability/v1/vulnerabilities/cves',
157
+ 'REQUEST_URI' => '/api/vulnerability/v1/cves/CVE-2024-1234/affected_systems',
151
158
  'REQUEST_METHOD' => 'GET',
152
159
  'rack.input' => ::Puma::NullIO.new
153
160
  )
154
161
 
155
- result = @forwarder.send(:scope_request?, get_req, 'api/vulnerability/v1/vulnerabilities/cves')
162
+ result = @forwarder.send(:scope_request?, get_req, 'api/vulnerability/v1/cves/CVE-2024-1234/affected_systems')
156
163
  assert_equal :tags, result
157
164
  end
158
165
 
@@ -163,7 +170,7 @@ class UIRequestForwarderTest < ActiveSupport::TestCase
163
170
  'rack.input' => ::Puma::NullIO.new
164
171
  )
165
172
 
166
- result = @forwarder.send(:scope_request?, post_req, '/api/vulnerability/v1/cves')
173
+ result = @forwarder.send(:scope_request?, post_req, 'api/vulnerability/v1/cves')
167
174
  assert_nil result
168
175
  end
169
176
 
@@ -174,7 +181,7 @@ class UIRequestForwarderTest < ActiveSupport::TestCase
174
181
  'rack.input' => ::Puma::NullIO.new
175
182
  )
176
183
 
177
- result = @forwarder.send(:scope_request?, get_req, '/api/unmatched/path')
184
+ result = @forwarder.send(:scope_request?, get_req, 'api/unmatched/path')
178
185
  assert_nil result
179
186
  end
180
187
 
@@ -255,6 +262,29 @@ class UIRequestForwarderTest < ActiveSupport::TestCase
255
262
  assert_equal :tags, result
256
263
  end
257
264
 
265
+ test 'trailing slash on tagged endpoint should still resolve to tagged pattern' do
266
+ get_req = ActionDispatch::Request.new(
267
+ 'REQUEST_URI' => '/api/compliance/v2/systems/',
268
+ 'REQUEST_METHOD' => 'GET',
269
+ 'rack.input' => ::Puma::NullIO.new
270
+ )
271
+
272
+ # Must resolve to the tagged systems pattern, not the untagged catch-all
273
+ result = @forwarder.send(:scope_request?, get_req, 'api/compliance/v2/systems/')
274
+ assert_equal :tags, result
275
+ end
276
+
277
+ test 'trailing slash on vulnerability endpoint should still resolve to tagged pattern' do
278
+ get_req = ActionDispatch::Request.new(
279
+ 'REQUEST_URI' => '/api/vulnerability/v1/cves/CVE-2024-1234/affected_systems/',
280
+ 'REQUEST_METHOD' => 'GET',
281
+ 'rack.input' => ::Puma::NullIO.new
282
+ )
283
+
284
+ result = @forwarder.send(:scope_request?, get_req, 'api/vulnerability/v1/cves/CVE-2024-1234/affected_systems/')
285
+ assert_equal :tags, result
286
+ end
287
+
258
288
  test 'prepare_tags should use provided tag_name' do
259
289
  result = @forwarder.send(:prepare_tags, @user, @organization, @location, :custom_tag)
260
290
 
@@ -290,21 +320,11 @@ class UIRequestForwarderTest < ActiveSupport::TestCase
290
320
  ActionDispatch::Request.new(env)
291
321
  end
292
322
 
293
- # Permission enforcement tests
294
-
295
- # GET /api/inventory/v1/hosts is a shared dependency - view_compliance OR view_vulnerability grants access
323
+ # Inventory hosts OR-logic: any single permission is sufficient
296
324
  test 'should allow GET request to inventory hosts when user has view_vulnerability permission' do
297
- user_agent = { :foo => :bar }
298
- params = {}
299
-
300
- req = ActionDispatch::Request.new(
301
- 'REQUEST_URI' => '/api/inventory/v1/hosts',
302
- 'REQUEST_METHOD' => 'GET',
303
- 'HTTP_USER_AGENT' => user_agent,
304
- 'rack.input' => ::Puma::NullIO.new,
305
- 'action_dispatch.request.query_parameters' => params
306
- )
325
+ req = build_request(method: 'GET', uri: '/api/inventory/v1/hosts')
307
326
 
327
+ @user.stubs(:can?).with(:view_advisor).returns(false)
308
328
  @user.stubs(:can?).with(:view_compliance).returns(false)
309
329
  @user.stubs(:can?).with(:view_vulnerability).returns(true)
310
330
  ::ForemanRhCloud::TagsAuth.any_instance.expects(:update_tag)
@@ -316,6 +336,7 @@ class UIRequestForwarderTest < ActiveSupport::TestCase
316
336
  test 'should allow GET request to inventory hosts when user has view_compliance permission' do
317
337
  req = build_request(method: 'GET', uri: '/api/inventory/v1/hosts')
318
338
 
339
+ @user.stubs(:can?).with(:view_advisor).returns(false)
319
340
  @user.stubs(:can?).with(:view_compliance).returns(true)
320
341
  @user.stubs(:can?).with(:view_vulnerability).returns(false)
321
342
  ::ForemanRhCloud::TagsAuth.any_instance.expects(:update_tag)
@@ -324,18 +345,10 @@ class UIRequestForwarderTest < ActiveSupport::TestCase
324
345
  @forwarder.forward_request(req, 'api/inventory/v1/hosts', 'test_controller', @user, @organization, @location)
325
346
  end
326
347
 
327
- test 'should deny GET request to inventory hosts when user lacks both view_compliance and view_vulnerability' do
328
- user_agent = { :foo => :bar }
329
- params = {}
330
-
331
- req = ActionDispatch::Request.new(
332
- 'REQUEST_URI' => '/api/inventory/v1/hosts',
333
- 'REQUEST_METHOD' => 'GET',
334
- 'HTTP_USER_AGENT' => user_agent,
335
- 'rack.input' => ::Puma::NullIO.new,
336
- 'action_dispatch.request.query_parameters' => params
337
- )
348
+ test 'should deny GET request to inventory hosts when user lacks all permissions' do
349
+ req = build_request(method: 'GET', uri: '/api/inventory/v1/hosts')
338
350
 
351
+ @user.stubs(:can?).with(:view_advisor).returns(false)
339
352
  @user.stubs(:can?).with(:view_compliance).returns(false)
340
353
  @user.stubs(:can?).with(:view_vulnerability).returns(false)
341
354
 
@@ -344,311 +357,131 @@ class UIRequestForwarderTest < ActiveSupport::TestCase
344
357
  end
345
358
  end
346
359
 
347
- # POST /api/vulnerability/v1/vulnerabilities/cves requires view_vulnerability
348
- test 'should deny POST request to vulnerabilities cves when user lacks view_vulnerability permission' do
349
- post_data = '{"test": "data"}'
350
- req = ActionDispatch::Request.new(
351
- 'REQUEST_URI' => '/api/vulnerability/v1/vulnerabilities/cves',
352
- 'REQUEST_METHOD' => 'POST',
353
- 'rack.input' => ::Puma::NullIO.new,
354
- 'RAW_POST_DATA' => post_data
355
- )
356
-
357
- @user.stubs(:can?).with(:view_vulnerability).returns(false)
360
+ # Edge case: anonymous user
361
+ test 'should deny request when user is nil' do
362
+ req = build_request(method: 'GET', uri: '/api/insights/v1/stats/systems')
358
363
 
359
364
  assert_raises(::Foreman::PermissionMissingException) do
360
- @forwarder.forward_request(req, 'api/vulnerability/v1/vulnerabilities/cves', 'test_controller', @user, @organization, @location)
365
+ @forwarder.forward_request(req, 'api/insights/v1/stats/systems', 'test_controller', nil, @organization, @location)
361
366
  end
362
367
  end
363
368
 
364
- # PATCH /api/vulnerability/v1/status requires edit_vulnerability
365
- test 'should allow PATCH request to vulnerability status when user has edit_vulnerability permission' do
366
- patch_data = '{"status": "resolved"}'
367
- req = ActionDispatch::Request.new(
368
- 'REQUEST_URI' => '/api/vulnerability/v1/status',
369
- 'REQUEST_METHOD' => 'PATCH',
370
- 'rack.input' => ::Puma::NullIO.new,
371
- 'RAW_POST_DATA' => patch_data,
372
- "action_dispatch.request.path_parameters" => { :format => "json" }
373
- )
374
-
375
- @user.stubs(:can?).with(:edit_vulnerability).returns(true)
376
- @forwarder.expects(:execute_cloud_request).returns(true)
369
+ # Comprehensive permission matrix tests
370
+ #
371
+ # For each path, every HTTP method is tested via forward_request:
372
+ # - Mapped operations (method listed in permissions) → user lacking permission gets PermissionMissingException
373
+ # - Unmapped operations (method not listed) → rejected with UnsupportedOperationError, execute_cloud_request never called
374
+ #
375
+ # Allow behavior (user WITH permission) is tested by the happy-path tests above.
377
376
 
378
- @forwarder.forward_request(req, 'api/vulnerability/v1/status', 'test_controller', @user, @organization, @location)
379
- end
377
+ HTTP_METHODS = %w[GET HEAD POST PUT PATCH DELETE OPTIONS].freeze
380
378
 
381
- test 'should deny PATCH request to vulnerability status when user lacks edit_vulnerability permission' do
382
- patch_data = '{"status": "resolved"}'
383
- req = ActionDispatch::Request.new(
384
- 'REQUEST_URI' => '/api/vulnerability/v1/status',
385
- 'REQUEST_METHOD' => 'PATCH',
386
- 'rack.input' => ::Puma::NullIO.new,
387
- 'RAW_POST_DATA' => patch_data,
388
- "action_dispatch.request.path_parameters" => { :format => "json" }
389
- )
390
-
391
- @user.stubs(:can?).with(:edit_vulnerability).returns(false)
392
-
393
- assert_raises(::Foreman::PermissionMissingException) do
394
- @forwarder.forward_request(req, 'api/vulnerability/v1/status', 'test_controller', @user, @organization, @location)
395
- end
396
- end
397
-
398
- # Data-driven tests for required_permission_for
399
379
  PERMISSION_MAPPINGS = [
400
- # Shared inventory hosts endpoint - either view_compliance or view_vulnerability grants GET access
401
- { path: 'api/inventory/v1/hosts', method: 'GET', expected: [:view_compliance, :view_vulnerability] },
402
- { path: 'api/inventory/v1/hosts/abc-123', method: 'GET', expected: [:view_compliance, :view_vulnerability] },
403
- # Compliance endpoints
404
- { path: 'api/compliance/v2/policies', method: 'GET', expected: :view_compliance },
405
- { path: 'api/compliance/v2/policies', method: 'POST', expected: :edit_compliance },
406
- { path: 'api/compliance/v2/policies/policy-123', method: 'GET', expected: :view_compliance },
407
- { path: 'api/compliance/v2/policies/policy-123', method: 'DELETE', expected: :edit_compliance },
408
- { path: 'api/compliance/v2/policies/policy-123', method: 'PATCH', expected: :edit_compliance },
409
- { path: 'api/compliance/v2/policies/policy-123/systems', method: 'GET', expected: :view_compliance },
410
- { path: 'api/compliance/v2/policies/policy-123/systems', method: 'POST', expected: :edit_compliance },
411
- { path: 'api/compliance/v2/policies/policy-123/systems/system-456', method: 'GET', expected: :view_compliance },
412
- { path: 'api/compliance/v2/policies/policy-123/systems/system-456', method: 'DELETE', expected: :edit_compliance },
413
- { path: 'api/compliance/v2/policies/policy-123/systems/system-456', method: 'PATCH', expected: :edit_compliance },
414
- { path: 'api/compliance/v2/policies/policy-123/tailorings', method: 'GET', expected: :view_compliance },
415
- { path: 'api/compliance/v2/policies/policy-123/tailorings', method: 'POST', expected: :edit_compliance },
416
- { path: 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789', method: 'GET', expected: :view_compliance },
417
- { path: 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789', method: 'PATCH', expected: :edit_compliance },
418
- { path: 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules', method: 'GET', expected: :view_compliance },
419
- { path: 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules', method: 'POST', expected: :edit_compliance },
420
- { path: 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules/rule-999', method: 'GET', expected: :view_compliance },
421
- { path: 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules/rule-999', method: 'DELETE', expected: :edit_compliance },
422
- { path: 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules/rule-999', method: 'PATCH', expected: :edit_compliance },
423
- { path: 'api/compliance/v2/reports', method: 'GET', expected: :view_compliance },
424
- { path: 'api/compliance/v2/reports/report-123', method: 'GET', expected: :view_compliance },
425
- { path: 'api/compliance/v2/reports/report-123', method: 'DELETE', expected: :edit_compliance },
426
- { path: 'api/compliance/v2/reports/report-123/systems', method: 'GET', expected: :view_compliance },
427
- { path: 'api/compliance/v2/reports/report-123/systems/system-456', method: 'GET', expected: :view_compliance },
428
- { path: 'api/compliance/v2/reports/report-123/systems/os_versions', method: 'GET', expected: :view_compliance },
429
- { path: 'api/compliance/v2/policies/policy-123/systems/os_versions', method: 'GET', expected: :view_compliance },
430
- { path: 'api/compliance/v2/systems', method: 'GET', expected: :view_compliance },
431
- { path: 'api/compliance/v2/systems/system-456', method: 'GET', expected: :view_compliance },
432
- { path: 'api/compliance/v2/systems/os_versions', method: 'GET', expected: :view_compliance },
433
- { path: 'api/compliance/v2/systems/system-456/policies', method: 'GET', expected: :view_compliance },
434
- { path: 'api/compliance/v2/systems/system-456/reports', method: 'GET', expected: :view_compliance },
435
- { path: 'api/compliance/v2/profiles', method: 'GET', expected: :view_compliance },
436
- # Vulnerability endpoints
437
- { path: 'api/vulnerability/v1/vulnerabilities/cves', method: 'POST', expected: :view_vulnerability },
438
- { path: 'api/vulnerability/v1/status', method: 'PATCH', expected: :edit_vulnerability },
439
- { path: 'api/vulnerability/v1/cves/status', method: 'PATCH', expected: :edit_vulnerability },
440
- { path: 'api/vulnerability/v1/cves/business_risk', method: 'PATCH', expected: :edit_vulnerability },
441
- { path: 'api/vulnerability/v1/systems/opt_out', method: 'PATCH', expected: :edit_vulnerability },
442
- { path: 'api/vulnerability/v1/dashbar', method: 'GET', expected: :view_vulnerability },
443
- { path: 'api/vulnerability/v1/cves/CVE-2024-1234/affected_systems', method: 'GET', expected: :view_vulnerability },
444
- # Endpoints without tags support (still require view_vulnerability)
445
- { path: 'api/vulnerability/v1/apistatus', method: 'GET', expected: :view_vulnerability },
446
- { path: 'api/vulnerability/v1/version', method: 'GET', expected: :view_vulnerability },
447
- { path: 'api/vulnerability/v1/business_risk', method: 'GET', expected: :view_vulnerability },
448
- { path: 'api/vulnerability/v1/announcement', method: 'GET', expected: :view_vulnerability },
449
- { path: 'api/vulnerability/v1/cves/CVE-2024-1234', method: 'GET', expected: :view_vulnerability },
450
- { path: 'api/vulnerability/v1/playbooks/abc-123', method: 'GET', expected: :view_vulnerability },
451
- { path: 'api/vulnerability/v1/report/abc-123', method: 'GET', expected: :view_vulnerability },
452
- { path: 'api/vulnerability/v1/feature/cves_without_errata', method: 'GET', expected: :view_vulnerability },
453
- { path: 'api/vulnerability/v1/feature/cves_without_errata', method: 'PATCH', expected: :edit_vulnerability },
454
- # Advisor endpoints
455
- { path: 'api/insights/v1/stats/systems', method: 'GET', expected: :view_advisor },
456
- { path: 'api/insights/v1/ack/', method: 'POST', expected: :edit_advisor },
457
- { path: 'api/insights/v1/ack/rule_id', method: 'DELETE', expected: :edit_advisor },
458
- { path: 'api/insights/v1/hostack/', method: 'POST', expected: :edit_advisor },
459
- { path: 'api/insights/v1/hostack/123', method: 'DELETE', expected: :edit_advisor },
460
- { path: 'api/insights/v1/rule/test_rule/unack_hosts', method: 'POST', expected: :edit_advisor },
461
- # Unknown endpoints
462
- { path: 'api/unknown/endpoint', method: 'GET', expected: nil },
380
+ # Inventory hosts - shared dependency (any one of three permissions grants GET access)
381
+ { path: 'api/inventory/v1/hosts', permissions: { 'GET' => [:view_advisor, :view_compliance, :view_vulnerability] } },
382
+ { path: 'api/inventory/v1/hosts/abc-123', permissions: { 'GET' => [:view_advisor, :view_compliance, :view_vulnerability] } },
383
+ # Compliance - policies (pattern policies(/[^/]*)?$ matches both list and individual with same permissions)
384
+ { path: 'api/compliance/v2/policies', permissions: { 'GET' => :view_compliance, 'POST' => :edit_compliance, 'DELETE' => :edit_compliance, 'PATCH' => :edit_compliance } },
385
+ { path: 'api/compliance/v2/policies/policy-123', permissions: { 'GET' => :view_compliance, 'POST' => :edit_compliance, 'DELETE' => :edit_compliance, 'PATCH' => :edit_compliance } },
386
+ # Compliance - policy systems (pattern systems(/[^/]*)?$ matches both list and individual)
387
+ { path: 'api/compliance/v2/policies/policy-123/systems', permissions: { 'GET' => :view_compliance, 'POST' => :edit_compliance, 'DELETE' => :edit_compliance, 'PATCH' => :edit_compliance } },
388
+ { path: 'api/compliance/v2/policies/policy-123/systems/system-456', permissions: { 'GET' => :view_compliance, 'POST' => :edit_compliance, 'DELETE' => :edit_compliance, 'PATCH' => :edit_compliance } },
389
+ # Compliance - tailorings (pattern tailorings(/[^/]*)?$ matches both list and individual)
390
+ { path: 'api/compliance/v2/policies/policy-123/tailorings', permissions: { 'GET' => :view_compliance, 'POST' => :edit_compliance, 'PATCH' => :edit_compliance } },
391
+ { path: 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789', permissions: { 'GET' => :view_compliance, 'POST' => :edit_compliance, 'PATCH' => :edit_compliance } },
392
+ # Compliance - tailoring rules (pattern rules(/[^/]*)?$ matches both list and individual)
393
+ { path: 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules', permissions: { 'GET' => :view_compliance, 'POST' => :edit_compliance, 'DELETE' => :edit_compliance, 'PATCH' => :edit_compliance } },
394
+ { path: 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules/rule-999', permissions: { 'GET' => :view_compliance, 'POST' => :edit_compliance, 'DELETE' => :edit_compliance, 'PATCH' => :edit_compliance } },
395
+ # Compliance - reports (pattern reports(/[^/]*)?$ matches both list and individual)
396
+ { path: 'api/compliance/v2/reports', permissions: { 'GET' => :view_compliance, 'DELETE' => :edit_compliance } },
397
+ { path: 'api/compliance/v2/reports/report-123', permissions: { 'GET' => :view_compliance, 'DELETE' => :edit_compliance } },
398
+ { path: 'api/compliance/v2/reports/report-123/systems', permissions: { 'GET' => :view_compliance } },
399
+ { path: 'api/compliance/v2/reports/report-123/systems/system-456', permissions: { 'GET' => :view_compliance } },
400
+ { path: 'api/compliance/v2/reports/report-123/systems/os_versions', permissions: { 'GET' => :view_compliance } },
401
+ # Compliance - test results
402
+ { path: 'api/compliance/v2/reports/report-123/test_results', permissions: { 'GET' => :view_compliance } },
403
+ { path: 'api/compliance/v2/reports/report-123/test_results/result-456', permissions: { 'GET' => :view_compliance } },
404
+ # Compliance - policy system os_versions
405
+ { path: 'api/compliance/v2/policies/policy-123/systems/os_versions', permissions: { 'GET' => :view_compliance } },
406
+ # Compliance - systems
407
+ { path: 'api/compliance/v2/systems', permissions: { 'GET' => :view_compliance } },
408
+ { path: 'api/compliance/v2/systems/system-456', permissions: { 'GET' => :view_compliance } },
409
+ { path: 'api/compliance/v2/systems/os_versions', permissions: { 'GET' => :view_compliance } },
410
+ { path: 'api/compliance/v2/systems/system-456/policies', permissions: { 'GET' => :view_compliance } },
411
+ { path: 'api/compliance/v2/systems/system-456/reports', permissions: { 'GET' => :view_compliance } },
412
+ # Compliance - catch-all
413
+ { path: 'api/compliance/v2/profiles', permissions: { 'GET' => :view_compliance } },
414
+ # Vulnerability - CVEs list and IDs (GET/POST)
415
+ { path: 'api/vulnerability/v1/vulnerabilities/cves', permissions: { 'GET' => :view_vulnerability, 'POST' => :view_vulnerability } },
416
+ { path: 'api/vulnerability/v1/vulnerabilities/cves/ids', permissions: { 'GET' => :view_vulnerability, 'POST' => :view_vulnerability } },
417
+ # Vulnerability - status (GET/PATCH)
418
+ { path: 'api/vulnerability/v1/status', permissions: { 'GET' => :view_vulnerability, 'PATCH' => :edit_vulnerability } },
419
+ { path: 'api/vulnerability/v1/cves/status', permissions: { 'PATCH' => :edit_vulnerability } },
420
+ { path: 'api/vulnerability/v1/cves/business_risk', permissions: { 'PATCH' => :edit_vulnerability } },
421
+ { path: 'api/vulnerability/v1/systems/opt_out', permissions: { 'PATCH' => :edit_vulnerability } },
422
+ # Vulnerability - endpoints without tags support (GET only)
423
+ { path: 'api/vulnerability/v1/apistatus', permissions: { 'GET' => :view_vulnerability } },
424
+ { path: 'api/vulnerability/v1/version', permissions: { 'GET' => :view_vulnerability } },
425
+ { path: 'api/vulnerability/v1/business_risk', permissions: { 'GET' => :view_vulnerability } },
426
+ { path: 'api/vulnerability/v1/announcement', permissions: { 'GET' => :view_vulnerability } },
427
+ { path: 'api/vulnerability/v1/cves/CVE-2024-1234', permissions: { 'GET' => :view_vulnerability } },
428
+ { path: 'api/vulnerability/v1/playbooks/abc-123', permissions: { 'GET' => :view_vulnerability } },
429
+ { path: 'api/vulnerability/v1/report/abc-123', permissions: { 'GET' => :view_vulnerability } },
430
+ # Vulnerability - cves_without_errata (GET + PATCH)
431
+ { path: 'api/vulnerability/v1/feature/cves_without_errata', permissions: { 'GET' => :view_vulnerability, 'PATCH' => :edit_vulnerability } },
432
+ # Vulnerability - catch-all (GET with tags)
433
+ { path: 'api/vulnerability/v1/dashbar', permissions: { 'GET' => :view_vulnerability } },
434
+ { path: 'api/vulnerability/v1/cves/CVE-2024-1234/affected_systems', permissions: { 'GET' => :view_vulnerability } },
435
+ # Advisor - ack (GET/POST/PUT/DELETE, with trailing slash variants)
436
+ { path: 'api/insights/v1/ack/', permissions: { 'GET' => :view_advisor, 'POST' => :edit_advisor, 'PUT' => :edit_advisor, 'DELETE' => :edit_advisor } },
437
+ { path: 'api/insights/v1/ack/rule_id', permissions: { 'GET' => :view_advisor, 'POST' => :edit_advisor, 'PUT' => :edit_advisor, 'DELETE' => :edit_advisor } },
438
+ { path: 'api/insights/v1/ack/rule_id/', permissions: { 'GET' => :view_advisor, 'POST' => :edit_advisor, 'PUT' => :edit_advisor, 'DELETE' => :edit_advisor } },
439
+ # Advisor - hostack (GET/POST/PUT/DELETE, with trailing slash variants)
440
+ { path: 'api/insights/v1/hostack/', permissions: { 'GET' => :view_advisor, 'POST' => :edit_advisor, 'PUT' => :edit_advisor, 'DELETE' => :edit_advisor } },
441
+ { path: 'api/insights/v1/hostack/123', permissions: { 'GET' => :view_advisor, 'POST' => :edit_advisor, 'PUT' => :edit_advisor, 'DELETE' => :edit_advisor } },
442
+ { path: 'api/insights/v1/hostack/123/', permissions: { 'GET' => :view_advisor, 'POST' => :edit_advisor, 'PUT' => :edit_advisor, 'DELETE' => :edit_advisor } },
443
+ # Advisor - ack_hosts (POST)
444
+ { path: 'api/insights/v1/rule/test_rule/ack_hosts', permissions: { 'POST' => :edit_advisor } },
445
+ # Advisor - unack_hosts (POST)
446
+ { path: 'api/insights/v1/rule/test_rule/unack_hosts', permissions: { 'POST' => :edit_advisor } },
447
+ # Advisor - catch-all (GET)
448
+ { path: 'api/insights/v1/stats/systems', permissions: { 'GET' => :view_advisor } },
449
+ # Unmapped paths (no pattern matches at all)
450
+ { path: 'api/unknown/endpoint', permissions: {} },
451
+ { path: 'api/inventory/v1/system_profile/operating_system', permissions: {} },
452
+ { path: 'api/tasks/v1/some_task', permissions: {} },
453
+ # Boundary: suffixed paths must not match anchored patterns (but still match the catch-all)
454
+ { path: 'api/vulnerability/v1/status_extra', permissions: { 'GET' => :view_vulnerability } },
455
+ { path: 'api/vulnerability/v1/cves/business_risk_foo', permissions: { 'GET' => :view_vulnerability } },
456
+ # Boundary: prefixed paths must not match any pattern due to \A anchoring
457
+ { path: 'evil/api/vulnerability/v1/cves', permissions: {} },
458
+ { path: 'evil/api/insights/v1/stats/systems', permissions: {} },
459
+ { path: '/api/vulnerability/v1/cves', permissions: {} },
463
460
  ].freeze
464
461
 
465
462
  PERMISSION_MAPPINGS.each do |mapping|
466
- test "required_permission_for returns #{mapping[:expected].inspect} for #{mapping[:method]} #{mapping[:path]}" do
467
- permission = @forwarder.send(:required_permission_for, mapping[:path], mapping[:method])
468
- assert_equal mapping[:expected], permission
469
- end
470
- end
471
-
472
- # Advisor permission integration tests
473
- test 'should allow GET request to insights endpoint when user has view_advisor permission' do
474
- req = build_request(method: 'GET', uri: '/api/insights/v1/stats/systems')
475
-
476
- @user.stubs(:can?).with(:view_advisor).returns(true)
477
- ::ForemanRhCloud::TagsAuth.any_instance.expects(:update_tag)
478
- @forwarder.expects(:execute_cloud_request).returns(true)
479
-
480
- @forwarder.forward_request(req, 'api/insights/v1/stats/systems', 'test_controller', @user, @organization, @location)
481
- end
482
-
483
- test 'should deny GET request to insights endpoint when user lacks view_advisor permission' do
484
- req = build_request(method: 'GET', uri: '/api/insights/v1/stats/systems')
485
-
486
- @user.stubs(:can?).with(:view_advisor).returns(false)
487
-
488
- assert_raises(::Foreman::PermissionMissingException) do
489
- @forwarder.forward_request(req, 'api/insights/v1/stats/systems', 'test_controller', @user, @organization, @location)
490
- end
491
- end
492
-
493
- test 'should allow POST request to insights ack when user has edit_advisor permission' do
494
- req = build_request(method: 'POST', uri: '/api/insights/v1/ack/', data: '{"rule_id": "test|RULE"}')
495
-
496
- @user.stubs(:can?).with(:edit_advisor).returns(true)
497
- @forwarder.expects(:execute_cloud_request).returns(true)
498
-
499
- @forwarder.forward_request(req, 'api/insights/v1/ack/', 'test_controller', @user, @organization, @location)
500
- end
501
-
502
- test 'should deny POST request to insights ack when user lacks edit_advisor permission' do
503
- req = build_request(method: 'POST', uri: '/api/insights/v1/ack/', data: '{"rule_id": "test|RULE"}')
504
-
505
- @user.stubs(:can?).with(:edit_advisor).returns(false)
506
-
507
- assert_raises(::Foreman::PermissionMissingException) do
508
- @forwarder.forward_request(req, 'api/insights/v1/ack/', 'test_controller', @user, @organization, @location)
509
- end
510
- end
511
-
512
- # Compliance permission integration tests
513
- test 'should allow GET request to compliance policies when user has view_compliance permission' do
514
- req = build_request(method: 'GET', uri: '/api/compliance/v2/policies')
515
-
516
- @user.stubs(:can?).with(:view_compliance).returns(true)
517
- @forwarder.expects(:execute_cloud_request).returns(true)
518
-
519
- @forwarder.forward_request(req, 'api/compliance/v2/policies', 'test_controller', @user, @organization, @location)
520
- end
521
-
522
- test 'should deny GET request to compliance policies when user lacks view_compliance permission' do
523
- req = build_request(method: 'GET', uri: '/api/compliance/v2/policies')
524
-
525
- @user.stubs(:can?).with(:view_compliance).returns(false)
526
-
527
- assert_raises(::Foreman::PermissionMissingException) do
528
- @forwarder.forward_request(req, 'api/compliance/v2/policies', 'test_controller', @user, @organization, @location)
529
- end
530
- end
531
-
532
- test 'should allow POST request to compliance policies when user has edit_compliance permission' do
533
- req = build_request(method: 'POST', uri: '/api/compliance/v2/policies', data: '{"name": "test-policy"}')
534
-
535
- @user.stubs(:can?).with(:edit_compliance).returns(true)
536
- @forwarder.expects(:execute_cloud_request).returns(true)
537
-
538
- @forwarder.forward_request(req, 'api/compliance/v2/policies', 'test_controller', @user, @organization, @location)
539
- end
540
-
541
- test 'should deny POST request to compliance policies when user lacks edit_compliance permission' do
542
- req = build_request(method: 'POST', uri: '/api/compliance/v2/policies', data: '{"name": "test-policy"}')
543
-
544
- @user.stubs(:can?).with(:edit_compliance).returns(false)
545
-
546
- assert_raises(::Foreman::PermissionMissingException) do
547
- @forwarder.forward_request(req, 'api/compliance/v2/policies', 'test_controller', @user, @organization, @location)
548
- end
549
- end
550
-
551
- test 'should allow PATCH request to compliance policy when user has edit_compliance permission' do
552
- req = build_request(method: 'PATCH', uri: '/api/compliance/v2/policies/policy-123', data: '{"name": "updated-policy"}')
553
-
554
- @user.stubs(:can?).with(:edit_compliance).returns(true)
555
- @forwarder.expects(:execute_cloud_request).returns(true)
556
-
557
- @forwarder.forward_request(req, 'api/compliance/v2/policies/policy-123', 'test_controller', @user, @organization, @location)
558
- end
559
-
560
- test 'should deny PATCH request to compliance policy when user lacks edit_compliance permission' do
561
- req = build_request(method: 'PATCH', uri: '/api/compliance/v2/policies/policy-123', data: '{"name": "updated-policy"}')
562
-
563
- @user.stubs(:can?).with(:edit_compliance).returns(false)
564
-
565
- assert_raises(::Foreman::PermissionMissingException) do
566
- @forwarder.forward_request(req, 'api/compliance/v2/policies/policy-123', 'test_controller', @user, @organization, @location)
567
- end
568
- end
569
-
570
- test 'should allow DELETE request to compliance policy when user has edit_compliance permission' do
571
- req = build_request(method: 'DELETE', uri: '/api/compliance/v2/policies/policy-123')
572
-
573
- @user.stubs(:can?).with(:edit_compliance).returns(true)
574
- @forwarder.expects(:execute_cloud_request).returns(true)
575
-
576
- @forwarder.forward_request(req, 'api/compliance/v2/policies/policy-123', 'test_controller', @user, @organization, @location)
577
- end
578
-
579
- test 'should deny DELETE request to compliance policy when user lacks edit_compliance permission' do
580
- req = build_request(method: 'DELETE', uri: '/api/compliance/v2/policies/policy-123')
581
-
582
- @user.stubs(:can?).with(:edit_compliance).returns(false)
583
-
584
- assert_raises(::Foreman::PermissionMissingException) do
585
- @forwarder.forward_request(req, 'api/compliance/v2/policies/policy-123', 'test_controller', @user, @organization, @location)
586
- end
587
- end
588
-
589
- test 'should allow POST request to compliance policy systems when user has edit_compliance permission' do
590
- req = build_request(method: 'POST', uri: '/api/compliance/v2/policies/policy-123/systems', data: '{"id": "system-456"}')
591
-
592
- @user.stubs(:can?).with(:edit_compliance).returns(true)
593
- @forwarder.expects(:execute_cloud_request).returns(true)
594
-
595
- @forwarder.forward_request(req, 'api/compliance/v2/policies/policy-123/systems', 'test_controller', @user, @organization, @location)
596
- end
597
-
598
- test 'should deny POST request to compliance policy systems when user lacks edit_compliance permission' do
599
- req = build_request(method: 'POST', uri: '/api/compliance/v2/policies/policy-123/systems', data: '{"id": "system-456"}')
600
-
601
- @user.stubs(:can?).with(:edit_compliance).returns(false)
602
-
603
- assert_raises(::Foreman::PermissionMissingException) do
604
- @forwarder.forward_request(req, 'api/compliance/v2/policies/policy-123/systems', 'test_controller', @user, @organization, @location)
605
- end
606
- end
607
-
608
- test 'should allow DELETE request to compliance report when user has edit_compliance permission' do
609
- req = build_request(method: 'DELETE', uri: '/api/compliance/v2/reports/report-123')
610
-
611
- @user.stubs(:can?).with(:edit_compliance).returns(true)
612
- @forwarder.expects(:execute_cloud_request).returns(true)
613
-
614
- @forwarder.forward_request(req, 'api/compliance/v2/reports/report-123', 'test_controller', @user, @organization, @location)
615
- end
616
-
617
- test 'should deny DELETE request to compliance report when user lacks edit_compliance permission' do
618
- req = build_request(method: 'DELETE', uri: '/api/compliance/v2/reports/report-123')
619
-
620
- @user.stubs(:can?).with(:edit_compliance).returns(false)
621
-
622
- assert_raises(::Foreman::PermissionMissingException) do
623
- @forwarder.forward_request(req, 'api/compliance/v2/reports/report-123', 'test_controller', @user, @organization, @location)
624
- end
625
- end
626
-
627
- test 'should allow DELETE request to compliance tailoring rule when user has edit_compliance permission' do
628
- req = build_request(method: 'DELETE', uri: '/api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules/rule-999')
629
-
630
- @user.stubs(:can?).with(:edit_compliance).returns(true)
631
- @forwarder.expects(:execute_cloud_request).returns(true)
632
-
633
- @forwarder.forward_request(req, 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules/rule-999', 'test_controller', @user, @organization, @location)
634
- end
635
-
636
- test 'should deny DELETE request to compliance tailoring rule when user lacks edit_compliance permission' do
637
- req = build_request(method: 'DELETE', uri: '/api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules/rule-999')
638
-
639
- @user.stubs(:can?).with(:edit_compliance).returns(false)
640
-
641
- assert_raises(::Foreman::PermissionMissingException) do
642
- @forwarder.forward_request(req, 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules/rule-999', 'test_controller', @user, @organization, @location)
643
- end
644
- end
645
-
646
- # Edge case: anonymous user
647
- test 'should deny request when user is nil' do
648
- req = build_request(method: 'GET', uri: '/api/insights/v1/stats/systems')
649
-
650
- assert_raises(::Foreman::PermissionMissingException) do
651
- @forwarder.forward_request(req, 'api/insights/v1/stats/systems', 'test_controller', nil, @organization, @location)
463
+ HTTP_METHODS.each do |http_method|
464
+ expected_permission = mapping[:permissions][http_method]
465
+
466
+ if expected_permission
467
+ test "#{http_method} #{mapping[:path]} enforces #{Array(expected_permission).join(', ')}" do
468
+ req = build_request(method: http_method, uri: "/#{mapping[:path]}")
469
+ Array(expected_permission).each { |perm| @user.stubs(:can?).with(perm).returns(false) }
470
+
471
+ assert_raises(::Foreman::PermissionMissingException) do
472
+ @forwarder.forward_request(req, mapping[:path], 'test_controller', @user, @organization, @location)
473
+ end
474
+ end
475
+ else
476
+ test "#{http_method} #{mapping[:path]} is rejected as unmapped operation" do
477
+ req = build_request(method: http_method, uri: "/#{mapping[:path]}")
478
+ @forwarder.expects(:execute_cloud_request).never
479
+
480
+ assert_raises(::ForemanRhCloud::InsightsApiForwarder::UnsupportedOperationError) do
481
+ @forwarder.forward_request(req, mapping[:path], 'test_controller', @user, @organization, @location)
482
+ end
483
+ end
484
+ end
652
485
  end
653
486
  end
654
487
  end