foreman_rh_cloud 14.1.3 → 14.2.0

data/webpack/ForemanInventoryUpload/Components/PageHeader/PageTitle.js

@@ -18,9 +18,11 @@ import {
   getInventoryDocsUrl,
 } from '../../ForemanInventoryHelpers';
 import CloudPingModal from './components/CloudPingModal';
+import { useIopConfig } from '../../../common/Hooks/ConfigHooks';
 
 const PageTitle = () => {
   const [isDropdownOpen, setIsDropdownOpen] = useState(false);
+  const isIop = useIopConfig();
   const [showPingModal, setPingModal] = useState(false);
   const togglePingModal = () => setPingModal(v => !v);
   const dropdownItems = [
@@ -42,13 +44,17 @@ const PageTitle = () => {
     >
       {DOCS_BUTTON_TEXT}
     </DropdownItem>,
-    <DropdownItem
-      key="cloud-ping"
-      ouiaId="dropdownItem-cloud-ping"
-      onClick={togglePingModal}
-    >
-      {CLOUD_PING_TITLE}
-    </DropdownItem>,
+    ...(!isIop
+      ? [
+          <DropdownItem
+            key="cloud-ping"
+            ouiaId="dropdownItem-cloud-ping"
+            onClick={togglePingModal}
+          >
+            {CLOUD_PING_TITLE}
+          </DropdownItem>,
+        ]
+      : []),
   ];
   return (
     <Grid className="inventory-upload-header-title">

data/webpack/ForemanInventoryUpload/Components/PageHeader/__tests__/PageHeader.test.js

@@ -20,9 +20,6 @@ jest.mock('foremanReact/Root/Context/ForemanContext', () => ({
 
 // Mock child components to isolate PageHeader testing
 // This prevents child component complexity from affecting our tests
-jest.mock('../components/SettingsWarning', () => () => (
-  <div data-testid="settings-warning">SettingsWarning</div>
-));
 jest.mock('../PageTitle', () => () => (
   <div data-testid="page-title">PageTitle</div>
 ));
@@ -59,7 +56,6 @@ describe('PageHeader', () => {
       });
 
       // All components should be present when not in IoP mode
-      expect(screen.getByTestId('settings-warning')).toBeTruthy();
       expect(screen.getByTestId('page-title')).toBeTruthy();
       expect(screen.getByTestId('inventory-settings')).toBeTruthy();
       expect(screen.getByTestId('page-description')).toBeTruthy();
@@ -83,7 +79,6 @@ describe('PageHeader', () => {
       });
 
       // Core components should still be present
-      expect(screen.getByTestId('settings-warning')).toBeTruthy();
       expect(screen.getByTestId('page-title')).toBeTruthy();
       expect(screen.getByTestId('inventory-filter')).toBeTruthy();
       expect(screen.getByTestId('toolbar-buttons')).toBeTruthy();

data/webpack/ForemanInventoryUpload/Components/PageHeader/__tests__/PageTitle.test.js

@@ -1,12 +1,30 @@
 import React from 'react';
-import { render, screen } from '@testing-library/react';
+import { fireEvent, render, screen } from '@testing-library/react';
 import PageTitle from '../PageTitle';
 
+let mockIopMode = false;
+
+jest.mock('foremanReact/Root/Context/ForemanContext', () => ({
+  useForemanContext: () => ({
+    metadata: {
+      foreman_rh_cloud: {
+        iop: mockIopMode,
+      },
+    },
+    UI: {},
+  }),
+}));
+
 jest.mock('../components/CloudPingModal', () => () => (
   <div data-testid="cloud-ping-modal">CloudPingModal</div>
 ));
+jest.mock('foremanReact/common/helpers', () => ({ getDocsURL: () => {} }));
 
 describe('PageTitle', () => {
+  afterEach(() => {
+    mockIopMode = false;
+  });
+
   it('renders the page title', () => {
     render(<PageTitle />);
     expect(screen.getByText('Red Hat Inventory')).toBeTruthy();
@@ -16,4 +34,19 @@ describe('PageTitle', () => {
     const { container } = render(<PageTitle />);
     expect(container.querySelector('.title-dropdown')).toBeTruthy();
   });
+
+  it('renders cloud-ping dropdown item when not in IoP mode', () => {
+    mockIopMode = false;
+    render(<PageTitle />);
+    fireEvent.click(screen.getByLabelText('Actions'));
+    expect(screen.getByText('Connectivity test')).toBeTruthy();
+  });
+
+  it('does not render cloud-ping dropdown item when in IoP mode', () => {
+    mockIopMode = true;
+    render(<PageTitle />);
+    fireEvent.click(screen.getByLabelText('Actions'));
+    expect(screen.queryByText('Connectivity test')).toBeNull();
+    mockIopMode = false;
+  });
 });

data/webpack/ForemanInventoryUpload/Components/PageHeader/components/ToolbarButtons/ToolbarButtons.js

@@ -1,16 +1,13 @@
 import React from 'react';
 import { useSelector } from 'react-redux';
 import SyncButton from '../SyncButton';
-import CloudConnectorButton from '../CloudConnectorButton';
 import './toolbarButtons.scss';
 import { selectSubscriptionConnectionEnabled } from '../../../InventorySettings/InventorySettingsSelectors';
-import { useIopConfig } from '../../../../../common/Hooks/ConfigHooks';
 
 const ToolbarButtons = () => {
   const subscriptionConnectionEnabled = useSelector(
     selectSubscriptionConnectionEnabled
   );
-  const isIop = useIopConfig();
 
   if (!subscriptionConnectionEnabled) {
     return null;
@@ -18,7 +15,6 @@ const ToolbarButtons = () => {
 
   return (
     <div className="inventory_toolbar_buttons">
-      {!isIop && <CloudConnectorButton />}
       <SyncButton />
     </div>
   );

data/webpack/ForemanInventoryUpload/Components/PageHeader/components/ToolbarButtons/__tests__/ToolbarButtons.test.js

@@ -1,21 +1,13 @@
 import React from 'react';
-import { screen } from '@testing-library/react';
-import { rtlHelpers } from 'foremanReact/common/rtlTestHelpers';
+import { render, screen } from '@testing-library/react';
+import '@testing-library/jest-dom';
+import * as reactRedux from 'react-redux';
 import ToolbarButtons from '../ToolbarButtons';
-import { useIopConfig } from '../../../../../../common/Hooks/ConfigHooks';
-import { selectSubscriptionConnectionEnabled } from '../../../../InventorySettings/InventorySettingsSelectors';
 
-// Mock the config hook
-jest.mock('../../../../../../common/Hooks/ConfigHooks', () => ({
-  useIopConfig: jest.fn(),
+jest.mock('react-redux', () => ({
+  useSelector: jest.fn(),
 }));
 
-// Mock the selector
-jest.mock('../../../../InventorySettings/InventorySettingsSelectors', () => ({
-  selectSubscriptionConnectionEnabled: jest.fn(),
-}));
-
-// Mock child components to isolate ToolbarButtons testing
 jest.mock(
   '../../SyncButton',
   () =>
@@ -23,56 +15,35 @@ jest.mock(
       return <div data-testid="sync-button">Sync all inventory status</div>;
     }
 );
-jest.mock(
-  '../../CloudConnectorButton',
-  () =>
-    function MockCloudConnectorButton() {
-      return (
-        <div data-testid="cloud-connector-button">
-          Configure cloud connector
-        </div>
-      );
-    }
-);
-
-const { renderWithStore } = rtlHelpers;
 
 describe('ToolbarButtons', () => {
-  test('renders both buttons when subscription connection is enabled and not in IOP mode', () => {
-    useIopConfig.mockReturnValue(false);
-    selectSubscriptionConnectionEnabled.mockReturnValue(true);
-
-    renderWithStore(<ToolbarButtons />);
-
-    expect(screen.getByTestId('cloud-connector-button')).toBeTruthy();
-    expect(screen.getByTestId('sync-button')).toBeTruthy();
+  afterEach(() => {
+    jest.clearAllMocks();
   });
 
-  test('renders only sync button when in IOP mode', () => {
-    useIopConfig.mockReturnValue(true);
-    selectSubscriptionConnectionEnabled.mockReturnValue(true);
+  test('renders sync button when subscription connection is enabled', () => {
+    reactRedux.useSelector.mockReturnValue(true);
 
-    renderWithStore(<ToolbarButtons />);
+    render(<ToolbarButtons />);
 
-    expect(screen.queryByTestId('cloud-connector-button')).toBeNull();
-    expect(screen.getByTestId('sync-button')).toBeTruthy();
+    expect(screen.getByTestId('sync-button')).toBeInTheDocument();
   });
 
   test('renders nothing when subscription connection is not enabled', () => {
-    useIopConfig.mockReturnValue(false);
-    selectSubscriptionConnectionEnabled.mockReturnValue(false);
+    reactRedux.useSelector.mockReturnValue(false);
 
-    const { container } = renderWithStore(<ToolbarButtons />);
+    const { container } = render(<ToolbarButtons />);
 
     expect(container.firstChild).toBeNull();
   });
 
   test('renders toolbar buttons container with correct className when enabled', () => {
-    useIopConfig.mockReturnValue(false);
-    selectSubscriptionConnectionEnabled.mockReturnValue(true);
+    reactRedux.useSelector.mockReturnValue(true);
 
-    const { container } = renderWithStore(<ToolbarButtons />);
+    const { container } = render(<ToolbarButtons />);
 
-    expect(container.querySelector('.inventory_toolbar_buttons')).toBeTruthy();
+    expect(
+      container.querySelector('.inventory_toolbar_buttons')
+    ).toBeInTheDocument();
   });
 });

data/webpack/ForemanInventoryUpload/ForemanInventoryHelpers.js

@@ -1,14 +1,14 @@
 import URI from 'urijs';
+import { getDocsURL } from 'foremanReact/common/helpers';
 import { foremanUrl } from '../ForemanRhCloudHelpers';
 
 export const inventoryUrl = path =>
   foremanUrl(`/foreman_inventory_upload/${path}`);
 
 export const getInventoryDocsUrl = () =>
-  foremanUrl(
-    `/links/manual/?root_url=${URI.encode(
-      'https://docs.redhat.com/en/documentation/red_hat_lightspeed/1-latest/html-single/red_hat_lightspeed_remediations_guide/index'
-    )}`
+  getDocsURL(
+    'Managing_Hosts',
+    'configuring-foreman-server-for-cloud-connection'
   );
 
 export const getSubscriptionServiceDocsUrl = () =>

data/webpack/ForemanInventoryUpload/__tests__/ForemanInventoryHelpers.test.js

@@ -1,6 +1,21 @@
-import { isExitCodeLoading } from '../ForemanInventoryHelpers';
+jest.mock('foremanReact/common/helpers', () => ({
+  getDocsURL: jest.fn(),
+}));
+
+import { getDocsURL } from 'foremanReact/common/helpers';
+import { getInventoryDocsUrl, isExitCodeLoading } from '../ForemanInventoryHelpers';
 
 describe('ForemanInventoryUpload helpers', () => {
+  describe('getInventoryDocsUrl', () => {
+    it('requests the Managing Hosts guide at the cloud connection chapter', () => {
+      getInventoryDocsUrl();
+      expect(getDocsURL).toHaveBeenCalledWith(
+        'Managing_Hosts',
+        'configuring-foreman-server-for-cloud-connection'
+      );
+    });
+  });
+
   describe('isExitCodeLoading', () => {
     it('returns true when exit code contains "running"', () => {
       expect(isExitCodeLoading('currently running')).toBe(true);

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foreman_rh_cloud
 version: !ruby/object:Gem::Version
-  version: 14.1.3
+  version: 14.2.0
 platform: ruby
 authors:
 - Foreman Red Hat Cloud team
@@ -373,19 +373,10 @@ files:
 - webpack/ForemanInventoryUpload/Components/PageHeader/PageTitle.js
 - webpack/ForemanInventoryUpload/Components/PageHeader/__tests__/PageHeader.test.js
 - webpack/ForemanInventoryUpload/Components/PageHeader/__tests__/PageTitle.test.js
-- webpack/ForemanInventoryUpload/Components/PageHeader/components/CloudConnectorButton/CloudConnectorActions.js
-- webpack/ForemanInventoryUpload/Components/PageHeader/components/CloudConnectorButton/CloudConnectorButton.js
-- webpack/ForemanInventoryUpload/Components/PageHeader/components/CloudConnectorButton/CloudConnectorConstants.js
-- webpack/ForemanInventoryUpload/Components/PageHeader/components/CloudConnectorButton/CloudConnectorSelectors.js
-- webpack/ForemanInventoryUpload/Components/PageHeader/components/CloudConnectorButton/__tests__/CloudConnectorButton.test.js
-- webpack/ForemanInventoryUpload/Components/PageHeader/components/CloudConnectorButton/index.js
 - webpack/ForemanInventoryUpload/Components/PageHeader/components/CloudPingModal/index.js
 - webpack/ForemanInventoryUpload/Components/PageHeader/components/PageDescription/PageDescription.js
 - webpack/ForemanInventoryUpload/Components/PageHeader/components/PageDescription/__tests__/PageDescription.test.js
 - webpack/ForemanInventoryUpload/Components/PageHeader/components/PageDescription/index.js
-- webpack/ForemanInventoryUpload/Components/PageHeader/components/SettingsWarning/SettingsWarning.js
-- webpack/ForemanInventoryUpload/Components/PageHeader/components/SettingsWarning/SettingsWarning.test.js
-- webpack/ForemanInventoryUpload/Components/PageHeader/components/SettingsWarning/index.js
 - webpack/ForemanInventoryUpload/Components/PageHeader/components/SyncButton/SyncButton.js
 - webpack/ForemanInventoryUpload/Components/PageHeader/components/SyncButton/SyncButtonActions.js
 - webpack/ForemanInventoryUpload/Components/PageHeader/components/SyncButton/SyncButtonConstants.js
@@ -584,7 +575,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.6
+rubygems_version: 4.0.10
 specification_version: 4
 summary: Summary of ForemanRhCloud.
 test_files:

data/webpack/ForemanInventoryUpload/Components/PageHeader/components/CloudConnectorButton/CloudConnectorActions.js

@@ -1,21 +0,0 @@
-import React from 'react';
-import { translate as __ } from 'foremanReact/common/I18n';
-import { post } from 'foremanReact/redux/API';
-import { CONFIGURE_CLOUD_CONNECTOR } from './CloudConnectorConstants';
-import { inventoryUrl } from '../../../../ForemanInventoryHelpers';
-import { foremanUrl } from '../../../../../ForemanRhCloudHelpers';
-
-export const configureCloudConnector = () =>
-  post({
-    key: CONFIGURE_CLOUD_CONNECTOR,
-    url: inventoryUrl('cloud_connector'),
-    successToast: response => (
-      <span>
-        {__('Cloud connector setup is in progress now: ')}
-        <a href={foremanUrl(`/job_invocations/${response.data.id}`)}>
-          {__('Cloud connector job link')}
-        </a>
-      </span>
-    ),
-    errorToast: error => `${__('Cloud connector setup has failed: ')} ${error}`,
-  });

data/webpack/ForemanInventoryUpload/Components/PageHeader/components/CloudConnectorButton/CloudConnectorButton.js

@@ -1,59 +0,0 @@
-import React, { useState } from 'react';
-import PropTypes from 'prop-types';
-import { Spinner, Button, Popover } from '@patternfly/react-core';
-import { translate as __ } from 'foremanReact/common/I18n';
-import { CONNECTOR_STATUS } from './CloudConnectorConstants';
-
-export const CloudConnectorButton = ({ status, onClick, jobLink }) => {
-  const [isPopoverVisible, setIsPopoverVisible] = useState(false);
-  if (status === CONNECTOR_STATUS.PENDING) {
-    return (
-      <Popover
-        isVisible={isPopoverVisible}
-        shouldClose={() => setIsPopoverVisible(false)}
-        bodyContent={
-          <div>
-            {__('Cloud connector setup has started: ')}
-            <a href={jobLink} target="_blank" rel="noopener noreferrer">
-              {__('view the job in progress')}
-            </a>
-          </div>
-        }
-        aria-label="Popover with Link to cloud connector job"
-        closeBtnAriaLabel="Close cloud connector Popover"
-      >
-        <div
-          className="cloud-connector-pending-button"
-          onMouseEnter={() => setIsPopoverVisible(true)}
-        >
-          <Button variant="secondary" ouiaId="button-in-progress" isDisabled>
-            <Spinner size="sm" /> {__('Cloud Connector is in progress')}
-          </Button>
-        </div>
-      </Popover>
-    );
-  }
-
-  if (status === CONNECTOR_STATUS.RESOLVED) {
-    return (
-      <Button variant="secondary" ouiaId="button-reconfigure" onClick={onClick}>
-        {__('Reconfigure cloud connector')}
-      </Button>
-    );
-  }
-
-  return (
-    <Button variant="secondary" ouiaId="button-configure" onClick={onClick}>
-      {__('Configure cloud connector')}
-    </Button>
-  );
-};
-
-CloudConnectorButton.propTypes = {
-  status: PropTypes.string.isRequired,
-  onClick: PropTypes.func.isRequired,
-  jobLink: PropTypes.string,
-};
-CloudConnectorButton.defaultProps = {
-  jobLink: '',
-};

data/webpack/ForemanInventoryUpload/Components/PageHeader/components/CloudConnectorButton/CloudConnectorConstants.js

@@ -1,6 +0,0 @@
-export const CONFIGURE_CLOUD_CONNECTOR = 'CONFIGURE_CLOUD_CONNECTOR';
-export const CONNECTOR_STATUS = {
-  PENDING: 'PENDING',
-  RESOLVED: 'RESOLVED',
-  NOT_RESOLVED: 'NOT_RESOLVED',
-};

data/webpack/ForemanInventoryUpload/Components/PageHeader/components/CloudConnectorButton/CloudConnectorSelectors.js

@@ -1,19 +0,0 @@
-import { foremanUrl } from '../../../../../ForemanRhCloudHelpers';
-import { selectAccountsList } from '../../../AccountList/AccountListSelectors';
-import { CONNECTOR_STATUS } from './CloudConnectorConstants';
-
-export const SelectCloudConnectorStatus = state =>
-  selectAccountsList(state).CloudConnectorStatus || {};
-
-export const selectStatus = state => {
-  const { task } = SelectCloudConnectorStatus(state);
-  if (!task) return CONNECTOR_STATUS.NOT_RESOLVED;
-  if (task.result === 'pending') return CONNECTOR_STATUS.PENDING;
-  if (task.result === 'success') return CONNECTOR_STATUS.RESOLVED;
-  return CONNECTOR_STATUS.NOT_RESOLVED;
-};
-
-export const selectJobLink = state => {
-  const { id } = SelectCloudConnectorStatus(state);
-  return id ? foremanUrl(`/job_invocations/${id}`) : '';
-};

data/webpack/ForemanInventoryUpload/Components/PageHeader/components/CloudConnectorButton/__tests__/CloudConnectorButton.test.js

@@ -1,51 +0,0 @@
-import React from 'react';
-import { render, screen, fireEvent } from '@testing-library/react';
-import { CloudConnectorButton } from '../CloudConnectorButton';
-import { CONNECTOR_STATUS } from '../CloudConnectorConstants';
-
-describe('CloudConnectorButton', () => {
-  it('renders "Configure cloud connector" when not resolved', () => {
-    render(
-      <CloudConnectorButton
-        status={CONNECTOR_STATUS.NOT_RESOLVED}
-        onClick={jest.fn()}
-      />
-    );
-    expect(screen.getByRole('button', { name: /Configure cloud connector/ })).toBeTruthy();
-  });
-
-  it('renders "Reconfigure cloud connector" when resolved', () => {
-    render(
-      <CloudConnectorButton
-        status={CONNECTOR_STATUS.RESOLVED}
-        onClick={jest.fn()}
-      />
-    );
-    expect(screen.getByRole('button', { name: /Reconfigure cloud connector/ })).toBeTruthy();
-  });
-
-  it('renders in-progress button when pending', () => {
-    render(
-      <CloudConnectorButton
-        status={CONNECTOR_STATUS.PENDING}
-        onClick={jest.fn()}
-        jobLink="/job-link"
-      />
-    );
-    expect(
-      screen.getByText('Cloud Connector is in progress')
-    ).toBeTruthy();
-  });
-
-  it('calls onClick when configure button is clicked', () => {
-    const onClick = jest.fn();
-    render(
-      <CloudConnectorButton
-        status={CONNECTOR_STATUS.NOT_RESOLVED}
-        onClick={onClick}
-      />
-    );
-    fireEvent.click(screen.getByRole('button', { name: /Configure cloud connector/ }));
-    expect(onClick).toHaveBeenCalledTimes(1);
-  });
-});

data/webpack/ForemanInventoryUpload/Components/PageHeader/components/CloudConnectorButton/index.js

@@ -1,34 +0,0 @@
-import React from 'react';
-import { useSelector, useDispatch } from 'react-redux';
-import { openConfirmModal } from 'foremanReact/components/ConfirmModal';
-import { translate as __ } from 'foremanReact/common/I18n';
-import { CloudConnectorButton } from './CloudConnectorButton';
-import { configureCloudConnector } from './CloudConnectorActions';
-import { selectStatus, selectJobLink } from './CloudConnectorSelectors';
-
-const ConnectedCloudConnectorButton = () => {
-  const status = useSelector(selectStatus);
-  const jobLink = useSelector(selectJobLink);
-  const dispatch = useDispatch();
-
-  return (
-    <CloudConnectorButton
-      status={status}
-      onClick={() =>
-        dispatch(
-          openConfirmModal({
-            title: __('Notice'),
-            message: __(
-              'This action will also enable automatic reports upload'
-            ),
-            isWarning: true,
-            onConfirm: () => dispatch(configureCloudConnector()),
-          })
-        )
-      }
-      jobLink={jobLink}
-    />
-  );
-};
-
-export default ConnectedCloudConnectorButton;

data/webpack/ForemanInventoryUpload/Components/PageHeader/components/SettingsWarning/SettingsWarning.js

@@ -1,66 +0,0 @@
-import React, { useState } from 'react';
-import PropTypes from 'prop-types';
-import { Alert, AlertActionCloseButton } from '@patternfly/react-core';
-import { translate as __ } from 'foremanReact/common/I18n';
-
-export const SettingsWarning = ({
-  autoUpload,
-  hostObfuscation,
-  isCloudConnector,
-}) => {
-  const [showUploadWarning, setShowUploadWarning] = useState(true);
-  const [showObfuscationWarning, setShowObfuscationWarning] = useState(true);
-  if (!isCloudConnector || (!showUploadWarning && !showObfuscationWarning)) {
-    return null;
-  }
-  if (autoUpload && !hostObfuscation) {
-    return null;
-  }
-
-  const alerts = [];
-  if (!autoUpload && showUploadWarning) {
-    alerts.push(
-      <Alert
-        key="auto-upload"
-        ouiaId="auto-upload"
-        variant="warning"
-        title={__(
-          "Cloud Connector has been configured however the inventory auto-upload is disabled, it's recommended to enable it"
-        )}
-        actionClose={
-          <AlertActionCloseButton onClose={() => setShowUploadWarning(false)} />
-        }
-      />
-    );
-  }
-  if (hostObfuscation && showObfuscationWarning) {
-    alerts.push(
-      <Alert
-        key="obfuscating-host"
-        ouiaId="obfuscating-host"
-        variant="warning"
-        title={__(
-          "Cloud Connector has been configured however obfuscating host names setting is enabled, it's recommended to disable it"
-        )}
-        actionClose={
-          <AlertActionCloseButton
-            onClose={() => setShowObfuscationWarning(false)}
-          />
-        }
-      />
-    );
-  }
-  return <div className="settings-alert">{alerts}</div>;
-};
-
-SettingsWarning.propTypes = {
-  autoUpload: PropTypes.bool,
-  hostObfuscation: PropTypes.bool,
-  isCloudConnector: PropTypes.bool,
-};
-
-SettingsWarning.defaultProps = {
-  autoUpload: false,
-  hostObfuscation: false,
-  isCloudConnector: false,
-};

data/webpack/ForemanInventoryUpload/Components/PageHeader/components/SettingsWarning/SettingsWarning.test.js

@@ -1,61 +0,0 @@
-import React from 'react';
-import { render, screen } from '@testing-library/react';
-import { SettingsWarning } from './SettingsWarning';
-
-describe('SettingsWarning', () => {
-  it('renders nothing when isCloudConnector is false', () => {
-    render(
-      <SettingsWarning autoUpload={false} isCloudConnector={false} />
-    );
-    expect(screen.queryByRole('alert')).toBeNull();
-  });
-
-  it('renders nothing when autoUpload is on and obfuscation is off', () => {
-    render(
-      <SettingsWarning
-        autoUpload
-        hostObfuscation={false}
-        isCloudConnector
-      />
-    );
-    expect(screen.queryByRole('alert')).toBeNull();
-  });
-
-  it('renders upload warning when autoUpload is disabled', () => {
-    render(
-      <SettingsWarning
-        autoUpload={false}
-        hostObfuscation={false}
-        isCloudConnector
-      />
-    );
-    expect(
-      screen.getByText(/inventory auto-upload is disabled/)
-    ).toBeTruthy();
-  });
-
-  it('renders obfuscation warning when hostObfuscation is enabled', () => {
-    render(
-      <SettingsWarning autoUpload hostObfuscation isCloudConnector />
-    );
-    expect(
-      screen.getByText(/obfuscating host names setting is enabled/)
-    ).toBeTruthy();
-  });
-
-  it('renders both warnings when both conditions met', () => {
-    render(
-      <SettingsWarning
-        autoUpload={false}
-        hostObfuscation
-        isCloudConnector
-      />
-    );
-    expect(
-      screen.getByText(/inventory auto-upload is disabled/)
-    ).toBeTruthy();
-    expect(
-      screen.getByText(/obfuscating host names setting is enabled/)
-    ).toBeTruthy();
-  });
-});

data/webpack/ForemanInventoryUpload/Components/PageHeader/components/SettingsWarning/index.js

@@ -1,25 +0,0 @@
-import React from 'react';
-import { useSelector } from 'react-redux';
-import { SettingsWarning } from './SettingsWarning';
-import {
-  selectAutoUploadEnabled,
-  selectHostObfuscationEnabled,
-} from '../../../InventorySettings/InventorySettingsSelectors';
-import { CONNECTOR_STATUS } from '../CloudConnectorButton/CloudConnectorConstants';
-import { selectStatus } from '../CloudConnectorButton/CloudConnectorSelectors';
-
-const ConnectedSettingsWarning = () => {
-  const autoUpload = useSelector(selectAutoUploadEnabled);
-  const hostObfuscation = useSelector(selectHostObfuscationEnabled);
-  const isCloudConnector =
-    useSelector(selectStatus) === CONNECTOR_STATUS.RESOLVED;
-  return (
-    <SettingsWarning
-      autoUpload={autoUpload}
-      hostObfuscation={hostObfuscation}
-      isCloudConnector={isCloudConnector}
-    />
-  );
-};
-
-export default ConnectedSettingsWarning;