foreman_rh_cloud 14.1.2 → 14.2.0

data/test/unit/services/foreman_rh_cloud/insights_api_forwarder_test.rb

@@ -178,6 +178,61 @@ class UIRequestForwarderTest < ActiveSupport::TestCase
     assert_nil result
   end
 
+  test 'scope_request? should return tag_name for compliance systems endpoint' do
+    get_req = ActionDispatch::Request.new(
+      'REQUEST_URI' => '/api/compliance/v2/systems',
+      'REQUEST_METHOD' => 'GET',
+      'rack.input' => ::Puma::NullIO.new
+    )
+
+    result = @forwarder.send(:scope_request?, get_req, 'api/compliance/v2/systems')
+    assert_equal :tags, result
+  end
+
+  test 'scope_request? should return tag_name for compliance report systems endpoint' do
+    get_req = ActionDispatch::Request.new(
+      'REQUEST_URI' => '/api/compliance/v2/reports/report-123/systems',
+      'REQUEST_METHOD' => 'GET',
+      'rack.input' => ::Puma::NullIO.new
+    )
+
+    result = @forwarder.send(:scope_request?, get_req, 'api/compliance/v2/reports/report-123/systems')
+    assert_equal :tags, result
+  end
+
+  test 'scope_request? should return tag_name for individual compliance system endpoint' do
+    get_req = ActionDispatch::Request.new(
+      'REQUEST_URI' => '/api/compliance/v2/systems/system-456',
+      'REQUEST_METHOD' => 'GET',
+      'rack.input' => ::Puma::NullIO.new
+    )
+
+    result = @forwarder.send(:scope_request?, get_req, 'api/compliance/v2/systems/system-456')
+    assert_equal :tags, result
+  end
+
+  test 'scope_request? should return tag_name for system policies endpoint' do
+    get_req = ActionDispatch::Request.new(
+      'REQUEST_URI' => '/api/compliance/v2/systems/system-456/policies',
+      'REQUEST_METHOD' => 'GET',
+      'rack.input' => ::Puma::NullIO.new
+    )
+
+    result = @forwarder.send(:scope_request?, get_req, 'api/compliance/v2/systems/system-456/policies')
+    assert_equal :tags, result
+  end
+
+  test 'scope_request? should return tag_name for system reports endpoint' do
+    get_req = ActionDispatch::Request.new(
+      'REQUEST_URI' => '/api/compliance/v2/systems/system-456/reports',
+      'REQUEST_METHOD' => 'GET',
+      'rack.input' => ::Puma::NullIO.new
+    )
+
+    result = @forwarder.send(:scope_request?, get_req, 'api/compliance/v2/systems/system-456/reports')
+    assert_equal :tags, result
+  end
+
   test 'prepare_tags should use provided tag_name' do
     result = @forwarder.send(:prepare_tags, @user, @organization, @location, :custom_tag)
 
@@ -215,7 +270,7 @@ class UIRequestForwarderTest < ActiveSupport::TestCase
 
   # Permission enforcement tests
 
-  # GET /api/inventory/v1/hosts requires view_vulnerability
+  # GET /api/inventory/v1/hosts is a shared dependency - view_compliance OR view_vulnerability grants access
   test 'should allow GET request to inventory hosts when user has view_vulnerability permission' do
     user_agent = { :foo => :bar }
     params = {}
@@ -228,6 +283,7 @@ class UIRequestForwarderTest < ActiveSupport::TestCase
       'action_dispatch.request.query_parameters' => params
     )
 
+    @user.stubs(:can?).with(:view_compliance).returns(false)
     @user.stubs(:can?).with(:view_vulnerability).returns(true)
     ::ForemanRhCloud::TagsAuth.any_instance.expects(:update_tag)
     @forwarder.expects(:execute_cloud_request).returns(true)
@@ -235,7 +291,18 @@ class UIRequestForwarderTest < ActiveSupport::TestCase
     @forwarder.forward_request(req, 'api/inventory/v1/hosts', 'test_controller', @user, @organization, @location)
   end
 
-  test 'should deny GET request to inventory hosts when user lacks view_vulnerability permission' do
+  test 'should allow GET request to inventory hosts when user has view_compliance permission' do
+    req = build_request(method: 'GET', uri: '/api/inventory/v1/hosts')
+
+    @user.stubs(:can?).with(:view_compliance).returns(true)
+    @user.stubs(:can?).with(:view_vulnerability).returns(false)
+    ::ForemanRhCloud::TagsAuth.any_instance.expects(:update_tag)
+    @forwarder.expects(:execute_cloud_request).returns(true)
+
+    @forwarder.forward_request(req, 'api/inventory/v1/hosts', 'test_controller', @user, @organization, @location)
+  end
+
+  test 'should deny GET request to inventory hosts when user lacks both view_compliance and view_vulnerability' do
     user_agent = { :foo => :bar }
     params = {}
 
@@ -247,6 +314,7 @@ class UIRequestForwarderTest < ActiveSupport::TestCase
       'action_dispatch.request.query_parameters' => params
     )
 
+    @user.stubs(:can?).with(:view_compliance).returns(false)
     @user.stubs(:can?).with(:view_vulnerability).returns(false)
 
     assert_raises(::Foreman::PermissionMissingException) do
@@ -307,9 +375,43 @@ class UIRequestForwarderTest < ActiveSupport::TestCase
 
   # Data-driven tests for required_permission_for
   PERMISSION_MAPPINGS = [
+    # Shared inventory hosts endpoint - either view_compliance or view_vulnerability grants GET access
+    { path: 'api/inventory/v1/hosts', method: 'GET', expected: [:view_compliance, :view_vulnerability] },
+    { path: 'api/inventory/v1/hosts/abc-123', method: 'GET', expected: [:view_compliance, :view_vulnerability] },
+    # Compliance endpoints
+    { path: 'api/compliance/v2/policies', method: 'GET', expected: :view_compliance },
+    { path: 'api/compliance/v2/policies', method: 'POST', expected: :edit_compliance },
+    { path: 'api/compliance/v2/policies/policy-123', method: 'GET', expected: :view_compliance },
+    { path: 'api/compliance/v2/policies/policy-123', method: 'DELETE', expected: :edit_compliance },
+    { path: 'api/compliance/v2/policies/policy-123', method: 'PATCH', expected: :edit_compliance },
+    { path: 'api/compliance/v2/policies/policy-123/systems', method: 'GET', expected: :view_compliance },
+    { path: 'api/compliance/v2/policies/policy-123/systems', method: 'POST', expected: :edit_compliance },
+    { path: 'api/compliance/v2/policies/policy-123/systems/system-456', method: 'GET', expected: :view_compliance },
+    { path: 'api/compliance/v2/policies/policy-123/systems/system-456', method: 'DELETE', expected: :edit_compliance },
+    { path: 'api/compliance/v2/policies/policy-123/systems/system-456', method: 'PATCH', expected: :edit_compliance },
+    { path: 'api/compliance/v2/policies/policy-123/tailorings', method: 'GET', expected: :view_compliance },
+    { path: 'api/compliance/v2/policies/policy-123/tailorings', method: 'POST', expected: :edit_compliance },
+    { path: 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789', method: 'GET', expected: :view_compliance },
+    { path: 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789', method: 'PATCH', expected: :edit_compliance },
+    { path: 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules', method: 'GET', expected: :view_compliance },
+    { path: 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules', method: 'POST', expected: :edit_compliance },
+    { path: 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules/rule-999', method: 'GET', expected: :view_compliance },
+    { path: 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules/rule-999', method: 'DELETE', expected: :edit_compliance },
+    { path: 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules/rule-999', method: 'PATCH', expected: :edit_compliance },
+    { path: 'api/compliance/v2/reports', method: 'GET', expected: :view_compliance },
+    { path: 'api/compliance/v2/reports/report-123', method: 'GET', expected: :view_compliance },
+    { path: 'api/compliance/v2/reports/report-123', method: 'DELETE', expected: :edit_compliance },
+    { path: 'api/compliance/v2/reports/report-123/systems', method: 'GET', expected: :view_compliance },
+    { path: 'api/compliance/v2/reports/report-123/systems/system-456', method: 'GET', expected: :view_compliance },
+    { path: 'api/compliance/v2/reports/report-123/systems/os_versions', method: 'GET', expected: :view_compliance },
+    { path: 'api/compliance/v2/policies/policy-123/systems/os_versions', method: 'GET', expected: :view_compliance },
+    { path: 'api/compliance/v2/systems', method: 'GET', expected: :view_compliance },
+    { path: 'api/compliance/v2/systems/system-456', method: 'GET', expected: :view_compliance },
+    { path: 'api/compliance/v2/systems/os_versions', method: 'GET', expected: :view_compliance },
+    { path: 'api/compliance/v2/systems/system-456/policies', method: 'GET', expected: :view_compliance },
+    { path: 'api/compliance/v2/systems/system-456/reports', method: 'GET', expected: :view_compliance },
+    { path: 'api/compliance/v2/profiles', method: 'GET', expected: :view_compliance },
     # Vulnerability endpoints
-    { path: 'api/inventory/v1/hosts', method: 'GET', expected: :view_vulnerability },
-    { path: 'api/inventory/v1/hosts/abc-123', method: 'GET', expected: :view_vulnerability },
     { path: 'api/vulnerability/v1/vulnerabilities/cves', method: 'POST', expected: :view_vulnerability },
     { path: 'api/vulnerability/v1/status', method: 'PATCH', expected: :edit_vulnerability },
     { path: 'api/vulnerability/v1/cves/status', method: 'PATCH', expected: :edit_vulnerability },
@@ -383,6 +485,140 @@ class UIRequestForwarderTest < ActiveSupport::TestCase
     end
   end
 
+  # Compliance permission integration tests
+  test 'should allow GET request to compliance policies when user has view_compliance permission' do
+    req = build_request(method: 'GET', uri: '/api/compliance/v2/policies')
+
+    @user.stubs(:can?).with(:view_compliance).returns(true)
+    @forwarder.expects(:execute_cloud_request).returns(true)
+
+    @forwarder.forward_request(req, 'api/compliance/v2/policies', 'test_controller', @user, @organization, @location)
+  end
+
+  test 'should deny GET request to compliance policies when user lacks view_compliance permission' do
+    req = build_request(method: 'GET', uri: '/api/compliance/v2/policies')
+
+    @user.stubs(:can?).with(:view_compliance).returns(false)
+
+    assert_raises(::Foreman::PermissionMissingException) do
+      @forwarder.forward_request(req, 'api/compliance/v2/policies', 'test_controller', @user, @organization, @location)
+    end
+  end
+
+  test 'should allow POST request to compliance policies when user has edit_compliance permission' do
+    req = build_request(method: 'POST', uri: '/api/compliance/v2/policies', data: '{"name": "test-policy"}')
+
+    @user.stubs(:can?).with(:edit_compliance).returns(true)
+    @forwarder.expects(:execute_cloud_request).returns(true)
+
+    @forwarder.forward_request(req, 'api/compliance/v2/policies', 'test_controller', @user, @organization, @location)
+  end
+
+  test 'should deny POST request to compliance policies when user lacks edit_compliance permission' do
+    req = build_request(method: 'POST', uri: '/api/compliance/v2/policies', data: '{"name": "test-policy"}')
+
+    @user.stubs(:can?).with(:edit_compliance).returns(false)
+
+    assert_raises(::Foreman::PermissionMissingException) do
+      @forwarder.forward_request(req, 'api/compliance/v2/policies', 'test_controller', @user, @organization, @location)
+    end
+  end
+
+  test 'should allow PATCH request to compliance policy when user has edit_compliance permission' do
+    req = build_request(method: 'PATCH', uri: '/api/compliance/v2/policies/policy-123', data: '{"name": "updated-policy"}')
+
+    @user.stubs(:can?).with(:edit_compliance).returns(true)
+    @forwarder.expects(:execute_cloud_request).returns(true)
+
+    @forwarder.forward_request(req, 'api/compliance/v2/policies/policy-123', 'test_controller', @user, @organization, @location)
+  end
+
+  test 'should deny PATCH request to compliance policy when user lacks edit_compliance permission' do
+    req = build_request(method: 'PATCH', uri: '/api/compliance/v2/policies/policy-123', data: '{"name": "updated-policy"}')
+
+    @user.stubs(:can?).with(:edit_compliance).returns(false)
+
+    assert_raises(::Foreman::PermissionMissingException) do
+      @forwarder.forward_request(req, 'api/compliance/v2/policies/policy-123', 'test_controller', @user, @organization, @location)
+    end
+  end
+
+  test 'should allow DELETE request to compliance policy when user has edit_compliance permission' do
+    req = build_request(method: 'DELETE', uri: '/api/compliance/v2/policies/policy-123')
+
+    @user.stubs(:can?).with(:edit_compliance).returns(true)
+    @forwarder.expects(:execute_cloud_request).returns(true)
+
+    @forwarder.forward_request(req, 'api/compliance/v2/policies/policy-123', 'test_controller', @user, @organization, @location)
+  end
+
+  test 'should deny DELETE request to compliance policy when user lacks edit_compliance permission' do
+    req = build_request(method: 'DELETE', uri: '/api/compliance/v2/policies/policy-123')
+
+    @user.stubs(:can?).with(:edit_compliance).returns(false)
+
+    assert_raises(::Foreman::PermissionMissingException) do
+      @forwarder.forward_request(req, 'api/compliance/v2/policies/policy-123', 'test_controller', @user, @organization, @location)
+    end
+  end
+
+  test 'should allow POST request to compliance policy systems when user has edit_compliance permission' do
+    req = build_request(method: 'POST', uri: '/api/compliance/v2/policies/policy-123/systems', data: '{"id": "system-456"}')
+
+    @user.stubs(:can?).with(:edit_compliance).returns(true)
+    @forwarder.expects(:execute_cloud_request).returns(true)
+
+    @forwarder.forward_request(req, 'api/compliance/v2/policies/policy-123/systems', 'test_controller', @user, @organization, @location)
+  end
+
+  test 'should deny POST request to compliance policy systems when user lacks edit_compliance permission' do
+    req = build_request(method: 'POST', uri: '/api/compliance/v2/policies/policy-123/systems', data: '{"id": "system-456"}')
+
+    @user.stubs(:can?).with(:edit_compliance).returns(false)
+
+    assert_raises(::Foreman::PermissionMissingException) do
+      @forwarder.forward_request(req, 'api/compliance/v2/policies/policy-123/systems', 'test_controller', @user, @organization, @location)
+    end
+  end
+
+  test 'should allow DELETE request to compliance report when user has edit_compliance permission' do
+    req = build_request(method: 'DELETE', uri: '/api/compliance/v2/reports/report-123')
+
+    @user.stubs(:can?).with(:edit_compliance).returns(true)
+    @forwarder.expects(:execute_cloud_request).returns(true)
+
+    @forwarder.forward_request(req, 'api/compliance/v2/reports/report-123', 'test_controller', @user, @organization, @location)
+  end
+
+  test 'should deny DELETE request to compliance report when user lacks edit_compliance permission' do
+    req = build_request(method: 'DELETE', uri: '/api/compliance/v2/reports/report-123')
+
+    @user.stubs(:can?).with(:edit_compliance).returns(false)
+
+    assert_raises(::Foreman::PermissionMissingException) do
+      @forwarder.forward_request(req, 'api/compliance/v2/reports/report-123', 'test_controller', @user, @organization, @location)
+    end
+  end
+
+  test 'should allow DELETE request to compliance tailoring rule when user has edit_compliance permission' do
+    req = build_request(method: 'DELETE', uri: '/api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules/rule-999')
+
+    @user.stubs(:can?).with(:edit_compliance).returns(true)
+    @forwarder.expects(:execute_cloud_request).returns(true)
+
+    @forwarder.forward_request(req, 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules/rule-999', 'test_controller', @user, @organization, @location)
+  end
+
+  test 'should deny DELETE request to compliance tailoring rule when user lacks edit_compliance permission' do
+    req = build_request(method: 'DELETE', uri: '/api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules/rule-999')
+
+    @user.stubs(:can?).with(:edit_compliance).returns(false)
+
+    assert_raises(::Foreman::PermissionMissingException) do
+      @forwarder.forward_request(req, 'api/compliance/v2/policies/policy-123/tailorings/tailoring-789/rules/rule-999', 'test_controller', @user, @organization, @location)
+    end
+  end
+
   # Edge case: anonymous user
   test 'should deny request when user is nil' do
     req = build_request(method: 'GET', uri: '/api/insights/v1/stats/systems')

data/webpack/ForemanInventoryUpload/Components/AccountList/AccountList.fixtures.js

@@ -32,11 +32,6 @@ export const processStatusName = 'upload_report_status';
 
 export const filterTerm = 'some_filter';
 
-export const CloudConnectorStatus = {
-  id: 7,
-  task: { id: 11 },
-};
-
 export const props = {
   accounts,
   fetchAccountsStatus: noop,
@@ -47,7 +42,6 @@ export const props = {
 
 export const pollingResponse = {
   accounts,
-  CloudConnectorStatus,
 };
 
 export const fetchAccountsStatusResponse = {

data/webpack/ForemanInventoryUpload/Components/AccountList/AccountListReducer.js

@@ -20,7 +20,6 @@ export default (state = initialState, action) => {
       accounts,
       accountID,
       processStatusName,
-      CloudConnectorStatus,
     } = {},
   } = action;
 
@@ -29,7 +28,6 @@ export default (state = initialState, action) => {
       return state.merge({
         ...state,
         accounts,
-        CloudConnectorStatus,
         error: null,
       });
     case INVENTORY_ACCOUNT_STATUS_POLLING_ERROR:

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/EmptyResults/__tests__/EmptyResults.test.js

@@ -1,13 +1,14 @@
-import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
-
+import React from 'react';
+import { render, screen } from '@testing-library/react';
 import EmptyResults from '../EmptyResults';
 
-const fixtures = {
-  'render without Props': {},
-  /** fixtures, props for the component */
-};
-
 describe('EmptyResults', () => {
-  describe('rendering', () =>
-    testComponentSnapshotsWithFixtures(EmptyResults, fixtures));
+  it('renders the empty results message', () => {
+    render(<EmptyResults />);
+    expect(
+      screen.getByText(
+        "Oops! Couldn't find organization that matches your query"
+      )
+    ).toBeTruthy();
+  });
 });

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/EmptyState/__tests__/EmptyState.test.js

@@ -1,13 +1,17 @@
-import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
-
+import React from 'react';
+import { render, screen } from '@testing-library/react';
 import EmptyState from '../EmptyState';
 
-const fixtures = {
-  'render without Props': {},
-  /** fixtures, props for the component */
-};
-
 describe('EmptyState', () => {
-  describe('rendering', () =>
-    testComponentSnapshotsWithFixtures(EmptyState, fixtures));
+  it('renders fetching data message', () => {
+    render(<EmptyState />);
+    expect(
+      screen.getByText('Fetching data about your accounts')
+    ).toBeTruthy();
+  });
+
+  it('renders loading indicator', () => {
+    render(<EmptyState />);
+    expect(screen.getByText('Loading...')).toBeTruthy();
+  });
 });

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/ErrorState/__tests__/ErrorState.test.js

@@ -1,13 +1,24 @@
-import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
-
+import React from 'react';
+import { render, screen } from '@testing-library/react';
 import ErrorState from '../ErrorState';
 
-const fixtures = {
-  'render without Props': {},
-  /** fixtures, props for the component */
-};
-
 describe('ErrorState', () => {
-  describe('rendering', () =>
-    testComponentSnapshotsWithFixtures(ErrorState, fixtures));
+  it('renders the error message heading', () => {
+    render(<ErrorState error="Something went wrong" />);
+    expect(
+      screen.getByText(
+        'Encountered an error while trying to access the server:'
+      )
+    ).toBeTruthy();
+  });
+
+  it('renders the error description', () => {
+    render(<ErrorState error="Connection refused" />);
+    expect(screen.getByText('Connection refused')).toBeTruthy();
+  });
+
+  it('renders with empty error by default', () => {
+    const { container } = render(<ErrorState />);
+    expect(container.querySelector('.error_description')).toBeTruthy();
+  });
 });

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/ListItem/__tests__/ListItem.test.js

@@ -1,13 +1,36 @@
-import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
-
+import React from 'react';
+import { render, screen } from '@testing-library/react';
+import { Accordion } from '@patternfly/react-core';
 import ListItem from '../ListItem';
-import { props } from '../ListItem.fixtures';
 
-const fixtures = {
-  'render with Props': props,
-};
+jest.mock('../../../../Dashboard', () => () => null);
+
+const renderListItem = props =>
+  render(
+    <Accordion>
+      <ListItem {...props} />
+    </Accordion>
+  );
 
 describe('ListItem', () => {
-  describe('rendering', () =>
-    testComponentSnapshotsWithFixtures(ListItem, fixtures));
+  const defaultProps = {
+    label: 'test-org',
+    account: {
+      generated_status: 'unknown',
+      uploaded_status: 'unknown',
+      id: 1,
+    },
+  };
+
+  it('renders the account label', () => {
+    renderListItem(defaultProps);
+    expect(screen.getByText('test-org')).toBeTruthy();
+  });
+
+  it('renders Generated and Uploaded status labels', () => {
+    renderListItem(defaultProps);
+    expect(screen.getByText('Generated')).toBeTruthy();
+    expect(screen.getByText('Uploaded')).toBeTruthy();
+  });
+
 });

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/ListItemStatus/__tests__/ListItemStatus.test.js

@@ -1,14 +1,30 @@
-import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
-
+import React from 'react';
+import { render, screen } from '@testing-library/react';
 import ListItemStatus from '../ListItemStatus';
-import { props } from '../ListItemStatus.fixtures';
-
-const fixtures = {
-  'render without Props': {},
-  'render with Props': props,
-};
 
 describe('ListItemStatus', () => {
-  describe('rendering', () =>
-    testComponentSnapshotsWithFixtures(ListItemStatus, fixtures));
+  it('renders Generated and Uploaded labels', () => {
+    render(<ListItemStatus />);
+    expect(screen.getByText('Generated')).toBeTruthy();
+    expect(screen.getByText('Uploaded')).toBeTruthy();
+  });
+
+  it('shows dash placeholders for unknown status', () => {
+    render(
+      <ListItemStatus
+        account={{ generated_status: 'unknown', uploaded_status: 'unknown' }}
+      />
+    );
+    expect(screen.getAllByText('--')).toHaveLength(2);
+  });
+
+  it('renders with provided account statuses', () => {
+    render(
+      <ListItemStatus
+        account={{ generated_status: 'success', uploaded_status: 'running' }}
+      />
+    );
+    expect(screen.getByText('Generated')).toBeTruthy();
+    expect(screen.getByText('Uploaded')).toBeTruthy();
+  });
 });

data/webpack/ForemanInventoryUpload/Components/AccountList/__tests__/AccountList.test.js

@@ -1,14 +1,38 @@
-import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
-
+import React from 'react';
+import { render, screen } from '@testing-library/react';
 import AccountList from '../AccountList';
-import { props } from '../AccountList.fixtures';
+import { accounts } from '../AccountList.fixtures';
 
-const fixtures = {
-  'render with props': props,
-  'show empty results': { ...props, filterTerm: 'not_matching_term' },
-};
+jest.mock('../Components/ListItem', () => ({ label }) => (
+  <div>{label}</div>
+));
 
 describe('AccountList', () => {
-  describe('rendering', () =>
-    testComponentSnapshotsWithFixtures(AccountList, fixtures));
+  it('renders account labels', () => {
+    render(<AccountList accounts={accounts} />);
+    Object.keys(accounts).forEach(label => {
+      expect(screen.getByText(label)).toBeTruthy();
+    });
+  });
+
+  it('shows empty results when filterTerm matches nothing', () => {
+    render(<AccountList accounts={accounts} filterTerm="not_matching_term" />);
+    expect(
+      screen.getByText(
+        "Oops! Couldn't find organization that matches your query"
+      )
+    ).toBeTruthy();
+  });
+
+  it('shows empty state when accounts are empty', () => {
+    render(<AccountList accounts={{}} />);
+    expect(
+      screen.getByText('Fetching data about your accounts')
+    ).toBeTruthy();
+  });
+
+  it('shows error state when error is present', () => {
+    render(<AccountList accounts={{}} error="Server error" />);
+    expect(screen.getByText('Server error')).toBeTruthy();
+  });
 });

data/webpack/ForemanInventoryUpload/Components/AccountList/__tests__/AccountListReducer.test.js

@@ -1,5 +1,3 @@
-import { testReducerSnapshotWithFixtures } from '@theforeman/test';
-
 import {
   INVENTORY_ACCOUNT_STATUS_POLLING,
   INVENTORY_ACCOUNT_STATUS_POLLING_START,
@@ -14,45 +12,65 @@ import {
   accountID,
   processStatusName,
   pollingResponse,
+  accounts,
 } from '../AccountList.fixtures';
 
-const fixtures = {
-  'should return the initial state': {},
-  'should handle INVENTORY_ACCOUNT_STATUS_POLLING': {
-    action: {
+describe('AccountList reducer', () => {
+  it('returns the initial state', () => {
+    const state = reducer(undefined, { type: '@@INIT' });
+    expect(state.accounts).toEqual({});
+    expect(state.pollingProcessID).toBe(0);
+    expect(state.error).toBeNull();
+  });
+
+  it('handles INVENTORY_ACCOUNT_STATUS_POLLING', () => {
+    const state = reducer(undefined, {
       type: INVENTORY_ACCOUNT_STATUS_POLLING,
       payload: pollingResponse,
-    },
-  },
-  'should handle INVENTORY_ACCOUNT_STATUS_POLLING_ERROR': {
-    action: {
+    });
+    expect(state.accounts).toEqual(accounts);
+    expect(state.error).toBeNull();
+  });
+
+  it('handles INVENTORY_ACCOUNT_STATUS_POLLING_ERROR', () => {
+    const state = reducer(undefined, {
       type: INVENTORY_ACCOUNT_STATUS_POLLING_ERROR,
       payload: { error },
-    },
-  },
-  'should handle INVENTORY_ACCOUNT_STATUS_POLLING_START': {
-    action: {
+    });
+    expect(state.accounts).toEqual({});
+    expect(state.error).toBe(error);
+  });
+
+  it('handles INVENTORY_ACCOUNT_STATUS_POLLING_START', () => {
+    const state = reducer(undefined, {
+      type: INVENTORY_ACCOUNT_STATUS_POLLING_START,
+      payload: { pollingProcessID },
+    });
+    expect(state.pollingProcessID).toBe(pollingProcessID);
+  });
+
+  it('handles INVENTORY_ACCOUNT_STATUS_POLLING_STOP (default case)', () => {
+    const prevState = reducer(undefined, {
       type: INVENTORY_ACCOUNT_STATUS_POLLING_START,
-      payload: {
-        pollingProcessID,
-      },
-    },
-  },
-  'should handle INVENTORY_ACCOUNT_STATUS_POLLING_STOP': {
-    action: {
+      payload: { pollingProcessID },
+    });
+    const state = reducer(prevState, {
       type: INVENTORY_ACCOUNT_STATUS_POLLING_STOP,
-    },
-  },
-  'should handle INVENTORY_PROCESS_RESTART': {
-    action: {
-      type: INVENTORY_PROCESS_RESTART,
-      payload: {
-        accountID,
-        processStatusName,
-      },
-    },
-  },
-};
+    });
+    expect(state.pollingProcessID).toBe(pollingProcessID);
+    expect(state.accounts).toEqual({});
+    expect(state.error).toBeNull();
+  });
 
-describe('AccountList reducer', () =>
-  testReducerSnapshotWithFixtures(reducer, fixtures));
+  it('handles INVENTORY_PROCESS_RESTART', () => {
+    const stateWithAccounts = reducer(undefined, {
+      type: INVENTORY_ACCOUNT_STATUS_POLLING,
+      payload: pollingResponse,
+    });
+    const state = reducer(stateWithAccounts, {
+      type: INVENTORY_PROCESS_RESTART,
+      payload: { accountID, processStatusName },
+    });
+    expect(state.accounts[accountID][processStatusName]).toBe('Restarting...');
+  });
+});