foreman_rh_cloud 14.1.1 → 14.1.3

data/test/unit/organization_destroy_extensions_test.rb

@@ -0,0 +1,50 @@
+require 'test_plugin_helper'
+require 'foreman_tasks/test_helpers'
+
+class OrganizationDestroyExtensionsTest < ActiveSupport::TestCase
+  include Dynflow::Testing
+
+  setup do
+    User.current = User.find_by(login: 'secret_admin')
+
+    @organization = stub
+    @organization.stubs(:label).returns('test_org')
+    @organization.stubs(:id).returns(1)
+    @organization.stubs(:validate_destroy).returns([])
+    @organization.stubs(:products).returns([])
+    @organization.stubs(:activation_keys).returns([])
+    @organization.stubs(:content_views).returns(stub(:non_default => []))
+    @organization.stubs(:default_content_view).returns(stub(:content_view_environments => []))
+    @organization.stubs(:promotion_paths).returns([])
+    @organization.stubs(:providers).returns([])
+    @organization.stubs(:library).returns(stub(:destroy! => true))
+
+    where_clause = mock
+    where_clause.stubs(:where).returns([])
+    ::Host.stubs(:unscoped).returns(where_clause)
+  end
+
+  teardown do
+    ForemanRhCloud.unstub(:with_iop_smart_proxy?)
+  end
+
+  test 'plans DestroyOrganizationHbiHostsJob when in IoP mode' do
+    ForemanRhCloud.stubs(:with_iop_smart_proxy?).returns(true)
+
+    action = create_action(::Actions::Katello::Organization::Destroy)
+    action.stubs(:action_subject).with(@organization)
+    plan_action(action, @organization)
+
+    assert_action_planned_with(action, ForemanInventoryUpload::Async::DestroyOrganizationHbiHostsJob, @organization.id)
+  end
+
+  test 'does not plan DestroyOrganizationHbiHostsJob when not in IoP mode' do
+    ForemanRhCloud.stubs(:with_iop_smart_proxy?).returns(false)
+
+    action = create_action(::Actions::Katello::Organization::Destroy)
+    action.stubs(:action_subject).with(@organization)
+    plan_action(action, @organization)
+
+    refute_action_planned(action, ForemanInventoryUpload::Async::DestroyOrganizationHbiHostsJob)
+  end
+end

data/test/unit/services/foreman_rh_cloud/url_remediations_retriever_test.rb

@@ -1,8 +1,8 @@
 require 'test_plugin_helper'
 
 class URLRemediationsRetrieverTest < ActiveSupport::TestCase
-  test 'Calls the given url' do
-    retreiver = ForemanRhCloud::URLRemediationsRetriever.new(
+  test 'Calls the given url with GET when no hosts in URL' do
+    retriever = ForemanRhCloud::URLRemediationsRetriever.new(
       organization_id: FactoryBot.create(:organization).id,
       url: 'http://test.example.com',
       payload: 'TEST_PAYLOAD',
@@ -11,19 +11,96 @@ class URLRemediationsRetrieverTest < ActiveSupport::TestCase
       }
     )
 
-    retreiver.stubs(:cert_auth_available?).returns(true)
+    retriever.stubs(:cert_auth_available?).returns(true)
 
     response = mock('response')
     response.stubs(:body).returns('TEST_RESPONSE')
-    retreiver.expects(:execute_cloud_request).with do |params|
+    retriever.expects(:execute_cloud_request).with do |params|
       params[:method] == :get &&
       params[:url] == 'http://test.example.com' &&
       params[:headers][:custom1] == 'TEST_HEADER' &&
       params[:payload] == "\"TEST_PAYLOAD\""
     end.returns(response)
 
-    actual = retreiver.create_playbook
+    actual = retriever.create_playbook
 
     assert_equal 'TEST_RESPONSE', actual
   end
+
+  test 'Uses POST with hosts in body when URL contains hosts query param' do
+    retriever = ForemanRhCloud::URLRemediationsRetriever.new(
+      organization_id: FactoryBot.create(:organization).id,
+      url: 'http://test.example.com/api/remediations/1234/playbook?hosts=uuid-1,uuid-2,uuid-3'
+    )
+
+    retriever.stubs(:cert_auth_available?).returns(true)
+
+    response = mock('response')
+    response.stubs(:body).returns('TEST_PLAYBOOK')
+    retriever.expects(:execute_cloud_request).with do |params|
+      params[:method] == :post &&
+      params[:url] == 'http://test.example.com/api/remediations/1234/playbook' &&
+      JSON.parse(params[:payload]) == ['uuid-1', 'uuid-2', 'uuid-3']
+    end.returns(response)
+
+    actual = retriever.create_playbook
+
+    assert_equal 'TEST_PLAYBOOK', actual
+  end
+
+  test 'Preserves other query params when extracting hosts' do
+    retriever = ForemanRhCloud::URLRemediationsRetriever.new(
+      organization_id: FactoryBot.create(:organization).id,
+      url: 'http://test.example.com/api/remediations/1234/playbook?hosts=uuid-1,uuid-2&localhost=false'
+    )
+
+    retriever.stubs(:cert_auth_available?).returns(true)
+
+    response = mock('response')
+    response.stubs(:body).returns('TEST_PLAYBOOK')
+    retriever.expects(:execute_cloud_request).with do |params|
+      params[:method] == :post &&
+      params[:url].include?('localhost=false') &&
+      !params[:url].include?('hosts=') &&
+      JSON.parse(params[:payload]) == ['uuid-1', 'uuid-2']
+    end.returns(response)
+
+    retriever.create_playbook
+  end
+
+  test 'Merges multiple hosts query params into a single array' do
+    retriever = ForemanRhCloud::URLRemediationsRetriever.new(
+      organization_id: FactoryBot.create(:organization).id,
+      url: 'http://test.example.com/api/remediations/1234/playbook?hosts=uuid-1&hosts=uuid-2'
+    )
+
+    retriever.stubs(:cert_auth_available?).returns(true)
+
+    response = mock('response')
+    response.stubs(:body).returns('TEST_PLAYBOOK')
+    retriever.expects(:execute_cloud_request).with do |params|
+      params[:method] == :post &&
+      params[:url] == 'http://test.example.com/api/remediations/1234/playbook' &&
+      JSON.parse(params[:payload]) == ['uuid-1', 'uuid-2']
+    end.returns(response)
+
+    retriever.create_playbook
+  end
+
+  test 'Falls back to GET when hosts query param is empty' do
+    retriever = ForemanRhCloud::URLRemediationsRetriever.new(
+      organization_id: FactoryBot.create(:organization).id,
+      url: 'http://test.example.com/api/remediations/1234/playbook?hosts='
+    )
+
+    retriever.stubs(:cert_auth_available?).returns(true)
+
+    response = mock('response')
+    response.stubs(:body).returns('TEST_PLAYBOOK')
+    retriever.expects(:execute_cloud_request).with do |params|
+      params[:method] == :get
+    end.returns(response)
+
+    retriever.create_playbook
+  end
 end

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/EmptyResults/__tests__/EmptyResults.test.js

@@ -1,13 +1,14 @@
-import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
-
+import React from 'react';
+import { render, screen } from '@testing-library/react';
 import EmptyResults from '../EmptyResults';
 
-const fixtures = {
-  'render without Props': {},
-  /** fixtures, props for the component */
-};
-
 describe('EmptyResults', () => {
-  describe('rendering', () =>
-    testComponentSnapshotsWithFixtures(EmptyResults, fixtures));
+  it('renders the empty results message', () => {
+    render(<EmptyResults />);
+    expect(
+      screen.getByText(
+        "Oops! Couldn't find organization that matches your query"
+      )
+    ).toBeTruthy();
+  });
 });

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/EmptyState/__tests__/EmptyState.test.js

@@ -1,13 +1,17 @@
-import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
-
+import React from 'react';
+import { render, screen } from '@testing-library/react';
 import EmptyState from '../EmptyState';
 
-const fixtures = {
-  'render without Props': {},
-  /** fixtures, props for the component */
-};
-
 describe('EmptyState', () => {
-  describe('rendering', () =>
-    testComponentSnapshotsWithFixtures(EmptyState, fixtures));
+  it('renders fetching data message', () => {
+    render(<EmptyState />);
+    expect(
+      screen.getByText('Fetching data about your accounts')
+    ).toBeTruthy();
+  });
+
+  it('renders loading indicator', () => {
+    render(<EmptyState />);
+    expect(screen.getByText('Loading...')).toBeTruthy();
+  });
 });

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/ErrorState/__tests__/ErrorState.test.js

@@ -1,13 +1,24 @@
-import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
-
+import React from 'react';
+import { render, screen } from '@testing-library/react';
 import ErrorState from '../ErrorState';
 
-const fixtures = {
-  'render without Props': {},
-  /** fixtures, props for the component */
-};
-
 describe('ErrorState', () => {
-  describe('rendering', () =>
-    testComponentSnapshotsWithFixtures(ErrorState, fixtures));
+  it('renders the error message heading', () => {
+    render(<ErrorState error="Something went wrong" />);
+    expect(
+      screen.getByText(
+        'Encountered an error while trying to access the server:'
+      )
+    ).toBeTruthy();
+  });
+
+  it('renders the error description', () => {
+    render(<ErrorState error="Connection refused" />);
+    expect(screen.getByText('Connection refused')).toBeTruthy();
+  });
+
+  it('renders with empty error by default', () => {
+    const { container } = render(<ErrorState />);
+    expect(container.querySelector('.error_description')).toBeTruthy();
+  });
 });

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/ListItem/__tests__/ListItem.test.js

@@ -1,13 +1,36 @@
-import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
-
+import React from 'react';
+import { render, screen } from '@testing-library/react';
+import { Accordion } from '@patternfly/react-core';
 import ListItem from '../ListItem';
-import { props } from '../ListItem.fixtures';
 
-const fixtures = {
-  'render with Props': props,
-};
+jest.mock('../../../../Dashboard', () => () => null);
+
+const renderListItem = props =>
+  render(
+    <Accordion>
+      <ListItem {...props} />
+    </Accordion>
+  );
 
 describe('ListItem', () => {
-  describe('rendering', () =>
-    testComponentSnapshotsWithFixtures(ListItem, fixtures));
+  const defaultProps = {
+    label: 'test-org',
+    account: {
+      generated_status: 'unknown',
+      uploaded_status: 'unknown',
+      id: 1,
+    },
+  };
+
+  it('renders the account label', () => {
+    renderListItem(defaultProps);
+    expect(screen.getByText('test-org')).toBeTruthy();
+  });
+
+  it('renders Generated and Uploaded status labels', () => {
+    renderListItem(defaultProps);
+    expect(screen.getByText('Generated')).toBeTruthy();
+    expect(screen.getByText('Uploaded')).toBeTruthy();
+  });
+
 });

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/ListItemStatus/__tests__/ListItemStatus.test.js

@@ -1,14 +1,30 @@
-import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
-
+import React from 'react';
+import { render, screen } from '@testing-library/react';
 import ListItemStatus from '../ListItemStatus';
-import { props } from '../ListItemStatus.fixtures';
-
-const fixtures = {
-  'render without Props': {},
-  'render with Props': props,
-};
 
 describe('ListItemStatus', () => {
-  describe('rendering', () =>
-    testComponentSnapshotsWithFixtures(ListItemStatus, fixtures));
+  it('renders Generated and Uploaded labels', () => {
+    render(<ListItemStatus />);
+    expect(screen.getByText('Generated')).toBeTruthy();
+    expect(screen.getByText('Uploaded')).toBeTruthy();
+  });
+
+  it('shows dash placeholders for unknown status', () => {
+    render(
+      <ListItemStatus
+        account={{ generated_status: 'unknown', uploaded_status: 'unknown' }}
+      />
+    );
+    expect(screen.getAllByText('--')).toHaveLength(2);
+  });
+
+  it('renders with provided account statuses', () => {
+    render(
+      <ListItemStatus
+        account={{ generated_status: 'success', uploaded_status: 'running' }}
+      />
+    );
+    expect(screen.getByText('Generated')).toBeTruthy();
+    expect(screen.getByText('Uploaded')).toBeTruthy();
+  });
 });

data/webpack/ForemanInventoryUpload/Components/AccountList/__tests__/AccountList.test.js

@@ -1,14 +1,38 @@
-import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
-
+import React from 'react';
+import { render, screen } from '@testing-library/react';
 import AccountList from '../AccountList';
-import { props } from '../AccountList.fixtures';
+import { accounts } from '../AccountList.fixtures';
 
-const fixtures = {
-  'render with props': props,
-  'show empty results': { ...props, filterTerm: 'not_matching_term' },
-};
+jest.mock('../Components/ListItem', () => ({ label }) => (
+  <div>{label}</div>
+));
 
 describe('AccountList', () => {
-  describe('rendering', () =>
-    testComponentSnapshotsWithFixtures(AccountList, fixtures));
+  it('renders account labels', () => {
+    render(<AccountList accounts={accounts} />);
+    Object.keys(accounts).forEach(label => {
+      expect(screen.getByText(label)).toBeTruthy();
+    });
+  });
+
+  it('shows empty results when filterTerm matches nothing', () => {
+    render(<AccountList accounts={accounts} filterTerm="not_matching_term" />);
+    expect(
+      screen.getByText(
+        "Oops! Couldn't find organization that matches your query"
+      )
+    ).toBeTruthy();
+  });
+
+  it('shows empty state when accounts are empty', () => {
+    render(<AccountList accounts={{}} />);
+    expect(
+      screen.getByText('Fetching data about your accounts')
+    ).toBeTruthy();
+  });
+
+  it('shows error state when error is present', () => {
+    render(<AccountList accounts={{}} error="Server error" />);
+    expect(screen.getByText('Server error')).toBeTruthy();
+  });
 });

data/webpack/ForemanInventoryUpload/Components/AccountList/__tests__/AccountListReducer.test.js

@@ -1,5 +1,3 @@
-import { testReducerSnapshotWithFixtures } from '@theforeman/test';
-
 import {
   INVENTORY_ACCOUNT_STATUS_POLLING,
   INVENTORY_ACCOUNT_STATUS_POLLING_START,
@@ -14,45 +12,67 @@ import {
   accountID,
   processStatusName,
   pollingResponse,
+  accounts,
+  CloudConnectorStatus,
 } from '../AccountList.fixtures';
 
-const fixtures = {
-  'should return the initial state': {},
-  'should handle INVENTORY_ACCOUNT_STATUS_POLLING': {
-    action: {
+describe('AccountList reducer', () => {
+  it('returns the initial state', () => {
+    const state = reducer(undefined, { type: '@@INIT' });
+    expect(state.accounts).toEqual({});
+    expect(state.pollingProcessID).toBe(0);
+    expect(state.error).toBeNull();
+  });
+
+  it('handles INVENTORY_ACCOUNT_STATUS_POLLING', () => {
+    const state = reducer(undefined, {
       type: INVENTORY_ACCOUNT_STATUS_POLLING,
       payload: pollingResponse,
-    },
-  },
-  'should handle INVENTORY_ACCOUNT_STATUS_POLLING_ERROR': {
-    action: {
+    });
+    expect(state.accounts).toEqual(accounts);
+    expect(state.CloudConnectorStatus).toEqual(CloudConnectorStatus);
+    expect(state.error).toBeNull();
+  });
+
+  it('handles INVENTORY_ACCOUNT_STATUS_POLLING_ERROR', () => {
+    const state = reducer(undefined, {
       type: INVENTORY_ACCOUNT_STATUS_POLLING_ERROR,
       payload: { error },
-    },
-  },
-  'should handle INVENTORY_ACCOUNT_STATUS_POLLING_START': {
-    action: {
+    });
+    expect(state.accounts).toEqual({});
+    expect(state.error).toBe(error);
+  });
+
+  it('handles INVENTORY_ACCOUNT_STATUS_POLLING_START', () => {
+    const state = reducer(undefined, {
+      type: INVENTORY_ACCOUNT_STATUS_POLLING_START,
+      payload: { pollingProcessID },
+    });
+    expect(state.pollingProcessID).toBe(pollingProcessID);
+  });
+
+  it('handles INVENTORY_ACCOUNT_STATUS_POLLING_STOP (default case)', () => {
+    const prevState = reducer(undefined, {
       type: INVENTORY_ACCOUNT_STATUS_POLLING_START,
-      payload: {
-        pollingProcessID,
-      },
-    },
-  },
-  'should handle INVENTORY_ACCOUNT_STATUS_POLLING_STOP': {
-    action: {
+      payload: { pollingProcessID },
+    });
+    const state = reducer(prevState, {
       type: INVENTORY_ACCOUNT_STATUS_POLLING_STOP,
-    },
-  },
-  'should handle INVENTORY_PROCESS_RESTART': {
-    action: {
-      type: INVENTORY_PROCESS_RESTART,
-      payload: {
-        accountID,
-        processStatusName,
-      },
-    },
-  },
-};
+    });
+    expect(state.pollingProcessID).toBe(pollingProcessID);
+    expect(state.accounts).toEqual({});
+    expect(state.error).toBeNull();
+  });
 
-describe('AccountList reducer', () =>
-  testReducerSnapshotWithFixtures(reducer, fixtures));
+  it('handles INVENTORY_PROCESS_RESTART', () => {
+    const stateWithAccounts = reducer(undefined, {
+      type: INVENTORY_ACCOUNT_STATUS_POLLING,
+      payload: pollingResponse,
+    });
+    const state = reducer(stateWithAccounts, {
+      type: INVENTORY_PROCESS_RESTART,
+      payload: { accountID, processStatusName },
+    });
+    expect(state.accounts[accountID][processStatusName]).toBe('Restarting...');
+  });
+});

data/webpack/ForemanInventoryUpload/Components/FileDownload/__tests__/FileDownload.test.js

@@ -1,13 +1,17 @@
-import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
-
+import React from 'react';
+import { render, screen, fireEvent } from '@testing-library/react';
 import FileDownload from '../FileDownload';
 
-const fixtures = {
-  'render without Props': {},
-  /** fixtures, props for the component */
-};
-
 describe('FileDownload', () => {
-  describe('rendering', () =>
-    testComponentSnapshotsWithFixtures(FileDownload, fixtures));
+  it('renders the download button', () => {
+    render(<FileDownload />);
+    expect(screen.getByRole('button', { name: /Download Report/ })).toBeTruthy();
+  });
+
+  it('calls onClick when button is clicked', () => {
+    const onClick = jest.fn();
+    render(<FileDownload onClick={onClick} />);
+    fireEvent.click(screen.getByRole('button', { name: /Download Report/ }));
+    expect(onClick).toHaveBeenCalledTimes(1);
+  });
 });

data/webpack/ForemanInventoryUpload/Components/InventoryFilter/__tests__/InventoryFilter.test.js

@@ -1,20 +1,17 @@
-import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
-import { noop } from 'foremanReact/common/helpers';
-
+import React from 'react';
+import { render, screen } from '@testing-library/react';
 import InventoryFilter from '../InventoryFilter';
-import { filterTerm, organization } from '../InventoryFilter.fixtures';
 
-const fixtures = {
-  'render with props': {
-    handleFilterChange: noop,
-    handleFilterClear: noop,
-    filterTerm,
-    organization,
-  },
-  /** fixtures, props for the component */
-};
+jest.mock('foremanReact/Root/Context/ForemanContext');
 
 describe('InventoryFilter', () => {
-  describe('rendering', () =>
-    testComponentSnapshotsWithFixtures(InventoryFilter, fixtures));
+  it('renders the filter input', () => {
+    render(<InventoryFilter />);
+    expect(screen.getByPlaceholderText('Filter..')).toBeTruthy();
+  });
+
+  it('displays the current filter term', () => {
+    render(<InventoryFilter filterTerm="test-filter" />);
+    expect(screen.getByDisplayValue('test-filter')).toBeTruthy();
+  });
 });

data/webpack/ForemanInventoryUpload/Components/InventoryFilter/__tests__/integration.test.js

@@ -1,18 +1,38 @@
 import React from 'react';
-import { IntegrationTestHelper } from '@theforeman/test';
-import InventoryFilter from '../index';
-import reducers from '../../../../ForemanRhCloudReducers';
+import { render, screen, fireEvent } from '@testing-library/react';
+import { Provider } from 'react-redux';
+import configureMockStore from 'redux-mock-store';
+import thunk from 'redux-thunk';
+import ConnectedInventoryFilter from '../index';
+import { INVENTORY_FILTER_UPDATE } from '../InventoryFilterConstants';
+
+jest.mock('foremanReact/Root/Context/ForemanContext');
+
+const mockStore = configureMockStore([thunk]);
 
 describe('InventoryFilter integration test', () => {
-  it('should flow', async () => {
-    const integrationTestHelper = new IntegrationTestHelper(reducers);
-    const wrapper = integrationTestHelper.mount(<InventoryFilter />);
-    const input = wrapper.find('input[id="inventory_filter_input"]');
-    input.simulate('change', { target: { value: 'some_new_filter' } });
-    await IntegrationTestHelper.flushAllPromises();
-    wrapper.update();
-    integrationTestHelper.takeStoreAndLastActionSnapshot(
-      'filter have been updated'
+  it('dispatches filter update action on input change', () => {
+    const store = mockStore({
+      ForemanRhCloud: {
+        inventoryUpload: {
+          inventoryFilter: { filterTerm: '' },
+        },
+      },
+    });
+
+    render(
+      <Provider store={store}>
+        <ConnectedInventoryFilter />
+      </Provider>
+    );
+
+    const input = screen.getByPlaceholderText('Filter..');
+    fireEvent.change(input, { target: { value: 'some_new_filter' } });
+
+    const actions = store.getActions();
+    const filterAction = actions.find(
+      a => a.type === INVENTORY_FILTER_UPDATE && a.payload.filterTerm === 'some_new_filter'
     );
+    expect(filterAction).toBeTruthy();
   });
 });

data/webpack/ForemanInventoryUpload/Components/PageHeader/__tests__/PageTitle.test.js

@@ -1,12 +1,19 @@
-import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
-
+import React from 'react';
+import { render, screen } from '@testing-library/react';
 import PageTitle from '../PageTitle';
 
-const fixtures = {
-  'render without Props': {},
-};
+jest.mock('../components/CloudPingModal', () => () => (
+  <div data-testid="cloud-ping-modal">CloudPingModal</div>
+));
 
 describe('PageTitle', () => {
-  describe('rendering', () =>
-    testComponentSnapshotsWithFixtures(PageTitle, fixtures));
+  it('renders the page title', () => {
+    render(<PageTitle />);
+    expect(screen.getByText('Red Hat Inventory')).toBeTruthy();
+  });
+
+  it('renders the kebab dropdown', () => {
+    const { container } = render(<PageTitle />);
+    expect(container.querySelector('.title-dropdown')).toBeTruthy();
+  });
 });