foreman_rh_cloud 13.2.8 → 13.2.10

data/test/controllers/insights_cloud/ui_requests_controller_test.rb

@@ -177,8 +177,22 @@ module InsightsCloud
 
         get :forward_request, params: { "controller" => "vulnerabilities", "path" => "api/vulnerability/v1/cves" }, session: set_session
         assert_equal 500, @response.status
-        assert_equal 'Cloud request failed', JSON.parse(@response.body)['message']
-        assert_match(/#{@body}/, JSON.parse(@response.body)['response'])
+        assert_equal @body, @response.body
+      end
+
+      test "should forward JSON error responses without double-escaping" do
+        json_error = { errors: [{ detail: 'inventory_id must exist', status: '404' }] }.to_json
+        net_http_resp = Net::HTTPResponse.new(1.0, 404, "Not Found")
+        net_http_resp['content-type'] = 'application/json'
+        res = RestClient::Response.create(json_error, net_http_resp, @http_req)
+        ::ForemanRhCloud::InsightsApiForwarder.any_instance.stubs(:execute_cloud_request).raises(RestClient::NotFound.new(res))
+
+        get :forward_request, params: { "controller" => "vulnerabilities", "path" => "api/vulnerability/v1/systems/00000000-0000-0000-0000-000000000000" }, session: set_session
+        assert_equal 404, @response.status
+        assert_includes @response.content_type, 'application/json'
+        assert_equal json_error, @response.body
+        parsed = JSON.parse(@response.body)
+        assert_equal 'inventory_id must exist', parsed['errors'][0]['detail']
       end
 
       test "should allow forward_request with nil location (Any location)" do

data/test/jobs/insights_client_status_aging_test.rb

@@ -31,4 +31,44 @@ class InsightsClientStatusAgingTest < ActiveSupport::TestCase
     assert_equal InsightsClientReportStatus::NO_REPORT, @host3.get_status(InsightsClientReportStatus).status
     assert_equal InsightsClientReportStatus::NO_REPORT, @host4.get_status(InsightsClientReportStatus).status
   end
+
+  test 'aging job does not affect USER_OMITTED hosts' do
+    # Host 1: USER_OMITTED with old reported_at (should stay USER_OMITTED)
+    InsightsClientReportStatus.find_or_initialize_by(host_id: @host1.id).update(
+      status: InsightsClientReportStatus::USER_OMITTED,
+      reported_at: Time.now - InsightsClientReportStatus::REPORT_INTERVAL - 1.day
+    )
+
+    # Host 2: REPORTING with old reported_at (should change to NO_REPORT)
+    InsightsClientReportStatus.find_or_initialize_by(host_id: @host2.id).update(
+      status: InsightsClientReportStatus::REPORTING,
+      reported_at: Time.now - InsightsClientReportStatus::REPORT_INTERVAL - 1.day
+    )
+
+    # Host 3: USER_OMITTED with recent reported_at (should stay USER_OMITTED)
+    InsightsClientReportStatus.find_or_initialize_by(host_id: @host3.id).update(
+      status: InsightsClientReportStatus::USER_OMITTED,
+      reported_at: Time.now - 1.day
+    )
+
+    # Host 4: REPORTING with recent reported_at (should stay REPORTING)
+    InsightsClientReportStatus.find_or_initialize_by(host_id: @host4.id).update(
+      status: InsightsClientReportStatus::REPORTING,
+      reported_at: Time.now - 1.day
+    )
+
+    action = create_and_plan_action(InsightsCloud::Async::InsightsClientStatusAging)
+    run_action(action)
+
+    @hosts.each(&:reload)
+
+    assert_equal InsightsClientReportStatus::USER_OMITTED, @host1.get_status(InsightsClientReportStatus).status,
+      'USER_OMITTED host with old report should stay USER_OMITTED'
+    assert_equal InsightsClientReportStatus::NO_REPORT, @host2.get_status(InsightsClientReportStatus).status,
+      'REPORTING host with old report should change to NO_REPORT'
+    assert_equal InsightsClientReportStatus::USER_OMITTED, @host3.get_status(InsightsClientReportStatus).status,
+      'USER_OMITTED host with recent report should stay USER_OMITTED'
+    assert_equal InsightsClientReportStatus::REPORTING, @host4.get_status(InsightsClientReportStatus).status,
+      'REPORTING host with recent report should stay REPORTING'
+  end
 end

data/test/jobs/insights_generate_notifications_test.rb

@@ -0,0 +1,26 @@
+require 'test_plugin_helper'
+require 'foreman_tasks/test_helpers'
+
+class InsightsGenerateNotificationsTest < ActiveSupport::TestCase
+  include Dynflow::Testing::Factories
+
+  setup do
+    User.current = User.find_by(login: 'secret_admin')
+  end
+
+  test 'skips notifications when foreman_host is nil' do
+    ForemanRhCloud.stubs(:foreman_host).returns(nil)
+
+    # Ensure blueprint exists or create it
+    NotificationBlueprint.find_or_create_by(name: 'insights_satellite_hits') do |bp|
+      bp.message = 'Test message'
+      bp.level = 'info'
+      bp.expires_in = 7.days
+    end
+
+    plan = ForemanTasks.sync_task(InsightsCloud::Async::InsightsGenerateNotifications)
+
+    # Should not raise an error, task completes successfully
+    assert_includes ['success', 'stopped'], plan.state, "Task should complete without error"
+  end
+end

data/test/jobs/inventory_full_sync_test.rb

@@ -5,6 +5,7 @@ class InventoryFullSyncTest < ActiveSupport::TestCase
   include Dynflow::Testing::Factories
   include MockCerts
   include KatelloCVEHelper
+  include CandlepinIsolation
 
   setup do
     User.current = User.find_by(login: 'secret_admin')
@@ -313,4 +314,215 @@ class InventoryFullSyncTest < ActiveSupport::TestCase
 
     assert_nil InventorySync::InventoryStatus.where(host_id: @host3.id).first
   end
+
+  test 'user-omitted hosts get USER_OMITTED status' do
+    # Add parameter to exclude host1
+    @host1.host_parameters << HostParameter.create(
+      name: 'host_registration_insights_inventory',
+      value: 'false',
+      parameter_type: 'boolean'
+    )
+    @host1.save!
+
+    setup_certs_expectation do
+      InventorySync::Async::InventoryFullSync.any_instance.stubs(:candlepin_id_cert)
+    end
+    InventorySync::Async::InventoryFullSync.any_instance.expects(:query_inventory).returns(@inventory)
+    FactoryBot.create(:fact_value, fact_name: fact_names['virt::uuid'], value: '1234', host: @host2)
+
+    action = create_and_plan_action(InventorySync::Async::InventoryFullSync, @host1.organization)
+    run_action(action)
+
+    @host1.reload
+    @host2.reload
+
+    # Host1 should be USER_OMITTED
+    assert_equal InventorySync::InventoryStatus::USER_OMITTED,
+      InventorySync::InventoryStatus.where(host_id: @host1.id).first.status,
+      'Host with host_registration_insights_inventory=false should have USER_OMITTED status'
+
+    # Host2 should be SYNC
+    assert_equal InventorySync::InventoryStatus::SYNC,
+      InventorySync::InventoryStatus.where(host_id: @host2.id).first.status,
+      'Normal host should have SYNC status'
+  end
+
+  test 'user-omitted hosts are not marked as disconnected' do
+    # Add parameter to exclude host1
+    @host1.host_parameters << HostParameter.create(
+      name: 'host_registration_insights_inventory',
+      value: 'false',
+      parameter_type: 'boolean'
+    )
+    @host1.save!
+
+    # Host1 is not in the cloud inventory response
+    setup_certs_expectation do
+      InventorySync::Async::InventoryFullSync.any_instance.stubs(:candlepin_id_cert)
+    end
+    InventorySync::Async::InventoryFullSync.any_instance.expects(:query_inventory).returns(@inventory)
+    InventorySync::Async::InventoryFullSync.any_instance.expects(:affected_host_ids).returns([@host1.id, @host2.id])
+    FactoryBot.create(:fact_value, fact_name: fact_names['virt::uuid'], value: '1234', host: @host2)
+
+    action = create_and_plan_action(InventorySync::Async::InventoryFullSync, @host1.organization)
+    run_action(action)
+
+    @host1.reload
+
+    # Host1 should be USER_OMITTED, not DISCONNECT
+    assert_equal InventorySync::InventoryStatus::USER_OMITTED,
+      InventorySync::InventoryStatus.where(host_id: @host1.id).first.status,
+      'User-omitted host should have USER_OMITTED status even if not in cloud inventory'
+  end
+
+  test 'host_statuses output includes all three counts' do
+    # Create a mix of hosts with different statuses
+    # Host1: will be user-omitted
+    @host1.host_parameters << HostParameter.create(
+      name: 'host_registration_insights_inventory',
+      value: 'false',
+      parameter_type: 'boolean'
+    )
+    @host1.save!
+
+    # Host2: will be synced (in cloud inventory)
+    # Host3: will be disconnected (not in cloud inventory)
+
+    # Create inventory response with only host2 (exclude host1 and host3)
+    inventory_with_host2_only = @inventory.dup
+    inventory_with_host2_only['results'] = [@inventory['results'][0]] # Only host2
+    inventory_with_host2_only['total'] = 1
+    inventory_with_host2_only['count'] = 1
+
+    setup_certs_expectation do
+      InventorySync::Async::InventoryFullSync.any_instance.stubs(:candlepin_id_cert)
+    end
+    InventorySync::Async::InventoryFullSync.any_instance.expects(:query_inventory).returns(inventory_with_host2_only)
+    InventorySync::Async::InventoryFullSync.any_instance.expects(:affected_host_ids).returns([@host1.id, @host2.id, @host3.id])
+    FactoryBot.create(:fact_value, fact_name: fact_names['virt::uuid'], value: '1234', host: @host2)
+
+    action = create_and_plan_action(InventorySync::Async::InventoryFullSync, @host1.organization)
+    run_action(action)
+
+    # Verify the statuses were actually set correctly
+    @host1.reload
+    @host2.reload
+    @host3.reload
+
+    assert_equal InventorySync::InventoryStatus::USER_OMITTED,
+      InventorySync::InventoryStatus.where(host_id: @host1.id).first.status,
+      'Host with host_registration_insights_inventory=false should have USER_OMITTED status'
+    assert_equal InventorySync::InventoryStatus::SYNC,
+      InventorySync::InventoryStatus.where(host_id: @host2.id).first.status,
+      'Host in cloud inventory should have SYNC status'
+    assert_equal InventorySync::InventoryStatus::DISCONNECT,
+      InventorySync::InventoryStatus.where(host_id: @host3.id).first.status,
+      'Host not in cloud inventory and not user-omitted should have DISCONNECT status'
+  end
+
+  test 'user-omitted status respects parameter inheritance from hostgroup' do
+    # Create a hostgroup and assign it to host1
+    hostgroup = FactoryBot.create(:hostgroup)
+    hostgroup.organizations << @host1.organization
+    @host1.hostgroup = hostgroup
+    @host1.save!
+
+    # Set parameter at hostgroup level, not directly on host
+    # This verifies the fix that uses search_for instead of querying HostParameter directly
+    hostgroup.group_parameters << GroupParameter.create(
+      name: 'host_registration_insights_inventory',
+      value: 'false',
+      key_type: 'boolean'
+    )
+    hostgroup.save!
+
+    # Verify parameter is inherited (not set directly on host)
+    assert_nil @host1.parameters.find_by(name: 'host_registration_insights_inventory'),
+      'Test setup: parameter should not be set directly on host'
+    refute ::Foreman::Cast.to_bool(@host1.host_param('host_registration_insights_inventory')),
+      'Test setup: parameter should be inherited from hostgroup'
+
+    # Host2 remains normal (no parameter)
+    setup_certs_expectation do
+      InventorySync::Async::InventoryFullSync.any_instance.stubs(:candlepin_id_cert)
+    end
+    InventorySync::Async::InventoryFullSync.any_instance.expects(:query_inventory).returns(@inventory)
+    InventorySync::Async::InventoryFullSync.any_instance.expects(:affected_host_ids).returns([@host1.id, @host2.id])
+    FactoryBot.create(:fact_value, fact_name: fact_names['virt::uuid'], value: '1234', host: @host2)
+
+    action = create_and_plan_action(InventorySync::Async::InventoryFullSync, @host1.organization)
+    run_action(action)
+
+    @host1.reload
+    @host2.reload
+
+    # Host1 should be USER_OMITTED (inherited parameter from hostgroup)
+    host1_status = InventorySync::InventoryStatus.where(host_id: @host1.id).first
+    assert_not_nil host1_status, 'Host1 should have an inventory status'
+    assert_equal InventorySync::InventoryStatus::USER_OMITTED, host1_status.status,
+      'Host with inherited host_registration_insights_inventory=false should have USER_OMITTED status'
+
+    # Host2 should be SYNC
+    assert_equal InventorySync::InventoryStatus::SYNC,
+      InventorySync::InventoryStatus.where(host_id: @host2.id).first.status,
+      'Normal host should have SYNC status'
+  end
+
+  test 'user-omitted statuses are cleared before re-creating them to avoid silent create failures' do
+    # First sync: host1 is user-omitted
+    @host1.host_parameters << HostParameter.create(
+      name: 'host_registration_insights_inventory',
+      value: 'false',
+      parameter_type: 'boolean'
+    )
+    @host1.save!
+
+    setup_certs_expectation do
+      InventorySync::Async::InventoryFullSync.any_instance.stubs(:candlepin_id_cert)
+    end
+    InventorySync::Async::InventoryFullSync.any_instance.expects(:query_inventory).returns(@inventory).twice
+    InventorySync::Async::InventoryFullSync.any_instance.expects(:affected_host_ids).returns([@host1.id, @host2.id]).twice
+    FactoryBot.create(:fact_value, fact_name: fact_names['virt::uuid'], value: '1234', host: @host2)
+
+    # Run first sync
+    action = create_and_plan_action(InventorySync::Async::InventoryFullSync, @host1.organization)
+    run_action(action)
+
+    @host1.reload
+    initial_status = InventorySync::InventoryStatus.where(host_id: @host1.id).first
+    assert_equal InventorySync::InventoryStatus::USER_OMITTED, initial_status.status,
+      'Initial sync: host should be USER_OMITTED'
+    initial_status_id = initial_status.id
+
+    # Verify there's only one status record for host1
+    assert_equal 1, InventorySync::InventoryStatus.where(host_id: @host1.id).count,
+      'Should have exactly one status record after first sync'
+
+    # Run second sync (parameter still false)
+    # Without clearing old user_omitted statuses, the .create would silently fail
+    # with 'Host has already been taken' due to uniqueness constraint
+    setup_certs_expectation do
+      InventorySync::Async::InventoryFullSync.any_instance.stubs(:candlepin_id_cert)
+    end
+
+    action2 = create_and_plan_action(InventorySync::Async::InventoryFullSync, @host1.organization)
+    run_action(action2)
+
+    @host1.reload
+    final_status = InventorySync::InventoryStatus.where(host_id: @host1.id).first
+
+    # Verify status is still USER_OMITTED (not stale from first sync)
+    assert_equal InventorySync::InventoryStatus::USER_OMITTED, final_status.status,
+      'Status should be USER_OMITTED after second sync'
+
+    # Verify there's still only one status record (old one was deleted before creating new one)
+    assert_equal 1, InventorySync::InventoryStatus.where(host_id: @host1.id).count,
+      'Should have exactly one status record (old cleared before new created)'
+
+    # Verify the old status record was actually deleted and replaced with a new one
+    refute InventorySync::InventoryStatus.exists?(initial_status_id),
+      'Old status record should have been deleted before creating new one'
+    assert_not_equal initial_status_id, final_status.id,
+      'New status record should have different ID, proving old was deleted'
+  end
 end

data/test/jobs/inventory_self_host_sync_test.rb

@@ -106,4 +106,13 @@ class InventorySelfHostSyncTest < ActiveSupport::TestCase
 
     assert_equal @host1_inventory_id, @host1.insights.uuid
   end
+
+  test 'skips sync when foreman_host is nil' do
+    ForemanRhCloud.stubs(:foreman_host).returns(nil)
+
+    plan = ForemanTasks.sync_task(InventorySync::Async::InventorySelfHostSync)
+
+    # Task should be stopped (not executed) when host is nil, not failed
+    assert_equal 'stopped', plan.state
+  end
 end

data/test/models/insights_client_report_status_test.rb

@@ -72,4 +72,113 @@ class InsightsClientReportStatusTest < ActiveSupport::TestCase
 
     assert_equal HostStatus::Global::ERROR, @host.global_status
   end
+
+  test 'host with host_registration_insights parameter set to false gets USER_OMITTED status' do
+    @host.host_parameters << HostParameter.create(
+      name: 'host_registration_insights',
+      value: 'false',
+      parameter_type: 'boolean'
+    )
+    @host.save!
+
+    insights_status = @host.get_status(InsightsClientReportStatus)
+    insights_status.refresh!
+
+    assert_equal InsightsClientReportStatus::USER_OMITTED, insights_status.status
+    assert_equal HostStatus::Global::OK, insights_status.to_global
+  end
+
+  test 'USER_OMITTED status has correct label' do
+    insights_status = @host.get_status(InsightsClientReportStatus)
+    insights_status.status = InsightsClientReportStatus::USER_OMITTED
+    insights_status.save!
+
+    label = insights_status.to_label
+    assert_match(/host_registration_insights/, label)
+    assert_match(/false/, label)
+  end
+
+  test 'stale scope excludes USER_OMITTED hosts' do
+    host1 = FactoryBot.create(:host, :managed)
+    host2 = FactoryBot.create(:host, :managed)
+    host3 = FactoryBot.create(:host, :managed)
+
+    # Host 1: USER_OMITTED with old reported_at (should NOT be in stale scope)
+    status1 = host1.get_status(InsightsClientReportStatus)
+    status1.status = InsightsClientReportStatus::USER_OMITTED
+    status1.reported_at = Time.zone.now - InsightsClientReportStatus::REPORT_INTERVAL - 1.day
+    status1.save!
+
+    # Host 2: REPORTING with old reported_at (should be in stale scope)
+    status2 = host2.get_status(InsightsClientReportStatus)
+    status2.status = InsightsClientReportStatus::REPORTING
+    status2.reported_at = Time.zone.now - InsightsClientReportStatus::REPORT_INTERVAL - 1.day
+    status2.save!
+
+    # Host 3: NO_REPORT with old reported_at (should be in stale scope)
+    status3 = host3.get_status(InsightsClientReportStatus)
+    status3.status = InsightsClientReportStatus::NO_REPORT
+    status3.reported_at = Time.zone.now - InsightsClientReportStatus::REPORT_INTERVAL - 1.day
+    status3.save!
+
+    stale_statuses = InsightsClientReportStatus.stale
+    stale_host_ids = stale_statuses.pluck(:host_id)
+
+    assert_not_includes stale_host_ids, host1.id, 'USER_OMITTED host should not be in stale scope'
+    assert_includes stale_host_ids, host2.id, 'REPORTING host with old report should be in stale scope'
+    assert_includes stale_host_ids, host3.id, 'NO_REPORT host with old report should be in stale scope'
+  end
+
+  test 'USER_OMITTED status respects parameter inheritance from hostgroup' do
+    # Create a hostgroup with parameter = false
+    hostgroup = FactoryBot.create(:hostgroup)
+    hostgroup.group_parameters << GroupParameter.create(
+      name: 'host_registration_insights',
+      value: 'false',
+      key_type: 'boolean'
+    )
+    hostgroup.save!
+
+    @host.hostgroup = hostgroup
+    @host.save!
+
+    # Verify parameter is inherited (not set directly on host)
+    assert_nil @host.parameters.find_by(name: 'host_registration_insights'),
+      'Test setup: parameter should not be set directly on host'
+
+    insights_status = @host.get_status(InsightsClientReportStatus)
+    insights_status.refresh!
+
+    assert_equal InsightsClientReportStatus::USER_OMITTED, insights_status.status,
+      'Status should be USER_OMITTED when host_registration_insights=false is inherited from hostgroup'
+    assert_equal HostStatus::Global::OK, insights_status.to_global,
+      'USER_OMITTED status should not affect global status'
+  end
+
+  test 'host parameter overrides inherited parameter from hostgroup' do
+    # Create a hostgroup with parameter = false
+    hostgroup = FactoryBot.create(:hostgroup)
+    hostgroup.group_parameters << GroupParameter.create(
+      name: 'host_registration_insights',
+      value: 'false',
+      key_type: 'boolean'
+    )
+    hostgroup.save!
+
+    @host.hostgroup = hostgroup
+
+    # Override with host parameter = true
+    @host.host_parameters << HostParameter.create(
+      name: 'host_registration_insights',
+      value: 'true',
+      parameter_type: 'boolean'
+    )
+    @host.save!
+
+    insights_status = @host.get_status(InsightsClientReportStatus)
+    insights_status.refresh!
+
+    assert_not_equal InsightsClientReportStatus::USER_OMITTED, insights_status.status,
+      'Status should not be USER_OMITTED when host parameter overrides hostgroup parameter with true'
+  end
 end

data/test/models/inventory_sync/inventory_status_test.rb

@@ -0,0 +1,85 @@
+require 'test_plugin_helper'
+
+module InventorySync
+  class InventoryStatusTest < ActiveSupport::TestCase
+    setup do
+      @host = FactoryBot.create(:host, :managed)
+    end
+
+    test 'status constants are defined correctly' do
+      assert_equal 0, InventorySync::InventoryStatus::DISCONNECT
+      assert_equal 1, InventorySync::InventoryStatus::SYNC
+      assert_equal 2, InventorySync::InventoryStatus::USER_OMITTED
+    end
+
+    test 'to_global returns OK for USER_OMITTED status' do
+      status = @host.get_status(InventorySync::InventoryStatus)
+      status.status = InventorySync::InventoryStatus::USER_OMITTED
+      status.save!
+
+      assert_equal HostStatus::Global::OK, status.to_global
+    end
+
+    test 'to_global returns WARN for DISCONNECT status' do
+      status = @host.get_status(InventorySync::InventoryStatus)
+      status.status = InventorySync::InventoryStatus::DISCONNECT
+      status.save!
+
+      assert_equal HostStatus::Global::WARN, status.to_global
+    end
+
+    test 'to_global returns OK for SYNC status' do
+      status = @host.get_status(InventorySync::InventoryStatus)
+      status.status = InventorySync::InventoryStatus::SYNC
+      status.save!
+
+      assert_equal HostStatus::Global::OK, status.to_global
+    end
+
+    test 'to_label returns appropriate messages for each status' do
+      status = @host.get_status(InventorySync::InventoryStatus)
+
+      # Test DISCONNECT label
+      status.status = InventorySync::InventoryStatus::DISCONNECT
+      status.save!
+      label = status.to_label
+      assert_match(/not present/, label.downcase)
+      assert_match(/console\.redhat\.com/, label)
+
+      # Test SYNC label
+      status.status = InventorySync::InventoryStatus::SYNC
+      status.save!
+      label = status.to_label
+      assert_match(/uploaded.*present/, label.downcase)
+      assert_match(/console\.redhat\.com/, label)
+
+      # Test USER_OMITTED label
+      status.status = InventorySync::InventoryStatus::USER_OMITTED
+      status.save!
+      label = status.to_label
+      assert_match(/excluded/, label.downcase)
+      assert_match(/host parameter/, label.downcase)
+      assert_match(/console\.redhat\.com/, label)
+    end
+
+    test 'relevant? returns true in regular (non-IoP) mode' do
+      ForemanRhCloud.stubs(:with_iop_smart_proxy?).returns(false)
+
+      status = @host.get_status(InventorySync::InventoryStatus)
+      status.status = InventorySync::InventoryStatus::SYNC
+      status.save!
+
+      assert status.relevant?, 'Inventory status should be relevant in regular mode'
+    end
+
+    test 'relevant? returns false in IoP mode' do
+      ForemanRhCloud.stubs(:with_iop_smart_proxy?).returns(true)
+
+      status = @host.get_status(InventorySync::InventoryStatus)
+      status.status = InventorySync::InventoryStatus::SYNC
+      status.save!
+
+      refute status.relevant?, 'Inventory status should NOT be relevant in IoP mode'
+    end
+  end
+end

data/test/unit/foreman_rh_cloud_self_host_test.rb

@@ -2,8 +2,9 @@ require 'test_plugin_helper'
 
 class ForemanRhCloudSelfHostTest < ActiveSupport::TestCase
   setup do
-    # reset cached value
-    ForemanRhCloud.instance_variable_set(:@foreman_host, nil)
+    # reset cached value - must remove the variable entirely, not just set to nil
+    ForemanRhCloud.remove_instance_variable(:@foreman_host) if ForemanRhCloud.instance_variable_defined?(:@foreman_host)
+    ENV.delete('SATELLITE_RH_CLOUD_FOREMAN_HOST')
   end
 
   test 'finds host by fullname' do
@@ -32,4 +33,51 @@ class ForemanRhCloudSelfHostTest < ActiveSupport::TestCase
 
     assert_equal @host, actual
   end
+
+  test 'returns nil when host does not exist' do
+    ForemanRhCloud.expects(:foreman_host_name).returns('nonexistent.example.com')
+
+    actual = ForemanRhCloud.foreman_host
+
+    assert_nil actual
+  end
+
+  test 'returns nil and does not query Host when foreman_host_name is nil' do
+    ForemanRhCloud.stubs(:foreman_host_name).returns(nil)
+    ::Host.unscoped.friendly.expects(:where).never
+
+    assert_nil ForemanRhCloud.foreman_host
+  end
+
+  test 'caches nil value to avoid repeated lookups' do
+    ForemanRhCloud.expects(:foreman_host_name).once.returns('nonexistent.example.com')
+
+    2.times { ForemanRhCloud.foreman_host }
+  end
+
+  test 'extracts hostname from foreman_url setting' do
+    Setting[:foreman_url] = 'https://satellite.example.com'
+
+    actual = ForemanRhCloud.foreman_url_hostname
+
+    assert_equal 'satellite.example.com', actual
+  end
+
+  test 'handles invalid foreman_url gracefully' do
+    # Stub Setting to return invalid URL without validation
+    Setting.stubs(:[]).with(:foreman_url).returns('not a valid url')
+
+    actual = ForemanRhCloud.foreman_url_hostname
+
+    assert_nil actual
+  end
+
+  test 'foreman_host_name uses foreman_url when marked_foreman_host is nil' do
+    ForemanRhCloud.expects(:marked_foreman_host).returns(nil)
+    ForemanRhCloud.expects(:foreman_url_hostname).returns('satellite.example.com')
+
+    actual = ForemanRhCloud.foreman_host_name
+
+    assert_equal 'satellite.example.com', actual
+  end
 end

data/test/unit/metadata_generator_test.rb

@@ -2,7 +2,8 @@ require 'test_plugin_helper'
 
 class MetadataGeneratorTest < ActiveSupport::TestCase
   setup do
-    ForemanRhCloud.instance_variable_set(:@foreman_host, nil)
+    # reset cached value - must remove the variable entirely, not just set to nil
+    ForemanRhCloud.remove_instance_variable(:@foreman_host) if ForemanRhCloud.instance_variable_defined?(:@foreman_host)
   end
 
   test 'generates an empty report' do
@@ -64,4 +65,26 @@ class MetadataGeneratorTest < ActiveSupport::TestCase
     assert_not_nil(slice = slices['test_12345'])
     assert_equal 3, slice['number_hosts']
   end
+
+  test 'generates metadata when foreman_host is nil' do
+    ForemanRhCloud.stubs(:foreman_host).returns(nil)
+    ForemanRhCloud.stubs(:foreman_host_name).returns('satellite.example.com')
+
+    generator = ForemanInventoryUpload::Generators::Metadata.new
+
+    # Should not raise an error
+    json_str = nil
+    assert_nothing_raised do
+      json_str = generator.render do
+      end
+    end
+
+    # Verify hostname is from foreman_host_name
+    actual = JSON.parse(json_str.join("\n"))
+    assert_equal 'satellite.example.com', actual['reporting_host_name']
+    # Verify IP and BIOS UUID fields are nil when host is nil
+    # This is acceptable per SAT-25889 - cloud services don't rely on these fields
+    assert_nil actual['reporting_host_ips']
+    assert_nil actual['reporting_host_bios_uuid']
+  end
 end