foreman_rh_cloud 13.2.11 → 14.0.1

data/webpack/CVEsHostDetailsTab/CVEsHostDetailsTab.js

@@ -3,10 +3,6 @@ import PropTypes from 'prop-types';
 import { ScalprumComponent, ScalprumProvider } from '@scalprum/react-core';
 import { createProviderOptions } from '../common/ScalprumModule/ScalprumContext';
 import { useInsightsPermissions } from '../common/Hooks/PermissionsHooks';
-import {
-  vulnerabilityDisabled,
-  useTabRedirect,
-} from '../ForemanRhCloudHelpers';
 import './CVEsHostDetailsTab.scss';
 
 const CVEsHostDetailsTab = ({ systemId }) => {
@@ -14,12 +10,7 @@ const CVEsHostDetailsTab = ({ systemId }) => {
   const module = './SystemDetailTable';
   return (
     <div className="rh-cloud-insights-vulnerability-host-details-component vulnerability">
-      <ScalprumComponent
-        key={systemId}
-        scope={scope}
-        module={module}
-        systemId={systemId}
-      />
+      <ScalprumComponent scope={scope} module={module} systemId={systemId} />
     </div>
   );
 };
@@ -30,15 +21,6 @@ CVEsHostDetailsTab.propTypes = {
 
 const CVEsHostDetailsTabWrapper = ({ response }) => {
   const permissions = useInsightsPermissions();
-  const isHostDataLoaded = Boolean(response?.id);
-  const shouldHideTab = useTabRedirect(
-    isHostDataLoaded && vulnerabilityDisabled({ hostDetails: response })
-  );
-
-  if (shouldHideTab) {
-    return null;
-  }
-
   return (
     <ScalprumProvider {...createProviderOptions(permissions)}>
       <CVEsHostDetailsTab
@@ -51,19 +33,10 @@ const CVEsHostDetailsTabWrapper = ({ response }) => {
 
 CVEsHostDetailsTabWrapper.propTypes = {
   response: PropTypes.shape({
-    id: PropTypes.number,
-    operatingsystem_name: PropTypes.string,
-    vulnerability: PropTypes.shape({
-      enabled: PropTypes.bool,
-    }),
     subscription_facet_attributes: PropTypes.shape({
-      uuid: PropTypes.string,
+      uuid: PropTypes.string.isRequired,
     }),
-  }),
-};
-
-CVEsHostDetailsTabWrapper.defaultProps = {
-  response: {},
+  }).isRequired,
 };
 
 export default CVEsHostDetailsTabWrapper;

data/webpack/CVEsHostDetailsTab/__tests__/CVEsHostDetailsTab.test.js

@@ -1,17 +1,6 @@
 import React from 'react';
 import { render } from '@testing-library/react';
-import { MemoryRouter } from 'react-router-dom';
 import CVEsHostDetailsTabWrapper from '../CVEsHostDetailsTab';
-import { OVERVIEW_TAB_PATH } from '../../ForemanRhCloudHelpers';
-
-const mockHistoryReplace = jest.fn();
-
-jest.mock('react-router-dom', () => ({
-  ...jest.requireActual('react-router-dom'),
-  useHistory: () => ({
-    replace: mockHistoryReplace,
-  }),
-}));
 
 jest.mock('foremanReact/Root/Context/ForemanContext', () => ({
   useForemanContext: () => ({
@@ -22,115 +11,24 @@ jest.mock('foremanReact/Root/Context/ForemanContext', () => ({
   useForemanPermissions: () => new Set(['view_vulnerability']),
 }));
 
-const mockUnmountTracker = jest.fn();
-jest.mock('@scalprum/react-core', () => {
-  const ReactMock = require('react');
-  return {
-    ScalprumComponent: jest.fn(props => {
-      ReactMock.useEffect(() => mockUnmountTracker, []);
-      return (
-        <div data-testid="mock-scalprum-component">{JSON.stringify(props)}</div>
-      );
-    }),
-    ScalprumProvider: jest.fn(({ children }) => <div>{children}</div>),
-  };
-});
-
-const defaultResponse = {
-  id: 1,
-  operatingsystem_name: 'Red Hat Enterprise Linux 8',
-  vulnerability: { enabled: true },
-  subscription_facet_attributes: { uuid: '1-2-3' },
-};
+jest.mock('@scalprum/react-core', () => ({
+  ScalprumComponent: jest.fn(props => (
+    <div data-testid="mock-scalprum-component">{JSON.stringify(props)}</div>
+  )),
+  ScalprumProvider: jest.fn(({ children }) => <div>{children}</div>),
+}));
 
 describe('CVEsHostDetailsTabWrapper', () => {
-  beforeEach(() => {
-    jest.clearAllMocks();
-  });
-
-  it('renders without crashing and does not redirect for valid host', () => {
+  it('renders without crashing', () => {
     const { container } = render(
-      <MemoryRouter>
-        <CVEsHostDetailsTabWrapper response={defaultResponse} />
-      </MemoryRouter>
+      <CVEsHostDetailsTabWrapper
+        response={{ subscription_facet_attributes: { uuid: '1-2-3' } }}
+      />
     );
     expect(
       container.querySelector(
         '.rh-cloud-insights-vulnerability-host-details-component'
       )
     ).toBeTruthy();
-    expect(mockHistoryReplace).not.toHaveBeenCalled();
-  });
-
-  it('remounts ScalprumComponent when systemId changes', () => {
-    const { ScalprumComponent } = require('@scalprum/react-core');
-
-    const responseHostA = {
-      ...defaultResponse,
-      subscription_facet_attributes: { uuid: 'uuid-host-A' },
-    };
-
-    const { rerender } = render(
-      <MemoryRouter>
-        <CVEsHostDetailsTabWrapper response={responseHostA} />
-      </MemoryRouter>
-    );
-
-    expect(mockUnmountTracker).not.toHaveBeenCalled();
-    expect(ScalprumComponent).toHaveBeenLastCalledWith(
-      expect.objectContaining({ systemId: 'uuid-host-A' }),
-      expect.anything()
-    );
-
-    const responseHostB = {
-      ...defaultResponse,
-      subscription_facet_attributes: { uuid: 'uuid-host-B' },
-    };
-
-    rerender(
-      <MemoryRouter>
-        <CVEsHostDetailsTabWrapper response={responseHostB} />
-      </MemoryRouter>
-    );
-
-    expect(mockUnmountTracker).toHaveBeenCalledTimes(1);
-    expect(ScalprumComponent).toHaveBeenLastCalledWith(
-      expect.objectContaining({ systemId: 'uuid-host-B' }),
-      expect.anything()
-    );
-  });
-
-  it('redirects to Overview when tab should be hidden', () => {
-    const nonRhelResponse = {
-      id: 2,
-      operatingsystem_name: 'Ubuntu 20.04',
-      vulnerability: { enabled: false },
-      subscription_facet_attributes: { uuid: '1-2-3' },
-    };
-
-    const { container } = render(
-      <MemoryRouter>
-        <CVEsHostDetailsTabWrapper response={nonRhelResponse} />
-      </MemoryRouter>
-    );
-
-    expect(mockHistoryReplace).toHaveBeenCalledWith(OVERVIEW_TAB_PATH);
-    expect(
-      container.querySelector(
-        '.rh-cloud-insights-vulnerability-host-details-component'
-      )
-    ).toBeNull();
-  });
-
-  it('does not redirect when host data is not yet loaded', () => {
-    const emptyResponse = { subscription_facet_attributes: { uuid: '1-2-3' } };
-
-    render(
-      <MemoryRouter>
-        <CVEsHostDetailsTabWrapper response={emptyResponse} />
-      </MemoryRouter>
-    );
-
-    expect(mockHistoryReplace).not.toHaveBeenCalled();
   });
 });

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/EmptyResults/__tests__/EmptyResults.test.js

@@ -1,14 +1,13 @@
-import React from 'react';
-import { render, screen } from '@testing-library/react';
+import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
+
 import EmptyResults from '../EmptyResults';
 
+const fixtures = {
+  'render without Props': {},
+  /** fixtures, props for the component */
+};
+
 describe('EmptyResults', () => {
-  it('renders the empty results message', () => {
-    render(<EmptyResults />);
-    expect(
-      screen.getByText(
-        "Oops! Couldn't find organization that matches your query"
-      )
-    ).toBeTruthy();
-  });
+  describe('rendering', () =>
+    testComponentSnapshotsWithFixtures(EmptyResults, fixtures));
 });

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/EmptyResults/__tests__/__snapshots__/EmptyResults.test.js.snap

@@ -0,0 +1,18 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`EmptyResults rendering render without Props 1`] = `
+<EmptyState
+  className=""
+>
+  <EmptyStateTitle
+    className=""
+  >
+    <Icon
+      className="no_results_icon"
+      name="meh-o"
+      type="fa"
+    />
+    Oops! Couldn't find organization that matches your query
+  </EmptyStateTitle>
+</EmptyState>
+`;

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/EmptyState/__tests__/EmptyState.test.js

@@ -1,17 +1,13 @@
-import React from 'react';
-import { render, screen } from '@testing-library/react';
+import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
+
 import EmptyState from '../EmptyState';
 
-describe('EmptyState', () => {
-  it('renders fetching data message', () => {
-    render(<EmptyState />);
-    expect(
-      screen.getByText('Fetching data about your accounts')
-    ).toBeTruthy();
-  });
+const fixtures = {
+  'render without Props': {},
+  /** fixtures, props for the component */
+};
 
-  it('renders loading indicator', () => {
-    render(<EmptyState />);
-    expect(screen.getByText('Loading...')).toBeTruthy();
-  });
+describe('EmptyState', () => {
+  describe('rendering', () =>
+    testComponentSnapshotsWithFixtures(EmptyState, fixtures));
 });

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/EmptyState/__tests__/__snapshots__/EmptyState.test.js.snap

@@ -0,0 +1,25 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`EmptyState rendering render without Props 1`] = `
+<EmptyState
+  className=""
+>
+  <Spinner
+    className=""
+    inline={true}
+    inverse={false}
+    loading={true}
+    size="lg"
+  />
+  <EmptyStateTitle
+    className=""
+  >
+    Fetching data about your accounts
+  </EmptyStateTitle>
+  <EmptyStateInfo
+    className=""
+  >
+    Loading...
+  </EmptyStateInfo>
+</EmptyState>
+`;

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/ErrorState/__tests__/ErrorState.test.js

@@ -1,24 +1,13 @@
-import React from 'react';
-import { render, screen } from '@testing-library/react';
-import ErrorState from '../ErrorState';
+import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
 
-describe('ErrorState', () => {
-  it('renders the error message heading', () => {
-    render(<ErrorState error="Something went wrong" />);
-    expect(
-      screen.getByText(
-        'Encountered an error while trying to access the server:'
-      )
-    ).toBeTruthy();
-  });
+import ErrorState from '../ErrorState';
 
-  it('renders the error description', () => {
-    render(<ErrorState error="Connection refused" />);
-    expect(screen.getByText('Connection refused')).toBeTruthy();
-  });
+const fixtures = {
+  'render without Props': {},
+  /** fixtures, props for the component */
+};
 
-  it('renders with empty error by default', () => {
-    const { container } = render(<ErrorState />);
-    expect(container.querySelector('.error_description')).toBeTruthy();
-  });
+describe('ErrorState', () => {
+  describe('rendering', () =>
+    testComponentSnapshotsWithFixtures(ErrorState, fixtures));
 });

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/ErrorState/__tests__/__snapshots__/ErrorState.test.js.snap

@@ -0,0 +1,20 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`ErrorState rendering render without Props 1`] = `
+<div
+  className="error_state"
+>
+  <Icon
+    className="error_icon"
+    name="times"
+    size="2x"
+    type="fa"
+  />
+  <p>
+    Encountered an error while trying to access the server:
+  </p>
+  <p
+    className="error_description"
+  />
+</div>
+`;

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/ListItem/__tests__/ListItem.test.js

@@ -1,36 +1,13 @@
-import React from 'react';
-import { render, screen } from '@testing-library/react';
-import { Accordion } from '@patternfly/react-core';
-import ListItem from '../ListItem';
+import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
 
-jest.mock('../../../../Dashboard', () => () => null);
+import ListItem from '../ListItem';
+import { props } from '../ListItem.fixtures';
 
-const renderListItem = props =>
-  render(
-    <Accordion>
-      <ListItem {...props} />
-    </Accordion>
-  );
+const fixtures = {
+  'render with Props': props,
+};
 
 describe('ListItem', () => {
-  const defaultProps = {
-    label: 'test-org',
-    account: {
-      generated_status: 'unknown',
-      uploaded_status: 'unknown',
-      id: 1,
-    },
-  };
-
-  it('renders the account label', () => {
-    renderListItem(defaultProps);
-    expect(screen.getByText('test-org')).toBeTruthy();
-  });
-
-  it('renders Generated and Uploaded status labels', () => {
-    renderListItem(defaultProps);
-    expect(screen.getByText('Generated')).toBeTruthy();
-    expect(screen.getByText('Uploaded')).toBeTruthy();
-  });
-
+  describe('rendering', () =>
+    testComponentSnapshotsWithFixtures(ListItem, fixtures));
 });

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/ListItem/__tests__/__snapshots__/ListItem.test.js.snap

@@ -0,0 +1,47 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`ListItem rendering render with Props 1`] = `
+<AccordionItem>
+  <AccordionToggle
+    isExpanded={false}
+    onClick={[Function]}
+  >
+    <span>
+      <Label
+        className="account-icon"
+        color="blue"
+        icon={<UserIcon />}
+        variant="outline"
+      />
+      test
+    </span>
+    <ListItemStatus
+      account={
+        Object {
+          "generated_status": "unknown",
+          "id": 1,
+          "report_file_paths": Array [],
+          "uploaded_status": "unknown",
+        }
+      }
+      key="test_status"
+    />
+  </AccordionToggle>
+  <AccordionContent
+    isHidden={true}
+  >
+    <Dashboard
+      account={
+        Object {
+          "generated_status": "unknown",
+          "id": 1,
+          "report_file_paths": Array [],
+          "uploaded_status": "unknown",
+        }
+      }
+      accountID={1}
+      onTaskStart={null}
+    />
+  </AccordionContent>
+</AccordionItem>
+`;

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/ListItemStatus/__tests__/ListItemStatus.test.js

@@ -1,30 +1,14 @@
-import React from 'react';
-import { render, screen } from '@testing-library/react';
-import ListItemStatus from '../ListItemStatus';
+import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
 
-describe('ListItemStatus', () => {
-  it('renders Generated and Uploaded labels', () => {
-    render(<ListItemStatus />);
-    expect(screen.getByText('Generated')).toBeTruthy();
-    expect(screen.getByText('Uploaded')).toBeTruthy();
-  });
+import ListItemStatus from '../ListItemStatus';
+import { props } from '../ListItemStatus.fixtures';
 
-  it('shows dash placeholders for unknown status', () => {
-    render(
-      <ListItemStatus
-        account={{ generated_status: 'unknown', uploaded_status: 'unknown' }}
-      />
-    );
-    expect(screen.getAllByText('--')).toHaveLength(2);
-  });
+const fixtures = {
+  'render without Props': {},
+  'render with Props': props,
+};
 
-  it('renders with provided account statuses', () => {
-    render(
-      <ListItemStatus
-        account={{ generated_status: 'success', uploaded_status: 'running' }}
-      />
-    );
-    expect(screen.getByText('Generated')).toBeTruthy();
-    expect(screen.getByText('Uploaded')).toBeTruthy();
-  });
+describe('ListItemStatus', () => {
+  describe('rendering', () =>
+    testComponentSnapshotsWithFixtures(ListItemStatus, fixtures));
 });

data/webpack/ForemanInventoryUpload/Components/AccountList/Components/ListItemStatus/__tests__/__snapshots__/ListItemStatus.test.js.snap

@@ -0,0 +1,59 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`ListItemStatus rendering render with Props 1`] = `
+<Grid
+  className="status"
+  hasGutter={true}
+>
+  <GridItem
+    className="item"
+    span={6}
+  >
+    <p>
+      Generated
+    </p>
+    <CheckIcon />
+  </GridItem>
+  <GridItem
+    className="item"
+    span={6}
+  >
+    <p>
+      Uploaded
+    </p>
+    <Spinner
+      size="sm"
+    />
+  </GridItem>
+</Grid>
+`;
+
+exports[`ListItemStatus rendering render without Props 1`] = `
+<Grid
+  className="status"
+  hasGutter={true}
+>
+  <GridItem
+    className="item"
+    span={6}
+  >
+    <p>
+      Generated
+    </p>
+    <span>
+      --
+    </span>
+  </GridItem>
+  <GridItem
+    className="item"
+    span={6}
+  >
+    <p>
+      Uploaded
+    </p>
+    <span>
+      --
+    </span>
+  </GridItem>
+</Grid>
+`;

data/webpack/ForemanInventoryUpload/Components/AccountList/__tests__/AccountList.test.js

@@ -1,38 +1,14 @@
-import React from 'react';
-import { render, screen } from '@testing-library/react';
+import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
+
 import AccountList from '../AccountList';
-import { accounts } from '../AccountList.fixtures';
+import { props } from '../AccountList.fixtures';
 
-jest.mock('../Components/ListItem', () => ({ label }) => (
-  <div>{label}</div>
-));
+const fixtures = {
+  'render with props': props,
+  'show empty results': { ...props, filterTerm: 'not_matching_term' },
+};
 
 describe('AccountList', () => {
-  it('renders account labels', () => {
-    render(<AccountList accounts={accounts} />);
-    Object.keys(accounts).forEach(label => {
-      expect(screen.getByText(label)).toBeTruthy();
-    });
-  });
-
-  it('shows empty results when filterTerm matches nothing', () => {
-    render(<AccountList accounts={accounts} filterTerm="not_matching_term" />);
-    expect(
-      screen.getByText(
-        "Oops! Couldn't find organization that matches your query"
-      )
-    ).toBeTruthy();
-  });
-
-  it('shows empty state when accounts are empty', () => {
-    render(<AccountList accounts={{}} />);
-    expect(
-      screen.getByText('Fetching data about your accounts')
-    ).toBeTruthy();
-  });
-
-  it('shows error state when error is present', () => {
-    render(<AccountList accounts={{}} error="Server error" />);
-    expect(screen.getByText('Server error')).toBeTruthy();
-  });
+  describe('rendering', () =>
+    testComponentSnapshotsWithFixtures(AccountList, fixtures));
 });

data/webpack/ForemanInventoryUpload/Components/AccountList/__tests__/AccountListActions.test.js

@@ -0,0 +1,34 @@
+import { testActionSnapshotWithFixtures } from '@theforeman/test';
+import { API } from 'foremanReact/redux/API';
+import {
+  fetchAccountsStatus,
+  startAccountStatusPolling,
+  stopAccountStatusPolling,
+  restartProcess,
+} from '../AccountListActions';
+import {
+  pollingProcessID,
+  fetchAccountsStatusResponse,
+} from '../AccountList.fixtures';
+import { accountID, activeTab } from '../../Dashboard/Dashboard.fixtures';
+
+jest.mock('foremanReact/redux/API');
+API.get.mockImplementation(async () => fetchAccountsStatusResponse);
+
+const fixtures = {
+  'should fetchAccountsStatus': () => fetchAccountsStatus(),
+  'should startAccountStatusPolling': () =>
+    startAccountStatusPolling(pollingProcessID),
+  'should stopAccountStatusPolling': () =>
+    stopAccountStatusPolling(pollingProcessID),
+  'should restartProcess': () => restartProcess(accountID, activeTab),
+  'should invoke toast notification upon failure': () => {
+    API.post.mockImplementationOnce(() =>
+      Promise.reject(new Error('test error'))
+    );
+
+    return restartProcess(accountID, activeTab);
+  },
+};
+
+describe('AccountList actions', () => testActionSnapshotWithFixtures(fixtures));

data/webpack/ForemanInventoryUpload/Components/AccountList/__tests__/AccountListIntegration.test.js

@@ -0,0 +1,14 @@
+import React from 'react';
+import { IntegrationTestHelper } from '@theforeman/test';
+
+import AccountList from '../index';
+import reducers from '../../../../ForemanRhCloudReducers';
+
+describe('AccountList integration test', () => {
+  it('should flow', async () => {
+    const integrationTestHelper = new IntegrationTestHelper(reducers);
+    const component = integrationTestHelper.mount(<AccountList />);
+    component.update();
+    /** Create a Flow test */
+  });
+});