foreman_rh_cloud 12.2.16 → 13.0.0

data/app/controllers/concerns/foreman_rh_cloud/registration_manager_extensions.rb

@@ -1,39 +0,0 @@
-module ForemanRhCloud
-  module RegistrationManagerExtensions
-    include ForemanRhCloud::CertAuth
-
-    def logger
-      Rails.logger
-    end
-
-    def unregister_host(host, options = {})
-      organization_destroy = options.fetch(:organization_destroy, false)
-
-      # Reload to ensure we have fresh association data
-      host.reload
-
-      # Only delete from HBI in IoP mode (hosted mode uses async job for cleanup)
-      hbi_host_destroy(host) if ForemanRhCloud.with_iop_smart_proxy? && !organization_destroy && host.insights_uuid.presence
-      host.insights&.destroy!
-      super(host, options)
-    end
-
-    def hbi_host_destroy(host)
-      uuid = host.insights_uuid
-      logger.debug "Unregistering host #{uuid} from HBI"
-      execute_cloud_request(
-        organization: host.organization,
-        method: :delete,
-        url: ForemanInventoryUpload.host_by_id_url(uuid),
-        headers: {
-          content_type: :json,
-        }
-      )
-    rescue RestClient::NotFound
-      Rails.logger.warn(_("Attempted to destroy HBI host %s, but host does not exist in HBI") % uuid)
-    rescue StandardError => e
-      # TODO: Improve error handling - don't break registration if HBI delete fails
-      Rails.logger.error(format(_("Failed to destroy HBI host %s: %s"), uuid, e.message))
-    end
-  end
-end

data/lib/foreman_inventory_upload/async/create_missing_insights_facets.rb

@@ -1,30 +0,0 @@
-module ForemanInventoryUpload
-  module Async
-    class CreateMissingInsightsFacets < ::Actions::EntryAction
-      def plan(organization_id)
-        plan_self(organization_id: organization_id)
-      end
-
-      def run
-        organization = ::Organization.find(input[:organization_id])
-        hosts_without_facets = ::ForemanInventoryUpload::Generators::Queries.for_org(organization, hosts_query: 'null? insights_uuid')
-        facet_count = 0
-        hosts_without_facets.each do |batch|
-          facets = batch.pluck(:id, 'katello_subscription_facets.uuid').map do |host_id, uuid|
-            {
-              host_id: host_id,
-              uuid: uuid,
-            }
-          end
-          # We don't need to validate the facets here as we create the necessary fields.
-          # rubocop:disable Rails/SkipsModelValidations
-          InsightsFacet.upsert_all(facets, unique_by: :host_id) unless facets.empty?
-          # rubocop:enable Rails/SkipsModelValidations
-          facet_count += facets.size
-        end
-        output[:result] = facet_count.zero? ? _("There were no missing Insights facets") : format(_("Missing Insights facets created: %s"), facet_count)
-        Rails.logger.debug output[:result]
-      end
-    end
-  end
-end

data/lib/foreman_inventory_upload/async/generate_host_report.rb

@@ -1,20 +0,0 @@
-module ForemanInventoryUpload
-  module Async
-    class GenerateHostReport < ::Actions::EntryAction
-      def plan(base_folder, organization_id, filter)
-        plan_self(
-          base_folder: base_folder,
-          organization_id: organization_id,
-          filter: filter
-        )
-        input[:target] = File.join(base_folder, ForemanInventoryUpload.facts_archive_name(input[:organization_id], input[:filter]))
-      end
-
-      def run
-        archived_report_generator = ForemanInventoryUpload::Generators::ArchivedReport.new(input[:target])
-        archived_report_generator.render(organization: input[:organization_id], filter: input[:filter])
-        output[:result] = "Generated #{input[:target]} for organization id #{input[:organization_id]}"
-      end
-    end
-  end
-end

data/lib/foreman_inventory_upload/async/host_inventory_report_job.rb

@@ -1,39 +0,0 @@
-module ForemanInventoryUpload
-  module Async
-    class HostInventoryReportJob < ::Actions::EntryAction
-      def plan(base_folder, organization_id, hosts_filter = "", upload = true)
-        sequence do
-          plan_action(
-            GenerateHostReport,
-            base_folder,
-            organization_id,
-            hosts_filter
-          )
-          if upload
-            plan_action(
-              QueueForUploadJob,
-              base_folder,
-              ForemanInventoryUpload.facts_archive_name(organization_id, hosts_filter),
-              organization_id
-            )
-          end
-
-          if ForemanRhCloud.with_iop_smart_proxy?
-            plan_action(
-              CreateMissingInsightsFacets,
-              organization_id
-            )
-          end
-        end
-      end
-
-      def humanized_name
-        _("Host inventory report job")
-      end
-
-      def organization_id
-        input[:organization_id]
-      end
-    end
-  end
-end

data/lib/foreman_inventory_upload/async/single_host_report_job.rb

@@ -1,20 +0,0 @@
-module ForemanInventoryUpload
-  module Async
-    class SingleHostReportJob < HostInventoryReportJob
-      def plan(base_folder, organization_id, host_id)
-        input[:host_id] = host_id
-        super(base_folder, organization_id, "id=#{input[:host_id]}")
-      end
-
-      def hostname(host_id)
-        host = ::Host.find_by(id: host_id)
-        host&.name
-      end
-
-      def humanized_name
-        hostname_result = hostname(input[:host_id])
-        hostname_result.present? ? format(_("Single-host report job for host %s"), hostname_result) : _("Single-host report job")
-      end
-    end
-  end
-end

data/lib/foreman_inventory_upload/async/upload_report_direct_job.rb

@@ -1,200 +0,0 @@
-require 'tempfile'
-require 'rest-client'
-
-module ForemanInventoryUpload
-  module Async
-    class UploadReportDirectJob < ::Actions::EntryAction
-      include AsyncHelpers
-      include ::ForemanRhCloud::Async::ExponentialBackoff
-      include ::ForemanRhCloud::CloudRequest
-
-      # Wrapper class to avoid monkey-patching File for multipart uploads
-      class FileUpload
-        attr_reader :file, :content_type
-
-        def initialize(file, content_type:)
-          @file = file
-          @content_type = content_type
-        end
-
-        def read(*args)
-          @file.read(*args)
-        end
-
-        def path
-          @file.path
-        end
-
-        def respond_to_missing?(method_name, include_private = false)
-          @file.respond_to?(method_name, include_private) || super
-        end
-
-        def method_missing(method_name, *args, &block)
-          if @file.respond_to?(method_name)
-            @file.send(method_name, *args, &block)
-          else
-            super
-          end
-        end
-      end
-
-      def self.output_label(label)
-        "upload_for_#{label}"
-      end
-
-      def plan(filename, organization_id)
-        # NOTE: This implementation assumes a single organization will not trigger multiple
-        # concurrent uploads. The instance_label is derived from organization_id alone, which
-        # means concurrent uploads for the same org would share ProgressOutput storage.
-        # This matches the pattern in GenerateReportJob. A full fix for thread-safety
-        # requires UI changes to display multiple concurrent tasks per org (tracked for PR #2).
-        label = UploadReportDirectJob.output_label(organization_id)
-        clear_task_output(label)
-        plan_self(
-          instance_label: label,
-          filename: filename,
-          organization_id: organization_id
-        )
-      end
-
-      def try_execute
-        if content_disconnected?
-          progress_output do |progress_output|
-            progress_output.write_line("Report was not moved and upload was canceled because connection to Insights is not enabled. Report location: #{filename}.")
-            progress_output.status = "Task aborted, exit 1"
-            done!
-          end
-          return
-        end
-
-        unless organization.owner_details&.dig('upstreamConsumer', 'idCert')
-          logger.info("Skipping organization '#{organization}', no candlepin certificate defined.")
-          progress_output do |progress_output|
-            progress_output.write_line("Skipping organization #{organization}, no candlepin certificate defined.")
-            progress_output.status = "Task aborted, exit 1"
-            done!
-          end
-          return
-        end
-
-        Tempfile.create([organization.name, '.pem']) do |cer_file|
-          cer_file.write(certificate[:cert])
-          cer_file.write(certificate[:key])
-          cer_file.flush
-          upload_report(cer_file.path)
-        end
-
-        done!
-      end
-
-      def upload_report(cer_path)
-        progress_output do |progress_output|
-          progress_output.write_line("Uploading report for organization #{organization.label}...")
-          progress_output.status = "Running upload"
-
-          begin
-            upload_file(cer_path)
-            progress_output.write_line("Upload completed successfully")
-            move_to_done_folder
-            progress_output.write_line("Uploaded file moved to done/ folder")
-            progress_output.status = "pid #{Process.pid} exit 0"
-          rescue StandardError => e
-            progress_output.write_line("Upload failed: #{e.message}")
-            progress_output.status = "pid #{Process.pid} exit 1"
-            raise
-          end
-        end
-      end
-
-      def upload_file(cer_path)
-        cert_content = File.read(cer_path)
-
-        File.open(filename, 'rb') do |file|
-          # Wrap file with FileUpload class for RestClient multipart handling
-          # RestClient requires objects with :read, :path, and :content_type methods
-          wrapped_file = FileUpload.new(file, content_type: 'application/vnd.redhat.qpc.tar+tgz')
-
-          response = execute_cloud_request(
-            method: :post,
-            url: ForemanInventoryUpload.upload_url,
-            payload: {
-              multipart: true,
-              file: wrapped_file,
-            },
-            headers: {
-              'X-Org-Id' => organization.label,
-            },
-            ssl_client_cert: OpenSSL::X509::Certificate.new(cert_content),
-            ssl_client_key: OpenSSL::PKey::RSA.new(cert_content),
-            timeout: 600,
-            open_timeout: 60
-          )
-
-          logger.debug("Upload response code: #{response.code}")
-        end
-      end
-
-      def move_to_done_folder
-        FileUtils.mkdir_p(ForemanInventoryUpload.done_folder)
-        done_file = ForemanInventoryUpload.done_file_path(File.basename(filename))
-        FileUtils.mv(filename, done_file)
-        logger.debug("Moved #{filename} to #{done_file}")
-      end
-
-      def certificate
-        ForemanRhCloud.with_iop_smart_proxy? ? foreman_certificate : manifest_certificate
-      end
-
-      def manifest_certificate
-        candlepin_id_certificate = organization.owner_details['upstreamConsumer']['idCert']
-        {
-          cert: candlepin_id_certificate['cert'],
-          key: candlepin_id_certificate['key'],
-        }
-      end
-
-      def foreman_certificate
-        {
-          cert: File.read(Setting[:ssl_certificate]),
-          key: File.read(Setting[:ssl_priv_key]),
-        }
-      end
-
-      def filename
-        input[:filename]
-      end
-
-      def organization
-        Organization.find(input[:organization_id])
-      end
-
-      def content_disconnected?
-        !Setting[:subscription_connection_enabled]
-      end
-
-      def progress_output
-        progress_output = ProgressOutput.register(instance_label)
-        yield(progress_output)
-      ensure
-        progress_output.close
-      end
-
-      def instance_label
-        input[:instance_label]
-      end
-
-      def logger
-        Foreman::Logging.logger('background')
-      end
-
-      def rescue_strategy_for_self
-        Dynflow::Action::Rescue::Fail
-      end
-
-      def clear_task_output(label)
-        TaskOutputLine.where(label: label).delete_all
-        TaskOutputStatus.where(label: label).delete_all
-      end
-    end
-  end
-end

data/test/jobs/create_missing_insights_facets_test.rb

@@ -1,151 +0,0 @@
-require 'test_plugin_helper'
-require 'foreman_tasks/test_helpers'
-
-class CreateMissingInsightsFacetsTest < ActiveSupport::TestCase
-  include Dynflow::Testing::Factories
-  include KatelloCVEHelper
-
-  setup do
-    User.current = User.find_by(login: 'secret_admin')
-    @cve = make_cve
-    @env = @cve.lifecycle_environment
-    @organization = @env.organization
-
-    # Create a host with subscription facet but no insights facet
-    @host_without_facet = FactoryBot.create(
-      :host,
-      :with_subscription,
-      :with_content,
-      content_view: @cve.content_view,
-      lifecycle_environment: @env,
-      organization: @organization
-    )
-
-    # Create a host with both subscription and insights facets
-    @host_with_facet = FactoryBot.create(
-      :host,
-      :with_subscription,
-      :with_content,
-      content_view: @cve.content_view,
-      lifecycle_environment: @env,
-      organization: @organization
-    )
-    @host_with_facet.build_insights(uuid: @host_with_facet.subscription_facet.uuid)
-    @host_with_facet.insights.save!
-  end
-
-  test 'creates insights facets for hosts without them' do
-    assert_nil @host_without_facet.insights
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::CreateMissingInsightsFacets,
-      @organization.id
-    )
-    action = run_action(action)
-
-    @host_without_facet.reload
-    assert_not_nil @host_without_facet.insights
-    assert_equal @host_without_facet.subscription_facet.uuid, @host_without_facet.insights.uuid
-    assert_match(/Missing Insights facets created: 1/, action.output[:result])
-  end
-
-  test 'does not create duplicate facets for hosts that already have them' do
-    original_uuid = @host_with_facet.insights.uuid
-    original_id = @host_with_facet.insights.id
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::CreateMissingInsightsFacets,
-      @organization.id
-    )
-    run_action(action)
-
-    @host_with_facet.reload
-    assert_equal original_id, @host_with_facet.insights.id
-    assert_equal original_uuid, @host_with_facet.insights.uuid
-  end
-
-  test 'handles organization with no missing facets' do
-    # Create insights facet for the host that was missing one
-    @host_without_facet.build_insights(uuid: @host_without_facet.subscription_facet.uuid)
-    @host_without_facet.insights.save!
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::CreateMissingInsightsFacets,
-      @organization.id
-    )
-    action = run_action(action)
-
-    assert_match(/There were no missing Insights facets/, action.output[:result])
-  end
-
-  test 'creates multiple facets when multiple hosts are missing them' do
-    # Remove the insights facet from the host that has one
-    @host_with_facet.insights.destroy
-    @host_with_facet.reload
-
-    assert_nil @host_without_facet.insights
-    assert_nil @host_with_facet.insights
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::CreateMissingInsightsFacets,
-      @organization.id
-    )
-    action = run_action(action)
-
-    @host_without_facet.reload
-    @host_with_facet.reload
-    assert_not_nil @host_without_facet.insights
-    assert_not_nil @host_with_facet.insights
-    # After the bug fix, the count should correctly show 2 hosts
-    assert_match(/Missing Insights facets created: 2/, action.output[:result])
-  end
-
-  test 'logs result message' do
-    Rails.logger.expects(:debug).with(regexp_matches(/Missing Insights facets created/))
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::CreateMissingInsightsFacets,
-      @organization.id
-    )
-    run_action(action)
-  end
-
-  test 'correctly counts facets across multiple batches' do
-    # Remove existing insights facet
-    @host_with_facet.insights.destroy
-    @host_with_facet.reload
-
-    # Stub the batch size to force multiple batches with just 2 hosts
-    ForemanInventoryUpload.stubs(:slice_size).returns(1)
-
-    assert_nil @host_without_facet.insights
-    assert_nil @host_with_facet.insights
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::CreateMissingInsightsFacets,
-      @organization.id
-    )
-    action = run_action(action)
-
-    @host_without_facet.reload
-    @host_with_facet.reload
-    assert_not_nil @host_without_facet.insights
-    assert_not_nil @host_with_facet.insights
-    # Count should be 2 even though processed in 2 separate batches
-    assert_match(/Missing Insights facets created: 2/, action.output[:result])
-  end
-
-  test 'handles error when InsightsFacet.upsert_all fails' do
-    # Stub upsert_all to raise an exception
-    InsightsFacet.stubs(:upsert_all).raises(StandardError.new('upsert failed'))
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::CreateMissingInsightsFacets,
-      @organization.id
-    )
-
-    assert_raises(StandardError) do
-      run_action(action)
-    end
-  end
-end

data/test/jobs/generate_host_report_test.rb

@@ -1,100 +0,0 @@
-require 'test_plugin_helper'
-require 'foreman_tasks/test_helpers'
-
-class GenerateHostReportTest < ActiveSupport::TestCase
-  include Dynflow::Testing::Factories
-  include FolderIsolation
-
-  let(:organization) { FactoryBot.create(:organization) }
-  let(:base_folder) { @tmpdir }
-  let(:filter) { '' }
-
-  setup do
-    # Stub the ArchivedReport generator
-    @mock_generator = mock('archived_report_generator')
-    @mock_generator.stubs(:render)
-    ForemanInventoryUpload::Generators::ArchivedReport.stubs(:new).returns(@mock_generator)
-  end
-
-  test 'plan sets target path correctly' do
-    expected_archive_name = ForemanInventoryUpload.facts_archive_name(organization.id, filter)
-    expected_target = File.join(base_folder, expected_archive_name)
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::GenerateHostReport,
-      base_folder,
-      organization.id,
-      filter
-    )
-
-    assert_equal expected_target, action.input[:target]
-  end
-
-  test 'run generates report archive' do
-    expected_target = File.join(base_folder, ForemanInventoryUpload.facts_archive_name(organization.id, filter))
-
-    ForemanInventoryUpload::Generators::ArchivedReport.expects(:new).with(expected_target).returns(@mock_generator)
-    @mock_generator.expects(:render).with(organization: organization.id, filter: filter)
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::GenerateHostReport,
-      base_folder,
-      organization.id,
-      filter
-    )
-    action = run_action(action)
-
-    assert_match(/Generated #{Regexp.escape(expected_target)} for organization id #{organization.id}/, action.output[:result])
-  end
-
-  test 'generates report with filter' do
-    filter_value = 'id=123'
-    expected_target = File.join(base_folder, ForemanInventoryUpload.facts_archive_name(organization.id, filter_value))
-
-    ForemanInventoryUpload::Generators::ArchivedReport.expects(:new).with(expected_target).returns(@mock_generator)
-    @mock_generator.expects(:render).with(organization: organization.id, filter: filter_value)
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::GenerateHostReport,
-      base_folder,
-      organization.id,
-      filter_value
-    )
-    action = run_action(action)
-
-    assert_match(/organization id #{organization.id}/, action.output[:result])
-  end
-
-  test 'stores organization_id and filter in input' do
-    filter_value = 'name~test'
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::GenerateHostReport,
-      base_folder,
-      organization.id,
-      filter_value
-    )
-
-    assert_equal organization.id, action.input[:organization_id]
-    assert_equal filter_value, action.input[:filter]
-    assert_equal base_folder, action.input[:base_folder]
-  end
-
-  test 'handles ArchivedReport generator failure' do
-    expected_target = File.join(base_folder, ForemanInventoryUpload.facts_archive_name(organization.id, filter))
-
-    ForemanInventoryUpload::Generators::ArchivedReport.expects(:new).with(expected_target).returns(@mock_generator)
-    @mock_generator.expects(:render).with(organization: organization.id, filter: filter).raises(StandardError.new('Report generation failed'))
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::GenerateHostReport,
-      base_folder,
-      organization.id,
-      filter
-    )
-
-    assert_raises(StandardError) do
-      run_action(action)
-    end
-  end
-end