foreman_rh_cloud 12.2.13 → 13.0.0

data/test/jobs/generate_report_job_test.rb

@@ -1,146 +0,0 @@
-require 'test_plugin_helper'
-require 'foreman_tasks/test_helpers'
-
-class GenerateReportJobTest < ActiveSupport::TestCase
-  include Dynflow::Testing::Factories
-  include Dynflow::Testing::Assertions
-
-  let(:organization) { FactoryBot.create(:organization) }
-  let(:base_folder) { Dir.mktmpdir }
-
-  setup do
-    # Stub settings
-    Setting.stubs(:[]).with(:subscription_connection_enabled).returns(true)
-    Setting.stubs(:[]).with("foreman_tasks_sync_task_timeout").returns(120)
-    Setting.stubs(:[]).with(:content_default_http_proxy).returns(nil)
-    Setting.stubs(:[]).with(:http_proxy).returns(nil)
-  end
-
-  teardown do
-    FileUtils.remove_entry base_folder if Dir.exist?(base_folder)
-  end
-
-  test 'disconnected parameter defaults to false' do
-    # When disconnected defaults to false and subscription_connection is enabled,
-    # QueueForUploadJob should be scheduled
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::GenerateReportJob,
-      base_folder,
-      organization.id
-    )
-
-    assert_action_planned(action, ForemanInventoryUpload::Async::QueueForUploadJob)
-  end
-
-  test 'disconnected parameter can be set to true explicitly' do
-    # When disconnected is explicitly true, QueueForUploadJob should NOT be scheduled
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::GenerateReportJob,
-      base_folder,
-      organization.id,
-      true
-    )
-
-    refute_action_planned(action, ForemanInventoryUpload::Async::QueueForUploadJob)
-  end
-
-  test 'disconnected parameter can be set to false explicitly' do
-    # When disconnected is explicitly false and subscription_connection is enabled,
-    # QueueForUploadJob should be scheduled
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::GenerateReportJob,
-      base_folder,
-      organization.id,
-      false
-    )
-
-    assert_action_planned(action, ForemanInventoryUpload::Async::QueueForUploadJob)
-  end
-
-  test 'skips upload when subscription_connection_enabled is false' do
-    Setting.stubs(:[]).with(:subscription_connection_enabled).returns(false)
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::GenerateReportJob,
-      base_folder,
-      organization.id,
-      false
-    )
-
-    refute_action_planned(action, ForemanInventoryUpload::Async::QueueForUploadJob)
-  end
-
-  test 'schedules upload when disconnected is false and subscription_connection is enabled' do
-    Setting.stubs(:[]).with(:subscription_connection_enabled).returns(true)
-
-    expected_archive_name = ForemanInventoryUpload.facts_archive_name(organization.id, nil)
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::GenerateReportJob,
-      base_folder,
-      organization.id,
-      false
-    )
-
-    assert_action_planned_with(
-      action,
-      ForemanInventoryUpload::Async::QueueForUploadJob,
-      base_folder,
-      expected_archive_name,
-      organization.id
-    )
-  end
-
-  test 'handles hosts_filter parameter' do
-    hosts_filter = 'name~test'
-    expected_archive_name = ForemanInventoryUpload.facts_archive_name(organization.id, hosts_filter)
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::GenerateReportJob,
-      base_folder,
-      organization.id,
-      false,
-      hosts_filter
-    )
-
-    assert_action_planned_with(
-      action,
-      ForemanInventoryUpload::Async::QueueForUploadJob,
-      base_folder,
-      expected_archive_name,
-      organization.id
-    )
-  end
-
-  test 'output_label generates correct label' do
-    label = ForemanInventoryUpload::Async::GenerateReportJob.output_label('test_org')
-    assert_equal 'report_for_test_org', label
-  end
-
-  test 'output_label with filter includes parameterized filter' do
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::GenerateReportJob,
-      base_folder,
-      organization.id,
-      false,
-      'name~production'
-    )
-
-    # The output label should include organization id and parameterized filter
-    expected_label = "report_for_#{organization.id}[name-production]"
-    assert_equal expected_label, action.input[:instance_label]
-  end
-
-  test 'output_label without filter includes only organization id' do
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::GenerateReportJob,
-      base_folder,
-      organization.id,
-      false,
-      ''
-    )
-
-    # The output label should include only organization id when filter is empty
-    expected_label = "report_for_#{organization.id}"
-    assert_equal expected_label, action.input[:instance_label]
-  end
-end

data/test/jobs/host_inventory_report_job_test.rb

@@ -1,244 +0,0 @@
-require 'test_plugin_helper'
-require 'foreman_tasks/test_helpers'
-
-class HostInventoryReportJobTest < ActiveSupport::TestCase
-  include Dynflow::Testing::Factories
-  include Dynflow::Testing::Assertions
-
-  let(:organization) { FactoryBot.create(:organization) }
-  let(:base_folder) { Dir.mktmpdir }
-  let(:hosts_filter) { '' }
-  let(:upload) { true }
-
-  teardown do
-    FileUtils.remove_entry base_folder if Dir.exist?(base_folder)
-  end
-
-  test 'plan schedules GenerateHostReport action' do
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::HostInventoryReportJob,
-      base_folder,
-      organization.id,
-      hosts_filter,
-      upload
-    )
-
-    assert_action_planned_with(
-      action,
-      ForemanInventoryUpload::Async::GenerateHostReport,
-      base_folder,
-      organization.id,
-      hosts_filter
-    )
-  end
-
-  test 'plan schedules QueueForUploadJob when upload is true' do
-    expected_archive_name = ForemanInventoryUpload.facts_archive_name(organization.id, hosts_filter)
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::HostInventoryReportJob,
-      base_folder,
-      organization.id,
-      hosts_filter,
-      true
-    )
-
-    assert_action_planned_with(
-      action,
-      ForemanInventoryUpload::Async::QueueForUploadJob,
-      base_folder,
-      expected_archive_name,
-      organization.id
-    )
-  end
-
-  test 'plan skips QueueForUploadJob when upload is false' do
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::HostInventoryReportJob,
-      base_folder,
-      organization.id,
-      hosts_filter,
-      false
-    )
-
-    refute_action_planned(action, ForemanInventoryUpload::Async::QueueForUploadJob)
-  end
-
-  test 'plan defaults upload to true when not specified' do
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::HostInventoryReportJob,
-      base_folder,
-      organization.id,
-      hosts_filter
-    )
-
-    assert_action_planned(action, ForemanInventoryUpload::Async::QueueForUploadJob)
-  end
-
-  test 'plan schedules CreateMissingInsightsFacets when IoP is enabled' do
-    ForemanRhCloud.stubs(:with_iop_smart_proxy?).returns(true)
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::HostInventoryReportJob,
-      base_folder,
-      organization.id,
-      hosts_filter,
-      upload
-    )
-
-    assert_action_planned_with(
-      action,
-      ForemanInventoryUpload::Async::CreateMissingInsightsFacets,
-      organization.id
-    )
-  end
-
-  test 'plan skips CreateMissingInsightsFacets when IoP is disabled' do
-    ForemanRhCloud.stubs(:with_iop_smart_proxy?).returns(false)
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::HostInventoryReportJob,
-      base_folder,
-      organization.id,
-      hosts_filter,
-      upload
-    )
-
-    refute_action_planned(action, ForemanInventoryUpload::Async::CreateMissingInsightsFacets)
-  end
-
-  test 'plan schedules all three actions with IoP enabled and upload true' do
-    ForemanRhCloud.stubs(:with_iop_smart_proxy?).returns(true)
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::HostInventoryReportJob,
-      base_folder,
-      organization.id,
-      hosts_filter,
-      true
-    )
-
-    assert_action_planned(action, ForemanInventoryUpload::Async::GenerateHostReport)
-    assert_action_planned(action, ForemanInventoryUpload::Async::QueueForUploadJob)
-    assert_action_planned(action, ForemanInventoryUpload::Async::CreateMissingInsightsFacets)
-  end
-
-  test 'plan schedules only generation and facets with IoP enabled and upload false' do
-    ForemanRhCloud.stubs(:with_iop_smart_proxy?).returns(true)
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::HostInventoryReportJob,
-      base_folder,
-      organization.id,
-      hosts_filter,
-      false
-    )
-
-    assert_action_planned(action, ForemanInventoryUpload::Async::GenerateHostReport)
-    refute_action_planned(action, ForemanInventoryUpload::Async::QueueForUploadJob)
-    assert_action_planned(action, ForemanInventoryUpload::Async::CreateMissingInsightsFacets)
-  end
-
-  test 'humanized_name returns correct string' do
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::HostInventoryReportJob,
-      base_folder,
-      organization.id,
-      hosts_filter,
-      upload
-    )
-
-    assert_equal 'Host inventory report job', action.humanized_name
-  end
-
-  test 'handles empty hosts_filter parameter' do
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::HostInventoryReportJob,
-      base_folder,
-      organization.id,
-      '',
-      upload
-    )
-
-    assert_action_planned_with(
-      action,
-      ForemanInventoryUpload::Async::GenerateHostReport,
-      base_folder,
-      organization.id,
-      ''
-    )
-  end
-
-  test 'handles custom hosts_filter parameter' do
-    custom_filter = 'name~production'
-    expected_archive_name = ForemanInventoryUpload.facts_archive_name(organization.id, custom_filter)
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::HostInventoryReportJob,
-      base_folder,
-      organization.id,
-      custom_filter,
-      upload
-    )
-
-    assert_action_planned_with(
-      action,
-      ForemanInventoryUpload::Async::GenerateHostReport,
-      base_folder,
-      organization.id,
-      custom_filter
-    )
-    assert_action_planned_with(
-      action,
-      ForemanInventoryUpload::Async::QueueForUploadJob,
-      base_folder,
-      expected_archive_name,
-      organization.id
-    )
-  end
-
-  test 'handles invalid hosts_filter parameter' do
-    invalid_filter = 'name~~'
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::HostInventoryReportJob,
-      base_folder,
-      organization.id,
-      invalid_filter,
-      upload
-    )
-
-    # Job should still plan even with invalid filter syntax
-    assert_action_planned(action, ForemanInventoryUpload::Async::GenerateHostReport)
-  end
-
-  test 'handles potentially malicious hosts_filter parameter' do
-    malicious_filter = "'; DROP TABLE hosts; --"
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::HostInventoryReportJob,
-      base_folder,
-      organization.id,
-      malicious_filter,
-      upload
-    )
-
-    # Job should handle malicious input safely (filter is parameterized)
-    assert_action_planned(action, ForemanInventoryUpload::Async::GenerateHostReport)
-  end
-
-  test 'handles non-matching hosts_filter parameter' do
-    non_matching_filter = 'name~doesnotexist'
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::HostInventoryReportJob,
-      base_folder,
-      organization.id,
-      non_matching_filter,
-      upload
-    )
-
-    # Job should plan successfully even if filter matches no hosts
-    assert_action_planned(action, ForemanInventoryUpload::Async::GenerateHostReport)
-  end
-end

data/test/jobs/queue_for_upload_job_test.rb

@@ -1,65 +0,0 @@
-require 'test_plugin_helper'
-require 'foreman_tasks/test_helpers'
-
-class QueueForUploadJobTest < ActiveSupport::TestCase
-  include Dynflow::Testing::Factories
-
-  let(:organization) { FactoryBot.create(:organization) }
-  let(:base_folder) { Dir.mktmpdir }
-  let(:report_file) { 'test_report.tar.xz' }
-  let(:report_path) { File.join(base_folder, report_file) }
-  let(:uploads_folder) { ForemanInventoryUpload.uploads_folder }
-
-  setup do
-    # Stub the script template source
-    script_source = File.join(ForemanRhCloud::Engine.root, 'lib/foreman_inventory_upload/scripts/uploader.sh.erb')
-    File.stubs(:read).with(script_source).returns('#!/bin/bash\necho "Test script"')
-
-    # Stub template rendering
-    Foreman::Renderer.stubs(:render).returns('#!/bin/bash\necho "Rendered script"')
-
-    # Stub additional settings that are accessed
-    Setting.stubs(:[]).with(:content_default_http_proxy).returns(nil)
-    Setting.stubs(:[]).with(:http_proxy).returns(nil)
-    Setting.stubs(:[]).with("foreman_tasks_sync_task_timeout").returns(120)
-    FileUtils.touch(report_path)
-  end
-
-  teardown do
-    FileUtils.rm_rf(uploads_folder) if Dir.exist?(uploads_folder)
-    FileUtils.remove_entry base_folder if Dir.exist?(base_folder)
-  end
-
-  test 'plan method sets up the job correctly and calls plan_upload_report' do
-    # Mock plan_upload_report to verify it's called
-    ForemanInventoryUpload::Async::QueueForUploadJob.any_instance.expects(:plan_upload_report).once
-
-    action = create_and_plan_action(ForemanInventoryUpload::Async::QueueForUploadJob, base_folder, report_file, organization.id)
-    run_action(action)
-  end
-
-  test 'run method processes file and moves it to uploads folder' do
-    ForemanInventoryUpload::Async::QueueForUploadJob.any_instance.stubs(:plan_upload_report)
-
-    action = create_and_plan_action(ForemanInventoryUpload::Async::QueueForUploadJob, base_folder, report_file, organization.id)
-    run_action(action)
-
-    # Verify the file was moved
-    refute File.exist?(report_path), "Original file should be moved"
-    assert File.exist?(File.join(uploads_folder, report_file)), "File should exist in uploads folder"
-  end
-
-  test 'creates necessary folders and scripts' do
-    ForemanInventoryUpload::Async::QueueForUploadJob.any_instance.stubs(:plan_upload_report)
-
-    action = create_and_plan_action(ForemanInventoryUpload::Async::QueueForUploadJob, base_folder, report_file, organization.id)
-    run_action(action)
-
-    # Verify the uploads folder was created
-    assert Dir.exist?(uploads_folder), "Uploads folder should be created"
-
-    # Verify the script file was created
-    script_path = File.join(uploads_folder, ForemanInventoryUpload.upload_script_file)
-    assert File.exist?(script_path), "Upload script should be created"
-  end
-end

data/test/jobs/single_host_report_job_test.rb

@@ -1,155 +0,0 @@
-require 'test_plugin_helper'
-require 'foreman_tasks/test_helpers'
-
-class SingleHostReportJobTest < ActiveSupport::TestCase
-  include Dynflow::Testing::Factories
-  include Dynflow::Testing::Assertions
-  include KatelloCVEHelper
-
-  let(:base_folder) { Dir.mktmpdir }
-
-  setup do
-    User.current = User.find_by(login: 'secret_admin')
-    cve = make_cve
-    env = cve.lifecycle_environment
-
-    @host = FactoryBot.create(
-      :host,
-      :with_subscription,
-      :with_content,
-      content_view: cve.content_view,
-      lifecycle_environment: env,
-      organization: env.organization
-    )
-  end
-
-  teardown do
-    FileUtils.remove_entry base_folder if Dir.exist?(base_folder)
-  end
-
-  test 'plan sets host_id in input' do
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::SingleHostReportJob,
-      base_folder,
-      @host.organization_id,
-      @host.id
-    )
-
-    assert_equal @host.id, action.input[:host_id]
-  end
-
-  test 'plan calls super with id filter' do
-    expected_filter = "id=#{@host.id}"
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::SingleHostReportJob,
-      base_folder,
-      @host.organization_id,
-      @host.id
-    )
-
-    assert_action_planned_with(
-      action,
-      ForemanInventoryUpload::Async::GenerateHostReport,
-      base_folder,
-      @host.organization_id,
-      expected_filter
-    )
-  end
-
-  test 'inherits behavior from HostInventoryReportJob' do
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::SingleHostReportJob,
-      base_folder,
-      @host.organization_id,
-      @host.id
-    )
-
-    # Should schedule all parent actions
-    assert_action_planned(action, ForemanInventoryUpload::Async::GenerateHostReport)
-    assert_action_planned(action, ForemanInventoryUpload::Async::QueueForUploadJob)
-  end
-
-  test 'humanized_name includes hostname' do
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::SingleHostReportJob,
-      base_folder,
-      @host.organization_id,
-      @host.id
-    )
-
-    assert_equal "Single-host report job for host #{@host.name}", action.humanized_name
-  end
-
-  test 'humanized_name handles missing host' do
-    non_existent_host_id = 999_999
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::SingleHostReportJob,
-      base_folder,
-      @host.organization_id,
-      non_existent_host_id
-    )
-
-    assert_equal 'Single-host report job', action.humanized_name
-  end
-
-  test 'hostname method returns correct name' do
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::SingleHostReportJob,
-      base_folder,
-      @host.organization_id,
-      @host.id
-    )
-
-    assert_equal @host.name, action.hostname(@host.id)
-  end
-
-  test 'hostname method handles nil gracefully' do
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::SingleHostReportJob,
-      base_folder,
-      @host.organization_id,
-      @host.id
-    )
-
-    assert_nil action.hostname(999_999)
-  end
-
-  test 'generates report with correct archive name for single host' do
-    expected_filter = "id=#{@host.id}"
-    expected_archive_name = ForemanInventoryUpload.facts_archive_name(@host.organization_id, expected_filter)
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::SingleHostReportJob,
-      base_folder,
-      @host.organization_id,
-      @host.id
-    )
-
-    assert_action_planned_with(
-      action,
-      ForemanInventoryUpload::Async::QueueForUploadJob,
-      base_folder,
-      expected_archive_name,
-      @host.organization_id
-    )
-  end
-
-  test 'respects IoP mode for facet creation' do
-    ForemanRhCloud.stubs(:with_iop_smart_proxy?).returns(true)
-
-    action = create_and_plan_action(
-      ForemanInventoryUpload::Async::SingleHostReportJob,
-      base_folder,
-      @host.organization_id,
-      @host.id
-    )
-
-    assert_action_planned_with(
-      action,
-      ForemanInventoryUpload::Async::CreateMissingInsightsFacets,
-      @host.organization_id
-    )
-  end
-end