foreman_remote_execution 4.6.0 → 5.0.1

data/webpack/JobWizard/steps/AdvancedFields/__tests__/__snapshots__/AdvancedFields.test.js.snap

@@ -1,249 +1,82 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`AdvancedFields rendring 1`] = `
-<Provider
-  store={
-    Object {
-      "clearActions": [Function],
-      "dispatch": [Function],
-      "getActions": [Function],
-      "getState": [Function],
-      "replaceReducer": [Function],
-      "subscribe": [Function],
-    }
-  }
->
-  <AdvancedFields
-    advancedValues={Object {}}
-    setAdvancedValues={[MockFunction]}
-  >
-    <Title
-      className="advanced-fields-title"
-      headingLevel="h2"
-    >
-      <h2
-        className="pf-c-title pf-m-xl advanced-fields-title"
-      >
-        Advanced Fields
-      </h2>
-    </Title>
-    <Form>
-      <form
-        className="pf-c-form"
-        noValidate={true}
-      >
-        <EffectiveUserField
-          setValue={[Function]}
-          value=""
-        >
-          <mockConstructor
-            fieldId="effective-user"
-            label="Effective user"
-            labelIcon={
-              <Popover
-                aria-label="help-text"
-                bodyContent="A user to be used for executing the script. If it differs from the SSH user, su or sudo is used to switch the accounts."
-                id="effective-user-help"
-              >
-                <button
-                  aria-label="open-help-tooltip-button"
-                  className="pf-c-form__group-label-help"
-                  onClick={[Function]}
-                >
-                  <HelpIcon
-                    color="currentColor"
-                    noVerticalAlign={true}
-                    size="sm"
-                  />
-                </button>
-              </Popover>
-            }
-          >
-            <div />
-          </mockConstructor>
-        </EffectiveUserField>
-        <TimeoutToKillField
-          setValue={[Function]}
-          value=""
-        >
-          <mockConstructor
-            fieldId="timeout-to-kill"
-            label="Timeout to kill"
-            labelIcon={
-              <Popover
-                aria-label="help-text"
-                bodyContent="Time in seconds from the start on the remote host after which the job should be killed."
-                id="timeout-to-kill-help"
-              >
-                <button
-                  aria-label="open-help-tooltip-button"
-                  className="pf-c-form__group-label-help"
-                  onClick={[Function]}
-                >
-                  <HelpIcon
-                    color="currentColor"
-                    noVerticalAlign={true}
-                    size="sm"
-                  />
-                </button>
-              </Popover>
-            }
-          >
-            <div />
-          </mockConstructor>
-        </TimeoutToKillField>
-        <PasswordField
-          setValue={[Function]}
-          value=""
-        >
-          <mockConstructor
-            fieldId="password"
-            label="Password"
-            labelIcon={
-              <Popover
-                aria-label="help-text"
-                bodyContent="Password is stored encrypted in DB until the job finishes. For future or recurring executions, it is removed after the last execution."
-                id="password-help"
-              >
-                <button
-                  aria-label="open-help-tooltip-button"
-                  className="pf-c-form__group-label-help"
-                  onClick={[Function]}
-                >
-                  <HelpIcon
-                    color="currentColor"
-                    noVerticalAlign={true}
-                    size="sm"
-                  />
-                </button>
-              </Popover>
-            }
-          >
-            <div />
-          </mockConstructor>
-        </PasswordField>
-        <KeyPassphraseField
-          setValue={[Function]}
-          value=""
-        >
-          <mockConstructor
-            fieldId="key-passphrase"
-            label="Private key passphrase"
-            labelIcon={
-              <Popover
-                aria-label="help-text"
-                bodyContent="Key passphrase is only applicable for SSH provider. Other providers ignore this field. Passphrase is stored encrypted in DB until the job finishes. For future or recurring executions, it is removed after the last execution."
-                id="key-passphrase-help"
-              >
-                <button
-                  aria-label="open-help-tooltip-button"
-                  className="pf-c-form__group-label-help"
-                  onClick={[Function]}
-                >
-                  <HelpIcon
-                    color="currentColor"
-                    noVerticalAlign={true}
-                    size="sm"
-                  />
-                </button>
-              </Popover>
-            }
-          >
-            <div />
-          </mockConstructor>
-        </KeyPassphraseField>
-        <EffectiveUserPasswordField
-          setValue={[Function]}
-          value=""
-        >
-          <mockConstructor
-            fieldId="effective-user-password"
-            label="Effective user password"
-            labelIcon={
-              <Popover
-                aria-label="help-text"
-                bodyContent="Effective user password is only applicable for SSH provider. Other providers ignore this field. Password is stored encrypted in DB until the job finishes. For future or recurring executions, it is removed after the last execution."
-                id="effective-user-password-help"
-              >
-                <button
-                  aria-label="open-help-tooltip-button"
-                  className="pf-c-form__group-label-help"
-                  onClick={[Function]}
-                >
-                  <HelpIcon
-                    color="currentColor"
-                    noVerticalAlign={true}
-                    size="sm"
-                  />
-                </button>
-              </Popover>
-            }
-          >
-            <div />
-          </mockConstructor>
-        </EffectiveUserPasswordField>
-        <ConcurrencyLevelField
-          setValue={[Function]}
-          value=""
-        >
-          <mockConstructor
-            fieldId="concurrency-level"
-            label="Concurrency level"
-            labelIcon={
-              <Popover
-                aria-label="help-text"
-                bodyContent="Run at most N tasks at a time. If this is set and proxy batch triggering is enabled, then tasks are triggered on the smart proxy in batches of size 1."
-                id="concurrency-level-help"
-              >
-                <button
-                  aria-label="open-help-tooltip-button"
-                  className="pf-c-form__group-label-help"
-                  onClick={[Function]}
-                >
-                  <HelpIcon
-                    color="currentColor"
-                    noVerticalAlign={true}
-                    size="sm"
-                  />
-                </button>
-              </Popover>
-            }
-          >
-            <div />
-          </mockConstructor>
-        </ConcurrencyLevelField>
-        <TimeSpanLevelField
-          setValue={[Function]}
-          value=""
-        >
-          <mockConstructor
-            fieldId="time-span"
-            label="Time span"
-            labelIcon={
-              <Popover
-                aria-label="help-text"
-                bodyContent="Distribute execution over N seconds. If this is set and proxy batch triggering is enabled, then tasks are triggered on the smart proxy in batches of size 1."
-                id="time-span-help"
-              >
-                <button
-                  aria-label="open-help-tooltip-button"
-                  className="pf-c-form__group-label-help"
-                  onClick={[Function]}
-                >
-                  <HelpIcon
-                    color="currentColor"
-                    noVerticalAlign={true}
-                    size="sm"
-                  />
-                </button>
-              </Popover>
-            }
-          >
-            <div />
-          </mockConstructor>
-        </TimeSpanLevelField>
-      </form>
-    </Form>
-  </AdvancedFields>
-</Provider>
+exports[`AdvancedFields search resources action: resource search 1`] = `
+Array [
+  Object {
+    "key": "JOB_CATEGORIES",
+    "type": "get",
+    "url": "/ui_job_wizard/categories",
+  },
+  Object {
+    "key": "JOB_TEMPLATES",
+    "type": "get",
+    "url": URI {
+      "_deferred_build": true,
+      "_parts": Object {
+        "duplicateQueryParameters": false,
+        "escapeQuerySpace": true,
+        "fragment": null,
+        "hostname": null,
+        "password": null,
+        "path": "foreman/api/v2/job_templates",
+        "port": null,
+        "preventInvalidHostname": false,
+        "protocol": null,
+        "query": "search=job_category%3D%22Ansible+Commands%22&per_page=all",
+        "urn": null,
+        "username": null,
+      },
+      "_string": "",
+    },
+  },
+  Object {
+    "key": "JOB_TEMPLATE",
+    "type": "get",
+    "url": "/ui_job_wizard/template/178",
+  },
+  Object {
+    "key": "ForemanTasksTask",
+    "type": "get",
+    "url": URI {
+      "_deferred_build": true,
+      "_parts": Object {
+        "duplicateQueryParameters": false,
+        "escapeQuerySpace": true,
+        "fragment": null,
+        "hostname": null,
+        "password": null,
+        "path": "/ui_job_wizard/resources",
+        "port": null,
+        "preventInvalidHostname": false,
+        "protocol": null,
+        "query": "resource=ForemanTasks%3A%3ATask&name=",
+        "urn": null,
+        "username": null,
+      },
+      "_string": "",
+    },
+  },
+  Object {
+    "key": "ForemanTasksTask",
+    "type": "get",
+    "url": URI {
+      "_deferred_build": true,
+      "_parts": Object {
+        "duplicateQueryParameters": false,
+        "escapeQuerySpace": true,
+        "fragment": null,
+        "hostname": null,
+        "password": null,
+        "path": "/ui_job_wizard/resources",
+        "port": null,
+        "preventInvalidHostname": false,
+        "protocol": null,
+        "query": "resource=ForemanTasks%3A%3ATask&name=some+search",
+        "urn": null,
+        "username": null,
+      },
+      "_string": "",
+    },
+  },
+]
 `;

data/webpack/JobWizard/steps/CategoryAndTemplate/CategoryAndTemplate.js

@@ -1,9 +1,11 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-import { Title, Text, TextVariants, Form, Alert } from '@patternfly/react-core';
+import { Text, TextVariants, Form, Alert } from '@patternfly/react-core';
 import { translate as __ } from 'foremanReact/common/I18n';
 import { SelectField } from '../form/SelectField';
 import { GroupedSelectField } from '../form/GroupedSelectField';
+import { WizardTitle } from '../form/WizardTitle';
+import { WIZARD_TITLES } from '../../JobWizardConstants';
 
 export const CategoryAndTemplate = ({
   jobCategories,
@@ -40,7 +42,7 @@ export const CategoryAndTemplate = ({
   const isError = !!(categoryError || allTemplatesError || templateError);
   return (
     <>
-      <Title headingLevel="h2">{__('Category and Template')}</Title>
+      <WizardTitle title={WIZARD_TITLES.categoryAndTemplate} />
       <Text component={TextVariants.p}>{__('All fields are required.')}</Text>
       <Form>
         <SelectField
@@ -51,6 +53,7 @@ export const CategoryAndTemplate = ({
           value={selectedCategory}
           placeholderText={categoryError ? __('Error') : ''}
           isDisabled={!!categoryError}
+          isRequired
         />
         <GroupedSelectField
           label={__('Job template')}

data/webpack/JobWizard/steps/CategoryAndTemplate/CategoryAndTemplate.test.js

@@ -1,52 +1,124 @@
-import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
-import { CategoryAndTemplate } from './CategoryAndTemplate';
-
-const baseProps = {
-  setJobTemplate: jest.fn(),
-  selectedTemplateID: 190,
-  setCategory: jest.fn(),
-};
-const fixtures = {
-  'renders with props': {
-    ...baseProps,
-    jobCategories: [
-      'Commands',
-      'Ansible Playbook',
-      'Ansible Galaxy',
-      'Ansible Roles Installation',
-    ],
-    jobTemplates: [
-      {
-        id: 190,
-        name: 'ab Run Command - SSH Default clone',
-        job_category: 'Commands',
-        provider_type: 'SSH',
-        snippet: false,
-      },
-      {
-        id: 168,
-        name: 'Ansible Roles - Ansible Default',
-        job_category: 'Ansible Playbook',
-        provider_type: 'Ansible',
-        snippet: false,
-      },
-      {
-        id: 170,
-        name: 'Ansible Roles - Install from git',
-        job_category: 'Ansible Roles Installation',
-        provider_type: 'Ansible',
-        snippet: false,
-      },
-    ],
-    selectedCategory: 'I am a category',
-  },
-  'render with error': {
-    ...baseProps,
-    errors: { allTemplatesError: 'I have an error' },
-  },
-};
-
-describe('CategoryAndTemplate', () => {
-  describe('rendering', () =>
-    testComponentSnapshotsWithFixtures(CategoryAndTemplate, fixtures));
+import React from 'react';
+import { Provider } from 'react-redux';
+import { fireEvent, screen, render, act } from '@testing-library/react';
+import * as api from 'foremanReact/redux/API';
+import { JobWizard } from '../../JobWizard';
+import * as selectors from '../../JobWizardSelectors';
+import { testSetup, mockApi } from '../../__tests__/fixtures';
+import { WIZARD_TITLES } from '../../JobWizardConstants';
+
+const store = testSetup(selectors, api);
+mockApi(api);
+jest.spyOn(selectors, 'selectCategoryError');
+jest.spyOn(selectors, 'selectAllTemplatesError');
+jest.spyOn(selectors, 'selectTemplateError');
+
+describe('Category And Template', () => {
+  it('should select ', async () => {
+    selectors.selectCategoryError.mockImplementation(() => null);
+    selectors.selectAllTemplatesError.mockImplementation(() => null);
+    selectors.selectTemplateError.mockImplementation(() => null);
+    render(
+      <Provider store={store}>
+        <JobWizard />
+      </Provider>
+    );
+
+    expect(screen.queryAllByLabelText('Error')).toHaveLength(0);
+    expect(screen.queryAllByLabelText('failed')).toHaveLength(0);
+    // Category
+    fireEvent.click(
+      screen.getByLabelText('Ansible Commands', { selector: 'button' })
+    );
+    await act(async () => {
+      await fireEvent.click(screen.getByText('Puppet'));
+    });
+    fireEvent.click(screen.getAllByText(WIZARD_TITLES.categoryAndTemplate)[0]); // to remove focus
+    expect(
+      screen.queryAllByLabelText('Ansible Commands', { selector: 'button' })
+    ).toHaveLength(0);
+    expect(
+      screen.queryAllByLabelText('Puppet', { selector: 'button' })
+    ).toHaveLength(1);
+
+    // Template
+    fireEvent.click(
+      screen.getByDisplayValue('template1', { selector: 'button' })
+    );
+    await act(async () => {
+      await fireEvent.click(screen.getByText('template2'));
+    });
+    fireEvent.click(screen.getAllByText(WIZARD_TITLES.categoryAndTemplate)[0]); // to remove focus
+    expect(
+      screen.queryAllByDisplayValue('template1', { selector: 'button' })
+    ).toHaveLength(0);
+    expect(
+      screen.queryAllByDisplayValue('template2', { selector: 'button' })
+    ).toHaveLength(1);
+  });
+  it('category error ', async () => {
+    selectors.selectCategoryError.mockImplementation(() => 'category error');
+    selectors.selectAllTemplatesError.mockImplementation(() => null);
+    selectors.selectTemplateError.mockImplementation(() => null);
+    render(
+      <Provider store={store}>
+        <JobWizard />
+      </Provider>
+    );
+
+    expect(
+      screen.queryAllByText('Categories list failed with:', { exact: false })
+    ).toHaveLength(1);
+
+    expect(
+      screen.queryAllByText('Templates list failed with:', { exact: false })
+    ).toHaveLength(0);
+    expect(
+      screen.queryAllByText('Template failed with:', { exact: false })
+    ).toHaveLength(0);
+  });
+  it('templates error ', async () => {
+    selectors.selectCategoryError.mockImplementation(() => null);
+    selectors.selectAllTemplatesError.mockImplementation(
+      () => 'templates error'
+    );
+    selectors.selectTemplateError.mockImplementation(() => null);
+    render(
+      <Provider store={store}>
+        <JobWizard />
+      </Provider>
+    );
+
+    expect(
+      screen.queryAllByText('Categories list failed with:', { exact: false })
+    ).toHaveLength(0);
+
+    expect(
+      screen.queryAllByText('Templates list failed with:', { exact: false })
+    ).toHaveLength(1);
+    expect(
+      screen.queryAllByText('Template failed with:', { exact: false })
+    ).toHaveLength(0);
+  });
+  it('template error ', async () => {
+    selectors.selectCategoryError.mockImplementation(() => null);
+    selectors.selectAllTemplatesError.mockImplementation(() => null);
+    selectors.selectTemplateError.mockImplementation(() => 'template error');
+    render(
+      <Provider store={store}>
+        <JobWizard />
+      </Provider>
+    );
+
+    expect(
+      screen.queryAllByText('Categories list failed with:', { exact: false })
+    ).toHaveLength(0);
+
+    expect(
+      screen.queryAllByText('Templates list failed with:', { exact: false })
+    ).toHaveLength(0);
+    expect(
+      screen.queryAllByText('Template failed with:', { exact: false })
+    ).toHaveLength(1);
+  });
 });

data/webpack/JobWizard/steps/CategoryAndTemplate/index.js

@@ -54,10 +54,11 @@ const ConnectedCategoryAndTemplate = ({
             search: `job_category="${category}"`,
             per_page: 'all',
           }),
-          handleSuccess: response =>
+          handleSuccess: response => {
             setJobTemplate(
               Number(filterJobTemplates(response?.data?.results)[0]?.id) || null
-            ),
+            );
+          },
         })
       );
     }

data/webpack/JobWizard/steps/HostsAndInputs/HostPreviewModal.js

@@ -0,0 +1,62 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+import { useSelector } from 'react-redux';
+import URI from 'urijs';
+import { List, ListItem, Modal, Button } from '@patternfly/react-core';
+import { translate as __, sprintf } from 'foremanReact/common/I18n';
+import { foremanUrl } from 'foremanReact/common/helpers';
+import { selectHosts, selectHostCount } from '../../JobWizardSelectors';
+import { HOSTS_TO_PREVIEW_AMOUNT } from '../../JobWizardConstants';
+
+export const HostPreviewModal = ({ isOpen, setIsOpen, searchQuery }) => {
+  const hosts = useSelector(selectHosts);
+  const hostsCount = useSelector(selectHostCount);
+  const url = new URI(foremanUrl('/hosts'));
+
+  return (
+    <Modal
+      title={__('Preview Hosts')}
+      isOpen={isOpen}
+      onClose={() => setIsOpen(false)}
+      appendTo={() => document.getElementsByClassName('job-wizard')[0]}
+    >
+      <List isPlain>
+        {hosts.map(host => (
+          <ListItem key={host}>
+            <Button
+              component="a"
+              href={foremanUrl(`/hosts/${host}`)}
+              variant="link"
+              target="_blank"
+              rel="noreferrer"
+            >
+              {host}
+            </Button>
+          </ListItem>
+        ))}
+        {hostsCount > HOSTS_TO_PREVIEW_AMOUNT && (
+          <ListItem>
+            <Button
+              component="a"
+              href={url.addSearch({ search: searchQuery })}
+              variant="link"
+              target="_blank"
+              rel="noreferrer"
+            >
+              {sprintf(
+                __('...and %s more'),
+                hostsCount - HOSTS_TO_PREVIEW_AMOUNT
+              )}
+            </Button>
+          </ListItem>
+        )}
+      </List>
+    </Modal>
+  );
+};
+
+HostPreviewModal.propTypes = {
+  isOpen: PropTypes.bool.isRequired,
+  setIsOpen: PropTypes.func.isRequired,
+  searchQuery: PropTypes.string.isRequired,
+};

data/webpack/JobWizard/steps/HostsAndInputs/HostSearch.js

@@ -0,0 +1,54 @@
+import React, { useEffect } from 'react';
+import { useSelector, useDispatch } from 'react-redux';
+import PropTypes from 'prop-types';
+import SearchBar from 'foremanReact/components/SearchBar';
+import { getControllerSearchProps } from 'foremanReact/constants';
+import { getResults } from 'foremanReact/components/AutoComplete/AutoCompleteActions';
+import { TRIGGERS } from 'foremanReact/components/AutoComplete/AutoCompleteConstants';
+import { hostsController, hostQuerySearchID } from '../../JobWizardConstants';
+import { noop } from '../../../helpers';
+
+export const HostSearch = ({ value, setValue }) => {
+  const searchQuery = useSelector(
+    state => state.autocomplete?.hostsSearch?.searchQuery
+  );
+  useEffect(() => {
+    setValue(searchQuery || '');
+  }, [setValue, searchQuery]);
+  const dispatch = useDispatch();
+  const setSearch = newSearchQuery => {
+    dispatch(
+      getResults({
+        url: '/hosts/auto_complete_search',
+        searchQuery: newSearchQuery,
+        controller: 'hostsController',
+        trigger: TRIGGERS.INPUT_CHANGE,
+        id: hostQuerySearchID,
+      })
+    );
+  };
+
+  const props = getControllerSearchProps(hostsController, hostQuerySearchID);
+  return (
+    <div className="foreman-search-field">
+      <SearchBar
+        data={{
+          ...props,
+          autocomplete: {
+            id: hostQuerySearchID,
+            url: '/hosts/auto_complete_search',
+            useKeyShortcuts: true,
+          },
+        }}
+        onSearch={noop}
+        initialQuery={value}
+        onBookmarkClick={search => setSearch(search)}
+      />
+    </div>
+  );
+};
+
+HostSearch.propTypes = {
+  value: PropTypes.string.isRequired,
+  setValue: PropTypes.func.isRequired,
+};