foreman_remote_execution 4.5.1 → 4.5.2

data/webpack/JobWizard/steps/AdvancedFields/__tests__/DescriptionField.test.js

@@ -0,0 +1,23 @@
+import React from 'react';
+import { mount } from '@theforeman/test';
+import { DescriptionField } from '../DescriptionField';
+
+describe('DescriptionField', () => {
+  it('rendring', () => {
+    const component = mount(
+      <DescriptionField
+        inputs={[{ name: 'command' }]}
+        value="Run %{command}"
+        setValue={jest.fn()}
+      />
+    );
+    const preview = component.find('#description-preview').hostNodes();
+    const findLink = () => component.find('.pf-m-link.pf-m-inline');
+    expect(findLink().text()).toEqual('Edit job description template');
+    expect(preview.props().value).toEqual('Run command');
+    findLink().simulate('click');
+    const description = component.find('#description').hostNodes();
+    expect(description.props().value).toEqual('Run %{command}');
+    expect(findLink().text()).toEqual('Preview job description');
+  });
+});

data/webpack/JobWizard/steps/CategoryAndTemplate/CategoryAndTemplate.test.js

@@ -1,52 +1,123 @@
-import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
-import { CategoryAndTemplate } from './CategoryAndTemplate';
-
-const baseProps = {
-  setJobTemplate: jest.fn(),
-  selectedTemplateID: 190,
-  setCategory: jest.fn(),
-};
-const fixtures = {
-  'renders with props': {
-    ...baseProps,
-    jobCategories: [
-      'Commands',
-      'Ansible Playbook',
-      'Ansible Galaxy',
-      'Ansible Roles Installation',
-    ],
-    jobTemplates: [
-      {
-        id: 190,
-        name: 'ab Run Command - SSH Default clone',
-        job_category: 'Commands',
-        provider_type: 'SSH',
-        snippet: false,
-      },
-      {
-        id: 168,
-        name: 'Ansible Roles - Ansible Default',
-        job_category: 'Ansible Playbook',
-        provider_type: 'Ansible',
-        snippet: false,
-      },
-      {
-        id: 170,
-        name: 'Ansible Roles - Install from git',
-        job_category: 'Ansible Roles Installation',
-        provider_type: 'Ansible',
-        snippet: false,
-      },
-    ],
-    selectedCategory: 'I am a category',
-  },
-  'render with error': {
-    ...baseProps,
-    errors: { allTemplatesError: 'I have an error' },
-  },
-};
-
-describe('CategoryAndTemplate', () => {
-  describe('rendering', () =>
-    testComponentSnapshotsWithFixtures(CategoryAndTemplate, fixtures));
+import React from 'react';
+import { Provider } from 'react-redux';
+import { fireEvent, screen, render, act } from '@testing-library/react';
+import * as api from 'foremanReact/redux/API';
+import { JobWizard } from '../../JobWizard';
+import * as selectors from '../../JobWizardSelectors';
+import { testSetup, mockApi } from '../../__tests__/fixtures';
+
+const store = testSetup(selectors, api);
+mockApi(api);
+jest.spyOn(selectors, 'selectCategoryError');
+jest.spyOn(selectors, 'selectAllTemplatesError');
+jest.spyOn(selectors, 'selectTemplateError');
+
+describe('Category And Template', () => {
+  it('should select ', async () => {
+    selectors.selectCategoryError.mockImplementation(() => null);
+    selectors.selectAllTemplatesError.mockImplementation(() => null);
+    selectors.selectTemplateError.mockImplementation(() => null);
+    render(
+      <Provider store={store}>
+        <JobWizard />
+      </Provider>
+    );
+
+    expect(screen.queryAllByLabelText('Error')).toHaveLength(0);
+    expect(screen.queryAllByLabelText('failed')).toHaveLength(0);
+    // Category
+    fireEvent.click(
+      screen.getByLabelText('Ansible Commands', { selector: 'button' })
+    );
+    await act(async () => {
+      await fireEvent.click(screen.getByText('Puppet'));
+    });
+    fireEvent.click(screen.getAllByText('Category and Template')[0]); // to remove focus
+    expect(
+      screen.queryAllByLabelText('Ansible Commands', { selector: 'button' })
+    ).toHaveLength(0);
+    expect(
+      screen.queryAllByLabelText('Puppet', { selector: 'button' })
+    ).toHaveLength(1);
+
+    // Template
+    fireEvent.click(
+      screen.getByDisplayValue('template1', { selector: 'button' })
+    );
+    await act(async () => {
+      await fireEvent.click(screen.getByText('template2'));
+    });
+    fireEvent.click(screen.getAllByText('Category and Template')[0]); // to remove focus
+    expect(
+      screen.queryAllByDisplayValue('template1', { selector: 'button' })
+    ).toHaveLength(0);
+    expect(
+      screen.queryAllByDisplayValue('template2', { selector: 'button' })
+    ).toHaveLength(1);
+  });
+  it('category error ', async () => {
+    selectors.selectCategoryError.mockImplementation(() => 'category error');
+    selectors.selectAllTemplatesError.mockImplementation(() => null);
+    selectors.selectTemplateError.mockImplementation(() => null);
+    render(
+      <Provider store={store}>
+        <JobWizard />
+      </Provider>
+    );
+
+    expect(
+      screen.queryAllByText('Categories list failed with:', { exact: false })
+    ).toHaveLength(1);
+
+    expect(
+      screen.queryAllByText('Templates list failed with:', { exact: false })
+    ).toHaveLength(0);
+    expect(
+      screen.queryAllByText('Template failed with:', { exact: false })
+    ).toHaveLength(0);
+  });
+  it('templates error ', async () => {
+    selectors.selectCategoryError.mockImplementation(() => null);
+    selectors.selectAllTemplatesError.mockImplementation(
+      () => 'templates error'
+    );
+    selectors.selectTemplateError.mockImplementation(() => null);
+    render(
+      <Provider store={store}>
+        <JobWizard />
+      </Provider>
+    );
+
+    expect(
+      screen.queryAllByText('Categories list failed with:', { exact: false })
+    ).toHaveLength(0);
+
+    expect(
+      screen.queryAllByText('Templates list failed with:', { exact: false })
+    ).toHaveLength(1);
+    expect(
+      screen.queryAllByText('Template failed with:', { exact: false })
+    ).toHaveLength(0);
+  });
+  it('template error ', async () => {
+    selectors.selectCategoryError.mockImplementation(() => null);
+    selectors.selectAllTemplatesError.mockImplementation(() => null);
+    selectors.selectTemplateError.mockImplementation(() => 'template error');
+    render(
+      <Provider store={store}>
+        <JobWizard />
+      </Provider>
+    );
+
+    expect(
+      screen.queryAllByText('Categories list failed with:', { exact: false })
+    ).toHaveLength(0);
+
+    expect(
+      screen.queryAllByText('Templates list failed with:', { exact: false })
+    ).toHaveLength(0);
+    expect(
+      screen.queryAllByText('Template failed with:', { exact: false })
+    ).toHaveLength(1);
+  });
 });

data/webpack/JobWizard/steps/Schedule/QueryType.js

@@ -0,0 +1,48 @@
+import React, { useState } from 'react';
+import { FormGroup, Radio } from '@patternfly/react-core';
+import { translate as __ } from 'foremanReact/common/I18n';
+import { helpLabel } from '../form/FormHelpers';
+
+export const QueryType = () => {
+  const [isTypeStatic, setIsTypeStatic] = useState(true);
+  return (
+    <FormGroup
+      label={__('Query type')}
+      fieldId="query-type"
+      labelIcon={helpLabel(
+        <p>
+          {__('Type has impact on when is the query evaluated to hosts.')}
+          <br />
+          <ul>
+            <li>
+              <b>{__('Static')}</b> -{' '}
+              {__('evaluates just after you submit this form')}
+            </li>
+            <li>
+              <b>{__('Dynamic')}</b> -{' '}
+              {__(
+                "evaluates just before the execution is started, so if it's planed in future, targeted hosts set may change before it"
+              )}
+            </li>
+          </ul>
+        </p>,
+        'query-type'
+      )}
+    >
+      <Radio
+        isChecked={isTypeStatic}
+        name="query-type"
+        onChange={() => setIsTypeStatic(true)}
+        id="query-type-static"
+        label={__('Static query')}
+      />
+      <Radio
+        isChecked={!isTypeStatic}
+        name="query-type"
+        onChange={() => setIsTypeStatic(false)}
+        id="query-type-dynamic"
+        label={__('Dynamic query')}
+      />
+    </FormGroup>
+  );
+};

data/webpack/JobWizard/steps/Schedule/RepeatOn.js

@@ -0,0 +1,61 @@
+import React, { useState } from 'react';
+import PropTypes from 'prop-types';
+import { TextInput, Grid, GridItem, FormGroup } from '@patternfly/react-core';
+import { translate as __ } from 'foremanReact/common/I18n';
+import { SelectField } from '../form/SelectField';
+import { repeatTypes } from '../../JobWizardConstants';
+
+export const RepeatOn = ({
+  repeatType,
+  setRepeatType,
+  repeatAmount,
+  setRepeatAmount,
+}) => {
+  const [repeatValidated, setRepeatValidated] = useState('default');
+  const handleRepeatInputChange = newValue => {
+    setRepeatValidated(newValue >= 1 ? 'default' : 'error');
+    setRepeatAmount(newValue);
+  };
+  return (
+    <Grid>
+      <GridItem span={6}>
+        <SelectField
+          fieldId="repeat-select"
+          options={Object.values(repeatTypes)}
+          setValue={newValue => {
+            setRepeatType(newValue);
+            if (newValue === repeatTypes.noRepeat) {
+              setRepeatValidated('default');
+            }
+          }}
+          value={repeatType}
+        />
+      </GridItem>
+      <GridItem span={1} />
+      <GridItem span={5}>
+        <FormGroup
+          isInline
+          helperTextInvalid={__('Repeat amount can only be a positive number')}
+          validated={repeatValidated}
+        >
+          <TextInput
+            isDisabled={repeatType === repeatTypes.noRepeat}
+            id="repeat-amount"
+            value={repeatAmount}
+            type="text"
+            onChange={newValue => handleRepeatInputChange(newValue)}
+            placeholder={__('Repeat N times')}
+          />
+        </FormGroup>
+      </GridItem>
+    </Grid>
+  );
+};
+
+RepeatOn.propTypes = {
+  repeatType: PropTypes.oneOf(Object.values(repeatTypes)).isRequired,
+  setRepeatType: PropTypes.func.isRequired,
+  repeatAmount: PropTypes.oneOfType([PropTypes.string, PropTypes.number])
+    .isRequired,
+  setRepeatAmount: PropTypes.func.isRequired,
+};

data/webpack/JobWizard/steps/Schedule/ScheduleType.js

@@ -0,0 +1,25 @@
+import React, { useState } from 'react';
+import { FormGroup, Radio } from '@patternfly/react-core';
+import { translate as __ } from 'foremanReact/common/I18n';
+
+export const ScheduleType = () => {
+  const [isFuture, setIsFuture] = useState(false);
+  return (
+    <FormGroup label={__('Schedule type')} fieldId="schedule-type">
+      <Radio
+        isChecked={!isFuture}
+        name="schedule-type"
+        onChange={() => setIsFuture(false)}
+        id="schedule-type-now"
+        label={__('Execute now')}
+      />
+      <Radio
+        isChecked={isFuture}
+        name="schedule-type"
+        onChange={() => setIsFuture(true)}
+        id="schedule-type-future"
+        label={__('Schedule for future execution')}
+      />
+    </FormGroup>
+  );
+};

data/webpack/JobWizard/steps/Schedule/StartEndDates.js

@@ -0,0 +1,51 @@
+import React, { useState } from 'react';
+import PropTypes from 'prop-types';
+import { FormGroup, TextInput, Checkbox } from '@patternfly/react-core';
+import { translate as __ } from 'foremanReact/common/I18n';
+
+// TODO: change to datepicker
+export const StartEndDates = ({ starts, setStarts, ends, setEnds }) => {
+  const [isNeverEnds, setIsNeverEnds] = useState(false);
+  const toggleIsNeverEnds = (checked, event) => {
+    const value = event?.target?.checked;
+    setIsNeverEnds(value);
+    setEnds('');
+  };
+  return (
+    <>
+      <FormGroup label={__('Starts')} fieldId="start-date">
+        <TextInput
+          id="start-date"
+          value={starts}
+          type="text"
+          onChange={newValue => setStarts(newValue)}
+          placeholder="mm/dd/yy, hh:mm UTC"
+        />
+      </FormGroup>
+      <FormGroup label={__('Ends')} fieldId="end-date">
+        <TextInput
+          isDisabled={isNeverEnds}
+          id="end-date"
+          value={ends}
+          type="text"
+          onChange={newValue => setEnds(newValue)}
+          placeholder="mm/dd/yy, hh:mm UTC"
+        />
+        <Checkbox
+          label={__('Never ends')}
+          isChecked={isNeverEnds}
+          onChange={toggleIsNeverEnds}
+          id="never-ends"
+          name="never-ends"
+        />
+      </FormGroup>
+    </>
+  );
+};
+
+StartEndDates.propTypes = {
+  starts: PropTypes.string.isRequired,
+  setStarts: PropTypes.func.isRequired,
+  ends: PropTypes.string.isRequired,
+  setEnds: PropTypes.func.isRequired,
+};

data/webpack/JobWizard/steps/Schedule/__tests__/StartEndDates.test.js

@@ -0,0 +1,22 @@
+import React from 'react';
+import { render, fireEvent, screen } from '@testing-library/react';
+import { StartEndDates } from '../StartEndDates';
+
+const setEnds = jest.fn();
+const props = {
+  starts: '',
+  setStarts: jest.fn(),
+  ends: 'some-end-date',
+  setEnds,
+};
+
+describe('StartEndDates', () => {
+  it('never ends', () => {
+    render(<StartEndDates {...props} />);
+    const neverEnds = screen.getByLabelText('Never ends', {
+      selector: 'input',
+    });
+    fireEvent.click(neverEnds);
+    expect(setEnds).toBeCalledWith('');
+  });
+});

data/webpack/JobWizard/steps/Schedule/index.js

@@ -0,0 +1,41 @@
+import React, { useState } from 'react';
+import { Title, Button, Form } from '@patternfly/react-core';
+import { translate as __ } from 'foremanReact/common/I18n';
+import { ScheduleType } from './ScheduleType';
+import { RepeatOn } from './RepeatOn';
+import { QueryType } from './QueryType';
+import { StartEndDates } from './StartEndDates';
+import { repeatTypes } from '../../JobWizardConstants';
+
+const Schedule = () => {
+  const [repeatType, setRepeatType] = useState(repeatTypes.noRepeat);
+  const [repeatAmount, setRepeatAmount] = useState('');
+  const [starts, setStarts] = useState('');
+  const [ends, setEnds] = useState('');
+
+  return (
+    <Form className="schedule-tab">
+      <Title headingLevel="h2">{__('Schedule')}</Title>
+      <ScheduleType />
+
+      <RepeatOn
+        repeatType={repeatType}
+        setRepeatType={setRepeatType}
+        repeatAmount={repeatAmount}
+        setRepeatAmount={setRepeatAmount}
+      />
+      <StartEndDates
+        starts={starts}
+        setStarts={setStarts}
+        ends={ends}
+        setEnds={setEnds}
+      />
+      <Button variant="link" className="advanced-scheduling-button" isInline>
+        {__('Advanced scheduling')}
+      </Button>
+      <QueryType />
+    </Form>
+  );
+};
+
+export default Schedule;