foreman_remote_execution 3.0.2 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b508796a09bd44e8ded07627d4f73d9ca5f2f2ee7576ab2dab2bca47d2247f0f
-  data.tar.gz: f5dfc0b4375e2ab8e14675f1f7c2c1d4e1b7906a9fe2d66a3a1aa387d678af59
+  metadata.gz: d00f4722f74258ad947432c2d8104522d3fb53749f7bac4e7c52914862af3ecc
+  data.tar.gz: 187645d51578339523b94fb83fe781cba865477a616c2d8c0980255be1fd0377
 SHA512:
-  metadata.gz: 9d7e2eed12d1517f46fbc5ba50c3c4fe5d1687334ec36e14c4ec3f3b103137c711f3059af1b4fa4b14d4828307e9b41fc4b2512d06476c6ad231c6706f8bbf11
-  data.tar.gz: 43d0a7b3595298d50c47545c09e337f1bcf90399f56a5a16f6e95d755bc7d9d6ba80d6547c1caefd39cf3807d44237cf9494a12505e2b030249609dd5ebd2c59
+  metadata.gz: 04c6a44e96bb03d75310d7dd48acd249503f04778c62f520d1101bf4719d195c2cd4d11e9a6ae63c97e24d8cbd50884dd090ec56a54aff933ee19f3379bbeec1
+  data.tar.gz: 165ba49b54b18ed4128c7b72a53ef52fea60f6f9a619ee7bd0a22545910cf68997b763e27f3569892b20dd528e70236c44b241c1d1b6c5fcec15a5a21f76af7e

data/.eslintrc

@@ -1,32 +1,7 @@
 {
-  "root": true,
-  "extends": ["airbnb-base", "./node_modules/@theforeman/vendor-dev/eslint.extends.js"],
-  "plugins": [
-    "react"
-  ],
-  "env": {
-    "browser": true,
-    "es6": true,
-    "node": true,
-    "jasmine": true,
-    "jest": true
-  },
-  "parser": "babel-eslint",
-  "rules": {
-    "react/jsx-uses-vars": "error",
-    "react/jsx-uses-react": "error",
-    "no-unused-vars": [
-      "error",
-      {
-        "vars": "all",
-        "args": "none"
-      }
-    ],
-    "no-underscore-dangle": "off",
-    "no-use-before-define": "off",
-    "import/prefer-default-export": "off",
-    // Import rules off for now due to HoundCI issue
-    "import/no-unresolved": "off",
-    "import/extensions": "off"
-  }
+  "plugins": ["@theforeman/foreman"],
+  "extends": [
+    "plugin:@theforeman/foreman/core",
+    "plugin:@theforeman/foreman/plugins"
+  ]
 }

data/.gitignore

@@ -14,3 +14,4 @@ locale/*/*.po.time_stamp
 Gemfile.lock
 node_modules/
 package-lock.json
+coverage/

data/.hound.yml

@@ -4,15 +4,11 @@ scss:
 stylelint:
   enabled: true
 
-ruby:
+rubocop:
   config_file: .rubocop.yml
+  version: 0.80.0
 
 jshint:
   enabled: false
 
-eslint:
-  enabled: true
-  config_file: .eslintrc
-  ignore_file: .eslintignore
-
 fail_on_violations: true

data/.rubocop.yml

@@ -1,111 +1,141 @@
-inherit_from:
-  - .rubocop_todo.yml
+require:
+  - rubocop-minitest
+  - rubocop-performance
+  - rubocop-rails
+
+inherit_from: .rubocop_todo.yml
 
 AllCops:
+  TargetRubyVersion: 2.5
+  TargetRailsVersion: 5.2
   Exclude:
-    - 'config/routes.rb'
-    - 'node_modules/**'
-    - 'test/**/*'
-    - 'doc/plugins/**'
+    - 'node_modules/**/*'
 
-Rails:
-  Enabled: true
-  Exclude:
-    - 'lib/foreman_remote_execution_core/**'
-    - 'node_modules/**'
+Bundler/OrderedGems:
+  Enabled: false
 
-Rails/Date:
+Layout/ArgumentAlignment:
+  EnforcedStyle: with_fixed_indentation
+  IndentationWidth: 2
+
+Layout/DotPosition:
   Enabled: false
 
-Metrics:
+Layout/FirstArgumentIndentation:
+  EnforcedStyle: consistent
+
+Layout/HashAlignment:
   Enabled: false
 
-Style/Documentation:
+Layout/LineLength:
   Enabled: false
 
-Style/TrailingCommaInArrayLiteral:
+Layout/ParameterAlignment:
   Enabled: false
 
-Style/TrailingCommaInHashLiteral:
+Lint/BooleanSymbol:
   Enabled: false
 
-#Style/TrailingCommaInArguments:
-#Enabled: false
+Metrics:
+  Enabled: false
 
-Naming/AccessorMethodName:
+Performance/Casecmp:
   Enabled: false
 
-Style/RedundantSelf:
+Performance/RedundantMatch:
+  Enabled: true
+
+Performance/RedundantMerge:
+  Enabled: true
+
+Performance/RegexpMatch:
   Enabled: false
 
-Naming/FileName:
+Rails:
   Exclude:
-      - 'db/seeds.d/*'
-      - 'node_modules/font-awesome-sass/lib/font-awesome-sass.rb'
+    - 'lib/foreman_remote_execution_core/**/*'
+    - 'lib/foreman_remote_execution_core.rb'
 
-Style/WordArray:
-  Enabled: false
+Rails/Blank:
+  UnlessPresent: false
 
-Style/BracesAroundHashParameters:
+# Won't work with sqlite
+Rails/BulkChangeTable:
   Enabled: false
 
-Style/RescueModifier:
+Rails/RefuteMethods:
   Enabled: false
 
-Style/ClassAndModuleChildren:
-  Enabled: false
+Style/Alias:
+  EnforcedStyle: prefer_alias_method
+
+Style/AndOr:
+  EnforcedStyle: conditionals
 
-Style/EachWithObject:
+# Don't prefer is_a? over kind_of?
+Style/ClassCheck:
   Enabled: false
 
-Style/GuardClause:
+# Don't enforce certain methods, e.g. detect over find
+Style/CollectionMethods:
   Enabled: false
 
-Naming/VariableNumber:
+Style/ConditionalAssignment:
   Enabled: false
 
-# a == 0 is not the same as a.zero?, when a is not a number
-Style/NumericPredicate:
+# Don't enforce documentation
+Style/Documentation:
   Enabled: false
 
-Style/FormatStringToken:
-  EnforcedStyle: template
+Style/EmptyMethod:
+  EnforcedStyle: expanded
 
-Rails/SkipsModelValidations:
+# Don't enforce frozen string literals
+Style/FrozenStringLiteralComment:
   Enabled: false
 
-Style/SymbolArray:
+# Support both, Ruby 1.9 hashmap and hash-rocket syntax
+Style/HashSyntax:
   Enabled: false
 
-Style/FormatString:
+Style/IfUnlessModifier:
   Enabled: false
 
-Naming/HeredocDelimiterNaming:
+Style/InverseMethods:
   Enabled: false
 
-Style/RescueStandardError:
+# disabled until we can configure "+" as concat sign
+Style/LineEndConcatenation:
   Enabled: false
 
-Style/SafeNavigation:
+Style/MultipleComparison:
   Enabled: false
 
-Lint/BooleanSymbol:
+Style/NumericPredicate:
   Enabled: false
 
-Style/FrozenStringLiteralComment:
+Style/ParallelAssignment:
   Enabled: false
 
-Layout/EmptyLineAfterGuardClause:
+Style/ParenthesesAroundCondition:
   Enabled: false
 
-Layout/AlignHash:
+Style/PreferredHashMethods:
   Enabled: false
 
-Rails/ReflectionClassName:
+# Both double and single quotes are OK
+Style/StringLiterals:
   Enabled: false
 
-Rails/HelperInstanceVariable:
-  Enabled: false
+Style/TernaryParentheses:
+  EnforcedStyle: require_parentheses_when_complex
+
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: comma
 
-Naming/RescuedExceptionsVariableName:
+#Allow both ['a', 'b'], %w[a b] and %w(a b) style arrays
+Style/WordArray:
   Enabled: false

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --exclude-limit 0`
-# on 2018-04-02 18:24:49 +0200 using RuboCop version 0.54.0.
+# on 2020-03-14 13:43:47 +0100 using RuboCop version 0.80.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -8,24 +8,24 @@
 
 # Offense count: 2
 # Cop supports --auto-correct.
-# Configuration parameters: Include, TreatCommentsAsGroupSeparators.
+# Configuration parameters: TreatCommentsAsGroupSeparators, Include.
 # Include: **/*.gemspec
 Gemspec/OrderedDependencies:
   Enabled: false
 
-# Offense count: 17
+# Offense count: 14
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentOneStep, IndentationWidth.
 # SupportedStyles: case, end
 Layout/CaseIndentation:
   Enabled: false
 
-# Offense count: 6
+# Offense count: 4
 # Cop supports --auto-correct.
 Layout/EmptyLines:
   Enabled: false
 
-# Offense count: 7
+# Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: empty_lines, no_empty_lines
@@ -39,38 +39,39 @@ Layout/EmptyLinesAroundBlockBody:
 Layout/EmptyLinesAroundClassBody:
   Enabled: false
 
-# Offense count: 3
+# Offense count: 4
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
 Layout/EmptyLinesAroundModuleBody:
   Enabled: false
 
-# Offense count: 1
+# Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: Width, IgnoredPatterns.
 Layout/IndentationWidth:
   Enabled: false
 
-# Offense count: 8
+# Offense count: 9
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: aligned, indented
 Layout/MultilineOperationIndentation:
   Enabled: false
 
-# Offense count: 1
+# Offense count: 5
 # Cop supports --auto-correct.
 Layout/SpaceAfterComma:
   Enabled: false
 
-# Offense count: 4
+# Offense count: 28
 # Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment.
+# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
+# SupportedStylesForExponentOperator: space, no_space
 Layout/SpaceAroundOperators:
   Enabled: false
 
-# Offense count: 46
+# Offense count: 54
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
 # SupportedStyles: space, no_space, compact
@@ -78,7 +79,7 @@ Layout/SpaceAroundOperators:
 Layout/SpaceInsideArrayLiteralBrackets:
   Enabled: false
 
-# Offense count: 85
+# Offense count: 95
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
 # SupportedStyles: space, no_space, compact
@@ -86,60 +87,54 @@ Layout/SpaceInsideArrayLiteralBrackets:
 Layout/SpaceInsideHashLiteralBraces:
   Enabled: false
 
-# Offense count: 5
-# Configuration parameters: MaximumRangeSize.
-Lint/MissingCopEnableDirective:
-  Enabled: false
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Lint/UnneededCopDisableDirective:
-  Enabled: false
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Lint/UnneededCopEnableDirective:
-  Enabled: false
-
 # Offense count: 10
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
 Lint/UnusedBlockArgument:
   Enabled: false
 
-# Offense count: 14
+# Offense count: 15
 # Cop supports --auto-correct.
 # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
 Lint/UnusedMethodArgument:
   Enabled: false
 
-# Offense count: 1
+# Offense count: 4
 Lint/UselessAssignment:
   Enabled: false
 
-# Offense count: 5
-Metrics/CyclomaticComplexity:
-  Max: 8
+# Offense count: 1
+Naming/AccessorMethodName:
+  Enabled: false
 
-# Offense count: 940
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 204
+# Offense count: 5
+# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
+# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
+Naming/FileName:
+  Enabled: false
 
-# Offense count: 2
-Naming/MemoizedInstanceVariableName:
+# Offense count: 1
+# Configuration parameters: ForbiddenDelimiters.
+# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+Naming/HeredocDelimiterNaming:
   Enabled: false
 
-# Offense count: 3
+# Offense count: 2
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to
-Naming/UncommunicativeMethodParamName:
+# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
+Naming/MethodParameterName:
   Enabled: false
 
-# Offense count: 15
+# Offense count: 1
 # Cop supports --auto-correct.
-Rails/ActiveRecordAliases:
+# Configuration parameters: PreferredName.
+Naming/RescuedExceptionsVariableName:
+  Enabled: false
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: snake_case, normalcase, non_integer
+Naming/VariableNumber:
   Enabled: false
 
 # Offense count: 7
@@ -149,13 +144,18 @@ Rails/CreateTableWithTimestamps:
   Enabled: false
 
 # Offense count: 1
-# Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
-# SupportedStyles: numeric, symbolic
-Rails/HttpStatus:
+# SupportedStyles: strict, flexible
+Rails/Date:
   Enabled: false
 
-# Offense count: 23
+# Offense count: 13
+# Configuration parameters: Include.
+# Include: app/helpers/**/*.rb
+Rails/HelperInstanceVariable:
+  Enabled: false
+
+# Offense count: 13
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
 Rails/InverseOf:
@@ -168,17 +168,36 @@ Rails/LexicallyScopedActionFilter:
   Enabled: false
 
 # Offense count: 1
-# Cop supports --auto-correct.
-Rails/Presence:
+# Configuration parameters: Include.
+# Include: **/Rakefile, **/*.rake
+Rails/RakeEnvironment:
   Enabled: false
 
-# Offense count: 3
+# Offense count: 1
+Rails/ReflectionClassName:
+  Enabled: false
+
+# Offense count: 21
+# Configuration parameters: Blacklist, Whitelist.
+# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
+Rails/SkipsModelValidations:
+  Enabled: false
+
+# Offense count: 6
+# Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: strict, flexible
 Rails/TimeZone:
   Enabled: false
 
-# Offense count: 3
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle.
+# SupportedStyles: nested, compact
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+# Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: Keywords.
 # Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW
@@ -194,35 +213,39 @@ Style/DoubleNegation:
 Style/Encoding:
   Enabled: false
 
-# Offense count: 7
+# Offense count: 8
 # Cop supports --auto-correct.
 Style/ExpandPathArguments:
   Enabled: false
 
-# Offense count: 15
+# Offense count: 12
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: format, sprintf, percent
+Style/FormatString:
+  Enabled: false
+
+# Offense count: 62
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: annotated, template, unannotated
 Style/FormatStringToken:
   Enabled: false
 
-# Offense count: 1527
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
-# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
-Style/HashSyntax:
+# Offense count: 21
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
   Enabled: false
 
-# Offense count: 17
-# Cop supports --auto-correct.
-Style/IfUnlessModifier:
+Style/HashEachMethods:
   Enabled: false
 
-# Offense count: 12
-# Cop supports --auto-correct.
-Style/LineEndConcatenation:
+Style/HashTransformKeys:
   Enabled: false
 
-# Offense count: 22
+Style/HashTransformValues:
+  Enabled: false
+
+# Offense count: 26
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
@@ -235,20 +258,37 @@ Style/PercentLiteralDelimiters:
 Style/RaiseArgs:
   Enabled: false
 
-# Offense count: 14
+# Offense count: 15
 # Cop supports --auto-correct.
 # Configuration parameters: AllowMultipleReturnValues.
 Style/RedundantReturn:
   Enabled: false
 
-# Offense count: 5
+# Offense count: 76
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiterals:
+Style/RedundantSelf:
   Enabled: false
 
-# Offense count: 2
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/RescueModifier:
+  Enabled: false
+
+# Offense count: 11
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: implicit, explicit
+Style/RescueStandardError:
+  Enabled: false
+
+# Offense count: 37
+# Cop supports --auto-correct.
+# Configuration parameters: MinSize.
+# SupportedStyles: percent, brackets
+Style/SymbolArray:
+  EnforcedStyle: brackets
+
+# Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoredMethods.
 # IgnoredMethods: respond_to, define_method