foreman_remote_execution 16.5.3 → 16.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4d4a947b587075d0d60662d365b36c3fab8006b958a363c39354b1f67f771c69
-  data.tar.gz: 16bc29adc59c2a3bf1605902aece3e9d0f2bbd67749f4bc1a429ae52507165c8
+  metadata.gz: c9b021c23fae39af103f3ac3bdb0fd3e208b74fb8ad234f66f7770a5e4dfc78f
+  data.tar.gz: 4fd6498051640caae5cf6e4580d01106883a0f33d486b672a0d77ed49205e52c
 SHA512:
-  metadata.gz: 3766b56254d55dd3f520ca16cca021d558362db4a34ccb15fb6833124a14f5900deefc78fc4125b4128c28f8eafd6d41f9c97d5526702a66ff32eb28665cde6f
-  data.tar.gz: 1cb89677b91f21c07296af85bd5b18c993572965e701d8b8e55d0880ff5e5fc81b7d7a56a6a053a916309825489c3ec90d929092382f5dd1630fb44fd599a6fc
+  metadata.gz: bf4e127076278dca8d3ec7d4b86a625a89bb95c4a4c5cd728e9207e8ff3151f983965061498bbfd813c6d9d08f49ec59f9ba2bc06be113f8e721e8f04dfc0285
+  data.tar.gz: 0124e5ae5e0f484269adf05e9e9e3aa10e1262c4c6f635707dee035f217a5206565bc231fa65dee356609ce6e9db332d7c1faf96b8d1b7b3760483171997e5fd

data/Rakefile

@@ -3,21 +3,6 @@ begin
 rescue LoadError
   puts 'You must `gem install bundler` and `bundle install` to run rake tasks'
 end
-begin
-  require 'rdoc/task'
-rescue LoadError
-  require 'rdoc/rdoc'
-  require 'rake/rdoctask'
-  RDoc::Task = Rake::RDocTask
-end
-
-RDoc::Task.new(:rdoc) do |rdoc|
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title    = 'ForemanRemoteExecution'
-  rdoc.options << '--line-numbers'
-  rdoc.rdoc_files.include('README.rdoc')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end
 
 APP_RAKEFILE = File.expand_path('../test/dummy/Rakefile', __FILE__)
 

data/lib/foreman_remote_execution/version.rb

@@ -1,3 +1,3 @@
 module ForemanRemoteExecution
-  VERSION = '16.5.3'.freeze
+  VERSION = '16.6.4'.freeze
 end

data/webpack/JobInvocationDetail/JobInvocationActions.js

@@ -24,6 +24,13 @@ export const getJobInvocation = url => dispatch => {
       handleError: () => {
         dispatch(stopInterval(JOB_INVOCATION_KEY));
       },
+      errorToast: ({ response }) =>
+        // eslint-disable-next-line camelcase
+        response?.data?.error?.full_messages?.[0] ||
+        // eslint-disable-next-line camelcase
+        response?.data?.error?.full_messages ||
+        response?.data?.error?.message ||
+        'Error',
     }),
     1000
   );

data/webpack/JobInvocationDetail/JobInvocationHostTable.js

@@ -1,12 +1,14 @@
 /* eslint-disable max-lines */
 /* eslint-disable camelcase */
 import {
+  Icon,
   EmptyState,
   EmptyStateBody,
   EmptyStateHeader,
   EmptyStateVariant,
   ToolbarItem,
 } from '@patternfly/react-core';
+import { AddCircleOIcon } from '@patternfly/react-icons';
 import { ExpandableRowContent, Tbody, Td, Tr } from '@patternfly/react-table';
 import { useDispatch } from 'react-redux';
 import { APIActions } from 'foremanReact/redux/API';
@@ -22,7 +24,6 @@ import {
 import { getPageStats } from 'foremanReact/components/PF4/TableIndexPage/Table/helpers';
 import TableIndexPage from 'foremanReact/components/PF4/TableIndexPage/TableIndexPage';
 import { getControllerSearchProps } from 'foremanReact/constants';
-import { Icon } from 'patternfly-react';
 import PropTypes from 'prop-types';
 import React, {
   useEffect,
@@ -339,7 +340,9 @@ const JobInvocationHostTable = ({
       <Td colSpan={100}>
         <EmptyState variant={EmptyStateVariant.xl}>
           <span className="empty-state-icon">
-            <Icon name="add-circle-o" type="pf" size="2x" />
+            <Icon size="xl" iconSize="xl">
+              <AddCircleOIcon name="add-circle-o" />
+            </Icon>
           </span>
           <EmptyStateHeader
             titleText={<>{__('No Results')}</>}

data/webpack/JobInvocationDetail/TemplateInvocationComponents/OutputCodeBlock.js

@@ -11,7 +11,7 @@ import { translate as __ } from 'foremanReact/common/I18n';
 export const OutputCodeBlock = ({ code, showOutputType, scrollElement }) => {
   let lineCounter = 0;
   // eslint-disable-next-line no-control-regex
-  const COLOR_PATTERN = /\x1b\[(\d+)m/g;
+  const COLOR_PATTERN = /\x1b\[[\d;]*m/g;
   const CONSOLE_COLOR = {
     '31': 'red',
     '32': 'lightgreen',
@@ -27,12 +27,15 @@ export const OutputCodeBlock = ({ code, showOutputType, scrollElement }) => {
     '95': 'violet',
     '96': 'turquoise',
     '0': 'default',
+    '39': 'default',
   };
 
   const colorizeLine = line => {
     line = line.replace(COLOR_PATTERN, seq => {
-      const color = seq.match(/(\d+)m/)[1];
-      return `{{{format color:${color}}}}`;
+      const codes = seq.match(/(\d+)/g) || [];
+      const lastColorCode =
+        [...codes].reverse().find(code_ => code_ in CONSOLE_COLOR) || '0';
+      return `{{{format color:${lastColorCode}}}}`;
     });
 
     let currentColor = 'default';

data/webpack/JobInvocationDetail/__tests__/OutputCodeBlock.test.js

@@ -31,6 +31,7 @@ describe('OutputCodeBlock', () => {
     expect(screen.getByText('This is green text')).toHaveStyle(
       'color: lightgreen'
     );
+    expect(screen.getByText('Compound red text')).toHaveStyle('color: red');
   });
 
   test('displays no output message when filtered', () => {

data/webpack/JobInvocationDetail/__tests__/fixtures.js

@@ -196,6 +196,15 @@ export const jobInvocationOutput = [
     timestamp: 1733931148.2044532,
   },
 
+  {
+    id: 1960,
+    template_invocation_id: templateInvocationID,
+    timestamp: 1733931149.2044532,
+    meta: null,
+    external_id: '0',
+    output_type: 'stdout',
+    output: '\u001b[0;31mCompound red text\u001b[0m\n',
+  },
   {
     id: 1907,
     template_invocation_id: templateInvocationID,

data/webpack/JobWizard/JobWizard.js

@@ -62,10 +62,12 @@ export const JobWizard = ({ rerunData }) => {
     hostGroups: [],
   });
   const [hostsSearchQuery, setHostsSearchQuery] = useState('');
+  const [selectedBookmark, setSelectedBookmark] = useState(null);
   const [fills, setFills] = useState(
     rerunData
       ? {
           search: rerunData?.targeting?.search_query,
+          bookmark_id: rerunData?.targeting?.bookmark_id,
           ...rerunData.inputs,
           ...routerSearch,
         }
@@ -251,6 +253,7 @@ export const JobWizard = ({ rerunData }) => {
     setFills,
     setSelectedTargets,
     setHostsSearchQuery,
+    setSelectedBookmark,
     setJobTemplateID,
     setTemplateValues,
     setAdvancedValues,
@@ -298,6 +301,8 @@ export const JobWizard = ({ rerunData }) => {
           setSelected={setSelectedTargets}
           hostsSearchQuery={hostsSearchQuery}
           setHostsSearchQuery={setHostsSearchQuery}
+          selectedBookmark={selectedBookmark}
+          setSelectedBookmark={setSelectedBookmark}
         />
       ),
       canJumpTo: isTemplate,
@@ -474,6 +479,7 @@ export const JobWizard = ({ rerunData }) => {
       dispatch,
       selectedTargets,
       hostsSearchQuery,
+      selectedBookmark,
       location,
       organization,
       feature,
@@ -507,6 +513,7 @@ JobWizard.propTypes = {
     job_category: PropTypes.string,
     targeting: PropTypes.shape({
       search_query: PropTypes.string,
+      bookmark_id: PropTypes.number,
       targeting_type: PropTypes.string,
       randomized_ordering: PropTypes.bool,
     }),

data/webpack/JobWizard/JobWizardConstants.js

@@ -1,5 +1,6 @@
 import { translate as __ } from 'foremanReact/common/I18n';
 import { foremanUrl } from 'foremanReact/common/helpers';
+import { getControllerSearchProps } from 'foremanReact/constants';
 
 export const JOB_TEMPLATES = 'JOB_TEMPLATES';
 export const JOB_CATEGORIES = 'JOB_CATEGORIES';
@@ -61,6 +62,10 @@ export const hostMethods = {
 
 export const hostQuerySearchID = 'mainHostQuery';
 export const hostsController = 'hosts';
+export const hostsSearchProps = getControllerSearchProps(
+  hostsController,
+  hostQuerySearchID
+);
 
 export const dataName = {
   [HOSTS]: 'hosts',

data/webpack/JobWizard/JobWizardSelectors.js

@@ -9,6 +9,8 @@ import {
 } from 'foremanReact/redux/API/APISelectors';
 import { STATUS } from 'foremanReact/constants';
 import { selectRouterLocation } from 'foremanReact/routes/RouterSelector';
+import { BOOKMARKS } from 'foremanReact/components/PF4/Bookmarks/BookmarksConstants';
+import { selectBookmarksResults } from 'foremanReact/components/PF4/Bookmarks/BookmarksSelectors';
 
 import {
   JOB_TEMPLATES,
@@ -134,3 +136,9 @@ export const selectRouterSearch = state => {
   const { search } = selectRouterLocation(state) || {};
   return URI.parseQuery(search);
 };
+
+const HOSTS_CONTROLLER = 'hosts';
+const BOOKMARKS_HOSTS_KEY = `${BOOKMARKS}_${HOSTS_CONTROLLER.toUpperCase()}`;
+
+export const selectHostBookmarks = state =>
+  selectBookmarksResults(state, BOOKMARKS_HOSTS_KEY, HOSTS_CONTROLLER);

data/webpack/JobWizard/PermissionDenied.js

@@ -1,8 +1,9 @@
 import React from 'react';
 import PropTypes from 'prop-types';
 import { translate as __ } from 'foremanReact/common/I18n';
-import { Icon } from 'patternfly-react';
+import { LockIcon } from '@patternfly/react-icons';
 import {
+  Icon,
   Button,
   EmptyState,
   EmptyStateVariant,
@@ -36,7 +37,9 @@ const PermissionDenied = ({ missingPermissions, setProceedAnyway }) => {
   return (
     <EmptyState variant={EmptyStateVariant.xl}>
       <span className="empty-state-icon">
-        <Icon name="lock" type="fa" size="2x" />
+        <Icon size="xl" iconSize="xl">
+          <LockIcon name="lock" />
+        </Icon>
       </span>
       <EmptyStateHeader
         titleText={<>{__('Permission Denied')}</>}

data/webpack/JobWizard/__tests__/JobWizardPageRerun.test.js

@@ -3,21 +3,19 @@ import { Provider } from 'react-redux';
 import { render, fireEvent, screen, act } from '@testing-library/react';
 import { MockedProvider } from '@apollo/client/testing';
 
-import * as APIHooks from 'foremanReact/common/hooks/API/APIHooks';
 import * as api from 'foremanReact/redux/API';
 import JobWizardPageRerun from '../JobWizardPageRerun';
 import * as selectors from '../JobWizardSelectors';
-import { testSetup, mockApi, gqlMock, jobInvocation } from './fixtures';
+import {
+  testSetup,
+  mockApi,
+  gqlMock,
+  jobInvocation,
+  bookmarksList,
+} from './fixtures';
 
 const store = testSetup(selectors, api);
 mockApi(api);
-jest.spyOn(APIHooks, 'useAPI');
-APIHooks.useAPI.mockImplementation((action, url) => {
-  if (url === '/ui_job_wizard/job_invocation?id=57') {
-    return { response: jobInvocation, status: 'RESOLVED' };
-  }
-  return {};
-});
 
 describe('Job wizard fill', () => {
   it('fill defaults into fields', async () => {
@@ -76,4 +74,50 @@ describe('Job wizard fill', () => {
       }).value
     ).toBe('6');
   });
+
+  it('fills bookmark on rerun when job used a bookmark', async () => {
+    const bookmark = bookmarksList[0];
+    const jobWithBookmark = {
+      ...jobInvocation,
+      job: {
+        ...jobInvocation.job,
+        targeting: {
+          ...jobInvocation.job.targeting,
+          bookmark_id: bookmark.id,
+          search_query: null,
+        },
+      },
+    };
+
+    selectors.selectRerunJobInvocationResponse.mockImplementation(
+      () => jobWithBookmark
+    );
+
+    render(
+      <MockedProvider mocks={gqlMock} addTypename={false}>
+        <Provider store={store}>
+          <JobWizardPageRerun
+            match={{
+              params: { id: '99' },
+            }}
+          />
+        </Provider>
+      </MockedProvider>
+    );
+
+    await act(async () => {
+      fireEvent.click(screen.getByText('Target hosts and inputs'));
+    });
+
+    const hostMethodSelect = screen.getByRole('button', {
+      name: 'host method',
+    });
+    expect(hostMethodSelect.textContent).toContain('Search query');
+
+    expect(screen.queryAllByText(bookmark.query)).toHaveLength(1);
+
+    selectors.selectRerunJobInvocationResponse.mockImplementation(
+      () => jobInvocation
+    );
+  });
 });

data/webpack/JobWizard/__tests__/fixtures.js

@@ -116,6 +116,22 @@ export const jobTemplateResponse = {
   ],
 };
 
+export const bookmarksList = [
+  { id: 19, name: 'my hosts', query: 'name ~ myhost', controller: 'hosts' },
+  {
+    id: 23,
+    name: 'active hosts',
+    query: 'last_report > "1 hour ago"',
+    controller: 'hosts',
+  },
+  {
+    id: 31,
+    name: 'dashboard default',
+    query: 'os = centos',
+    controller: 'dashboard',
+  },
+];
+
 export const jobCategories = ['Services', 'Ansible Commands', 'Puppet'];
 
 export const testSetup = (selectors, api) => {
@@ -176,6 +192,14 @@ export const testSetup = (selectors, api) => {
         subtotal: 3,
       },
     },
+    bookmarksPF4: {
+      hosts: {
+        results: bookmarksList,
+      },
+    },
+    API: {
+      BOOKMARKS_HOSTS: { status: 'RESOLVED', results: [] },
+    },
   });
   return store;
 };

data/webpack/JobWizard/autofill.js

@@ -1,7 +1,14 @@
-import { useEffect } from 'react';
-import { useDispatch } from 'react-redux';
+import { useEffect, useState } from 'react';
+import { useDispatch, useSelector } from 'react-redux';
 import { get } from 'foremanReact/redux/API';
-import { HOST_IDS, REX_FEATURE } from './JobWizardConstants';
+import { getBookmarks } from 'foremanReact/components/PF4/Bookmarks/BookmarksActions';
+import {
+  HOST_IDS,
+  REX_FEATURE,
+  hostsController,
+  hostsSearchProps,
+} from './JobWizardConstants';
+import { selectHostBookmarks } from './JobWizardSelectors';
 import './JobWizard.scss';
 
 export const useAutoFill = ({
@@ -9,11 +16,28 @@ export const useAutoFill = ({
   setFills,
   setSelectedTargets,
   setHostsSearchQuery,
+  setSelectedBookmark,
   setJobTemplateID,
   setTemplateValues,
   setAdvancedValues,
 }) => {
   const dispatch = useDispatch();
+  const bookmarks = useSelector(selectHostBookmarks);
+  const [pendingBookmarkId, setPendingBookmarkId] = useState(null);
+
+  useEffect(() => {
+    if (pendingBookmarkId === null || bookmarks.length === 0) return;
+    const bookmark = bookmarks.find(bm => bm.id === pendingBookmarkId);
+    if (bookmark) {
+      setSelectedBookmark({
+        id: bookmark.id,
+        name: bookmark.name,
+        query: bookmark.query,
+      });
+      setHostsSearchQuery(bookmark.query);
+    }
+    setPendingBookmarkId(null);
+  }, [bookmarks, pendingBookmarkId, setSelectedBookmark, setHostsSearchQuery]);
 
   useEffect(() => {
     if (Object.keys(fills).length) {
@@ -22,10 +46,12 @@ export const useAutoFill = ({
         search,
         feature,
         template_id: templateID,
+        bookmark_id: bookmarkId,
         ...rest
       } = { ...fills };
       setFills({});
       if (hostIds) {
+        setSelectedBookmark(null);
         const hostSearch = Array.isArray(hostIds)
           ? `id = ${hostIds.join(' or id = ')}`
           : `id = ${hostIds}`;
@@ -52,9 +78,34 @@ export const useAutoFill = ({
           })
         );
       }
-      if ((search || search === '') && !hostIds?.length) {
+      if (bookmarkId) {
+        setSelectedTargets({
+          hosts: [],
+          hostCollections: [],
+          hostGroups: [],
+        });
+        const numericId = Number(bookmarkId);
+        if (bookmarks.length > 0) {
+          const bookmark = bookmarks.find(bm => bm.id === numericId);
+          if (bookmark) {
+            setSelectedBookmark({
+              id: bookmark.id,
+              name: bookmark.name,
+              query: bookmark.query,
+            });
+            setHostsSearchQuery(bookmark.query);
+          }
+        } else {
+          setPendingBookmarkId(numericId);
+          dispatch(
+            getBookmarks(hostsSearchProps.bookmarks.url, hostsController)
+          );
+        }
+      } else if ((search || search === '') && !hostIds?.length) {
         // replace an empty string search with a dummy search query to match all hosts
         // but only if search query was entered (based on presence of :search parameter)
+
+        setSelectedBookmark(null);
         const hostSearch = search === '' ? "name != ''" : search;
         setHostsSearchQuery(hostSearch);
       }
@@ -100,9 +151,11 @@ export const useAutoFill = ({
     setFills,
     setSelectedTargets,
     setHostsSearchQuery,
+    setSelectedBookmark,
     setJobTemplateID,
     setTemplateValues,
     setAdvancedValues,
     dispatch,
+    bookmarks,
   ]);
 };

data/webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js

@@ -125,7 +125,7 @@ describe('AdvancedFields', () => {
     const resourceSelectField = screen.getByLabelText(
       'adv resource select toggle'
     );
-    const searchField = screen.getByPlaceholderText('Filter...');
+    const searchField = screen.getByPlaceholderText('Search');
     const dateField = screen.getByLabelText('adv date datepicker');
     const timeField = screen.getByLabelText('adv date timepicker');
 
@@ -403,6 +403,11 @@ describe('AdvancedFields', () => {
 
       jest.advanceTimersByTime(10000);
     });
-    expect(newStore.getActions()).toMatchSnapshot('resource search');
+    const actions = newStore.getActions();
+    const resourceSearchAction = actions.filter(
+      action => action.key === 'ForemanTasksTask'
+    );
+    expect(resourceSearchAction).toHaveLength(2);
+    expect(String(resourceSearchAction[1].url)).toContain('name=some+search');
   });
 });

data/webpack/JobWizard/steps/HostsAndInputs/HostSearch.js

@@ -1,24 +1,47 @@
 import React from 'react';
 import PropTypes from 'prop-types';
+import { useSelector } from 'react-redux';
 import SearchBar from 'foremanReact/components/SearchBar';
-import { getControllerSearchProps } from 'foremanReact/constants';
-import { hostsController, hostQuerySearchID } from '../../JobWizardConstants';
+import { hostQuerySearchID, hostsSearchProps } from '../../JobWizardConstants';
+import { selectHostBookmarks } from '../../JobWizardSelectors';
+
+export const HostSearch = ({ value, setValue, onBookmarkMatch }) => {
+  const bookmarks = useSelector(selectHostBookmarks);
+
+  const handleSearchChange = search => {
+    setValue(search);
+    onBookmarkMatch(null);
+  };
+
+  const handleBookmarkSearch = query => {
+    const matched = bookmarks.find(
+      bookmark => bookmark.query && bookmark.query.trim() === query.trim()
+    );
+    if (matched) {
+      onBookmarkMatch({
+        id: matched.id,
+        name: matched.name,
+        query: matched.query,
+      });
+    } else {
+      onBookmarkMatch(null);
+    }
+  };
 
-export const HostSearch = ({ value, setValue }) => {
-  const props = getControllerSearchProps(hostsController, hostQuerySearchID);
   return (
     <div className="foreman-search-field">
       <SearchBar
         data={{
-          ...props,
+          ...hostsSearchProps,
           autocomplete: {
             id: hostQuerySearchID,
             url: '/hosts/auto_complete_search',
             searchQuery: value,
           },
         }}
-        onSearch={null}
-        onSearchChange={search => setValue(search)}
+        onSearch={handleBookmarkSearch}
+        onSearchChange={handleSearchChange}
+        bookmarksPosition="right"
       />
     </div>
   );
@@ -27,4 +50,5 @@ export const HostSearch = ({ value, setValue }) => {
 HostSearch.propTypes = {
   value: PropTypes.string.isRequired,
   setValue: PropTypes.func.isRequired,
+  onBookmarkMatch: PropTypes.func.isRequired,
 };

data/webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js

@@ -6,7 +6,12 @@ import * as api from 'foremanReact/redux/API';
 import * as routerSelectors from 'foremanReact/routes/RouterSelector';
 import { JobWizard } from '../../../JobWizard';
 import * as selectors from '../../../JobWizardSelectors';
-import { testSetup, mockApi, gqlMock } from '../../../__tests__/fixtures';
+import {
+  testSetup,
+  mockApi,
+  gqlMock,
+  bookmarksList,
+} from '../../../__tests__/fixtures';
 
 const store = testSetup(selectors, api);
 mockApi(api);
@@ -183,6 +188,95 @@ describe('Hosts', () => {
     expect(screen.queryAllByText('os=gnome')).toHaveLength(1);
   });
 
+  it('submits bookmark_id when search matches a bookmark', async () => {
+    const bookmark = bookmarksList[0];
+    routerSelectors.selectRouterLocation.mockImplementation(() => ({
+      search: '',
+    }));
+    const bookmarkStore = testSetup(selectors, api);
+    mockApi(api);
+
+    render(
+      <MockedProvider mocks={gqlMock} addTypename={false}>
+        <Provider store={bookmarkStore}>
+          <JobWizard />
+        </Provider>
+      </MockedProvider>
+    );
+
+    await act(async () => {
+      fireEvent.click(screen.getByText('Target hosts and inputs'));
+    });
+    await act(async () => {
+      fireEvent.click(screen.getByRole('button', { name: 'host method' }));
+    });
+    await act(async () => {
+      fireEvent.click(screen.getByText('Search query'));
+    });
+
+    await act(async () => {
+      fireEvent.click(
+        screen.getByRole('button', { name: 'bookmarks dropdown toggle' })
+      );
+    });
+    await act(async () => {
+      fireEvent.click(screen.getByText(bookmark.name));
+    });
+
+    await act(async () => {
+      fireEvent.click(screen.getByText('Review details'));
+    });
+    await act(async () => {
+      fireEvent.click(screen.getByText('Submit'));
+    });
+
+    const submitAction = bookmarkStore
+      .getActions()
+      .find(action => action?.key === 'JOB_INVOCATION');
+    expect(submitAction).toBeDefined();
+    const { job_invocation: invocation } = submitAction.params;
+    expect(invocation.bookmark_id).toBe(bookmark.id);
+    expect(invocation.search_query).toBeNull();
+  });
+
+  it('does not submit bookmark_id when search does not match a bookmark', async () => {
+    const customQuery = 'some custom query';
+    routerSelectors.selectRouterLocation.mockImplementation(() => ({
+      search: `search=${encodeURIComponent(customQuery)}`,
+    }));
+    const customStore = testSetup(selectors, api);
+    mockApi(api);
+
+    render(
+      <MockedProvider mocks={gqlMock} addTypename={false}>
+        <Provider store={customStore}>
+          <JobWizard />
+        </Provider>
+      </MockedProvider>
+    );
+
+    await act(async () => {
+      fireEvent.click(screen.getByText('Target hosts and inputs'));
+    });
+
+    expect(screen.queryAllByText(customQuery)).toHaveLength(1);
+
+    await act(async () => {
+      fireEvent.click(screen.getByText('Review details'));
+    });
+    await act(async () => {
+      fireEvent.click(screen.getByText('Submit'));
+    });
+
+    const submitAction = customStore
+      .getActions()
+      .find(action => action?.key === 'JOB_INVOCATION');
+    expect(submitAction).toBeDefined();
+    const { job_invocation: invocation } = submitAction.params;
+    expect(invocation.bookmark_id).toBeNull();
+    expect(invocation.search_query).toBe(customQuery);
+  });
+
   it('input fill from url', async () => {
     const inputText = 'test text';
     const advancedInputText = 'test adv text';

data/webpack/JobWizard/steps/HostsAndInputs/index.js

@@ -51,6 +51,7 @@ const HostsAndInputs = ({
   setSelected,
   hostsSearchQuery,
   setHostsSearchQuery,
+  setSelectedBookmark,
 }) => {
   const defaultHostMethod = hostsSearchQuery.length
     ? hostMethods.searchQuery
@@ -132,6 +133,7 @@ const HostsAndInputs = ({
 
   const clearSearch = () => {
     setHostsSearchQuery('');
+    setSelectedBookmark(null);
   };
   const [errorText, setErrorText] = useState(
     __('Please select at least one host')
@@ -156,6 +158,7 @@ const HostsAndInputs = ({
                 className="target-method-select"
                 toggleIcon={<FilterIcon />}
                 fieldId="host_methods"
+                toggleAriaLabel={__('host method')}
                 options={Object.values(hostMethods).filter(method => {
                   if (method === hostMethods.hostCollections && !withKatello) {
                     return false;
@@ -186,6 +189,7 @@ const HostsAndInputs = ({
               <HostSearch
                 setValue={setHostsSearchQuery}
                 value={hostsSearchQuery}
+                onBookmarkMatch={setSelectedBookmark}
               />
             )}
             {hostMethod === hostMethods.hosts && (
@@ -286,6 +290,7 @@ HostsAndInputs.propTypes = {
   setSelected: PropTypes.func.isRequired,
   hostsSearchQuery: PropTypes.string.isRequired,
   setHostsSearchQuery: PropTypes.func.isRequired,
+  setSelectedBookmark: PropTypes.func.isRequired,
 };
 
 export default HostsAndInputs;

data/webpack/JobWizard/steps/Schedule/__tests__/Schedule.test.js

@@ -55,6 +55,8 @@ const store = mockStore({
       subtotal: 3,
     },
   },
+  bookmarksPF4: {},
+  API: {},
 });
 jest.useFakeTimers();
 

data/webpack/JobWizard/submit.js

@@ -2,6 +2,14 @@ import { post } from 'foremanReact/redux/API';
 import { repeatTypes, JOB_INVOCATION } from './JobWizardConstants';
 import { buildHostQuery } from './steps/HostsAndInputs/buildHostQuery';
 
+const hasExplicitTargets = selectedTargets =>
+  selectedTargets.hosts.length > 0 ||
+  selectedTargets.hostCollections.length > 0 ||
+  selectedTargets.hostGroups.length > 0;
+
+const shouldSendBookmark = (selectedBookmark, selectedTargets) =>
+  selectedBookmark && !hasExplicitTargets(selectedTargets);
+
 export const submit = ({
   jobTemplateID,
   templateValues,
@@ -9,6 +17,7 @@ export const submit = ({
   scheduleValue,
   selectedTargets,
   hostsSearchQuery,
+  selectedBookmark,
   location,
   organization,
   feature,
@@ -110,8 +119,12 @@ export const submit = ({
       concurrency_control: {
         concurrency_level: concurrencyLevel,
       },
-      bookmark_id: null,
-      search_query: buildHostQuery(selectedTargets, hostsSearchQuery),
+      bookmark_id: shouldSendBookmark(selectedBookmark, selectedTargets)
+        ? selectedBookmark.id
+        : null,
+      search_query: shouldSendBookmark(selectedBookmark, selectedTargets)
+        ? null
+        : buildHostQuery(selectedTargets, hostsSearchQuery),
       description_format: description,
       execution_timeout_interval: timeoutToKill,
       feature,

data/webpack/react_app/components/RegistrationExtension/RexPull.js

@@ -4,9 +4,8 @@ import PropTypes from 'prop-types';
 
 import { translate as __ } from 'foremanReact/common/I18n';
 import LabelIcon from 'foremanReact/components/common/LabelIcon';
-import { Alert } from 'patternfly-react';
-
 import {
+  Alert,
   FormGroup,
   FormSelectOption,
   FormSelect,
@@ -26,11 +25,15 @@ const options = (value = '') => {
 };
 
 const pullWarning = (
-  <Alert type="info" isInline style={{ marginTop: '10px' }}>
-    {__(
+  <Alert
+    ouiaId="overrideAlert"
+    variant="info"
+    isInline
+    title={__(
       'Please make sure that the Smart Proxy is configured correctly for the Pull provider.'
     )}
-  </Alert>
+    style={{ marginTop: '10px' }}
+  />
 );
 
 function showPullWarning(valueFromParam, value) {

data/webpack/react_app/components/TargetingHosts/__tests__/__snapshots__/TargetingHostsPage.test.js.snap

@@ -14,6 +14,7 @@ exports[`TargetingHostsPage renders 1`] = `
       md={6}
     >
       <SearchBar
+        bookmarksPosition="left"
         data={
           Object {
             "autocomplete": Object {
@@ -31,9 +32,12 @@ exports[`TargetingHostsPage renders 1`] = `
             "controller": "hosts",
           }
         }
+        initialQuery=""
+        name={null}
         onBookmarkClick={[Function]}
-        onChange={[Function]}
         onSearch={[Function]}
+        onSearchChange={[Function]}
+        restrictedSearchQuery={[Function]}
       />
     </Col>
   </Row>

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foreman_remote_execution
 version: !ruby/object:Gem::Version
-  version: 16.5.3
+  version: 16.6.4
 platform: ruby
 authors:
 - Foreman Remote Execution team
 bindir: bin
 cert_chain: []
-date: 2026-03-31 00:00:00.000000000 Z
+date: 2026-06-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deface
@@ -37,34 +37,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 8.3.0
-- !ruby/object:Gem::Dependency
-  name: factory_bot_rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 4.8.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 4.8.0
-- !ruby/object:Gem::Dependency
-  name: rdoc
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: A plugin bringing remote execution to the Foreman, completing the config
   management functionality with remote management functionality.
 email:
@@ -448,7 +420,6 @@ files:
 - webpack/JobWizard/steps/AdvancedFields/DescriptionField.js
 - webpack/JobWizard/steps/AdvancedFields/Fields.js
 - webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js
-- webpack/JobWizard/steps/AdvancedFields/__tests__/__snapshots__/AdvancedFields.test.js.snap
 - webpack/JobWizard/steps/CategoryAndTemplate/CategoryAndTemplate.js
 - webpack/JobWizard/steps/CategoryAndTemplate/CategoryAndTemplate.test.js
 - webpack/JobWizard/steps/CategoryAndTemplate/index.js
@@ -503,7 +474,6 @@ files:
 - webpack/__mocks__/foremanReact/components/Head/index.js
 - webpack/__mocks__/foremanReact/components/HostDetails/DetailsCard/DefaultLoaderEmptyState.js
 - webpack/__mocks__/foremanReact/components/Pagination.js
-- webpack/__mocks__/foremanReact/components/SearchBar.js
 - webpack/__mocks__/foremanReact/components/ToastsList/index.js
 - webpack/__mocks__/foremanReact/components/common/ActionButtons/ActionButtons.js
 - webpack/__mocks__/foremanReact/constants.js
@@ -589,7 +559,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.6
+rubygems_version: 4.0.10
 specification_version: 4
 summary: A plugin bringing remote execution to the Foreman, completing the config
   management functionality with remote management functionality.

data/webpack/JobWizard/steps/AdvancedFields/__tests__/__snapshots__/AdvancedFields.test.js.snap

@@ -1,90 +0,0 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
-
-exports[`AdvancedFields search resources action: resource search 1`] = `
-Array [
-  Object {
-    "key": "JOB_CATEGORIES",
-    "type": "get",
-    "url": "/ui_job_wizard/categories",
-  },
-  Object {
-    "key": "HOST_IDS",
-    "params": Object {
-      "search": "id = 105 or id = 37",
-    },
-    "type": "get",
-    "url": "/api/hosts",
-  },
-  Object {
-    "key": "JOB_TEMPLATES",
-    "type": "get",
-    "url": URI {
-      "_deferred_build": true,
-      "_parts": Object {
-        "duplicateQueryParameters": false,
-        "escapeQuerySpace": true,
-        "fragment": null,
-        "hostname": null,
-        "password": null,
-        "path": "foreman/api/v2/job_templates",
-        "port": null,
-        "preventInvalidHostname": false,
-        "protocol": null,
-        "query": "search=job_category%3D%22Ansible+Commands%22&per_page=all",
-        "urn": null,
-        "username": null,
-      },
-      "_string": "",
-    },
-  },
-  Object {
-    "key": "JOB_TEMPLATE",
-    "type": "get",
-    "url": "/ui_job_wizard/template/178",
-  },
-  Object {
-    "key": "ForemanTasksTask",
-    "type": "get",
-    "url": URI {
-      "_deferred_build": true,
-      "_parts": Object {
-        "duplicateQueryParameters": false,
-        "escapeQuerySpace": true,
-        "fragment": null,
-        "hostname": null,
-        "password": null,
-        "path": "/ui_job_wizard/resources",
-        "port": null,
-        "preventInvalidHostname": false,
-        "protocol": null,
-        "query": "resource=ForemanTasks%3A%3ATask",
-        "urn": null,
-        "username": null,
-      },
-      "_string": "",
-    },
-  },
-  Object {
-    "key": "ForemanTasksTask",
-    "type": "get",
-    "url": URI {
-      "_deferred_build": true,
-      "_parts": Object {
-        "duplicateQueryParameters": false,
-        "escapeQuerySpace": true,
-        "fragment": null,
-        "hostname": null,
-        "password": null,
-        "path": "/ui_job_wizard/resources",
-        "port": null,
-        "preventInvalidHostname": false,
-        "protocol": null,
-        "query": "resource=ForemanTasks%3A%3ATask&name=some+search",
-        "urn": null,
-        "username": null,
-      },
-      "_string": "",
-    },
-  },
-]
-`;

data/webpack/__mocks__/foremanReact/components/SearchBar.js

@@ -1,19 +0,0 @@
-import React from 'react';
-import PropTypes from 'prop-types';
-
-const SearchBar = ({ onChange }) => (
-  <input
-    className="foreman-search"
-    onChange={onChange}
-    placeholder="Filter..."
-  />
-);
-export default SearchBar;
-
-SearchBar.propTypes = {
-  onChange: PropTypes.func,
-};
-
-SearchBar.defaultProps = {
-  onChange: () => null,
-};