foreman_remote_execution 16.3.1 → 16.4.0

data/webpack/JobWizard/steps/form/SearchSelect.js

@@ -1,4 +1,4 @@
-import React, { useState, useEffect } from 'react';
+import React, { useState, useEffect, useRef } from 'react';
 import PropTypes from 'prop-types';
 import {
   Select,
@@ -25,14 +25,13 @@ export const SearchSelect = ({
   const [onSearch, response, isLoading] = useNameSearch(apiKey, url);
   const [isOpen, setIsOpen] = useState(false);
   const [typingTimeout, setTypingTimeout] = useState(null);
+  const initializedRef = useRef(false);
   useEffect(() => {
-    onSearch(selected.name || '');
-    if (typingTimeout) {
-      return () => clearTimeout(typingTimeout);
+    if (!initializedRef.current) {
+      onSearch(selected.name || '');
+      initializedRef.current = true;
     }
-    return undefined;
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, []);
+  }, [onSearch, selected.name]);
   let selectOptions = [];
   if (response.subtotal > maxResults) {
     selectOptions = [

data/webpack/JobWizard/validation.js

@@ -46,8 +46,6 @@ export const useValidation = ({ advancedValues, templateValues }) => {
         setValid(currValid => ({ ...currValid, advanced: false }));
       }
     });
-
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [advancedValues, templateValues]);
+  }, [advancedValues, templateValues, templateInputs, advancedTemplateInputs]);
   return [valid, setValid];
 };

data/webpack/react_app/components/TargetingHosts/index.js

@@ -1,4 +1,4 @@
-import React, { useEffect, useState } from 'react';
+import React, { useEffect, useState, useCallback, useRef } from 'react';
 import { useSelector, useDispatch } from 'react-redux';
 
 import { get } from 'foremanReact/redux/API';
@@ -50,38 +50,55 @@ const WrappedTargetingHosts = () => {
   const [apiUrl, setApiUrl] = useState(getApiUrl(searchQuery, pagination));
   const intervalExists = useSelector(selectIntervalExists);
 
-  const handleSearch = (query, status) => {
-    const defaultPagination = { page: 1, per_page: pagination.per_page };
-    stopApiInterval();
-
-    setApiUrl(getApiUrl(buildSearchQuery(query, status), defaultPagination));
-    setSearchQuery(query);
-    setPagination(defaultPagination);
-  };
-
-  const handlePagination = args => {
-    stopApiInterval();
-    setPagination(args);
-    setApiUrl(getApiUrl(buildSearchQuery(searchQuery, statusFilter), args));
-  };
-
-  const stopApiInterval = () => {
+  const stopApiInterval = useCallback(() => {
     if (intervalExists) {
       dispatch(stopInterval(TARGETING_HOSTS));
     }
-  };
-
-  const getData = url =>
-    withInterval(
-      get({
-        key: TARGETING_HOSTS,
-        url,
-        handleError: () => {
-          dispatch(stopInterval(TARGETING_HOSTS));
-        },
-      }),
-      1000
-    );
+  }, [dispatch, intervalExists]);
+
+  // Use ref to avoid infinite loop from handleSearch depending on pagination.per_page
+  const perPageRef = useRef(pagination.per_page);
+
+  const handleSearch = useCallback(
+    (query, status) => {
+      const defaultPagination = { page: 1, per_page: perPageRef.current };
+      stopApiInterval();
+
+      setApiUrl(getApiUrl(buildSearchQuery(query, status), defaultPagination));
+      setSearchQuery(query);
+      setPagination(defaultPagination);
+    },
+    [stopApiInterval]
+  );
+
+  // Keep ref in sync with pagination
+  useEffect(() => {
+    perPageRef.current = pagination.per_page;
+  }, [pagination.per_page]);
+
+  const handlePagination = useCallback(
+    args => {
+      stopApiInterval();
+      setPagination(args);
+      setApiUrl(getApiUrl(buildSearchQuery(searchQuery, statusFilter), args));
+    },
+    [searchQuery, statusFilter, stopApiInterval]
+  );
+
+  const getData = useCallback(
+    url =>
+      withInterval(
+        get({
+          key: TARGETING_HOSTS,
+          url,
+          handleError: () => {
+            dispatch(stopInterval(TARGETING_HOSTS));
+          },
+        }),
+        1000
+      ),
+    [dispatch]
+  );
 
   useEffect(() => {
     dispatch(getData(apiUrl));
@@ -93,11 +110,11 @@ const WrappedTargetingHosts = () => {
     return () => {
       dispatch(stopInterval(TARGETING_HOSTS));
     };
-  }, [dispatch, apiUrl, autoRefresh]);
+  }, [dispatch, apiUrl, autoRefresh, getData]);
 
   useEffect(() => {
     handleSearch(searchQuery, statusFilter);
-  }, [statusFilter, searchQuery]);
+  }, [statusFilter, searchQuery, handleSearch]);
 
   return (
     <TargetingHostsPage

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foreman_remote_execution
 version: !ruby/object:Gem::Version
-  version: 16.3.1
+  version: 16.4.0
 platform: ruby
 authors:
 - Foreman Remote Execution team
 bindir: bin
 cert_chain: []
-date: 2025-11-11 00:00:00.000000000 Z
+date: 2026-01-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deface
@@ -223,6 +223,7 @@ files:
 - app/views/api/v2/remote_execution_features/index.json.rabl
 - app/views/api/v2/remote_execution_features/main.json.rabl
 - app/views/api/v2/remote_execution_features/show.json.rabl
+- app/views/api/v2/smart_proxies/ca_pubkey.json.rabl
 - app/views/api/v2/smart_proxies/pubkey.json.rabl
 - app/views/api/v2/subnets/remote_execution_proxies.json.rabl
 - app/views/api/v2/template_invocations/base.json.rabl
@@ -340,6 +341,7 @@ files:
 - db/migrate/20240522093412_add_smart_proxy_id_to_template_invocation.rb
 - db/migrate/20240522093413_migrate_smart_proxy_ids_to_template_invocations.rb
 - db/migrate/20241126150849_remove_remote_execution_workers_pool_size.rb
+- db/migrate/20250606125543_add_ca_pub_key_to_smart_proxy.rb
 - db/seeds.d/100-assign_features_with_templates.rb
 - db/seeds.d/20-permissions.rb
 - db/seeds.d/50-notification_blueprints.rb
@@ -606,7 +608,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.3
 specification_version: 4
 summary: A plugin bringing remote execution to the Foreman, completing the config
   management functionality with remote management functionality.