foreman_remote_execution 16.1.0 → 16.2.1

data/webpack/JobInvocationDetail/TemplateInvocation.js

@@ -57,9 +57,9 @@ export const TemplateInvocation = ({
   hostID,
   jobID,
   isInTableView,
+  isExpanded,
   hostName,
   hostProxy,
-  isExpanded,
 }) => {
   const intervalRef = useRef(null);
   const templateURL = showTemplateInvocationUrl(hostID, jobID);
@@ -67,72 +67,76 @@ export const TemplateInvocation = ({
 
   const status = useSelector(selectTemplateInvocationStatus(hostID));
   const response = useSelector(selectTemplateInvocation(hostID));
-  const finished = response.finished ?? true;
-  const autoRefresh = response.auto_refresh || false;
   const dispatch = useDispatch();
 
+  const responseRef = useRef(response);
   useEffect(() => {
-    const getData = async () => {
-      if (
-        (!isInTableView || (isInTableView && isExpanded)) &&
-        (Object.keys(response).length === 0 || autoRefresh)
-      ) {
-        dispatch(
-          APIActions.get({
-            url: templateURL,
-            key: `${GET_TEMPLATE_INVOCATION}_${hostID}`,
-            handleError: () => {
-              if (intervalRef.current) clearInterval(intervalRef.current);
-            },
-          })
-        );
-      }
+    responseRef.current = response;
+  }, [response]);
+
+  const [showOutputType, setShowOutputType] = useState({
+    stderr: true,
+    stdout: true,
+    debug: true,
+  });
+  const [showTemplatePreview, setShowTemplatePreview] = useState(false);
+  const [showCommand, setShowCommand] = useState(false);
+
+  useEffect(() => {
+    const dispatchFetch = () => {
+      dispatch(
+        APIActions.get({
+          url: templateURL,
+          key: `${GET_TEMPLATE_INVOCATION}_${hostID}`,
+        })
+      );
     };
-    getData();
-    if (!finished && autoRefresh) {
+
+    if (intervalRef.current) {
+      clearInterval(intervalRef.current);
+      intervalRef.current = null;
+    }
+
+    if (isExpanded) {
+      if (isEmpty(responseRef.current)) {
+        dispatchFetch();
+      }
+
       intervalRef.current = setInterval(() => {
-        getData();
+        const latestResponse = responseRef.current;
+        const finished = latestResponse?.finished ?? true;
+        // eslint-disable-next-line camelcase
+        const autoRefresh = latestResponse?.auto_refresh || false;
+
+        if (!finished && autoRefresh) {
+          dispatchFetch();
+        } else if (intervalRef.current) {
+          clearInterval(intervalRef.current);
+        }
       }, 5000);
     }
 
     return () => {
       if (intervalRef.current) {
         clearInterval(intervalRef.current);
-        intervalRef.current = null;
       }
     };
-  }, [
-    dispatch,
-    templateURL,
-    isExpanded,
-    isInTableView,
-    finished,
-    autoRefresh,
-    hostID,
-  ]);
+  }, [isExpanded, dispatch, templateURL, hostID]);
+
+  if (!isExpanded) {
+    return null;
+  }
+
+  if ((status === STATUS.PENDING && isEmpty(response)) || !response) {
+    return <Skeleton />;
+  }
 
   const errorMessage =
     response?.response?.data?.error?.message ||
     response?.response?.data?.error ||
     JSON.stringify(response);
-  const {
-    preview,
-    output,
-    input_values: inputValues,
-    task,
-    permissions,
-  } = response;
-  const { id: taskID, cancellable: taskCancellable } = task || {};
-  const [showOutputType, setShowOutputType] = useState({
-    stderr: true,
-    stdout: true,
-    debug: true,
-  });
-  const [showTemplatePreview, setShowTemplatePreview] = useState(false);
-  const [showCommand, setCommand] = useState(false);
-  if (status === STATUS.PENDING && isEmpty(response)) {
-    return <Skeleton />;
-  } else if (status === STATUS.ERROR) {
+
+  if (status === STATUS.ERROR) {
     return (
       <Alert
         ouiaId="template-invocation-error-alert"
@@ -146,6 +150,15 @@ export const TemplateInvocation = ({
     );
   }
 
+  const {
+    preview,
+    output,
+    input_values: inputValues,
+    task,
+    permissions,
+  } = response;
+  const { id: taskID, cancellable: taskCancellable } = task || {};
+
   return (
     <div
       id={`template-invocation-${hostID}`}
@@ -159,7 +172,7 @@ export const TemplateInvocation = ({
         setShowTemplatePreview={setShowTemplatePreview}
         showTemplatePreview={showTemplatePreview}
         showCommand={showCommand}
-        setShowCommand={setCommand}
+        setShowCommand={setShowCommand}
         newTabUrl={templateInvocationPageUrl(hostID, jobID)}
         isInTableView={isInTableView}
         copyToClipboard={

data/webpack/JobInvocationDetail/TemplateInvocationPage.js

@@ -36,6 +36,7 @@ const TemplateInvocationPage = ({
         hostID={hostID}
         jobID={jobID}
         isInTableView={false}
+        isExpanded
         hostName={hostName}
         hostProxy={hostProxy}
       />

data/webpack/JobInvocationDetail/__tests__/TableToolbarActions.test.js

@@ -196,7 +196,7 @@ describe('TableToolbarActions', () => {
       const rerunLink = screen.getByRole('link', { name: /rerun/i });
       expect(rerunLink).toBeEnabled();
       const expectedHref = foremanUrl(
-        `/job_invocations/42/rerun?search=(name~*) AND ((id ^ (101, 102, 103)))`
+        `/job_invocations/42/rerun?search=(job_invocation.id = 42) AND ((id ^ (101, 102, 103)))`
       );
       expect(rerunLink).toHaveAttribute('href', expectedHref);
     });

data/webpack/JobInvocationDetail/__tests__/TemplateInvocation.test.js

@@ -32,6 +32,7 @@ describe('TemplateInvocation', () => {
           hostID="1"
           jobID="1"
           isInTableView={false}
+          isExpanded
           hostName="example-host"
           hostProxy={{ name: 'example-proxy', href: '#' }}
         />
@@ -54,6 +55,7 @@ describe('TemplateInvocation', () => {
           hostID="1"
           jobID="1"
           isInTableView={false}
+          isExpanded
           hostName="example-host"
           hostProxy={{ name: 'example-proxy', href: '#' }}
         />
@@ -108,6 +110,7 @@ describe('TemplateInvocation', () => {
           hostID="1"
           jobID="1"
           isInTableView={false}
+          isExpanded
           hostName="example-host"
           hostProxy={{ name: 'example-proxy', href: '#' }}
         />
@@ -133,6 +136,7 @@ describe('TemplateInvocation', () => {
           hostID="1"
           jobID="1"
           isInTableView={false}
+          isExpanded
           hostName="example-host"
         />
       </Provider>

data/webpack/JobInvocationDetail/index.js

@@ -183,9 +183,9 @@ const JobInvocationDetailPage = ({
             id={id}
             targeting={targeting}
             failedCount={failed}
-            finished={finished}
             autoRefresh={autoRefresh}
             initialFilter={selectedFilter}
+            statusLabel={statusLabel}
             onFilterUpdate={handleFilterChange}
           />
         </SkeletonLoader>

data/webpack/JobWizard/Footer.js

@@ -1,4 +1,4 @@
-import React from 'react';
+import React, { useRef } from 'react';
 import { useSelector } from 'react-redux';
 import PropTypes from 'prop-types';
 import { Button, Tooltip, Spinner } from '@patternfly/react-core';
@@ -12,6 +12,8 @@ import { selectIsSubmitting } from './JobWizardSelectors';
 
 export const Footer = ({ canSubmit, onSave }) => {
   const isSubmitting = useSelector(selectIsSubmitting);
+  const tooltipRunOn = useRef(null);
+  const tooltipSkipTo = useRef(null);
   return (
     <WizardFooter>
       <WizardContextConsumer>
@@ -52,6 +54,7 @@ export const Footer = ({ canSubmit, onSave }) => {
                       : __('Fill all required fields in all the steps')}
                   </div>
                 }
+                triggerRef={tooltipRunOn}
               >
                 <Button
                   ouiaId="run-on-selected-hosts-footer"
@@ -59,6 +62,7 @@ export const Footer = ({ canSubmit, onSave }) => {
                   onClick={onSave}
                   isAriaDisabled={!canSubmit}
                   isDisabled={isSubmitting}
+                  ref={tooltipRunOn}
                 >
                   {__('Run on selected hosts')}
                 </Button>
@@ -73,6 +77,7 @@ export const Footer = ({ canSubmit, onSave }) => {
                         )}
                   </div>
                 }
+                triggerRef={tooltipSkipTo}
               >
                 <Button
                   ouiaId="skip-to-review-footer"
@@ -80,6 +85,7 @@ export const Footer = ({ canSubmit, onSave }) => {
                   onClick={() => goToStepByName(WIZARD_TITLES.review)}
                   isAriaDisabled={!canSubmit}
                   isDisabled={isSubmitting}
+                  ref={tooltipSkipTo}
                 >
                   {__('Skip to review')}
                 </Button>

data/webpack/JobWizard/steps/HostsAndInputs/buildHostQuery.js

@@ -18,7 +18,7 @@ export const buildHostQuery = (selected, search) => {
       .join(',')})`;
 
   let hostGroupsSearch;
-  if (hostCollections.length < MAX_NAME_ITEMS)
+  if (hostGroups.length < MAX_NAME_ITEMS)
     hostGroupsSearch = `hostgroup_fullname ^ (${hostGroups
       .map(({ name }) => nameEscape(name))
       .join(',')})`;

data/webpack/react_app/components/HostKebab/KebabItems.js

@@ -1,6 +1,6 @@
 import React from 'react';
 import { useSelector } from 'react-redux';
-import { DropdownItem } from '@patternfly/react-core/deprecated';
+import { DropdownItem } from '@patternfly/react-core';
 import { CodeIcon } from '@patternfly/react-icons';
 import { selectAPIResponse } from 'foremanReact/redux/API/APISelectors';
 import { translate as __ } from 'foremanReact/common/I18n';
@@ -16,9 +16,8 @@ const HostKebabItems = () => {
     <DropdownItem
       ouiaId="web-console-dropdown-item"
       icon={<CodeIcon />}
-      href={consoleUrl}
+      to={consoleUrl}
       target="_blank"
-      rel="noreferrer"
     >
       {__('Web Console')}
     </DropdownItem>

data/webpack/react_app/components/RecentJobsCard/RecentJobsCard.js

@@ -1,8 +1,7 @@
 import PropTypes from 'prop-types';
 import React, { useState } from 'react';
 
-import { Tabs, Tab, TabTitleText } from '@patternfly/react-core';
-import { DropdownItem } from '@patternfly/react-core/deprecated';
+import { DropdownItem, Tabs, Tab, TabTitleText } from '@patternfly/react-core';
 import CardTemplate from 'foremanReact/components/HostDetails/Templates/CardItem/CardTemplate';
 import { translate as __ } from 'foremanReact/common/I18n';
 import { foremanUrl } from 'foremanReact/common/helpers';
@@ -26,14 +25,14 @@ const RecentJobsCard = ({ hostDetails: { name, id } }) => {
       header={__('Recent jobs')}
       dropdownItems={[
         <DropdownItem
-          href={foremanUrl(`${JOB_BASE_URL}${id}`)}
+          to={foremanUrl(`${JOB_BASE_URL}${id}`)}
           key="link-to-all"
           ouiaId="link-to-all-dropdown-item"
         >
           {__('View all jobs')}
         </DropdownItem>,
         <DropdownItem
-          href={foremanUrl(
+          to={foremanUrl(
             `${JOB_BASE_URL}${id}+and+status+%3D+failed+or+status%3D+succeeded`
           )}
           key="link-to-finished"
@@ -42,14 +41,14 @@ const RecentJobsCard = ({ hostDetails: { name, id } }) => {
           {__('View finished jobs')}
         </DropdownItem>,
         <DropdownItem
-          href={foremanUrl(`${JOB_BASE_URL}${id}+and+status+%3D+running`)}
+          to={foremanUrl(`${JOB_BASE_URL}${id}+and+status+%3D+running`)}
           key="link-to-running"
           ouiaId="link-to-running-dropdown-item"
         >
           {__('View running jobs')}
         </DropdownItem>,
         <DropdownItem
-          href={foremanUrl(`${JOB_BASE_URL}${id}+and+status+%3D+queued`)}
+          to={foremanUrl(`${JOB_BASE_URL}${id}+and+status+%3D+queued`)}
           key="link-to-scheduled"
           ouiaId="link-to-scheduled-dropdown-item"
         >

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foreman_remote_execution
 version: !ruby/object:Gem::Version
-  version: 16.1.0
+  version: 16.2.1
 platform: ruby
 authors:
 - Foreman Remote Execution team
 bindir: bin
 cert_chain: []
-date: 2025-08-05 00:00:00.000000000 Z
+date: 2025-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deface