foreman_remote_execution 16.0.5 → 16.2.0

data/webpack/JobInvocationDetail/__tests__/TableToolbarActions.test.js

@@ -1,16 +1,20 @@
+import '@testing-library/jest-dom/extend-expect';
+import { fireEvent, render, screen, waitFor } from '@testing-library/react';
+import axios from 'axios';
+import { foremanUrl } from 'foremanReact/common/helpers';
+import { useAPI } from 'foremanReact/common/hooks/API/APIHooks';
 import React from 'react';
 import { Provider } from 'react-redux';
 import configureStore from 'redux-mock-store';
-import { render, screen, fireEvent, waitFor } from '@testing-library/react';
-import '@testing-library/jest-dom/extend-expect';
-import { useAPI } from 'foremanReact/common/hooks/API/APIHooks';
+
 import { CheckboxesActions } from '../CheckboxesActions';
 import * as selectors from '../JobInvocationSelectors';
 import { PopupAlert } from '../OpenAllInvocationsModal';
 
+jest.mock('axios');
 jest.mock('foremanReact/common/hooks/API/APIHooks');
-
 jest.mock('../JobInvocationSelectors');
+
 jest.mock('../JobInvocationConstants', () => ({
   ...jest.requireActual('../JobInvocationConstants'),
   templateInvocationPageUrl: jest.fn(
@@ -18,18 +22,15 @@ jest.mock('../JobInvocationConstants', () => ({
   ),
   DIRECT_OPEN_HOST_LIMIT: 3,
 }));
+
 selectors.selectItems.mockImplementation(() => ({
   targeting: { search_query: 'name~*' },
 }));
-selectors.selectHasPermission.mockImplementation(() => () => () => true);
+selectors.selectHasPermission.mockImplementation(() => () => true);
+selectors.selectTaskCancelable.mockImplementation(() => true);
+
 const mockStore = configureStore([]);
-const store = mockStore({
-  templateInvocation: {
-    permissions: {
-      execute_jobs: true,
-    },
-  },
-});
+const store = mockStore({});
 
 describe('TableToolbarActions', () => {
   const jobID = '42';
@@ -38,6 +39,7 @@ describe('TableToolbarActions', () => {
   beforeEach(() => {
     openSpy = jest.spyOn(window, 'open').mockImplementation(jest.fn());
     useAPI.mockClear();
+    axios.post.mockResolvedValue({ data: {} });
     useAPI.mockReturnValue({
       response: null,
       status: 'initial',
@@ -68,7 +70,7 @@ describe('TableToolbarActions', () => {
       expect(openSpy).toHaveBeenCalledTimes(selectedIds.length);
     });
 
-    test('shows modal when results length is greater than 3', () => {
+    test('shows modal when results length is greater than 3', async () => {
       const selectedIds = [1, 2, 3, 4];
       render(
         <Provider store={store}>
@@ -83,13 +85,13 @@ describe('TableToolbarActions', () => {
         screen.getByLabelText(/open all template invocations in new tab/i)
       );
       expect(
-        screen.getByRole('heading', {
-          name: /open all %s invocations in new tabs \+ selected/i,
+        await screen.findByRole('heading', {
+          name: /open all.*invocations in new tabs \+ selected/i,
         })
       ).toBeInTheDocument();
     });
 
-    test('shows alert when popups are blocked', () => {
+    test('shows alert when popups are blocked', async () => {
       openSpy.mockReturnValue(null);
       const selectedIds = [1, 2];
       render(
@@ -105,7 +107,7 @@ describe('TableToolbarActions', () => {
         screen.getByLabelText(/open all template invocations in new tab/i)
       );
       expect(
-        screen.getByText(/Popups are blocked by your browser/)
+        await screen.findByText(/Popups are blocked by your browser/)
       ).toBeInTheDocument();
     });
   });
@@ -123,23 +125,23 @@ describe('TableToolbarActions', () => {
         </Provider>
       );
       fireEvent.click(screen.getByLabelText(/actions dropdown toggle/i));
-      fireEvent.click(screen.getByText(/open all failed runs/i));
+      fireEvent.click(await screen.findByText(/open all failed runs/i));
       await waitFor(() => {
         expect(openSpy).toHaveBeenCalledTimes(failedHosts.length);
       });
     });
 
-    test('shows modal when results length is greater than 3', () => {
+    test('shows modal when results length is greater than 3', async () => {
       render(
         <Provider store={store}>
           <CheckboxesActions selectedIds={[]} failedCount={4} jobID={jobID} />
         </Provider>
       );
       fireEvent.click(screen.getByLabelText(/actions dropdown toggle/i));
-      fireEvent.click(screen.getByText(/open all failed runs/i));
+      fireEvent.click(await screen.findByText(/open all failed runs/i));
       expect(
-        screen.getByRole('heading', {
-          name: /open all %s invocations in new tabs \+ failed/i,
+        await screen.findByRole('heading', {
+          name: /open all.*invocations in new tabs \+ failed/i,
         })
       ).toBeInTheDocument();
     });
@@ -152,7 +154,7 @@ describe('TableToolbarActions', () => {
       );
       expect(useAPI).toHaveBeenCalledWith(
         'get',
-        `foreman/api/job_invocations/${jobID}/hosts`,
+        foremanUrl(`/api/job_invocations/${jobID}/hosts`),
         expect.objectContaining({
           skip: true,
         })
@@ -193,9 +195,9 @@ describe('TableToolbarActions', () => {
       );
       const rerunLink = screen.getByRole('link', { name: /rerun/i });
       expect(rerunLink).toBeEnabled();
-      const expectedSearchParams = new URLSearchParams();
-      selectedIds.forEach(id => expectedSearchParams.append('host_ids[]', id));
-      const expectedHref = `foreman/job_invocations/42/rerun?search=(name~*) AND ((id ^ (101, 102, 103)))`;
+      const expectedHref = foremanUrl(
+        `/job_invocations/42/rerun?search=(job_invocation.id = 42) AND ((id ^ (101, 102, 103)))`
+      );
       expect(rerunLink).toHaveAttribute('href', expectedHref);
     });
   });

data/webpack/JobInvocationDetail/__tests__/TemplateInvocation.test.js

@@ -32,6 +32,7 @@ describe('TemplateInvocation', () => {
           hostID="1"
           jobID="1"
           isInTableView={false}
+          isExpanded
           hostName="example-host"
           hostProxy={{ name: 'example-proxy', href: '#' }}
         />
@@ -54,6 +55,7 @@ describe('TemplateInvocation', () => {
           hostID="1"
           jobID="1"
           isInTableView={false}
+          isExpanded
           hostName="example-host"
           hostProxy={{ name: 'example-proxy', href: '#' }}
         />
@@ -108,6 +110,7 @@ describe('TemplateInvocation', () => {
           hostID="1"
           jobID="1"
           isInTableView={false}
+          isExpanded
           hostName="example-host"
           hostProxy={{ name: 'example-proxy', href: '#' }}
         />
@@ -133,6 +136,7 @@ describe('TemplateInvocation', () => {
           hostID="1"
           jobID="1"
           isInTableView={false}
+          isExpanded
           hostName="example-host"
         />
       </Provider>

data/webpack/JobInvocationDetail/index.js

@@ -5,32 +5,31 @@ import {
   PageSectionVariants,
   Skeleton,
 } from '@patternfly/react-core';
-import { useAPI } from 'foremanReact/common/hooks/API/APIHooks';
+import React, { useEffect, useState } from 'react';
 import { translate as __, documentLocale } from 'foremanReact/common/I18n';
-import { stopInterval } from 'foremanReact/redux/middlewares/IntervalMiddleware';
+import { useDispatch, useSelector } from 'react-redux';
 import PageLayout from 'foremanReact/routes/common/PageLayout/PageLayout';
-import SkeletonLoader from 'foremanReact/components/common/SkeletonLoader';
 import PropTypes from 'prop-types';
-import React, { useEffect, useState } from 'react';
-import { useDispatch, useSelector } from 'react-redux';
+import SkeletonLoader from 'foremanReact/components/common/SkeletonLoader';
+import { stopInterval } from 'foremanReact/redux/middlewares/IntervalMiddleware';
+import { useAPI } from 'foremanReact/common/hooks/API/APIHooks';
 
 import { JobAdditionInfo } from './JobAdditionInfo';
+import JobInvocationHostTable from './JobInvocationHostTable';
+import JobInvocationOverview from './JobInvocationOverview';
+import JobInvocationSystemStatusChart from './JobInvocationSystemStatusChart';
+import JobInvocationToolbarButtons from './JobInvocationToolbarButtons';
 import { getJobInvocation, getTask } from './JobInvocationActions';
+import './JobInvocationDetail.scss';
 import {
   CURRENT_PERMISSIONS,
-  currentPermissionsUrl,
   DATE_OPTIONS,
   JOB_INVOCATION_KEY,
   STATUS,
   STATUS_UPPERCASE,
+  currentPermissionsUrl,
 } from './JobInvocationConstants';
-import JobInvocationHostTable from './JobInvocationHostTable';
-import JobInvocationOverview from './JobInvocationOverview';
 import { selectItems } from './JobInvocationSelectors';
-import JobInvocationSystemStatusChart from './JobInvocationSystemStatusChart';
-import JobInvocationToolbarButtons from './JobInvocationToolbarButtons';
-
-import './JobInvocationDetail.scss';
 
 const JobInvocationDetailPage = ({
   match: {
@@ -184,9 +183,9 @@ const JobInvocationDetailPage = ({
             id={id}
             targeting={targeting}
             failedCount={failed}
-            finished={finished}
             autoRefresh={autoRefresh}
             initialFilter={selectedFilter}
+            statusLabel={statusLabel}
             onFilterUpdate={handleFilterChange}
           />
         </SkeletonLoader>

data/webpack/Routes/routes.js

@@ -16,7 +16,7 @@ const ForemanREXRoutes = [
     render: props => <JobWizardPageRerun {...props} />,
   },
   {
-    path: '/experimental/job_invocations_detail/:id',
+    path: '/job_invocations/:id',
     exact: true,
     render: props => <JobInvocationDetailPage {...props} />,
   },

data/webpack/react_app/components/HostKebab/KebabItems.js

@@ -1,6 +1,6 @@
 import React from 'react';
 import { useSelector } from 'react-redux';
-import { DropdownItem } from '@patternfly/react-core/deprecated';
+import { DropdownItem } from '@patternfly/react-core';
 import { CodeIcon } from '@patternfly/react-icons';
 import { selectAPIResponse } from 'foremanReact/redux/API/APISelectors';
 import { translate as __ } from 'foremanReact/common/I18n';
@@ -16,9 +16,8 @@ const HostKebabItems = () => {
     <DropdownItem
       ouiaId="web-console-dropdown-item"
       icon={<CodeIcon />}
-      href={consoleUrl}
+      to={consoleUrl}
       target="_blank"
-      rel="noreferrer"
     >
       {__('Web Console')}
     </DropdownItem>

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foreman_remote_execution
 version: !ruby/object:Gem::Version
-  version: 16.0.5
+  version: 16.2.0
 platform: ruby
 authors:
 - Foreman Remote Execution team
 bindir: bin
 cert_chain: []
-date: 2025-07-28 00:00:00.000000000 Z
+date: 2025-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deface