foreman_remote_execution 16.0.3 → 16.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 40f170b56effb3a3f7f415ac040d45242641bc3210266bf723d957a4337e8aa2
-  data.tar.gz: c6a8e5a792629049aa8e40fdc2a3b6b20cc182af3e0e3d1578e5e3614525e7d0
+  metadata.gz: 263ac53880d0a4d4673659013457388598c58706f452a8f6db7c94df017ac634
+  data.tar.gz: c7806ab71384b036d0ce50e2f8b55c0f9c13095fcfc455dd8057d28fabc74682
 SHA512:
-  metadata.gz: 7b47defe2e23b8ce3ac1ebc08164749d7c2a03a133f78dfcb702c76cd4f434786b0dbeceb72c2d7ca47cedbd5d1f688175b9e0680245eac4e1064f9739d2b68c
-  data.tar.gz: c0d069ef4dde5b1a07cb38b60f0dcc7218487cc58a5a2961039f2603517a2fdc5060b603b4a13b5ff4c659a13b9b25eb836b59e5e3d6efbe1e69202364cc0f87
+  metadata.gz: 8c20ef4f8c84e5b57e3b1562dba4191d3552269d327de0ce51e7dd9d737db87a3e15a390abb60003568035e168adf2e3f3053fdbaf3f36a3f0e3282941081008
+  data.tar.gz: 33c31c42d97a26a67331097c545e731c3b44a4430e6c8a2ce26f516b4296db78908639ab410b5959128f182d58d05681d4fc46e495c95c6cce120b2a2ff25e80

data/app/controllers/api/v2/job_templates_controller.rb

@@ -108,8 +108,9 @@ module Api
       param :id, :identifier, :required => true
       param_group :job_template_clone, :as => :create
       def clone
+        original = @job_template
         @job_template = @job_template.clone
-        load_vars_from_template
+        @job_template.cloned_from = original
         @job_template.name = job_template_params[:name]
         process_response @job_template.save
       end

data/app/controllers/cockpit_controller.rb

@@ -2,7 +2,7 @@ class CockpitController < ApplicationController
   before_action :find_resource, :only => [:host_ssh_params]
 
   def host_ssh_params
-    render :json => SSHExecutionProvider.ssh_params(@host)
+    render :json => ScriptExecutionProvider.ssh_params(@host)
   end
 
   def redirect
@@ -10,7 +10,7 @@ class CockpitController < ApplicationController
 
     redir_url = URI.parse(params[:redirect_uri])
 
-    cockpit_url = SSHExecutionProvider.cockpit_url_for_host('')
+    cockpit_url = ScriptExecutionProvider.cockpit_url_for_host('')
     redir_url.query = if redir_url.hostname == URI.join(Setting[:foreman_url], cockpit_url).hostname
                         "access_token=#{request.session_options[:id]}"
                       else

data/app/helpers/hosts_extensions_helper.rb

@@ -44,7 +44,7 @@ module HostsExtensionsHelper
   def web_console_button(host, *_args)
     return if !authorized_for(permission: 'cockpit_hosts', auth_object: host) || !can_execute_on_infrastructure_host?(host)
 
-    url = SSHExecutionProvider.cockpit_url_for_host(host.name)
+    url = ScriptExecutionProvider.cockpit_url_for_host(host.name)
     url ? link_to(_('Web Console'), url, :class => 'btn btn-default', :id => :'web-console-button', :target => '_new') : nil
   end
 

data/app/lib/actions/remote_execution/run_host_job.rb

@@ -70,7 +70,7 @@ module Actions
                                  .merge(additional_options)
 
         plan_delegated_action(proxy, provider.proxy_action_class, action_options, proxy_action_class: ::Actions::RemoteExecution::ProxyAction)
-        plan_self :with_event_logging => true
+        plan_self
       end
 
       def finalize(*args)
@@ -127,32 +127,6 @@ module Actions
       end
 
       def fill_continuous_output(continuous_output)
-        if input[:with_event_logging]
-          continuous_output_from_template_invocation_events(continuous_output)
-          return
-        end
-
-        delegated_output.fetch('result', []).each do |raw_output|
-          continuous_output.add_raw_output(raw_output)
-        end
-
-        final_timestamp = (continuous_output.last_timestamp || task.ended_at).to_f + 1
-
-        if task.state == 'stopped' && task.result == 'cancelled'
-          continuous_output.add_output(_('Job cancelled by user'), 'debug', final_timestamp)
-        else
-          fill_planning_errors_to_continuous_output(continuous_output) unless exit_status
-        end
-        if exit_status
-          continuous_output.add_output(_('Exit status: %s') % exit_status, 'stdout', final_timestamp)
-        elsif run_step&.error
-          continuous_output.add_output(_('Job finished with error') + ": #{run_step.error.exception_class} - #{run_step.error.message}", 'debug', final_timestamp)
-        end
-      rescue => e
-        continuous_output.add_exception(_('Error loading data from proxy'), e)
-      end
-
-      def continuous_output_from_template_invocation_events(continuous_output)
         begin
           # Trigger reload
           delegated_output unless task.state == 'stopped'
@@ -160,6 +134,7 @@ module Actions
           # This is enough, the error will get shown using add_exception at the end of the method
         end
 
+        # Show the outputs which are already stored in the database
         task.template_invocation.template_invocation_events.order(:timestamp).find_each do |output|
           if output.event_type == 'exit'
             continuous_output.add_output(_('Exit status: %s') % output.event, 'stdout', output.timestamp)
@@ -167,11 +142,13 @@ module Actions
             continuous_output.add_raw_output(output.as_raw_continuous_output)
           end
         end
+
+        # Attach the exception at the end
         continuous_output.add_exception(_('Error loading data from proxy'), e) if e
       end
 
       def exit_status
-        input[:with_event_logging] ? task.template_invocation.template_invocation_events.find_by(event_type: 'exit')&.event : delegated_output[:exit_status]
+        task.template_invocation.template_invocation_events.find_by(event_type: 'exit')&.event
       end
 
       def host_id

data/app/models/concerns/foreman_remote_execution/host_extensions.rb

@@ -28,6 +28,8 @@ module ForemanRemoteExecution
           end
         }
 
+        after_build :reset_host_proxy_invocations
+
         def search_by_job_invocation(key, operator, value)
           if key == 'job_invocation.result'
             operator = operator == '=' ? 'IN' : 'NOT IN'
@@ -46,8 +48,12 @@ module ForemanRemoteExecution
       end
     end
 
+    def reset_host_proxy_invocations
+      HostProxyInvocation.where(host_id: self.id).delete_all
+    end
+
     def cockpit_url
-      SSHExecutionProvider.cockpit_url_for_host(self.name)
+      ScriptExecutionProvider.cockpit_url_for_host(self.name)
     end
 
     def execution_status(options = {})

data/app/models/job_template.rb

@@ -129,6 +129,11 @@ class JobTemplate < ::Template
     end
   end
 
+  def clone
+    deep_clone(:include => [:effective_user, :foreign_input_sets, :organizations, :locations],
+      :except => [:name, :locked])
+  end
+
   def provider
     RemoteExecutionProvider.provider_for(provider_type)
   end

data/app/models/{ssh_execution_provider.rb → script_execution_provider.rb}

@@ -40,7 +40,7 @@ class ScriptExecutionProvider < RemoteExecutionProvider
       proxy = proxy_for_cockpit(host)
       {
         :hostname => find_ip_or_hostname(host),
-        :proxy => proxy.class == Symbol ? proxy : proxy.url,
+        :proxy => proxy.instance_of?(Symbol) ? proxy : proxy.url,
         :ssh_user => ssh_user(host),
         :ssh_port => ssh_port(host),
         :ssh_password => ssh_password(host),
@@ -50,7 +50,7 @@ class ScriptExecutionProvider < RemoteExecutionProvider
     end
 
     def cockpit_url_for_host(host)
-      Setting[:remote_execution_cockpit_url] % { :host => host } if Setting[:remote_execution_cockpit_url].present?
+      format(Setting[:remote_execution_cockpit_url], host: host) if Setting[:remote_execution_cockpit_url].present?
     end
 
     def proxy_feature
@@ -76,5 +76,3 @@ class ScriptExecutionProvider < RemoteExecutionProvider
     end
   end
 end
-
-SSHExecutionProvider = ScriptExecutionProvider

data/config/initializers/inflections.rb

@@ -1,6 +1,5 @@
 Rails.autoloaders.each do |autoloader|
   autoloader.inflector.inflect(
-    'ssh_execution_provider' => 'SSHExecutionProvider',
     'remote_execution_ssh' => 'RemoteExecutionSSH'
   )
 end

data/lib/foreman_remote_execution/engine.rb

@@ -71,10 +71,10 @@ module ForemanRemoteExecution
                 full_name: N_('Effective User')
               setting 'remote_execution_effective_user_method',
                 type: :string,
-                description: N_('What command should be used to switch to the effective user. One of %s') % ::SSHExecutionProvider::EFFECTIVE_USER_METHODS.inspect,
+                description: N_('What command should be used to switch to the effective user. One of %s') % ::ScriptExecutionProvider::EFFECTIVE_USER_METHODS.inspect,
                 default: 'sudo',
                 full_name: N_('Effective User Method'),
-                collection: proc { Hash[::SSHExecutionProvider::EFFECTIVE_USER_METHODS.map { |method| [method, method] }] }
+                collection: proc { Hash[::ScriptExecutionProvider::EFFECTIVE_USER_METHODS.map { |method| [method, method] }] }
               setting 'remote_execution_effective_user_password',
                 type: :string,
                 description: N_('Effective user password'),
@@ -328,7 +328,7 @@ module ForemanRemoteExecution
       require_dependency 'foreman_tasks/task'
       ForemanTasks::Task.include ForemanRemoteExecution::ForemanTasksTaskExtensions
       ForemanTasks::Cleaner.include ForemanRemoteExecution::ForemanTasksCleanerExtensions
-      RemoteExecutionProvider.register(:SSH, ::SSHExecutionProvider)
+      RemoteExecutionProvider.register(:SSH, ::ScriptExecutionProvider)
       RemoteExecutionProvider.register(:script, ::ScriptExecutionProvider)
 
       ForemanRemoteExecution.register_rex_feature

data/lib/foreman_remote_execution/version.rb

@@ -1,3 +1,3 @@
 module ForemanRemoteExecution
-  VERSION = '16.0.3'.freeze
+  VERSION = '16.0.4'.freeze
 end

data/test/functional/api/v2/job_templates_controller_test.rb

@@ -90,6 +90,35 @@ module Api
         assert_response :unprocessable_entity
       end
 
+      test 'should clone locked template' do
+        @template.locked = true
+        @template.save!
+        post :clone, params: { :id => @template.to_param, :job_template => {:name => 'MyClone'} }
+        assert_response :success
+
+        template = ActiveSupport::JSON.decode(@response.body)
+        assert_equal(template['locked'], false)
+      end
+
+      test 'should clone template with associations' do
+        template2 = FactoryBot.create(:job_template)
+        @template.organizations << FactoryBot.create(:organization)
+        @template.locations << FactoryBot.create(:location)
+        @template.foreign_input_sets << FactoryBot.build(:foreign_input_set).tap { |fis| fis.target_template_id = template2.id }
+        @template.effective_user.value = 'toor'
+        @template.save!
+
+        post :clone, params: { :id => @template.to_param, :job_template => {:name => 'MyClone'} }
+        template = ActiveSupport::JSON.decode(@response.body)
+
+        clone = JobTemplate.unscoped.find(template['id'])
+        assert_equal(clone.organizations.sort, @template.organizations.sort)
+        assert_equal(clone.locations.sort, @template.locations.sort)
+        assert_equal(clone.foreign_input_sets.map(&:target_template_id), [template2.id])
+        assert_equal(clone.effective_user.value, 'toor')
+        assert_equal(clone.cloned_from.id, @template.id)
+      end
+
       test 'should export template' do
         get :export, params: { :id => @template.to_param }
         User.current = users(:admin)

data/test/unit/actions/run_host_job_test.rb

@@ -10,7 +10,7 @@ module ForemanRemoteExecution
       let(:job_invocation) { FactoryBot.create(:job_invocation, :with_task) }
       let(:host) { job_invocation.template_invocations.first.host }
       let(:provider) do
-        provider = ::SSHExecutionProvider
+        provider = ::ScriptExecutionProvider
         provider.expects(:ssh_password).with(host).returns('sshpass')
         provider.expects(:effective_user_password).with(host).returns('sudopass')
         provider.expects(:ssh_key_passphrase).with(host).returns('keypass')

data/test/unit/remote_execution_provider_test.rb

@@ -5,11 +5,11 @@ class RemoteExecutionProviderTest < ActiveSupport::TestCase
     let(:providers) { RemoteExecutionProvider.providers }
     it { assert_kind_of HashWithIndifferentAccess, providers }
     it 'makes providers accessible using symbol' do
-      assert_equal SSHExecutionProvider, providers[:SSH]
+      assert_equal ScriptExecutionProvider, providers[:SSH]
       assert_equal ScriptExecutionProvider, providers[:script]
     end
     it 'makes providers accessible using string' do
-      assert_equal SSHExecutionProvider, providers['SSH']
+      assert_equal ScriptExecutionProvider, providers['SSH']
       assert_equal ScriptExecutionProvider, providers['script']
     end
   end
@@ -27,11 +27,11 @@ class RemoteExecutionProviderTest < ActiveSupport::TestCase
 
   describe '.provider_for' do
     it 'accepts symbols' do
-      assert_equal SSHExecutionProvider, RemoteExecutionProvider.provider_for(:SSH)
+      assert_equal ScriptExecutionProvider, RemoteExecutionProvider.provider_for(:SSH)
     end
 
     it 'accepts strings' do
-      assert_equal SSHExecutionProvider, RemoteExecutionProvider.provider_for('SSH')
+      assert_equal ScriptExecutionProvider, RemoteExecutionProvider.provider_for('SSH')
     end
 
     it 'returns a default one if unknown value is provided' do
@@ -81,7 +81,7 @@ class RemoteExecutionProviderTest < ActiveSupport::TestCase
   describe '.provider_proxy_features' do
     it 'returns correct values' do
       RemoteExecutionProvider.stubs(:providers).returns(
-        :SSH => SSHExecutionProvider,
+        :SSH => ScriptExecutionProvider,
         :script => ScriptExecutionProvider
       )
 
@@ -112,15 +112,15 @@ class RemoteExecutionProviderTest < ActiveSupport::TestCase
     end
   end
 
-  describe SSHExecutionProvider do
+  describe ScriptExecutionProvider do
     before { User.current = FactoryBot.build(:user, :admin) }
     after { User.current = nil }
 
     let(:job_invocation) { FactoryBot.create(:job_invocation, :with_template) }
     let(:template_invocation) { job_invocation.pattern_template_invocations.first }
     let(:host) { FactoryBot.create(:host) }
-    let(:proxy_options) { SSHExecutionProvider.proxy_command_options(template_invocation, host) }
-    let(:secrets) { SSHExecutionProvider.secrets(host) }
+    let(:proxy_options) { ScriptExecutionProvider.proxy_command_options(template_invocation, host) }
+    let(:secrets) { ScriptExecutionProvider.secrets(host) }
 
     describe 'effective user' do
       it 'takes the effective user from value from the template invocation' do
@@ -153,11 +153,11 @@ class RemoteExecutionProviderTest < ActiveSupport::TestCase
         assert_equal 'sudo', proxy_options[:effective_user_method]
         method_param.update!(:value => 'su')
         host.clear_host_parameters_cache!
-        proxy_options = SSHExecutionProvider.proxy_command_options(template_invocation, host)
+        proxy_options = ScriptExecutionProvider.proxy_command_options(template_invocation, host)
         assert_equal 'su', proxy_options[:effective_user_method]
         method_param.update!(:value => 'dzdo')
         host.clear_host_parameters_cache!
-        proxy_options = SSHExecutionProvider.proxy_command_options(template_invocation, host)
+        proxy_options = ScriptExecutionProvider.proxy_command_options(template_invocation, host)
         assert_equal 'dzdo', proxy_options[:effective_user_method]
       end
     end
@@ -219,7 +219,7 @@ class RemoteExecutionProviderTest < ActiveSupport::TestCase
 
       it 'gets fqdn from flagged interfaces if not preferring ips' do
         # falling to primary interface
-        assert_equal 'somehost.somedomain.org', SSHExecutionProvider.find_ip_or_hostname(host)
+        assert_equal 'somehost.somedomain.org', ScriptExecutionProvider.find_ip_or_hostname(host)
 
         # execution wins if present
         execution_interface = FactoryBot.build(:nic_managed,
@@ -228,13 +228,13 @@ class RemoteExecutionProviderTest < ActiveSupport::TestCase
         host.primary_interface.update(:execution => false)
         host.interfaces.each(&:save)
         host.reload
-        assert_equal execution_interface.fqdn, SSHExecutionProvider.find_ip_or_hostname(host)
+        assert_equal execution_interface.fqdn, ScriptExecutionProvider.find_ip_or_hostname(host)
       end
 
       it 'gets ip from flagged interfaces' do
         host.host_params['remote_execution_connect_by_ip'] = true
         # no ip address set on relevant interface - fallback to fqdn
-        assert_equal 'somehost.somedomain.org', SSHExecutionProvider.find_ip_or_hostname(host)
+        assert_equal 'somehost.somedomain.org', ScriptExecutionProvider.find_ip_or_hostname(host)
 
         # provision interface with ip while primary without
         provision_interface = FactoryBot.build(:nic_managed,
@@ -243,12 +243,12 @@ class RemoteExecutionProviderTest < ActiveSupport::TestCase
         host.primary_interface.update(:provision => false)
         host.interfaces.each(&:save)
         host.reload
-        assert_equal provision_interface.ip, SSHExecutionProvider.find_ip_or_hostname(host)
+        assert_equal provision_interface.ip, ScriptExecutionProvider.find_ip_or_hostname(host)
 
         # both primary and provision interface have IPs: the primary wins
         host.primary_interface.update(:ip => '10.0.0.2', :execution => false)
         host.reload
-        assert_equal host.primary_interface.ip, SSHExecutionProvider.find_ip_or_hostname(host)
+        assert_equal host.primary_interface.ip, ScriptExecutionProvider.find_ip_or_hostname(host)
 
         # there is an execution interface with IP: it wins
         execution_interface = FactoryBot.build(:nic_managed,
@@ -257,7 +257,7 @@ class RemoteExecutionProviderTest < ActiveSupport::TestCase
         host.primary_interface.update(:execution => false)
         host.interfaces.each(&:save)
         host.reload
-        assert_equal execution_interface.ip, SSHExecutionProvider.find_ip_or_hostname(host)
+        assert_equal execution_interface.ip, ScriptExecutionProvider.find_ip_or_hostname(host)
 
         # there is an execution interface with both IPv6 and IPv4: IPv4 is being preferred over IPv6 by default
         execution_interface = FactoryBot.build(:nic_managed,
@@ -265,7 +265,7 @@ class RemoteExecutionProviderTest < ActiveSupport::TestCase
         host.interfaces = [execution_interface]
         host.interfaces.each(&:save)
         host.reload
-        assert_equal execution_interface.ip, SSHExecutionProvider.find_ip_or_hostname(host)
+        assert_equal execution_interface.ip, ScriptExecutionProvider.find_ip_or_hostname(host)
       end
 
       it 'gets ipv6 from flagged interfaces with IPv6 preference' do
@@ -278,7 +278,7 @@ class RemoteExecutionProviderTest < ActiveSupport::TestCase
         host.interfaces = [execution_interface]
         host.interfaces.each(&:save)
         host.reload
-        assert_equal execution_interface.ip6, SSHExecutionProvider.find_ip_or_hostname(host)
+        assert_equal execution_interface.ip6, ScriptExecutionProvider.find_ip_or_hostname(host)
       end
 
       it 'gets ipv6 from flagged interfaces with IPv4 preference but without IPv4 address' do
@@ -291,7 +291,7 @@ class RemoteExecutionProviderTest < ActiveSupport::TestCase
         host.interfaces = [execution_interface]
         host.interfaces.each(&:save)
         host.reload
-        assert_equal execution_interface.ip6, SSHExecutionProvider.find_ip_or_hostname(host)
+        assert_equal execution_interface.ip6, ScriptExecutionProvider.find_ip_or_hostname(host)
       end
     end
   end

data/webpack/JobInvocationDetail/JobInvocationConstants.js

@@ -83,7 +83,7 @@ const Columns = () => {
 
   return {
     expand: {
-      title: '',
+      title: ' ',
       weight: 0,
       wrapper: () => null,
     },
@@ -136,7 +136,7 @@ const Columns = () => {
       weight: 5,
     },
     actions: {
-      title: '',
+      title: ' ',
       weight: 6,
       wrapper: () => null,
     },

data/webpack/JobInvocationDetail/JobInvocationDetail.scss

@@ -7,6 +7,16 @@
     height: $chart_size;
     width: $chart_size;
     margin-bottom: 10px;
+
+    svg {
+      position: relative;
+      overflow: visible;
+      z-index: 999;
+    }
+
+    path {
+      cursor: pointer;
+    }
   }
 
   .chart-legend {
@@ -28,6 +38,10 @@
         font-weight: normal;
       }
     }
+
+    text, path {
+      cursor: pointer;
+    }
   }
 
   .pf-v5-c-divider {

data/webpack/JobInvocationDetail/JobInvocationHostTable.js

@@ -1,3 +1,4 @@
+/* eslint-disable max-lines */
 /* eslint-disable camelcase */
 import PropTypes from 'prop-types';
 import React, { useMemo, useEffect, useState } from 'react';
@@ -36,11 +37,20 @@ const JobInvocationHostTable = ({
   finished,
   autoRefresh,
   initialFilter,
+  onFilterUpdate,
 }) => {
   const columns = Columns();
   const columnNamesKeys = Object.keys(columns);
   const apiOptions = { key: JOB_INVOCATION_HOSTS };
-  const [selectedFilter, setSelectedFilter] = useState(initialFilter || '');
+  const [selectedFilter, setSelectedFilter] = useState(initialFilter);
+
+  useEffect(() => {
+    if (initialFilter !== selectedFilter) {
+      wrapSetSelectedFilter(initialFilter);
+    }
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [initialFilter]);
+
   const {
     searchParam: urlSearchQuery = '',
     page: urlPage,
@@ -111,6 +121,7 @@ const JobInvocationHostTable = ({
       return prevOptions;
     });
     setSelectedFilter(filter);
+    onFilterUpdate(filter);
   };
 
   useEffect(() => {
@@ -262,7 +273,7 @@ const JobInvocationHostTable = ({
                     expandId: 'host-expandable',
                   }}
                 />
-                {columnNamesKeys.slice(1).map(k => (
+                {columnNamesKeys.map(k => (
                   <Td key={k}>{columns[k].wrapper(result)}</Td>
                 ))}
                 <Td isActionCell>
@@ -275,7 +286,7 @@ const JobInvocationHostTable = ({
               >
                 <Td
                   dataLabel={`${result.id}-expandable-content`}
-                  colSpan={columnNamesKeys.length + 1}
+                  colSpan={columnNamesKeys.length}
                 >
                   <ExpandableRowContent>
                     {result.job_status === 'cancelled' ||
@@ -303,8 +314,11 @@ JobInvocationHostTable.propTypes = {
   finished: PropTypes.bool.isRequired,
   autoRefresh: PropTypes.bool.isRequired,
   initialFilter: PropTypes.string.isRequired,
+  onFilterUpdate: PropTypes.func,
 };
 
-JobInvocationHostTable.defaultProps = {};
+JobInvocationHostTable.defaultProps = {
+  onFilterUpdate: () => {},
+};
 
 export default JobInvocationHostTable;

data/webpack/JobInvocationDetail/JobInvocationSystemStatusChart.js

@@ -53,7 +53,6 @@ const JobInvocationSystemStatusChart = ({
   };
   const chartSize = 105;
   const [legendWidth, setLegendWidth] = useState(270);
-  const [cursor, setCursor] = useState('default');
 
   // Calculates chart legend width based on its content
   useEffect(() => {
@@ -79,7 +78,7 @@ const JobInvocationSystemStatusChart = ({
 
   return (
     <>
-      <FlexItem className="chart-donut" style={{ cursor }}>
+      <FlexItem className="chart-donut">
         <ChartDonut
           allowTooltip
           constrainToVisibleArea
@@ -96,12 +95,6 @@ const JobInvocationSystemStatusChart = ({
               target: 'data',
               eventHandlers: {
                 onClick: onChartClick,
-                onMouseOver: () => {
-                  setCursor('pointer');
-                },
-                onMouseOut: () => {
-                  setCursor('default');
-                },
               },
             },
           ]}
@@ -109,7 +102,12 @@ const JobInvocationSystemStatusChart = ({
             total > 0 ? chartData.map(d => d.color) : [emptyChartDonut.value]
           }
           labelComponent={
-            <ChartTooltip pointerLength={0} renderInPortal={false} />
+            <ChartTooltip
+              pointerLength={0}
+              renderInPortal={false}
+              constrainToVisibleArea
+              center={{ x: 15, y: 0 }}
+            />
           }
           title={chartDonutTitle}
           titleComponent={
@@ -133,7 +131,7 @@ const JobInvocationSystemStatusChart = ({
           height={chartSize}
         />
       </FlexItem>
-      <FlexItem className="chart-legend" style={{ cursor }}>
+      <FlexItem className="chart-legend">
         <Text ouiaId="legend-title" className="legend-title">
           {__('System status')}
         </Text>
@@ -156,24 +154,12 @@ const JobInvocationSystemStatusChart = ({
                 target: 'data',
                 eventHandlers: {
                   onClick: onChartClick,
-                  onMouseOver: () => {
-                    setCursor('pointer');
-                  },
-                  onMouseOut: () => {
-                    setCursor('default');
-                  },
                 },
               },
               {
                 target: 'labels',
                 eventHandlers: {
                   onClick: onChartClick,
-                  onMouseOver: () => {
-                    setCursor('pointer');
-                  },
-                  onMouseOut: () => {
-                    setCursor('default');
-                  },
                 },
               },
             ]}

data/webpack/JobInvocationDetail/index.js

@@ -55,8 +55,8 @@ const JobInvocationDetailPage = ({
   );
   const [selectedFilter, setSelectedFilter] = useState('');
 
-  const handleFilterChange = filter => {
-    setSelectedFilter(filter);
+  const handleFilterChange = newFilter => {
+    setSelectedFilter(newFilter);
   };
 
   let isAlreadyStarted = false;
@@ -119,6 +119,7 @@ const JobInvocationDetailPage = ({
             data={items}
             isAlreadyStarted={isAlreadyStarted}
             formattedStartDate={formattedStartDate}
+            onFilterChange={handleFilterChange}
           />
           <Divider
             orientation={{
@@ -155,6 +156,7 @@ const JobInvocationDetailPage = ({
             finished={finished}
             autoRefresh={autoRefresh}
             initialFilter={selectedFilter}
+            onFilterUpdate={handleFilterChange}
           />
         )}
       </PageSection>

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foreman_remote_execution
 version: !ruby/object:Gem::Version
-  version: 16.0.3
+  version: 16.0.4
 platform: ruby
 authors:
 - Foreman Remote Execution team
 bindir: bin
 cert_chain: []
-date: 2025-05-13 00:00:00.000000000 Z
+date: 2025-06-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deface
@@ -187,7 +187,7 @@ files:
 - app/models/remote_execution_feature.rb
 - app/models/remote_execution_provider.rb
 - app/models/rex_mail_notification.rb
-- app/models/ssh_execution_provider.rb
+- app/models/script_execution_provider.rb
 - app/models/target_remote_execution_proxy.rb
 - app/models/targeting.rb
 - app/models/targeting_host.rb