foreman_remote_execution 15.0.1 → 16.0.0

data/webpack/JobWizard/steps/Schedule/ScheduleRecurring.js

@@ -5,8 +5,10 @@ import {
   FormGroup,
   Radio,
   TextInput,
-  ValidatedOptions,
   Divider,
+  FormHelperText,
+  HelperText,
+  HelperTextItem,
 } from '@patternfly/react-core';
 import { ExclamationCircleIcon } from '@patternfly/react-icons';
 import { translate as __ } from 'foremanReact/common/I18n';
@@ -86,7 +88,7 @@ export const ScheduleRecurring = ({
       <WizardTitle title={SCHEDULE_TYPES.RECURRING} />
       <Form className="schedule-tab">
         <FormGroup label={__('Starts')} fieldId="schedule-starts">
-          <div className="pf-c-form">
+          <div className="pf-v5-cform">
             <FormGroup fieldId="schedule-starts-now">
               <Radio
                 ouiaId="schedule-start-now"
@@ -162,7 +164,7 @@ export const ScheduleRecurring = ({
         />
         <Divider component="div" />
         <FormGroup label={__('Ends')} fieldId="schedule-ends">
-          <div className="pf-c-form">
+          <div className="pf-v5-cform">
             <FormGroup fieldId="schedule-ends-never">
               <Radio
                 ouiaId="schedule-never-ends"
@@ -180,14 +182,7 @@ export const ScheduleRecurring = ({
                 label={__('Never')}
               />
             </FormGroup>
-            <FormGroup
-              fieldId="ends-on-date"
-              validated={
-                validEnd ? ValidatedOptions.noval : ValidatedOptions.error
-              }
-              helperTextInvalid={__('End time needs to be after start time')}
-              helperTextInvalidIcon={<ExclamationCircleIcon />}
-            >
+            <FormGroup fieldId="ends-on-date">
               <Radio
                 ouiaId="schedule-ends-on-date"
                 isChecked={!!ends}
@@ -219,6 +214,18 @@ export const ScheduleRecurring = ({
                   </div>
                 }
               />
+              {!validEnd && (
+                <FormHelperText>
+                  <HelperText>
+                    <HelperTextItem
+                      icon={<ExclamationCircleIcon />}
+                      variant="error"
+                    >
+                      {__('End time needs to be after start time')}
+                    </HelperTextItem>
+                  </HelperText>
+                </FormHelperText>
+              )}
             </FormGroup>
             <FormGroup fieldId="ends-after">
               <Radio
@@ -238,21 +245,24 @@ export const ScheduleRecurring = ({
                 label={
                   <div className="schedule-radio-wrapper">
                     <div className="schedule-radio-title">{__('After')}</div>
-                    <FormGroup
-                      helperTextInvalid={__(
-                        'Repeat amount can only be a positive number'
-                      )}
-                      validated={repeatValidated}
-                      className="schedule-radio-repeat-text"
-                    >
+                    <FormGroup className="schedule-radio-repeat-text">
                       <TextInput
                         ouiaId="repeat-amount"
                         id="repeat-amount"
                         value={repeatAmount || ''}
                         type="number"
-                        onChange={handleRepeatInputChange}
+                        onChange={(_event, newValue) =>
+                          handleRepeatInputChange(newValue)
+                        }
                         isDisabled={!(repeatAmount === 0 || !!repeatAmount)}
                       />
+                      {repeatValidated === 'error' && (
+                        <HelperText>
+                          <HelperTextItem variant="error">
+                            {__('Repeat amount can only be a positive number')}
+                          </HelperTextItem>
+                        </HelperText>
+                      )}
                     </FormGroup>
                     <div className="schedule-radio-occurences">
                       {__('occurences')}

data/webpack/JobWizard/steps/form/DateTimePicker.js

@@ -75,7 +75,7 @@ export const DateTimePicker = ({
     }
   };
 
-  const onTimeChange = newTime => {
+  const onTimeChange = (e, newTime) => {
     if (!newTime.length && allowEmpty) {
       const parsedNewTime = new Date(`${formattedDate} 00:00`);
       setDateTime(formatDateTime(parsedNewTime));

data/webpack/JobWizard/steps/form/FormHelpers.js

@@ -1,8 +1,9 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-import { Popover, Button } from '@patternfly/react-core';
+import { Popover, Button, Icon } from '@patternfly/react-core';
 import { HelpIcon } from '@patternfly/react-icons';
 import { translate as __ } from 'foremanReact/common/I18n';
+import styles from '@patternfly/react-styles/css/components/Form/form';
 
 export const helpLabel = (text, id) => {
   if (!text) return null;
@@ -12,9 +13,11 @@ export const helpLabel = (text, id) => {
         type="button"
         aria-label={__('open-help-tooltip-button')}
         onClick={e => e.preventDefault()}
-        className="pf-c-form__group-label-help"
+        className={styles.formGroupLabelHelp}
       >
-        <HelpIcon noVerticalAlign />
+        <Icon isInline>
+          <HelpIcon />
+        </Icon>
       </button>
     </Popover>
   );
@@ -31,7 +34,7 @@ export const ResetDefault = ({ setValue, defaultValue }) =>
       className="reset-default"
       component="a"
       variant="link"
-      isSmall
+      size="sm"
       onClick={() => setValue(defaultValue)}
     >
       {__('Reset to default')}

data/webpack/JobWizard/steps/form/Formatter.js

@@ -127,7 +127,9 @@ export const formatter = (input, values, setValue) => {
           rows={2}
           id={id}
           value={value}
-          onChange={newValue => setValue({ ...values, [name]: newValue })}
+          onChange={(_event, newValue) =>
+            setValue({ ...values, [name]: newValue })
+          }
         />
       </FormGroup>
     );

data/webpack/JobWizard/steps/form/GroupedSelectField.js

@@ -1,12 +1,12 @@
 import React, { useState } from 'react';
 import PropTypes from 'prop-types';
+import { FormGroup } from '@patternfly/react-core';
 import {
   SelectOption,
   Select,
   SelectGroup,
   SelectVariant,
-  FormGroup,
-} from '@patternfly/react-core';
+} from '@patternfly/react-core/deprecated';
 
 export const GroupedSelectField = ({
   label,
@@ -62,7 +62,7 @@ export const GroupedSelectField = ({
         ouiaId={fieldId}
         isGrouped
         variant={SelectVariant.typeahead}
-        onToggle={setIsOpen}
+        onToggle={(_event, val) => setIsOpen(val)}
         onFilter={onFilter}
         isOpen={isOpen}
         onSelect={() => null}

data/webpack/JobWizard/steps/form/NumberInput.js

@@ -1,6 +1,13 @@
 import React, { useState } from 'react';
 import PropTypes from 'prop-types';
-import { FormGroup, TextInput, ValidatedOptions } from '@patternfly/react-core';
+import {
+  FormGroup,
+  TextInput,
+  ValidatedOptions,
+  FormHelperText,
+  HelperText,
+  HelperTextItem,
+} from '@patternfly/react-core';
 import { translate as __ } from 'foremanReact/common/I18n';
 import { isPositiveNumber } from './FormHelpers';
 
@@ -8,17 +15,13 @@ export const NumberInput = ({ formProps, inputProps }) => {
   const [validated, setValidated] = useState();
   const name = inputProps.id.replace(/-/g, ' ');
   return (
-    <FormGroup
-      {...formProps}
-      helperTextInvalid={__('Has to be a positive number')}
-      validated={validated}
-    >
+    <FormGroup {...formProps}>
       <TextInput
         ouiaId={name}
         aria-label={name}
         type="text"
         {...inputProps}
-        onChange={newValue => {
+        onChange={(_event, newValue) => {
           setValidated(
             isPositiveNumber(newValue) || newValue === ''
               ? ValidatedOptions.noval
@@ -27,6 +30,13 @@ export const NumberInput = ({ formProps, inputProps }) => {
           inputProps.onChange(newValue);
         }}
       />
+      {validated === 'error' && (
+        <FormHelperText>
+          <HelperText>
+            <HelperTextItem>{__('Has to be a positive number')}</HelperTextItem>
+          </HelperText>
+        </FormHelperText>
+      )}
     </FormGroup>
   );
 };

data/webpack/JobWizard/steps/form/ResourceSelect.js

@@ -1,6 +1,10 @@
 import React, { useState, useEffect } from 'react';
 import PropTypes from 'prop-types';
-import { Select, SelectOption, SelectVariant } from '@patternfly/react-core';
+import {
+  Select,
+  SelectOption,
+  SelectVariant,
+} from '@patternfly/react-core/deprecated';
 import Immutable from 'seamless-immutable';
 import { sprintf, translate as __ } from 'foremanReact/common/I18n';
 import { useForemanSettings } from 'foremanReact/Root/Context/ForemanContext';
@@ -104,9 +108,9 @@ export const ResourceSelect = ({
       selections={selected}
       loadingVariant={isLoading ? 'spinner' : null}
       onSelect={onSelect}
-      onToggle={setIsOpen}
-      onFilter={onFilter}
-      onClear={onClear}
+      onToggle={(_event, val) => setIsOpen(val)}
+      onFilter={(_event, val) => onFilter(val)}
+      onClear={(_event, val) => onClear(val)}
       isOpen={isOpen}
       className="without_select2"
       maxHeight="45vh"

data/webpack/JobWizard/steps/form/SearchSelect.js

@@ -1,6 +1,10 @@
 import React, { useState, useEffect } from 'react';
 import PropTypes from 'prop-types';
-import { Select, SelectOption, SelectVariant } from '@patternfly/react-core';
+import {
+  Select,
+  SelectOption,
+  SelectVariant,
+} from '@patternfly/react-core/deprecated';
 import Immutable from 'seamless-immutable';
 import { sprintf, translate as __ } from 'foremanReact/common/I18n';
 import { DEBOUNCE_API } from '../../JobWizardConstants';
@@ -87,7 +91,7 @@ export const SearchSelect = ({
       }
       loadingVariant={isLoading ? 'spinner' : null}
       onSelect={onSelect}
-      onToggle={setIsOpen}
+      onToggle={(_event, val) => setIsOpen(val)}
       isOpen={isOpen}
       className="without_select2"
       maxHeight="45vh"

data/webpack/JobWizard/steps/form/SelectField.js

@@ -1,5 +1,6 @@
 import React, { useState } from 'react';
-import { FormGroup, Select, SelectOption } from '@patternfly/react-core';
+import { FormGroup } from '@patternfly/react-core';
+import { Select, SelectOption } from '@patternfly/react-core/deprecated';
 import PropTypes from 'prop-types';
 
 export const SelectField = ({
@@ -40,7 +41,7 @@ export const SelectField = ({
         ouiaId={fieldId}
         selections={value}
         onSelect={onSelect}
-        onToggle={setIsOpen}
+        onToggle={(_event, val) => setIsOpen(val)}
         isOpen={isOpen}
         className="without_select2"
         maxHeight="45vh"

data/webpack/react_app/components/FeaturesDropdown/index.js

@@ -6,7 +6,7 @@ import {
   Dropdown,
   DropdownToggle,
   DropdownToggleAction,
-} from '@patternfly/react-core';
+} from '@patternfly/react-core/deprecated';
 import { push } from 'connected-react-router';
 
 import { useAPI } from 'foremanReact/common/hooks/API/APIHooks';

data/webpack/react_app/components/FeaturesDropdown/index.scss

@@ -1,10 +1,10 @@
-#schedule-a-job-dropdown ul.pf-c-dropdown__menu {
+#schedule-a-job-dropdown ul.pf-v5-c-dropdown__menu {
   padding-left: 0;
   li {
     display: unset;
     a {
       font-size: 16px;
-      color: var(--pf-c-dropdown__menu-item--Color);
+      color: var(--pf-v5-cdropdown__menu-item--Color);
       font-weight: 300;
     }
   }

data/webpack/react_app/components/HostKebab/KebabItems.js

@@ -1,6 +1,6 @@
 import React from 'react';
 import { useSelector } from 'react-redux';
-import { DropdownItem } from '@patternfly/react-core';
+import { DropdownItem } from '@patternfly/react-core/deprecated';
 import { CodeIcon } from '@patternfly/react-icons';
 import { selectAPIResponse } from 'foremanReact/redux/API/APISelectors';
 import { translate as __ } from 'foremanReact/common/I18n';

data/webpack/react_app/components/RecentJobsCard/RecentJobsCard.js

@@ -1,7 +1,8 @@
 import PropTypes from 'prop-types';
 import React, { useState } from 'react';
 
-import { DropdownItem, Tabs, Tab, TabTitleText } from '@patternfly/react-core';
+import { Tabs, Tab, TabTitleText } from '@patternfly/react-core';
+import { DropdownItem } from '@patternfly/react-core/deprecated';
 import CardTemplate from 'foremanReact/components/HostDetails/Templates/CardItem/CardTemplate';
 import { translate as __ } from 'foremanReact/common/I18n';
 import { foremanUrl } from 'foremanReact/common/helpers';

data/webpack/react_app/components/RecentJobsCard/RecentJobsTable.js

@@ -1,7 +1,7 @@
 import PropTypes from 'prop-types';
 import React from 'react';
 import { Text, Bullseye } from '@patternfly/react-core';
-import { TableComposable, Tr, Tbody, Td } from '@patternfly/react-table';
+import { Table, Tr, Tbody, Td } from '@patternfly/react-table';
 import { STATUS } from 'foremanReact/constants';
 
 import RelativeDateTime from 'foremanReact/components/common/dates/RelativeDateTime';
@@ -41,7 +41,7 @@ const RecentJobsTable = ({ status, hostId }) => {
       }
     >
       {!!jobs?.length && (
-        <TableComposable
+        <Table
           ouiaId="recent-jobs-table"
           aria-label="recent-jobs-table"
           variant="compact"
@@ -72,7 +72,7 @@ const RecentJobsTable = ({ status, hostId }) => {
               )
             )}
           </Tbody>
-        </TableComposable>
+        </Table>
       )}
     </SkeletonLoader>
   );

data/webpack/react_app/components/RecentJobsCard/styles.scss

@@ -1,11 +1,11 @@
 .job-success {
-  color: var(--pf-global--success-color--100);
+  color: var(--pf-v5-global--success-color--100);
 }
 
 .job-error {
-  color: var(--pf-global--danger-color--100);
+  color: var(--pf-v5-global--danger-color--100);
 }
 
 .job-info {
-  color: var(--pf-global--info-color--200);
+  color: var(--pf-v5-global--info-color--200);
 }

data/webpack/react_app/components/RegistrationExtension/RexInterface.js

@@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
 
 import { translate as __ } from 'foremanReact/common/I18n';
 
-import { FormGroup, TextInput, Popover } from '@patternfly/react-core';
+import { FormGroup, TextInput, Popover, Icon } from '@patternfly/react-core';
 
 import { HelpIcon } from '@patternfly/react-icons';
 
@@ -20,10 +20,12 @@ const RexInterface = ({ isLoading, onChange }) => (
         }
       >
         <button
-          className="pf-c-form__group-label-help"
+          className="pf-v5-cform__group-label-help"
           onClick={e => e.preventDefault()}
         >
-          <HelpIcon noVerticalAlign />
+          <Icon isInline>
+            <HelpIcon />
+          </Icon>
         </button>
       </Popover>
     }

data/webpack/react_app/components/RegistrationExtension/RexPull.js

@@ -59,7 +59,7 @@ const RexPull = ({ isLoading, onChange, pluginValues, configParams }) => (
     <FormSelect
       ouiaId="registration_setup_remote_execution_pull"
       value={pluginValues.setupRemoteExecutionPull}
-      onChange={setupRemoteExecutionPull =>
+      onChange={(_event, setupRemoteExecutionPull) =>
         onChange({ setupRemoteExecutionPull })
       }
       className="without_select2"

data/webpack/react_app/components/RegistrationExtension/__tests__/__snapshots__/RexInterface.test.js.snap

@@ -13,14 +13,14 @@ exports[`RexInterface renders 1`] = `
       }
     >
       <button
-        className="pf-c-form__group-label-help"
+        className="pf-v5-cform__group-label-help"
         onClick={[Function]}
       >
-        <HelpIcon
-          color="currentColor"
-          noVerticalAlign={true}
-          size="sm"
-        />
+        <Icon
+          isInline={true}
+        >
+          <HelpIcon />
+        </Icon>
       </button>
     </Popover>
   }

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foreman_remote_execution
 version: !ruby/object:Gem::Version
-  version: 15.0.1
+  version: 16.0.0
 platform: ruby
 authors:
 - Foreman Remote Execution team
 bindir: bin
 cert_chain: []
-date: 2025-02-18 00:00:00.000000000 Z
+date: 2025-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deface
@@ -101,7 +101,6 @@ files:
 - app/assets/javascripts/foreman_remote_execution/execution_interface.js
 - app/assets/javascripts/foreman_remote_execution/job_templates.js
 - app/assets/javascripts/foreman_remote_execution/locale/de/foreman_remote_execution.js
-- app/assets/javascripts/foreman_remote_execution/locale/en/foreman_remote_execution.js
 - app/assets/javascripts/foreman_remote_execution/locale/en_GB/foreman_remote_execution.js
 - app/assets/javascripts/foreman_remote_execution/locale/es/foreman_remote_execution.js
 - app/assets/javascripts/foreman_remote_execution/locale/fr/foreman_remote_execution.js
@@ -360,8 +359,6 @@ files:
 - locale/Makefile
 - locale/de/LC_MESSAGES/foreman_remote_execution.mo
 - locale/de/foreman_remote_execution.po
-- locale/en/LC_MESSAGES/foreman_remote_execution.mo
-- locale/en/foreman_remote_execution.po
 - locale/en_GB/LC_MESSAGES/foreman_remote_execution.mo
 - locale/en_GB/foreman_remote_execution.po
 - locale/es/LC_MESSAGES/foreman_remote_execution.mo
@@ -438,6 +435,7 @@ files:
 - webpack/JobInvocationDetail/TemplateInvocationComponents/OutputToggleGroup.js
 - webpack/JobInvocationDetail/TemplateInvocationComponents/PreviewTemplate.js
 - webpack/JobInvocationDetail/TemplateInvocationComponents/TemplateActionButtons.js
+- webpack/JobInvocationDetail/TemplateInvocationComponents/index.scss
 - webpack/JobInvocationDetail/TemplateInvocationPage.js
 - webpack/JobInvocationDetail/__tests__/MainInformation.test.js
 - webpack/JobInvocationDetail/__tests__/OpenAlInvocations.test.js