foreman_remote_execution 13.0.0 → 13.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9a5e47997164244116ccb9c37d8eb7f7ec32b36d953ddcba6763ba86afc84a0f
-  data.tar.gz: ec69e4b0ef576ba474949648e164ba6d6bcd252bc4f9e501c7adaa8dc69b4da9
+  metadata.gz: 0c70b663aba31ca9cbe32da992a3bfa346232b535c720d578ade8a78772e0a38
+  data.tar.gz: 29b2f8d63af5a7a360b18db895805c3adc781042e06f928ac875b7a048f15090
 SHA512:
-  metadata.gz: e3cf4ecf6c5834264479776dad8342b039964664ab2ff9b388da168c9ad5337d7b2f013d435bf64e6aedc15929a0147e882d068883b1d1dabaeac82a09193f72
-  data.tar.gz: c41da5c789687b7374a4412c12d3a20befeda3a46d1ab087d12da91a053c82a1fd6d63164d4a11043cb4931c899012e2da9b57c1f250893ed1ec79a2db8e03a1
+  metadata.gz: 30c819eda158efaabec5b9aa47f01fd61bf9b92ff595f20e0646f5e91eae4ad1b4c9a5e05ffb7d0ecc442c19c211ed6b46e8eccaba831f36eef36886c11cd155
+  data.tar.gz: 2b60fb76b97d97b7491eb87b2c1c454d024b5be5ffa48de1acad41575eb9fd761a2d70aecda133b5d7f4604150c88524ca7606185b2fd2d0a86760eb4c9a9433

data/.eslintrc

@@ -6,5 +6,8 @@
   "extends": [
     "plugin:@theforeman/foreman/core",
     "plugin:@theforeman/foreman/plugins"
-  ]
+  ],
+  "rules":{
+    "@theforeman/rules/require-ouiaid": ["error"]
+  }
 }

data/.github/workflows/release.yml

@@ -1,8 +1,10 @@
 name: Release
 
 on:
-  create:
-    ref_type: tag
+  push:
+    # Pattern matched against refs/tags
+    tags:
+      - '**'
 
 jobs:
   release:

data/app/lib/actions/remote_execution/run_host_job.rb

@@ -204,20 +204,6 @@ module Actions
         host.refresh_global_status!
       end
 
-      def delegated_output
-        if input[:delegated_action_id]
-          super
-        elsif phase?(Present)
-          # for compatibility with old actions
-          old_action = all_planned_actions.first
-          if old_action
-            old_action.output.fetch('proxy_output', {})
-          else
-            {}
-          end
-        end
-      end
-
       def verify_permissions(host, template_invocation)
         raise _('User can not execute job on host %s') % host.name unless User.current.can?(:view_hosts, host)
         raise _('User can not execute this job template') unless User.current.can?(:view_job_templates, template_invocation.template)

data/app/models/concerns/foreman_remote_execution/host_extensions.rb

@@ -152,3 +152,11 @@ module ForemanRemoteExecution
     end
   end
 end
+
+module Host
+  class Managed
+    class Jail < Safemode::Jail
+      allow :execution_interface
+    end
+  end
+end

data/app/models/job_invocation_composer.rb

@@ -569,9 +569,10 @@ class JobInvocationComposer
   # builds input values for a given templates id based on params
   # omits inputs that belongs to unavailable templates
   def build_input_values_for(template_invocation, job_template_base)
-    template_invocation.input_values = job_template_base.fetch('input_values', {}).map do |attributes|
-      input = template_invocation.template.template_inputs_with_foreign.find { |i| i.id.to_s == attributes[:template_input_id].to_s }
-      input ? input.template_invocation_input_values.build(attributes) : nil
+    template_invocation.input_values = template_invocation.template.template_inputs_with_foreign.map do |input|
+      attributes = job_template_base.fetch('input_values', {}).find { |i| i[:template_input_id].to_s == input.id.to_s }
+      attributes = { "template_input_id" => input.id, "value" => input.default } if attributes.nil? && input.default
+      attributes ? input.template_invocation_input_values.build(attributes) : nil
     end.compact
     template_invocation.provider_input_values.build job_template_base.fetch('provider_input_values', [])
   end

data/app/views/api/v2/job_invocations/base.json.rabl

@@ -8,11 +8,13 @@ node do |invocation|
     :template_id => pattern_template&.template_id,
     :template_name => pattern_template&.template_name,
     :effective_user => pattern_template&.effective_user,
-    :succeeded => invocation_count(invocation, :output_key => :success_count),
-    :failed    => invocation_count(invocation, :output_key => :failed_count),
-    :pending   => invocation_count(invocation, :output_key => :pending_count),
+    :succeeded => invocation.progress_report[:success],
+    :failed    => invocation.progress_report[:error],
+    :pending   => invocation.progress_report[:pending],
+    :cancelled => invocation.progress_report[:cancelled],
     :total     => invocation_count(invocation, :output_key => :total_count),
     :missing   => invocation.missing_hosts_count,
+    :total_hosts => invocation.total_hosts_count,
   }
 end
 

data/app/views/templates/script/convert2rhel_analyze.erb

@@ -1,15 +1,6 @@
 <%#
 name: Convert2RHEL analyze
 snippet: false
-template_inputs:
-  - name: Data telemetry
-    required: false
-    input_type: user
-    options: "yes\r\nno"
-    advanced: false
-    value_type: plain
-    default: 'yes'
-    hidden_value: false
 model: JobTemplate
 job_category: Convert 2 RHEL
 provider_type: script
@@ -25,9 +16,7 @@ if ! rpm -q convert2rhel &> /dev/null; then
   yum install -y convert2rhel
 fi
 
-<% if input('Data telemetry') != "yes" -%>
-export CONVERT2RHEL_DISABLE_TELEMETRY=1
-<% end -%>
+export CONVERT2RHEL_THROUGH_FOREMAN=1
 
 /usr/bin/convert2rhel analyze -y
 

data/app/views/templates/script/package_action.erb

@@ -115,9 +115,19 @@ handle_zypp_res_codes () {
       end
     end
   -%>
+  OUTFILE=$(mktemp)
+  trap "rm -f $OUTFILE" EXIT
+  set -o pipefail
   export DEBIAN_FRONTEND=noninteractive
   apt-get -y update
-  apt-get -o APT::Get::Upgrade-Allow-New="true" -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" -y <%= input("options") %> <%= action %> <%= input("package") %>
+  LANG=C apt-get -o APT::Get::Upgrade-Allow-New="true" -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" -y <%= input("options") %> <%= action %> <%= input("package") %> 2>&1 | tee $OUTFILE
+  RETVAL=$?
+  if grep -q "Unable to locate" $OUTFILE; then
+    true
+  else
+    setReturnValue() { RETVAL=$1; return $RETVAL; }
+    setReturnValue $RETVAL
+  fi
 <% elsif package_manager == 'zypper' -%>
   <%-
     if action == "group install"

data/app/views/templates/script/puppet_run_once.erb

@@ -12,7 +12,7 @@ template_inputs:
   required: false
 feature: puppet_run_host
 %>
-<% if @host.operatingsystem.family == 'Debian' -%>
-export PATH=/opt/puppetlabs/bin:$PATH
-<% end -%>
+if [ -f /etc/profile.d/puppet-agent.sh ]; then
+  . /etc/profile.d/puppet-agent.sh
+fi
 puppet agent --onetime --no-usecacheonfailure --no-daemonize <%= input("puppet_options") %>

data/lib/foreman_remote_execution/version.rb

@@ -1,3 +1,3 @@
 module ForemanRemoteExecution
-  VERSION = '13.0.0'.freeze
+  VERSION = '13.1.0'.freeze
 end

data/package.json

@@ -19,11 +19,11 @@
   },
   "devDependencies": {
     "@babel/core": "^7.7.0",
-    "@theforeman/builder": "^12.0.1",
-    "@theforeman/eslint-plugin-foreman": "^12.0.1",
-    "@theforeman/eslint-plugin-rules": "^12.0.2",
-    "@theforeman/test": "^12.0.1",
-    "@theforeman/vendor-dev": "^12.0.1",
+    "@theforeman/builder": ">= 12.0.1",
+    "@theforeman/eslint-plugin-foreman": ">= 12.0.1",
+    "@theforeman/eslint-plugin-rules": ">= 12.0.2",
+    "@theforeman/test": ">= 12.0.1",
+    "@theforeman/vendor-dev": ">= 12.0.1",
     "babel-eslint": "^10.0.0",
     "eslint": "^6.8.0",
     "prettier": "^1.19.1",
@@ -32,6 +32,6 @@
     "graphql": "^15.5.0"
   },
   "peerDependencies": {
-    "@theforeman/vendor": "^12.0.1"
+    "@theforeman/vendor": ">= 12.0.1"
   }
 }

data/test/unit/job_invocation_composer_test.rb

@@ -35,6 +35,7 @@ class JobInvocationComposerTest < ActiveSupport::TestCase
   let(:trying_job_template_1) { FactoryBot.create(:job_template, :job_category => 'trying_job_template_1', :name => 'trying1', :provider_type => 'SSH') }
   let(:trying_job_template_2) { FactoryBot.create(:job_template, :job_category => 'trying_job_template_2', :name => 'trying2', :provider_type => 'Mcollective') }
   let(:trying_job_template_3) { FactoryBot.create(:job_template, :job_category => 'trying_job_template_1', :name => 'trying3', :provider_type => 'SSH') }
+  let(:trying_job_template_5) { FactoryBot.create(:job_template, :job_category => 'trying_job_template_5', :name => 'trying5', :provider_type => 'SSH') }
   let(:unauthorized_job_template_1) { FactoryBot.create(:job_template, :job_category => 'trying_job_template_1', :name => 'unauth1', :provider_type => 'SSH') }
   let(:unauthorized_job_template_2) { FactoryBot.create(:job_template, :job_category => 'unauthorized_job_template_2', :name => 'unauth2', :provider_type => 'Ansible') }
 
@@ -44,6 +45,7 @@ class JobInvocationComposerTest < ActiveSupport::TestCase
   let(:input2) { FactoryBot.create(:template_input, :template => trying_job_template_3, :input_type => 'user') }
   let(:input3) { FactoryBot.create(:template_input, :template => trying_job_template_1, :input_type => 'user', :required => true) }
   let(:input4) { FactoryBot.create(:template_input, :template => provider_inputs_job_template, :input_type => 'user') }
+  let(:input5) { FactoryBot.create(:template_input, :template => trying_job_template_5, :input_type => 'user', :default => 'value') }
   let(:unauthorized_input1) { FactoryBot.create(:template_input, :template => unauthorized_job_template_1, :input_type => 'user') }
 
   let(:ansible_params) { { } }
@@ -654,14 +656,40 @@ class JobInvocationComposerTest < ActiveSupport::TestCase
 
     context 'with with inputs' do
       let(:params) do
-        { :job_category => trying_job_template_1.job_category,
-          :job_template_id => trying_job_template_1.id,
+        { :job_category => trying_job_template_5.job_category,
+          :job_template_id => trying_job_template_5.id,
           :targeting_type => 'static_query',
           :search_query => 'some hosts',
-          :inputs => {input1.name => 'some_value'}}
+          :inputs => {input5.name => 'some_value'}}
       end
 
       it 'finds the inputs by name' do
+        assert composer.save!
+        values = composer.pattern_template_invocations.first.input_values
+        assert_equal 1, values.count
+        assert_equal 'some_value', values.first.value
+      end
+
+      it 'can be forced to be empty' do
+        params[:inputs] = {input5.name => ''}
+        assert composer.save!
+        values = composer.pattern_template_invocations.first.input_values
+        assert_equal 1, values.count
+        assert_equal '', values.first.value
+      end
+    end
+
+    context 'with inputs and default values' do
+      let(:params) do
+        { :job_category => trying_job_template_5.job_category,
+          :job_template_id => trying_job_template_5.id,
+          :targeting_type => 'static_query',
+          :search_query => 'some hosts',
+          :inputs => {}}
+      end
+
+      it 'uses the default input values' do
+        input5 # Force the factory to be materialized
         assert composer.save!
         assert_equal 1, composer.pattern_template_invocations.first.input_values.collect.count
       end

data/webpack/JobInvocationDetail/JobInvocationConstants.js

@@ -5,3 +5,13 @@ export const STATUS = {
   SUCCEEDED: 'succeeded',
   FAILED: 'failed',
 };
+
+export const DATE_OPTIONS = {
+  day: 'numeric',
+  month: 'short',
+  year: 'numeric',
+  hour: '2-digit',
+  minute: '2-digit',
+  hour12: false,
+  timeZoneName: 'short',
+};

data/webpack/JobInvocationDetail/JobInvocationDetail.scss

@@ -0,0 +1,38 @@
+.job-invocation-detail-page-section {
+  $chart_size: 105px;
+  
+  .chart-donut {
+    height: $chart_size;
+    width: $chart_size;
+    margin-bottom: 10px;
+  }
+
+  .chart-legend {
+    height: $chart_size;
+    min-width: 270px;
+
+    .legend-title {
+      font-weight: bold;
+      font-size: var(--pf-global--FontSize--sm);
+      margin-left: 8px;
+      margin-bottom: 0;
+    }
+
+    .pf-c-description-list {
+      margin-left: 8px;
+      margin-top: 8px;
+
+      .pf-c-description-list__term .pf-c-description-list__text {
+        font-weight: normal;
+      }
+    }
+  }
+
+  .pf-c-divider {
+    max-height: $chart_size;
+  }
+
+  .job-overview {
+    height: $chart_size;
+  }
+}

data/webpack/JobInvocationDetail/JobInvocationOverview.js

@@ -7,12 +7,15 @@ import {
   DescriptionListGroup,
   DescriptionListDescription,
 } from '@patternfly/react-core';
+import { translate as __ } from 'foremanReact/common/I18n';
 import DefaultLoaderEmptyState from 'foremanReact/components/HostDetails/DetailsCard/DefaultLoaderEmptyState';
-import { translate as __, documentLocale } from 'foremanReact/common/I18n';
 
-const JobInvocationOverview = ({ data }) => {
+const JobInvocationOverview = ({
+  data,
+  isAlreadyStarted,
+  formattedStartDate,
+}) => {
   const {
-    start_at: startAt,
     ssh_user: sshUser,
     template_id: templateId,
     template_name: templateName,
@@ -22,27 +25,6 @@ const JobInvocationOverview = ({ data }) => {
   const canEditJobTemplates = permissions
     ? permissions.edit_job_templates
     : false;
-  const dateOptions = {
-    day: 'numeric',
-    month: 'short',
-    year: 'numeric',
-    hour: '2-digit',
-    minute: '2-digit',
-    hour12: false,
-    timeZoneName: 'short',
-  };
-  let formattedStartDate = __('Not yet');
-
-  if (startAt) {
-    // Ensures date string compatibility across browsers
-    const convertedDate = new Date(startAt.replace(/[-.]/g, '/'));
-    if (convertedDate.getTime() <= new Date().getTime()) {
-      formattedStartDate = convertedDate.toLocaleString(
-        documentLocale(),
-        dateOptions
-      );
-    }
-  }
 
   return (
     <DescriptionList
@@ -63,7 +45,7 @@ const JobInvocationOverview = ({ data }) => {
       <DescriptionListGroup>
         <DescriptionListTerm>{__('Started at:')}</DescriptionListTerm>
         <DescriptionListDescription>
-          {formattedStartDate}
+          {isAlreadyStarted ? formattedStartDate : __('Not yet')}
         </DescriptionListDescription>
       </DescriptionListGroup>
       <DescriptionListGroup>
@@ -99,6 +81,12 @@ const JobInvocationOverview = ({ data }) => {
 
 JobInvocationOverview.propTypes = {
   data: PropTypes.object.isRequired,
+  isAlreadyStarted: PropTypes.bool.isRequired,
+  formattedStartDate: PropTypes.string,
+};
+
+JobInvocationOverview.defaultProps = {
+  formattedStartDate: undefined,
 };
 
 export default JobInvocationOverview;

data/webpack/JobInvocationDetail/JobInvocationSystemStatusChart.js

@@ -0,0 +1,153 @@
+import React, { useEffect, useState } from 'react';
+import PropTypes from 'prop-types';
+import { translate as __, sprintf } from 'foremanReact/common/I18n';
+import {
+  ChartDonut,
+  ChartLabel,
+  ChartLegend,
+  ChartTooltip,
+} from '@patternfly/react-charts';
+import {
+  DescriptionList,
+  DescriptionListTerm,
+  DescriptionListGroup,
+  DescriptionListDescription,
+  FlexItem,
+  Text,
+} from '@patternfly/react-core';
+import {
+  global_palette_green_500 as successedColor,
+  global_palette_red_100 as failedColor,
+  global_palette_blue_300 as inProgressColor,
+  global_palette_black_600 as canceledColor,
+  global_palette_black_500 as emptyChartDonut,
+} from '@patternfly/react-tokens';
+import DefaultLoaderEmptyState from 'foremanReact/components/HostDetails/DetailsCard/DefaultLoaderEmptyState';
+import './JobInvocationDetail.scss';
+
+const JobInvocationSystemStatusChart = ({
+  data,
+  isAlreadyStarted,
+  formattedStartDate,
+}) => {
+  const {
+    succeeded,
+    failed,
+    pending,
+    cancelled,
+    total,
+    total_hosts: totalHosts, // includes scheduled
+  } = data;
+  const chartData = [
+    { title: __('Succeeded:'), count: succeeded, color: successedColor.value },
+    { title: __('Failed:'), count: failed, color: failedColor.value },
+    { title: __('In Progress:'), count: pending, color: inProgressColor.value },
+    { title: __('Canceled:'), count: cancelled, color: canceledColor.value },
+  ];
+  const chartDonutTitle = () => {
+    if (total > 0) return `${succeeded.toString()}/${total}`;
+    if (totalHosts > 0) return `0/${totalHosts}`;
+    return '0';
+  };
+  const chartSize = 105;
+  const [legendWidth, setLegendWidth] = useState(270);
+
+  // Calculates chart legend width based on its content
+  useEffect(() => {
+    const legendContainer = document.querySelector('.chart-legend');
+    if (legendContainer) {
+      const rectElement = legendContainer.querySelector('rect');
+      if (rectElement) {
+        const rectWidth = parseFloat(rectElement.getAttribute('width'));
+        setLegendWidth(rectWidth);
+      }
+    }
+  }, [isAlreadyStarted, data]);
+
+  return (
+    <>
+      <FlexItem className="chart-donut">
+        <ChartDonut
+          allowTooltip
+          constrainToVisibleArea
+          data={
+            total > 0
+              ? chartData.map(d => ({
+                  label: sprintf(__(`${d.title} ${d.count} hosts`)),
+                  y: d.count,
+                }))
+              : [{ label: sprintf(__(`Scheduled: ${totalHosts} hosts`)), y: 1 }]
+          }
+          colorScale={
+            total > 0 ? chartData.map(d => d.color) : [emptyChartDonut.value]
+          }
+          labelComponent={
+            <ChartTooltip pointerLength={0} constrainToVisibleArea />
+          }
+          title={chartDonutTitle}
+          titleComponent={
+            // inline style overrides PatternFly default styling
+            <ChartLabel style={{ fontSize: '20px' }} />
+          }
+          subTitle={__('Systems')}
+          subTitleComponent={
+            // inline style overrides PatternFly default styling
+            <ChartLabel
+              style={{ fontSize: '12px', fill: canceledColor.value }}
+            />
+          }
+          padding={{
+            bottom: 0,
+            left: 0,
+            right: 0,
+            top: 0,
+          }}
+          width={chartSize}
+          height={chartSize}
+        />
+      </FlexItem>
+      <FlexItem className="chart-legend">
+        <Text ouiaId="legend-title" className="legend-title">
+          {__('System status')}
+        </Text>
+        {isAlreadyStarted ? (
+          <ChartLegend
+            orientation="vertical"
+            itemsPerRow={2}
+            gutter={25}
+            rowGutter={7}
+            padding={{ left: 15 }}
+            data={chartData.map(d => ({
+              name: `${d.title} ${d.count}`,
+              symbol: { type: 'circle' },
+            }))}
+            colorScale={chartData.map(d => d.color)}
+            width={legendWidth}
+            height={chartSize}
+          />
+        ) : (
+          <DescriptionList>
+            <DescriptionListGroup>
+              <DescriptionListTerm>{__('Scheduled at:')}</DescriptionListTerm>
+              <DescriptionListDescription>
+                {formattedStartDate || <DefaultLoaderEmptyState />}
+              </DescriptionListDescription>
+            </DescriptionListGroup>
+          </DescriptionList>
+        )}
+      </FlexItem>
+    </>
+  );
+};
+
+JobInvocationSystemStatusChart.propTypes = {
+  data: PropTypes.object.isRequired,
+  isAlreadyStarted: PropTypes.bool.isRequired,
+  formattedStartDate: PropTypes.string,
+};
+
+JobInvocationSystemStatusChart.defaultProps = {
+  formattedStartDate: undefined,
+};
+
+export default JobInvocationSystemStatusChart;

data/webpack/JobInvocationDetail/index.js

@@ -1,14 +1,20 @@
 import React, { useEffect } from 'react';
 import { useSelector, useDispatch } from 'react-redux';
 import PropTypes from 'prop-types';
-import { Divider, PageSection, Flex, FlexItem } from '@patternfly/react-core';
-import { translate as __ } from 'foremanReact/common/I18n';
+import { Divider, PageSection, Flex } from '@patternfly/react-core';
+import { translate as __, documentLocale } from 'foremanReact/common/I18n';
 import PageLayout from 'foremanReact/routes/common/PageLayout/PageLayout';
 import { stopInterval } from 'foremanReact/redux/middlewares/IntervalMiddleware';
 import { getData } from './JobInvocationActions';
 import { selectItems } from './JobInvocationSelectors';
 import JobInvocationOverview from './JobInvocationOverview';
-import { JOB_INVOCATION_KEY, STATUS } from './JobInvocationConstants';
+import JobInvocationSystemStatusChart from './JobInvocationSystemStatusChart';
+import {
+  JOB_INVOCATION_KEY,
+  STATUS,
+  DATE_OPTIONS,
+} from './JobInvocationConstants';
+import './JobInvocationDetail.scss';
 
 const JobInvocationDetailPage = ({
   match: {
@@ -17,11 +23,28 @@ const JobInvocationDetailPage = ({
 }) => {
   const dispatch = useDispatch();
   const items = useSelector(selectItems);
-  const { description, status_label: statusLabel, task } = items;
+  const {
+    description,
+    status_label: statusLabel,
+    task,
+    start_at: startAt,
+  } = items;
   const finished =
     statusLabel === STATUS.FAILED || statusLabel === STATUS.SUCCEEDED;
   const autoRefresh = task?.state === STATUS.PENDING || false;
 
+  let isAlreadyStarted = false;
+  let formattedStartDate;
+  if (startAt) {
+    // Ensures date string compatibility across browsers
+    const convertedDate = new Date(startAt.replace(/[-.]/g, '/'));
+    isAlreadyStarted = convertedDate.getTime() <= new Date().getTime();
+    formattedStartDate = convertedDate.toLocaleString(
+      documentLocale(),
+      DATE_OPTIONS
+    );
+  }
+
   useEffect(() => {
     dispatch(getData(`/api/job_invocations/${id}`));
     if (finished && !autoRefresh) {
@@ -48,17 +71,32 @@ const JobInvocationDetailPage = ({
       searchable={false}
     >
       <React.Fragment>
-        <PageSection isFilled variant="light">
-          <Flex>
-            <FlexItem> </FlexItem>
+        <PageSection
+          className="job-invocation-detail-page-section"
+          isFilled
+          variant="light"
+        >
+          <Flex alignItems={{ default: 'alignItemsFlexStart' }}>
+            <JobInvocationSystemStatusChart
+              data={items}
+              isAlreadyStarted={isAlreadyStarted}
+              formattedStartDate={formattedStartDate}
+            />
             <Divider
               orientation={{
                 default: 'vertical',
               }}
             />
-            <FlexItem>
-              <JobInvocationOverview data={items} />
-            </FlexItem>
+            <Flex
+              className="job-overview"
+              alignItems={{ default: 'alignItemsCenter' }}
+            >
+              <JobInvocationOverview
+                data={items}
+                isAlreadyStarted={isAlreadyStarted}
+                formattedStartDate={formattedStartDate}
+              />
+            </Flex>
           </Flex>
         </PageSection>
       </React.Fragment>

data/webpack/JobWizard/Footer.js

@@ -26,6 +26,7 @@ export const Footer = ({ canSubmit, onSave }) => {
           return (
             <>
               <Button
+                ouiaId="next-footer"
                 variant="primary"
                 type="submit"
                 onClick={onNext}
@@ -36,6 +37,7 @@ export const Footer = ({ canSubmit, onSave }) => {
                   : __('Next')}
               </Button>
               <Button
+                ouiaId="back-footer"
                 variant="secondary"
                 onClick={onBack}
                 isDisabled={
@@ -54,6 +56,7 @@ export const Footer = ({ canSubmit, onSave }) => {
                 }
               >
                 <Button
+                  ouiaId="run-on-selected-hosts-footer"
                   variant="tertiary"
                   onClick={onSave}
                   isAriaDisabled={!canSubmit}
@@ -74,6 +77,7 @@ export const Footer = ({ canSubmit, onSave }) => {
                 }
               >
                 <Button
+                  ouiaId="skip-to-review-footer"
                   variant="tertiary"
                   onClick={() => goToStepByName(WIZARD_TITLES.review)}
                   isAriaDisabled={!canSubmit}
@@ -82,7 +86,7 @@ export const Footer = ({ canSubmit, onSave }) => {
                   {__('Skip to review')}
                 </Button>
               </Tooltip>
-              <Button variant="link" onClick={onClose}>
+              <Button ouiaId="cancel-footer" variant="link" onClick={onClose}>
                 {__('Cancel')}
               </Button>
               {isSubmitting && (