foreman_remote_execution 11.1.3 → 12.0.1

data/db/migrate/20200623073022_rename_sudo_password_to_effective_user_password.rb

@@ -2,7 +2,7 @@ class RenameSudoPasswordToEffectiveUserPassword < ActiveRecord::Migration[6.0]
   def up
     rename_column :job_invocations, :sudo_password, :effective_user_password
 
-    Parameter.where(name: 'remote_execution_sudo_password').each do |parameter|
+    Parameter.where(name: 'remote_execution_sudo_password').find_each do |parameter|
       record = Parameter.find_by(type: parameter.type, reference_id: parameter.reference_id, name: "remote_execution_effective_user_password")
       if record.nil?
         parameter.update(name: "remote_execution_effective_user_password")
@@ -19,7 +19,7 @@ class RenameSudoPasswordToEffectiveUserPassword < ActiveRecord::Migration[6.0]
   def down
     rename_column :job_invocations, :effective_user_password, :sudo_password
 
-    Parameter.where(name: 'remote_execution_effective_user_password').each do |parameter|
+    Parameter.where(name: 'remote_execution_effective_user_password').find_each do |parameter|
       record = Parameter.find_by(type: parameter.type, reference_id: parameter.reference_id, name: "remote_execution_sudo_password")
       if record.nil?
         parameter.update(name: "remote_execution_sudo_password")

data/db/migrate/20220321101835_rename_ssh_provider_to_script.rb

@@ -6,7 +6,7 @@ class RenameSshProviderToScript < ActiveRecord::Migration[6.0]
     setting = Setting.find_by(:name => 'remote_execution_form_job_template')
     default_template = nil
 
-    Template.where(:provider_type => from).each do |t|
+    Template.where(:provider_type => from).find_each do |t|
       default_template = t if t.name == setting&.value
       t.provider_type = to
       t.name = t.name.gsub(from_re, new_label)

data/extra/cockpit/foreman-cockpit-session

@@ -124,7 +124,7 @@ class ProxyBuffer
 
   def write_available!
     count = @dst_io.write_nonblock(@buffer)
-    @buffer = @buffer[count..-1]
+    @buffer = @buffer[count..]
   rescue IO::WaitWritable
     0
   rescue IO::WaitReadable

data/foreman_remote_execution.gemspec

@@ -22,9 +22,11 @@ Gem::Specification.new do |s|
   s.test_files =       `git ls-files test`.split("\n")
   s.extra_rdoc_files = Dir['README*', 'LICENSE']
 
+  s.required_ruby_version = '>= 2.7', '< 4'
+
   s.add_dependency 'deface'
   s.add_dependency 'dynflow', '>= 1.0.2', '< 2.0.0'
-  s.add_dependency 'foreman-tasks', '>= 8.2.0'
+  s.add_dependency 'foreman-tasks', '>= 8.3.0'
 
   s.add_development_dependency 'factory_bot_rails', '~> 4.8.0'
   s.add_development_dependency 'rdoc'

data/lib/foreman_remote_execution/engine.rb

@@ -47,7 +47,7 @@ module ForemanRemoteExecution
 
     initializer 'foreman_remote_execution.register_plugin', before: :finisher_hook do |_app|
       Foreman::Plugin.register :foreman_remote_execution do
-        requires_foreman '>= 3.8'
+        requires_foreman '>= 3.9'
         register_global_js_file 'global'
         register_gettext
 
@@ -177,11 +177,8 @@ module ForemanRemoteExecution
                                             :'api/v2/job_templates' => [:update],
                                             :'api/v2/template_inputs' => [:create, :update, :destroy],
                                             :'api/v2/foreign_input_sets' => [:create, :update, :destroy]}, :resource_type => 'JobTemplate'
-          permission :view_remote_execution_features, { :remote_execution_features => [:index, :show],
-                                                        :'api/v2/remote_execution_features' => [:index, :show, :available_remote_execution_features]},
-            :resource_type => 'RemoteExecutionFeature'
-          permission :edit_remote_execution_features, { :remote_execution_features => [:update],
-                                                        :'api/v2/remote_execution_features' => [:update ]}, :resource_type => 'RemoteExecutionFeature'
+          permission :edit_remote_execution_features, { :remote_execution_features => [:index, :show, :update],
+                                                        :'api/v2/remote_execution_features' => [:index, :show, :update, :available_remote_execution_features]}, :resource_type => 'RemoteExecutionFeature'
           permission :destroy_job_templates, { :job_templates => [:destroy],
                                                :'api/v2/job_templates' => [:destroy] }, :resource_type => 'JobTemplate'
           permission :lock_job_templates, { :job_templates => [:lock, :unlock] }, :resource_type => 'JobTemplate'
@@ -207,7 +204,6 @@ module ForemanRemoteExecution
           :create_template_invocations,
           :view_hosts,
           :view_smart_proxies,
-          :view_remote_execution_features,
         ].freeze
         MANAGER_PERMISSIONS = USER_PERMISSIONS + [
           :cancel_job_invocations,
@@ -248,6 +244,12 @@ module ForemanRemoteExecution
           parent: :monitor_menu,
           after: :audits
 
+        menu :labs_menu, :job_invocations_detail,
+          url_hash: { controller: :job_invocations, action: :show },
+          caption: N_('Job invocations detail'),
+          parent: :lab_features_menu,
+          url: '/experimental/job_invocations_detail/1'
+
         register_custom_status HostStatus::ExecutionStatus
         # add dashboard widget
         # widget 'foreman_remote_execution_widget', name: N_('Foreman plugin template widget'), sizex: 4, sizey: 1
@@ -284,8 +286,10 @@ module ForemanRemoteExecution
           ::Dynflow::Action.descendants.select do |klass|
             klass <= ::Actions::ObservableAction
           end.map(&:namespaced_event_names) +
-          RemoteExecutionFeature.all.pluck(:label).map do |label|
-            ::Actions::RemoteExecution::RunHostJob.feature_job_event_name(label)
+          RemoteExecutionFeature.all.pluck(:label).flat_map do |label|
+            [::Actions::RemoteExecution::RunHostJob, ::Actions::RemoteExecution::RunHostsJob].map do |klass|
+              klass.feature_job_event_names(label)
+            end
           end
         )
       end
@@ -341,6 +345,7 @@ module ForemanRemoteExecution
 
       ForemanRemoteExecution.register_rex_feature
 
+      ::Api::V2::HostsController.include Api::V2::HostsControllerExtensions
       ::Api::V2::SubnetsController.include ::ForemanRemoteExecution::Concerns::Api::V2::SubnetsControllerExtensions
       ::Api::V2::RegistrationController.prepend ::ForemanRemoteExecution::Concerns::Api::V2::RegistrationControllerExtensions
       ::Api::V2::RegistrationController.include ::ForemanRemoteExecution::Concerns::Api::V2::RegistrationControllerExtensions::ApipieExtensions

data/lib/foreman_remote_execution/version.rb

@@ -1,3 +1,3 @@
 module ForemanRemoteExecution
-  VERSION = '11.1.3'.freeze
+  VERSION = '12.0.1'.freeze
 end

data/locale/Makefile

@@ -6,8 +6,8 @@
 # make tx-update - download and merge translations from Transifex
 # make clean - clean everything
 #
-DOMAIN = foreman_remote_execution
-VERSION = $(shell ruby -e 'require "rubygems";spec = Gem::Specification::load(Dir.glob("../*.gemspec")[0]);puts spec.version')
+DOMAIN = $(shell ruby -rrubygems -e 'puts Gem::Specification::load(Dir.glob("../*.gemspec")[0]).name')
+VERSION = $(shell ruby -rrubygems -e 'puts Gem::Specification::load(Dir.glob("../*.gemspec")[0]).version')
 POTFILE = $(DOMAIN).pot
 MOFILE = $(DOMAIN).mo
 POFILES = $(shell find . -name '$(DOMAIN).po')
@@ -43,7 +43,7 @@ uniq-po:
 	done
 
 tx-pull: $(EDITFILES)
-	cd .. && tx pull -f
+	cd .. && tx pull -f --all
 	for f in $(EDITFILES) ; do \
 		sed -i 's/^\("Project-Id-Version: \).*$$/\1$(DOMAIN) $(VERSION)\\n"/' $$f; \
 	done
@@ -61,4 +61,3 @@ mo-files: $(MOFILES)
 	@echo
 	@echo Changes commited!
 	@echo
-

data/locale/de/foreman_remote_execution.po

@@ -84,9 +84,6 @@ msgstr "Ein Benutzer, der für die Ausführung des Skripts verwendet werden soll
 msgid "Abort Job"
 msgstr "Job abbrechen"
 
-msgid "Action with sub plans"
-msgstr "Aktion mit Unterplänen"
-
 msgid "Actions"
 msgstr "Aktionen"
 
@@ -171,9 +168,6 @@ msgstr ""
 msgid "Category and template"
 msgstr ""
 
-msgid "Check for long running tasks"
-msgstr ""
-
 msgid "Choose a job template that is pre-selected in job invocation form"
 msgstr "Wählen Sie eine Jobvorlage, die im Jobaufrufformular vorausgewählt ist"
 
@@ -306,9 +300,6 @@ msgstr "Fremdeingabe-Satz löschen"
 msgid "Delete a job template"
 msgstr "Job-Vorlage löschen"
 
-msgid "Deliver notifications about long running tasks"
-msgstr ""
-
 msgid "Description"
 msgstr "Beschreibung"
 
@@ -372,6 +363,9 @@ msgstr "Das gültige Benutzerkennwort gilt nur für den SSH-Anbieter. Andere Anb
 msgid "Effective user password is only applicable for SSH provider. Other providers ignore this field. Password is stored encrypted in DB until the job finishes. For future or recurring executions, it is removed after the last execution."
 msgstr ""
 
+msgid "Effective user:"
+msgstr ""
+
 msgid "Enable Global Proxy"
 msgstr "Globalen Proxy aktivieren"
 
@@ -543,15 +537,9 @@ msgstr ""
 msgid "Import"
 msgstr "Import"
 
-msgid "Import Puppet classes"
-msgstr "Puppet-Klassen importieren"
-
 msgid "Import a job template from ERB"
 msgstr "Job-Vorlage aus ERB importieren"
 
-msgid "Import facts"
-msgstr "Fakten importieren"
-
 msgid "Include all inputs from the foreign template"
 msgstr "Alle Eingaben aus Fremdvorlage einschließen"
 
@@ -630,6 +618,9 @@ msgstr "Job-Aufrufe "
 msgid "Job invocations"
 msgstr "Job-Aufrufe "
 
+msgid "Job invocations detail"
+msgstr ""
+
 msgid "Job result"
 msgstr ""
 
@@ -735,6 +726,9 @@ msgstr "Niemals"
 msgid "New Job Template"
 msgstr "Neue Job-Vorlage"
 
+msgid "New UI"
+msgstr ""
+
 msgid "Next"
 msgstr ""
 
@@ -762,6 +756,9 @@ msgstr "Der Funktion %{feature_name} wurde keine Vorlage zugewiesen"
 msgid "Not all required inputs have values. Missing inputs: %s"
 msgstr "Nicht alle erforderlichen Eingaben haben Werte. Fehlende Eingaben: %s"
 
+msgid "Not yet"
+msgstr ""
+
 msgid "Now"
 msgstr ""
 
@@ -1004,6 +1001,9 @@ msgstr "Besondere Optionen des SSH-Anbieters"
 msgid "SSH user"
 msgstr ""
 
+msgid "SSH user:"
+msgstr ""
+
 msgid "Schedule"
 msgstr "Plan"
 
@@ -1133,6 +1133,9 @@ msgstr ""
 msgid "Started"
 msgstr "Gestartet"
 
+msgid "Started at:"
+msgstr ""
+
 msgid "Starts"
 msgstr "Beginnt"
 
@@ -1175,6 +1178,9 @@ msgstr "Erfolgreich"
 msgid "Success"
 msgstr "Erfolg"
 
+msgid "Switch to the new job invocation detail UI"
+msgstr ""
+
 msgid "Sync Job Templates"
 msgstr "Synchronisations Job-Vorlage"
 
@@ -1214,6 +1220,9 @@ msgstr "Vorlagenversion"
 msgid "Template with id '%{id}' was not found"
 msgstr "Vorlage mit ID '%{id}' nicht gefunden"
 
+msgid "Template:"
+msgstr ""
+
 msgid "Templates list failed with:"
 msgstr ""
 

data/locale/en/foreman_remote_execution.po

@@ -79,9 +79,6 @@ msgstr ""
 msgid "Abort Job"
 msgstr ""
 
-msgid "Action with sub plans"
-msgstr ""
-
 msgid "Actions"
 msgstr ""
 
@@ -166,9 +163,6 @@ msgstr ""
 msgid "Category and template"
 msgstr ""
 
-msgid "Check for long running tasks"
-msgstr ""
-
 msgid "Choose a job template that is pre-selected in job invocation form"
 msgstr ""
 
@@ -301,9 +295,6 @@ msgstr ""
 msgid "Delete a job template"
 msgstr ""
 
-msgid "Deliver notifications about long running tasks"
-msgstr ""
-
 msgid "Description"
 msgstr ""
 
@@ -367,6 +358,9 @@ msgstr ""
 msgid "Effective user password is only applicable for SSH provider. Other providers ignore this field. Password is stored encrypted in DB until the job finishes. For future or recurring executions, it is removed after the last execution."
 msgstr ""
 
+msgid "Effective user:"
+msgstr ""
+
 msgid "Enable Global Proxy"
 msgstr ""
 
@@ -538,15 +532,9 @@ msgstr ""
 msgid "Import"
 msgstr ""
 
-msgid "Import Puppet classes"
-msgstr ""
-
 msgid "Import a job template from ERB"
 msgstr ""
 
-msgid "Import facts"
-msgstr ""
-
 msgid "Include all inputs from the foreign template"
 msgstr ""
 
@@ -625,6 +613,9 @@ msgstr ""
 msgid "Job invocations"
 msgstr ""
 
+msgid "Job invocations detail"
+msgstr ""
+
 msgid "Job result"
 msgstr ""
 
@@ -730,6 +721,9 @@ msgstr ""
 msgid "New Job Template"
 msgstr ""
 
+msgid "New UI"
+msgstr ""
+
 msgid "Next"
 msgstr ""
 
@@ -757,6 +751,9 @@ msgstr ""
 msgid "Not all required inputs have values. Missing inputs: %s"
 msgstr ""
 
+msgid "Not yet"
+msgstr ""
+
 msgid "Now"
 msgstr ""
 
@@ -997,6 +994,9 @@ msgstr ""
 msgid "SSH user"
 msgstr ""
 
+msgid "SSH user:"
+msgstr ""
+
 msgid "Schedule"
 msgstr ""
 
@@ -1126,6 +1126,9 @@ msgstr ""
 msgid "Started"
 msgstr ""
 
+msgid "Started at:"
+msgstr ""
+
 msgid "Starts"
 msgstr ""
 
@@ -1168,6 +1171,9 @@ msgstr ""
 msgid "Success"
 msgstr ""
 
+msgid "Switch to the new job invocation detail UI"
+msgstr ""
+
 msgid "Sync Job Templates"
 msgstr ""
 
@@ -1207,6 +1213,9 @@ msgstr ""
 msgid "Template with id '%{id}' was not found"
 msgstr ""
 
+msgid "Template:"
+msgstr ""
+
 msgid "Templates list failed with:"
 msgstr ""
 

data/locale/en_GB/foreman_remote_execution.po

@@ -80,9 +80,6 @@ msgstr ""
 msgid "Abort Job"
 msgstr ""
 
-msgid "Action with sub plans"
-msgstr "Action with sub plans"
-
 msgid "Actions"
 msgstr "Actions"
 
@@ -167,9 +164,6 @@ msgstr ""
 msgid "Category and template"
 msgstr ""
 
-msgid "Check for long running tasks"
-msgstr ""
-
 msgid "Choose a job template that is pre-selected in job invocation form"
 msgstr ""
 
@@ -302,9 +296,6 @@ msgstr ""
 msgid "Delete a job template"
 msgstr ""
 
-msgid "Deliver notifications about long running tasks"
-msgstr ""
-
 msgid "Description"
 msgstr "Description"
 
@@ -368,6 +359,9 @@ msgstr ""
 msgid "Effective user password is only applicable for SSH provider. Other providers ignore this field. Password is stored encrypted in DB until the job finishes. For future or recurring executions, it is removed after the last execution."
 msgstr ""
 
+msgid "Effective user:"
+msgstr ""
+
 msgid "Enable Global Proxy"
 msgstr ""
 
@@ -539,15 +533,9 @@ msgstr ""
 msgid "Import"
 msgstr ""
 
-msgid "Import Puppet classes"
-msgstr "Import Puppet classes"
-
 msgid "Import a job template from ERB"
 msgstr ""
 
-msgid "Import facts"
-msgstr "Import facts"
-
 msgid "Include all inputs from the foreign template"
 msgstr ""
 
@@ -626,6 +614,9 @@ msgstr ""
 msgid "Job invocations"
 msgstr ""
 
+msgid "Job invocations detail"
+msgstr ""
+
 msgid "Job result"
 msgstr ""
 
@@ -731,6 +722,9 @@ msgstr ""
 msgid "New Job Template"
 msgstr ""
 
+msgid "New UI"
+msgstr ""
+
 msgid "Next"
 msgstr ""
 
@@ -758,6 +752,9 @@ msgstr ""
 msgid "Not all required inputs have values. Missing inputs: %s"
 msgstr ""
 
+msgid "Not yet"
+msgstr ""
+
 msgid "Now"
 msgstr ""
 
@@ -998,6 +995,9 @@ msgstr ""
 msgid "SSH user"
 msgstr ""
 
+msgid "SSH user:"
+msgstr ""
+
 msgid "Schedule"
 msgstr ""
 
@@ -1127,6 +1127,9 @@ msgstr ""
 msgid "Started"
 msgstr ""
 
+msgid "Started at:"
+msgstr ""
+
 msgid "Starts"
 msgstr ""
 
@@ -1169,6 +1172,9 @@ msgstr ""
 msgid "Success"
 msgstr "Success"
 
+msgid "Switch to the new job invocation detail UI"
+msgstr ""
+
 msgid "Sync Job Templates"
 msgstr ""
 
@@ -1208,6 +1214,9 @@ msgstr ""
 msgid "Template with id '%{id}' was not found"
 msgstr ""
 
+msgid "Template:"
+msgstr ""
+
 msgid "Templates list failed with:"
 msgstr ""
 

data/locale/es/foreman_remote_execution.po

@@ -80,9 +80,6 @@ msgstr "Un usuario que se debe utilizar para ejecutar el script. Si es distinto
 msgid "Abort Job"
 msgstr "Abortar trabajo"
 
-msgid "Action with sub plans"
-msgstr "Acción con subplanes"
-
 msgid "Actions"
 msgstr "Acciones"
 
@@ -167,9 +164,6 @@ msgstr "La lista de categorías falló con:"
 msgid "Category and template"
 msgstr ""
 
-msgid "Check for long running tasks"
-msgstr ""
-
 msgid "Choose a job template that is pre-selected in job invocation form"
 msgstr "Elija una plantilla de tarea que esté preseleccionada en el formulario de invocación de tarea"
 
@@ -302,9 +296,6 @@ msgstr "Eliminar un conjunto de entrada externo"
 msgid "Delete a job template"
 msgstr "Eliminar una plantilla de trabajo"
 
-msgid "Deliver notifications about long running tasks"
-msgstr ""
-
 msgid "Description"
 msgstr "Descripción"
 
@@ -368,6 +359,9 @@ msgstr "La contraseña de usuario efectiva sólo es aplicable al proveedor SSH.
 msgid "Effective user password is only applicable for SSH provider. Other providers ignore this field. Password is stored encrypted in DB until the job finishes. For future or recurring executions, it is removed after the last execution."
 msgstr "La contraseña de usuario efectiva sólo es aplicable al proveedor SSH. Otros proveedores ignoran este campo. La contraseña se almacena encriptada en la base de datos hasta que finaliza el trabajo. Para ejecuciones futuras o recurrentes, se elimina después de la última ejecución."
 
+msgid "Effective user:"
+msgstr ""
+
 msgid "Enable Global Proxy"
 msgstr "Activar proxy global"
 
@@ -539,15 +533,9 @@ msgstr ""
 msgid "Import"
 msgstr "Importar"
 
-msgid "Import Puppet classes"
-msgstr "Importar clases Puppet"
-
 msgid "Import a job template from ERB"
 msgstr "Importar una plantilla de trabajo desde ERB"
 
-msgid "Import facts"
-msgstr "Importar datos"
-
 msgid "Include all inputs from the foreign template"
 msgstr "Incluir todas las entradas de la plantilla externa"
 
@@ -626,6 +614,9 @@ msgstr "Invocación de trabajo"
 msgid "Job invocations"
 msgstr "Invocaciones de trabajo"
 
+msgid "Job invocations detail"
+msgstr ""
+
 msgid "Job result"
 msgstr "Resultado del trabajo"
 
@@ -731,6 +722,9 @@ msgstr "Nunca"
 msgid "New Job Template"
 msgstr "Nueva plantilla de trabajo"
 
+msgid "New UI"
+msgstr ""
+
 msgid "Next"
 msgstr ""
 
@@ -758,6 +752,9 @@ msgstr "No hay ninguna plantilla mapeada a la funcionalidad %{feature_name}."
 msgid "Not all required inputs have values. Missing inputs: %s"
 msgstr "No todas las entradas requeridas tienen valores. Entradas que faltan: %s"
 
+msgid "Not yet"
+msgstr ""
+
 msgid "Now"
 msgstr ""
 
@@ -998,6 +995,9 @@ msgstr "Opciones específicas del proveedor SSH"
 msgid "SSH user"
 msgstr ""
 
+msgid "SSH user:"
+msgstr ""
+
 msgid "Schedule"
 msgstr "Programa"
 
@@ -1127,6 +1127,9 @@ msgstr ""
 msgid "Started"
 msgstr "Inició"
 
+msgid "Started at:"
+msgstr ""
+
 msgid "Starts"
 msgstr "Comienza"
 
@@ -1169,6 +1172,9 @@ msgstr "exitoso"
 msgid "Success"
 msgstr "Éxito"
 
+msgid "Switch to the new job invocation detail UI"
+msgstr ""
+
 msgid "Sync Job Templates"
 msgstr "Sincronizar plantillas de trabajo"
 
@@ -1208,6 +1214,9 @@ msgstr "versión de plantilla"
 msgid "Template with id '%{id}' was not found"
 msgstr "No se encontró la plantilla con ID '%{id}'."
 
+msgid "Template:"
+msgstr ""
+
 msgid "Templates list failed with:"
 msgstr "Lista de plantillas falló con:"