foreman_remote_execution 1.5.0 → 1.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ba209c6348446c266991c2e6880200aaf8fb30bb
-  data.tar.gz: 3621380b18fd2c7da59ba1f7e4e099cdcd3a5fdf
+  metadata.gz: 9fcd52aa2585b165caee15553d3ceaaf4fc5cf69
+  data.tar.gz: d22298a49fa2ddc29e0d5c5ea022716461ecf527
 SHA512:
-  metadata.gz: 0c1fbd4411e47233b8b8b839b1bb104caefbf24438e5c4643218e93d0ebc07163e6abd6fa88175383849baca51fecb05b26b11e9ee9eaba4a74e70469dd3056a
-  data.tar.gz: 461ec40952a2b9490a65edb47a99048b807d26ca37c1d238586e61093c32cd07ccf8238a856fc9a7567b8c6653173a6df5dfee244fbf313237cab467009ae625
+  metadata.gz: bf01f416ab54076ae74f0e13aead95fa68604e6600bac1df9936991e65e3e24fbcfaf8f97ade5c68bcb3a6b25701e27368071bed6de27a31a13b59e875e13756
+  data.tar.gz: 3283109dbb5554f722c00bcf8632e9513521641354afcc1f86484e0eefc74da05797fd70bd522b0e95d68ead7a1b28767d9e86e18f4e1da292aa1f9ecf4f8ba3

data/.babelrc

@@ -0,0 +1,9 @@
+{
+  "presets": ["env", "react"],
+  "plugins": [
+    "transform-class-properties",
+    "transform-object-rest-spread",
+    "transform-object-assign",
+    "lodash"
+  ]
+}

data/.eslintignore

@@ -0,0 +1,3 @@
+# Ignore all files except webpack directory
+**/*.js
+!webpack/**/*.js

data/.eslintrc

@@ -0,0 +1,49 @@
+{
+  "root": true,
+  "extends": "airbnb-base",
+  "plugins": [
+    "react"
+  ],
+  "env": {
+    "browser": true,
+    "es6": true,
+    "node": true,
+    "jasmine": true,
+    "jest": true
+  },
+  "globals": {
+    "document": false,
+    "escape": false,
+    "navigator": false,
+    "unescape": false,
+    "window": false,
+    "$": true,
+    "_": true,
+    "__": true
+  },
+  "parser": "babel-eslint",
+  "rules": {
+    "react/jsx-uses-vars": "error",
+    "react/jsx-uses-react": "error",
+    "no-unused-vars": [
+      "error",
+      {
+        "vars": "all",
+        "args": "none"
+      }
+    ],
+    "no-underscore-dangle": "off",
+    "no-use-before-define": "off",
+    "import/prefer-default-export": "off",
+    "import/no-extraneous-dependencies": [
+      "error",
+      {
+        // Allow importing devDependencies like @storybook
+        "devDependencies": true
+      }
+    ],
+    // Import rules off for now due to HoundCI issue
+    "import/no-unresolved": "off",
+    "import/extensions": "off"
+  }
+}

data/.gitignore

@@ -12,3 +12,4 @@ locale/*/*.pox
 locale/*/*.edit.po
 locale/*/*.po.time_stamp
 Gemfile.lock
+node_modules/

data/.hound.yml

@@ -10,4 +10,9 @@ ruby:
 jshint:
   enabled: false
 
+eslint:
+  enabled: true
+  config_file: .eslintrc
+  ignore_file: .eslintignore
+
 fail_on_violations: true

data/.rubocop.yml

@@ -18,7 +18,10 @@ Style/Documentation:
 Metrics/MethodLength:
   Max: 40
 
-Style/TrailingCommaInLiteral:
+Style/TrailingCommaInArrayLiteral:
+  Enabled: false
+
+Style/TrailingCommaInHashLiteral:
   Enabled: false
 
 #Style/TrailingCommaInArguments:

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --exclude-limit 0`
-# on 2017-12-25 00:41:15 +0100 using RuboCop version 0.52.0.
+# on 2018-04-02 18:24:49 +0200 using RuboCop version 0.54.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -13,7 +13,7 @@
 Gemspec/OrderedDependencies:
   Enabled: false
 
-# Offense count: 16
+# Offense count: 17
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentOneStep, IndentationWidth.
 # SupportedStyles: case, end
@@ -25,22 +25,17 @@ Layout/CaseIndentation:
 Layout/EmptyLines:
   Enabled: false
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/EmptyLinesAroundArguments:
-  Enabled: false
-
-# Offense count: 8
+# Offense count: 7
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: empty_lines, no_empty_lines
 Layout/EmptyLinesAroundBlockBody:
   Enabled: false
 
-# Offense count: 22
+# Offense count: 20
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
-# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
+# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only
 Layout/EmptyLinesAroundClassBody:
   Enabled: false
 
@@ -51,12 +46,6 @@ Layout/EmptyLinesAroundClassBody:
 Layout/EmptyLinesAroundModuleBody:
   Enabled: false
 
-# Offense count: 907
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 204
-
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: Width, IgnoredPatterns.
@@ -70,7 +59,7 @@ Layout/IndentationWidth:
 Layout/MultilineOperationIndentation:
   Enabled: false
 
-# Offense count: 2
+# Offense count: 1
 # Cop supports --auto-correct.
 Layout/SpaceAfterComma:
   Enabled: false
@@ -81,7 +70,7 @@ Layout/SpaceAfterComma:
 Layout/SpaceAroundOperators:
   Enabled: false
 
-# Offense count: 44
+# Offense count: 46
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
 # SupportedStyles: space, no_space, compact
@@ -89,7 +78,7 @@ Layout/SpaceAroundOperators:
 Layout/SpaceInsideArrayLiteralBrackets:
   Enabled: false
 
-# Offense count: 97
+# Offense count: 85
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
 # SupportedStyles: space, no_space, compact
@@ -97,18 +86,28 @@ Layout/SpaceInsideArrayLiteralBrackets:
 Layout/SpaceInsideHashLiteralBraces:
   Enabled: false
 
-# Offense count: 6
+# Offense count: 5
 # Configuration parameters: MaximumRangeSize.
 Lint/MissingCopEnableDirective:
   Enabled: false
 
-# Offense count: 11
+# Offense count: 1
+# Cop supports --auto-correct.
+Lint/UnneededCopDisableDirective:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Lint/UnneededCopEnableDirective:
+  Enabled: false
+
+# Offense count: 10
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
 Lint/UnusedBlockArgument:
   Enabled: false
 
-# Offense count: 15
+# Offense count: 14
 # Cop supports --auto-correct.
 # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
 Lint/UnusedMethodArgument:
@@ -118,21 +117,45 @@ Lint/UnusedMethodArgument:
 Lint/UselessAssignment:
   Enabled: false
 
-# Offense count: 42
-Metrics/AbcSize:
-  Max: 40
-
-# Offense count: 3
+# Offense count: 5
 Metrics/CyclomaticComplexity:
   Max: 8
 
+# Offense count: 940
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 204
+
+# Offense count: 2
+Naming/MemoizedInstanceVariableName:
+  Enabled: false
+
+# Offense count: 3
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: io, id, to
+Naming/UncommunicativeMethodParamName:
+  Enabled: false
+
+# Offense count: 15
+# Cop supports --auto-correct.
+Rails/ActiveRecordAliases:
+  Enabled: false
+
 # Offense count: 7
 # Configuration parameters: Include.
 # Include: db/migrate/*.rb
 Rails/CreateTableWithTimestamps:
   Enabled: false
 
-# Offense count: 27
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: numeric, symbolic
+Rails/HttpStatus:
+  Enabled: false
+
+# Offense count: 23
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
 Rails/InverseOf:
@@ -144,7 +167,7 @@ Rails/InverseOf:
 Rails/LexicallyScopedActionFilter:
   Enabled: false
 
-# Offense count: 3
+# Offense count: 1
 # Cop supports --auto-correct.
 Rails/Presence:
   Enabled: false
@@ -171,20 +194,25 @@ Style/DoubleNegation:
 Style/Encoding:
   Enabled: false
 
-# Offense count: 18
+# Offense count: 7
+# Cop supports --auto-correct.
+Style/ExpandPathArguments:
+  Enabled: false
+
+# Offense count: 15
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: annotated, template, unannotated
 Style/FormatStringToken:
   Enabled: false
 
-# Offense count: 1481
+# Offense count: 1527
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
 # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
 Style/HashSyntax:
   Enabled: false
 
-# Offense count: 14
+# Offense count: 17
 # Cop supports --auto-correct.
 Style/IfUnlessModifier:
   Enabled: false
@@ -194,7 +222,7 @@ Style/IfUnlessModifier:
 Style/LineEndConcatenation:
   Enabled: false
 
-# Offense count: 17
+# Offense count: 22
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
@@ -213,14 +241,14 @@ Style/RaiseArgs:
 Style/RedundantReturn:
   Enabled: false
 
-# Offense count: 4
+# Offense count: 5
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
 # SupportedStyles: single_quotes, double_quotes
 Style/StringLiterals:
   Enabled: false
 
-# Offense count: 1
+# Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoredMethods.
 # IgnoredMethods: respond_to, define_method

data/.travis.yml

@@ -0,0 +1,6 @@
+language: node_js
+node_js:
+  - '6.10' # current EPEL 7
+  - '6' # previous LTS
+  - '8' # current LTS
+script: ./scripts/travis_run_js_tests.sh

data/app/assets/javascripts/foreman_remote_execution/template_invocation.js

@@ -91,7 +91,7 @@ function delayed_refresh(url, data){
         url: url,
         data: data,
         dataType: "script",
-        error: function() { $("div.terminal div.printable").append('<div class="line error">' + __('There was an error while updating the status, try refreshing the page.') + '</div>'); }
+        error: function() { $("div#job-invocation-chart").append('<div class="line error">' + __('There was an error while updating the status, try refreshing the page.') + '</div>'); }
       }
     )
   }, 1000);

data/app/assets/stylesheets/foreman_remote_execution/job_invocations.css.scss

@@ -1,7 +1,3 @@
-div#status_chart {
-  float: right;
-}
-
 div.infoblock {
   margin-bottom: 20px;
   line-height: 2;
@@ -9,14 +5,4 @@ div.infoblock {
   pre {
     margin-top: 5px;
   }
-
-  div.host_counter {
-    float: left;
-    min-width: 100px;
-    text-align: center;
-
-    .count {
-      font-size: 20px;
-    }
-  }
 }

data/app/controllers/job_invocations_controller.rb

@@ -1,6 +1,8 @@
 class JobInvocationsController < ApplicationController
   include ::Foreman::Controller::AutoCompleteSearch
   include ::ForemanTasks::Concerns::Parameters::Triggering
+  include ::JobInvocationsChartHelper
+
 
   def new
     return @composer = prepare_composer if params[:feature].present?
@@ -62,6 +64,20 @@ class JobInvocationsController < ApplicationController
     @composer = prepare_composer
   end
 
+  def chart
+    find_resource
+    render :json => {
+      :finished => @job_invocation.finished?,
+      :job_invocations => job_invocation_data(@job_invocation)[:columns],
+      :statuses => {
+        :success => @job_invocation.progress_report[:success],
+        :cancelled => @job_invocation.progress_report[:cancelled],
+        :failed => @job_invocation.progress_report[:error],
+        :pending => @job_invocation.progress_report[:pending]
+      },
+    }
+  end
+
   def preview_hosts
     composer = prepare_composer
 
@@ -103,6 +119,8 @@ class JobInvocationsController < ApplicationController
         'create'
       when 'cancel'
         'cancel'
+      when 'chart'
+        'view'
       else
         super
     end

data/app/helpers/job_invocations_chart_helper.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal:true
+
+module JobInvocationsChartHelper
+  def job_invocation_chart(invocation)
+    donut_chart('#status_chart',
+                job_invocation_data(invocation)[:columns],
+                job_invocation_data(invocation)[:groups])
+  end
+
+  def job_invocation_data(invocation)
+    return @job_invocation_data if @job_invocation_data.present?
+    progress_report = invocation.progress_report
+    success = progress_report[:success]
+    cancelled = progress_report[:cancelled]
+    failed = progress_report[:error]
+    pending = progress_report[:pending]
+    columns = [[_('Success'), success, '#5CB85C'],
+               [_('Failed'), failed, '#D9534F'],
+               [_('Pending'), pending, '#DEDEDE'],
+               [_('Cancelled'), cancelled, '#B7312D']]
+    groups = [columns.map(&:first)]
+
+    @job_invocation_data = { :columns => columns, :groups => groups}
+  end
+
+  def job_invocation_status(invocation, percent = nil, verbose = true)
+    case invocation.status
+    when HostStatus::ExecutionStatus::QUEUED
+      if verbose && invocation.task
+        _('queued to start executing in %{time}') % {:time => time_ago_in_words(invocation.task.start_at) }
+      else
+        _('queued')
+      end
+    when HostStatus::ExecutionStatus::RUNNING
+      percent ||= invocation.progress_report[:progress]
+      _('running %{percent}%%') % {:percent => percent}
+    when HostStatus::ExecutionStatus::OK
+      _('succeeded')
+    when HostStatus::ExecutionStatus::ERROR
+      _('failed')
+    else
+      _('unknown status')
+    end
+  end
+
+  def job_invocation_success_status
+    icon_text('ok',
+              @job_invocation_data[0][1],
+              :kind => 'pficon')
+  end
+
+  def job_invocation_failed_status
+    icon_text('error-circle-o',
+              @job_invocation_data[1][1],
+              :kind => 'pficon')
+  end
+
+  def job_invocation_pending_status
+    icon_text('running',
+              @job_invocation_data[2][1],
+              :kind => 'pficon')
+  end
+
+  def job_invocation_cancelled_status
+    icon_text('close',
+              @job_invocation_data[3][1],
+              :kind => 'pficon')
+  end
+
+  def task_failed?(task)
+    %w(warning error).include? task.result
+  end
+
+  def task_cancelled?(task)
+    task.execution_plan.errors.map(&:exception).any? { |exception| exception.class == ::ForemanTasks::Task::TaskCancelledException }
+  end
+end