foreman_remote_execution 0.1.2 → 0.2.1

data/test/unit/job_invocation_composer_test.rb

@@ -7,7 +7,7 @@ describe JobInvocationComposer do
     permission1 = FactoryGirl.create(:permission, :name => 'view_job_templates', :resource_type => 'JobTemplate')
     permission2 = Permission.find_by_name('view_bookmarks')
     permission3 = Permission.find_by_name('view_hosts')
-    filter1 = FactoryGirl.build(:filter, :permissions => [permission1], :search => 'name ~ testing*')
+    filter1 = FactoryGirl.build(:filter, :permissions => [permission1], :search => 'name ~ trying*')
     filter2 = FactoryGirl.build(:filter, :permissions => [permission2])
     filter3 = FactoryGirl.build(:filter, :permissions => [permission3])
     filter1.save
@@ -21,16 +21,16 @@ describe JobInvocationComposer do
     User.current.save
   end
 
-  let(:testing_job_template_1) { FactoryGirl.create(:job_template, :job_name => 'testing_job_template_1', :name => 'testing1', :provider_type => 'Ssh') }
-  let(:testing_job_template_2) { FactoryGirl.create(:job_template, :job_name => 'testing_job_template_2', :name => 'testing2', :provider_type => 'Mcollective') }
-  let(:testing_job_template_3) { FactoryGirl.create(:job_template, :job_name => 'testing_job_template_1', :name => 'testing3', :provider_type => 'Ssh') }
-  let(:unauthorized_job_template_1) { FactoryGirl.create(:job_template, :job_name => 'testing_job_template_1', :name => 'unauth1', :provider_type => 'Ssh') }
-  let(:unauthorized_job_template_2) { FactoryGirl.create(:job_template, :job_name => 'unauthorized_job_template_2', :name => 'unauth2', :provider_type => 'Ansible') }
+  let(:trying_job_template_1) { FactoryGirl.create(:job_template, :job_category => 'trying_job_template_1', :name => 'trying1', :provider_type => 'SSH') }
+  let(:trying_job_template_2) { FactoryGirl.create(:job_template, :job_category => 'trying_job_template_2', :name => 'trying2', :provider_type => 'Mcollective') }
+  let(:trying_job_template_3) { FactoryGirl.create(:job_template, :job_category => 'trying_job_template_1', :name => 'trying3', :provider_type => 'SSH') }
+  let(:unauthorized_job_template_1) { FactoryGirl.create(:job_template, :job_category => 'trying_job_template_1', :name => 'unauth1', :provider_type => 'SSH') }
+  let(:unauthorized_job_template_2) { FactoryGirl.create(:job_template, :job_category => 'unauthorized_job_template_2', :name => 'unauth2', :provider_type => 'Ansible') }
 
 
-  let(:input1) { FactoryGirl.create(:template_input, :template => testing_job_template_1, :input_type => 'user') }
-  let(:input2) { FactoryGirl.create(:template_input, :template => testing_job_template_3, :input_type => 'user') }
-  let(:input3) { FactoryGirl.create(:template_input, :template => testing_job_template_1, :input_type => 'user', :required => true) }
+  let(:input1) { FactoryGirl.create(:template_input, :template => trying_job_template_1, :input_type => 'user') }
+  let(:input2) { FactoryGirl.create(:template_input, :template => trying_job_template_3, :input_type => 'user') }
+  let(:input3) { FactoryGirl.create(:template_input, :template => trying_job_template_1, :input_type => 'user', :required => true) }
   let(:unauthorized_input1) { FactoryGirl.create(:template_input, :template => unauthorized_job_template_1, :input_type => 'user') }
 
   let(:ansible_params) { { } }
@@ -45,44 +45,44 @@ describe JobInvocationComposer do
     describe '#available_templates' do
       it 'obeys authorization' do
         composer # lazy load composer before stubbing
-        JobTemplate.expects(:authorized).with(:view_job_templates).returns(JobTemplate.scoped)
+        JobTemplate.expects(:authorized).with(:view_job_templates).returns(JobTemplate.where({}))
         composer.available_templates
       end
     end
 
     context 'job templates exist' do
       before do
-        testing_job_template_1
-        testing_job_template_2
-        testing_job_template_3
+        trying_job_template_1
+        trying_job_template_2
+        trying_job_template_3
         unauthorized_job_template_1
         unauthorized_job_template_2
       end
 
-      describe '#available_templates_for(job_name)' do
+      describe '#available_templates_for(job_category)' do
         it 'find the templates only for a given job name' do
-          results = composer.available_templates_for(testing_job_template_1.job_name)
-          results.must_include testing_job_template_1
-          results.wont_include testing_job_template_2
+          results = composer.available_templates_for(trying_job_template_1.job_category)
+          results.must_include trying_job_template_1
+          results.wont_include trying_job_template_2
         end
 
         it 'it respects view permissions' do
-          results = composer.available_templates_for(testing_job_template_1.job_name)
+          results = composer.available_templates_for(trying_job_template_1.job_category)
           results.wont_include unauthorized_job_template_1
         end
       end
 
-      describe '#available_job_names' do
-        let(:job_names) { composer.available_job_names }
+      describe '#available_job_categories' do
+        let(:job_categories) { composer.available_job_categories }
 
         it 'find only job names that user is granted to view' do
-          job_names.must_include testing_job_template_1.job_name
-          job_names.must_include testing_job_template_2.job_name
-          job_names.wont_include unauthorized_job_template_2.job_name
+          job_categories.must_include trying_job_template_1.job_category
+          job_categories.must_include trying_job_template_2.job_category
+          job_categories.wont_include unauthorized_job_template_2.job_category
         end
 
         it 'every job name is listed just once' do
-          job_names.uniq.must_equal job_names
+          job_categories.uniq.must_equal job_categories
         end
       end
 
@@ -90,8 +90,8 @@ describe JobInvocationComposer do
         let(:provider_types) { composer.available_provider_types }
 
         it 'finds only providers which user is granted to view' do
-          composer.job_invocation.job_name = 'testing_job_template_1'
-          provider_types.must_include 'Ssh'
+          composer.job_invocation.job_category = 'trying_job_template_1'
+          provider_types.must_include 'SSH'
           provider_types.wont_include 'Mcollective'
           provider_types.wont_include 'Ansible'
         end
@@ -115,7 +115,7 @@ describe JobInvocationComposer do
         end
 
         context 'params contains job template ids' do
-          let(:ssh_params) { { :job_template_id => testing_job_template_1.id.to_s } }
+          let(:ssh_params) { { :job_template_id => trying_job_template_1.id.to_s } }
           let(:ansible_params) { { :job_template_id => '' } }
           let(:mcollective_params) { { :job_template_id => '' } }
           let(:params) { { :job_invocation => providers_params }.with_indifferent_access }
@@ -130,58 +130,34 @@ describe JobInvocationComposer do
 
       describe '#needs_provider_type_selection?' do
         it 'returns true if there are more than one providers respecting authorization' do
-          composer.stubs(:available_provider_types => [ 'Ssh', 'Ansible' ])
+          composer.stubs(:available_provider_types => [ 'SSH', 'Ansible' ])
           assert composer.needs_provider_type_selection?
         end
 
         it 'returns false if there is one provider' do
-          composer.stubs(:available_provider_types => [ 'Ssh' ])
+          composer.stubs(:available_provider_types => [ 'SSH' ])
           refute composer.needs_provider_type_selection?
         end
       end
 
-      describe '#only_one_template_available?' do
-        context 'composer needs provider type selection' do
-          before { composer.stubs(:needs_provider_type_selection? => true) }
-
-          it 'returns false because it means we have at least two providers so we need to be able to disable it per provider' do
-            refute composer.only_one_template_available?
-          end
-        end
-
-        context 'composer does not need provider type selection' do
-          before { composer.stubs(:needs_provider_type_selection? => false) }
-
-          it 'returns true if there is only one template for the provider' do
-            composer.stubs(:templates_for_provider => [ testing_job_template_1 ])
-            assert composer.only_one_template_available?
-          end
-
-          it 'returns false if there is more than one template for the provider' do
-            composer.stubs(:templates_for_provider => [ testing_job_template_1, testing_job_template_3 ])
-            refute composer.only_one_template_available?
-          end
-        end
-      end
-
       describe '#displayed_provider_types' do
         # nothing to test yet
       end
 
       describe '#templates_for_provider(provider_type)' do
         it 'returns all templates for a given provider respecting template permissions' do
-          testing_job_template_4 = FactoryGirl.create(:job_template, :job_name => 'testing_job_template_1', :name => 'testing4', :provider_type => 'Ansible')
-          result = composer.templates_for_provider('Ssh')
-          result.must_include testing_job_template_1
-          result.must_include testing_job_template_3
+          trying_job_template_4 = FactoryGirl.create(:job_template, :job_category => 'trying_job_template_1', :name => 'trying4', :provider_type => 'Ansible')
+          result = composer.templates_for_provider('SSH')
+          result.must_include trying_job_template_1
+          result.must_include trying_job_template_3
           result.wont_include unauthorized_job_template_1
-          result.wont_include testing_job_template_4
+          result.wont_include trying_job_template_4
 
           result = composer.templates_for_provider('Ansible')
-          result.wont_include testing_job_template_1
-          result.wont_include testing_job_template_3
+          result.wont_include trying_job_template_1
+          result.wont_include trying_job_template_3
           result.wont_include unauthorized_job_template_2
-          result.must_include testing_job_template_4
+          result.must_include trying_job_template_4
         end
       end
 
@@ -191,9 +167,9 @@ describe JobInvocationComposer do
         end
 
         context 'extra unavailable templates id were selected' do
-          let(:unauthorized) { FactoryGirl.create(:job_template, :job_name => 'testing_job_template_1', :name => 'unauth3', :provider_type => 'Ansible') }
-          let(:mcollective_authorized) { FactoryGirl.create(:job_template, :job_name => 'testing_job_template_1', :name => 'testing4', :provider_type => 'Mcollective') }
-          let(:ssh_params) { { :job_template_id => testing_job_template_1.id.to_s } }
+          let(:unauthorized) { FactoryGirl.create(:job_template, :job_category => 'trying_job_template_1', :name => 'unauth3', :provider_type => 'Ansible') }
+          let(:mcollective_authorized) { FactoryGirl.create(:job_template, :job_category => 'trying_job_template_1', :name => 'trying4', :provider_type => 'Mcollective') }
+          let(:ssh_params) { { :job_template_id => trying_job_template_1.id.to_s } }
           let(:ansible_params) { { :job_template_id => unauthorized.id.to_s } }
           let(:mcollective_params) { { :job_template_id => mcollective_authorized.id.to_s } }
           let(:params) { { :job_invocation => providers_params }.with_indifferent_access }
@@ -205,44 +181,44 @@ describe JobInvocationComposer do
 
           it 'contains only authorized template specified in params' do
             mcollective_authorized # make sure mcollective_authorized exists
-            composer.selected_job_templates.must_include testing_job_template_1
+            composer.selected_job_templates.must_include trying_job_template_1
             composer.selected_job_templates.must_include mcollective_authorized
-            composer.selected_job_templates.wont_include testing_job_template_3
+            composer.selected_job_templates.wont_include trying_job_template_3
           end
         end
       end
 
-      describe '#preselect_disabled_for_provider(provider_type)' do
+      describe '#preselected_template_for_provider(provider_type)' do
         context 'none template was selected through params' do
-          it 'returns true since nothing was selected and disabled is default' do
-            assert composer.preselect_disabled_for_provider('Ssh')
+          it 'returns nil' do
+            composer.preselected_template_for_provider('SSH').must_be_nil
           end
         end
 
         context 'available template was selected for a specified provider through params' do
-          let(:ssh_params) { { :job_template_id => testing_job_template_1.id.to_s } }
+          let(:ssh_params) { { :job_template_id => trying_job_template_1.id.to_s } }
           let(:params) { { :job_invocation => providers_params }.with_indifferent_access }
 
-          it 'returns false because available template was selected' do
-            refute composer.preselect_disabled_for_provider('Ssh')
+          it 'returns the selected template because it is available for provider' do
+            composer.preselected_template_for_provider('SSH').must_equal trying_job_template_1
           end
         end
       end
 
-      describe '#template_invocations' do
+      describe '#pattern template_invocations' do
         let(:ssh_params) do
-          { :job_template_id => testing_job_template_1.id.to_s,
+          { :job_template_id => trying_job_template_1.id.to_s,
             :job_templates => {
-              testing_job_template_1.id.to_s => {
+              trying_job_template_1.id.to_s => {
                 :input_values => { input1.id.to_s => { :value => 'value1' },  unauthorized_input1.id.to_s => { :value => 'dropped' } }
               }
             }
           }
         end
         let(:params) { { :job_invocation => { :providers => { :ssh => ssh_params } } }.with_indifferent_access }
-        let(:invocations) { composer.template_invocations }
+        let(:invocations) { composer.pattern_template_invocations }
 
-        it 'builds template invocations based on passed params and it filters out wrong inputs' do
+        it 'builds pattern template invocations based on passed params and it filters out wrong inputs' do
           invocations.size.must_equal 1
           invocations.first.input_values.size.must_equal 1
           invocations.first.input_values.first.value.must_equal 'value1'
@@ -251,9 +227,9 @@ describe JobInvocationComposer do
 
       describe '#effective_user' do
         let(:ssh_params) do
-          { :job_template_id => testing_job_template_1.id.to_s,
+          { :job_template_id => trying_job_template_1.id.to_s,
             :job_templates => {
-              testing_job_template_1.id.to_s => {
+              trying_job_template_1.id.to_s => {
                 :effective_user => invocation_effective_user
               }
             }
@@ -261,8 +237,8 @@ describe JobInvocationComposer do
         end
         let(:params) { { :job_invocation => { :providers => { :ssh => ssh_params } } }.with_indifferent_access }
         let(:template_invocation) do
-          testing_job_template_1.effective_user.update_attributes(:overridable => overridable, :value => 'template user')
-          composer.template_invocations.first
+          trying_job_template_1.effective_user.update_attributes(:overridable => overridable, :value => 'template user')
+          composer.pattern_template_invocations.first
         end
 
         before do
@@ -280,7 +256,7 @@ describe JobInvocationComposer do
 
         context 'when overridable and not provided' do
           let(:overridable) { true }
-          let(:invocation_effective_user) { "" }
+          let(:invocation_effective_user) { '' }
 
           it 'takes the value from the job template' do
             template_invocation.effective_user.must_equal 'template user'
@@ -289,7 +265,7 @@ describe JobInvocationComposer do
 
         context 'when not overridable and provided' do
           let(:overridable) { false }
-          let(:invocation_effective_user) { "invocation user" }
+          let(:invocation_effective_user) { 'invocation user' }
 
           it 'takes the value from the job template' do
             template_invocation.effective_user.must_equal 'template user'
@@ -347,7 +323,7 @@ describe JobInvocationComposer do
       describe '#available_bookmarks' do
         it 'obeys authorization' do
           composer
-          Bookmark.expects(:authorized).with(:view_bookmarks).returns(Bookmark.scoped)
+          Bookmark.expects(:authorized).with(:view_bookmarks).returns(Bookmark.where({}))
           composer.available_bookmarks
         end
 
@@ -372,7 +348,7 @@ describe JobInvocationComposer do
 
         it 'obeys authorization' do
           composer.stubs(:displayed_search_query => "name = #{host.name}")
-          Host.expects(:authorized).with(:view_hosts, Host).returns(Host.scoped)
+          Host.expects(:authorized).with(:view_hosts, Host).returns(Host.where({}))
           composer.targeted_hosts_count
         end
 
@@ -382,7 +358,7 @@ describe JobInvocationComposer do
         end
 
         it 'returns 0 for queries with syntax errors' do
-          composer.stubs(:displayed_search_query => "name = ")
+          composer.stubs(:displayed_search_query => 'name = ')
           composer.targeted_hosts_count.must_equal 0
         end
 
@@ -393,7 +369,7 @@ describe JobInvocationComposer do
       end
 
       describe '#template_invocation_input_value_for(input)' do
-        let(:value1) { composer.template_invocation_input_value_for(input1) }
+        let(:value1) { composer.template_invocation_input_value_for(trying_job_template_1, input1) }
         it 'returns new empty input value if there is no invocation' do
           assert value1.new_record?
           value1.value.must_be_empty
@@ -401,9 +377,9 @@ describe JobInvocationComposer do
 
         context 'there are invocations without input values for a given input' do
           let(:ssh_params) do
-            { :job_template_id => testing_job_template_1.id.to_s,
+            { :job_template_id => trying_job_template_1.id.to_s,
               :job_templates => {
-                testing_job_template_1.id.to_s => {
+                trying_job_template_1.id.to_s => {
                   :input_values => { }
                 } } }
           end
@@ -417,9 +393,9 @@ describe JobInvocationComposer do
 
         context 'there are invocations with input values for a given input' do
           let(:ssh_params) do
-            { :job_template_id => testing_job_template_1.id.to_s,
+            { :job_template_id => trying_job_template_1.id.to_s,
               :job_templates => {
-                testing_job_template_1.id.to_s => {
+                trying_job_template_1.id.to_s => {
                   :input_values => { input1.id.to_s => { :value => 'value1' } }
                 } } }
           end
@@ -434,9 +410,9 @@ describe JobInvocationComposer do
       describe '#valid?' do
         let(:host) { FactoryGirl.create(:host) }
         let(:ssh_params) do
-          { :job_template_id => testing_job_template_1.id.to_s,
+          { :job_template_id => trying_job_template_1.id.to_s,
             :job_templates => {
-              testing_job_template_1.id.to_s => {
+              trying_job_template_1.id.to_s => {
                 :input_values => { input1.id.to_s => { :value => 'value1' } }
               } } }
         end
@@ -448,7 +424,7 @@ describe JobInvocationComposer do
           composer
           composer.job_invocation.expects(:valid?).returns(false)
           composer.targeting.expects(:valid?).returns(false)
-          composer.template_invocations.each { |invocation| invocation.expects(:valid?).returns(false) }
+          composer.pattern_template_invocations.each { |invocation| invocation.expects(:valid?).returns(false) }
           refute composer.valid?
         end
       end
@@ -477,11 +453,11 @@ describe JobInvocationComposer do
         end
       end
 
-      describe '#job_name' do
-        it 'triggers job_name on job_invocation' do
+      describe '#job_category' do
+        it 'triggers job_category on job_invocation' do
           composer
-          composer.job_invocation.expects(:job_name)
-          composer.job_name
+          composer.job_invocation.expects(:job_category)
+          composer.job_category
         end
       end
 
@@ -496,9 +472,9 @@ describe JobInvocationComposer do
       describe '#compose_from_invocation(existing_invocation)' do
         let(:host) { FactoryGirl.create(:host) }
         let(:ssh_params) do
-          { :job_template_id => testing_job_template_1.id.to_s,
+          { :job_template_id => trying_job_template_1.id.to_s,
             :job_templates => {
-              testing_job_template_1.id.to_s => {
+              trying_job_template_1.id.to_s => {
                 :input_values => { input1.id.to_s => { :value => 'value1' } }
               } } }
         end
@@ -522,7 +498,7 @@ describe JobInvocationComposer do
         end
 
         it 'sets the same job name' do
-          new_composer.job_name.must_equal existing.job_name
+          new_composer.job_category.must_equal existing.job_category
         end
 
         it 'builds new targeting object which keeps search query' do
@@ -531,11 +507,11 @@ describe JobInvocationComposer do
         end
 
         it 'keeps job template ids' do
-          new_composer.job_template_ids.must_equal existing.template_invocations.map(&:template_id)
+          new_composer.job_template_ids.must_equal existing.pattern_template_invocations.map(&:template_id)
         end
 
         it 'keeps template invocations and their values' do
-          new_composer.template_invocations.size.must_equal existing.template_invocations.size
+          new_composer.pattern_template_invocations.size.must_equal existing.pattern_template_invocations.size
         end
 
       end
@@ -549,153 +525,153 @@ describe JobInvocationComposer do
     context 'with targeting from bookmark' do
 
       before do
-        [testing_job_template_1, testing_job_template_3] # mentioning templates we want to have initialized in the test
+        [trying_job_template_1, trying_job_template_3] # mentioning templates we want to have initialized in the test
       end
 
       let(:params) do
-        { :job_name => testing_job_template_1.job_name,
-          :job_template_id => testing_job_template_1.id,
-          :targeting_type => "static_query",
+        { :job_category => trying_job_template_1.job_category,
+          :job_template_id => trying_job_template_1.id,
+          :targeting_type => 'static_query',
           :bookmark_id => bookmark.id }
       end
 
-      it "creates invocation with a bookmark" do
+      it 'creates invocation with a bookmark' do
         assert composer.save!
         assert_equal bookmark, composer.job_invocation.targeting.bookmark
         assert_equal composer.job_invocation.targeting.user, User.current
-        refute_empty composer.job_invocation.template_invocations
+        refute_empty composer.job_invocation.pattern_template_invocations
       end
     end
 
-    context "with targeting from search query" do
+    context 'with targeting from search query' do
       let(:params) do
-        { :job_name => testing_job_template_1.job_name,
-          :job_template_id => testing_job_template_1.id,
-          :targeting_type => "static_query",
-          :search_query => "some hosts" }
+        { :job_category => trying_job_template_1.job_category,
+          :job_template_id => trying_job_template_1.id,
+          :targeting_type => 'static_query',
+          :search_query => 'some hosts' }
       end
 
-      it "creates invocation with a search query" do
+      it 'creates invocation with a search query' do
         assert composer.save!
-        assert_equal "some hosts", composer.job_invocation.targeting.search_query
-        refute_empty composer.job_invocation.template_invocations
+        assert_equal 'some hosts', composer.job_invocation.targeting.search_query
+        refute_empty composer.job_invocation.pattern_template_invocations
       end
     end
 
-    context "with with inputs" do
+    context 'with with inputs' do
       let(:params) do
-        { :job_name => testing_job_template_1.job_name,
-          :job_template_id => testing_job_template_1.id,
-          :targeting_type => "static_query",
-          :search_query => "some hosts",
-          :inputs => {input1.name => "some_value"}}
+        { :job_category => trying_job_template_1.job_category,
+          :job_template_id => trying_job_template_1.id,
+          :targeting_type => 'static_query',
+          :search_query => 'some hosts',
+          :inputs => {input1.name => 'some_value'}}
       end
 
-      it "finds the inputs by name" do
+      it 'finds the inputs by name' do
         assert composer.save!
-        assert_equal 1, composer.template_invocations.first.input_values.count
+        assert_equal 1, composer.pattern_template_invocations.first.input_values.count
       end
     end
 
-    context "with effective user" do
+    context 'with effective user' do
       let(:params) do
-        { :job_name => testing_job_template_1.job_name,
-          :job_template_id => testing_job_template_1.id,
+        { :job_category => trying_job_template_1.job_category,
+          :job_template_id => trying_job_template_1.id,
           :effective_user => 'invocation user',
-          :targeting_type => "static_query",
-          :search_query => "some hosts",
-          :inputs => {input1.name => "some_value"}}
+          :targeting_type => 'static_query',
+          :search_query => 'some hosts',
+          :inputs => {input1.name => 'some_value'}}
       end
 
-      let(:template_invocation) { composer.job_invocation.template_invocations.first }
+      let(:template_invocation) { composer.job_invocation.pattern_template_invocations.first }
 
-      it "sets the effective user based on the input" do
+      it 'sets the effective user based on the input' do
         assert composer.save!
         template_invocation.effective_user.must_equal 'invocation user'
       end
     end
 
-    context "with invalid targeting" do
+    context 'with invalid targeting' do
       let(:params) do
-        { :job_name => testing_job_template_1.job_name,
-          :job_template_id => testing_job_template_1.id,
-          :search_query => "some hosts",
-          :inputs => {input1.name => "some_value"}}
+        { :job_category => trying_job_template_1.job_category,
+          :job_template_id => trying_job_template_1.id,
+          :search_query => 'some hosts',
+          :inputs => {input1.name => 'some_value'}}
       end
 
-      it "handles errors" do
+      it 'handles errors' do
         assert_raises(ActiveRecord::RecordNotSaved) do
           composer.save!
         end
       end
     end
 
-    context "with invalid bookmark and search query" do
+    context 'with invalid bookmark and search query' do
       let(:params) do
-        { :job_name => testing_job_template_1.job_name,
-          :job_template_id => testing_job_template_1.id,
-          :targeting_type => "static_query",
-          :search_query => "some hosts",
+        { :job_category => trying_job_template_1.job_category,
+          :job_template_id => trying_job_template_1.id,
+          :targeting_type => 'static_query',
+          :search_query => 'some hosts',
           :bookmark_id => bookmark.id,
-          :inputs => {input1.name => "some_value"}}
+          :inputs => {input1.name => 'some_value'}}
       end
 
-      it "handles errors" do
+      it 'handles errors' do
         assert_raises(Foreman::Exception) do
           JobInvocationComposer.from_api_params(params)
         end
       end
     end
 
-    context "with invalid inputs" do
+    context 'with invalid inputs' do
       let(:params) do
-        { :job_name => testing_job_template_1.job_name,
-          :job_template_id => testing_job_template_1.id,
-          :targeting_type => "static_query",
-          :search_query => "some hosts",
+        { :job_category => trying_job_template_1.job_category,
+          :job_template_id => trying_job_template_1.id,
+          :targeting_type => 'static_query',
+          :search_query => 'some hosts',
           :inputs => {input3.name => nil}}
       end
 
-      it "handles errors" do
+      it 'handles errors' do
         error = assert_raises(ActiveRecord::RecordNotSaved) do
           composer.save!
         end
-        error.message.must_include "Template #{testing_job_template_1.name}: Input #{input3.name.downcase}: Value can't be blank"
+        error.message.must_include "Template #{trying_job_template_1.name}: Input #{input3.name.downcase}: Value can't be blank"
       end
     end
 
-    context "with empty values for non-required inputs" do
+    context 'with empty values for non-required inputs' do
       let(:params) do
-        { :job_name => testing_job_template_1.job_name,
-          :job_template_id => testing_job_template_1.id,
-          :targeting_type => "static_query",
-          :search_query => "some hosts",
-          :inputs => {input3.name => "some value"}}
+        { :job_category => trying_job_template_1.job_category,
+          :job_template_id => trying_job_template_1.id,
+          :targeting_type => 'static_query',
+          :search_query => 'some hosts',
+          :inputs => {input3.name => 'some value'}}
       end
 
-      it "accepts the params" do
+      it 'accepts the params' do
         composer.save!
         refute composer.job_invocation.new_record?
       end
     end
 
-    context "with missing required inputs" do
+    context 'with missing required inputs' do
       let(:params) do
-        { :job_name => testing_job_template_1.job_name,
-          :job_template_id => testing_job_template_1.id,
-          :targeting_type => "static_query",
-          :search_query => "some hosts",
-          :inputs => {input1.name => "some_value"}}
+        { :job_category => trying_job_template_1.job_category,
+          :job_template_id => trying_job_template_1.id,
+          :targeting_type => 'static_query',
+          :search_query => 'some hosts',
+          :inputs => {input1.name => 'some_value'}}
       end
 
-      it "handles errors" do
+      it 'handles errors' do
         input3.must_be :required
 
         error = assert_raises(ActiveRecord::RecordNotSaved) do
           composer.save!
         end
 
-        error.message.must_include "Template #{testing_job_template_1.name}: Not all required inputs have values. Missing inputs: #{input3.name}"
+        error.message.must_include "Template #{trying_job_template_1.name}: Not all required inputs have values. Missing inputs: #{input3.name}"
       end
     end
   end