foreman_remote_execution 0.0.6 → 0.0.7

data/test/unit/concerns/nic_extensions_test.rb

@@ -0,0 +1,9 @@
+require 'test_plugin_helper'
+
+describe ForemanRemoteExecution::NicExtensions do
+  let(:host) { FactoryGirl.create(:host) }
+
+  it 'sets the first primary interface as the execution interface' do
+    host.execution_interface.must_equal host.interfaces.first
+  end
+end

data/test/unit/input_template_renderer_test.rb

@@ -50,37 +50,50 @@ describe InputTemplateRenderer do
       before do
         template.template_inputs << FactoryGirl.build(:template_input, :name => 'service_name', :input_type => 'user')
         job_invocation.template_invocations << template_invocation
-        renderer.invocation = template_invocation
       end
 
       describe 'rendering' do
-        it 'can\'t render the content without job invocation since we don\'t have values' do
+        it 'cannot render the content without job invocation' do
           refute result
-        end
-
-        it 'registers an error' do
-          result # let is lazy
           renderer.error_message.wont_be_nil
           renderer.error_message.wont_be_empty
         end
 
+        it 'can preview' do
+          renderer.preview.must_equal 'service restart $USER_INPUT[service_name]'
+        end
+
+        context 'with invocation specified and a required input' do
+          before do
+            template.template_inputs.first.update_attributes(:required => true)
+            renderer.invocation = template_invocation
+          end
+
+          it 'cannot render the content' do
+            refute result
+            renderer.error_message.wont_be_nil
+            renderer.error_message.wont_be_empty
+          end
+        end
+
         context 'with invocation specified' do
           before do
             FactoryGirl.create(:template_invocation_input_value,
                                :template_invocation => template_invocation,
                                :template_input => template.template_inputs.first,
                                :value => 'foreman')
+            renderer.invocation = template_invocation
+            renderer.invocation.reload
           end
 
           it 'can render with job invocation with corresponding value' do
             renderer.render.must_equal 'service restart foreman'
           end
         end
-      end
 
-      describe 'preview' do
-        it 'should render preview' do
-          renderer.preview.must_equal 'service restart $USER_INPUT[service_name]'
+        it 'renders even without an input value' do
+          renderer.invocation = template_invocation
+          renderer.render.must_equal 'service restart '
         end
       end
     end
@@ -104,6 +117,7 @@ describe InputTemplateRenderer do
                              :template_invocation => template_invocation,
                              :template_input => template.template_inputs.first,
                              :value => 'foreman')
+          renderer.invocation.reload
         end
 
         it 'can render with job invocation with corresponding value' do

data/test/unit/job_invocation_api_composer_test.rb

@@ -0,0 +1,117 @@
+require 'test_plugin_helper'
+
+describe JobInvocationApiComposer do
+  before do
+    permission1 = FactoryGirl.create(:permission, :name => 'view_job_templates', :resource_type => 'JobTemplate')
+    permission2 = Permission.find_by_name('view_bookmarks')
+    permission3 = Permission.find_by_name('view_hosts')
+    filter1 = FactoryGirl.build(:filter, :permissions => [permission1], :search => 'name ~ testing*')
+    filter2 = FactoryGirl.build(:filter, :permissions => [permission2])
+    filter3 = FactoryGirl.build(:filter, :permissions => [permission3])
+    filter1.save
+    filter2.save
+    filter3.save
+    role = FactoryGirl.build(:role)
+    role.filters = filter1, filter2, filter3
+    role.save
+    User.current = FactoryGirl.build(:user)
+    User.current.roles<< role
+    User.current.save
+  end
+
+  let(:testing_job_template_1) { FactoryGirl.create(:job_template, :job_name => 'testing_job_template_1', :name => 'testing1', :provider_type => 'Ssh') }
+  let(:testing_job_template_2) { FactoryGirl.create(:job_template, :job_name => 'testing_job_template_2', :name => 'testing2', :provider_type => 'Mcollective') }
+  let(:testing_job_template_3) { FactoryGirl.create(:job_template, :job_name => 'testing_job_template_1', :name => 'testing3', :provider_type => 'Ssh') }
+  let(:unauthorized_job_template_1) { FactoryGirl.create(:job_template, :job_name => 'testing_job_template_1', :name => 'unauth1', :provider_type => 'Ssh') }
+  let(:unauthorized_job_template_2) { FactoryGirl.create(:job_template, :job_name => 'unauthorized_job_template_2', :name => 'unauth2', :provider_type => 'Ansible') }
+
+  let(:input1) { FactoryGirl.create(:template_input, :template => testing_job_template_1, :input_type => 'user') }
+  let(:input2) { FactoryGirl.create(:template_input, :template => testing_job_template_3, :input_type => 'user') }
+  let(:unauthorized_input1) { FactoryGirl.create(:template_input, :template => unauthorized_job_template_1, :input_type => 'user') }
+
+  let(:bookmark) { bookmarks(:one) }
+  let(:providers_params) { { :providers => { :ansible => ansible_params, :ssh => ssh_params, :mcollective => mcollective_params } } }
+
+  context 'composer' do
+    it "creates invocation with a bookmark" do
+      params = {:job_name => testing_job_template_1.job_name,
+                :template_id => testing_job_template_1.id,
+                :targeting_type => "static_query",
+                :bookmark_id => bookmark.id}
+      ji = JobInvocation.new
+
+      composer = JobInvocationApiComposer.new(ji, User.current, params)
+      assert composer.save!
+      assert_equal bookmark, ji.targeting.bookmark
+      assert_equal ji.targeting.user, User.current
+      refute_empty ji.template_invocations
+    end
+
+    it "creates invocation with a search query" do
+      params = {:job_name => testing_job_template_1.job_name,
+                :template_id => testing_job_template_1.id,
+                :targeting_type => "static_query",
+                :search_query => "some hosts"}
+      ji = JobInvocation.new
+
+      composer = JobInvocationApiComposer.new(ji, User.current, params)
+      assert composer.save!
+      assert_equal "some hosts", ji.targeting.search_query
+      refute_empty ji.template_invocations
+    end
+
+    it "creates invocation with inputs" do
+      params = {:job_name => testing_job_template_1.job_name,
+                :template_id => testing_job_template_1.id,
+                :targeting_type => "static_query",
+                :search_query => "some hosts",
+                :inputs => [{:name => input1.name, :value => "some_value"}]}
+      ji = JobInvocation.new
+
+      composer = JobInvocationApiComposer.new(ji, User.current, params)
+      assert composer.save!
+      assert_equal 1, ji.template_invocations.first.input_values.count
+    end
+
+    it "handles errors on invalid targeting" do
+      params = {:job_name => testing_job_template_1.job_name,
+                :template_id => testing_job_template_1.id,
+                :search_query => "some hosts",
+                :inputs => [{:name => input1.name, :value => "some_value"}]}
+      ji = JobInvocation.new
+
+      composer = JobInvocationApiComposer.new(ji, User.current, params)
+      assert_raises(ActiveRecord::RecordInvalid) do
+        composer.save!
+      end
+    end
+
+    it "handles errors with both bookmark and search_query" do
+      params = {:job_name => testing_job_template_1.job_name,
+                :template_id => testing_job_template_1.id,
+                :targeting_type => "static_query",
+                :search_query => "some hosts",
+                :bookmark_id => bookmark.id,
+                :inputs => [{:name => input1.name, :value => "some_value"}]}
+      ji = JobInvocation.new
+
+      assert_raises(Foreman::Exception) do
+        JobInvocationApiComposer.new(ji, User.current, params)
+      end
+    end
+
+    it "handles errors on invalid inputs" do
+      params = {:job_name => testing_job_template_1.job_name,
+                :template_id => testing_job_template_1.id,
+                :targeting_type => "static_query",
+                :search_query => "some hosts",
+                :inputs => [{:name => input1.name}]}
+      ji = JobInvocation.new
+
+      composer = JobInvocationApiComposer.new(ji, User.current, params)
+      assert_raises(ActiveRecord::RecordInvalid) do
+        composer.save!
+      end
+    end
+  end
+end

data/test/unit/job_invocation_composer_test.rb

@@ -38,7 +38,7 @@ describe JobInvocationComposer do
 
   context 'with general new invocation and empty params' do
     let(:params) { {} }
-    let(:job_invocation) { JobInvocation.new }
+    let(:job_invocation) { JobInvocation.new.tap { |job_invocation| job_invocation.stubs(:trigger_mode=) } }
     let(:composer) { JobInvocationComposer.new(job_invocation).compose_from_params(params) }
 
     describe '#available_templates' do
@@ -299,6 +299,21 @@ describe JobInvocationComposer do
           Bookmark.expects(:authorized).with(:view_bookmarks).returns(Bookmark.scoped)
           composer.available_bookmarks
         end
+
+        context 'there are hostgroups and hosts bookmark' do
+          let(:hostgroups) { Bookmark.create(:name => 'hostgroups', :query => 'name = x', :controller => 'hostgroups') }
+          let(:hosts) { Bookmark.create(:name => 'hosts', :query => 'name = x', :controller => 'hosts') }
+          let(:dashboard) { Bookmark.create(:name => 'dashboard', :query => 'name = x', :controller => 'dashboard') }
+
+          it 'finds only host related bookmarks' do
+            hosts
+            dashboard
+            hostgroups
+            composer.available_bookmarks.must_include hosts
+            composer.available_bookmarks.must_include dashboard
+            composer.available_bookmarks.wont_include hostgroups
+          end
+        end
       end
 
       describe '#targeted_hosts_count' do

data/test/unit/job_invocation_test.rb

@@ -19,13 +19,58 @@ describe JobInvocation do
     let(:job_invocation) { FactoryGirl.create(:job_invocation, :with_template) }
 
     before do
+      input = job_invocation.template_invocations.first.template.template_inputs.create!(:name => 'foo', :required => true, :input_type => 'user')
       @input_value = FactoryGirl.create(:template_invocation_input_value,
                                         :template_invocation =>  job_invocation.template_invocations.first,
-                                        :template_input      => template.template_inputs.first)
-
+                                        :template_input      => input)
+      job_invocation.reload
+      job_invocation.template_invocations.first.reload
     end
 
     it { refute job_invocation.reload.template_invocations.empty? }
-    it { refute job_invocation.template_invocations.first.input_values.empty? }
+    it { refute job_invocation.reload.template_invocations.first.input_values.empty? }
+
+    it 'validates required inputs have values' do
+      assert job_invocation.valid?
+      @input_value.destroy
+      refute job_invocation.reload.valid?
+    end
+  end
+
+  context 'future execution' do
+
+    it 'can report host count' do
+      job_invocation.total_hosts_count.must_equal 'N/A'
+      job_invocation.targeting.expects(:resolved_at).returns(Time.now)
+      job_invocation.total_hosts_count.must_equal 0
+    end
+
+    it 'has default trigger mode' do
+      job_invocation.trigger_mode.must_equal :immediate
+    end
+
+    it 'cannot set trigger mode to anything other than :immediate or :future' do
+      proc { job_invocation.trigger_mode = 'test' }.must_raise ::Foreman::Exception
+      job_invocation.trigger_mode.must_equal :immediate
+    end
+
+    it 'cannot change trigger mode once set' do
+      job_invocation.trigger_mode = 'future'
+      job_invocation.trigger_mode = 'immediate'
+      job_invocation.trigger_mode.must_equal :future
+    end
+
+    it 'parses times' do
+      time = Time.new(2015, 9, 16, 13, 56)
+      time_string = time.strftime(job_invocation.time_format)
+      job_invocation.start_at_parsed.must_equal false
+      job_invocation.start_at = time_string
+      job_invocation.start_at_parsed.must_equal time
+      job_invocation.start_before.must_be_nil
+      job_invocation.start_before_parsed.must_be_nil
+      job_invocation.start_before = time_string
+      job_invocation.start_before_parsed.must_equal time
+    end
+
   end
 end

data/test/unit/proxy_load_balancer_test.rb

@@ -0,0 +1,25 @@
+require 'test_plugin_helper'
+
+describe ProxyLoadBalancer do
+  let(:load_balancer) { ProxyLoadBalancer.new }
+
+  before do
+    ProxyAPI::ForemanDynflow::DynflowProxy.any_instance.stubs(:tasks_count).returns(0)
+  end
+
+  it 'load balances' do
+    proxies = FactoryGirl.create_list(:smart_proxy, 3, :ssh)
+    not_yet_seen = proxies.dup
+
+    3.times do
+      found = load_balancer.next(proxies)
+      not_yet_seen.delete(found)
+    end
+
+    not_yet_seen.must_be_empty
+  end
+
+  it 'returns nil for if no proxy is available' do
+    load_balancer.next([]).must_be_nil
+  end
+end

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: foreman_remote_execution
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Foreman Remote Execution team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-14 00:00:00.000000000 Z
+date: 2015-10-01 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: deface
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
@@ -30,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.3
+        version: 0.7.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.3
+        version: 0.7.6
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -91,6 +105,7 @@ extra_rdoc_files:
 - doc/source/_includes/footer.html
 - doc/source/_includes/tocify.html
 - doc/source/design/index.md
+- doc/source/design/wireframes.pdf
 - doc/source/static/css/jquery.tocify.css
 - doc/source/static/css/bootstrap.min.css
 - doc/source/static/css/style.css
@@ -112,36 +127,56 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- app/assets/javascripts/execution_interface.js
 - app/assets/javascripts/template_input.js
 - app/assets/javascripts/template_invocation.js
 - app/assets/stylesheets/job_invocations.css.scss
 - app/assets/stylesheets/template_invocation.css.scss
+- app/controllers/api/v2/job_invocations_controller.rb
 - app/controllers/api/v2/job_templates_controller.rb
 - app/controllers/job_invocations_controller.rb
 - app/controllers/job_templates_controller.rb
+- app/controllers/template_invocations_controller.rb
 - app/helpers/concerns/foreman_remote_execution/hosts_helper_extensions.rb
 - app/helpers/remote_execution_helper.rb
+- app/lib/actions/middleware/bind_job_invocation.rb
 - app/lib/actions/remote_execution/run_host_job.rb
 - app/lib/actions/remote_execution/run_hosts_job.rb
 - app/lib/actions/remote_execution/run_proxy_command.rb
 - app/models/concerns/foreman_remote_execution/bookmark_extensions.rb
 - app/models/concerns/foreman_remote_execution/foreman_tasks_task_extensions.rb
 - app/models/concerns/foreman_remote_execution/host_extensions.rb
+- app/models/concerns/foreman_remote_execution/nic_extensions.rb
+- app/models/concerns/foreman_remote_execution/subnet_extensions.rb
+- app/models/concerns/foreman_remote_execution/taxonomy_extensions.rb
 - app/models/concerns/foreman_remote_execution/template_extensions.rb
 - app/models/concerns/foreman_remote_execution/template_relations.rb
 - app/models/concerns/foreman_remote_execution/user_extensions.rb
 - app/models/input_template_renderer.rb
 - app/models/job_invocation.rb
+- app/models/job_invocation_api_composer.rb
 - app/models/job_invocation_composer.rb
 - app/models/job_template.rb
 - app/models/remote_execution_provider.rb
 - app/models/setting/remote_execution.rb
 - app/models/ssh_execution_provider.rb
+- app/models/target_remote_execution_proxy.rb
 - app/models/targeting.rb
 - app/models/targeting_host.rb
 - app/models/template_input.rb
 - app/models/template_invocation.rb
 - app/models/template_invocation_input_value.rb
+- app/overrides/execution_interface.rb
+- app/overrides/foreman/nics/_execution_interface.html.erb
+- app/overrides/foreman/subnets/_rex_tab.html.erb
+- app/overrides/foreman/subnets/_rex_tab_pane.html.erb
+- app/overrides/subnet_proxies.rb
+- app/services/proxy_load_balancer.rb
+- app/views/api/v2/job_invocations/base.json.rabl
+- app/views/api/v2/job_invocations/create.json.rabl
+- app/views/api/v2/job_invocations/index.json.rabl
+- app/views/api/v2/job_invocations/main.json.rabl
+- app/views/api/v2/job_invocations/show.json.rabl
 - app/views/api/v2/job_templates/base.json.rabl
 - app/views/api/v2/job_templates/create.json.rabl
 - app/views/api/v2/job_templates/index.json.rabl
@@ -154,6 +189,7 @@ files:
 - app/views/job_invocations/new.html.erb
 - app/views/job_invocations/refresh.js.erb
 - app/views/job_invocations/show.html.erb
+- app/views/job_invocations/show.js.erb
 - app/views/job_templates/_custom_tab_headers.html.erb
 - app/views/job_templates/_custom_tabs.html.erb
 - app/views/job_templates/auto_complete_job_name.json.erb
@@ -161,6 +197,10 @@ files:
 - app/views/job_templates/index.html.erb
 - app/views/job_templates/new.html.erb
 - app/views/template_inputs/_form.html.erb
+- app/views/template_invocations/_output_line_set.html.erb
+- app/views/template_invocations/_refresh.js.erb
+- app/views/template_invocations/show.html.erb
+- app/views/template_invocations/show.js.erb
 - app/views/templates/package_action.erb
 - app/views/templates/puppet_run_once.erb
 - app/views/templates/run_command.erb
@@ -173,8 +213,10 @@ files:
 - db/migrate/20150708133305_add_template_invocation.rb
 - db/migrate/20150812110800_add_resolved_at_to_targeting.rb
 - db/migrate/20150812145900_add_last_task_id_to_job_invocation.rb
+- db/migrate/20150826191632_create_target_remote_execution_proxies.rb
 - db/migrate/20150827144500_change_targeting_search_query_type.rb
 - db/migrate/20150827152730_add_options_to_template_input.rb
+- db/migrate/20150903192731_add_execution_to_interface.rb
 - db/seeds.d/60-ssh_proxy_feature.rb
 - db/seeds.d/70-job_templates.rb
 - doc/Gemfile
@@ -196,6 +238,7 @@ files:
 - doc/source/_layouts/page.html
 - doc/source/atom.xml
 - doc/source/design/index.md
+- doc/source/design/wireframes.pdf
 - doc/source/index.md
 - doc/source/static/css/bootstrap-responsive.min.css
 - doc/source/static/css/bootstrap.min.css
@@ -219,14 +262,19 @@ files:
 - locale/foreman_remote_execution.pot
 - locale/gemspec.rb
 - test/factories/foreman_remote_execution_factories.rb
+- test/functional/api/v2/job_invocations_controller_test.rb
 - test/functional/api/v2/job_templates_controller_test.rb
 - test/test_plugin_helper.rb
 - test/unit/actions/run_hosts_job_test.rb
 - test/unit/actions/run_proxy_command_test.rb
+- test/unit/concerns/host_extensions_test.rb
+- test/unit/concerns/nic_extensions_test.rb
 - test/unit/input_template_renderer_test.rb
+- test/unit/job_invocation_api_composer_test.rb
 - test/unit/job_invocation_composer_test.rb
 - test/unit/job_invocation_test.rb
 - test/unit/job_template_test.rb
+- test/unit/proxy_load_balancer_test.rb
 - test/unit/remote_execution_provider_test.rb
 - test/unit/targeting_test.rb
 - test/unit/template_input_test.rb
@@ -266,6 +314,11 @@ test_files:
 - test/unit/actions/run_hosts_job_test.rb
 - test/unit/actions/run_proxy_command_test.rb
 - test/unit/job_invocation_composer_test.rb
+- test/unit/job_invocation_api_composer_test.rb
 - test/unit/input_template_renderer_test.rb
+- test/unit/concerns/host_extensions_test.rb
+- test/unit/concerns/nic_extensions_test.rb
+- test/unit/proxy_load_balancer_test.rb
+- test/functional/api/v2/job_invocations_controller_test.rb
 - test/functional/api/v2/job_templates_controller_test.rb
 - test/factories/foreman_remote_execution_factories.rb