foreman_puppet 6.3.0 → 6.4.0

data/test/models/foreman_puppet/host_test.rb

@@ -325,5 +325,17 @@ module ForemanPuppet
       h.save!
       assert_empty h.puppet.config_groups
     end
+
+    test 'assign a puppet class to host without puppet facet' do
+      puppet_class = FactoryBot.create(:puppetclass)
+      host = FactoryBot.create(:host)
+      # This would raise the following exception
+      # NoMethodError: undefined method `<<' for #<ActiveRecord::Relation []>
+      host.puppetclasses << puppet_class
+
+      assert_not_nil host.puppet
+      assert_includes host.puppet.puppetclasses, puppet_class
+      assert_includes host.puppetclasses, puppet_class
+    end
   end
 end

data/test/models/foreman_puppet/hostgroup_test.rb

@@ -10,5 +10,17 @@ module ForemanPuppet
       assert_equal 1, hostgroups.count
       assert_equal hostgroups.pluck(:id).sort, hostgroups.map(&:id).sort
     end
+
+    test 'assign a puppet class to hostgroup without puppet facet' do
+      puppet_class = FactoryBot.create(:puppetclass)
+      hostgroup = FactoryBot.create(:hostgroup)
+      # This would raise the following exception
+      # NoMethodError: undefined method `<<' for #<ActiveRecord::Relation []>
+      hostgroup.puppetclasses << puppet_class
+
+      assert_not_nil hostgroup.puppet
+      assert_includes hostgroup.puppet.puppetclasses, puppet_class
+      assert_includes hostgroup.puppetclasses, puppet_class
+    end
   end
 end

data/webpack/src/foreman_class_edit.js

@@ -154,7 +154,7 @@ export function addConfigGroup(item) {
     .addClass('selected-marker')
     .hide();
 
-  const puppetclassIds = $.parseJSON($(item).attr('data-puppetclass-ids'));
+  const puppetclassIds = JSON.parse($(item).attr('data-puppetclass-ids'));
   const inheritedIds = _getInheritedIds();
 
   $.each(puppetclassIds, (index, puppetclassId) => {
@@ -182,7 +182,7 @@ export function removeConfigGroup(item) {
     .tooltip('hide');
   $(`#selected_config_group_${id}`).remove();
 
-  const puppetclassIds = $.parseJSON($(item).attr('data-puppetclass-ids'));
+  const puppetclassIds = JSON.parse($(item).attr('data-puppetclass-ids'));
   const inheritedIds = _getInheritedIds();
 
   $.each(puppetclassIds, (index, puppetclassId) => {

data/webpack/src/foreman_puppet_host_form.js

@@ -110,7 +110,7 @@ export function checkForUnavailablePuppetclasses() {
       ${warningMessage}
     </span>`;
 
-  if (unavailableClasses.size() > 0) {
+  if (unavailableClasses.length > 0) {
     if (puppetEncTab.find('#puppetclasses_unavailable_warning').length <= 0) {
       tab.prepend('<span class="pficon pficon-warning-triangle-o"></span> ');
       puppetEncTab.prepend(warning);

data/webpack/src/foreman_puppet_host_form.test.js

@@ -37,7 +37,7 @@ describe('checkForUnavailablePuppetclasses', () => {
     );
 
     checkForUnavailablePuppetclasses();
-    expect($('#puppetclasses_unavailable_warning').size()).toBe(1);
+    expect($('#puppetclasses_unavailable_warning').length).toBe(1);
   });
 
   it('does not add a warning if no unavailable classes are found', () => {
@@ -48,8 +48,7 @@ describe('checkForUnavailablePuppetclasses', () => {
     expect(
       $('#hostgroup .help-block')
         .first()
-        .children()
-        .size()
+        .children().length
     ).toBe(0);
   });
 
@@ -59,7 +58,7 @@ describe('checkForUnavailablePuppetclasses', () => {
     );
     checkForUnavailablePuppetclasses();
     setTimeout(() => {
-      expect($('a .pficon').size()).toBe(1);
+      expect($('a .pficon').length).toBe(1);
     }, 100);
   });
 });

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: foreman_puppet
 version: !ruby/object:Gem::Version
-  version: 6.3.0
+  version: 6.4.0
 platform: ruby
 authors:
 - Ondřej Ezr
 - Shira Maximov
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-03-25 00:00:00.000000000 Z
+date: 2024-08-02 00:00:00.000000000 Z
 dependencies: []
 description: Allow assigning Puppet environments and classes to the Foreman Hosts.
 email:
@@ -47,6 +47,7 @@ files:
 - app/controllers/concerns/foreman_puppet/extensions/api_smart_proxies_controller.rb
 - app/controllers/concerns/foreman_puppet/extensions/api_template_combinations_controller.rb
 - app/controllers/concerns/foreman_puppet/extensions/api_v2_hosts_controller.rb
+- app/controllers/concerns/foreman_puppet/extensions/api_v2_registration_controller_extensions.rb
 - app/controllers/concerns/foreman_puppet/extensions/hostgroups_controller_extensions.rb
 - app/controllers/concerns/foreman_puppet/extensions/hosts_controller_extensions.rb
 - app/controllers/concerns/foreman_puppet/extensions/operatingsystems_controller.rb
@@ -238,83 +239,46 @@ files:
 - locale/Makefile
 - locale/action_names.rb
 - locale/ca/LC_MESSAGES/foreman_puppet.mo
-- locale/ca/foreman_puppet.edit.po
 - locale/ca/foreman_puppet.po
-- locale/ca/foreman_puppet.po.time_stamp
 - locale/cs_CZ/LC_MESSAGES/foreman_puppet.mo
-- locale/cs_CZ/foreman_puppet.edit.po
 - locale/cs_CZ/foreman_puppet.po
-- locale/cs_CZ/foreman_puppet.po.time_stamp
 - locale/de/LC_MESSAGES/foreman_puppet.mo
-- locale/de/foreman_puppet.edit.po
 - locale/de/foreman_puppet.po
-- locale/de/foreman_puppet.po.time_stamp
 - locale/en/LC_MESSAGES/foreman_puppet.mo
 - locale/en/foreman_puppet.edit.po
 - locale/en/foreman_puppet.po
-- locale/en/foreman_puppet.po.time_stamp
 - locale/en_GB/LC_MESSAGES/foreman_puppet.mo
-- locale/en_GB/foreman_puppet.edit.po
 - locale/en_GB/foreman_puppet.po
-- locale/en_GB/foreman_puppet.po.time_stamp
 - locale/es/LC_MESSAGES/foreman_puppet.mo
-- locale/es/foreman_puppet.edit.po
 - locale/es/foreman_puppet.po
-- locale/es/foreman_puppet.po.time_stamp
 - locale/foreman_puppet.pot
 - locale/fr/LC_MESSAGES/foreman_puppet.mo
-- locale/fr/foreman_puppet.edit.po
 - locale/fr/foreman_puppet.po
-- locale/fr/foreman_puppet.po.time_stamp
 - locale/gemspec.rb
 - locale/gl/LC_MESSAGES/foreman_puppet.mo
-- locale/gl/foreman_puppet.edit.po
 - locale/gl/foreman_puppet.po
-- locale/gl/foreman_puppet.po.time_stamp
 - locale/it/LC_MESSAGES/foreman_puppet.mo
-- locale/it/foreman_puppet.edit.po
 - locale/it/foreman_puppet.po
-- locale/it/foreman_puppet.po.time_stamp
 - locale/ja/LC_MESSAGES/foreman_puppet.mo
-- locale/ja/foreman_puppet.edit.po
 - locale/ja/foreman_puppet.po
-- locale/ja/foreman_puppet.po.time_stamp
 - locale/ka/LC_MESSAGES/foreman_puppet.mo
-- locale/ka/foreman_puppet.edit.po
 - locale/ka/foreman_puppet.po
-- locale/ka/foreman_puppet.po.time_stamp
 - locale/ko/LC_MESSAGES/foreman_puppet.mo
-- locale/ko/foreman_puppet.edit.po
 - locale/ko/foreman_puppet.po
-- locale/ko/foreman_puppet.po.time_stamp
 - locale/nl_NL/LC_MESSAGES/foreman_puppet.mo
-- locale/nl_NL/foreman_puppet.edit.po
 - locale/nl_NL/foreman_puppet.po
-- locale/nl_NL/foreman_puppet.po.time_stamp
 - locale/pl/LC_MESSAGES/foreman_puppet.mo
-- locale/pl/foreman_puppet.edit.po
 - locale/pl/foreman_puppet.po
-- locale/pl/foreman_puppet.po.time_stamp
 - locale/pt_BR/LC_MESSAGES/foreman_puppet.mo
-- locale/pt_BR/foreman_puppet.edit.po
 - locale/pt_BR/foreman_puppet.po
-- locale/pt_BR/foreman_puppet.po.time_stamp
 - locale/ru/LC_MESSAGES/foreman_puppet.mo
-- locale/ru/foreman_puppet.edit.po
 - locale/ru/foreman_puppet.po
-- locale/ru/foreman_puppet.po.time_stamp
 - locale/sv_SE/LC_MESSAGES/foreman_puppet.mo
-- locale/sv_SE/foreman_puppet.edit.po
 - locale/sv_SE/foreman_puppet.po
-- locale/sv_SE/foreman_puppet.po.time_stamp
 - locale/zh_CN/LC_MESSAGES/foreman_puppet.mo
-- locale/zh_CN/foreman_puppet.edit.po
 - locale/zh_CN/foreman_puppet.po
-- locale/zh_CN/foreman_puppet.po.time_stamp
 - locale/zh_TW/LC_MESSAGES/foreman_puppet.mo
-- locale/zh_TW/foreman_puppet.edit.po
 - locale/zh_TW/foreman_puppet.po
-- locale/zh_TW/foreman_puppet.po.time_stamp
 - package.json
 - test/controllers/foreman_puppet/api/v2/config_groups_controller_test.rb
 - test/controllers/foreman_puppet/api/v2/environments_controller_test.rb
@@ -426,7 +390,7 @@ homepage: https://github.com/theforeman/foreman_puppet
 licenses:
 - GPL-3.0
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -444,76 +408,76 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key:
+rubygems_version: 3.1.2
+signing_key: 
 specification_version: 4
 summary: Add Puppet features to Foreman
 test_files:
-- test/controllers/foreman_puppet/api/v2/config_groups_controller_test.rb
-- test/controllers/foreman_puppet/api/v2/host_classes_controller_test.rb
-- test/controllers/foreman_puppet/api/v2/hostgroup_classes_controller_test.rb
-- test/controllers/foreman_puppet/api/v2/hostgroups_controller_test.rb
-- test/controllers/foreman_puppet/api/v2/lookups_common_controller_test.rb
-- test/controllers/foreman_puppet/api/v2/provisioning_templates_controller_test.rb
-- test/controllers/foreman_puppet/api/v2/puppetclasses_controller_test.rb
-- test/controllers/foreman_puppet/api/v2/smart_proxies_controller_test.rb
-- test/controllers/foreman_puppet/api/v2/template_combinations_controller_test.rb
-- test/controllers/foreman_puppet/api/v2/environments_controller_test.rb
-- test/controllers/foreman_puppet/api/v2/smart_class_parameters_controller_test.rb
-- test/controllers/foreman_puppet/api/v2/hosts_controller_test.rb
-- test/controllers/foreman_puppet/api/v2/override_values_controller_test.rb
-- test/controllers/foreman_puppet/config_groups_controller_test.rb
-- test/controllers/foreman_puppet/hostgroups_controller_test.rb
-- test/controllers/foreman_puppet/puppet_smart_proxies_controller_test.rb
-- test/controllers/foreman_puppet/puppetclass_lookup_keys_controller_test.rb
-- test/controllers/foreman_puppet/puppetclasses_controller_test.rb
-- test/controllers/foreman_puppet/environments_controller_test.rb
-- test/controllers/foreman_puppet/hosts_controller_test.rb
-- test/controllers/provisioning_templates_controller_test.rb
-- test/factories/foreman_puppet_factories.rb
-- test/factories/host_puppet_enhancements.rb
-- test/factories/proxy_puppet_enhancements.rb
-- test/graphql/mutations/hosts/create_mutation_test.rb
-- test/graphql/queries/environments_query_test.rb
-- test/graphql/queries/host_puppet_query_test.rb
-- test/graphql/queries/hostgroup_puppet_query_test.rb
-- test/graphql/queries/location_query_test.rb
-- test/graphql/queries/organization_query_test.rb
-- test/graphql/queries/puppetclasses_query_test.rb
-- test/graphql/queries/environment_query_test.rb
-- test/graphql/queries/puppetclass_query_test.rb
+- test/unit/foreman_puppet_test.rb
+- test/unit/foreman_puppet/global_id_test.rb
+- test/unit/foreman_puppet/puppet_class_importer_test.rb
+- test/unit/foreman_puppet/template_rendering_test.rb
+- test/unit/foreman_puppet/access_permissions_test.rb
+- test/helpers/foreman_puppet/puppetclass_lookup_keys_helper_test.rb
 - test/helpers/foreman_puppet/hosts_and_hostgroups_helper_test.rb
 - test/helpers/foreman_puppet/puppetclasses_helper_test.rb
-- test/helpers/foreman_puppet/puppetclass_lookup_keys_helper_test.rb
 - test/integration/foreman_puppet/dashboard_js_test.rb
-- test/integration/foreman_puppet/environment_js_test.rb
-- test/integration/foreman_puppet/hostgroup_js_test.rb
-- test/integration/foreman_puppet/puppetclass_js_test.rb
 - test/integration/foreman_puppet/host_js_test.rb
+- test/integration/foreman_puppet/hostgroup_js_test.rb
 - test/integration/foreman_puppet/smartclass_parameter_js_test.rb
-- test/models/foreman_puppet/config_group_class_test.rb
+- test/integration/foreman_puppet/puppetclass_js_test.rb
+- test/integration/foreman_puppet/environment_js_test.rb
+- test/factories/foreman_puppet_factories.rb
+- test/factories/host_puppet_enhancements.rb
+- test/factories/proxy_puppet_enhancements.rb
+- test/integration_puppet_helper.rb
 - test/models/foreman_puppet/config_group_test.rb
-- test/models/foreman_puppet/environment_test.rb
-- test/models/foreman_puppet/host_config_group_test.rb
-- test/models/foreman_puppet/hostgroup_puppet_facet_test.rb
-- test/models/foreman_puppet/hostgroup_test.rb
-- test/models/foreman_puppet/lookup_value_test.rb
-- test/models/foreman_puppet/puppetclass_lookup_key_test.rb
 - test/models/foreman_puppet/report_test.rb
-- test/models/foreman_puppet/smart_proxy_test.rb
+- test/models/foreman_puppet/host_puppet_facet_test.rb
+- test/models/foreman_puppet/host_test.rb
 - test/models/foreman_puppet/user_test.rb
 - test/models/foreman_puppet/provisioning_template_test.rb
+- test/models/foreman_puppet/host_config_group_test.rb
+- test/models/foreman_puppet/lookup_value_test.rb
+- test/models/foreman_puppet/hostgroup_test.rb
+- test/models/foreman_puppet/hostgroup_puppet_facet_test.rb
+- test/models/foreman_puppet/puppetclass_lookup_key_test.rb
+- test/models/foreman_puppet/environment_test.rb
 - test/models/foreman_puppet/puppetclass_test.rb
-- test/models/foreman_puppet/host_puppet_facet_test.rb
-- test/models/foreman_puppet/host_test.rb
-- test/services/foreman_puppet/host_info_providers/config_groups_info_test.rb
-- test/services/foreman_puppet/host_info_providers/puppet_info_test.rb
+- test/models/foreman_puppet/config_group_class_test.rb
+- test/models/foreman_puppet/smart_proxy_test.rb
+- test/graphql/queries/hostgroup_puppet_query_test.rb
+- test/graphql/queries/puppetclass_query_test.rb
+- test/graphql/queries/location_query_test.rb
+- test/graphql/queries/organization_query_test.rb
+- test/graphql/queries/puppetclasses_query_test.rb
+- test/graphql/queries/environment_query_test.rb
+- test/graphql/queries/environments_query_test.rb
+- test/graphql/queries/host_puppet_query_test.rb
+- test/graphql/mutations/hosts/create_mutation_test.rb
+- test/test_puppet_helper.rb
+- test/controllers/provisioning_templates_controller_test.rb
+- test/controllers/foreman_puppet/hostgroups_controller_test.rb
+- test/controllers/foreman_puppet/puppetclass_lookup_keys_controller_test.rb
+- test/controllers/foreman_puppet/environments_controller_test.rb
+- test/controllers/foreman_puppet/puppet_smart_proxies_controller_test.rb
+- test/controllers/foreman_puppet/hosts_controller_test.rb
+- test/controllers/foreman_puppet/api/v2/template_combinations_controller_test.rb
+- test/controllers/foreman_puppet/api/v2/smart_class_parameters_controller_test.rb
+- test/controllers/foreman_puppet/api/v2/host_classes_controller_test.rb
+- test/controllers/foreman_puppet/api/v2/hostgroups_controller_test.rb
+- test/controllers/foreman_puppet/api/v2/lookups_common_controller_test.rb
+- test/controllers/foreman_puppet/api/v2/environments_controller_test.rb
+- test/controllers/foreman_puppet/api/v2/hosts_controller_test.rb
+- test/controllers/foreman_puppet/api/v2/hostgroup_classes_controller_test.rb
+- test/controllers/foreman_puppet/api/v2/puppetclasses_controller_test.rb
+- test/controllers/foreman_puppet/api/v2/smart_proxies_controller_test.rb
+- test/controllers/foreman_puppet/api/v2/override_values_controller_test.rb
+- test/controllers/foreman_puppet/api/v2/config_groups_controller_test.rb
+- test/controllers/foreman_puppet/api/v2/provisioning_templates_controller_test.rb
+- test/controllers/foreman_puppet/puppetclasses_controller_test.rb
+- test/controllers/foreman_puppet/config_groups_controller_test.rb
 - test/services/foreman_puppet/input_type/puppet_parameter_input_test.rb
 - test/services/foreman_puppet/host_counter_test.rb
-- test/unit/foreman_puppet/access_permissions_test.rb
-- test/unit/foreman_puppet/puppet_class_importer_test.rb
-- test/unit/foreman_puppet/template_rendering_test.rb
-- test/unit/foreman_puppet/global_id_test.rb
-- test/unit/foreman_puppet_test.rb
-- test/test_puppet_helper.rb
-- test/integration_puppet_helper.rb
+- test/services/foreman_puppet/host_info_providers/config_groups_info_test.rb
+- test/services/foreman_puppet/host_info_providers/puppet_info_test.rb