foreman_puppet 6.1.1 → 6.3.0

data/locale/sv_SE/foreman_puppet.po

@@ -113,6 +113,9 @@ msgstr "Byt Miljö"
 msgid "Change Puppet Master"
 msgstr ""
 
+msgid "Changed"
+msgstr ""
+
 msgid "Changed environments"
 msgstr "Ändrade miljöer"
 
@@ -152,6 +155,9 @@ msgstr ""
 msgid "Copy to clipboard"
 msgstr ""
 
+msgid "Corrective Change"
+msgstr ""
+
 msgid "Couldn't find any ENC data for this host"
 msgstr ""
 
@@ -266,12 +272,18 @@ msgstr ""
 msgid "Facts"
 msgstr "Fakta"
 
+msgid "Failed"
+msgstr ""
+
 msgid "Failed to import %{klass} for %{name}: doesn't exists in our database - ignoring"
 msgstr "Misslyckades med att importera %{klass} på grund av att %{name}: inte existerar i vår databas - ignorerar"
 
 msgid "Failed to set %{proxy_type} proxy for %{host}."
 msgstr ""
 
+msgid "Failed to start"
+msgstr ""
+
 msgid "Failed to update environments and Puppet classes from the on-disk Puppet installation: %s"
 msgstr ""
 
@@ -413,6 +425,9 @@ msgstr ""
 msgid "Invalid proxy selected!"
 msgstr ""
 
+msgid "Last configuration status"
+msgstr ""
+
 msgid "List all Puppet class IDs for host"
 msgstr ""
 
@@ -488,12 +503,18 @@ msgstr ""
 msgid "Name"
 msgstr "Namn"
 
+msgid "Never"
+msgstr ""
+
 msgid "New"
 msgstr "Ny"
 
 msgid "No changes to your environments detected"
 msgstr ""
 
+msgid "No configuration status available"
+msgstr ""
+
 msgid "No environment selected!"
 msgstr "Ingen miljö vald!"
 
@@ -557,6 +578,9 @@ msgstr "Organisationer"
 msgid "Original value info"
 msgstr ""
 
+msgid "Out of sync"
+msgstr ""
+
 msgid "Overridden"
 msgstr ""
 
@@ -641,6 +665,9 @@ msgstr "Puppet externa noder YAML-export"
 msgid "Puppet interval"
 msgstr ""
 
+msgid "Puppet metrics"
+msgstr ""
+
 msgid "Puppet parameter"
 msgstr ""
 
@@ -677,6 +704,12 @@ msgstr "Rapporter"
 msgid "Required parameter without value.<br/><b>Please override!</b><br/>"
 msgstr ""
 
+msgid "Restarted"
+msgstr ""
+
+msgid "Scheduled"
+msgstr ""
+
 msgid "Select environment"
 msgstr "Välj miljö"
 
@@ -713,6 +746,9 @@ msgstr ""
 msgid "Show template combination"
 msgstr ""
 
+msgid "Skipped"
+msgstr ""
+
 msgid "Smart Class Parameter"
 msgstr "Smart Klassparameter"
 

data/locale/zh_CN/foreman_puppet.po

@@ -117,6 +117,9 @@ msgstr "改变环境"
 msgid "Change Puppet Master"
 msgstr "更改 Puppet 主服务器"
 
+msgid "Changed"
+msgstr ""
+
 msgid "Changed environments"
 msgstr "修改的环境"
 
@@ -156,6 +159,9 @@ msgstr "配置管理"
 msgid "Copy to clipboard"
 msgstr ""
 
+msgid "Corrective Change"
+msgstr ""
+
 msgid "Couldn't find any ENC data for this host"
 msgstr "无法找到此主机的任何 ENC 数据"
 
@@ -270,12 +276,18 @@ msgstr "错误！"
 msgid "Facts"
 msgstr "Facts"
 
+msgid "Failed"
+msgstr ""
+
 msgid "Failed to import %{klass} for %{name}: doesn't exists in our database - ignoring"
 msgstr "为 %{name} 导入 %{klass} 失败：不存在于我们的数据库中 -- 忽略"
 
 msgid "Failed to set %{proxy_type} proxy for %{host}."
 msgstr "无法为 %{host} 设置 {proxy_type} 代理服务器。"
 
+msgid "Failed to start"
+msgstr ""
+
 msgid "Failed to update environments and Puppet classes from the on-disk Puppet installation: %s"
 msgstr "无法使用磁盘 Puppet 安装更新环境及 Puppet 类别：%s"
 
@@ -417,6 +429,9 @@ msgstr "从 %s 继承的类"
 msgid "Invalid proxy selected!"
 msgstr "所选代理服务器无效！"
 
+msgid "Last configuration status"
+msgstr ""
+
 msgid "List all Puppet class IDs for host"
 msgstr "列出主机的所有 Puppet 类 ID"
 
@@ -492,12 +507,18 @@ msgstr "合并所有匹配的值（仅用于阵列/哈希类型）"
 msgid "Name"
 msgstr "名称"
 
+msgid "Never"
+msgstr ""
+
 msgid "New"
 msgstr "新"
 
 msgid "No changes to your environments detected"
 msgstr "未探测到您的环境有任何变化"
 
+msgid "No configuration status available"
+msgstr ""
+
 msgid "No environment selected!"
 msgstr "没有选择环境！"
 
@@ -561,6 +582,9 @@ msgstr "机构"
 msgid "Original value info"
 msgstr "原始值信息"
 
+msgid "Out of sync"
+msgstr ""
+
 msgid "Overridden"
 msgstr "覆盖"
 
@@ -645,6 +669,9 @@ msgstr "Puppet 外部节点 YAML 转储"
 msgid "Puppet interval"
 msgstr "Puppet 间隔"
 
+msgid "Puppet metrics"
+msgstr ""
+
 msgid "Puppet parameter"
 msgstr "Puppet 参数"
 
@@ -681,6 +708,12 @@ msgstr "报表"
 msgid "Required parameter without value.<br/><b>Please override!</b><br/>"
 msgstr "需要的参数没有值。<br/><b>请覆盖</b><br/>"
 
+msgid "Restarted"
+msgstr ""
+
+msgid "Scheduled"
+msgstr ""
+
 msgid "Select environment"
 msgstr "选择环境"
 
@@ -717,6 +750,9 @@ msgstr "显示具体智能类别参数的替代值"
 msgid "Show template combination"
 msgstr "显示模板组合"
 
+msgid "Skipped"
+msgstr ""
+
 msgid "Smart Class Parameter"
 msgstr "智能代理参数"
 

data/locale/zh_TW/foreman_puppet.po

@@ -112,6 +112,9 @@ msgstr "更改環境"
 msgid "Change Puppet Master"
 msgstr "改變 Puppet Master"
 
+msgid "Changed"
+msgstr ""
+
 msgid "Changed environments"
 msgstr "已更改的環境"
 
@@ -151,6 +154,9 @@ msgstr ""
 msgid "Copy to clipboard"
 msgstr ""
 
+msgid "Corrective Change"
+msgstr ""
+
 msgid "Couldn't find any ENC data for this host"
 msgstr ""
 
@@ -265,12 +271,18 @@ msgstr ""
 msgid "Facts"
 msgstr "詳情"
 
+msgid "Failed"
+msgstr ""
+
 msgid "Failed to import %{klass} for %{name}: doesn't exists in our database - ignoring"
 msgstr "為 %{name} 匯入 %{klass} 失敗：不存在我們的資料庫中 - 將被忽略"
 
 msgid "Failed to set %{proxy_type} proxy for %{host}."
 msgstr "設定 %{proxy_type} 代理給 %{host} 時失敗。"
 
+msgid "Failed to start"
+msgstr ""
+
 msgid "Failed to update environments and Puppet classes from the on-disk Puppet installation: %s"
 msgstr ""
 
@@ -412,6 +424,9 @@ msgstr ""
 msgid "Invalid proxy selected!"
 msgstr "選擇了不正確的代理！"
 
+msgid "Last configuration status"
+msgstr ""
+
 msgid "List all Puppet class IDs for host"
 msgstr "列出主機的所有 Puppet 類別 ID"
 
@@ -487,12 +502,18 @@ msgstr "合併所有相符的值（只有陣列 / 雜湊類型）"
 msgid "Name"
 msgstr "名稱"
 
+msgid "Never"
+msgstr ""
+
 msgid "New"
 msgstr "新增"
 
 msgid "No changes to your environments detected"
 msgstr "未偵測到您的環境遭到變更"
 
+msgid "No configuration status available"
+msgstr ""
+
 msgid "No environment selected!"
 msgstr "未選擇環境！"
 
@@ -556,6 +577,9 @@ msgstr "組織"
 msgid "Original value info"
 msgstr "原始值資訊"
 
+msgid "Out of sync"
+msgstr ""
+
 msgid "Overridden"
 msgstr ""
 
@@ -640,6 +664,9 @@ msgstr "Puppet 外部節點 YAML 傾印"
 msgid "Puppet interval"
 msgstr "Puppet 間隔"
 
+msgid "Puppet metrics"
+msgstr ""
+
 msgid "Puppet parameter"
 msgstr "Puppet 參數"
 
@@ -676,6 +703,12 @@ msgstr "報告"
 msgid "Required parameter without value.<br/><b>Please override!</b><br/>"
 msgstr "必要的參數未提供值。<br/><b>請覆寫！</b> <br/>"
 
+msgid "Restarted"
+msgstr ""
+
+msgid "Scheduled"
+msgstr ""
+
 msgid "Select environment"
 msgstr "選擇環境"
 
@@ -712,6 +745,9 @@ msgstr "顯示特定智慧類別參數的置換值"
 msgid "Show template combination"
 msgstr "顯示範本組合"
 
+msgid "Skipped"
+msgstr ""
+
 msgid "Smart Class Parameter"
 msgstr "智慧類別參數"
 

data/test/integration/foreman_puppet/smartclass_parameter_js_test.rb

@@ -74,6 +74,8 @@ module ForemanPuppet
       within(:xpath, '//table') do
         click_link 'ssl'
       end
+      # see: https://projects.theforeman.org/issues/37251
+      page.driver.browser.file_detector = nil if page.driver.browser.respond_to?(:file_detector=)
       fill_in 'puppetclass_lookup_key_description', with: 'test'
       fill_in 'puppetclass_lookup_key_default_value', with: 'false'
       assert_submit_button(puppetclass_lookup_keys_path)

data/test/models/foreman_puppet/host_test.rb

@@ -172,7 +172,7 @@ module ForemanPuppet
         host.expects(:template_kinds).returns(template_kinds)
         template_kinds.each do |kind|
           ::ProvisioningTemplate.expects(:find_template)
-                                .with(kind: kind.name, operatingsystem_id: host.operatingsystem.id, hostgroup_id: host.hostgroup.id, environment_id: host.puppet.environment.id)
+                                .with({ kind: kind.name, operatingsystem_id: host.operatingsystem.id, hostgroup_id: host.hostgroup.id, environment_id: host.puppet.environment.id })
                                 .returns(stub(name: "default #{kind.name}"))
         end
         assert_equal template_kinds.map { |k| "default #{k.name}" }, host.available_template_kinds.map(&:name)
@@ -183,7 +183,7 @@ module ForemanPuppet
         host.expects(:template_kinds).returns(template_kinds)
         template_kinds.each do |kind|
           ::ProvisioningTemplate.expects(:find_template)
-                                .with(kind: kind.name, operatingsystem_id: host.operatingsystem.id, hostgroup_id: host.hostgroup.id, environment_id: nil)
+                                .with({ kind: kind.name, operatingsystem_id: host.operatingsystem.id, hostgroup_id: host.hostgroup.id, environment_id: nil })
                                 .returns(stub(name: "default #{kind.name}"))
         end
         assert_equal template_kinds.map { |k| "default #{k.name}" }, host.available_template_kinds.map(&:name)

data/webpack/src/Extends/Host/PuppetTab/Routes.js

@@ -6,7 +6,7 @@ import Reports from './SubTabs/Reports';
 import ENCPreview from './SubTabs/ENCPreview';
 
 const SecondaryTabRoutes = ({ hostName, hostInfo, status }) => (
-  <Switch>
+  <Switch ouiaId="foreman-puppet-switch">
     <Route path={route('reports')}>
       <Reports hostName={hostName} hostInfo={hostInfo} status={status} />
     </Route>

data/webpack/src/Extends/Host/PuppetTab/SubTabs/Reports/components/ConfigStatusCard/ConfigStatusCardActions.js

@@ -0,0 +1,10 @@
+import { API_OPERATIONS, get } from 'foremanReact/redux/API';
+import { FOREMAN_PUPPET_LAST_REPORT_KEY } from './ConfigStatusCardConstants';
+
+export const getReportByIdAction = reportId =>
+  get({
+    type: API_OPERATIONS.GET,
+    key: FOREMAN_PUPPET_LAST_REPORT_KEY,
+    url: `/api/config_reports/${reportId}`,
+  });
+export default getReportByIdAction;

data/webpack/src/Extends/Host/PuppetTab/SubTabs/Reports/components/ConfigStatusCard/ConfigStatusCardConstants.js

@@ -0,0 +1 @@
+export const FOREMAN_PUPPET_LAST_REPORT_KEY = 'FOREMAN_PUPPET_LAST_REPORT';

data/webpack/src/Extends/Host/PuppetTab/SubTabs/Reports/components/ConfigStatusCard/index.js

@@ -0,0 +1,186 @@
+import PropTypes from 'prop-types';
+import React, { useCallback, useEffect } from 'react';
+import {
+  Divider,
+  Flex,
+  FlexItem,
+  Button,
+  DescriptionList,
+  DescriptionListTerm,
+  DescriptionListGroup,
+  DescriptionListDescription,
+} from '@patternfly/react-core';
+import {
+  TableComposable,
+  TableText,
+  Tr,
+  Tbody,
+  Td,
+} from '@patternfly/react-table';
+import { useSelector, useDispatch } from 'react-redux';
+import { selectAPIResponse } from 'foremanReact/redux/API/APISelectors';
+import CardTemplate from 'foremanReact/components/HostDetails/Templates/CardItem/CardTemplate';
+import RelativeDateTime from 'foremanReact/components/common/dates/RelativeDateTime';
+import SkeletonLoader from 'foremanReact/components/common/SkeletonLoader';
+import DefaultLoaderEmptyState from 'foremanReact/components/HostDetails/DetailsCard/DefaultLoaderEmptyState';
+import { statusFormatter } from 'foremanReact/components/HostDetails/Tabs/ReportsTab/helpers';
+import { translate as __ } from 'foremanReact/common/I18n';
+
+import { getReportByIdAction } from './ConfigStatusCardActions';
+import { FOREMAN_PUPPET_LAST_REPORT_KEY } from './ConfigStatusCardConstants';
+import './styles.scss';
+
+const cardHeaderDivider = () => (
+  <Divider
+    orientation={{
+      default: 'vertical',
+    }}
+    inset={{ default: 'insetMd' }}
+  />
+);
+
+const generateCardHeader = (allReports = [], reportsCount) =>
+  reportsCount > 0 ? (
+    <>
+      {__('Last configuration status')}
+      <Flex>
+        <FlexItem>
+          <Button
+            ouiaId="foreman-puppet-last-report-button"
+            variant="link"
+            component="a"
+            isInline
+            isDisabled={!allReports.length}
+            href={`/config_reports/${allReports[0].id}`}
+          >
+            <RelativeDateTime
+              date={allReports[0].reported_at}
+              defaultValue={__('Never')}
+            />
+          </Button>
+        </FlexItem>
+        <FlexItem>{statusFormatter('failed', allReports[0])}</FlexItem>
+        {cardHeaderDivider()}
+        <FlexItem>{statusFormatter('failed_restarts', allReports[0])}</FlexItem>
+        {cardHeaderDivider()}
+        <FlexItem>{statusFormatter('restarted', allReports[0])}</FlexItem>
+        {cardHeaderDivider()}
+        <FlexItem>{statusFormatter('applied', allReports[0])}</FlexItem>
+        {cardHeaderDivider()}
+        <FlexItem>{statusFormatter('skipped', allReports[0])}</FlexItem>
+        {cardHeaderDivider()}
+        <FlexItem>{statusFormatter('pending', allReports[0])}</FlexItem>
+      </Flex>
+    </>
+  ) : (
+    <> {__('No configuration status available')} </>
+  );
+
+const createPuppetMetricsTableElement = (name, value = '--') => (
+  <>
+    <Td modifier="truncate" key={`metrics-name-${name}`}>
+      <TableText
+        className={name === 'Total' ? 'last-config-puppet-metrics-total' : ''}
+      >
+        {name}
+      </TableText>
+    </Td>
+    <Td modifier="truncate" key={`metrics-name-${value}`}>
+      <TableText
+        className={name === 'Total' ? 'last-config-puppet-metrics-total' : ''}
+      >
+        {value}
+      </TableText>
+    </Td>
+  </>
+);
+
+const createPuppetMetricsTable = (metrics = undefined) => (
+  <TableComposable
+    aria-label="foreman puppet metrics table"
+    variant="compact"
+    borders="compactBorderless"
+    ouiaId="foreman-puppet-metrics-table"
+    key="foreman-puppet-metrics-table"
+  >
+    <Tbody>
+      <Tr>
+        {createPuppetMetricsTableElement(__('Failed'), metrics.failed)}
+        {createPuppetMetricsTableElement(__('Changed'), metrics.changed)}
+        {createPuppetMetricsTableElement(__('Scheduled'), metrics.scheduled)}
+      </Tr>
+      <Tr>
+        {createPuppetMetricsTableElement(
+          __('Failed to start'),
+          metrics.failed_to_start
+        )}
+        {createPuppetMetricsTableElement(__('Restarted'), metrics.restarted)}
+        {createPuppetMetricsTableElement(
+          __('Corrective Change'),
+          metrics.corrective_change
+        )}
+      </Tr>
+      <Tr>
+        {createPuppetMetricsTableElement(__('Skipped'), metrics.skipped)}
+        {createPuppetMetricsTableElement(
+          __('Out of sync'),
+          metrics.out_of_sync
+        )}
+        {createPuppetMetricsTableElement(__('Total'), metrics.total)}
+      </Tr>
+    </Tbody>
+  </TableComposable>
+);
+
+const ConfigStatusCard = ({ hostName, parentStatus }) => {
+  const dispatch = useDispatch();
+  // get already fetched results from reports tab
+  const API_KEY = `get-reports-${hostName}`;
+  const { reports, itemCount } = useSelector(state =>
+    selectAPIResponse(state, API_KEY)
+  );
+
+  // we need to fetch the last Puppet report to get all Puppet metrics
+  const getLastReport = useCallback(() => {
+    if (hostName && reports?.length)
+      dispatch(getReportByIdAction(reports[0].id));
+  }, [hostName, reports, dispatch]);
+
+  useEffect(() => {
+    getLastReport();
+  }, [hostName, reports]);
+
+  const { metrics } = useSelector(state =>
+    selectAPIResponse(state, FOREMAN_PUPPET_LAST_REPORT_KEY)
+  );
+
+  return (
+    <CardTemplate header={generateCardHeader(reports, itemCount)} expandable>
+      <DescriptionList isCompact>
+        <DescriptionListGroup>
+          <DescriptionListTerm>{__('Puppet metrics')}</DescriptionListTerm>
+          <DescriptionListDescription>
+            <SkeletonLoader
+              status={parentStatus}
+              emptyState={<DefaultLoaderEmptyState />}
+            >
+              {metrics && createPuppetMetricsTable(metrics.resources)}
+            </SkeletonLoader>
+          </DescriptionListDescription>
+        </DescriptionListGroup>
+      </DescriptionList>
+    </CardTemplate>
+  );
+};
+
+ConfigStatusCard.propTypes = {
+  hostName: PropTypes.string,
+  parentStatus: PropTypes.string,
+};
+
+ConfigStatusCard.defaultProps = {
+  hostName: undefined,
+  parentStatus: undefined,
+};
+
+export default ConfigStatusCard;

data/webpack/src/Extends/Host/PuppetTab/SubTabs/Reports/components/ConfigStatusCard/styles.scss

@@ -0,0 +1,3 @@
+.last-config-puppet-metrics-total {
+  font-weight: bold;
+}

data/webpack/src/Extends/Host/PuppetTab/SubTabs/Reports/index.js

@@ -3,6 +3,7 @@ import React from 'react';
 import { Grid, GridItem } from '@patternfly/react-core';
 import ReportsTab from 'foremanReact/components/HostDetails/Tabs/ReportsTab';
 import DescriptionCard from './components/DescriptionCard';
+import ConfigStatusCard from './components/ConfigStatusCard';
 import './styles.scss';
 
 const Reports = ({
@@ -18,6 +19,9 @@ const Reports = ({
 }) => (
   <div className="report-tab">
     <Grid hasGutter>
+      <GridItem span={8}>
+        <ConfigStatusCard hostName={hostName} parentStatus={status} />
+      </GridItem>
       <GridItem span={4}>
         <DescriptionCard
           proxyName={proxyName}

data/webpack/src/Extends/Host/PuppetTab/index.js

@@ -8,13 +8,15 @@ import SecondaryTabRoutes from './Routes';
 import { activeTab } from './helpers';
 import { SECONDARY_TABS } from './constants';
 
+import './styles.scss';
+
 const PuppetTab = ({ response, status, location: { pathname } }) => {
   const hashHistory = useHistory();
   return (
     <>
       <Tabs
-        ouiaId="puppet-tabs"
-        className="margin-0-24"
+        ouiaId="foreman-puppet-host-details-tab"
+        className="foreman-puppet-host-details-tab"
         onSelect={(evt, subTab) => hashHistory.push(subTab)}
         isSecondary
         activeKey={activeTab(pathname)}

data/webpack/src/Extends/Host/PuppetTab/styles.scss

@@ -0,0 +1,9 @@
+
+.pf-c-tabs.pf-m-secondary.foreman-puppet-host-details-tab {
+  overflow: visible;
+}
+
+.foreman-puppet-host-details-tab {
+  margin: 0 24px
+}
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foreman_puppet
 version: !ruby/object:Gem::Version
-  version: 6.1.1
+  version: 6.3.0
 platform: ruby
 authors:
 - Ondřej Ezr
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-12-01 00:00:00.000000000 Z
+date: 2024-03-25 00:00:00.000000000 Z
 dependencies: []
 description: Allow assigning Puppet environments and classes to the Foreman Hosts.
 email:
@@ -401,12 +401,17 @@ files:
 - webpack/src/Extends/Host/PuppetTab/SubTabs/ENCPreview/ENCTab.js
 - webpack/src/Extends/Host/PuppetTab/SubTabs/ENCPreview/index.js
 - webpack/src/Extends/Host/PuppetTab/SubTabs/EmptyPage.js
+- webpack/src/Extends/Host/PuppetTab/SubTabs/Reports/components/ConfigStatusCard/ConfigStatusCardActions.js
+- webpack/src/Extends/Host/PuppetTab/SubTabs/Reports/components/ConfigStatusCard/ConfigStatusCardConstants.js
+- webpack/src/Extends/Host/PuppetTab/SubTabs/Reports/components/ConfigStatusCard/index.js
+- webpack/src/Extends/Host/PuppetTab/SubTabs/Reports/components/ConfigStatusCard/styles.scss
 - webpack/src/Extends/Host/PuppetTab/SubTabs/Reports/components/DescriptionCard.js
 - webpack/src/Extends/Host/PuppetTab/SubTabs/Reports/index.js
 - webpack/src/Extends/Host/PuppetTab/SubTabs/Reports/styles.scss
 - webpack/src/Extends/Host/PuppetTab/constants.js
 - webpack/src/Extends/Host/PuppetTab/helpers.js
 - webpack/src/Extends/Host/PuppetTab/index.js
+- webpack/src/Extends/Host/PuppetTab/styles.scss
 - webpack/src/ForemanPuppet.js
 - webpack/src/Router/__snapshots__/routes.test.js.snap
 - webpack/src/Router/index.js
@@ -429,7 +434,10 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.7'
+  - - "<"
+    - !ruby/object:Gem::Version
+      version: '4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -481,8 +489,8 @@ test_files:
 - test/integration/foreman_puppet/environment_js_test.rb
 - test/integration/foreman_puppet/hostgroup_js_test.rb
 - test/integration/foreman_puppet/puppetclass_js_test.rb
-- test/integration/foreman_puppet/smartclass_parameter_js_test.rb
 - test/integration/foreman_puppet/host_js_test.rb
+- test/integration/foreman_puppet/smartclass_parameter_js_test.rb
 - test/models/foreman_puppet/config_group_class_test.rb
 - test/models/foreman_puppet/config_group_test.rb
 - test/models/foreman_puppet/environment_test.rb