foreman_puppet 3.0.5 → 4.0.1

data/package.json

@@ -21,17 +21,17 @@
     "url": "http://projects.theforeman.org/projects/foreman_puppet/issues"
   },
   "peerDependencies": {
-    "@theforeman/vendor": "^8.15.0"
+    "@theforeman/vendor": "^10.1.0"
   },
   "devDependencies": {
     "@babel/core": "^7.7.0",
     "@sheerun/mutationobserver-shim": "^0.3.3",
-    "@theforeman/builder": "^8.15.0",
-    "@theforeman/eslint-plugin-foreman": "^8.15.0",
-    "@theforeman/find-foreman": "^8.15.0",
-    "@theforeman/stories": "^8.15.0",
-    "@theforeman/test": "^8.15.0",
-    "@theforeman/vendor-dev": "^8.15.0",
+    "@theforeman/builder": "^10.1.0",
+    "@theforeman/eslint-plugin-foreman": "^10.1.0",
+    "@theforeman/find-foreman": "^10.1.0",
+    "@theforeman/stories": "^10.1.0",
+    "@theforeman/test": "^10.1.0",
+    "@theforeman/vendor-dev": "^10.1.0",
     "babel-eslint": "^10.0.3",
     "eslint": "^6.7.2",
     "jed": "^1.1.1",

data/test/controllers/foreman_puppet/api/v2/override_values_controller_test.rb

@@ -75,8 +75,12 @@ module ForemanPuppet
               post :create, params: { smart_class_parameter_id: lookup_key.id, override_value: override_value }
             end
             response = ActiveSupport::JSON.decode(@response.body)
-            param_not_posted = (override_value.keys.first.to_s == 'match') ? 'Value' : 'Match' # The opposite of override_value is missing
-            assert_match(/Validation failed: #{param_not_posted} can't be blank/, response['error']['message'])
+            if override_value.keys.first.to_s == 'match'
+              # The opposite of override_value is missing and should fail
+              assert_match(/Validation failed: Value can't be blank/, response['error']['message'])
+            else # match is missing
+              assert_match(/Failed to save the record/, response['error']['message'])
+            end
             assert_response :error
           end
         end

data/test/models/foreman_puppet/host_test.rb

@@ -110,6 +110,12 @@ module ForemanPuppet
     end
 
     describe '#info puppet bits' do
+      test 'ENC YAML omits environment if no puppet facet' do
+        host = FactoryBot.build_stubbed(:host)
+        enc = host.info
+        assert_not_includes enc.keys, 'environment'
+      end
+
       test 'ENC YAML uses Classification::ClassParam for parameterized output' do
         skip 'No idea whats wrong here'
         host = FactoryBot.build_stubbed(:host, :with_environment)

data/webpack/global_index.js

@@ -0,0 +1,11 @@
+import { registerReducer } from 'foremanReact/common/MountingService';
+import reducers from './src/reducers';
+import { registerFills } from './src/Extends/Fills';
+import { registerLegacy } from './legacy';
+
+// register reducers
+registerReducer('puppet', reducers);
+// add fills
+registerFills();
+// TODO: the checkForUnavailablePuppetclasses is very nasty
+registerLegacy();

data/webpack/index.js

@@ -2,16 +2,9 @@
 /* eslint-disable import/no-extraneous-dependencies */
 /* eslint-disable import/extensions */
 import componentRegistry from 'foremanReact/components/componentRegistry';
-import { registerReducer } from 'foremanReact/common/MountingService';
-import reducers from './src/reducers';
 import ForemanPuppet from './src/ForemanPuppet';
 import { WelcomeEnv } from './src/Components/Environments/Welcome';
 
-// register reducers
-Object.entries(reducers).forEach(([key, reducer]) =>
-  registerReducer(key, reducer)
-);
-
 // register components for erb mounting
 componentRegistry.register({ name: 'WelcomeEnv', type: WelcomeEnv });
 componentRegistry.register({ name: 'ForemanPuppet', type: ForemanPuppet });

data/webpack/legacy.js

@@ -0,0 +1,31 @@
+import $ from 'jquery';
+import * as classEditor from './src/foreman_class_edit';
+import * as hostForm from './src/foreman_puppet_host_form';
+
+export const registerLegacy = () => {
+  window.tfm = Object.assign(window.tfm || {}, {
+    classEditor,
+    puppetEnc: {
+      hostForm,
+    },
+  });
+
+  // TODO: the checkForUnavailablePuppetclasses is very nasty
+  $(document)
+    .on('change', '.hostgroup-select', evt => {
+      const form = $('form.host-form')[0];
+      if (form && form.dataset.id) hostForm.updatePuppetclasses(evt.target);
+    })
+    .on('change', '.interface_domain', evt => {
+      hostForm.reloadPuppetclassParams();
+    })
+    .on('change', '.host-architecture-os-select', evt => {
+      hostForm.reloadPuppetclassParams();
+    })
+    .on('ContentLoad', evt => {
+      hostForm.checkForUnavailablePuppetclasses();
+    });
+  $(window).on('load', evt => {
+    hostForm.checkForUnavailablePuppetclasses();
+  });
+};

data/webpack/src/Extends/Fills/index.js

@@ -0,0 +1,26 @@
+import React from 'react';
+import { translate as __ } from 'foremanReact/common/I18n';
+import { addGlobalFill } from 'foremanReact/components/common/Fill/GlobalFill';
+import PuppetTab from '../Host/PuppetTab';
+
+const fills = [
+  {
+    slot: 'host-details-page-tabs',
+    name: 'Puppet',
+    component: props => <PuppetTab {...props} />,
+    weight: 500,
+    metadata: { title: __('Puppet') },
+  },
+];
+
+export const registerFills = () => {
+  fills.forEach(({ slot, name, component: Component, weight, metadata }) =>
+    addGlobalFill(
+      slot,
+      name,
+      <Component key={`puppet-fill-${name}`} />,
+      weight,
+      metadata
+    )
+  );
+};

data/webpack/src/Extends/Host/PuppetTab/Routes.js

@@ -0,0 +1,47 @@
+import PropTypes from 'prop-types';
+import React from 'react';
+import { Route, Switch, Redirect } from 'react-router-dom';
+import { route } from './helpers';
+import EmptyPage from './SubTabs/EmptyPage';
+import Reports from './SubTabs/Reports';
+import ENCPreview from './SubTabs/ENCPreview';
+
+const SecondaryTabRoutes = ({ hostName, hostInfo, status }) => (
+  <Switch>
+    <Route path={route('reports')}>
+      {hostName ? (
+        <Reports hostName={hostName} hostInfo={hostInfo} status={status} />
+      ) : (
+        <EmptyPage header="Reports" />
+      )}
+    </Route>
+    <Route path={route('assigned')}>
+      <EmptyPage header="Assigned classes" />
+    </Route>
+    <Route path={route('smart-classes')}>
+      <EmptyPage header="Smart class parameters" />
+    </Route>
+    <Route path={route('yaml')}>
+      {hostName ? (
+        <ENCPreview hostName={hostName} />
+      ) : (
+        <EmptyPage header="ENC Preview" />
+      )}
+    </Route>
+    <Redirect to={route('reports')} />
+  </Switch>
+);
+
+SecondaryTabRoutes.propTypes = {
+  hostName: PropTypes.string,
+  hostInfo: PropTypes.object,
+  status: PropTypes.string,
+};
+
+SecondaryTabRoutes.defaultProps = {
+  hostName: '',
+  hostInfo: {},
+  status: undefined,
+};
+
+export default SecondaryTabRoutes;

data/webpack/src/Extends/Host/PuppetTab/SubTabs/ENCPreview/ENCTab.js

@@ -0,0 +1,61 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+import {
+  CodeBlock,
+  CodeBlockAction,
+  CodeBlockCode,
+  ClipboardCopyButton,
+} from '@patternfly/react-core';
+
+export const ENCTab = ({ encData }) => {
+  const [copied, setCopied] = React.useState(false);
+
+  const code = `${encData}`;
+
+  const clipboardCopyFunc = (event, text) => {
+    const clipboard = event.currentTarget.parentElement;
+    const el = document.createElement('textarea');
+    el.value = text.toString();
+    clipboard.appendChild(el);
+    el.select();
+    document.execCommand('copy');
+    clipboard.removeChild(el);
+  };
+
+  const onClick = (event, text) => {
+    clipboardCopyFunc(event, text);
+    setCopied(true);
+  };
+
+  const actions = (
+    <CodeBlockAction>
+      <ClipboardCopyButton
+        id="copy-button"
+        textId="code-content"
+        aria-label="Copy to clipboard"
+        onClick={e => onClick(e, code)}
+        exitDelay={600}
+        maxWidth="110px"
+        variant="plain"
+      >
+        {copied ? 'Successfully copied to clipboard!' : 'Copy to clipboard'}
+      </ClipboardCopyButton>
+    </CodeBlockAction>
+  );
+
+  return (
+    <CodeBlock actions={actions}>
+      <CodeBlockCode id="code-content">{code}</CodeBlockCode>
+    </CodeBlock>
+  );
+};
+
+ENCTab.propTypes = {
+  encData: PropTypes.oneOfType([PropTypes.string, PropTypes.object]),
+};
+
+ENCTab.defaultProps = {
+  encData: undefined,
+};
+
+export default ENCTab;

data/webpack/src/Extends/Host/PuppetTab/SubTabs/ENCPreview/index.js

@@ -0,0 +1,53 @@
+import React from 'react';
+import { useAPI } from 'foremanReact/common/hooks/API/APIHooks';
+import PropTypes from 'prop-types';
+
+import Skeleton from 'react-loading-skeleton';
+import EmptyState from 'foremanReact/components/common/EmptyState/EmptyStatePattern';
+import { STATUS } from 'foremanReact/constants';
+import { EmptyStateIcon } from '@patternfly/react-core';
+import { ExclamationCircleIcon } from '@patternfly/react-icons';
+import { global_danger_color_200 as dangerColor } from '@patternfly/react-tokens';
+import { translate as __ } from 'foremanReact/common/I18n';
+import { ENCTab } from './ENCTab';
+
+const ENCPreview = ({ hostName }) => {
+  const options = {
+    params: { name: hostName, format: 'yml' },
+    key: 'PUPPET_ENC_PREVIEW',
+  };
+  const url = `${window.location.origin.toString()}/foreman_puppet/hosts/${hostName}/externalNodes`;
+  const { response, status } = useAPI('get', url, options);
+
+  if (status === STATUS.PENDING) {
+    return <Skeleton count={5} />;
+  }
+
+  if (status === STATUS.ERROR) {
+    const icon = (
+      <EmptyStateIcon icon={ExclamationCircleIcon} color={dangerColor.value} />
+    );
+    return (
+      <EmptyState
+        header={__('Error!')}
+        icon={icon}
+        description={response?.response?.data?.message}
+      />
+    );
+  }
+  if (response !== '' || response !== undefined) {
+    return (
+      <div className="yaml-tab" padding="16px 24px">
+        <ENCTab encData={response} />
+      </div>
+    );
+  }
+
+  return null;
+};
+
+ENCPreview.propTypes = {
+  hostName: PropTypes.string.isRequired,
+};
+
+export default ENCPreview;

data/webpack/src/Extends/Host/PuppetTab/SubTabs/EmptyPage.js

@@ -0,0 +1,19 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+import PFEmptyPage from 'foremanReact/components/common/EmptyState/EmptyStatePattern';
+
+const EmptyPage = ({ header }) => (
+  <div className="host-details-tab-item">
+    <PFEmptyPage
+      icon="enterprise"
+      header={header}
+      description="This is a demo for adding content to the new host page"
+    />
+  </div>
+);
+
+EmptyPage.propTypes = {
+  header: PropTypes.string.isRequired,
+};
+
+export default EmptyPage;

data/webpack/src/Extends/Host/PuppetTab/SubTabs/Reports/components/DescriptionCard.js

@@ -0,0 +1,71 @@
+import PropTypes from 'prop-types';
+import React from 'react';
+import CardTemplate from 'foremanReact/components/HostDetails/Templates/CardItem/CardTemplate';
+import {
+  DescriptionList,
+  DescriptionListTerm,
+  DescriptionListGroup,
+  DescriptionListDescription,
+} from '@patternfly/react-core';
+import SkeletonLoader from 'foremanReact/components/common/SkeletonLoader';
+import DefaultLoaderEmptyState from 'foremanReact/components/HostDetails/DetailsCard/DefaultLoaderEmptyState';
+import { STATUS } from 'foremanReact/constants';
+import { translate as __ } from 'foremanReact/common/I18n';
+
+const DescriptionCard = ({ proxyName, caProxy, env, status }) => (
+  <CardTemplate header={__('Puppet details')} expandable>
+    <DescriptionList isCompact>
+      <DescriptionListGroup>
+        <DescriptionListTerm>{__('Puppet environment')}</DescriptionListTerm>
+        <DescriptionListDescription>
+          <SkeletonLoader
+            emptyState={<DefaultLoaderEmptyState />}
+            status={status}
+          >
+            {env && (
+              <a href={`/foreman_puppet/environments/${env}/edit`}>{env}</a>
+            )}
+          </SkeletonLoader>
+        </DescriptionListDescription>
+      </DescriptionListGroup>
+      <DescriptionListGroup>
+        <DescriptionListTerm>{__('Puppet smart proxy')}</DescriptionListTerm>
+        <DescriptionListDescription>
+          <SkeletonLoader
+            emptyState={<DefaultLoaderEmptyState />}
+            status={status}
+          >
+            {proxyName}
+          </SkeletonLoader>
+        </DescriptionListDescription>
+      </DescriptionListGroup>
+      <DescriptionListGroup>
+        <DescriptionListTerm>{__('Puppet server CA')}</DescriptionListTerm>
+        <DescriptionListDescription>
+          <SkeletonLoader
+            emptyState={<DefaultLoaderEmptyState />}
+            status={status}
+          >
+            {caProxy}
+          </SkeletonLoader>
+        </DescriptionListDescription>
+      </DescriptionListGroup>
+    </DescriptionList>
+  </CardTemplate>
+);
+
+DescriptionCard.propTypes = {
+  caProxy: PropTypes.string,
+  env: PropTypes.string,
+  proxyName: PropTypes.string,
+  status: PropTypes.string,
+};
+
+DescriptionCard.defaultProps = {
+  caProxy: undefined,
+  env: undefined,
+  proxyName: undefined,
+  status: STATUS.PENDING,
+};
+
+export default DescriptionCard;

data/webpack/src/Extends/Host/PuppetTab/SubTabs/Reports/index.js

@@ -0,0 +1,45 @@
+import PropTypes from 'prop-types';
+import React from 'react';
+import { Grid, GridItem } from '@patternfly/react-core';
+import ReportsTab from 'foremanReact/components/HostDetails/Tabs/ReportsTab';
+import DescriptionCard from './components/DescriptionCard';
+import './styles.scss';
+
+const Reports = ({
+  hostName,
+  status,
+  hostInfo: {
+    puppet_proxy_name: proxyName,
+    puppet_ca_proxy_name: caProxy,
+    environment_name: env,
+  },
+}) => (
+  <div className="report-tab">
+    <Grid hasGutter>
+      <GridItem span={4}>
+        <DescriptionCard
+          proxyName={proxyName}
+          caProxy={caProxy}
+          env={env}
+          status={status}
+        />
+      </GridItem>
+      <GridItem span={12}>
+        <ReportsTab hostName={hostName} origin="Puppet" />
+      </GridItem>
+    </Grid>
+  </div>
+);
+
+Reports.propTypes = {
+  hostName: PropTypes.string.isRequired,
+  hostInfo: PropTypes.object,
+  status: PropTypes.string,
+};
+
+Reports.defaultProps = {
+  hostInfo: {},
+  status: undefined,
+};
+
+export default Reports;

data/webpack/src/Extends/Host/PuppetTab/SubTabs/Reports/styles.scss

@@ -0,0 +1,7 @@
+.report-tab {
+  padding: 16px 24px;
+
+  .pf-c-card {
+    height: 100%;
+  }
+}

data/webpack/src/Extends/Host/PuppetTab/constants.js

@@ -0,0 +1,8 @@
+import { translate as __ } from 'foremanReact/common/I18n';
+
+export const SECONDARY_TABS = [
+  { key: 'reports', title: __('Reports') },
+  { key: 'assigned', title: __('Assigned classes') },
+  { key: 'smart-classes', title: __('Smart class parameters') },
+  { key: 'yaml', title: __('ENC Preview') },
+];

data/webpack/src/Extends/Host/PuppetTab/helpers.js

@@ -0,0 +1,3 @@
+export const hashRoute = subpath => `#/Puppet/${subpath}`;
+export const route = subpath => hashRoute(subpath).substring(1);
+export const activeTab = path => path.split('/')[2];

data/webpack/src/Extends/Host/PuppetTab/index.js

@@ -0,0 +1,51 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+import { useHistory } from 'react-router-dom';
+import { Tabs, Tab, TabTitleText } from '@patternfly/react-core';
+import { STATUS } from 'foremanReact/constants';
+
+import SecondaryTabRoutes from './Routes';
+import { activeTab } from './helpers';
+import { SECONDARY_TABS } from './constants';
+
+const PuppetTab = ({ response, status, location: { pathname } }) => {
+  const hashHistory = useHistory();
+  return (
+    <>
+      <Tabs
+        className="margin-0-24"
+        onSelect={(evt, subTab) => hashHistory.push(subTab)}
+        isSecondary
+        activeKey={activeTab(pathname)}
+      >
+        {SECONDARY_TABS.map(({ key, title }) => (
+          <Tab
+            key={key}
+            eventKey={key}
+            title={<TabTitleText>{title}</TabTitleText>}
+          />
+        ))}
+      </Tabs>
+      <SecondaryTabRoutes
+        hostName={response.name}
+        hostInfo={response}
+        status={status}
+      />
+    </>
+  );
+};
+
+PuppetTab.propTypes = {
+  response: PropTypes.object,
+  status: PropTypes.string,
+  location: PropTypes.shape({
+    pathname: PropTypes.string,
+  }),
+};
+PuppetTab.defaultProps = {
+  location: { pathname: '' },
+  response: { name: '' },
+  status: STATUS.PENDING,
+};
+
+export default PuppetTab;