foreman_puppet 11.0.0 → 11.2.0

data/locale/zh_TW/foreman_puppet.po

@@ -10,7 +10,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_puppet 9.0.0\n"
+"Project-Id-Version: foreman_puppet 11.1.0\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2021-02-03 16:30+0000\n"
 "Last-Translator: 0868a4d1af5275b3f70b0a6dac4c99a4, 2023\n"
@@ -55,6 +55,12 @@ msgid ""
 "        <b>Inherited value:</b> %{inherited_value}"
 msgstr ""
 
+msgid "A Puppet environment with id %{id} could not be found."
+msgstr ""
+
+msgid "A Smart Proxy with id %{id} and the %{proxy_type} feature could not be found."
+msgstr ""
+
 msgid "A config group provides a one-step method of associating many Puppet classes to either a host or host group. Typically this would be used to add a particular application profile or stack in one step."
 msgstr ""
 
@@ -79,6 +85,9 @@ msgstr "新增範本組合"
 msgid "Add:"
 msgstr "新增："
 
+msgid "All"
+msgstr ""
+
 msgid "All environments - (not filtered)"
 msgstr "所有環境 -（未篩選）"
 
@@ -106,15 +115,54 @@ msgstr "取消"
 msgid "Change Environment"
 msgstr "更改環境"
 
+msgid "Change Puppet (CA) Proxy"
+msgstr ""
+
+msgid "Change Puppet CA Proxy"
+msgstr ""
+
+msgid "Change Puppet CA proxy"
+msgstr ""
+
+msgid "Change Puppet Environment"
+msgstr ""
+
 msgid "Change Puppet Master"
 msgstr "改變 Puppet Master"
 
+msgid "Change Puppet Proxy"
+msgstr ""
+
+msgid "Change Puppet environment"
+msgstr ""
+
+msgid "Change Puppet proxy"
+msgstr ""
+
 msgid "Changed"
 msgstr ""
 
 msgid "Changed environments"
 msgstr "已更改的環境"
 
+msgid "Changing the Puppet CA proxy will affect {boldCount} selected hosts. Some hosts may already have been associated with the selected Puppet CA proxy."
+msgstr ""
+
+msgid "Changing the Puppet CA proxy will affect {boldCount} selected {count, plural, one {host} other {hosts}}. Some hosts may already have been associated with the selected Puppet CA proxy."
+msgstr ""
+
+msgid "Changing the Puppet environment will affect {boldCount} selected hosts. Some hosts may already have been associated with the selected environment."
+msgstr ""
+
+msgid "Changing the Puppet environment will affect {boldCount} selected {count, plural, one {host} other {hosts}}. Some hosts may already have been associated with the selected environment."
+msgstr ""
+
+msgid "Changing the Puppet proxy will affect {boldCount} selected hosts. Some hosts may already have been associated with the selected Puppet proxy."
+msgstr ""
+
+msgid "Changing the Puppet proxy will affect {boldCount} selected {count, plural, one {host} other {hosts}}. Some hosts may already have been associated with the selected Puppet proxy."
+msgstr ""
+
 msgid "Check/Uncheck all"
 msgstr "選取/反選全部"
 
@@ -271,12 +319,51 @@ msgstr "詳情"
 msgid "Failed"
 msgstr ""
 
+msgid "Failed to change %{proxy_type} for %{count} host"
+msgid_plural "Failed to change %{proxy_type} for %{count} hosts"
+msgstr[0] ""
+msgstr[1] ""
+
+msgid "Failed to change Puppet CA Proxy"
+msgstr ""
+
+msgid "Failed to change Puppet Environment"
+msgstr ""
+
+msgid "Failed to change Puppet Proxy"
+msgstr ""
+
+msgid "Failed to change environment for %{count} host"
+msgid_plural "Failed to change environment for %{count} hosts"
+msgstr[0] ""
+msgstr[1] ""
+
 msgid "Failed to import %{klass} for %{name}: doesn't exists in our database - ignoring"
 msgstr "為 %{name} 匯入 %{klass} 失敗：不存在我們的資料庫中 - 將被忽略"
 
+msgid "Failed to remove %{proxy_type} for %{count} host"
+msgid_plural "Failed to remove %{proxy_type} for %{count} hosts"
+msgstr[0] ""
+msgstr[1] ""
+
+msgid "Failed to remove Puppet CA Proxy"
+msgstr ""
+
+msgid "Failed to remove Puppet Environment"
+msgstr ""
+
+msgid "Failed to remove Puppet Proxy"
+msgstr ""
+
 msgid "Failed to set %{proxy_type} proxy for %{host}."
 msgstr "設定 %{proxy_type} 代理給 %{host} 時失敗。"
 
+msgid "Failed to set Puppet environment for %{host}."
+msgstr ""
+
+msgid "Failed to set proxy for %{host}."
+msgstr ""
+
 msgid "Failed to start"
 msgstr ""
 
@@ -358,6 +445,15 @@ msgstr "主機群組的 ID"
 msgid "ID of puppet environment"
 msgstr ""
 
+msgid "ID of the Puppet environment to set for the selected hosts"
+msgstr ""
+
+msgid "ID of the Puppet proxy to reassign the hosts to"
+msgstr ""
+
+msgid "ID of the organization"
+msgstr ""
+
 msgid "IDs of associated ConfigGroups"
 msgstr ""
 
@@ -460,6 +556,12 @@ msgstr "列出各個環境中的主機"
 msgid "List of config groups"
 msgstr "配置群組清單"
 
+msgid "List of host ids to exclude and not run an action on"
+msgstr ""
+
+msgid "List of host ids to perform an action on"
+msgstr ""
+
 msgid "List of override values for a specific smart class parameter"
 msgstr "特定智慧型類別參數的置換值之清單"
 
@@ -607,6 +709,9 @@ msgstr "Puppet CA"
 msgid "Puppet CA Smart Proxy"
 msgstr ""
 
+msgid "Puppet CA proxy"
+msgstr ""
+
 msgid "Puppet Class"
 msgstr "Puppet 類別"
 
@@ -661,6 +766,9 @@ msgstr ""
 msgid "Puppet parameter"
 msgstr "Puppet 參數"
 
+msgid "Puppet proxy"
+msgstr ""
+
 msgid "Puppetclass|Name"
 msgstr "名稱"
 
@@ -670,6 +778,27 @@ msgstr "移除"
 msgid "Remove Combination"
 msgstr ""
 
+msgid "Remove Puppet (CA) Proxy"
+msgstr ""
+
+msgid "Remove Puppet CA Proxy"
+msgstr ""
+
+msgid "Remove Puppet CA proxy"
+msgstr ""
+
+msgid "Remove Puppet Environment"
+msgstr ""
+
+msgid "Remove Puppet Proxy"
+msgstr ""
+
+msgid "Remove Puppet environment"
+msgstr ""
+
+msgid "Remove Puppet proxy"
+msgstr ""
+
 msgid "Remove a Puppet class from host"
 msgstr "從主機移除一個 Puppet 類別"
 
@@ -685,6 +814,24 @@ msgstr "移除此置換"
 msgid "Remove:"
 msgstr "移除："
 
+msgid "Removing the Puppet CA proxy will affect {boldCount} selected hosts. Warning: If a Puppet Proxy is still set, the Puppet CA Proxy will fall back to that value after removal!"
+msgstr ""
+
+msgid "Removing the Puppet CA proxy will affect {boldCount} selected {count, plural, one {host} other {hosts}}. Warning: If a Puppet Proxy is still set, the Puppet CA Proxy will fall back to that value after removal!"
+msgstr ""
+
+msgid "Removing the Puppet environment will affect {boldCount} selected hosts."
+msgstr ""
+
+msgid "Removing the Puppet environment will affect {boldCount} selected {count, plural, one {host} other {hosts}}."
+msgstr ""
+
+msgid "Removing the Puppet proxy will affect {boldCount} selected hosts."
+msgstr ""
+
+msgid "Removing the Puppet proxy will affect {boldCount} selected {count, plural, one {host} other {hosts}}."
+msgstr ""
+
 msgid "Reports"
 msgstr "報告"
 
@@ -697,12 +844,27 @@ msgstr ""
 msgid "Scheduled"
 msgstr ""
 
+msgid "Search string for hosts to perform an action on"
+msgstr ""
+
+msgid "Select a Puppet CA Proxy"
+msgstr ""
+
+msgid "Select a Puppet Proxy"
+msgstr ""
+
+msgid "Select an Environment"
+msgstr ""
+
 msgid "Select environment"
 msgstr "選擇環境"
 
 msgid "Select the changes you want to apply to Foreman"
 msgstr ""
 
+msgid "Selected Puppet environment is not assigned to the proper organization and/or location for all hosts."
+msgstr ""
+
 msgid "Set parameters to defaults"
 msgstr "將參數設為預設值"
 
@@ -789,6 +951,9 @@ msgstr ""
 msgid "There are no puppet environments set up on this puppet master. Please check the puppet master configuration."
 msgstr "此 puppet master 上並未設定 puppet 環境。請檢查 puppet master 的配置。"
 
+msgid "There is no Smart Proxy with the feature '%s' available."
+msgstr ""
+
 msgid "This Puppet class has no parameters in its signature."
 msgstr "此 puppet 類別的簽章中沒有參數。"
 
@@ -810,6 +975,12 @@ msgstr "切換"
 msgid "Total"
 msgstr "總數"
 
+msgid "True, if Puppet CA proxy should be changed instead of the Puppet proxy"
+msgstr ""
+
+msgid "True, if Puppet CA proxy should be removed instead of the Puppet proxy"
+msgstr ""
+
 msgid "Types of validation values"
 msgstr "驗證值的類型"
 
@@ -849,6 +1020,21 @@ msgstr "更新："
 msgid "Updated"
 msgstr "已更新"
 
+msgid "Updated host: changed %{proxy_type}"
+msgid_plural "Updated hosts: changed %{proxy_type}"
+msgstr[0] ""
+msgstr[1] ""
+
+msgid "Updated host: changed environment"
+msgid_plural "Updated hosts: changed environment"
+msgstr[0] ""
+msgstr[1] ""
+
+msgid "Updated host: removed %{proxy_type}"
+msgid_plural "Updated hosts: removed %{proxy_type}"
+msgstr[0] ""
+msgstr[1] ""
+
 msgid "Updated hosts: changed environment"
 msgstr "已更新主機：已更改的環境"
 

data/test/controllers/foreman_puppet/api/v2/hosts_bulk_actions_controller_test.rb

@@ -16,8 +16,101 @@ module ForemanPuppet
             organization: host.organization,
             location: host.location)
         end
+        let(:environment) { FactoryBot.create(:environment, organizations: [host.organization], locations: [host.location]) }
+        let(:hostgroup_environment) { FactoryBot.create(:environment, organizations: [host.organization], locations: [host.location]) }
+        let(:hostgroup) do
+          FactoryBot.create(:hostgroup, :with_puppet_enc,
+            environment: hostgroup_environment,
+            organizations: [host.organization],
+            locations: [host.location])
+        end
         let(:proxy) { FactoryBot.create(:puppet_and_ca_smart_proxy, organizations: [host.organization], locations: [host.location]) }
 
+        def put_change_puppet_environment(params:, session: nil)
+          put :change_puppet_environment, params: params, session: session
+        end
+
+        test 'changes puppet environment for selected hosts' do
+          put_change_puppet_environment(params: bulk_params.merge(environment_id: environment.id))
+
+          assert_response :success
+          assert_equal environment.id, host2.reload.puppet.environment_id
+          assert_equal environment.id, host.reload.puppet.environment_id
+        end
+
+        test 'inherits puppet environment from hostgroups for selected hosts' do
+          host.update!(hostgroup: hostgroup)
+          host2.update!(hostgroup: hostgroup)
+
+          put_change_puppet_environment(params: bulk_params.merge(environment_id: 'inherit'))
+
+          assert_response :success
+          assert_equal hostgroup_environment.id, host2.reload.puppet.environment_id
+          assert_equal hostgroup_environment.id, host.reload.puppet.environment_id
+        end
+
+        test 'clears puppet environment for selected hosts' do
+          host.puppet.update!(environment: environment)
+          host2.puppet.update!(environment: environment)
+
+          put_change_puppet_environment(
+            params: bulk_params.merge(environment_id: nil),
+            session: set_session_user
+          )
+
+          assert_response :success
+          assert_nil host.reload.puppet.environment
+          assert_nil host2.reload.puppet.environment
+        end
+
+        test 'returns error when puppet environment is missing' do
+          missing_environment_id = 999_999
+
+          put_change_puppet_environment(
+            params: bulk_params.merge(environment_id: missing_environment_id),
+            session: set_session_user
+          )
+
+          assert_response :unprocessable_entity
+          response = JSON.parse(@response.body)
+          assert_equal "A Puppet environment with id #{missing_environment_id} could not be found.",
+            response.dig('error', 'message')
+        end
+
+        test 'returns error when changing puppet environment fails for some hosts' do
+          ::BulkHostsManager.any_instance.expects(:change_puppet_environment)
+                            .with(environment)
+                            .returns([host2.id])
+
+          put_change_puppet_environment(
+            params: bulk_params.merge(environment_id: environment.id),
+            session: set_session_user
+          )
+
+          assert_response :unprocessable_entity
+          response = JSON.parse(@response.body)
+          assert_equal 'Failed to change environment for 1 host',
+            response.dig('error', 'message')
+          assert_equal [host2.id], response.dig('error', 'failed_host_ids')
+        end
+
+        test 'returns error when puppet environment is outside host taxonomies' do
+          invalid_environment = FactoryBot.create(:environment,
+            organizations: [host.organization],
+            locations: [FactoryBot.create(:location)])
+
+          put_change_puppet_environment(
+            params: bulk_params.merge(environment_id: invalid_environment.id),
+            session: set_session_user
+          )
+
+          assert_response :unprocessable_entity
+          response = JSON.parse(@response.body)
+          assert_equal 'Selected Puppet environment is not assigned to the proper organization and/or location for all hosts.',
+            response.dig('error', 'message')
+          assert_equal [host.id, host2.id].sort, response.dig('error', 'failed_host_ids').sort
+        end
+
         test 'changes puppet proxy for selected hosts' do
           put :change_puppet_proxy,
             params: bulk_params.merge(proxy_id: proxy.id, ca_proxy: false)

data/test/models/foreman_puppet/host_test.rb

@@ -176,6 +176,56 @@ module ForemanPuppet
         assert_not_includes completions, %(config_group =  "#{config_group.name}")
       end
 
+      test 'limits Puppet assignment completions to the current organization' do
+        organization = taxonomies(:organization1)
+        location = taxonomies(:location1)
+        hidden_organization = FactoryBot.create(:organization)
+        visible_environment = FactoryBot.create(
+          :environment,
+          organizations: [organization],
+          locations: [location]
+        )
+        hidden_environment = FactoryBot.create(
+          :environment,
+          organizations: [hidden_organization],
+          locations: [location]
+        )
+        visible_host = FactoryBot.create(
+          :host,
+          :with_puppet_enc,
+          :with_puppetclass,
+          environment: visible_environment,
+          organization: organization,
+          location: location
+        )
+        hidden_host = FactoryBot.create(
+          :host,
+          :with_puppet_enc,
+          :with_puppetclass,
+          environment: hidden_environment,
+          organization: hidden_organization,
+          location: location
+        )
+        visible_config_group = FactoryBot.create(:config_group)
+        hidden_config_group = FactoryBot.create(:config_group)
+        visible_host.puppet.config_groups << visible_config_group
+        hidden_host.puppet.config_groups << hidden_config_group
+        Organization.current = organization
+        Location.current = nil
+
+        visible_puppetclass = visible_host.puppet.puppetclasses.first
+        hidden_puppetclass = hidden_host.puppet.puppetclasses.first
+        visible_puppetclasses = ::Host::Managed.complete_for("puppetclass = #{visible_puppetclass.name}")
+        hidden_puppetclasses = ::Host::Managed.complete_for("puppetclass = #{hidden_puppetclass.name}")
+        visible_config_groups = ::Host::Managed.complete_for("config_group = #{visible_config_group.name}")
+        hidden_config_groups = ::Host::Managed.complete_for("config_group = #{hidden_config_group.name}")
+
+        assert_includes visible_puppetclasses, %(puppetclass =  "#{visible_puppetclass.name}")
+        assert_not_includes hidden_puppetclasses, %(puppetclass =  "#{hidden_puppetclass.name}")
+        assert_includes visible_config_groups, %(config_group =  "#{visible_config_group.name}")
+        assert_not_includes hidden_config_groups, %(config_group =  "#{hidden_config_group.name}")
+      end
+
       test 'preserves core host value completions' do
         completions = as_admin { ::Host::Managed.complete_for('user.login =') }
 

data/test/models/foreman_puppet/hostgroup_test.rb

@@ -47,6 +47,56 @@ module ForemanPuppet
       assert_includes completions, %(puppetclass =  "#{puppetclass.name}")
     end
 
+    test 'limits Puppet assignment completions to the current location' do
+      organization = taxonomies(:organization1)
+      location = taxonomies(:location1)
+      hidden_location = FactoryBot.create(:location)
+      visible_environment = FactoryBot.create(
+        :environment,
+        organizations: [organization],
+        locations: [location]
+      )
+      hidden_environment = FactoryBot.create(
+        :environment,
+        organizations: [organization],
+        locations: [hidden_location]
+      )
+      visible_hostgroup = FactoryBot.create(
+        :hostgroup,
+        :with_puppet_enc,
+        :with_puppetclass,
+        :with_config_group,
+        environment: visible_environment,
+        organizations: [organization],
+        locations: [location]
+      )
+      hidden_hostgroup = FactoryBot.create(
+        :hostgroup,
+        :with_puppet_enc,
+        :with_puppetclass,
+        :with_config_group,
+        environment: hidden_environment,
+        organizations: [organization],
+        locations: [hidden_location]
+      )
+      visible_config_group = visible_hostgroup.puppet.config_groups.first
+      hidden_config_group = hidden_hostgroup.puppet.config_groups.first
+      Organization.current = nil
+      Location.current = location
+
+      visible_puppetclass = visible_hostgroup.puppet.puppetclasses.first
+      hidden_puppetclass = hidden_hostgroup.puppet.puppetclasses.first
+      visible_puppetclasses = ::Hostgroup.complete_for("puppetclass = #{visible_puppetclass.name}")
+      hidden_puppetclasses = ::Hostgroup.complete_for("puppetclass = #{hidden_puppetclass.name}")
+      visible_config_groups = ::Hostgroup.complete_for("config_group = #{visible_config_group.name}")
+      hidden_config_groups = ::Hostgroup.complete_for("config_group = #{hidden_config_group.name}")
+
+      assert_includes visible_puppetclasses, %(puppetclass =  "#{visible_puppetclass.name}")
+      assert_not_includes hidden_puppetclasses, %(puppetclass =  "#{hidden_puppetclass.name}")
+      assert_includes visible_config_groups, %(config_group =  "#{visible_config_group.name}")
+      assert_not_includes hidden_config_groups, %(config_group =  "#{hidden_config_group.name}")
+    end
+
     test 'searches Puppet class values assigned through a config group' do
       config_group = hostgroup.puppet.config_groups.first
       puppetclass = FactoryBot.create(:puppetclass)

data/test/services/foreman_puppet/bulk_hosts_manager_test.rb

@@ -4,6 +4,51 @@ class BulkHostsManagerTest < ActiveSupport::TestCase
   let(:hosts) { FactoryBot.create_list(:host, 2, :with_puppet_enc) }
   let(:manager) { ::BulkHostsManager.new(hosts: hosts) }
   let(:proxy) { FactoryBot.create(:puppet_smart_proxy) }
+  let(:environment) { FactoryBot.create(:environment, organizations: [hosts.first.organization], locations: [hosts.first.location]) }
+
+  test 'changes puppet environment for hosts' do
+    manager.change_puppet_environment(environment)
+
+    hosts.each do |host|
+      assert_equal environment.id, host.reload.puppet.environment_id
+    end
+  end
+
+  test 'inherits puppet environment from hostgroup' do
+    organization = FactoryBot.create(:organization)
+    location = FactoryBot.create(:location)
+    inherited_environment = FactoryBot.create(:environment, organizations: [organization], locations: [location])
+    initial_environment = FactoryBot.create(:environment, organizations: [organization], locations: [location])
+    hostgroup = FactoryBot.create(:hostgroup, :with_puppet_enc,
+      environment: inherited_environment,
+      organizations: [organization],
+      locations: [location])
+    inherited_hosts = FactoryBot.create_list(:host, 2, :with_puppet_enc,
+      environment: initial_environment,
+      hostgroup: hostgroup,
+      organization: organization,
+      location: location)
+
+    inherited_hosts.each do |host|
+      assert_not_equal inherited_environment.id, host.reload.puppet.environment_id
+    end
+
+    ::BulkHostsManager.new(hosts: inherited_hosts).change_puppet_environment('inherit')
+
+    inherited_hosts.each do |host|
+      assert_equal inherited_environment.id, host.reload.puppet.environment_id
+    end
+  end
+
+  test 'clears puppet environment when environment is nil' do
+    hosts.each { |host| host.puppet.update!(environment: environment) }
+
+    manager.change_puppet_environment(nil)
+
+    hosts.each do |host|
+      assert_nil host.reload.puppet.environment
+    end
+  end
 
   test 'changes puppet proxy for hosts' do
     manager.change_puppet_proxy(proxy, false)

data/webpack/__mocks__/foremanReact/redux/API/index.js

@@ -6,5 +6,13 @@ export const API = {
   patch: jest.fn(),
 };
 
+export const APIActions = {
+  get: jest.fn(),
+  post: jest.fn(),
+  put: jest.fn(),
+  patch: jest.fn(),
+  delete: jest.fn(),
+};
+
 export const get = data => ({ type: 'get-some-type', ...data });
 export const post = data => ({ type: 'post-some-type', ...data });

data/webpack/global_index.js

@@ -7,12 +7,15 @@ import reducers from './src/reducers';
 import { registerFills } from './src/Extends/Fills';
 import { registerLegacy } from './legacy';
 import HostsIndexActionsBar from './src/Extends/Hosts/ActionsBar';
+import BulkChangePuppetEnvironment from './src/Extends/Hosts/BulkActions/BulkChangePuppetEnvironment';
+import BulkRemovePuppetEnvironment from './src/Extends/Hosts/BulkActions/BulkRemovePuppetEnvironment';
 import BulkChangePuppetProxy from './src/Extends/Hosts/BulkActions/BulkChangePuppetProxy';
 import BulkChangePuppetCAProxy from './src/Extends/Hosts/BulkActions/BulkChangePuppetCAProxy';
 import BulkRemovePuppetProxy from './src/Extends/Hosts/BulkActions/BulkRemovePuppetProxy';
 import BulkRemovePuppetCAProxy from './src/Extends/Hosts/BulkActions/BulkRemovePuppetCAProxy';
 
 const GLOBAL_FILL_PRIORITY = 100;
+const PUPPET_ENV_COLUMN_WEIGHT = 2700;
 
 // register reducers
 registerReducer('puppet', reducers);
@@ -28,7 +31,7 @@ const puppetHostsIndexColumns = [
     title: __('Puppet env'),
     isSorted: true,
     wrapper: hostDetails => hostDetails.environment_name,
-    weight: 2700,
+    weight: PUPPET_ENV_COLUMN_WEIGHT,
   },
 ];
 
@@ -45,6 +48,20 @@ addGlobalFill(
   GLOBAL_FILL_PRIORITY
 );
 
+addGlobalFill(
+  '_all-hosts-modals',
+  'BulkChangePuppetEnvironment',
+  <BulkChangePuppetEnvironment key="bulk-change-puppet-environment" />,
+  GLOBAL_FILL_PRIORITY
+);
+
+addGlobalFill(
+  '_all-hosts-modals',
+  'BulkRemovePuppetEnvironment',
+  <BulkRemovePuppetEnvironment key="bulk-remove-puppet-environment" />,
+  GLOBAL_FILL_PRIORITY
+);
+
 addGlobalFill(
   '_all-hosts-modals',
   'BulkChangePuppetProxy',

data/webpack/src/Extends/Hosts/ActionsBar/index.js

@@ -24,6 +24,26 @@ const HostActionsBar = () => {
         <Menu ouiaId="content-flyout-menu" onSelect={() => setMenuOpen(false)}>
           <MenuContent>
             <MenuList>
+              <MenuItem
+                itemId="bulk-change-puppet-environment-menu-item"
+                key="bulk-change-puppet-environment-menu-item"
+                onClick={() =>
+                  handleOpenBulkModal('bulk-change-puppet-environment')
+                }
+                isDisabled={selectedCount === 0}
+              >
+                {__('Change Puppet environment')}
+              </MenuItem>
+              <MenuItem
+                itemId="bulk-remove-puppet-environment-menu-item"
+                key="bulk-remove-puppet-environment-menu-item"
+                onClick={() =>
+                  handleOpenBulkModal('bulk-remove-puppet-environment')
+                }
+                isDisabled={selectedCount === 0}
+              >
+                {__('Remove Puppet environment')}
+              </MenuItem>
               <MenuItem
                 itemId="bulk-change-puppet-proxy-menu-item"
                 key="bulk-change-puppet-proxy-menu-item"

data/webpack/src/Extends/Hosts/BulkActions/BulkChangeProxyCommon/__tests__/actions.test.js

@@ -9,13 +9,6 @@ import {
   BULK_CHANGE_PUPPET_PROXY_KEY,
 } from '../actions';
 
-jest.mock('foremanReact/redux/API', () => ({
-  APIActions: {
-    get: jest.fn(),
-    put: jest.fn(),
-  },
-}));
-
 describe('BulkChangeProxyCommon actions', () => {
   const smartProxiesUrl = foremanUrl('/api/smart_proxies');
   const bulkChangeUrl = foremanUrl('/api/v2/hosts/bulk/change_puppet_proxy');