foreman_puppet 10.1.3 → 11.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cee4c4bc88e7e50cc6215f4d63bce66361304d94687507338c89333f3bd81e39
-  data.tar.gz: db7d58c859b13521f37097955a30da8f23d8437934f1a307907a6ab6c73c6f6c
+  metadata.gz: 5aa351556f85774a9796437e9ee6fd0671f46db4bb3519aa6a94c1691c90d6ca
+  data.tar.gz: a9507d1ae1d1961d4256eba509e88e72f5ee1124d2d2532751f6f3ff7b2e2ac2
 SHA512:
-  metadata.gz: 5ffcc0c52303eb7b4e402351d56536449396888f98038756acf318ec38b0dd9616d003747d6edc987ebd08a7b68f8c46328052a468eea0e5cd8dc31c617dc1af
-  data.tar.gz: '048e3527e272f20bba27026fd9d65cdfc00686cf8a4bdc6ad078f5e3fee6e874ee3eef042a9694369a282d5a7a201b324fb99d2d8b4c50069345dbd220fe620a'
+  metadata.gz: 31593435b997b9202741f97a709aa40bbd57ed82f6c09aeadbe8e83432d0273b0f2523aebe0a13cf03f3e534592418091f21da8eb768cad3dfc7f0a68c1c3277
+  data.tar.gz: 4625c5cfbefe7af792e45ffad193ca1f0867aac29ac3596c003072aec34c366d3ade137244a861802ddab8d75c45651343c76901d871bfd0b145509ea4a67df1

data/app/controllers/concerns/foreman_puppet/extensions/hosts_controller_extensions.rb

@@ -126,7 +126,7 @@ module ForemanPuppet
 
       def get_environment_for(host, id)
         if id == 'inherit' && host.hostgroup.present?
-          host.hostgroup.environment
+          host.hostgroup.puppet&.environment
         else
           ForemanPuppet::Environment.find_by(id: id)
         end

data/app/controllers/foreman_puppet/api/v2/hosts_bulk_actions_controller.rb

@@ -3,7 +3,9 @@ module ForemanPuppet
     module V2
       class HostsBulkActionsController < ::ForemanPuppet::Api::V2::PuppetBaseController
         include ::Api::V2::BulkHostsExtension
-        before_action :find_editable_hosts, only: %i[change_puppet_proxy remove_puppet_proxy]
+        before_action :find_editable_hosts, only: %i[change_puppet_environment change_puppet_proxy remove_puppet_proxy]
+        before_action :find_environment, only: %i[change_puppet_environment]
+        before_action :validate_environment_taxonomies, only: %i[change_puppet_environment]
         before_action :find_smart_proxy, only: %i[change_puppet_proxy]
 
         def_param_group :bulk_params do
@@ -17,6 +19,27 @@ module ForemanPuppet
           end
         end
 
+        api :PUT, '/hosts/bulk/change_puppet_environment', N_('Change Puppet environment')
+        param_group :bulk_params
+        param :environment_id, String, required: false, desc: N_('ID of the Puppet environment to set for the selected hosts')
+        def change_puppet_environment
+          error_hosts = ::BulkHostsManager.new(hosts: @hosts).change_puppet_environment(resolved_environment)
+
+          process_bulk_response(
+            error_hosts,
+            success_message: format(n_(
+              'Updated host: changed environment',
+              'Updated hosts: changed environment',
+              @hosts.count
+            )),
+            error_message: format(n_(
+              'Failed to change environment for %{count} host',
+              'Failed to change environment for %{count} hosts',
+              error_hosts.count
+            ), count: error_hosts.count)
+          )
+        end
+
         api :PUT, '/hosts/bulk/change_puppet_proxy', N_('Change Puppet (CA) Proxy')
         param_group :bulk_params
         param :proxy_id, :number, required: true, desc: N_('ID of the Puppet proxy to reassign the hosts to')
@@ -65,6 +88,14 @@ module ForemanPuppet
         end
 
         def process_bulk_puppet_proxy_response(error_hosts, success_message:, error_message:)
+          process_bulk_response(
+            error_hosts,
+            success_message: success_message,
+            error_message: error_message
+          )
+        end
+
+        def process_bulk_response(error_hosts, success_message:, error_message:)
           if error_hosts.empty?
             process_response(true, { message: success_message })
           else
@@ -93,6 +124,49 @@ module ForemanPuppet
           Foreman::Cast.to_bool(params[:ca_proxy])
         end
 
+        def find_environment
+          return true if environment_value == 'inherit' || environment_value.blank?
+
+          @environment = ForemanPuppet::Environment.find_by(id: environment_value)
+          return true if @environment.present?
+
+          render json: {
+            error: {
+              message: format(_('A Puppet environment with id %{id} could not be found.'), id: environment_value),
+            },
+          }, status: :unprocessable_entity
+          false
+        end
+
+        def validate_environment_taxonomies
+          return true if resolved_environment.blank? || resolved_environment == 'inherit'
+
+          invalid_host_ids = @hosts.reject do |host|
+            ForemanPuppet::Environment.with_taxonomy_scope(host.organization, host.location)
+                                      .exists?(id: resolved_environment.id)
+          end.map(&:id)
+
+          return true if invalid_host_ids.empty?
+
+          render_error(:bulk_hosts_error, status: :unprocessable_entity,
+            locals: {
+              message: _('Selected Puppet environment is not assigned to the proper organization and/or location for all hosts.'),
+              failed_host_ids: invalid_host_ids,
+            })
+          false
+        end
+
+        def environment_value
+          params[:environment_id]
+        end
+
+        def resolved_environment
+          return 'inherit' if environment_value == 'inherit'
+          return nil if environment_value.blank?
+
+          @environment
+        end
+
         def proxy_type
           ca_proxy? ? _('Puppet CA proxy') : _('Puppet proxy')
         end

data/app/models/concerns/foreman_puppet/extensions/host.rb

@@ -13,9 +13,9 @@ module ForemanPuppet
         include_in_clone puppet: %i[config_groups host_config_groups host_classes]
 
         scoped_search relation: :environment, on: :name, complete_value: true, rename: :environment
-        scoped_search relation: :puppetclasses, on: :name, complete_value: true, rename: :puppetclass, only_explicit: true, operators: ['= ', '~ '],
+        scoped_search relation: :search_puppetclasses, on: :name, complete_value: true, rename: :puppetclass, only_explicit: true, operators: ['= ', '~ '],
           ext_method: :search_by_puppetclass
-        scoped_search relation: :config_groups, on: :name, complete_value: true, rename: :config_group, only_explicit: true, operators: ['= ', '~ '],
+        scoped_search relation: :search_config_groups, on: :name, complete_value: true, rename: :config_group, only_explicit: true, operators: ['= ', '~ '],
           ext_method: :search_by_config_group
       end
 

data/app/models/concerns/foreman_puppet/extensions/host_common.rb

@@ -3,6 +3,41 @@ module ForemanPuppet
     module HostCommon
       extend ActiveSupport::Concern
 
+      ASSIGNMENT_RELATIONS = %i[search_puppetclasses search_config_groups].freeze
+
+      included do
+        singleton_class.prepend CompletionMethods
+
+        has_many :search_puppetclasses, through: :puppet, source: :puppetclasses, class_name: '::ForemanPuppet::Puppetclass'
+        has_many :search_config_groups, through: :puppet, source: :config_groups, class_name: '::ForemanPuppet::ConfigGroup'
+      end
+
+      module CompletionMethods
+        def complete_for(query, options = {})
+          return super if query.nil?
+
+          completer = AssignmentCompleter.new(scoped_search_definition, query, options)
+          return super unless completer.assignment_field?
+
+          completer.build_autocomplete_options
+        end
+      end
+
+      class AssignmentCompleter < ScopedSearch::AutoCompleteBuilder
+        def assignment_field?
+          return false unless complete_options(last_node).include?(:value)
+
+          token = last_token_is(COMPARISON_OPERATORS) ? tokens[-2] : tokens[-3]
+          ASSIGNMENT_RELATIONS.include?(definition.field_by_name(token)&.relation)
+        end
+
+        def completer_scope(field)
+          return super unless ASSIGNMENT_RELATIONS.include?(field.relation)
+
+          field.klass.completer_scope(@options).reorder(Arel.sql(field.quoted_field))
+        end
+      end
+
       def all_puppetclasses(env = environment)
         return ForemanPuppet::Puppetclass.none unless puppet
         puppet.all_puppetclasses(env)

data/app/models/concerns/foreman_puppet/extensions/hostgroup.rb

@@ -16,13 +16,13 @@ module ForemanPuppet
 
         # will need through relation to work properly
         scoped_search relation: :environment, on: :name, complete_value: true, rename: :environment, only_explicit: true
-        scoped_search relation: :puppetclasses, on: :name,
+        scoped_search relation: :search_puppetclasses, on: :name,
           complete_value: true,
           rename: :puppetclass,
           only_explicit: true,
           operators: ['= ', '~ '],
           ext_method: :search_by_puppetclass
-        scoped_search relation: :config_groups, on: :name,
+        scoped_search relation: :search_config_groups, on: :name,
           complete_value: true,
           rename: :config_group,
           only_explicit: true,
@@ -45,9 +45,16 @@ module ForemanPuppet
         def search_by_puppetclass(_key, operator, value)
           conditions = sanitize_sql_for_conditions(["puppetclasses.name #{operator} ?", value_to_sql(operator, value)])
           hostgroup_ids = ::Hostgroup.joins(puppet: :puppetclasses).where(conditions).map(&:subtree_ids)
+          config_group_ids = ForemanPuppet::ConfigGroup.joins(:puppetclasses).where(conditions).pluck(:id)
+          if config_group_ids.any?
+            hostgroup_cg_ids = ForemanPuppet::HostgroupPuppetFacet.joins(:host_config_groups)
+                                                                  .where(host_config_groups: { config_group_id: config_group_ids })
+                                                                  .pluck(:hostgroup_id)
+            hostgroup_ids += ::Hostgroup.where(id: hostgroup_cg_ids).map(&:subtree_ids)
+          end
 
           conds = []
-          conds << "hostgroups.id IN (#{hostgroup_ids.join(',')})" if hostgroup_ids.present?
+          conds << "hostgroups.id IN (#{hostgroup_ids.uniq.join(',')})" if hostgroup_ids.present?
 
           { conditions: conds.join(' OR ').presence || 'hostgroups.id < 0' }
         end

data/app/models/foreman_puppet/config_group.rb

@@ -16,6 +16,8 @@ module ForemanPuppet
 
     validates :name, presence: true, uniqueness: true
 
+    scope :assigned_to_hosts, -> { where(id: ForemanPuppet::HostConfigGroup.select(:config_group_id)) }
+
     scoped_search on: :name, complete_value: true
     scoped_search relation: :puppetclasses, on: :name, complete_value: true, rename: :puppetclass, only_explicit: true, operators: ['= ', '~ ']
 
@@ -41,5 +43,9 @@ module ForemanPuppet
     def hostgroups_count
       ::Hostgroup.authorized.search_for(%(config_group="#{name}")).size
     end
+
+    def self.completer_scope(options)
+      super.merge(assigned_to_hosts)
+    end
   end
 end

data/app/models/foreman_puppet/puppetclass.rb

@@ -41,6 +41,16 @@ module ForemanPuppet
 
     default_scope -> { order(:name) }
 
+    scope :assigned_to_hosts, lambda {
+      direct = ForemanPuppet::HostClass.select(:puppetclass_id)
+      via_hostgroup = ForemanPuppet::HostgroupClass.select(:puppetclass_id)
+      via_config_group = ForemanPuppet::ConfigGroupClass
+                         .where(config_group_id: ForemanPuppet::HostConfigGroup.select(:config_group_id))
+                         .select(:puppetclass_id)
+
+      where(id: direct).or(where(id: via_hostgroup)).or(where(id: via_config_group))
+    }
+
     scoped_search on: :name, complete_value: true
     scoped_search relation: :environments, on: :name, complete_value: true, rename: 'environment'
     scoped_search relation: :organizations, on: :name, complete_value: true, rename: 'organization', only_explicit: true
@@ -142,5 +152,9 @@ module ForemanPuppet
       puppet_classes = (direct + indirect).uniq
       { conditions: "puppetclasses.id IN(#{puppet_classes.join(',')})" }
     end
+
+    def self.completer_scope(options)
+      super.merge(assigned_to_hosts)
+    end
   end
 end

data/app/services/concerns/foreman_puppet/extensions/bulk_hosts_manager.rb

@@ -3,6 +3,24 @@ module ForemanPuppet
     module BulkHostsManager
       extend ActiveSupport::Concern
 
+      def change_puppet_environment(environment)
+        error_hosts = []
+        @hosts.each do |host|
+          puppet = host.puppet || host.build_puppet
+          puppet.environment = if environment == 'inherit'
+                                 host.hostgroup&.puppet&.environment
+                               else
+                                 environment
+                               end
+          host.save(validate: false)
+        rescue StandardError => e
+          message = format(_('Failed to set Puppet environment for %{host}.'), host: host)
+          Foreman::Logging.exception(message, e)
+          error_hosts << host.id
+        end
+        error_hosts
+      end
+
       def change_puppet_proxy(proxy, is_ca_proxy)
         error_hosts = []
         @hosts.each do |host|

data/config/api_routes.rb

@@ -4,6 +4,7 @@ Foreman::Application.routes.draw do
       scope '(:apiv)', module: :v2, defaults: { apiv: 'v2' }, apiv: /v1|v2/, constraints: ApiConstraints.new(version: 2, default: true) do
         match 'hosts/bulk/change_puppet_proxy', to: 'hosts_bulk_actions#change_puppet_proxy', via: [:put]
         match 'hosts/bulk/remove_puppet_proxy', to: 'hosts_bulk_actions#remove_puppet_proxy', via: [:put]
+        match 'hosts/bulk/change_puppet_environment', to: 'hosts_bulk_actions#change_puppet_environment', via: [:put]
       end
     end
   end

data/db/seeds.d/111_puppet_proxy_feature.rb

@@ -4,5 +4,5 @@ proxy_features = %w[Puppet]
 
 proxy_features.each do |f_name|
   f = Feature.where(name: f_name).first_or_create
-  raise "Unable to create proxy feature: #{format_errors f}" if f.nil? || f.errors.any?
+  raise "Unable to create proxy feature: #{SeedHelper.format_errors(f)}" if f.nil? || f.errors.any?
 end

data/lib/foreman_puppet/register.rb

@@ -1,5 +1,5 @@
 Foreman::Plugin.register :foreman_puppet do
-  requires_foreman '>= 3.19'
+  requires_foreman '>= 5.0'
   register_gettext
 
   # Add Global JS file for extending foreman-core components and routes
@@ -62,6 +62,7 @@ Foreman::Plugin.register :foreman_puppet do
       p.actions << 'hosts/update_multiple_environment'
       p.actions << 'hosts/select_multiple_puppet_proxy'
       p.actions << 'hosts/update_multiple_puppet_proxy'
+      p.actions << 'foreman_puppet/api/v2/hosts_bulk_actions/change_puppet_environment'
       p.actions << 'foreman_puppet/api/v2/hosts_bulk_actions/change_puppet_proxy'
       p.actions << 'foreman_puppet/api/v2/hosts_bulk_actions/remove_puppet_proxy'
     end

data/lib/foreman_puppet/version.rb

@@ -1,3 +1,3 @@
 module ForemanPuppet
-  VERSION = '10.1.3'.freeze
+  VERSION = '11.1.0'.freeze
 end

data/test/controllers/foreman_puppet/api/v2/hosts_bulk_actions_controller_test.rb

@@ -16,8 +16,101 @@ module ForemanPuppet
             organization: host.organization,
             location: host.location)
         end
+        let(:environment) { FactoryBot.create(:environment, organizations: [host.organization], locations: [host.location]) }
+        let(:hostgroup_environment) { FactoryBot.create(:environment, organizations: [host.organization], locations: [host.location]) }
+        let(:hostgroup) do
+          FactoryBot.create(:hostgroup, :with_puppet_enc,
+            environment: hostgroup_environment,
+            organizations: [host.organization],
+            locations: [host.location])
+        end
         let(:proxy) { FactoryBot.create(:puppet_and_ca_smart_proxy, organizations: [host.organization], locations: [host.location]) }
 
+        def put_change_puppet_environment(params:, session: nil)
+          put :change_puppet_environment, params: params, session: session
+        end
+
+        test 'changes puppet environment for selected hosts' do
+          put_change_puppet_environment(params: bulk_params.merge(environment_id: environment.id))
+
+          assert_response :success
+          assert_equal environment.id, host2.reload.puppet.environment_id
+          assert_equal environment.id, host.reload.puppet.environment_id
+        end
+
+        test 'inherits puppet environment from hostgroups for selected hosts' do
+          host.update!(hostgroup: hostgroup)
+          host2.update!(hostgroup: hostgroup)
+
+          put_change_puppet_environment(params: bulk_params.merge(environment_id: 'inherit'))
+
+          assert_response :success
+          assert_equal hostgroup_environment.id, host2.reload.puppet.environment_id
+          assert_equal hostgroup_environment.id, host.reload.puppet.environment_id
+        end
+
+        test 'clears puppet environment for selected hosts' do
+          host.puppet.update!(environment: environment)
+          host2.puppet.update!(environment: environment)
+
+          put_change_puppet_environment(
+            params: bulk_params.merge(environment_id: nil),
+            session: set_session_user
+          )
+
+          assert_response :success
+          assert_nil host.reload.puppet.environment
+          assert_nil host2.reload.puppet.environment
+        end
+
+        test 'returns error when puppet environment is missing' do
+          missing_environment_id = 999_999
+
+          put_change_puppet_environment(
+            params: bulk_params.merge(environment_id: missing_environment_id),
+            session: set_session_user
+          )
+
+          assert_response :unprocessable_entity
+          response = JSON.parse(@response.body)
+          assert_equal "A Puppet environment with id #{missing_environment_id} could not be found.",
+            response.dig('error', 'message')
+        end
+
+        test 'returns error when changing puppet environment fails for some hosts' do
+          ::BulkHostsManager.any_instance.expects(:change_puppet_environment)
+                            .with(environment)
+                            .returns([host2.id])
+
+          put_change_puppet_environment(
+            params: bulk_params.merge(environment_id: environment.id),
+            session: set_session_user
+          )
+
+          assert_response :unprocessable_entity
+          response = JSON.parse(@response.body)
+          assert_equal 'Failed to change environment for 1 host',
+            response.dig('error', 'message')
+          assert_equal [host2.id], response.dig('error', 'failed_host_ids')
+        end
+
+        test 'returns error when puppet environment is outside host taxonomies' do
+          invalid_environment = FactoryBot.create(:environment,
+            organizations: [host.organization],
+            locations: [FactoryBot.create(:location)])
+
+          put_change_puppet_environment(
+            params: bulk_params.merge(environment_id: invalid_environment.id),
+            session: set_session_user
+          )
+
+          assert_response :unprocessable_entity
+          response = JSON.parse(@response.body)
+          assert_equal 'Selected Puppet environment is not assigned to the proper organization and/or location for all hosts.',
+            response.dig('error', 'message')
+          assert_equal [host.id, host2.id].sort, response.dig('error', 'failed_host_ids').sort
+        end
+
         test 'changes puppet proxy for selected hosts' do
           put :change_puppet_proxy,
             params: bulk_params.merge(proxy_id: proxy.id, ca_proxy: false)

data/test/models/foreman_puppet/host_test.rb

@@ -117,6 +117,72 @@ module ForemanPuppet
       end
     end
 
+    describe '#complete_for' do
+      let(:host) { FactoryBot.create(:host, :with_puppet_enc, :with_puppetclass) }
+
+      test 'can complete Puppet class values' do
+        puppetclass = host.puppet.puppetclasses.first
+        completions = ::Host::Managed.complete_for("puppetclass = #{puppetclass.name}")
+
+        assert_includes completions, %(puppetclass =  "#{puppetclass.name}")
+      end
+
+      test 'can complete config group values' do
+        config_group = FactoryBot.create(:config_group)
+        host.puppet.config_groups << config_group
+        completions = ::Host::Managed.complete_for("config_group = #{config_group.name}")
+
+        assert_includes completions, %(config_group =  "#{config_group.name}")
+      end
+
+      test 'can complete Puppet class values inherited from a hostgroup' do
+        hostgroup = FactoryBot.create(:hostgroup, :with_puppet_enc, :with_puppetclass)
+        FactoryBot.create(:host, hostgroup: hostgroup)
+        puppetclass = hostgroup.puppet.puppetclasses.first
+        completions = ::Host::Managed.complete_for("puppetclass = #{puppetclass.name}")
+
+        assert_includes completions, %(puppetclass =  "#{puppetclass.name}")
+      end
+
+      test 'can complete Puppet class values assigned through a config group' do
+        config_group = FactoryBot.create(:config_group, :with_puppetclass)
+        host.puppet.config_groups << config_group
+        puppetclass = config_group.puppetclasses.first
+        completions = ::Host::Managed.complete_for("puppetclass = #{puppetclass.name}")
+
+        assert_includes completions, %(puppetclass =  "#{puppetclass.name}")
+      end
+
+      test 'can complete config group values inherited from a hostgroup' do
+        hostgroup = FactoryBot.create(:hostgroup, :with_puppet_enc, :with_config_group)
+        FactoryBot.create(:host, hostgroup: hostgroup)
+        config_group = hostgroup.puppet.config_groups.first
+        completions = ::Host::Managed.complete_for("config_group = #{config_group.name}")
+
+        assert_includes completions, %(config_group =  "#{config_group.name}")
+      end
+
+      test 'does not complete unassigned Puppet class values' do
+        puppetclass = FactoryBot.create(:puppetclass)
+        completions = ::Host::Managed.complete_for("puppetclass = #{puppetclass.name}")
+
+        assert_not_includes completions, %(puppetclass =  "#{puppetclass.name}")
+      end
+
+      test 'does not complete unassigned config group values' do
+        config_group = FactoryBot.create(:config_group)
+        completions = ::Host::Managed.complete_for("config_group = #{config_group.name}")
+
+        assert_not_includes completions, %(config_group =  "#{config_group.name}")
+      end
+
+      test 'preserves core host value completions' do
+        completions = as_admin { ::Host::Managed.complete_for('user.login =') }
+
+        assert_includes completions, 'user.login = current_user'
+      end
+    end
+
     describe '#info puppet bits' do
       test 'ENC YAML omits environment if no puppet facet' do
         host = FactoryBot.build_stubbed(:host)

data/test/models/foreman_puppet/hostgroup_test.rb

@@ -22,5 +22,37 @@ module ForemanPuppet
       assert_includes hostgroup.puppet.puppetclasses, puppet_class
       assert_includes hostgroup.puppetclasses, puppet_class
     end
+
+    test 'can complete Puppet class values' do
+      puppetclass = FactoryBot.create(:puppetclass)
+      hostgroup.puppet.puppetclasses << puppetclass
+      completions = ::Hostgroup.complete_for("puppetclass = #{puppetclass.name}")
+
+      assert_includes completions, %(puppetclass =  "#{puppetclass.name}")
+    end
+
+    test 'can complete config group values' do
+      config_group = hostgroup.puppet.config_groups.first
+      completions = ::Hostgroup.complete_for("config_group = #{config_group.name}")
+
+      assert_includes completions, %(config_group =  "#{config_group.name}")
+    end
+
+    test 'can complete Puppet class values inherited from a parent hostgroup' do
+      parent = FactoryBot.create(:hostgroup, :with_puppet_enc, :with_puppetclass)
+      FactoryBot.create(:hostgroup, parent: parent)
+      puppetclass = parent.puppet.puppetclasses.first
+      completions = ::Hostgroup.complete_for("puppetclass = #{puppetclass.name}")
+
+      assert_includes completions, %(puppetclass =  "#{puppetclass.name}")
+    end
+
+    test 'searches Puppet class values assigned through a config group' do
+      config_group = hostgroup.puppet.config_groups.first
+      puppetclass = FactoryBot.create(:puppetclass)
+      config_group.puppetclasses << puppetclass
+
+      assert_includes ::Hostgroup.search_for("puppetclass = #{puppetclass.name}"), hostgroup
+    end
   end
 end

data/test/services/foreman_puppet/bulk_hosts_manager_test.rb

@@ -4,6 +4,51 @@ class BulkHostsManagerTest < ActiveSupport::TestCase
   let(:hosts) { FactoryBot.create_list(:host, 2, :with_puppet_enc) }
   let(:manager) { ::BulkHostsManager.new(hosts: hosts) }
   let(:proxy) { FactoryBot.create(:puppet_smart_proxy) }
+  let(:environment) { FactoryBot.create(:environment, organizations: [hosts.first.organization], locations: [hosts.first.location]) }
+
+  test 'changes puppet environment for hosts' do
+    manager.change_puppet_environment(environment)
+
+    hosts.each do |host|
+      assert_equal environment.id, host.reload.puppet.environment_id
+    end
+  end
+
+  test 'inherits puppet environment from hostgroup' do
+    organization = FactoryBot.create(:organization)
+    location = FactoryBot.create(:location)
+    inherited_environment = FactoryBot.create(:environment, organizations: [organization], locations: [location])
+    initial_environment = FactoryBot.create(:environment, organizations: [organization], locations: [location])
+    hostgroup = FactoryBot.create(:hostgroup, :with_puppet_enc,
+      environment: inherited_environment,
+      organizations: [organization],
+      locations: [location])
+    inherited_hosts = FactoryBot.create_list(:host, 2, :with_puppet_enc,
+      environment: initial_environment,
+      hostgroup: hostgroup,
+      organization: organization,
+      location: location)
+
+    inherited_hosts.each do |host|
+      assert_not_equal inherited_environment.id, host.reload.puppet.environment_id
+    end
+
+    ::BulkHostsManager.new(hosts: inherited_hosts).change_puppet_environment('inherit')
+
+    inherited_hosts.each do |host|
+      assert_equal inherited_environment.id, host.reload.puppet.environment_id
+    end
+  end
+
+  test 'clears puppet environment when environment is nil' do
+    hosts.each { |host| host.puppet.update!(environment: environment) }
+
+    manager.change_puppet_environment(nil)
+
+    hosts.each do |host|
+      assert_nil host.reload.puppet.environment
+    end
+  end
 
   test 'changes puppet proxy for hosts' do
     manager.change_puppet_proxy(proxy, false)

data/webpack/__mocks__/foremanReact/redux/API/index.js

@@ -6,5 +6,13 @@ export const API = {
   patch: jest.fn(),
 };
 
+export const APIActions = {
+  get: jest.fn(),
+  post: jest.fn(),
+  put: jest.fn(),
+  patch: jest.fn(),
+  delete: jest.fn(),
+};
+
 export const get = data => ({ type: 'get-some-type', ...data });
 export const post = data => ({ type: 'post-some-type', ...data });

data/webpack/global_index.js

@@ -7,12 +7,15 @@ import reducers from './src/reducers';
 import { registerFills } from './src/Extends/Fills';
 import { registerLegacy } from './legacy';
 import HostsIndexActionsBar from './src/Extends/Hosts/ActionsBar';
+import BulkChangePuppetEnvironment from './src/Extends/Hosts/BulkActions/BulkChangePuppetEnvironment';
+import BulkRemovePuppetEnvironment from './src/Extends/Hosts/BulkActions/BulkRemovePuppetEnvironment';
 import BulkChangePuppetProxy from './src/Extends/Hosts/BulkActions/BulkChangePuppetProxy';
 import BulkChangePuppetCAProxy from './src/Extends/Hosts/BulkActions/BulkChangePuppetCAProxy';
 import BulkRemovePuppetProxy from './src/Extends/Hosts/BulkActions/BulkRemovePuppetProxy';
 import BulkRemovePuppetCAProxy from './src/Extends/Hosts/BulkActions/BulkRemovePuppetCAProxy';
 
 const GLOBAL_FILL_PRIORITY = 100;
+const PUPPET_ENV_COLUMN_WEIGHT = 2700;
 
 // register reducers
 registerReducer('puppet', reducers);
@@ -28,7 +31,7 @@ const puppetHostsIndexColumns = [
     title: __('Puppet env'),
     isSorted: true,
     wrapper: hostDetails => hostDetails.environment_name,
-    weight: 2700,
+    weight: PUPPET_ENV_COLUMN_WEIGHT,
   },
 ];
 
@@ -45,6 +48,20 @@ addGlobalFill(
   GLOBAL_FILL_PRIORITY
 );
 
+addGlobalFill(
+  '_all-hosts-modals',
+  'BulkChangePuppetEnvironment',
+  <BulkChangePuppetEnvironment key="bulk-change-puppet-environment" />,
+  GLOBAL_FILL_PRIORITY
+);
+
+addGlobalFill(
+  '_all-hosts-modals',
+  'BulkRemovePuppetEnvironment',
+  <BulkRemovePuppetEnvironment key="bulk-remove-puppet-environment" />,
+  GLOBAL_FILL_PRIORITY
+);
+
 addGlobalFill(
   '_all-hosts-modals',
   'BulkChangePuppetProxy',