foreman_puppet 1.0.5 → 3.0.1

data/test/integration/foreman_puppet/dashboard_js_test.rb

@@ -0,0 +1,30 @@
+require 'integration_puppet_helper'
+require 'integration/shared/host_finders'
+require 'integration/shared/host_orchestration_stubs'
+
+module ForemanPuppet
+  class DashboardJSTest < IntegrationTestWithJavascript
+    setup do
+      Dashboard::Manager.reset_user_to_default(users(:admin))
+      Setting[:outofsync_interval] = 35
+    end
+
+    context 'with origin' do
+      setup do
+        Setting[:puppet_out_of_sync_disabled] = true
+      end
+
+      context 'out of sync disabled' do
+        test 'has no out of sync link' do
+          visit dashboard_path
+          wait_for_ajax
+          within "li[data-name='Host Configuration Status for Puppet']" do
+            assert page.has_no_link?('Out of sync hosts')
+            assert page.has_no_link?('Good host reports in the last')
+            assert page.has_link?('Good host with reports')
+          end
+        end
+      end
+    end
+  end
+end

data/test/integration/foreman_puppet/environment_js_test.rb

@@ -1,5 +1,4 @@
-require 'test_puppet_helper'
-require 'integration_test_helper'
+require 'integration_puppet_helper'
 
 module ForemanPuppet
   class EnvironmentJSTest < IntegrationTestWithJavascript

data/test/integration/foreman_puppet/host_js_test.rb

@@ -1,5 +1,4 @@
-require 'test_puppet_helper'
-require 'integration_test_helper'
+require 'integration_puppet_helper'
 require 'integration/shared/host_finders'
 require 'integration/shared/host_orchestration_stubs'
 
@@ -214,7 +213,7 @@ module ForemanPuppet
                                                      puppetclass: host.puppet.puppetclasses.first, overrides: { host.lookup_value_matcher => 'hostOverride' })
           visit edit_host_path(host)
           switch_form_tab('Puppet ENC')
-          assert_equal('hostOverride', puppetclass_params.find('textarea').value)
+          expect(puppetclass_params.find('textarea').value).must_equal('hostOverride')
           assert puppetclass_params.find('textarea:enabled')
           puppetclass_params.find("a[data-tag='remove']").click
           assert puppetclass_params.find('textarea:disabled')
@@ -222,17 +221,17 @@ module ForemanPuppet
 
           visit edit_host_path(host)
           switch_form_tab('Puppet ENC')
-          assert_equal('default', puppetclass_params.find('textarea').value)
-          assert puppetclass_params.find('textarea:disabled')
+          expect(puppetclass_params.find('textarea').value).must_equal('default')
+          expect(puppetclass_params).must_have_selector('textarea:disabled')
           puppetclass_params.find("a[data-tag='override']").click
-          assert puppetclass_params.find('textarea:enabled')
+          expect(puppetclass_params).must_have_selector('textarea:enabled')
           puppetclass_params.find('textarea').set('userCustom')
           click_on_submit
 
           visit edit_host_path(host)
           switch_form_tab('Puppet ENC')
-          assert_equal('userCustom', puppetclass_params.find('textarea').value)
-          assert puppetclass_params.find('textarea:enabled')
+          expect(puppetclass_params.find('textarea').value).must_equal('userCustom')
+          expect(puppetclass_params).must_have_selector('textarea:enabled')
         end
 
         test 'can override puppetclass lookup values' do
@@ -241,22 +240,22 @@ module ForemanPuppet
 
           visit edit_host_path(host)
           switch_form_tab('Puppet ENC')
-          assert puppetclass_params.has_selector?("a[data-tag='remove']", visible: :visible)
-          assert puppetclass_params.has_selector?("a[data-tag='override']", visible: :hidden)
-          assert_equal('hostOverride', puppetclass_params.find('textarea').value)
-          assert puppetclass_params.find('textarea:enabled')
+          expect(puppetclass_params).must_have_selector("a[data-tag='remove']", visible: :visible)
+          expect(puppetclass_params).must_have_selector("a[data-tag='override']", visible: :hidden)
+          expect(puppetclass_params.find('textarea').value).must_equal('hostOverride')
+          expect(puppetclass_params).must_have_selector('textarea:enabled')
 
           puppetclass_params.find("a[data-tag='remove']").click
-          assert puppetclass_params.has_selector?("a[data-tag='remove']", visible: :hidden)
-          assert puppetclass_params.has_selector?("a[data-tag='override']", visible: :visible)
+          expect(puppetclass_params).must_have_selector("a[data-tag='remove']", visible: :hidden)
+          expect(puppetclass_params).must_have_selector("a[data-tag='override']", visible: :visible)
           assert_equal('default', puppetclass_params.find('textarea').value)
           assert puppetclass_params.find('textarea:disabled')
 
           puppetclass_params.find("a[data-tag='override']").click
-          assert puppetclass_params.has_selector?("a[data-tag='remove']", visible: :visible)
-          assert puppetclass_params.has_selector?("a[data-tag='override']", visible: :hidden)
-          assert_equal('default', puppetclass_params.find('textarea').value)
-          assert puppetclass_params.find('textarea:enabled')
+          expect(puppetclass_params).must_have_selector("a[data-tag='remove']", visible: :visible)
+          expect(puppetclass_params).must_have_selector("a[data-tag='override']", visible: :hidden)
+          expect(puppetclass_params.find('textarea').value).must_equal('default')
+          expect(puppetclass_params).must_have_selector('textarea:enabled')
         end
 
         context 'with non-admin user' do
@@ -362,7 +361,6 @@ module ForemanPuppet
       page.find('#puppet_klasses_parameters_table')
     end
 
-    # TODO: unless ForemanPuppet.extracted_from_core?
     def switch_form_tab_to_interfaces
       switch_form_tab('Interfaces')
       disable_interface_modal_animation

data/test/integration/foreman_puppet/hostgroup_js_test.rb

@@ -1,5 +1,4 @@
-require 'test_puppet_helper'
-require 'integration_test_helper'
+require 'integration_puppet_helper'
 
 module ForemanPuppet
   class HostgroupJSTest < IntegrationTestWithJavascript

data/test/integration/foreman_puppet/puppetclass_js_test.rb

@@ -1,5 +1,4 @@
-require 'test_puppet_helper'
-require 'integration_test_helper'
+require 'integration_puppet_helper'
 
 module ForemanPuppet
   class PuppetclassJsTest < IntegrationTestWithJavascript
@@ -11,7 +10,7 @@ module ForemanPuppet
     let(:puppetclass) { FactoryBot.create(:puppetclass, environments: [environment]) }
 
     test 'edit page' do
-      FactoryBot.create(:puppetclass, name: 'vim', environments: [environment]) if ForemanPuppet.extracted_from_core?
+      FactoryBot.create(:puppetclass, name: 'vim', environments: [environment])
       visit puppetclasses_path
       click_link 'vim'
       assert page.has_no_link? 'Common'

data/test/integration/foreman_puppet/smartclass_parameter_js_test.rb

@@ -1,5 +1,4 @@
-require_relative '../../test_puppet_helper'
-require 'integration_test_helper'
+require 'integration_puppet_helper'
 
 module ForemanPuppet
   class SmartclassParameterJSTest < IntegrationTestWithJavascript

data/test/integration_puppet_helper.rb

@@ -0,0 +1,3 @@
+require 'test_puppet_helper'
+require 'integration_test_helper'
+require 'capybara/minitest/spec'

data/test/models/foreman_puppet/host_puppet_facet_test.rb

@@ -107,13 +107,13 @@ module ForemanPuppet
       test 'should return empty array if host has no hostgroup' do
         host = FactoryBot.create(:host, :with_puppet_enc)
         assert_not host.hostgroup
-        assert_equal [], host.puppet.parent_config_groups
+        assert_empty host.puppet.parent_config_groups
       end
 
       test 'should return empty array if hostgroup do not have puppet data' do
         hostgroup = FactoryBot.create(:hostgroup)
         host = FactoryBot.create(:host, :with_puppet_enc, hostgroup: hostgroup)
-        assert_equal [], host.puppet.parent_config_groups
+        assert_empty host.puppet.parent_config_groups
       end
     end
 

data/test/models/foreman_puppet/host_test.rb

@@ -4,13 +4,13 @@ module ForemanPuppet
   class HostTest < ActiveSupport::TestCase
     test 'should read the Puppetserver URL from its proxy settings' do
       host = FactoryBot.build_stubbed(:host)
-      assert_nil host.puppet_server_uri
-      assert_empty host.puppetmaster
+      expect(host.puppet_server_uri).must_be_nil
+      expect(host.puppetmaster).must_be_empty
 
       proxy = FactoryBot.create(:puppet_smart_proxy, url: 'https://smartproxy.example.com:8443')
       host.puppet_proxy = proxy
-      assert_equal 'https://smartproxy.example.com:8140', host.puppet_server_uri.to_s
-      assert_equal 'smartproxy.example.com', host.puppetmaster
+      expect(host.puppet_server_uri.to_s).must_equal 'https://smartproxy.example.com:8140'
+      expect(host.puppetmaster).must_equal 'smartproxy.example.com'
 
       features = {
         'puppet' => {
@@ -18,8 +18,8 @@ module ForemanPuppet
         },
       }
       SmartProxyFeature.import_features(proxy, features)
-      assert_equal 'https://puppet.example.com:8140', host.puppet_server_uri.to_s
-      assert_equal 'puppet.example.com', host.puppetmaster
+      expect(host.puppet_server_uri.to_s).must_equal 'https://puppet.example.com:8140'
+      expect(host.puppetmaster).must_equal 'puppet.example.com'
     end
 
     test 'should find smart proxy ids' do
@@ -141,12 +141,38 @@ module ForemanPuppet
         host = FactoryBot.create(:host, :with_puppet_enc, :with_config_group, :with_puppetclass, :with_parameter,
           hostgroup: hostgroup, environment: hostgroup.puppet.environment)
         copy = host.clone
-        assert_equal host.puppet.individual_puppetclasses.map(&:id), copy.puppet.individual_puppetclasses.map(&:id)
-        assert_equal host.puppet.classes_in_groups.map(&:id), copy.puppet.classes_in_groups.map(&:id)
-        assert_equal host.puppet.classes.map(&:id), copy.puppet.classes.map(&:id)
-        assert_equal host.puppet.available_puppetclasses.map(&:id), copy.puppet.available_puppetclasses.map(&:id)
-        assert_equal host.puppet.host_classes.map(&:puppetclass_id), copy.puppet.host_classes.map(&:puppetclass_id)
-        assert_equal host.puppet.host_config_groups.map(&:config_group_id), copy.puppet.host_config_groups.map(&:config_group_id)
+        expect(copy.puppet.individual_puppetclasses.map(&:id)).must_equal(host.puppet.individual_puppetclasses.map(&:id))
+        expect(copy.puppet.classes_in_groups.map(&:id)).must_equal(host.puppet.classes_in_groups.map(&:id))
+        expect(copy.puppet.classes.map(&:id)).must_equal(host.puppet.classes.map(&:id))
+        expect(copy.puppet.available_puppetclasses.map(&:id)).must_equal(host.puppet.available_puppetclasses.map(&:id))
+        expect(copy.puppet.host_classes.map(&:puppetclass_id)).must_equal(host.puppet.host_classes.map(&:puppetclass_id))
+        expect(copy.puppet.host_config_groups.map(&:config_group_id)).must_equal(host.puppet.host_config_groups.map(&:config_group_id))
+      end
+    end
+
+    describe '#available_template_kinds' do
+      let(:template_kinds) { [stub(name: 'iPXE'), stub(name: 'finish')] }
+
+      test 'calls find_template with Puppet environment' do
+        host = FactoryBot.create(:host, :with_hostgroup, :with_puppet_enc)
+        host.expects(:template_kinds).returns(template_kinds)
+        template_kinds.each do |kind|
+          ::ProvisioningTemplate.expects(:find_template)
+                                .with(kind: kind.name, operatingsystem_id: host.operatingsystem.id, hostgroup_id: host.hostgroup.id, environment_id: host.puppet.environment.id)
+                                .returns(stub(name: "default #{kind.name}"))
+        end
+        assert_equal template_kinds.map { |k| "default #{k.name}" }, host.available_template_kinds.map(&:name)
+      end
+
+      test 'calls find_template without Puppet environment' do
+        host = FactoryBot.create(:host, :with_hostgroup)
+        host.expects(:template_kinds).returns(template_kinds)
+        template_kinds.each do |kind|
+          ::ProvisioningTemplate.expects(:find_template)
+                                .with(kind: kind.name, operatingsystem_id: host.operatingsystem.id, hostgroup_id: host.hostgroup.id, environment_id: nil)
+                                .returns(stub(name: "default #{kind.name}"))
+        end
+        assert_equal template_kinds.map { |k| "default #{k.name}" }, host.available_template_kinds.map(&:name)
       end
     end
 
@@ -206,20 +232,20 @@ module ForemanPuppet
       nodeinfo['parameters']['special_info'] = 'secret' # smart variable on apache
 
       info = host.info
-      assert_includes info.keys, 'environment'
-      assert_equal env.name, host.puppet.environment.name
-      assert_includes info.keys, 'parameters'
-      assert_includes info.keys, 'classes'
+      expect(host.puppet.environment.name).must_equal(env.name)
+      expect(info.keys).must_include 'environment'
+      expect(info.keys).must_include 'parameters'
+      expect(info.keys).must_include 'classes'
       # This worked in core, but it's beyond me how could have :shrug:
       # assert_equal(classes_params, info['classes'])
       # We are only importing classes in the method
-      assert_equal(classes_params.keys.sort, info['classes'].keys.sort)
+      expect(info['classes'].keys.sort).must_equal(classes_params.keys.sort)
       parameters = info['parameters']
-      assert_equal 'puppet', parameters['puppetmaster']
-      assert_equal 'xybxa6JUkz63w', parameters['root_pw']
-      assert_includes parameters.keys, 'foreman_subnets'
-      assert_includes parameters.keys, 'foreman_interfaces'
-      assert_equal '3.3.4.12', parameters['foreman_interfaces'].first['ip']
+      expect(parameters['puppetmaster']).must_equal 'puppet'
+      expect(parameters['root_pw']).must_equal 'xybxa6JUkz63w'
+      expect(parameters['foreman_interfaces'].first['ip']).must_equal '3.3.4.12'
+      expect(parameters.keys).must_include 'foreman_subnets'
+      expect(parameters.keys).must_include 'foreman_interfaces'
     end
 
     test 'should import from non-parameterized external nodes output' do

data/test/models/foreman_puppet/provisioning_template_test.rb

@@ -32,9 +32,9 @@ module ForemanPuppet
         assert tmplt.save
       end
       assert_nil tmplt.template_kind
-      assert_equal [], tmplt.hostgroups
-      assert_equal [], tmplt.environments
-      assert_equal [], tmplt.template_combinations
+      assert_empty tmplt.hostgroups
+      assert_empty tmplt.environments
+      assert_empty tmplt.template_combinations
     end
 
     test '#template_includes adds environment include' do

data/test/models/foreman_puppet/puppetclass_test.rb

@@ -17,7 +17,7 @@ module ForemanPuppet
     end
 
     test 'looking for a nonexistent host returns no puppetclasses' do
-      assert_equal [], Puppetclass.search_for('host = imaginaryhost.nodomain.what')
+      assert_empty Puppetclass.search_for('host = imaginaryhost.nodomain.what')
     end
 
     test 'Puppetclass singularize from custom inflection' do

data/test/models/foreman_puppet/user_test.rb

@@ -5,11 +5,7 @@ module ForemanPuppet
     describe '#visible_environments' do
       let(:environment) { FactoryBot.create(:environment) }
       let(:untaxed_env) { FactoryBot.create(:environment, organizations: [], locations: []) }
-      let(:env_names) do
-        env_names = [environment.name, untaxed_env.name]
-        env_names += %w[production global_puppetmaster testing] unless ForemanPuppet.extracted_from_core?
-        env_names
-      end
+      let(:env_names) { [environment.name, untaxed_env.name] }
 
       setup do
         environment

data/test/services/foreman_puppet/host_info_providers/config_groups_info_test.rb

@@ -28,7 +28,7 @@ module ForemanPuppet
       end
 
       it 'does not fail without puppet facet' do
-        assert_equal({}, cg_info.host_info)
+        assert_empty(cg_info.host_info)
       end
     end
   end

data/test/services/foreman_puppet/host_info_providers/puppet_info_test.rb

@@ -98,7 +98,7 @@ module ForemanPuppet
         puppetclass: puppetclass)
 
       enc = HostInfoProviders::PuppetInfo.new(@host).puppetclass_parameters
-      assert enc[puppetclass.name][lkey.key].nil?
+      assert_nil enc[puppetclass.name][lkey.key]
     end
 
     test '#enc should not return class parameters when lookup_value should use puppet default' do
@@ -113,7 +113,7 @@ module ForemanPuppet
 
       enc = HostInfoProviders::PuppetInfo.new(@host).puppetclass_parameters
 
-      assert enc[puppetclass.name][lkey.key].nil?
+      assert_nil enc[puppetclass.name][lkey.key]
     end
 
     test '#enc should return class parameters when default value and lookup_values should not use puppet default' do
@@ -160,7 +160,7 @@ module ForemanPuppet
 
       enc = HostInfoProviders::PuppetInfo.new(@host).puppetclass_parameters
 
-      assert enc[puppetclass.name][key.key].nil?
+      assert_nil enc[puppetclass.name][key.key]
     end
 
     test '#enc should return correct merged override to host when multiple overrides for inherited hostgroups exist' do

data/test/unit/foreman_puppet/puppet_class_importer_test.rb

@@ -3,7 +3,7 @@ require 'test_puppet_helper'
 module ForemanPuppet
   class PuppetClassImporterTest < ActiveSupport::TestCase
     def setup
-      FactoryBot.create(:environment, name: 'production') if ForemanPuppet.extracted_from_core?
+      FactoryBot.create(:environment, name: 'production')
       ProxyAPI::Puppet.any_instance.stubs(:environments).returns(%w[foreman-testing foreman-testing-1])
       ProxyAPI::Puppet.any_instance.stubs(:classes).returns(mocked_classes)
       User.current = users(:admin)

data/test/unit/foreman_puppet/template_rendering_test.rb

@@ -3,7 +3,7 @@ require 'test_puppet_helper'
 module ForemanPuppet
   class TemplateRenderingTest < ActiveSupport::TestCase
     let(:host) { FactoryBot.build_stubbed(:host, :with_puppet_enc) }
-    let(:template) { OpenStruct.new(name: 'Test', template: 'Test') }
+    let(:template) { stub(name: 'Test', template: 'Test') }
     let(:source) { Foreman::Renderer::Source::Database.new(template) }
     let(:scope) do
       Class.new(Foreman::Renderer::Scope::Base) do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foreman_puppet
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 3.0.1
 platform: ruby
 authors:
 - Ondřej Ezr
@@ -9,9 +9,9 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-11-15 00:00:00.000000000 Z
+date: 2021-12-29 00:00:00.000000000 Z
 dependencies: []
-description: Allow assigning Puppet environmets and classes to the Foreman Hosts.
+description: Allow assigning Puppet environments and classes to the Foreman Hosts.
 email:
 - foreman-dev@googlegroups.com
 executables: []
@@ -22,10 +22,10 @@ files:
 - README.md
 - Rakefile
 - app/assets/stylesheets/foreman_puppet.scss
-- app/controllers/concerns/foreman_puppet/api/import_puppetclasses_common_controller.rb
 - app/controllers/concerns/foreman_puppet/environments_import.rb
 - app/controllers/concerns/foreman_puppet/extensions/api_base_controller.rb
 - app/controllers/concerns/foreman_puppet/extensions/api_hostgroups_controller.rb
+- app/controllers/concerns/foreman_puppet/extensions/api_smart_proxies_controller.rb
 - app/controllers/concerns/foreman_puppet/extensions/api_template_combinations_controller.rb
 - app/controllers/concerns/foreman_puppet/extensions/api_v2_hosts_controller.rb
 - app/controllers/concerns/foreman_puppet/extensions/hostgroups_controller_extensions.rb
@@ -113,9 +113,11 @@ files:
 - app/views/foreman_puppet/api/v2/environments/show.json.rabl
 - app/views/foreman_puppet/api/v2/environments/update.json.rabl
 - app/views/foreman_puppet/api/v2/host_puppet_facets/base.json.rabl
+- app/views/foreman_puppet/api/v2/host_puppet_facets/host_list.json.rabl
 - app/views/foreman_puppet/api/v2/host_puppet_facets/host_single.json.rabl
 - app/views/foreman_puppet/api/v2/host_puppet_facets/show.json.rabl
 - app/views/foreman_puppet/api/v2/hostgroup_puppet_facets/base.json.rabl
+- app/views/foreman_puppet/api/v2/hostgroup_puppet_facets/hostgroup_list.json.rabl
 - app/views/foreman_puppet/api/v2/hostgroup_puppet_facets/hostgroup_single.json.rabl
 - app/views/foreman_puppet/api/v2/hostgroup_puppet_facets/show.json.rabl
 - app/views/foreman_puppet/api/v2/import_puppetclasses/index.json.rabl
@@ -183,17 +185,26 @@ files:
 - db/migrate/20200803113803_migrate_environment_to_puppet_facet.foreman_puppet.rb
 - db/migrate/20200803113903_migrate_host_type_in_host_config_groups.foreman_puppet.rb
 - db/migrate/20201125113903_migrate_puppetclasses_to_facets.foreman_puppet.rb
+- db/migrate/20210924103241_remove_katello_id_from_environments.foreman_puppet.rb
+- db/migrate/20211111125003_drop_puppetclasses_direct_references.foreman_puppet.rb
 - db/migrate/20211112130803_cleanup_environment_from_core_tables.foreman_puppet.rb
-- db/migrate_foreman/20090722141107_create_environments.rb
-- db/migrate_foreman/20120905095532_create_environment_classes.rb
-- db/migrate_foreman/20140407161817_create_config_groups.rb
-- db/migrate_foreman/20140407162007_create_config_group_classes.rb
-- db/migrate_foreman/20140407162059_create_host_config_groups.rb
-- db/migrate_foreman/20161205142618_delete_orphaned_smart_class_parameters.rb
-- db/migrate_foreman/20170109115157_fix_lookup_key_auditable_type.rb
-- db/migrate_foreman/20180816134832_cast_lookup_key_values.rb
-- db/migrate_foreman/20181023112532_add_environment_puppetclass_id.rb
-- db/migrate_foreman/20181224174419_add_index_to_environment_class_by_lookup_key_and_puppetclass.rb
+- db/migrate_foreman/20090722141107_create_environments.foreman_puppet.rb
+- db/migrate_foreman/20090802062223_create_puppetclasses.foreman_puppet.rb
+- db/migrate_foreman/20090905150132_create_hostgroups_puppetclasses.foreman_puppet.rb
+- db/migrate_foreman/20110412103238_remove_unused_fields_from_puppet_classes.foreman_puppet.rb
+- db/migrate_foreman/20110712070522_create_host_class.foreman_puppet.rb
+- db/migrate_foreman/20120824142048_add_some_indexes.foreman_puppet.rb
+- db/migrate_foreman/20120905095532_create_environment_classes.foreman_puppet.rb
+- db/migrate_foreman/20121018152459_create_hostgroup_classes.foreman_puppet.rb
+- db/migrate_foreman/20140407161817_create_config_groups.foreman_puppet.rb
+- db/migrate_foreman/20140407162007_create_config_group_classes.foreman_puppet.rb
+- db/migrate_foreman/20140407162059_create_host_config_groups.foreman_puppet.rb
+- db/migrate_foreman/20161205142618_delete_orphaned_smart_class_parameters.foreman_puppet.rb
+- db/migrate_foreman/20170109115157_fix_lookup_key_auditable_type.foreman_puppet.rb
+- db/migrate_foreman/20180816134832_cast_lookup_key_values.foreman_puppet.rb
+- db/migrate_foreman/20180831115634_add_uniqueness_to_puppetclass_name.foreman_puppet.rb
+- db/migrate_foreman/20181023112532_add_environment_puppetclass_id.foreman_puppet.rb
+- db/migrate_foreman/20181224174419_add_index_to_environment_class_by_lookup_key_and_puppetclass.foreman_puppet.rb
 - db/seeds.d/111_puppet_proxy_feature.rb
 - lib/foreman_puppet.rb
 - lib/foreman_puppet/engine.rb
@@ -202,16 +213,50 @@ files:
 - lib/tasks/foreman_puppet_tasks.rake
 - locale/Makefile
 - locale/action_names.rb
+- locale/ca/LC_MESSAGES/foreman_puppet.mo
+- locale/ca/foreman_puppet.po
+- locale/cs_CZ/LC_MESSAGES/foreman_puppet.mo
 - locale/cs_CZ/foreman_puppet.edit.po
+- locale/cs_CZ/foreman_puppet.po
 - locale/cs_CZ/foreman_puppet.po.time_stamp
+- locale/de/LC_MESSAGES/foreman_puppet.mo
+- locale/de/foreman_puppet.po
 - locale/en/LC_MESSAGES/foreman_puppet.mo
 - locale/en/foreman_puppet.edit.po
 - locale/en/foreman_puppet.po
 - locale/en/foreman_puppet.po.time_stamp
 - locale/en/foreman_puppet.pox
+- locale/en_GB/LC_MESSAGES/foreman_puppet.mo
+- locale/en_GB/foreman_puppet.po
+- locale/es/LC_MESSAGES/foreman_puppet.mo
+- locale/es/foreman_puppet.po
 - locale/foreman_puppet.pot
+- locale/fr/LC_MESSAGES/foreman_puppet.mo
+- locale/fr/foreman_puppet.po
 - locale/gemspec.rb
+- locale/gl/LC_MESSAGES/foreman_puppet.mo
+- locale/gl/foreman_puppet.po
+- locale/it/LC_MESSAGES/foreman_puppet.mo
+- locale/it/foreman_puppet.po
+- locale/ja/LC_MESSAGES/foreman_puppet.mo
+- locale/ja/foreman_puppet.po
+- locale/ko/LC_MESSAGES/foreman_puppet.mo
+- locale/ko/foreman_puppet.po
 - locale/messages.mo
+- locale/nl_NL/LC_MESSAGES/foreman_puppet.mo
+- locale/nl_NL/foreman_puppet.po
+- locale/pl/LC_MESSAGES/foreman_puppet.mo
+- locale/pl/foreman_puppet.po
+- locale/pt_BR/LC_MESSAGES/foreman_puppet.mo
+- locale/pt_BR/foreman_puppet.po
+- locale/ru/LC_MESSAGES/foreman_puppet.mo
+- locale/ru/foreman_puppet.po
+- locale/sv_SE/LC_MESSAGES/foreman_puppet.mo
+- locale/sv_SE/foreman_puppet.po
+- locale/zh_CN/LC_MESSAGES/foreman_puppet.mo
+- locale/zh_CN/foreman_puppet.po
+- locale/zh_TW/LC_MESSAGES/foreman_puppet.mo
+- locale/zh_TW/foreman_puppet.po
 - package.json
 - test/controllers/foreman_puppet/api/v2/config_groups_controller_test.rb
 - test/controllers/foreman_puppet/api/v2/environments_controller_test.rb
@@ -224,6 +269,7 @@ files:
 - test/controllers/foreman_puppet/api/v2/provisioning_templates_controller_test.rb
 - test/controllers/foreman_puppet/api/v2/puppetclasses_controller_test.rb
 - test/controllers/foreman_puppet/api/v2/smart_class_parameters_controller_test.rb
+- test/controllers/foreman_puppet/api/v2/smart_proxies_controller_test.rb
 - test/controllers/foreman_puppet/api/v2/template_combinations_controller_test.rb
 - test/controllers/foreman_puppet/config_groups_controller_test.rb
 - test/controllers/foreman_puppet/environments_controller_test.rb
@@ -247,11 +293,13 @@ files:
 - test/graphql/queries/puppetclasses_query_test.rb
 - test/helpers/foreman_puppet/hosts_and_hostgroups_helper_test.rb
 - test/helpers/foreman_puppet/puppetclasses_helper_test.rb
+- test/integration/foreman_puppet/dashboard_js_test.rb
 - test/integration/foreman_puppet/environment_js_test.rb
 - test/integration/foreman_puppet/host_js_test.rb
 - test/integration/foreman_puppet/hostgroup_js_test.rb
 - test/integration/foreman_puppet/puppetclass_js_test.rb
 - test/integration/foreman_puppet/smartclass_parameter_js_test.rb
+- test/integration_puppet_helper.rb
 - test/models/foreman_puppet/config_group_class_test.rb
 - test/models/foreman_puppet/config_group_test.rb
 - test/models/foreman_puppet/environment_test.rb
@@ -319,7 +367,7 @@ requirements: []
 rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
-summary: Adds puppet ENC features
+summary: Add Puppet features to Foreman
 test_files:
 - test/services/foreman_puppet/host_info_providers/config_groups_info_test.rb
 - test/services/foreman_puppet/host_info_providers/puppet_info_test.rb
@@ -329,6 +377,7 @@ test_files:
 - test/integration/foreman_puppet/puppetclass_js_test.rb
 - test/integration/foreman_puppet/hostgroup_js_test.rb
 - test/integration/foreman_puppet/environment_js_test.rb
+- test/integration/foreman_puppet/dashboard_js_test.rb
 - test/integration/foreman_puppet/host_js_test.rb
 - test/graphql/mutations/hosts/create_mutation_test.rb
 - test/graphql/queries/puppetclasses_query_test.rb
@@ -339,6 +388,7 @@ test_files:
 - test/graphql/queries/environment_query_test.rb
 - test/graphql/queries/hostgroup_puppet_query_test.rb
 - test/graphql/queries/environments_query_test.rb
+- test/integration_puppet_helper.rb
 - test/helpers/foreman_puppet/puppetclasses_helper_test.rb
 - test/helpers/foreman_puppet/hosts_and_hostgroups_helper_test.rb
 - test/models/foreman_puppet/config_group_class_test.rb
@@ -379,6 +429,7 @@ test_files:
 - test/controllers/foreman_puppet/api/v2/lookups_common_controller_test.rb
 - test/controllers/foreman_puppet/api/v2/host_classes_controller_test.rb
 - test/controllers/foreman_puppet/api/v2/provisioning_templates_controller_test.rb
+- test/controllers/foreman_puppet/api/v2/smart_proxies_controller_test.rb
 - test/controllers/foreman_puppet/api/v2/puppetclasses_controller_test.rb
 - test/controllers/foreman_puppet/api/v2/hosts_controller_test.rb
 - test/controllers/foreman_puppet/puppetclasses_controller_test.rb

data/db/migrate_foreman/20180816134832_cast_lookup_key_values.rb

@@ -1,35 +0,0 @@
-class CastLookupKeyValues < ActiveRecord::Migration[5.1]
-  def up
-    # Different LookupKey types handle casting a bit differently
-    PuppetclassLookupKey.unscoped.preload(:lookup_values).where(override: true).where.not(key_type: 'string').find_each do |key|
-      cast_key_and_values(key)
-    end
-  end
-
-  private
-
-  def cast_key_and_values(key)
-    fix_value(key, :default_value)
-    key.lookup_values.each do |lv|
-      fix_value(lv, :value)
-    end
-  end
-
-  def safemode_box
-    @safemode_box ||= Safemode::Box.new
-  end
-
-  def fix_value(obj, attribute)
-    return if obj.omit && !obj.try(:merge_default)
-    value = obj.send(attribute)
-    return unless value.is_a? String
-    return if value.contains_erb?
-    fixed = safemode_box.eval(value)
-    obj.update_column(attribute, fixed)
-  rescue StandardError => e
-    say "Failed to cast #{attribute} for #{obj.inspect}:"
-    say "Value: #{value}", subitem: true
-    say "Error: #{e.message}", subitem: true
-    say 'Perhaps it is invalid? Casting skipped, manual action may be needed.', subitem: true
-  end
-end