foreman_puppet 0.1.0 → 1.0.0.rc.1

data/test/{qraphql → graphql}/queries/host_puppet_query_test.rb

@@ -12,9 +12,6 @@ module Queries
           environment {
             id
           }
-          puppetProxy {
-            id
-          }
         }
       }
       GRAPHQL
@@ -23,14 +20,12 @@ module Queries
     let(:host) { FactoryBot.create(:host, :with_puppet_enc) }
     let(:global_id) { Foreman::GlobalId.encode('Host', host.id) }
     let(:variables) { { id: global_id } }
+    let(:data) { result['data']['host'] }
 
     test 'fetching host attributes' do
-      skip 'GraphQL is TODO'
-      host_data = result['data']['host']
       assert_empty result['errors']
-      assert_equal global_id, host_data['id']
-      assert_record host.environment, host_data['environment']
-      assert_record host.puppet_proxy, host_data['puppetProxy']
+      assert_equal global_id, data['id']
+      assert_record host.environment, data['environment']
     end
   end
 end

data/test/{qraphql → graphql}/queries/hostgroup_puppet_query_test.rb

@@ -12,25 +12,20 @@ module Queries
           environment {
             id
           }
-          puppetProxy {
-            id
-          }
         }
       }
       GRAPHQL
     end
 
-    let(:hostgroup) { FactoryBot.create(:hostgroup, :with_puppet_enc) }
+    let(:hostgroup) { FactoryBot.create(:hostgroup, :with_puppet_enc, :with_puppetclass) }
     let(:global_id) { Foreman::GlobalId.encode('Hostgroup', hostgroup.id) }
     let(:variables) { { id: global_id } }
 
     test 'fetching host attributes' do
-      skip 'GraphQL is TODO'
       hostgroup_data = result['data']['hostgroup']
       assert_empty result['errors']
       assert_equal global_id, hostgroup_data['id']
       assert_record hostgroup.puppet.environment, hostgroup_data['environment']
-      assert_record hostgroup.puppet_proxy, hostgroup_data['puppetProxy']
     end
   end
 end

data/test/graphql/queries/location_query_test.rb

@@ -0,0 +1,52 @@
+require 'test_puppet_helper'
+
+module Queries
+  class LocationQueryTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query (
+        $id: String!
+      ) {
+        location(id: $id) {
+          id
+          environments {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+          puppetclasses {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:environment) { FactoryBot.create(:environment) }
+    let(:location_object) { FactoryBot.create(:location, environments: [environment]) }
+
+    let(:global_id) { Foreman::GlobalId.for(location_object) }
+    let(:variables) { { id: global_id } }
+    let(:data) { result['data']['location'] }
+
+    setup do
+      FactoryBot.create(:puppetclass, environments: [environment])
+    end
+
+    test 'fetching location attributes' do
+      assert_empty result['errors']
+
+      assert_equal global_id, data['id']
+      assert_collection location_object.environments, data['environments']
+      assert_collection location_object.puppetclasses, data['puppetclasses']
+    end
+  end
+end

data/test/graphql/queries/organization_query_test.rb

@@ -0,0 +1,52 @@
+require 'test_puppet_helper'
+
+module Queries
+  class OrganizationQueryTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query (
+        $id: String!
+      ) {
+        organization(id: $id) {
+          id
+          environments {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+          puppetclasses {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:environment) { FactoryBot.create(:environment) }
+    let(:organization_object) { FactoryBot.create(:organization, environments: [environment]) }
+
+    let(:global_id) { Foreman::GlobalId.for(organization_object) }
+    let(:variables) { { id: global_id } }
+    let(:data) { result['data']['organization'] }
+
+    setup do
+      FactoryBot.create(:puppetclass, environments: [environment])
+    end
+
+    test 'fetching organization attributes' do
+      assert_empty result['errors']
+
+      assert_equal global_id, data['id']
+      assert_collection organization_object.environments, data['environments']
+      assert_collection organization_object.puppetclasses, data['puppetclasses']
+    end
+  end
+end

data/test/graphql/queries/puppetclass_query_test.rb

@@ -0,0 +1,68 @@
+require 'test_puppet_helper'
+
+module Queries
+  class PuppetclassQueryTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query (
+        $id: String!
+      ) {
+        puppetclass(id: $id) {
+          id
+          createdAt
+          updatedAt
+          name
+          environments {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+          locations {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+          organizations {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:environment) { FactoryBot.create(:environment) }
+    let(:puppetclass) { FactoryBot.create(:puppetclass) }
+
+    let(:global_id) { Foreman::GlobalId.for(puppetclass) }
+    let(:variables) { { id: global_id } }
+    let(:data) { result['data']['puppetclass'] }
+
+    setup do
+      FactoryBot.create(:environment_class, puppetclass: puppetclass, environment: environment)
+    end
+
+    test 'fetching puppetclass attributes' do
+      assert_empty result['errors']
+
+      assert_equal global_id, data['id']
+      assert_equal puppetclass.created_at.utc.iso8601, data['createdAt']
+      assert_equal puppetclass.updated_at.utc.iso8601, data['updatedAt']
+      assert_equal puppetclass.name, data['name']
+
+      assert_collection puppetclass.environments, data['environments']
+      assert_collection puppetclass.locations, data['locations']
+      assert_collection puppetclass.organizations, data['organizations']
+    end
+  end
+end

data/test/graphql/queries/puppetclasses_query_test.rb

@@ -0,0 +1,43 @@
+require 'test_puppet_helper'
+
+module Queries
+  class PuppetclassesQueryTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query {
+        puppetclasses {
+          totalCount
+          pageInfo {
+            startCursor
+            endCursor
+            hasNextPage
+            hasPreviousPage
+          }
+          edges {
+            cursor
+            node {
+              id
+            }
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:data) { result['data']['puppetclasses'] }
+
+    setup do
+      FactoryBot.create_list(:puppetclass, 2)
+    end
+
+    test 'fetching puppetclasses attributes' do
+      assert_empty result['errors']
+
+      expected_count = ForemanPuppet::Puppetclass.count
+
+      assert_not_equal 0, expected_count
+      assert_equal expected_count, data['totalCount']
+      assert_equal expected_count, data['edges'].count
+    end
+  end
+end

data/test/integration/foreman_puppet/environment_js_test.rb

@@ -5,6 +5,9 @@ module ForemanPuppet
   class EnvironmentJSTest < IntegrationTestWithJavascript
     include ForemanPuppet::Engine.routes.url_helpers
 
+    let(:environment) { FactoryBot.create(:environment) }
+    setup { environment }
+
     test 'index page' do
       assert_index_page(environments_path, 'Environments', 'Create Puppet Environment')
     end
@@ -18,7 +21,7 @@ module ForemanPuppet
 
     test 'edit page' do
       visit environments_path
-      click_link 'production'
+      click_link environment.name
       fill_in 'environment_name', with: 'production222'
       assert_submit_button(environments_path)
       assert page.has_link? 'production222'

data/test/integration/foreman_puppet/host_js_test.rb

@@ -141,7 +141,7 @@ module ForemanPuppet
         click_on_inherit('puppet_proxy')
         select2(overridden_hostgroup.name, from: 'host_hostgroup_id')
 
-        assert find('#s2id_host_puppet_attributes_environment_id .select2-chosen').has_text? original_hostgroup.environment.name
+        assert find('#s2id_host_puppet_attributes_environment_id .select2-chosen').has_text? original_hostgroup.puppet.environment.name
 
         # On host group change, the disabled select will be reset to an empty value - disabled select2 is invisible on chrome
         assert find('#s2id_host_puppet_proxy_id .select2-chosen', visible: :all).has_text? ''

data/test/integration/foreman_puppet/puppetclass_js_test.rb

@@ -11,6 +11,7 @@ module ForemanPuppet
     let(:puppetclass) { FactoryBot.create(:puppetclass, environments: [environment]) }
 
     test 'edit page' do
+      FactoryBot.create(:puppetclass, name: 'vim', environments: [environment]) if ForemanPuppet.extracted_from_core?
       visit puppetclasses_path
       click_link 'vim'
       assert page.has_no_link? 'Common'

data/test/models/foreman_puppet/config_group_class_test.rb

@@ -4,6 +4,8 @@ module ForemanPuppet
   class ConfigGroupClassTest < ActiveSupport::TestCase
     should validate_presence_of(:config_group)
     should validate_presence_of(:puppetclass)
-    should validate_uniqueness_of(:config_group).scoped_to(:puppetclass_id)
+    # can not validate_uniqueness_of associations
+    # https://github.com/thoughtbot/shoulda-matchers/issues/814
+    # should validate_uniqueness_of(:config_group).scoped_to(:puppetclass_id)
   end
 end

data/test/models/foreman_puppet/environment_test.rb

@@ -2,6 +2,8 @@ require 'test_puppet_helper'
 
 module ForemanPuppet
   class EnvironmentTest < ActiveSupport::TestCase
+    setup { FactoryBot.create(:environment) }
+
     should validate_presence_of(:name)
     should validate_uniqueness_of(:name)
     should have_many(:provisioning_templates).through(:template_combinations)

data/test/models/foreman_puppet/host_test.rb

@@ -79,7 +79,7 @@ module ForemanPuppet
 
       test 'can search hosts by puppet class from config group in parent hostgroup' do
         hostgroup = FactoryBot.create(:hostgroup, :with_puppet_enc)
-        host = FactoryBot.create(:host, :with_puppet_enc, hostgroup: hostgroup, environment: hostgroup.environment)
+        host = FactoryBot.create(:host, :with_puppet_enc, hostgroup: hostgroup, environment: hostgroup.puppet.environment)
         config_group = FactoryBot.create(:config_group, :with_puppetclass)
         hostgroup.puppet.config_groups << config_group
         result = Host.search_for("class = #{config_group.puppetclass_names.first}")
@@ -138,7 +138,8 @@ module ForemanPuppet
     describe '#clone' do
       test '#classes etc. on cloned host return the same' do
         hostgroup = FactoryBot.create(:hostgroup, :with_puppet_enc, :with_config_group, :with_puppetclass)
-        host = FactoryBot.create(:host, :with_puppet_enc, :with_config_group, :with_puppetclass, :with_parameter, hostgroup: hostgroup, environment: hostgroup.environment)
+        host = FactoryBot.create(:host, :with_puppet_enc, :with_config_group, :with_puppetclass, :with_parameter,
+          hostgroup: hostgroup, environment: hostgroup.puppet.environment)
         copy = host.clone
         assert_equal host.puppet.individual_puppetclasses.map(&:id), copy.puppet.individual_puppetclasses.map(&:id)
         assert_equal host.puppet.classes_in_groups.map(&:id), copy.puppet.classes_in_groups.map(&:id)

data/test/models/foreman_puppet/hostgroup_puppet_facet_test.rb

@@ -22,15 +22,14 @@ module ForemanPuppet
     end
 
     test 'changing environment should preserve puppetclasses' do
-      skip 'Something fishy on env update, try once extracted' unless ForemanPuppet.extracted_from_core?
       new_environment = FactoryBot.create(:environment)
-      old_puppetclass_ids = hostgroup.puppet.puppetclass_ids
+      old_puppetclass_ids = hostgroup.puppet.puppetclasses.all
 
       hostgroup.puppet.update!(environment: new_environment)
       hostgroup.reload
 
       assert_equal new_environment, hostgroup.puppet.environment
-      assert_equal old_puppetclass_ids.sort, hostgroup.puppet.puppetclass_ids.sort
+      assert_equal old_puppetclass_ids.sort, hostgroup.puppet.puppetclasses.all
     end
 
     test 'should return all classes for environment only' do

data/test/models/foreman_puppet/provisioning_template_test.rb

@@ -37,7 +37,7 @@ module ForemanPuppet
       assert_equal [], tmplt.template_combinations
     end
 
-    describe 'Association cascading' do
+    describe '#find_template by template_combinations' do
       setup do
         @arch = FactoryBot.create(:architecture)
         medium = FactoryBot.create(:medium, name: 'combo_medium', path: 'http://www.example.com/m')
@@ -74,50 +74,50 @@ module ForemanPuppet
         @ctd.os_default_templates.create(operatingsystem: @os1, template_kind_id: @ctd.template_kind_id)
       end
 
-      test 'find_template finds a matching template with hg and env' do
+      test 'finds a matching template with hg and env' do
         assert_equal @ct1.name,
           ProvisioningTemplate.find_template({ kind: @tk.name,
-            operatingsystem_id: @os1.id,
-            hostgroup_id: @hg1.id,
-            environment_id: @ev1.id }).name
+                                               operatingsystem_id: @os1.id,
+                                               hostgroup_id: @hg1.id,
+                                               environment_id: @ev1.id }).name
       end
 
-      test 'find_template finds a matching template with hg only' do
+      test 'finds a matching template with hg only' do
         assert_equal @ct2.name,
           ProvisioningTemplate.find_template({ kind: @tk.name,
-            operatingsystem_id: @os1.id,
-            hostgroup_id: @hg1.id }).name
+                                               operatingsystem_id: @os1.id,
+                                               hostgroup_id: @hg1.id }).name
       end
 
-      test 'find_template finds a matching template with hg and mismatched env' do
+      test 'finds a matching template with hg and mismatched env' do
         assert_equal @ct2.name,
           ProvisioningTemplate.find_template({ kind: @tk.name,
-            operatingsystem_id: @os1.id,
-            hostgroup_id: @hg1.id,
-            environment_id: @ev3.id }).name
+                                               operatingsystem_id: @os1.id,
+                                               hostgroup_id: @hg1.id,
+                                               environment_id: @ev3.id }).name
       end
 
-      test 'find_template finds a matching template with env only' do
+      test 'finds a matching template with env only' do
         assert_equal @ct3.name,
           ProvisioningTemplate.find_template({ kind: @tk.name,
-            operatingsystem_id: @os1.id,
-            environment_id: @ev1.id }).name
+                                               operatingsystem_id: @os1.id,
+                                               environment_id: @ev1.id }).name
       end
 
-      test 'find_template finds a matching template with env and mismatched hg' do
+      test 'finds a matching template with env and mismatched hg' do
         assert_equal @ct3.name,
           ProvisioningTemplate.find_template({ kind: @tk.name,
-            operatingsystem_id: @os1.id,
-            hostgroup_id: @hg3.id,
-            environment_id: @ev1.id }).name
+                                               operatingsystem_id: @os1.id,
+                                               hostgroup_id: @hg3.id,
+                                               environment_id: @ev1.id }).name
       end
 
-      test 'find_template finds the default template when hg and env do not match' do
+      test 'finds the default template when hg and env do not match' do
         assert_equal @ctd.name,
           ProvisioningTemplate.find_template({ kind: @tk.name,
-            operatingsystem_id: @os1.id,
-            hostgroup_id: @hg3.id,
-            environment_id: @ev3.id }).name
+                                               operatingsystem_id: @os1.id,
+                                               hostgroup_id: @hg3.id,
+                                               environment_id: @ev3.id }).name
       end
     end
   end